)]}'
{
  "commit": "6d4df677f8a60ea6bc0ef1a596c1a3a79b1d4882",
  "tree": "289572805ebba72be476af5d1b89fef32070114d",
  "parents": [
    "7d1362c0d05b8543807ab403ac8ce813cab41fa4"
  ],
  "author": {
    "name": "Alexey Dobriyan",
    "email": "adobriyan@gmail.com",
    "time": "Wed Dec 06 20:40:39 2006 -0800"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@woody.osdl.org",
    "time": "Thu Dec 07 08:39:46 2006 -0800"
  },
  "message": "[PATCH] do_coredump() and not stopping rewrite attacks?\n\nOn Sat, Dec 02, 2006 at 11:47:44PM +0300, Alexey Dobriyan wrote:\n\u003e David Binderman compiled 2.6.19 with icc and grepped for \"was set but never\n\u003e used\". Many warnings are on\n\u003e \thttp://coderock.org/kj/unused-2.6.19-fs\n\nHeh, the very first line:\nfs/exec.c(1465): remark #593: variable \"flag\" was set but never used\n\nfs/exec.c:\n  1477\t\t/*\n  1478\t\t *\tWe cannot trust fsuid as being the \"true\" uid of the\n  1479\t\t *\tprocess nor do we know its entire history. We only know it\n  1480\t\t *\twas tainted so we dump it as root in mode 2.\n  1481\t\t */\n  1482\t\tif (mm-\u003edumpable \u003d\u003d 2) {\t/* Setuid core dump mode */\n  1483\t\t\tflag \u003d O_EXCL;\t\t/* Stop rewrite attacks */\n  1484\t\t\tcurrent-\u003efsuid \u003d 0;\t/* Dump root private */\n  1485\t\t}\n\nAnd then filp_open follows with \"flag\" totally ignored.\n\n(akpm: this restores the code to Alan\u0027s original version.  Andi\u0027s \"Support\npiping into commands in /proc/sys/kernel/core_pattern\" (cset d025c9db) broke\nit).\n\nCc: Alan Cox \u003calan@lxorguk.ukuu.org.uk\u003e\nCc: \u003cstable@kerenl.org\u003e\nCc: Andi Kleen \u003cak@suse.de\u003e\nSigned-off-by: Andrew Morton \u003cakpm@osdl.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@osdl.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2092bd2074635f11e657ad55a20cd6b91737f115",
      "old_mode": 33188,
      "old_path": "fs/exec.c",
      "new_id": "add0e03c3ea908a6baf81d3b16b1065716c5a8ff",
      "new_mode": 33188,
      "new_path": "fs/exec.c"
    }
  ]
}