)]}'
{
  "commit": "784eb99ebad91db4c8c231c4b17f203147ab827b",
  "tree": "49c3e78a7a0f8cc056fe1705b37bae4343fd4915",
  "parents": [
    "58fc73d10f3e92bfcd1e9a8391eb3e49b68df8e5"
  ],
  "author": {
    "name": "Nicholas Bellinger",
    "email": "nab@linux-iscsi.org",
    "time": "Fri Sep 16 01:31:28 2011 -0700"
  },
  "committer": {
    "name": "Nicholas Bellinger",
    "email": "nab@linux-iscsi.org",
    "time": "Fri Sep 16 19:36:56 2011 +0000"
  },
  "message": "target: Skip non hex characters for VPD\u003d0x83 NAA IEEE Registered Extended\n\nThis patch adds target_parse_naa_6h_vendor_specific() to address a bug where the\nconversion of PRODUCT SERIAL NUMBER to use hex2bin() in target_emulate_evpd_83()\nwas not doing proper isxdigit() checking.  This conversion of the vpd_unit_serial\nconfigifs attribute is done while generating a VPD\u003d0x83 NAA IEEE Registered\nExtended DESIGNATOR format\u0027s 100 bits of unique VENDOR SPECIFIC IDENTIFIER +\nVENDOR SPECIFIC IDENTIFIER EXTENSION area.\n\nThis patch allows vpd_unit_serial (VPD\u003d0x80) and the T10 Vendor ID DESIGNATOR\nformat (VPD\u003d0x83) to continue to use free-form variable length ASCII values,\nand now skips any non hex characters for fixed length NAA IEEE Registered Extended\nDESIGNATOR format (VPD\u003d0x83) requring the binary conversion.\n\nThis was originally reported by Martin after the v3.1-rc1 change to use hex2bin()\nin commit 11650b859681e03fdbf26277fcfc5f1f62186703 where the use of non hex\ncharacters in vpd_unit_serial generated different values than the original\nv3.0 internal hex -\u003e binary code.  This v3.1 change caused a problem with\nfilesystems who write a NAA DESIGNATOR onto it\u0027s ondisk metadata, and this patch\nwill (again) change existing values to ensure that non hex characters are not\nincluded in the fixed length NAA DESIGNATOR.\n\nNote this patch still expects vpd_unit_serial to be set via existing userspace\nmethods of uuid generation, and does not do strict formatting via configfs input.\n\nThe original bug report and thread can be found here:\n\nNAA breakage\nhttp://www.spinics.net/lists/target-devel/msg00477.html\n\nThe v3.1-rc1 formatting of VPD\u003d0x83 w/o this patch:\n\nVPD INQUIRY: Device Identification page\n  Designation descriptor number 1, descriptor length: 20\n    designator_type: NAA,  code_set: Binary\n    associated with the addressed logical unit\n      NAA 6, IEEE Company_id: 0x1405\n      Vendor Specific Identifier: 0xffde35ebf\n      Vendor Specific Identifier Extension: 0x3092f498ffa820f9\n      [0x6001405ffde35ebf3092f498ffa820f9]\n  Designation descriptor number 2, descriptor length: 56\n    designator_type: T10 vendor identification,  code_set: ASCII\n    associated with the addressed logical unit\n      vendor id: LIO-ORG\n      vendor specific: IBLOCK:ffde35ec-3092-4980-a820-917636ca54f1\n\nThe v3.1-final formatting of VPD\u003d0x83 w/ this patch:\n\nVPD INQUIRY: Device Identification page\n  Designation descriptor number 1, descriptor length: 20\n    designator_type: NAA,  code_set: Binary\n    associated with the addressed logical unit\n      NAA 6, IEEE Company_id: 0x1405\n      Vendor Specific Identifier: 0xffde35ec3\n      Vendor Specific Identifier Extension: 0x924980a82091763\n      [0x6001405ffde35ec30924980a82091763]\n  Designation descriptor number 2, descriptor length: 56\n    designator_type: T10 vendor identification,  code_set: ASCII\n    associated with the addressed logical unit\n      vendor id: LIO-ORG\n      vendor specific: IBLOCK:ffde35ec-3092-4980-a820-917636ca54f1\n\n(v2: Fix parsing code to dereference + check for string terminator instead\n     of null pointer to ensure a zeroed payload for vpd_unit_serial less\n     than 100 bits of NAA DESIGNATOR VENDOR SPECIFIC area.  Also, remove\n     the unnecessary bitwise assignment)\n\nReported-by: Martin Svec \u003cmartin.svec@zoner.cz\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "89ae923c5da6e28362039fe2fd6a611459747752",
      "old_mode": 33188,
      "old_path": "drivers/target/target_core_cdb.c",
      "new_id": "f04d4ef99dca00893761a3fe7c3b93c9dd6ba519",
      "new_mode": 33188,
      "new_path": "drivers/target/target_core_cdb.c"
    }
  ]
}