)]}'
{
  "commit": "7c9e2b1c4784c6e574f69dbd904b2822f2e04d6e",
  "tree": "4f11b13961671d83128866aa456688c7e437f243",
  "parents": [
    "bdc2bda7c4dd253026cc1fce45fc939304749029"
  ],
  "author": {
    "name": "Dean Nelson",
    "email": "dnelson@redhat.com",
    "time": "Tue Mar 09 22:26:55 2010 -0500"
  },
  "committer": {
    "name": "Jesse Barnes",
    "email": "jbarnes@virtuousgeek.org",
    "time": "Fri Mar 19 12:41:48 2010 -0700"
  },
  "message": "PCI: cleanup error return for pcix get and set mmrbc functions\n\npcix_get_mmrbc() returns the maximum memory read byte count (mmrbc), if\nsuccessful, or an appropriate error value, if not.\n\nDistinguishing errors from correct values and understanding the meaning of an\nerror can be somewhat confusing in that:\n\n\tcorrect values: 512, 1024, 2048, 4096\n\terrors: -EINVAL  \t\t\t-22\n \t\tPCIBIOS_FUNC_NOT_SUPPORTED\t0x81\n\t\tPCIBIOS_BAD_VENDOR_ID\t\t0x83\n\t\tPCIBIOS_DEVICE_NOT_FOUND\t0x86\n\t\tPCIBIOS_BAD_REGISTER_NUMBER\t0x87\n\t\tPCIBIOS_SET_FAILED\t\t0x88\n\t\tPCIBIOS_BUFFER_TOO_SMALL\t0x89\n\nThe PCIBIOS_ errors are returned from the PCI functions generated by the\nPCI_OP_READ() and PCI_OP_WRITE() macros.\n\nIn a similar manner, pcix_set_mmrbc() also returns the PCIBIOS_ error values\nreturned from pci_read_config_[word|dword]() and pci_write_config_word().\n\nFollowing pcix_get_max_mmrbc()\u0027s example, the following patch simply returns\n-EINVAL for all PCIBIOS_ errors encountered by pcix_get_mmrbc(), and -EINVAL\nor -EIO for those encountered by pcix_set_mmrbc().\n\nThis simplification was chosen in light of the fact that none of the current\ncallers of these functions are interested in the specific type of error\nencountered. In the future, should this change, one could simply create a\nfunction that maps each PCIBIOS_ error to a corresponding unique errno value,\nwhich could be called by pcix_get_max_mmrbc(), pcix_get_mmrbc(), and\npcix_set_mmrbc().\n\nAdditionally, this patch eliminates some unnecessary variables.\n\nCc: stable@kernel.org\nSigned-off-by: Dean Nelson \u003cdnelson@redhat.com\u003e\nSigned-off-by: Jesse Barnes \u003cjbarnes@virtuousgeek.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5c80b59c5931d7277ae85d270303c432638ef2dd",
      "old_mode": 33188,
      "old_path": "drivers/pci/pci.c",
      "new_id": "1531f3a498791dd39fb0ce628acd3d09bb67b451",
      "new_mode": 33188,
      "new_path": "drivers/pci/pci.c"
    }
  ]
}