)]}'
{
  "commit": "7d3d5ec168f1f40e8547d2a1659670ef222a053b",
  "tree": "625e980d989829244f47b8e29db251ea6dd4df99",
  "parents": [
    "66da8c529ad4d330a268ac08aa101b87c5c911ff"
  ],
  "author": {
    "name": "Russell King",
    "email": "rmk+kernel@arm.linux.org.uk",
    "time": "Sat Feb 21 23:41:57 2009 -0800"
  },
  "committer": {
    "name": "David S. Miller",
    "email": "davem@davemloft.net",
    "time": "Sat Feb 21 23:41:57 2009 -0800"
  },
  "message": "etherh: Get working again.\n\nFurther to a71558d, this is round five of fixes to make etherh work\nagain. As mainline kernels stand, the fixes in b9a9b4b were the wrong\napproach.\n\nThe 8390 driver was structured by Al Viro to allow the flexibility required\nby platforms.  lib8390.c contains the core code which drivers explicitly\ninclude:\n- 8390.c includes lib8390.c to provide the standard ISA based driver.\n- etherh.c includes it with the accessors defined for RiscPC platforms,\n  where it is addressed via the MMIO accessors with a device dependent\n  register spacing.\n\nOther platform drivers do something similar.\n\nHowever, b9a9b4b caused the kernel to contain not only the etherh private\nbuild of lib8390 (included in etherh.c) but also lib8390.c itself, and\nreferred the new net_device_ops methods to the ISA version.  The result\nof this is is not pretty:\n\nUnable to handle kernel paging request at virtual address 12032030\npgd \u003d c8330000\n[12032030] *pgd\u003d00000000\nInternal error: Oops: 18331805 [#1]\nModules linked in: ipv6\nCPU: 0    Not tainted  (2.6.29-rc3 #167)\nPC is at do_set_multicast_list+0xd0/0x190\nLR is at bitrev32+0x28/0x34\npc : [\u003cc017aab4\u003e]    lr : [\u003cc0139120\u003e]    psr: a0000093\nsp : c8321d9c  ip : c8321d84  fp : c8321dbc\nr10: c80c6800  r9 : 00000000  r8 : c80c6b60\nr7 : c80c6b80  r6 : cc80c800  r5 : c80c6800  r4 : 00000000\nr3 : cc80c80c  r2 : 00000004  r1 : 00000007  r0 : e0000000\nFlags: NzCv  IRQs off  FIQs on  Mode SVC_32  ISA ARM  Segment user\n...\n\nFix up b9a9b4b by making etherh\u0027s net_device_ops refer to the internal\nlib8390 functions, and remove the build of the ISA 8390.c driver.\n\nSigned-off-by: Russell King \u003crmk+kernel@arm.linux.org.uk\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c69c0cdba4a26b1cc254f1ac112cce46171c5f04",
      "old_mode": 33188,
      "old_path": "drivers/net/arm/Makefile",
      "new_id": "811a3ccd14c107c56136af8884022f7cd9f4498f",
      "new_mode": 33188,
      "new_path": "drivers/net/arm/Makefile"
    },
    {
      "type": "modify",
      "old_id": "54b52e5b1821bbcd196b3f2f70cea19c51a5ec37",
      "old_mode": 33188,
      "old_path": "drivers/net/arm/etherh.c",
      "new_id": "f52f668c49bfae5fcf526d299f9368661dd0d32c",
      "new_mode": 33188,
      "new_path": "drivers/net/arm/etherh.c"
    }
  ]
}
