)]}'
{
  "commit": "8e31e607ea050c0df1483d8b6cdd5b1395c03cbe",
  "tree": "0249b18a545d6f8a5d65ccca70a16a722de372a7",
  "parents": [
    "9927c68864e9c39cc317b4f559309ba29e642168"
  ],
  "author": {
    "name": "Salyzyn, Mark",
    "email": "Mark_Salyzyn@adaptec.com",
    "time": "Wed Feb 06 13:54:12 2008 -0800"
  },
  "committer": {
    "name": "James Bottomley",
    "email": "James.Bottomley@HansenPartnership.com",
    "time": "Thu Feb 07 18:31:51 2008 -0600"
  },
  "message": "[SCSI] aacraid: do not set valid bit in sense information\n\nLuben Tuikov [mailto:ltuikov@yahoo.com] sez:\n\u003e Just as in your case and Tony\u0027s case, which I presume\n\u003e uses the same RAID firmware vendor, it would\u0027ve\n\u003e probably been better if the RAID firmware vendor\n\u003e fixed the firmware to not set the VALID bit if the\n\u003e INFORMATION field is not valid.\n\nPoint taken regarding the aacraid driver. Dropped the VALID bit, and\nthen did some cleanup/simplification of the set_sense procedure and\nthe associated parameters. Mike did some preliminary tests when the\nVALID bit was dropped before the \u0027Re: [PATCH] [SCSI] sd: make error\nhandling more robust\u0027 patches came on the scene. The change in the\nSCSI subsystem does make this enclosed aacraid patch unnecessary, so\nthis aacraid patch is merely post battle ground cleanup. If the\nsimplification is an issue, repugnant, too much for a back-port to the\nstable trees or clouds the point, this patch could be happily\ndistilled down to:\n\ndiff -ru a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c\n--- a/drivers/scsi/aacraid/aachba.c     2008-02-06 16:26:45.834938955 -0500\n+++ b/drivers/scsi/aacraid/aachba.c     2008-02-06 16:32:01.109035329 -0500\n@@ -865,7 +865,7 @@\n                         u32 residue)\n {\n-        sense_buf[0] \u003d 0xF0;    /* Sense data valid, err code 70h (current error) */\n+        sense_buf[0] \u003d 0x70;    /* Sense data invalid, err code 70h (current error) */\n         sense_buf[1] \u003d 0;       /* Segment number, always zero */\n\n         if (incorrect_length) {\n\nSigned-off-by: Mark Salyzyn \u003caacraid@adaptec.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@HansenPartnership.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d7235f42cf5faa730792415727e4998dbbd1cbc2",
      "old_mode": 33188,
      "old_path": "drivers/scsi/aacraid/aachba.c",
      "new_id": "bfd0e64964accc6e8317c50338725d4fc8db6ad5",
      "new_mode": 33188,
      "new_path": "drivers/scsi/aacraid/aachba.c"
    }
  ]
}