| commit | 8e64159dfb480b30233d947d5a3cd793dfea738f | [log] [tgz] |
|---|---|---|
| author | Kulikov Vasiliy <segooon@gmail.com> | Sat Jul 17 05:21:00 2010 +0000 |
| committer | David S. Miller <davem@davemloft.net> | Sun Jul 18 15:07:14 2010 -0700 |
| tree | 81e564d8f12fe7c8a7b9819572a1f1787c1d224e | |
| parent | bfc978fa5f3005e5dfb39c52393c3339f4f00233 [diff] |
net: dccp: fix sign bug
'gap' is unsigned, so this code is wrong:
gap = -new_head;
...
if (gap > 0) { ... }
Make 'gap' signed.
The semantic patch that finds this problem (many false-positive results):
(http://coccinelle.lip6.fr/)
// <smpl>
@ r1 @
identifier f;
@@
int f(...) { ... }
@@
identifier r1.f;
type T;
unsigned T x;
@@
*x = f(...)
...
*x > 0
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>