commit bafeafeab94b8d3019aac15c2df2ce47b08a6363
author Rusty Russell <rusty@rustcorp.com.au> Fri Jan 13 09:32:16 2012 +1030
committer Rusty Russell <rusty@rustcorp.com.au> Fri Jan 13 09:32:16 2012 +1030
tree c121e82aee4f0969cf90dfb2dbad46d06a669696
parent e49ce14150c64b29a8dd211df785576fa19a9858

module_param: check type correctness for module_param_array

module_param_array(), unlike its non-array cousins, didn't check the type
of the variable.  Fixing this found two bugs.

Cc: Luca Risolia <luca.risolia@studio.unibo.it>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Eric Piel <eric.piel@tremplin-utc.net>
Cc: linux-media@vger.kernel.org
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

include/linux/moduleparam.h

diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
index 7939f63..794d4b0 100644
--- a/include/linux/moduleparam.h
+++ b/include/linux/moduleparam.h
@@ -395,6 +395,7 @@
  * module_param_named() for why this might be necessary.
  */
 #define module_param_array_named(name, array, type, nump, perm)		\
+	param_check_##type(name, &(array)[0]);				\
 	static const struct kparam_array __param_arr_##name		\
 	= { .max = ARRAY_SIZE(array), .num = nump,                      \
 	    .ops = &param_ops_##type,					\