)]}'
{
  "commit": "bb617ee3f82ba94072c8b08043d9166bbfe397a2",
  "tree": "2ad6d51e5d84fc765a3fd35b4e73f1fc37bd1def",
  "parents": [
    "8a8d56b2a2f9aa423c3d8b6b1e2792c0492059ed"
  ],
  "author": {
    "name": "Jesper Juhl",
    "email": "jj@chaosbits.net",
    "time": "Fri Oct 29 22:54:45 2010 +0200"
  },
  "committer": {
    "name": "Takashi Iwai",
    "email": "tiwai@suse.de",
    "time": "Mon Nov 01 10:26:23 2010 +0100"
  },
  "message": "ALSA: cs46xx memory management fixes for cs46xx_dsp_spos_create()\n\nWhen reading through sound/pci/cs46xx/dsp_spos.c I noticed a couple of\nthings in cs46xx_dsp_spos_create().\n\nIt seems to me that we don\u0027t always free the various memory buffers we\nallocate and we also do some work (structure member assignment) early,\nthat is completely pointless if some of the memory allocations fail and\nwe end up just aborting the whole thing.\n\nI don\u0027t have hardware to test, so the patch below is compile tested only,\nbut it makes the following changes:\n\n- Make sure we always free all allocated memory on failures.\n- Don\u0027t do pointless work assigning to structure members before we know\n  all memory allocations, that may abort progress, have completed\n  successfully.\n- Remove some trailing whitespace.\n\nSigned-off-by: Jesper Juhl \u003cjj@chaosbits.net\u003e\nTested-by: Ondrej Zary \u003clinux@rainbow-software.org\u003e\nSigned-off-by: Takashi Iwai \u003ctiwai@suse.de\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3e5ca8fb519ff1ae5d2c03cf7f2beb8700b1745d",
      "old_mode": 33188,
      "old_path": "sound/pci/cs46xx/dsp_spos.c",
      "new_id": "e377287192aae954aa42d153cb9931f0934f67b4",
      "new_mode": 33188,
      "new_path": "sound/pci/cs46xx/dsp_spos.c"
    }
  ]
}
