)]}'
{
  "commit": "bca476139d2ded86be146dae09b06e22548b67f3",
  "tree": "50a894c3ccce5f2f629a8e535a8bd6132f759ef9",
  "parents": [
    "0813e22d4e0d618eac9b47bec942bf856adca4c5"
  ],
  "author": {
    "name": "Dick Hollenbeck",
    "email": "dick@softplc.com",
    "time": "Wed Dec 09 12:31:34 2009 -0800"
  },
  "committer": {
    "name": "Greg Kroah-Hartman",
    "email": "gregkh@suse.de",
    "time": "Tue Feb 16 15:55:51 2010 -0800"
  },
  "message": "serial: 8250: add serial transmitter fully empty test\n\nWhen controlling an industrial radio modem it can be necessary to\nmanipulate the handshake lines in order to control the radio modem\u0027s\ntransmitter, from userspace.\n\nThe transmitter should not be turned off before all characters have been\ntransmitted.  serial8250_tx_empty() was reporting that all characters were\ntransmitted before they actually were.\n\n\u003d\u003d\u003d\n\nDiscovered in parallel with more testing and analysis by Kees Schoenmakers\nas follows:\n\nI ran into an NetMos 9835 serial pci board which behaves a little\ndifferent than the standard.  This type of expansion board is very common.\n\n\"Standard\" 8250 compatible devices clear the \u0027UART_LST_TEMT\" bit together\nwith the \"UART_LSR_THRE\" bit when writing data to the device.\n\nThe NetMos device does it slightly different\n\nI believe that the TEMT bit is coupled to the shift register.  The problem\nis that after writing data to the device and very quickly after that one\ndoes call serial8250_tx_empty, it returns the wrong information.\n\nMy patch makes the test more robust (and solves the problem) and it does\nnot affect the already correct devices.\n\nAlan:\n\n  We may yet need to quirk this but now we know which chips we have a\n  way to do that should we find this breaks some other 8250 clone with\n  dodgy THRE.\n\nSigned-off-by: Dick Hollenbeck \u003cdick@softplc.com\u003e\nSigned-off-by: Alan Cox \u003calan@linux.intel.com\u003e\nCc: Kees Schoenmakers \u003ck.schoenmakers@sigmae.nl\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nCc: stable \u003cstable@kernel.org\u003e\nSigned-off-by: Greg Kroah-Hartman \u003cgregkh@suse.de\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c3e37c8e7e26a8b8ecc4a767561aea15b2378909",
      "old_mode": 33188,
      "old_path": "drivers/serial/8250.c",
      "new_id": "e9b15c3746fa0307bc91c929c929374efd0f1bea",
      "new_mode": 33188,
      "new_path": "drivers/serial/8250.c"
    }
  ]
}
