)]}'
{
  "commit": "bf0b48dfc368c07c42b5a3a5658c8ee81b4283ac",
  "tree": "7174e3ce995d6deaefb76027bc1a6265ccd25d11",
  "parents": [
    "bf1b803b01b00c3801e0aa373ba0305f8278e260"
  ],
  "author": {
    "name": "Brian Haley",
    "email": "brian.haley@hp.com",
    "time": "Mon Oct 08 00:12:05 2007 -0700"
  },
  "committer": {
    "name": "David S. Miller",
    "email": "davem@davemloft.net",
    "time": "Mon Oct 08 00:12:05 2007 -0700"
  },
  "message": "[IPv6]: Fix ICMPv6 redirect handling with target multicast address\n\nWhen the ICMPv6 Target address is multicast, Linux processes the \nredirect instead of dropping it.  The problem is in this code in \nndisc_redirect_rcv():\n\n         if (ipv6_addr_equal(dest, target)) {\n                 on_link \u003d 1;\n         } else if (!(ipv6_addr_type(target) \u0026 IPV6_ADDR_LINKLOCAL)) {\n                 ND_PRINTK2(KERN_WARNING\n                            \"ICMPv6 Redirect: target address is not \nlink-local.\\n\");\n                 return;\n         }\n\nThis second check will succeed if the Target address is, for example, \nFF02::1 because it has link-local scope.  Instead, it should be checking \nif it\u0027s a unicast link-local address, as stated in RFC 2461/4861 Section \n8.1:\n\n       - The ICMP Target Address is either a link-local address (when\n         redirected to a router) or the same as the ICMP Destination\n         Address (when redirected to the on-link destination).\n\nI know this doesn\u0027t explicitly say unicast link-local address, but it\u0027s \nimplied.\n\nThis bug is preventing Linux kernels from achieving IPv6 Logo Phase II \ncertification because of a recent error that was found in the TAHI test \nsuite - Neighbor Disovery suite test 206 (v6LC.2.3.6_G) had the \nmulticast address in the Destination field instead of Target field, so \nwe were passing the test.  This won\u0027t be the case anymore.\n\nThe patch below fixes this problem, and also fixes ndisc_send_redirect() \nto not send an invalid redirect with a multicast address in the Target \nfield.  I re-ran the TAHI Neighbor Discovery section to make sure Linux \npasses all 245 tests now.\n\nSigned-off-by: Brian Haley \u003cbrian.haley@hp.com\u003e\nAcked-by: David L Stevens \u003cdlstevens@us.ibm.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "73a894a2152ca003b9c3de5bed0b8412d8aa42d7",
      "old_mode": 33188,
      "old_path": "net/ipv6/ndisc.c",
      "new_id": "5b596659177cbbd8bd5e6c2db62b803af4ca1817",
      "new_mode": 33188,
      "new_path": "net/ipv6/ndisc.c"
    }
  ]
}