)]}'
{
  "commit": "d3e33ff59facec005e48ba3360502b73a04e4b4e",
  "tree": "7f5b6354d5d6794b35a5ea2bcee33ea16d8e326c",
  "parents": [
    "b5b9309d3415480b3e66314a1d6c89db58bff9de"
  ],
  "author": {
    "name": "Bartlomiej Zolnierkiewicz",
    "email": "bzolnier@gmail.com",
    "time": "Tue Aug 05 18:16:59 2008 +0200"
  },
  "committer": {
    "name": "Bartlomiej Zolnierkiewicz",
    "email": "bzolnier@gmail.com",
    "time": "Tue Aug 05 18:16:59 2008 +0200"
  },
  "message": "ide: fix regression caused by ide_device_{get,put}() addition (take 2)\n\nOn Monday 28 July 2008, Benjamin Herrenschmidt wrote:\n\n[...]\n\n\u003e Vector: 300 (Data Access) at [c58b7b80]\n\u003e     pc: c014f264: elv_may_queue+0x10/0x44\n\u003e     lr: c0152750: get_request+0x2c/0x2c0\n\u003e     sp: c58b7c30\n\u003e    msr: 1032\n\u003e    dar: c\n\u003e  dsisr: 40000000\n\u003e   current \u003d 0xc58aaae0\n\u003e     pid   \u003d 854, comm \u003d media-bay\n\u003e enter ? for help\n\u003e mon\u003e t\n\u003e [c58b7c40] c0152750 get_request+0x2c/0x2c0\n\u003e [c58b7c70] c0152a08 get_request_wait+0x24/0xec\n\u003e [c58b7cc0] c0225674 ide_cd_queue_pc+0x58/0x1a0\n\u003e [c58b7d40] c022672c ide_cdrom_packet+0x9c/0xdc\n\u003e [c58b7d70] c0261810 cdrom_get_disc_info+0x60/0xd0\n\u003e [c58b7dc0] c026208c cdrom_mrw_exit+0x1c/0x11c\n\u003e [c58b7e30] c0260f7c unregister_cdrom+0x84/0xe8\n\u003e [c58b7e50] c022395c ide_cd_release+0x80/0x84\n\u003e [c58b7e70] c0163650 kref_put+0x54/0x6c\n\u003e [c58b7e80] c0223884 ide_cd_put+0x40/0x5c\n\u003e [c58b7ea0] c0211100 generic_ide_remove+0x28/0x3c\n\u003e [c58b7eb0] c01e9d34 __device_release_driver+0x78/0xb4\n\u003e [c58b7ec0] c01e9e44 device_release_driver+0x28/0x44\n\u003e [c58b7ee0] c01e8f7c bus_remove_device+0xac/0xd8\n\u003e [c58b7f00] c01e7424 device_del+0x104/0x198\n\u003e [c58b7f20] c01e74d0 device_unregister+0x18/0x30\n\u003e [c58b7f40] c02121c4 __ide_port_unregister_devices+0x6c/0x88\n\u003e [c58b7f60] c0212398 ide_port_unregister_devices+0x38/0x80\n\u003e [c58b7f80] c0208ca4 media_bay_step+0x1cc/0x5c0\n\u003e [c58b7fb0] c0209124 media_bay_task+0x8c/0xcc\n\u003e [c58b7fd0] c00485c0 kthread+0x48/0x84\n\u003e [c58b7ff0] c0011b20 kernel_thread+0x44/0x60\n\nThe guilty commit turned out to be 08da591e14cf87247ec09b17c350235157a92fc3\n(\"ide: add ide_device_{get,put}() helpers\").  ide_device_put() is called\nbefore kref_put() in ide_cd_put() so IDE device is already gone by the time\nide_cd_release() is reached.\n\nFix it by calling ide_device_get() before kref_get() and ide_device_put()\nafter kref_put() in all affected device drivers.\n\nv2:\nBrown paper bag time.  In v1 cd-\u003edrive was referenced after dropping last\nreference on cd object (which could result in OOPS in ide_device_put() as\nreported/debugged by Mariusz Kozlowski).  Fix it by caching cd-\u003edrive in\nthe local variable (fix other device drivers too).\n\nReported-by: Benjamin Herrenschmidt \u003cbenh@kernel.crashing.org\u003e\nReported-by: Mariusz Kozlowski \u003cm.kozlowski@tuxland.pl\u003e\nCc: FUJITA Tomonori \u003cfujita.tomonori@lab.ntt.co.jp\u003e\nCc: Borislav Petkov \u003cpetkovbb@gmail.com\u003e\nTested-by: Mariusz Kozlowski \u003cm.kozlowski@tuxland.pl\u003e\nTested-by: Benjamin Herrenschmidt \u003cbenh@kernel.crashing.org\u003e\nSigned-off-by: Bartlomiej Zolnierkiewicz \u003cbzolnier@gmail.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "e617cf08aef67b882370f3f596694df2f465e3f4",
      "old_mode": 33188,
      "old_path": "drivers/ide/ide-cd.c",
      "new_id": "e19caa1453a3e6a61ddb52c0c8d92e75af240d61",
      "new_mode": 33188,
      "new_path": "drivers/ide/ide-cd.c"
    },
    {
      "type": "modify",
      "old_id": "28d85b410f7ce03361ddec4c957c930a9aa08518",
      "old_mode": 33188,
      "old_path": "drivers/ide/ide-disk.c",
      "new_id": "68b9cf0138b05f017427b24c958750bd77356ee8",
      "new_mode": 33188,
      "new_path": "drivers/ide/ide-disk.c"
    },
    {
      "type": "modify",
      "old_id": "ca11a26746f16a95fa83d6d99288d42c01281a1c",
      "old_mode": 33188,
      "old_path": "drivers/ide/ide-floppy.c",
      "new_id": "e9034c0125f3e32440d2d0d2a9de9fd067eada09",
      "new_mode": 33188,
      "new_path": "drivers/ide/ide-floppy.c"
    },
    {
      "type": "modify",
      "old_id": "82c2afe4d28a3a081a30fd5755de01fb17fc2e44",
      "old_mode": 33188,
      "old_path": "drivers/ide/ide-tape.c",
      "new_id": "1bce84b566304115c2834a1742f03284e2c25ce9",
      "new_mode": 33188,
      "new_path": "drivers/ide/ide-tape.c"
    },
    {
      "type": "modify",
      "old_id": "b40a673985aa66fd2fe5310945b2993a0aa2feb2",
      "old_mode": 33188,
      "old_path": "drivers/scsi/ide-scsi.c",
      "new_id": "461331d3dc45f041fd23bb8c02cc0f87b6737fe8",
      "new_mode": 33188,
      "new_path": "drivers/scsi/ide-scsi.c"
    }
  ]
}