)]}' { "log": [ { "commit": "3de0ef4f2067da58fa5126d821a56dcb98cdb565", "tree": "d88103aaf3e5ed019afef5b11d4241ecf3eb1cea", "parents": [ "cdc321ff0af78e818c97d4787f62bf52bdf9db2a" ], "author": { "name": "Wei Yongjun", "email": "yjwei@cn.fujitsu.com", "time": "Wed Oct 14 20:54:03 2009 +0800" }, "committer": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Sun Oct 18 15:49:38 2009 -0400" }, "message": "inotify: fix coalesce duplicate events into a single event in special case\n\nIf we do rename a dir entry, like this:\n\n rename(\"/tmp/ino7UrgoJ.rename1\", \"/tmp/ino7UrgoJ.rename2\")\n rename(\"/tmp/ino7UrgoJ.rename2\", \"/tmp/ino7UrgoJ\")\n\nThe duplicate events should be coalesced into a single event. But those two\nevents do not be coalesced into a single event, due to some bad check in\nevent_compare(). It can not match the two NULL inodes as the same event.\n\nSigned-off-by: Wei Yongjun \u003cyjwei@cn.fujitsu.com\u003e\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\n" }, { "commit": "cd94c8bbef8d4b796a7ed4c551355a334604fd36", "tree": "ac448f253eb01a7fd1872daa15938b5d72fee796", "parents": [ "eef3a116be11d35396efb2a8cc7345fd3221e294" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Sun Aug 16 21:51:49 2009 -0400" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Aug 17 13:37:37 2009 -0700" }, "message": "inotify: tail drop inotify q_overflow events\n\nIn f44aebcc the tail drop logic of events with no file backing\n(q_overflow and in_ignored) was reversed so IN_IGNORED events would\nnever be tail dropped. This now means that Q_OVERFLOW events are NOT\ntail dropped. The fix is to not tail drop IN_IGNORED, but to tail drop\nQ_OVERFLOW.\n\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "eef3a116be11d35396efb2a8cc7345fd3221e294", "tree": "2a5d0b36dd5985f29eac43f51b03e610e40b7c9b", "parents": [ "0f66f96d21b4bbff49baaa337546e687d7c58e87" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Sun Aug 16 21:51:44 2009 -0400" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Aug 17 13:37:37 2009 -0700" }, "message": "notify: unused event private race\n\ninotify decides if private data it passed to get added to an event was\nused by checking list_empty(). But it\u0027s possible that the event may\nhave been dequeued and the private event removed so it would look empty.\n\nThe fix is to use the return code from fsnotify_add_notify_event rather\nthan looking at the list.\n\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f44aebcc566d1d6275f7191867b9633dc11de2ee", "tree": "a5faaf5ca8e1360f359ee22ad29582992596c3e6", "parents": [ "c05594b62125c528d93af3a78229793aae36df7f" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Wed Jul 15 15:49:52 2009 -0400" }, "committer": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Tue Jul 21 15:26:27 2009 -0400" }, "message": "inotify: use GFP_NOFS under potential memory pressure\n\ninotify can have a watchs removed under filesystem reclaim.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n[ INFO: inconsistent lock state ]\n2.6.31-rc2 #16\n---------------------------------\ninconsistent {IN-RECLAIM_FS-W} -\u003e {RECLAIM_FS-ON-W} usage.\nkhubd/217 [HC0[0]:SC0[0]:HE1:SE1] takes:\n (iprune_mutex){+.+.?.}, at: [\u003cc10ba899\u003e] invalidate_inodes+0x20/0xe3\n{IN-RECLAIM_FS-W} state was registered at:\n [\u003cc10536ab\u003e] __lock_acquire+0x2c9/0xac4\n [\u003cc1053f45\u003e] lock_acquire+0x9f/0xc2\n [\u003cc1308872\u003e] __mutex_lock_common+0x2d/0x323\n [\u003cc1308c00\u003e] mutex_lock_nested+0x2e/0x36\n [\u003cc10ba6ff\u003e] shrink_icache_memory+0x38/0x1b2\n [\u003cc108bfb6\u003e] shrink_slab+0xe2/0x13c\n [\u003cc108c3e1\u003e] kswapd+0x3d1/0x55d\n [\u003cc10449b5\u003e] kthread+0x66/0x6b\n [\u003cc1003fdf\u003e] kernel_thread_helper+0x7/0x10\n [\u003cffffffff\u003e] 0xffffffff\n\nTwo things are needed to fix this. First we need a method to tell\nfsnotify_create_event() to use GFP_NOFS and second we need to stop using\none global IN_IGNORED event and allocate them one at a time. This solves\ncurrent issues with multiple IN_IGNORED on a queue having tail drop\nproblems and simplifies the allocations since we don\u0027t have to worry about\ntwo tasks opperating on the IGNORED event concurrently.\n\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\n" }, { "commit": "c05594b62125c528d93af3a78229793aae36df7f", "tree": "2e9b2ba0ea63d3587cb3c6dc7d72e7a202aade52", "parents": [ "4a148ba988988b9c400ad0f2cbccc155289b954b" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Mon Jul 13 15:56:55 2009 -0400" }, "committer": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Tue Jul 21 15:26:26 2009 -0400" }, "message": "fsnotify: fix inotify tail drop check with path entries\n\nfsnotify drops new events when they are the same as the tail event on the\nqueue to be sent to userspace. The problem is that if the event comes with\na path we forget to break out of the switch statement and fall into the\ncode path which matches on events that do not have any type of file backed\ninformation (things like IN_UNMOUNT and IN_Q_OVERFLOW). The problem is\nthat this code thinks all such events should be dropped. Fix is to add a\nbreak.\n\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\n" }, { "commit": "4a148ba988988b9c400ad0f2cbccc155289b954b", "tree": "e80e3cd0d182721038b1d83a55cbde828c98cb09", "parents": [ "520dc2a526fd681337883b6ff1ddcf7c23b1b063" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Mon Jul 13 15:56:55 2009 -0400" }, "committer": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Tue Jul 21 15:26:26 2009 -0400" }, "message": "inotify: check filename before dropping repeat events\n\ninotify drops events if the last event on the queue is the same as the\ncurrent event. But it does 2 things wrong. First it is comparing old-\u003einode\nwith new-\u003einode. But after an event if put on the queue the -\u003einode is no\nlonger allowed to be used. It\u0027s possible between the last event and this new\nevent the inode could be reused and we would falsely match the inode\u0027s memory\naddress between two differing events.\n\nThe second problem is that when a file is removed fsnotify is passed the\nnegative dentry for the removed object rather than the postive dentry from\nimmediately before the removal. This mean the (broken) inotify tail drop code\nwas matching the NULL -\u003einode of differing events.\n\nThe fix is to check the file name which is stored with events when doing the\ntail drop instead of wrongly checking the address of the stored -\u003einode.\n\nReported-by: Scott James Remnant \u003cscott@ubuntu.com\u003e\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\n" }, { "commit": "e4aff117368cfdd3567ee41844d216d079b55173", "tree": "c467bc38edc7ba3154bbf6875dca635b855e1c8c", "parents": [ "47882c6f51e8ef41fbbe2bbb746a1ea3228dd7ca" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Thu May 21 17:01:50 2009 -0400" }, "committer": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Thu Jun 11 14:57:54 2009 -0400" }, "message": "fsnotify: allow groups to add private data to events\n\ninotify needs per group information attached to events. This patch allows\ngroups to attach private information and implements a callback so that\ninformation can be freed when an event is being destroyed.\n\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\nAcked-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\n" }, { "commit": "47882c6f51e8ef41fbbe2bbb746a1ea3228dd7ca", "tree": "d3dd3e8d0e4d3e3793f32107077839f787e35fcd", "parents": [ "62ffe5dfba056f7ba81d710fee9f28c58a42fdd6" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Thu May 21 17:01:47 2009 -0400" }, "committer": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Thu Jun 11 14:57:54 2009 -0400" }, "message": "fsnotify: add correlations between events\n\nAs part of the standard inotify events it includes a correlation cookie\nbetween two dentry move operations. This patch includes the same behaviour\nin fsnotify events. It is needed so that inotify userspace can be\nimplemented on top of fsnotify.\n\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\nAcked-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\n" }, { "commit": "62ffe5dfba056f7ba81d710fee9f28c58a42fdd6", "tree": "ac0d4afc641bdc8ff76779545fde9c6ae539bdaf", "parents": [ "a2d8bc6cb4a3024661baf877242f123787d0c054" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Thu May 21 17:01:43 2009 -0400" }, "committer": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Thu Jun 11 14:57:53 2009 -0400" }, "message": "fsnotify: include pathnames with entries when possible\n\nWhen inotify wants to send events to a directory about a child it includes\nthe name of the original file. This patch collects that filename and makes\nit available for notification.\n\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\nAcked-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\n" }, { "commit": "a2d8bc6cb4a3024661baf877242f123787d0c054", "tree": "4ff3f93877a8992d5383c14fb6012ab9b1954660", "parents": [ "3c5119c05d624f95f4967d16b38c9624b816bdb9" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Thu May 21 17:01:37 2009 -0400" }, "committer": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Thu Jun 11 14:57:53 2009 -0400" }, "message": "fsnotify: generic notification queue and waitq\n\ninotify needs to do asyc notification in which event information is stored\non a queue until the listener is ready to receive it. This patch\nimplements a generic notification queue for inotify (and later fanotify) to\nstore events to be sent at a later time.\n\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\nAcked-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\n" }, { "commit": "90586523eb4b349806887c62ee70685a49415124", "tree": "2ba6da637f897bbb2309b141b81801e4151d87b0", "parents": [ "c9059598ea8981d02356eead3188bf7fa4d717b8" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Thu May 21 17:01:20 2009 -0400" }, "committer": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Thu Jun 11 14:57:52 2009 -0400" }, "message": "fsnotify: unified filesystem notification backend\n\nfsnotify is a backend for filesystem notification. fsnotify does\nnot provide any userspace interface but does provide the basis\nneeded for other notification schemes such as dnotify. fsnotify\ncan be extended to be the backend for inotify or the upcoming\nfanotify. fsnotify provides a mechanism for \"groups\" to register for\nsome set of filesystem events and to then deliver those events to\nthose groups for processing.\n\nfsnotify has a number of benefits, the first being actually shrinking the size\nof an inode. Before fsnotify to support both dnotify and inotify an inode had\n\n unsigned long i_dnotify_mask; /* Directory notify events */\n struct dnotify_struct *i_dnotify; /* for directory notifications */\n struct list_head inotify_watches; /* watches on this inode */\n struct mutex inotify_mutex; /* protects the watches list\n\nBut with fsnotify this same functionallity (and more) is done with just\n\n __u32 i_fsnotify_mask; /* all events for this inode */\n struct hlist_head i_fsnotify_mark_entries; /* marks on this inode */\n\nThat\u0027s right, inotify, dnotify, and fanotify all in 64 bits. We used that\nmuch space just in inotify_watches alone, before this patch set.\n\nfsnotify object lifetime and locking is MUCH better than what we have today.\ninotify locking is incredibly complex. See 8f7b0ba1c8539 as an example of\nwhat\u0027s been busted since inception. inotify needs to know internal semantics\nof superblock destruction and unmounting to function. The inode pinning and\nvfs contortions are horrible.\n\nno fsnotify implementers do allocation under locks. This means things like\nf04b30de3 which (due to an overabundance of caution) changes GFP_KERNEL to\nGFP_NOFS can be reverted. There are no longer any allocation rules when using\nor implementing your own fsnotify listener.\n\nfsnotify paves the way for fanotify. In brief fanotify is a notification\nmechanism that delivers the lisener both an \u0027event\u0027 and an open file descriptor\nto the object in question. This means that fanotify is pathname agnostic.\nSome on lkml may not care for the original companies or users that pushed for\nTALPA, but fanotify was designed with flexibility and input for other users in\nmind. The readahead group expressed interest in fanotify as it could be used\nto profile disk access on boot without breaking the audit system. The desktop\nsearch groups have also expressed interest in fanotify as it solves a number\nof the race conditions and problems present with managing inotify when more\nthan a limited number of specific files are of interest. fanotify can provide\nfor a userspace access control system which makes it a clean interface for AV\nvendors to hook without trying to do binary patching on the syscall table,\nLSM, and everywhere else they do their things today. With this patch series\nfanotify can be implemented in less than 1200 lines of easy to review code.\nAlmost all of which is the socket based user interface.\n\nThis patch series builds fsnotify to the point that it can implement\ndnotify and inotify_user. Patches exist and will be sent soon after\nacceptance to finish the in kernel inotify conversion (audit) and implement\nfanotify.\n\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\nAcked-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\n" } ] }