)]}' { "log": [ { "commit": "2d8f30380ab8c706f4e0a8f1aaa22b5886e9ac8a", "tree": "b798097fd831eab39f35c8c2e5a8ccfd7a850ef5", "parents": [ "256984a83880ff7ac78055cb87baea48137f0b77" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Tue Jul 22 09:59:21 2008 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sat Jul 26 20:53:34 2008 -0400" }, "message": "[PATCH] sanitize __user_walk_fd() et.al.\n\n* do not pass nameidata; struct path is all the callers want.\n* switch to new helpers:\n\tuser_path_at(dfd, pathname, flags, \u0026path)\n\tuser_path(pathname, \u0026path)\n\tuser_lpath(pathname, \u0026path)\n\tuser_path_dir(pathname, \u0026path) (fail if not a directory)\n The last 3 are trivial macro wrappers for the first one.\n* remove nameidata in callers.\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "f419a2e3b64def707e1384ee38abb77f99af5f6d", "tree": "adbe12c510f04cf25ca6f822ee8004c8679a3a63", "parents": [ "30524472c2f728c20d6bf35191042a5d455c0a64" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Tue Jul 22 00:07:17 2008 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sat Jul 26 20:53:31 2008 -0400" }, "message": "[PATCH] kill nameidata passing to permission(), rename to inode_permission()\n\nIncidentally, the name that gives hundreds of false positives on grep\nis not a good idea...\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "beb29e058c35ab69e96e455a12ccf7505f6de425", "tree": "0da9869b7e0422c34423a02216db1a758a55a95a", "parents": [ "b1da47e29e467f1ec36dc78d009bfb109fd533c7" ], "author": { "name": "Miklos Szeredi", "email": "mszeredi@suse.cz", "time": "Tue Jul 01 15:01:29 2008 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sat Jul 26 20:53:28 2008 -0400" }, "message": "[patch 4/4] vfs: immutable inode checking cleanup\n\nMove the immutable and append-only checks from chmod, chown and utimes\ninto notify_change(). Checks for immutable and append-only files are\nalways performed by the VFS and not by the filesystem (see\npermission() and may_...() in namei.c), so these belong in\nnotify_change(), and not in inode_change_ok().\n\nThis should be completely equivalent.\n\nCC: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nCC: Michael Kerrisk \u003cmtk.manpages@gmail.com\u003e\nSigned-off-by: Miklos Szeredi \u003cmszeredi@suse.cz\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "e9b76fedc61235da80b6b7f81dfd67ec224dfb49", "tree": "550aa17f359ac24b4d5720e8fa77f171d338bb25", "parents": [ "9767d74957450da6365c363d69e3d02d605d7375" ], "author": { "name": "Miklos Szeredi", "email": "mszeredi@suse.cz", "time": "Tue Jul 01 15:01:27 2008 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sat Jul 26 20:53:26 2008 -0400" }, "message": "[patch 2/4] vfs: utimes cleanup\n\nUntange the mess that is do_utimes(). Add kerneldoc comment to\ndo_utimes().\n\nCC: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nCC: Michael Kerrisk \u003cmtk.manpages@gmail.com\u003e\nSigned-off-by: Miklos Szeredi \u003cmszeredi@suse.cz\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "9767d74957450da6365c363d69e3d02d605d7375", "tree": "913afe491d13b42b0cfcb540569080bba4725dfd", "parents": [ "88b387824fdaecb6ba0f471acf0aadf7d24739fd" ], "author": { "name": "Miklos Szeredi", "email": "mszeredi@suse.cz", "time": "Tue Jul 01 15:01:26 2008 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sat Jul 26 20:53:25 2008 -0400" }, "message": "[patch 1/4] vfs: utimes: move owner check into inode_change_ok()\n\nAdd a new ia_valid flag: ATTR_TIMES_SET, to handle the\nUTIMES_OMIT/UTIMES_NOW and UTIMES_NOW/UTIMES_OMIT cases. In these\ncases neither ATTR_MTIME_SET nor ATTR_ATIME_SET is in the flags, yet\nthe POSIX draft specifies that permission checking is performed the\nsame way as if one or both of the times was explicitly set to a\ntimestamp.\n\nSee the path \"vfs: utimensat(): fix error checking for\n{UTIME_NOW,UTIME_OMIT} case\" by Michael Kerrisk for the patch\nintroducing this behavior.\n\nThis is a cleanup, as well as allowing filesystems (NFS/fuse/...) to\nperform their own permission checking instead of the default.\n\nCC: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nCC: Michael Kerrisk \u003cmtk.manpages@gmail.com\u003e\nSigned-off-by: Miklos Szeredi \u003cmszeredi@suse.cz\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "c70f84417429f41519be0197a1092a53c2201f47", "tree": "50f5e12bc51dab519da6006e6197091e8cf00092", "parents": [ "4cca92264e61a90b43fc4e076cd25b7f4e16dc61" ], "author": { "name": "Michael Kerrisk", "email": "mtk.manpages@googlemail.com", "time": "Mon Jun 09 21:16:09 2008 -0700" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Jun 23 08:43:52 2008 -0400" }, "message": "[patch for 2.6.26 4/4] vfs: utimensat(): fix write access check for futimens()\n\nThe POSIX.1 draft spec for futimens()/utimensat() says:\n\n Only a process with the effective user ID equal to the\n user ID of the file, *or with write access to the file*,\n or with appropriate privileges may use futimens() or\n utimensat() with a null pointer as the times argument\n or with both tv_nsec fields set to the special value\n UTIME_NOW.\n\nThe important piece here is \"with write access to the file\", and\nthis matters for futimens(), which deals with an argument that\nis a file descriptor referring to the file whose timestamps are\nbeing updated, The standard is saying that the \"writability\"\ncheck is based on the file permissions, not the access mode with\nwhich the file is opened. (This behavior is consistent with the\nsemantics of FreeBSD\u0027s futimes().) However, Linux is currently\ndoing the latter -- futimens(fd, times) is a library\nfunction implemented as\n\n utimensat(fd, NULL, times, 0)\n\nand within the utimensat() implementation we have the code:\n\n f \u003d fget(dfd); // dfd is \u0027fd\u0027\n ...\n if (f) {\n if (!(f-\u003ef_mode \u0026 FMODE_WRITE))\n goto mnt_drop_write_and_out;\n\nThe check should instead be based on the file permissions.\n\nThanks to Miklos for pointing out how to do this check.\nMiklos also pointed out a simplification that could be\nmade to my first version of this patch, since the checks\nfor the pathname and file descriptor cases can now be\nconflated.\n\nAcked-by: Miklos Szeredi \u003cmiklos@szeredi.hu\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nSigned-off-by: Michael Kerrisk \u003cmtk.manpages@gmail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "4cca92264e61a90b43fc4e076cd25b7f4e16dc61", "tree": "f7472b3dc27101761b92bb05ffff7785a73317f3", "parents": [ "94c70b9ba7e9c1036284e779e2fef5be89021533" ], "author": { "name": "Michael Kerrisk", "email": "mtk.manpages@googlemail.com", "time": "Mon Jun 09 21:16:08 2008 -0700" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Jun 23 08:43:04 2008 -0400" }, "message": "[patch for 2.6.26 3/4] vfs: utimensat(): fix error checking for {UTIME_NOW,UTIME_OMIT} case\n\nThe POSIX.1 draft spec for utimensat() says:\n\n Only a process with the effective user ID equal to the\n user ID of the file or with appropriate privileges may use\n futimens() or utimensat() with a non-null times argument\n that does not have both tv_nsec fields set to UTIME_NOW\n and does not have both tv_nsec fields set to UTIME_OMIT.\n\nIf this condition is violated, then the error EPERM should result.\nHowever, the current implementation does not generate EPERM if\none tv_nsec field is UTIME_NOW while the other is UTIME_OMIT.\nIt should give this error for that case.\n\nThis patch:\n\na) Repairs that problem.\nb) Removes the now unneeded nsec_special() helper function.\nc) Adds some comments to explain the checks that are being\n performed.\n\nThanks to Miklos, who provided comments on the previous iteration\nof this patch. As a result, this version is a little simpler and\nand its logic is better structured.\n\nMiklos suggested an alternative idea, migrating the\nis_owner_or_cap() checks into fs/attr.c:inode_change_ok() via\nthe use of an ATTR_OWNER_CHECK flag. Maybe we could do that\nlater, but for now I\u0027ve gone with this version, which is\nIMO simpler, and can be more easily read as being correct.\n\nAcked-by: Miklos Szeredi \u003cmiklos@szeredi.hu\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nSigned-off-by: Michael Kerrisk \u003cmtk.manpages@gmail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "94c70b9ba7e9c1036284e779e2fef5be89021533", "tree": "ae304528dfe2f31d21380e98d7575e43797b75d8", "parents": [ "12fd0d3088d27867be68655bcab2b074f2835f60" ], "author": { "name": "Michael Kerrisk", "email": "mtk.manpages@googlemail.com", "time": "Mon Jun 09 21:16:05 2008 -0700" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Jun 23 08:43:04 2008 -0400" }, "message": "[patch for 2.6.26 1/4] vfs: utimensat(): ignore tv_sec if tv_nsec \u003d\u003d UTIME_OMIT or UTIME_NOW\n\nThe POSIX.1 draft spec for utimensat() says that if a times[n].tv_nsec\nfield is UTIME_OMIT or UTIME_NOW, then the value in the corresponding\ntv_sec field is ignored. See the last sentence of this para, from\nthe spec:\n\n If the tv_nsec field of a timespec structure has\n the special value UTIME_NOW, the file\u0027s relevant\n timestamp shall be set to the greatest value\n supported by the file system that is not greater than\n the current time. If the tv_nsec field has the\n special value UTIME_OMIT, the file\u0027s relevant\n timestamp shall not be changed. In either case,\n the tv_sec field shall be ignored.\n\nHowever the current Linux implementation requires the tv_sec value to be\nzero (or the EINVAL error results). This requirement should be removed.\n\nAcked-by: Miklos Szeredi \u003cmiklos@szeredi.hu\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nSigned-off-by: Michael Kerrisk \u003cmtk.manpages@gmail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "12fd0d3088d27867be68655bcab2b074f2835f60", "tree": "088cf4d5ffc4f4f094b443f1186250403d296132", "parents": [ "fe6e9c1f25ac01f848bd084ee0ee62a5a0966ff3" ], "author": { "name": "Michael Kerrisk", "email": "mtk.manpages@googlemail.com", "time": "Mon Jun 09 21:16:07 2008 -0700" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Jun 23 08:43:03 2008 -0400" }, "message": "[patch for 2.6.26 2/4] vfs: utimensat(): be consistent with utime() for immutable and append-only files\n\nThis patch fixes utimensat() to make its behavior consistent\nwith that of utime()/utimes() when dealing with files marked\nimmutable and append-only.\n\nThe current utimensat() implementation also returns EPERM if\n\u0027times\u0027 is non-NULL and the tv_nsec fields are both UTIME_NOW.\nFor consistency, the\n\n(times !\u003d NULL \u0026\u0026 times[0].tv_nsec \u003d\u003d UTIME_NOW \u0026\u0026\n times[1].tv_nsec \u003d\u003d UTIME_NOW)\n\ncase should be treated like the traditional utimes() case where\n\u0027times\u0027 is NULL. That is, the call should succeed for a file\nmarked append-only and should give the error EACCES if the file\nis marked as immutable.\n\nThe simple way to do this is to set \u0027times\u0027 to NULL\nif (times[0].tv_nsec \u003d\u003d UTIME_NOW \u0026\u0026 times[1].tv_nsec \u003d\u003d UTIME_NOW).\n\nThis is also the natural approach, since POSIX.1 semantics consider the\ntimes \u003d\u003d {{x, UTIME_NOW}, {y, UTIME_NOW}}\nto be exactly equivalent to the case for\ntimes \u003d\u003d NULL.\n\n(Thanks to Miklos for pointing this out.)\n\nPatch 3 in this series relies on the simplification provided\nby this patch.\n\nAcked-by: Miklos Szeredi \u003cmiklos@szeredi.hu\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nSigned-off-by: Michael Kerrisk \u003cmtk.manpages@gmail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "02c6be615f1fcd37ac5ed93a3ad6692ad8991cd9", "tree": "9c5047ed8b165a3388d5c61b2702f7cc12954766", "parents": [ "2850699c59d513a0cd0c68f60f75609a5f9d4d32" ], "author": { "name": "Miklos Szeredi", "email": "mszeredi@suse.cz", "time": "Thu May 01 04:34:45 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu May 01 08:03:59 2008 -0700" }, "message": "vfs: fix permission checking in sys_utimensat\n\nIf utimensat() is called with both times set to UTIME_NOW or one of them to\nUTIME_NOW and the other to UTIME_OMIT, then it will update the file time\nwithout any permission checking.\n\nI don\u0027t think this can be used for anything other than a local DoS, but could\nbe quite bewildering at that (e.g. \"Why was that large source tree rebuilt\nwhen I didn\u0027t modify anything???\")\n\nThis affects all kernels from 2.6.22, when the utimensat() syscall was\nintroduced.\n\nFix by doing the same permission checking as for the \"times \u003d\u003d NULL\" case.\n\nThanks to Michael Kerrisk, whose utimensat-non-conformances-and-fixes.patch in\n-mm also fixes this (and breaks other stuff), only he didn\u0027t realize the\nsecurity implications of this bug.\n\nSigned-off-by: Miklos Szeredi \u003cmszeredi@suse.cz\u003e\nCc: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nCc: Michael Kerrisk \u003cmtk-manpages@gmx.net\u003e\nCc: \u003cstable@kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "74f9fdfa1f229284ee1ea58fa47f2cdeeb12f6fe", "tree": "6f368c91caf23e1795645d018c8ac971a4dceada", "parents": [ "cdb70f3f74b31576cc4d707a3d3b00d159cab8bb" ], "author": { "name": "Dave Hansen", "email": "haveblue@us.ibm.com", "time": "Fri Feb 15 14:37:42 2008 -0800" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sat Apr 19 00:29:24 2008 -0400" }, "message": "[PATCH] r/o bind mounts: elevate write count for do_utimes()\n\nNow includes fix for oops seen by akpm.\n\n\"never let a libc developer write your kernel code\" - hch\n\n\"nor, apparently, a kernel developer\" - akpm\n\nAcked-by: Al Viro \u003cviro@ZenIV.linux.org.uk\u003e\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nCc: Valdis Kletnieks \u003cValdis.Kletnieks@vt.edu\u003e\nCc: Balbir Singh \u003cbalbir@in.ibm.com\u003e\nSigned-off-by: Dave Hansen \u003chaveblue@us.ibm.com\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "1d957f9bf87da74f420424d16ece005202bbebd3", "tree": "363d4770c0c74a536524c99ccd2762ce96ee9bbe", "parents": [ "4ac9137858e08a19f29feac4e1f4df7c268b0ba5" ], "author": { "name": "Jan Blunck", "email": "jblunck@suse.de", "time": "Thu Feb 14 19:34:35 2008 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@woody.linux-foundation.org", "time": "Thu Feb 14 21:13:33 2008 -0800" }, "message": "Introduce path_put()\n\n* Add path_put() functions for releasing a reference to the dentry and\n vfsmount of a struct path in the right order\n\n* Switch from path_release(nd) to path_put(\u0026nd-\u003epath)\n\n* Rename dput_path() to path_put_conditional()\n\n[akpm@linux-foundation.org: fix cifs]\nSigned-off-by: Jan Blunck \u003cjblunck@suse.de\u003e\nSigned-off-by: Andreas Gruenbacher \u003cagruen@suse.de\u003e\nAcked-by: Christoph Hellwig \u003chch@lst.de\u003e\nCc: \u003clinux-fsdevel@vger.kernel.org\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Steven French \u003csfrench@us.ibm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4ac9137858e08a19f29feac4e1f4df7c268b0ba5", "tree": "f5b5d84fd12fcc2b0ba0e7ce1a79ff381ad8f5dd", "parents": [ "c5e725f33b733a77de622e91b6ba5645fcf070be" ], "author": { "name": "Jan Blunck", "email": "jblunck@suse.de", "time": "Thu Feb 14 19:34:32 2008 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@woody.linux-foundation.org", "time": "Thu Feb 14 21:13:33 2008 -0800" }, "message": "Embed a struct path into struct nameidata instead of nd-\u003e{dentry,mnt}\n\nThis is the central patch of a cleanup series. In most cases there is no good\nreason why someone would want to use a dentry for itself. This series reflects\nthat fact and embeds a struct path into nameidata.\n\nTogether with the other patches of this series\n- it enforced the correct order of getting/releasing the reference count on\n \u003cdentry,vfsmount\u003e pairs\n- it prepares the VFS for stacking support since it is essential to have a\n struct path in every place where the stack can be traversed\n- it reduces the overall code size:\n\nwithout patch series:\n text data bss dec hex filename\n5321639 858418 715768 6895825 6938d1 vmlinux\n\nwith patch series:\n text data bss dec hex filename\n5320026 858418 715768 6894212 693284 vmlinux\n\nThis patch:\n\nSwitch from nd-\u003e{dentry,mnt} to nd-\u003epath.{dentry,mnt} everywhere.\n\n[akpm@linux-foundation.org: coding-style fixes]\n[akpm@linux-foundation.org: fix cifs]\n[akpm@linux-foundation.org: fix smack]\nSigned-off-by: Jan Blunck \u003cjblunck@suse.de\u003e\nSigned-off-by: Andreas Gruenbacher \u003cagruen@suse.de\u003e\nAcked-by: Christoph Hellwig \u003chch@lst.de\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Casey Schaufler \u003ccasey@schaufler-ca.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "12c2ab5e8fdfde67f3f6778a366cbdef06de410d", "tree": "181a80de95fe57517a74e5a08f4f7457b71910ff", "parents": [ "011e3fcd1e1f14ef54db30b93404ab7caa726477" ], "author": { "name": "Adrian Bunk", "email": "bunk@kernel.org", "time": "Wed Feb 06 01:36:47 2008 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@woody.linux-foundation.org", "time": "Wed Feb 06 10:41:03 2008 -0800" }, "message": "fs/utimes.c should #include \u003clinux/syscalls.h\u003e\n\nEvery file should include the headers containing the prototypes for its global\nfunctions.\n\nSigned-off-by: Adrian Bunk \u003cbunk@kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "043f46f6151df2c518988b5e41376e42491257b5", "tree": "036f75b27d139408da721aaa75ed41a9b737a83d", "parents": [ "995e4286a047b32aebf8ce540908edb7fbd93f76" ], "author": { "name": "Miklos Szeredi", "email": "mszeredi@suse.cz", "time": "Tue Oct 16 23:27:07 2007 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@woody.linux-foundation.org", "time": "Wed Oct 17 08:42:52 2007 -0700" }, "message": "VFS: check nanoseconds in utimensat\n\nutimensat() (and possibly other callers of do_utimes()) didn\u0027t check if the\nnanosecond value was within the allowed range.\n\nSigned-off-by: Miklos Szeredi \u003cmszeredi@suse.cz\u003e\nCc: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3bd858ab1c451725c07a805dcb315215dc85b86e", "tree": "5d49c4300e350d64fd81eb3230b81f754117e0c1", "parents": [ "49c13b51a15f1ba9f6d47e26e4a3886c4f3931e2" ], "author": { "name": "Satyam Sharma", "email": "ssatyam@cse.iitk.ac.in", "time": "Tue Jul 17 15:00:08 2007 +0530" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@woody.linux-foundation.org", "time": "Tue Jul 17 12:00:03 2007 -0700" }, "message": "Introduce is_owner_or_cap() to wrap CAP_FOWNER use with fsuid check\n\nIntroduce is_owner_or_cap() macro in fs.h, and convert over relevant\nusers to it. This is done because we want to avoid bugs in the future\nwhere we check for only effective fsuid of the current task against a\nfile\u0027s owning uid, without simultaneously checking for CAP_FOWNER as\nwell, thus violating its semantics.\n[ XFS uses special macros and structures, and in general looked ...\nuntouchable, so we leave it alone -- but it has been looked over. ]\n\nThe (current-\u003efsuid !\u003d inode-\u003ei_uid) check in generic_permission() and\nexec_permission_lite() is left alone, because those operations are\ncovered by CAP_DAC_OVERRIDE and CAP_DAC_READ_SEARCH. Similarly operations\nfalling under the purview of CAP_CHOWN and CAP_LEASE are also left alone.\n\nSigned-off-by: Satyam Sharma \u003cssatyam@cse.iitk.ac.in\u003e\nCc: Al Viro \u003cviro@ftp.linux.org.uk\u003e\nAcked-by: Serge E. Hallyn \u003cserge@hallyn.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5b37696fda07b8acf37beba3853f83106397ccdf", "tree": "5f85c318eb7d76ce05adf504c4e209978a70ad47", "parents": [ "9793c3266755b4cae8915982825b2c07cd12e1c6" ], "author": { "name": "Satyam Sharma", "email": "ssatyam@cse.iitk.ac.in", "time": "Tue Jul 17 00:24:23 2007 +0530" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@woody.linux-foundation.org", "time": "Mon Jul 16 12:14:08 2007 -0700" }, "message": "utime(s): Honour CAP_FOWNER when times\u003d\u003dNULL\n\ndo_utimes() does not honour CAP_FOWNER when times\u003d\u003dNULL.\nTrivial and obvious one-line fix.\n\nSigned-off-by: Satyam Sharma \u003cssatyam@cse.iitk.ac.in\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1e5de2837c166535f9bb4232bfe97ea1f9fc7a1c", "tree": "333a9686bbebefd85e1854f1b234a0fc0f75d77b", "parents": [ "4e99325b462ba18075768582621af74a6b79d2a5" ], "author": { "name": "Linus Torvalds", "email": "torvalds@woody.linux-foundation.org", "time": "Sun Jul 08 12:02:55 2007 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@woody.linux-foundation.org", "time": "Sun Jul 08 12:02:55 2007 -0700" }, "message": "Fix permission checking for the new utimensat() system call\n\nCommit 1c710c896eb461895d3c399e15bb5f20b39c9073 added the utimensat()\nsystem call, but didn\u0027t handle the case of checking for the writability\nof the target right, when the target was a file descriptor, not a\nfilename.\n\nWe cannot use vfs_permission(MAY_WRITE) for that case, and need to\nsimply check whether the file descriptor is writable. The oops from\nusing the wrong function was noticed and narrowed down by Markus\nTrippelsdorf.\n\nCc: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nCc: Markus Trippelsdorf \u003cmarkus@trippelsdorf.de\u003e\nCc: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nAcked-by: Al Viro \u003cviro@ftp.linux.org.uk\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1c710c896eb461895d3c399e15bb5f20b39c9073", "tree": "862e210cc6dad50abffd7640f01d50c3e9f3d375", "parents": [ "ade5fb818fb1861fd5f84619c761920ade762b5d" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Tue May 08 00:33:25 2007 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@woody.linux-foundation.org", "time": "Tue May 08 11:15:18 2007 -0700" }, "message": "utimensat implementation\n\nImplement utimensat(2) which is an extension to futimesat(2) in that it\n\na) supports nano-second resolution for the timestamps\nb) allows to selectively ignore the atime/mtime value\nc) allows to selectively use the current time for either atime or mtime\nd) supports changing the atime/mtime of a symlink itself along the lines\n of the BSD lutimes(3) functions\n\nFor this change the internally used do_utimes() functions was changed to\naccept a timespec time value and an additional flags parameter.\n\nAdditionally the sys_utime function was changed to match compat_sys_utime\nwhich already use do_utimes instead of duplicating the work.\n\nAlso, the completely missing futimensat() functionality is added. We have\nsuch a function in glibc but we have to resort to using /proc/self/fd/* which\nnot everybody likes (chroot etc).\n\nTest application (the syscall number will need per-arch editing):\n\n#include \u003cerrno.h\u003e\n#include \u003cfcntl.h\u003e\n#include \u003ctime.h\u003e\n#include \u003csys/time.h\u003e\n#include \u003cstddef.h\u003e\n#include \u003csyscall.h\u003e\n\n#define __NR_utimensat 280\n\n#define UTIME_NOW ((1l \u003c\u003c 30) - 1l)\n#define UTIME_OMIT ((1l \u003c\u003c 30) - 2l)\n\nint\nmain(void)\n{\n int status \u003d 0;\n\n int fd \u003d open(\"ttt\", O_RDWR|O_CREAT|O_EXCL, 0666);\n if (fd \u003d\u003d -1)\n error (1, errno, \"failed to create test file \\\"ttt\\\"\");\n\n struct stat64 st1;\n if (fstat64 (fd, \u0026st1) !\u003d 0)\n error (1, errno, \"fstat failed\");\n\n struct timespec t[2];\n t[0].tv_sec \u003d 0;\n t[0].tv_nsec \u003d 0;\n t[1].tv_sec \u003d 0;\n t[1].tv_nsec \u003d 0;\n if (syscall(__NR_utimensat, AT_FDCWD, \"ttt\", t, 0) !\u003d 0)\n error (1, errno, \"utimensat failed\");\n\n struct stat64 st2;\n if (fstat64 (fd, \u0026st2) !\u003d 0)\n error (1, errno, \"fstat failed\");\n\n if (st2.st_atim.tv_sec !\u003d 0 || st2.st_atim.tv_nsec !\u003d 0)\n {\n puts (\"atim not reset to zero\");\n status \u003d 1;\n }\n if (st2.st_mtim.tv_sec !\u003d 0 || st2.st_mtim.tv_nsec !\u003d 0)\n {\n puts (\"mtim not reset to zero\");\n status \u003d 1;\n }\n if (status !\u003d 0)\n goto out;\n\n t[0] \u003d st1.st_atim;\n t[1].tv_sec \u003d 0;\n t[1].tv_nsec \u003d UTIME_OMIT;\n if (syscall(__NR_utimensat, AT_FDCWD, \"ttt\", t, 0) !\u003d 0)\n error (1, errno, \"utimensat failed\");\n\n if (fstat64 (fd, \u0026st2) !\u003d 0)\n error (1, errno, \"fstat failed\");\n\n if (st2.st_atim.tv_sec !\u003d st1.st_atim.tv_sec\n || st2.st_atim.tv_nsec !\u003d st1.st_atim.tv_nsec)\n {\n puts (\"atim not set\");\n status \u003d 1;\n }\n if (st2.st_mtim.tv_sec !\u003d 0 || st2.st_mtim.tv_nsec !\u003d 0)\n {\n puts (\"mtim changed from zero\");\n status \u003d 1;\n }\n if (status !\u003d 0)\n goto out;\n\n t[0].tv_sec \u003d 0;\n t[0].tv_nsec \u003d UTIME_OMIT;\n t[1] \u003d st1.st_mtim;\n if (syscall(__NR_utimensat, AT_FDCWD, \"ttt\", t, 0) !\u003d 0)\n error (1, errno, \"utimensat failed\");\n\n if (fstat64 (fd, \u0026st2) !\u003d 0)\n error (1, errno, \"fstat failed\");\n\n if (st2.st_atim.tv_sec !\u003d st1.st_atim.tv_sec\n || st2.st_atim.tv_nsec !\u003d st1.st_atim.tv_nsec)\n {\n puts (\"mtim changed from original time\");\n status \u003d 1;\n }\n if (st2.st_mtim.tv_sec !\u003d st1.st_mtim.tv_sec\n || st2.st_mtim.tv_nsec !\u003d st1.st_mtim.tv_nsec)\n {\n puts (\"mtim not set\");\n status \u003d 1;\n }\n if (status !\u003d 0)\n goto out;\n\n sleep (2);\n\n t[0].tv_sec \u003d 0;\n t[0].tv_nsec \u003d UTIME_NOW;\n t[1].tv_sec \u003d 0;\n t[1].tv_nsec \u003d UTIME_NOW;\n if (syscall(__NR_utimensat, AT_FDCWD, \"ttt\", t, 0) !\u003d 0)\n error (1, errno, \"utimensat failed\");\n\n if (fstat64 (fd, \u0026st2) !\u003d 0)\n error (1, errno, \"fstat failed\");\n\n struct timeval tv;\n gettimeofday(\u0026tv,NULL);\n\n if (st2.st_atim.tv_sec \u003c\u003d st1.st_atim.tv_sec\n || st2.st_atim.tv_sec \u003e tv.tv_sec)\n {\n puts (\"atim not set to NOW\");\n status \u003d 1;\n }\n if (st2.st_mtim.tv_sec \u003c\u003d st1.st_mtim.tv_sec\n || st2.st_mtim.tv_sec \u003e tv.tv_sec)\n {\n puts (\"mtim not set to NOW\");\n status \u003d 1;\n }\n\n if (symlink (\"ttt\", \"tttsym\") !\u003d 0)\n error (1, errno, \"cannot create symlink\");\n\n t[0].tv_sec \u003d 0;\n t[0].tv_nsec \u003d 0;\n t[1].tv_sec \u003d 0;\n t[1].tv_nsec \u003d 0;\n if (syscall(__NR_utimensat, AT_FDCWD, \"tttsym\", t, AT_SYMLINK_NOFOLLOW) !\u003d 0)\n error (1, errno, \"utimensat failed\");\n\n if (lstat64 (\"tttsym\", \u0026st2) !\u003d 0)\n error (1, errno, \"lstat failed\");\n\n if (st2.st_atim.tv_sec !\u003d 0 || st2.st_atim.tv_nsec !\u003d 0)\n {\n puts (\"symlink atim not reset to zero\");\n status \u003d 1;\n }\n if (st2.st_mtim.tv_sec !\u003d 0 || st2.st_mtim.tv_nsec !\u003d 0)\n {\n puts (\"symlink mtim not reset to zero\");\n status \u003d 1;\n }\n if (status !\u003d 0)\n goto out;\n\n t[0].tv_sec \u003d 1;\n t[0].tv_nsec \u003d 0;\n t[1].tv_sec \u003d 1;\n t[1].tv_nsec \u003d 0;\n if (syscall(__NR_utimensat, fd, NULL, t, 0) !\u003d 0)\n error (1, errno, \"utimensat failed\");\n\n if (fstat64 (fd, \u0026st2) !\u003d 0)\n error (1, errno, \"fstat failed\");\n\n if (st2.st_atim.tv_sec !\u003d 1 || st2.st_atim.tv_nsec !\u003d 0)\n {\n puts (\"atim not reset to one\");\n status \u003d 1;\n }\n if (st2.st_mtim.tv_sec !\u003d 1 || st2.st_mtim.tv_nsec !\u003d 0)\n {\n puts (\"mtim not reset to one\");\n status \u003d 1;\n }\n\n if (status \u003d\u003d 0)\n puts (\"all OK\");\n\n out:\n close (fd);\n unlink (\"ttt\");\n unlink (\"tttsym\");\n\n return status;\n}\n\n[akpm@linux-foundation.org: add missing i386 syscall table entry]\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nCc: Alexey Dobriyan \u003cadobriyan@openvz.org\u003e\nCc: Michael Kerrisk \u003cmtk-manpages@gmx.net\u003e\nCc: \u003clinux-arch@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "914e26379decf1fd984b22e51fd2e4209b7a7f1b", "tree": "4f20ee40e959699e344cdff0e117d309d238f6be", "parents": [ "f6a570333e554b48ad589e7137c77c57809eee81" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Oct 18 13:55:46 2006 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Dec 04 02:00:24 2006 -0500" }, "message": "[PATCH] severing fs.h, radix-tree.h -\u003e sched.h\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "82b0547cfae1fb2ee26cad588f6d49a347d24740", "tree": "67575452152d0e51a573f66053c29c2028f3701e", "parents": [ "52978be636374c4bfb61220b37fa12f55a071c46" ], "author": { "name": "Alexey Dobriyan", "email": "adobriyan@gmail.com", "time": "Sat Sep 30 23:27:22 2006 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@g5.osdl.org", "time": "Sun Oct 01 00:39:19 2006 -0700" }, "message": "[PATCH] Create fs/utimes.c\n\n* fs/open.c is getting bit crowdy\n* preparation to lutimes(2)\n\nSigned-off-by: Alexey Dobriyan \u003cadobriyan@gmail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@osdl.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@osdl.org\u003e\n" } ] }