)]}' { "log": [ { "commit": "a9c667f8f0656631ee5438baaf21bf30d5f67375", "tree": "eb92465fcb50126802b66fb509ed51a1fe966ad5", "parents": [ "c03f8aa9abdd517477c2021ea1251939b4da49e6" ], "author": { "name": "Lukas Czerner", "email": "lczerner@redhat.com", "time": "Mon Jun 06 09:51:52 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jun 06 09:51:52 2011 -0400" }, "message": "ext4: fixed tracepoints cleanup\n\nWhile creating fixed tracepoints for ext3, basically by porting them\nfrom ext4, I found a lot of useless retyping, wrong type usage, useless\nvariable passing and other inconsistencies in the ext4 fixed tracepoint\ncode.\n\nThis patch cleans the fixed tracepoint code for ext4 and also simplify\nsome of them.\n\nSigned-off-by: Lukas Czerner \u003clczerner@redhat.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "aa38572954ade525817fe88c54faebf85e5a61c0", "tree": "ef398ec06c97134592f62a49c99f3f80041b427c", "parents": [ "d6e9bd256c88ce5f4b668249e363a74f51393daa" ], "author": { "name": "Christoph Hellwig", "email": "hch@infradead.org", "time": "Fri May 27 06:53:02 2011 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 27 07:04:40 2011 -0400" }, "message": "fs: pass exact type of data dirties to -\u003edirty_inode\n\nTell the filesystem if we just updated timestamp (I_DIRTY_SYNC) or\nanything else, so that the filesystem can track internally if it\nneeds to push out a transaction for fdatasync or not.\n\nThis is just the prototype change with no user for it yet. I plan\nto push large XFS changes for the next merge window, and getting\nthis trivial infrastructure in this window would help a lot to avoid\ntree interdependencies.\n\nAlso remove incorrect comments that -\u003edirty_inode can\u0027t block. That\nhas been changed a long time ago, and many implementations rely on it.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "ae24f28d39610a4810c78185cf599a771cf6ee1f", "tree": "a4969875b6345f6ee3eb8bdf3a0af823cab33e3f", "parents": [ "556b27abf73833923d5cd4be80006292e1b31662" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed May 25 17:39:48 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed May 25 17:39:48 2011 -0400" }, "message": "ext4: Convert ext4 to new truncate calling convention\n\n\nTrivial conversion. Fixup one error handling case calling vmtruncate()\nand remove -\u003etruncate callback. We also fix a bug that IS_IMMUTABLE and\nIS_APPEND files could not be truncated during failed writes. In fact, the\ntest can be completely removed as upper layers do necessary permission\nchecks for truncate in do_sys_[f]truncate() and may_open() anyway.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "a4bb6b64e39abc0e41ca077725f2a72c868e7622", "tree": "0d911caa13d445d64cce5ea37f424bf066731ea6", "parents": [ "e861304b8ed83fe43e36d46794d72641c82d4636" ], "author": { "name": "Allison Henderson", "email": "achender@linux.vnet.ibm.com", "time": "Wed May 25 07:41:50 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed May 25 07:41:50 2011 -0400" }, "message": "ext4: enable \"punch hole\" functionality\n\nThis patch adds new routines: \"ext4_punch_hole\" \"ext4_ext_punch_hole\"\nand \"ext4_ext_check_cache\"\n\nfallocate has been modified to call ext4_punch_hole when the punch hole\nflag is passed. At the moment, we only support punching holes in\nextents, so this routine is pretty much a wrapper for the ext4_ext_punch_hole\nroutine.\n\nThe ext4_ext_punch_hole routine first completes all outstanding writes\nwith the associated pages, and then releases them. The unblock\naligned data is zeroed, and all blocks in between are punched out.\n\nThe ext4_ext_check_cache routine is very similar to ext4_ext_in_cache\nexcept it accepts a ext4_ext_cache parameter instead of a ext4_extent\nparameter. This routine is used by ext4_ext_punch_hole to check and\nsee if a block in a hole that has been cached. The ext4_ext_cache\nparameter is necessary because the members ext4_extent structure are\nnot large enough to hold a 32 bit value. The existing\next4_ext_in_cache routine has become a wrapper to this new function.\n\n[ext4 punch hole patch series 5/5 v7] \n\nSigned-off-by: Allison Henderson \u003cachender@us.ibm.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nReviewed-by: Mingming Cao \u003ccmm@us.ibm.com\u003e\n" }, { "commit": "308488518dfcbe3be250085cd582f5b0c1ce72a9", "tree": "4696b50debf9794f2cbb966cccbedadb93dc996a", "parents": [ "55f020db66ce187fb8c8e4002a94b0eb714da450" ], "author": { "name": "Allison Henderson", "email": "achender@linux.vnet.ibm.com", "time": "Wed May 25 07:41:32 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed May 25 07:41:32 2011 -0400" }, "message": "ext4: add new function ext4_block_zero_page_range()\n\nThis patch modifies the existing ext4_block_truncate_page() function\nwhich was used by the truncate code path, and which zeroes out block\nunaligned data, by adding a new length parameter, and renames it to\next4_block_zero_page_rage(). This function can now be used to zero out the\nhead of a block, the tail of a block, or the middle\nof a block.\n\nThe ext4_block_truncate_page() function is now a wrapper to\next4_block_zero_page_range().\n\n[ext4 punch hole patch series 2/5 v7] \n\nSigned-off-by: Allison Henderson \u003cachender@us.ibm.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nReviewed-by: Mingming Cao \u003ccmm@us.ibm.com\u003e\n" }, { "commit": "55f020db66ce187fb8c8e4002a94b0eb714da450", "tree": "e98214511542f57fa93074be12e27c4819520333", "parents": [ "ae81230686282af745ebb7a74c0332349cb9131a" ], "author": { "name": "Allison Henderson", "email": "achender@linux.vnet.ibm.com", "time": "Wed May 25 07:41:26 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed May 25 07:41:26 2011 -0400" }, "message": "ext4: add flag to ext4_has_free_blocks\n\nThis patch adds an allocation request flag to the ext4_has_free_blocks\nfunction which enables the use of reserved blocks. This will allow a\npunch hole to proceed even if the disk is full. Punching a hole may\nrequire additional blocks to first split the extents.\n\nBecause ext4_has_free_blocks is a low level function, the flag needs\nto be passed down through several functions listed below:\n\next4_ext_insert_extent\next4_ext_create_new_leaf\next4_ext_grow_indepth\next4_ext_split\next4_ext_new_meta_block\next4_mb_new_blocks\next4_claim_free_blocks\next4_has_free_blocks\n\n[ext4 punch hole patch series 1/5 v7]\n\nSigned-off-by: Allison Henderson \u003cachender@us.ibm.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nReviewed-by: Mingming Cao \u003ccmm@us.ibm.com\u003e\n" }, { "commit": "072bd7ea74d4b60149a33967d29666bbd84e7709", "tree": "1d09215dcc30192254e62b84a8515220413cfa40", "parents": [ "28e35e42fb255cbaeee8b9f89643f26fe376374d" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon May 23 15:13:02 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon May 23 15:13:02 2011 -0400" }, "message": "ext4: use truncate_setsize() unconditionally\n\nIn commit c8d46e41 (ext4: Add flag to files with blocks intentionally\npast EOF), if the EOFBLOCKS_FL flag is set, we call ext4_truncate()\nbefore calling vmtruncate(). This caused any allocated but unwritten\nblocks created by calling fallocate() with the FALLOC_FL_KEEP_SIZE\nflag to be dropped. This was done to make to make sure that\nEOFBLOCKS_FL would not be cleared while still leaving blocks past\ni_size allocated. This was not necessary, since ext4_truncate()\nguarantees that blocks past i_size will be dropped, even in the case\nwhere truncate() has increased i_size before calling ext4_truncate().\n\nSo fix this by removing the EOFBLOCKS_FL special case treatment in\next4_setattr(). In addition, use truncate_setsize() followed by a\ncall to ext4_truncate() instead of using vmtruncate(). This is more\nefficient since it skips the call to inode_newsize_ok(), which has\nbeen checked already by inode_change_ok(). This is also in a win in\nthe case where EOFBLOCKS_FL is set since it avoids calling\next4_truncate() twice.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "0e499890c1fd9e0a1bed02002161c4c7873d7489", "tree": "9d45cdd242f399837fd208c39e964ef022703e54", "parents": [ "7cb1a5351da8ac499d965a78e94c79ad27891f43" ], "author": { "name": "Darrick J. Wong", "email": "djwong@us.ibm.com", "time": "Wed May 18 13:55:20 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed May 18 13:55:20 2011 -0400" }, "message": "ext4: wait for writeback to complete while making pages writable\n\nIn order to stabilize pages during disk writes, ext4_page_mkwrite must\nwait for writeback operations to complete before making a page\nwritable. Furthermore, the function must return locked pages, and\nrecheck the writeback status if the page lock is ever dropped. The\n\"someone could wander in\" part of this patch was suggested by Chris\nMason.\n\nSigned-off-by: Darrick J. Wong \u003cdjwong@us.ibm.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "7cb1a5351da8ac499d965a78e94c79ad27891f43", "tree": "b78e2ff5d432f14e2840e8911654789b656b26db", "parents": [ "ed3ce80a52c4658f48ef8fc825bdedf8b3fcaa89" ], "author": { "name": "Darrick J. Wong", "email": "djwong@us.ibm.com", "time": "Wed May 18 13:53:20 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed May 18 13:53:20 2011 -0400" }, "message": "ext4: clean up some wait_on_page_writeback calls\n\nwait_on_page_writeback already checks the writeback bit, so callers of it\nneedn\u0027t do that test.\n\nSigned-off-by: Darrick J. Wong \u003cdjwong@us.ibm.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "00d098822fe215a2f4fd32f244a9055b0b043bfe", "tree": "e111dd4a9eb65cfc862186315e89220b692ddf83", "parents": [ "e8bbe8c401c61408ea226b33b824f231c8f9ccae" ], "author": { "name": "Tao Ma", "email": "boyu.mt@taobao.com", "time": "Mon May 09 10:26:41 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon May 09 10:26:41 2011 -0400" }, "message": "ext4: use s_inodes_per_block directly in __ext4_get_inode_loc\n\nIn __ext4_get_inode_loc, we calculate inodes_per_block every time by\nEXT4_BLOCK_SIZE(sb) / EXT4_INODE_SIZE(sb). AFAICS, this function is a\nhot path for ext4, so we\u0027d better use s_inodes_per_block directly\ninstead of calculating every time.\n\nSigned-off-by: Tao Ma \u003cboyu.mt@taobao.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "a97b52022a73ec12e43f0b2c7d4bd1f40f89c81d", "tree": "1a35544915a5704fa59c63b43e9f46e20be1e296", "parents": [ "18770c7c3a0ccd60017ac76b5d2e7d1f71376b94", "c8205636029fc869278c55b7336053b3e7ae3ef4" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 11 15:45:47 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 11 15:45:47 2011 -0700" }, "message": "Merge branch \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4\n\n* \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4:\n ext4: fix data corruption regression by reverting commit 6de9843dab3f\n ext4: Allow indirect-block file to grow the file size to max file size\n ext4: allow an active handle to be started when freezing\n ext4: sync the directory inode in ext4_sync_parent()\n ext4: init timer earlier to avoid a kernel panic in __save_error_info\n jbd2: fix potential memory leak on transaction commit\n ext4: fix a double free in ext4_register_li_request\n ext4: fix credits computing for indirect mapped files\n ext4: remove unnecessary [cm]time update of quota file\n jbd2: move bdget out of critical section\n" }, { "commit": "c8205636029fc869278c55b7336053b3e7ae3ef4", "tree": "c22b4f2fab37d14d4b81ad5683110075afdc35ea", "parents": [ "f80da1e70f1ffec3825aa0a1d0801f4896e002b6" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun Apr 10 22:30:07 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun Apr 10 22:30:07 2011 -0400" }, "message": "ext4: fix data corruption regression by reverting commit 6de9843dab3f\n\nRevert commit 6de9843dab3f2a1d4d66d80aa9e5782f80977d20, since it\ncaused a data corruption regression with BitTorrent downloads. Thanks\nto Damien for discovering and bisecting to find the problem commit.\n\nhttps://bugzilla.kernel.org/show_bug.cgi?id\u003d32972\n\nReported-by: Damien Grassart \u003cdamien@grassart.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "f80da1e70f1ffec3825aa0a1d0801f4896e002b6", "tree": "42976f4e0fc07da78ffce618b7e98b87d82a2bff", "parents": [ "be4f27d324e8ddd57cc0d4d604fe85ee0425cba9" ], "author": { "name": "Kazuya Mio", "email": "k-mio@sx.jp.nec.com", "time": "Sun Apr 10 22:06:36 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun Apr 10 22:06:36 2011 -0400" }, "message": "ext4: Allow indirect-block file to grow the file size to max file size\n\nWe can create 4402345721856 byte file with indirect block mapping.\nHowever, if we grow an indirect-block file to the size with ftruncate(),\nwe can see an ext4 warning. The following patch fixes this problem.\n\nHow to reproduce:\n# dd if\u003d/dev/zero of\u003d/mnt/mp1/hoge bs\u003d1 count\u003d0 seek\u003d4402345721856\n0+0 records in\n0+0 records out\n0 bytes (0 B) copied, 0.000221428 s, 0.0 kB/s\n# tail -n 1 /var/log/messages\nNov 25 15:10:27 test kernel: EXT4-fs warning (device sda8): ext4_block_to_path:345: block 1074791436 \u003e max in inode 12\n\nSigned-off-by: Kazuya Mio \u003ck-mio@sx.jp.nec.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "5b41395fcc0265fc9f193aef9df39ce49d64677c", "tree": "3e9ce0bc590399f78808fce8279d04c61301beb8", "parents": [ "21f976975cbecbdaf23ceeacc1cab2b1c05a028e" ], "author": { "name": "Yongqiang Yang", "email": "xiaoqiangnk@gmail.com", "time": "Mon Apr 04 15:40:24 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Apr 04 15:40:24 2011 -0400" }, "message": "ext4: fix credits computing for indirect mapped files\n\nWhen writing a contiguous set of blocks, two indirect blocks could be\nneeded depending on how the blocks are aligned, so we need to increase\nthe number of credits needed by one.\n\n[ Also fixed a another bug which could further underestimate the\n number of journal credits needed by 1; the code was using integer\n division instead of DIV_ROUND_UP() -- tytso]\n\nSigned-off-by: Yongqiang Yang \u003cxiaoqiangnk@gmail.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nCc: stable@kernel.org\n" }, { "commit": "25985edcedea6396277003854657b5f3cb31a628", "tree": "f026e810210a2ee7290caeb737c23cb6472b7c38", "parents": [ "6aba74f2791287ec407e0f92487a725a25908067" ], "author": { "name": "Lucas De Marchi", "email": "lucas.demarchi@profusion.mobi", "time": "Wed Mar 30 22:57:33 2011 -0300" }, "committer": { "name": "Lucas De Marchi", "email": "lucas.demarchi@profusion.mobi", "time": "Thu Mar 31 11:26:23 2011 -0300" }, "message": "Fix common misspellings\n\nFixes generated by \u0027codespell\u0027 and manually reviewed.\n\nSigned-off-by: Lucas De Marchi \u003clucas.demarchi@profusion.mobi\u003e\n" }, { "commit": "ae005cbed12d0b340b04b59d6f5c56e710b3895d", "tree": "d464865bcc97bea05eab4eba0d10bcad4ec89b93", "parents": [ "3961cdf85b749f6bab50ad31ee97e9277e7a3b70", "0ba0851714beebb800992e5105a79dc3a4c504b0" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 25 09:57:40 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 25 09:57:41 2011 -0700" }, "message": "Merge branch \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4\n\n* \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4: (43 commits)\n ext4: fix a BUG in mb_mark_used during trim.\n ext4: unused variables cleanup in fs/ext4/extents.c\n ext4: remove redundant set_buffer_mapped() in ext4_da_get_block_prep()\n ext4: add more tracepoints and use dev_t in the trace buffer\n ext4: don\u0027t kfree uninitialized s_group_info members\n ext4: add missing space in printk\u0027s in __ext4_grp_locked_error()\n ext4: add FITRIM to compat_ioctl.\n ext4: handle errors in ext4_clear_blocks()\n ext4: unify the ext4_handle_release_buffer() api\n ext4: handle errors in ext4_rename\n jbd2: add COW fields to struct jbd2_journal_handle\n jbd2: add the b_cow_tid field to journal_head struct\n ext4: Initialize fsync transaction ids in ext4_new_inode()\n ext4: Use single thread to perform DIO unwritten convertion\n ext4: optimize ext4_bio_write_page() when no extent conversion is needed\n ext4: skip orphan cleanup if fs has unknown ROCOMPAT features\n ext4: use the nblocks arg to ext4_truncate_restart_trans()\n ext4: fix missing iput of root inode for some mount error paths\n ext4: make FIEMAP and delayed allocation play well together\n ext4: suppress verbose debugging information if malloc-debug is off\n ...\n\nFi up conflicts in fs/ext4/super.c due to workqueue changes\n" }, { "commit": "6de9843dab3f2a1d4d66d80aa9e5782f80977d20", "tree": "9c78e8d386e117cb890e9823b113dfdc290be580", "parents": [ "0562e0bad483d10e9651fbb8f21dc3d0bad57374" ], "author": { "name": "Feng Tang", "email": "feng.tang@intel.com", "time": "Wed Mar 23 14:05:03 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Mar 23 14:05:03 2011 -0400" }, "message": "ext4: remove redundant set_buffer_mapped() in ext4_da_get_block_prep()\n\nThe map_bh() call will have already set the buffer_head to mapped.\n\nSigned-off-by: Feng Tang \u003cfeng.tang@intel.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "0562e0bad483d10e9651fbb8f21dc3d0bad57374", "tree": "19f6597f92c028badcb6df360ccac22240378e25", "parents": [ "4596fe07679ff0fae904515691ea747467614871" ], "author": { "name": "Jiaying Zhang", "email": "jiayingz@google.com", "time": "Mon Mar 21 21:38:05 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Mar 21 21:38:05 2011 -0400" }, "message": "ext4: add more tracepoints and use dev_t in the trace buffer\n\n- Add more ext4 tracepoints.\n- Change ext4 tracepoints to use dev_t field with MAJOR/MINOR macros\nso that we can save 4 bytes in the ring buffer on some platforms.\n- Add sync_mode to ext4_da_writepages, ext4_da_write_pages, and\next4_da_writepages_result tracepoints. Also remove for_reclaim\nfield from ext4_da_writepages since it is usually not very useful.\n\nSigned-off-by: Jiaying Zhang \u003cjiayingz@google.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "d67d1218344009970ba0deb7eb15a3984518ddd0", "tree": "323e3fb76bdff2481fa35ce3aa82699434dae743", "parents": [ "537a03103c67c4688b1e8e6671ad119aec5e2efb" ], "author": { "name": "Amir Goldstein", "email": "amir73il@gmail.com", "time": "Sun Mar 20 22:59:02 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun Mar 20 22:59:02 2011 -0400" }, "message": "ext4: handle errors in ext4_clear_blocks()\n\nChecking return code from ext4_journal_get_write_access() is important\nwith snapshots, because this function invokes COW, so may return new\nerrors, such as ENOSPC.\n\next4_clear_blocks() now returns \u003c 0 for fatal errors, in which case,\next4_free_data() is aborted.\n\nSigned-off-by: Amir Goldstein \u003camir73il@users.sf.net\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "7eaceaccab5f40bbfda044629a6298616aeaed50", "tree": "33954d12f63e25a47eb6d86ef3d3d0a5e62bf752", "parents": [ "73c101011926c5832e6e141682180c4debe2cf45" ], "author": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Thu Mar 10 08:52:07 2011 +0100" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Thu Mar 10 08:52:07 2011 +0100" }, "message": "block: remove per-queue plugging\n\nCode has been converted over to the new explicit on-stack plugging,\nand delay users have been converted to use the new API for that.\nSo lets kill off the old plugging along with aops-\u003esync_page().\n\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "8e8eaabefee3ff645b9551ee32c6c54c7d80ad19", "tree": "101f4a24a8f57f798a74eb097c424b882f872bf8", "parents": [ "32a9bb57d7c1fd04ae0f72b8f671501f000a0e9f" ], "author": { "name": "Amir Goldstein", "email": "amir73il@gmail.com", "time": "Sun Feb 27 23:32:12 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun Feb 27 23:32:12 2011 -0500" }, "message": "ext4: use the nblocks arg to ext4_truncate_restart_trans()\n\nnblocks is passed into ext4_truncate_restart_trans() from\next4_ext_truncate_extend_restart() with a value different from the default\nblocks_for_truncate(), but is being ignored.\n\nThe two other calls to ext4_truncate_restart_trans() already pass the\ndefault value, which is then being recalculated inside the function.\n\nFix the problem by using the passed argument.\n\nSigned-off-by: Amir Goldstein \u003camir73il@users.sf.net\u003e\n" }, { "commit": "168fc0223c0e944957b1f31d88c2334fc904baf1", "tree": "1768f86cca5cef5ae1ba2275fca7ea9f0c0630d5", "parents": [ "78aaced3408141bb7c836f2db0ca435790399da5" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:09:20 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:09:20 2011 -0500" }, "message": "ext4: move setup of the mpd structure to write_cache_pages_da()\n\nMove the initialization of all of the fields of the mpd structure to\nwrite_cache_pages_da(). This simplifies the code considerably.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "78aaced3408141bb7c836f2db0ca435790399da5", "tree": "c761d397605095d4d895ede9fc5e6a6548723cad", "parents": [ "ee6ecbcc5d73672217fdea420d182ecb0cdf310c" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:09:14 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:09:14 2011 -0500" }, "message": "ext4: don\u0027t lock the next page in write_cache_pages if not needed\n\nIf we have accumulated a contiguous region of memory to be written\nout, and the next page can added to this region, don\u0027t bother locking\n(and then unlocking the page) before writing out the memory. In the\nunlikely event that the next page was being written back by some other\nCPU, we can also skip waiting that page to finish writeback.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "ee6ecbcc5d73672217fdea420d182ecb0cdf310c", "tree": "4d5b960a2feb20ce1b5866739b39c89dec1c49d8", "parents": [ "9749895644a817cfd28a535bc3ae60e4267bdc50" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:08:11 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:08:11 2011 -0500" }, "message": "ext4: remove page_skipped hackery in ext4_da_writepages()\n\nBecause the ext4 page writeback codepath had been prematurely calling\nclear_page_dirty_for_io(), if it turned out that a particular page\ncouldn\u0027t be written out during a particular pass of\nwrite_cache_pages_da(), the page would have to get redirtied by\ncalling redirty_pages_for_writeback(). Not only was this wasted work,\nbut redirty_page_for_writeback() would increment wbc-\u003epages_skipped to\nsignal to writeback_sb_inodes() that buffers were locked, and that it\nshould skip this inode until later.\n\nSince this signal was incorrect in ext4\u0027s case --- which was caused by\next4\u0027s historically incorrect use of write_cache_pages() ---\next4_da_writepages() saved and restored wbc-\u003eskipped_pages to avoid\nconfusing writeback_sb_inodes().\n\nNow that we\u0027ve fixed ext4 to call clear_page_dirty_for_io() right\nbefore initiating the page I/O, we can nuke the page_skipped\nsave/restore hackery, and breathe a sigh of relief.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n\n" }, { "commit": "9749895644a817cfd28a535bc3ae60e4267bdc50", "tree": "a0958777287906320aba461690125d8786ceb565", "parents": [ "4f01b02c8c4e4111bd1adbcafb5741e8e991f5fd" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:08:01 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:08:01 2011 -0500" }, "message": "ext4: clear the dirty bit for a page in writeback at the last minute\n\nMove when we call clear_page_dirty_for_io() to just before we actually\nwrite the page. This simplifies the code somewhat, and avoids marking\npages as clean and then needing to remark them as dirty later.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "4f01b02c8c4e4111bd1adbcafb5741e8e991f5fd", "tree": "4b4793878e26779bf3bfe74028bd8b87de72609e", "parents": [ "8eb9e5ce211de1b98bc84e93258b7db0860a103c" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:07:37 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:07:37 2011 -0500" }, "message": "ext4: simple cleanups to write_cache_pages_da()\n\nEliminate duplicate code, unneeded variables, etc., to make it easier\nto understand the code. No behavioral changes were made in this patch.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "8eb9e5ce211de1b98bc84e93258b7db0860a103c", "tree": "80c5cba007b3f4612524474f1ec1cdbc4a7b5181", "parents": [ "6fd7a46781999c32f423025767e43b349b967d57" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:07:31 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 14:07:31 2011 -0500" }, "message": "ext4: fold __mpage_da_writepage() into write_cache_pages_da()\n\nFold the __mpage_da_writepage() function into write_cache_pages_da().\nThis will give us opportunities to clean up and simplify the resulting\ncode.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "c7f5938adce6727b9d17785f289c1146bd88d678", "tree": "000d17633b6b3b28dd644704afb501b366ad1bbb", "parents": [ "e0fd9b90765f604374c42de8ac59d6584afce264" ], "author": { "name": "Curt Wohlgemuth", "email": "curtw@google.com", "time": "Sat Feb 26 12:27:52 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 12:27:52 2011 -0500" }, "message": "ext4: fix ext4_da_block_invalidatepages() to handle page range properly\n\nIf ext4_da_block_invalidatepages() is called because of a\nfailure from ext4_map_blocks() in mpage_da_map_and_submit(),\nit\u0027s supposed to clean up -- including unlock -- all the\npages in the mpd structure. But these values may not match\nup, even on a system in which block size \u003d\u003d page size:\n\n mpd-\u003eb_blocknr !\u003d mpd-\u003efirst_page\n mpd-\u003eb_size !\u003d (mpd-\u003enext_page - mpd-\u003efirst_page)\n\next4_da_block_invalidatepages() has been using b_blocknr and\nb_size; this patch changes it to use first_page and\nnext_page.\n\nTested: I injected a small number (5%) of failures in\next4_map_blocks() in the case that the flags contain\nEXT4_GET_BLOCKS_DELALLOC_RESERVE, and ran fsstress on this\nkernel. Without this patch, I got hung tasks every time.\nWith this patch, I see no hangs in many runs of fsstress.\n\nSigned-off-by: Curt Wohlgemuth \u003ccurtw@google.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "e0fd9b90765f604374c42de8ac59d6584afce264", "tree": "04a44bed155b4d99e81d366145934d801036f5e8", "parents": [ "5a54b2f199fdf19533f96c3e285b70c6729e1e4a" ], "author": { "name": "Curt Wohlgemuth", "email": "curtw@google.com", "time": "Sat Feb 26 12:25:52 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Feb 26 12:25:52 2011 -0500" }, "message": "ext4: mark multi-page IO complete on mapping failure\n\nIn mpage_da_map_and_submit(), if we have a delayed block\nallocation failure from ext4_map_blocks(), we need to mark\nthe IO as complete, by setting\n\n mpd-\u003eio_done \u003d 1;\n\nOtherwise, we could end up submitting the pages in an outer\nloop; since they are unlocked on mapping failure in\next4_da_block_invalidatepages(), this will cause a bug check\nin mpage_da_submit_io().\n\nI tested this by injected failures into ext4_map_blocks().\nWithout this patch, a simple fsstress run will bug check;\nwith the patch, it works fine.\n\nSigned-off-by: Curt Wohlgemuth \u003ccurtw@google.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "7dc576158d7e5cdff3349f78598fdb4080536342", "tree": "e7be15a8ee8add729915c81e9cb39cd55d6b572d", "parents": [ "da488945f4bf4096f4ab6091938469bd8822cfec" ], "author": { "name": "Peter Huewe", "email": "peterhuewe@gmx.de", "time": "Mon Feb 21 21:01:42 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Feb 21 21:01:42 2011 -0500" }, "message": "ext4: Fix sparse warning: Using plain integer as NULL pointer\n\nThis patch fixes the warning \"Using plain integer as NULL pointer\",\ngenerated by sparse, by replacing the offending 0s with NULL.\n\nSigned-off-by: Peter Huewe \u003cpeterhuewe@gmx.de\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "008d23e4852d78bb2618f2035f8b2110b6a6b968", "tree": "81c88f744f6f3fc84132527c1ddc0b4da410c5e2", "parents": [ "8f685fbda43deccd130d192c9fcef1444649eaca", "bfc672dcf323877228682aff79dff8ecd9f30ff8" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 10:05:56 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 10:05:56 2011 -0800" }, "message": "Merge branch \u0027for-next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial\n\n* \u0027for-next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (43 commits)\n Documentation/trace/events.txt: Remove obsolete sched_signal_send.\n writeback: fix global_dirty_limits comment runtime -\u003e real-time\n ppc: fix comment typo singal -\u003e signal\n drivers: fix comment typo diable -\u003e disable.\n m68k: fix comment typo diable -\u003e disable.\n wireless: comment typo fix diable -\u003e disable.\n media: comment typo fix diable -\u003e disable.\n remove doc for obsolete dynamic-printk kernel-parameter\n remove extraneous \u0027is\u0027 from Documentation/iostats.txt\n Fix spelling milisec -\u003e ms in snd_ps3 module parameter description\n Fix spelling mistakes in comments\n Revert conflicting V4L changes\n i7core_edac: fix typos in comments\n mm/rmap.c: fix comment\n sound, ca0106: Fix assignment to \u0027channel\u0027.\n hrtimer: fix a typo in comment\n init/Kconfig: fix typo\n anon_inodes: fix wrong function name in comment\n fix comment typos concerning \"consistent\"\n poll: fix a typo in comment\n ...\n\nFix up trivial conflicts in:\n - drivers/net/wireless/iwlwifi/iwl-core.c (moved to iwl-legacy.c)\n - fs/ext4/ext4.h\n\nAlso fix missed \u0027diabled\u0027 typo in drivers/net/bnx2x/bnx2x.h while at it.\n" }, { "commit": "6db26ffc917b609402619e03df5af8d1cd371ce7", "tree": "95d58dec4f8a69c57fd632ca61e362654bc351d0", "parents": [ "f878133bf022717b880d0e0995b8f91436fd605c" ], "author": { "name": "Andrew Morton", "email": "akpm@linux-foundation.org", "time": "Wed Jan 12 16:59:13 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 08:03:05 2011 -0800" }, "message": "fs/ext4/inode.c: use pr_warn_ratelimited()\n\npr_warning_ratelimited() doesn\u0027t exist.\n\nAlso include printk.h, which defines these things.\n\nCc: Theodore Ts\u0027o \u003ctytso@mit.edu\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1c5b9e9065567876c2d4a7a16d78f0fed154a5bf", "tree": "67b74f12c7336a972de54d004455369eec38bc28", "parents": [ "a5196f8cdfbf6ccb20f093aaf48852d6d23b4e0b" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:51:28 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:51:28 2011 -0500" }, "message": "ext4: fix memory leak in ext4_free_branches\n\nCommit 40389687 moved a call to ext4_forget() out of\next4_free_branches and let ext4_free_blocks() handle calling\nbforget(). But that change unfortunately did not replace the call to\next4_forget() with brelse(), which was needed to drop the in-use count\nof the indirect block\u0027s buffer head, which lead to a memory leak when\ndeleting files that used indirect blocks. Fix this.\n\nThanks to Hugh Dickins for pointing this out.\n\nCc: stable@kernel.org\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "b40971426a837e9dc9c66e1b6bbcb3874eafe4e0", "tree": "34b2a745719ed18bd1f0c81cfad200b9d8b2e309", "parents": [ "ca6e909f9bebe709bc65a3ee605ce32969db0452" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:46:59 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:46:59 2011 -0500" }, "message": "ext4: add error checking to calls to ext4_handle_dirty_metadata()\n\nCall ext4_std_error() in various places when we can\u0027t bail out\ncleanly, so the file system can be marked as in error.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "8aefcd557d26d0023a36f9ec5afbf55e59f8f26b", "tree": "e13143306cd64525cddd2cc2513c448275a1d95a", "parents": [ "353eb83c1422c6326eaab30ce044a179c6018169" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:29:43 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:29:43 2011 -0500" }, "message": "ext4: dynamically allocate the jbd2_inode in ext4_inode_info as necessary\n\nReplace the jbd2_inode structure (which is 48 bytes) with a pointer\nand only allocate the jbd2_inode when it is needed --- that is, when\nthe file system has a journal present and the inode has been opened\nfor writing. This allows us to further slim down the ext4_inode_info\nstructure.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "353eb83c1422c6326eaab30ce044a179c6018169", "tree": "fd43e39b344de5ee43d82c90f0affda68a65f2df", "parents": [ "8a2005d3f84457b7d7d8646ab5195341d9e5f06a" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:18:25 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:18:25 2011 -0500" }, "message": "ext4: drop i_state_flags on architectures with 64-bit longs\n\nWe can store the dynamic inode state flags in the high bits of\nEXT4_I(inode)-\u003ei_flags, and eliminate i_state_flags. This saves 8\nbytes from the size of ext4_inode_info structure, which when\nmultiplied by the number of the number of in the inode cache, can save\na lot of memory.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "01f49d0b9d0209dc1194255b11601e4b94447b36", "tree": "c3ec53c7725bf7a9188e844d8c8c09432d2be6ae", "parents": [ "f232109773ff5b0c840a6761d74940b9cf0d66ec" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:13:03 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:13:03 2011 -0500" }, "message": "ext4: use ext4_lblk_t instead of sector_t for logical blocks\n\nThis fixes a number of places where we used sector_t instead of\next4_lblk_t for logical blocks, which for ext4 are still 32-bit data\ntypes. No point wasting space in the ext4_inode_info structure, and\nrequiring 64-bit arithmetic on 32-bit systems, when it isn\u0027t\nnecessary.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "f232109773ff5b0c840a6761d74940b9cf0d66ec", "tree": "a32da5ebd1a3e074e9f52107f3bdc23babb6340c", "parents": [ "ad4fb9cafe100a4a9de6e0529015e584d94ac8dc" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:12:36 2011 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jan 10 12:12:36 2011 -0500" }, "message": "ext4: replace i_delalloc_reserved_flag with EXT4_STATE_DELALLOC_RESERVED\n\nRemove the short element i_delalloc_reserved_flag from the\next4_inode_info structure and replace it a new bit in i_state_flags.\nSince we have an ext4_inode_info for every ext4 inode cached in the\ninode cache, any savings we can produce here is a very good thing from\na memory utilization perspective.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "4b7bd364700d9ac8372eff48832062b936d0793b", "tree": "0dbf78c95456a0b02d07fcd473281f04a87e266d", "parents": [ "c0d8768af260e2cbb4bf659ae6094a262c86b085", "90a8a73c06cc32b609a880d48449d7083327e11a" ], "author": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Wed Dec 22 18:57:02 2010 +0100" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Wed Dec 22 18:57:02 2010 +0100" }, "message": "Merge branch \u0027master\u0027 into for-next\n\nConflicts:\n\tMAINTAINERS\n\tarch/arm/mach-omap2/pm24xx.c\n\tdrivers/scsi/bfa/bfa_fcpim.c\n\nNeeded to update to apply fixes for which the old branch was too\noutdated.\n" }, { "commit": "a8901d34872dafcafa23efa0865dcecfd4fddf8c", "tree": "e593fa23bd961b693440966f84e421c5d7a2b5f4", "parents": [ "225db7d35c33f076115a583abec238a696f4467e" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Fri Dec 17 10:40:47 2010 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Fri Dec 17 10:40:47 2010 -0500" }, "message": "ext4: Use pr_warning_ratelimited() instead of printk_ratelimit()\n\nprintk_ratelimit() is deprecated since it is a global instead of a\nper-printk ratelimit.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "225db7d35c33f076115a583abec238a696f4467e", "tree": "d31fbe96f045d734b0c6cbf4b85afc1ba25d458e", "parents": [ "a2595b8aa67011419dae26b47e474f46df902989" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Thu Dec 16 16:38:26 2010 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Thu Dec 16 16:38:26 2010 -0500" }, "message": "ext4: Fix up comments in inode.c\n\nThis fixes up some broken argument descriptions that Namhyung Kim had\noriginally submitted for ext3. This fixes the comments that were\nstill applicable in ext4.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "1449032be17abb69116dbc393f67ceb8bd034f92", "tree": "f62757457241c2fdc14105afc12cb2718f7a2e68", "parents": [ "e8a7e48bb248a1196484d3f8afa53bded2b24e71" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Dec 14 15:27:50 2010 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Dec 14 15:27:50 2010 -0500" }, "message": "ext4: Turn off multiple page-io submission by default\n\nJon Nelson has found a test case which causes postgresql to fail with\nthe error:\n\npsql:t.sql:4: ERROR: invalid page header in block 38269 of relation base/16384/16581\n\nUnder memory pressure, it looks like part of a file can end up getting\nreplaced by zero\u0027s. Until we can figure out the cause, we\u0027ll roll\nback the change and use block_write_full_page() instead of\next4_bio_write_page(). The new, more efficient writing function can\nbe used via the mount option mblk_io_submit, so we can test and fix\nthe new page I/O code.\n\nTo reproduce the problem, install postgres 8.4 or 9.0, and pin enough\nmemory such that the system just at the end of triggering writeback\nbefore running the following sql script:\n\nbegin;\ncreate temporary table foo as select x as a, ARRAY[x] as b FROM\ngenerate_series(1, 10000000 ) AS x;\ncreate index foo_a_idx on foo (a);\ncreate index foo_b_idx on foo USING GIN (b);\nrollback;\n\nIf the temporary table is created on a hard drive partition which is\nencrypted using dm_crypt, then under memory pressure, approximately\n30-40% of the time, pgsql will issue the above failure.\n\nThis patch should fix this problem, and the problem will come back if\nthe file system is mounted with the mblk_io_submit mount option.\n\nReported-by: Jon Nelson \u003cjnelson@jamponi.net\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "380cf090f4f531545b558b04a3dd90d09df52ee9", "tree": "3ae833651a2c6f20b4a033ebcf66fce32a735bfe", "parents": [ "149d730fac715e077a8bcceb4b27f3523b314558" ], "author": { "name": "Wu Fengguang", "email": "fengguang.wu@intel.com", "time": "Thu Nov 11 19:23:29 2010 +0800" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Mon Nov 15 14:14:52 2010 +0100" }, "message": "ext4: fix redirty_page_for_writepage() typo in comment\n\nSigned-off-by: Wu Fengguang \u003cfengguang.wu@intel.com\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "a7bcf21e60c73cb7f7c13fad928967d7e47c3cac", "tree": "e24ae9d2c35508f68016b8cde848b7608e737b32", "parents": [ "5398a64c63a69a0ac33dbae458ea4aab0dc23f14", "7ff9c073dd4d7200399076554f7ab9b876f196f6" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Nov 08 11:54:53 2010 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Nov 08 11:54:53 2010 -0800" }, "message": "Merge branch \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4\n\n* \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4:\n ext4: Add new ext4 inode tracepoints\n ext4: Don\u0027t call sb_issue_discard() in ext4_free_blocks()\n ext4: do not try to grab the s_umount semaphore in ext4_quota_off\n ext4: fix potential race when freeing ext4_io_page structures\n ext4: handle writeback of inodes which are being freed\n ext4: initialize the percpu counters before replaying the journal\n ext4: \"ret\" may be used uninitialized in ext4_lazyinit_thread()\n ext4: fix lazyinit hang after removing request\n" }, { "commit": "7ff9c073dd4d7200399076554f7ab9b876f196f6", "tree": "6ca4eb4ca9b2f6f7b11e8197bd8a9417d7307b00", "parents": [ "b56ff9d397cecdaad6c98c9d57cc6fea475e1f50" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Nov 08 13:51:33 2010 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Nov 08 13:51:33 2010 -0500" }, "message": "ext4: Add new ext4 inode tracepoints\n\nAdd ext4_evict_inode, ext4_drop_inode, ext4_mark_inode_dirty, and\next4_begin_ordered_truncate()\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "eb8abb927ae2fd1730e24ea94cd9527f3c086292", "tree": "e0ae72934040e8d840db503c311ac070d9850bc8", "parents": [ "7fe19da4ca38fc20cdbc7020fcf2eca8fc756410" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Nov 02 09:34:50 2010 -0400" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Nov 02 10:38:30 2010 -0400" }, "message": "ext4: Remove useless spinlock in ext4_getattr()\n\nLinus noted, and complained to me, that doing while lots of \"git diff\"\u0027s\nof kernel sources, these spinlocks were responsible for 27% of the\nspinlock cost on his two-processor system as reported by perf.\n\nGit was doing lots of parallel stats, and this was putting a lot of\npressure on ext4_getattr(). A spinlock to protect a single\nmemory-to-memory copy is pointless, so remove it.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b595076a180a56d1bb170e6eceda6eb9d76f4cd3", "tree": "bc01ec7283808013e0b8ce7713fd6fc40f810429", "parents": [ "6aaccece1c483f189f76f1282b3984ff4c7ecb0a" ], "author": { "name": "Uwe Kleine-König", "email": "u.kleine-koenig@pengutronix.de", "time": "Mon Nov 01 15:38:34 2010 -0400" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Mon Nov 01 15:38:34 2010 -0400" }, "message": "tree-wide: fix comment/printk typos\n\n\"gadget\", \"through\", \"command\", \"maintain\", \"maintain\", \"controller\", \"address\",\n\"between\", \"initiali[zs]e\", \"instead\", \"function\", \"select\", \"already\",\n\"equal\", \"access\", \"management\", \"hierarchy\", \"registration\", \"interest\",\n\"relative\", \"memory\", \"offset\", \"already\",\n\nSigned-off-by: Uwe Kleine-König \u003cu.kleine-koenig@pengutronix.de\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "b1142e8fec6a594723e5054055a7b53379b90490", "tree": "57d6234fa2eb33f861eaea4cee4a40a3ae44c09e", "parents": [ "81280572ca6f54009edfa4deee563e8678784218" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Thu Oct 28 17:33:57 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Thu Oct 28 17:33:57 2010 -0400" }, "message": "ext4: BUG_ON fix: check if page has buffers before calling page_buffers() \n\nWe need to make check if a page does not have buffes by checking\npage_has_buffers(page) before calling page_buffers(page) in\next4_writepage(). Otherwise page_buffers() could throw a BUG_ON.\n\nThanks also to Markus Trippelsdorf and Avinash Kurup who also reported\nthe problem.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nReported-by: Sedat Dilek \u003csedat.dilek@googlemail.com\u003e\nTested-by: Sedat Dilek \u003csedat.dilek@googlemail.com\u003e\n" }, { "commit": "a107e5a3a473a2ea62bd5af24e11b84adf1486ff", "tree": "d36c2cb38d8be88d4d75cdebc354aa140aa0e470", "parents": [ "e3e1288e86a07cdeb0aee5860a2dff111c6eff79", "a269029d0e2192046be4c07ed78a45022469ee4c" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 23:44:47 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 23:44:47 2010 -0400" }, "message": "Merge branch \u0027next\u0027 into upstream-merge\n\nConflicts:\n\tfs/ext4/inode.c\n\tfs/ext4/mballoc.c\n\tinclude/trace/events/ext4.h\n" }, { "commit": "3d287de3b828226e5a450c7fd5bf4283792dc2b0", "tree": "4adcc534e2042aed924750df3ef2433bd2f14fd8", "parents": [ "beed5ecbaa377fa8bb6a54a6608e8725a21efdbc" ], "author": { "name": "Dmitry Monakhov", "email": "dmonakhov@openvz.org", "time": "Wed Oct 27 22:08:46 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 22:08:46 2010 -0400" }, "message": "ext4: optimize orphan_list handling for ext4_setattr\n\nSurprisingly chown() on ext4 is not SMP scalable operation. \nDue to unconditional orphan_del(NULL, inode) in ext4_setattr()\nresult in significant performance overhead because of global orphan\nmutex, especially in no-journal mode (where orphan_add() is noop).\nIt is possible to skip explicit orphan_del if possible.\nResults of fchown() micro-benchmark in no-journal mode\nwhile (1) {\n iteration++;\n fchown(fd, uid, gid);\n fchown(fd, uid + 1, gid + 1)\n}\nmeasured: iterations per millisecond\n| nr_tasks | w/o patch | with patch |\n| 1 | 142 | 185 |\n| 4 | 109 | 642 |\n\nSigned-off-by: Dmitry Monakhov \u003cdmonakhov@openvz.org\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "4a873a472b3bbcfd425d7ae210afdec28c04e2e5", "tree": "88aa333bfafcc5303b7a3074865f51f67ad836b9", "parents": [ "bf89d16f6ef5389f1b9d8046e838ec87b9b3f8b9" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:14 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:14 2010 -0400" }, "message": "ext4: move flush_completed_IO to fs/ext4/fsync.c and make it static\n\nFix a namespace leak by moving the function to the file where it is\nused and making it static.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "1f109d5a17b438c4a54cbf6fd87a249e3d72fb21", "tree": "f58c6fd431975bf900b502b80122e175065da657", "parents": [ "5dabfc78dcedbe46cb2e4872dde448de3cec2979" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:14 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:14 2010 -0400" }, "message": "ext4: make various ext4 functions be static\n\nThese functions have no need to be exported beyond file context.\n\nNo functions needed to be moved for this commit; just some function\ndeclarations changed to be static and removed from header files.\n\n(A similar patch was submitted by Eric Sandeen, but I wanted to handle\ncode movement in separate patches to make sure code changes didn\u0027t\naccidentally get dropped.)\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "72f84e6560d18d60a091df27edf81409be6641cb", "tree": "e2fa11476b074f8526d620820f8b2e86e8a11412", "parents": [ "5b41d92437f1ae19b3f3ffa3b16589fd5df50ac0" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Wed Oct 27 21:30:13 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:13 2010 -0400" }, "message": "ext4: update writeback_index based on last page scanned\n\nAs pointed out in a prior patch, updating the mapping\u0027s\nwriteback_index based on pages written isn\u0027t quite right;\nwhat the writeback index is really supposed to reflect is\nthe next page which should be scanned for writeback during\nperiodic flush.\n\nAs in write_cache_pages(), write_cache_pages_da() does\nthis scanning for us as we assemble the mpd for later\nwriteout. If we keep track of the next page after the\ncurrent scan, we can easily update writeback_index without\nworrying about pages written vs. pages skipped, etc.\n\nWithout this, an fsync will reset writeback_index to\n0 (its starting index) + however many pages it wrote, which\ncan mess up the progress of periodic flush.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "5b41d92437f1ae19b3f3ffa3b16589fd5df50ac0", "tree": "ed7e1999a2349811e3cae0f0bdd53a93aea413d7", "parents": [ "bbd08344e3df8c7c1d7aa04bc0c8c9367806e12d" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Wed Oct 27 21:30:13 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:13 2010 -0400" }, "message": "ext4: implement writeback livelock avoidance using page tagging\n\nThis is analogous to Jan Kara\u0027s commit,\nf446daaea9d4a420d16c606f755f3689dcb2d0ce\nmm: implement writeback livelock avoidance using page tagging\n\nbut since we forked write_cache_pages, we need to reimplement\nit there (and in ext4_da_writepages, since range_cyclic handling\nwas moved to there)\n\nIf you start a large buffered IO to a file, and then set\nfsync after it, you\u0027ll find that fsync does not complete\nuntil the other IO stops.\n\nIf you continue re-dirtying the file (say, putting dd\nwith conv\u003dnotrunc in a loop), when fsync finally completes\n(after all IO is done), it reports via tracing that\nit has written many more pages than the file contains;\nin other words it has synced and re-synced pages in\nthe file multiple times.\n\nThis then leads to problems with our writeback_index\nupdate, since it advances it by pages written, and\nessentially sets writeback_index off the end of the\nfile...\n\nWith the following patch, we only sync as much as was\ndirty at the time of the sync.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "bbd08344e3df8c7c1d7aa04bc0c8c9367806e12d", "tree": "6441a113660deb3bbe1795f5b03b1c11b9e18fda", "parents": [ "27ee40df2b17c84aa7855907df12befe6869b7a7" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Wed Oct 27 21:30:12 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:12 2010 -0400" }, "message": "ext4: tidy up a void argument in inode.c\n\nThis doesn\u0027t fix anything at all, it just removes a vestige\nof prior use from __mpage_da_writepage()\n\n__mpage_da_writepage() had a *void argument leftover from\nits previous life as a callback; make it reflect the actual type.\n\nFixing this up makes it slightly more obvious to read, and \nenables proper typechecking.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "877836905da55e8f2426234f42a89287184949e9", "tree": "eecb60e9b55daaf794a3083f9c48fc94e05d4cd2", "parents": [ "bd2d0210cf22f2bd0cef72eb97cf94fc7d31d8cc" ], "author": { "name": "Namhyung Kim", "email": "namhyung@gmail.com", "time": "Wed Oct 27 21:30:11 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:11 2010 -0400" }, "message": "ext4: Check return value of sb_getblk() and friends\n\nFail block allocation if sb_getblk() returns NULL. In that case,\nsb_find_get_block() also likely to fail so that it should skip\ncalling ext4_forget().\n\nSigned-off-by: Namhyung Kim \u003cnamhyung@gmail.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "bd2d0210cf22f2bd0cef72eb97cf94fc7d31d8cc", "tree": "f0d1902b7ff4294114614cc706855c3d6b131f73", "parents": [ "1de3e3df917459422cb2aecac440febc8879d410" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:10 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:10 2010 -0400" }, "message": "ext4: use bio layer instead of buffer layer in mpage_da_submit_io\n\nCall the block I/O layer directly instad of going through the buffer\nlayer. This should give us much better performance and scalability,\nas well as lowering our CPU utilization when doing buffered writeback.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n\n" }, { "commit": "1de3e3df917459422cb2aecac440febc8879d410", "tree": "3ff2584fa323ec855dec74b7e842e5e4abe39597", "parents": [ "3ecdb3a193a5f224f084c04a63aa28cdccf4d7d0" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:10 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:10 2010 -0400" }, "message": "ext4: move mpage_put_bnr_to_bhs()\u0027s functionality to mpage_da_submit_io()\n\nThis massively simplifies the ext4_da_writepages() code path by\ncompletely removing mpage_put_bnr_bhs(), which is almost 100 lines of\ncode iterating over a set of pages using pagevec_lookup(), and folds\nthat functionality into mpage_da_submit_io()\u0027s existing\npagevec_lookup() loop.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "3ecdb3a193a5f224f084c04a63aa28cdccf4d7d0", "tree": "9949f753917004c75ddd4549c8e9741ccdbd435e", "parents": [ "cb20d5188366f04d96d2e07b1240cc92170ade40" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:10 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:10 2010 -0400" }, "message": "ext4: inline walk_page_buffers() into mpage_da_submit_io\n\nExpand the call:\n\n if (walk_page_buffers(NULL, page_bufs, 0, len, NULL,\n ext4_bh_delay_or_unwritten))\n\tgoto redirty_page\n\ninto mpage_da_submit_io().\n\nThis will allow us to merge in mpage_put_bnr_to_bhs() in the next\npatch.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "cb20d5188366f04d96d2e07b1240cc92170ade40", "tree": "6fe424e1ccdd36f8b4a60e144cfdaa577296926e", "parents": [ "a42afc5f56f319107e987aa6adf2f65d93d527c7" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:09 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:09 2010 -0400" }, "message": "ext4: inline ext4_writepage() into mpage_da_submit_io()\n\nAs a prepratory step to switching to bio_submit, inline\next4_writepage() into mpage_da_submit() and then simplify things a\nbit. This makes it clearer what mpage_da_submit needs to do.\n\nAlso, move the ClearPageChecked(page) call into\n__ext4_journalled_writepage(), as a minor bit of cleanup refactoring.\n\nThis also allows us to pull i_size_read() and\next4_should_journal_data() out of the loop, which should be a very\nminor CPU savings.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "a42afc5f56f319107e987aa6adf2f65d93d527c7", "tree": "845d03a8cec3fcb705ea6c821d202c816de76655", "parents": [ "5a87b7a5da250c9be6d757758425dfeaf8ed3179" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:09 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:09 2010 -0400" }, "message": "ext4: simplify ext4_writepage()\n\nThe actual code in ext4_writepage() is unnecessarily convoluted.\nSimplify it so it is easier to understand, but otherwise logically\nequivalent.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "5a87b7a5da250c9be6d757758425dfeaf8ed3179", "tree": "efd1ca776e184101cb20ba4606bc35103385bcb5", "parents": [ "16828088f9e518158edecb6cde7e6fa38e4c889b" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:09 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:09 2010 -0400" }, "message": "ext4: call mpage_da_submit_io() from mpage_da_map_blocks()\n\nEventually we need to completely reorganize the ext4 writepage\ncallpath, but for now, we simplify things a little by calling\nmpage_da_submit_io() from mpage_da_map_blocks(), since all of the\nplaces where we call mpage_da_map_blocks() it is followed up by a call\nto mpage_da_submit_io().\n\nWe\u0027re also a wee bit better with respect to error handling, but there\nare still a number of issues where it\u0027s not clear what the right thing\nis to do with ext4 functions deep in the writeback codepath fails.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "c999af2b347a55174f702702e0df814d05ef5491", "tree": "47957b52c9a54babe4d8aefdda4f09cee5f76249", "parents": [ "3e1e5f501632460184a98237d5460c521510535e" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Wed Oct 27 21:30:07 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:07 2010 -0400" }, "message": "ext4: queue conversion after adding to inode\u0027s completed IO list\n\nBy queuing the io end on the unwritten workqueue before adding it\nto our inode\u0027s list of completed IOs, I think we run the risk\nof the work getting completed, and the IO freed, before we try\nto add it to the inode\u0027s i_completed_io_list.\n\nIt should be safe to add it to the inode\u0027s list of completed\nIOs, and -then- queue it for completion, I think.\n\nThanks to Dave Chinner for pointing out the race.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nReviewed-by: Jiaying Zhang \u003cjiayingz@google.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "0c9169ccad4aed233fdd49e95da4eada2536a06d", "tree": "2c89c49f8aa48dd781747e4f9d801ad06e5517b9", "parents": [ "e0d10bfa91b0a089a9e2c378b5c42f4e96171d95" ], "author": { "name": "Toshiyuki Okajima", "email": "toshi.okajima@jp.fujitsu.com", "time": "Wed Oct 27 21:30:07 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:07 2010 -0400" }, "message": "ext4: fix potential infinite loop in ext4_da_writepages()\n\nOn linux-2.6.36-rc2, if we execute the following script, we can hang\nthe system when the /bin/sync command is executed:\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n#!/bin/sh\n\necho -n \"HANG UP TEST: \"\n/bin/dd if\u003d/dev/zero of\u003d/tmp/img bs\u003d1k count\u003d1 seek\u003d1M 2\u003e /dev/null\n/sbin/mkfs.ext4 -Fq /tmp/img\n/bin/mount -o loop -t ext4 /tmp/img /mnt\n/bin/dd if\u003d/dev/zero of\u003d/mnt/file bs\u003d1 count\u003d1 \\\nseek\u003d$((16*1024*1024*1024*1024-4096)) 2\u003e /dev/null\n/bin/sync\n/bin/umount /mnt\necho \"DONE\"\nexit 0\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nWe can see the following backtrace if we get the kdump when this\nhangup occurs:\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nkthread()\n\u003d\u003e bdi_writeback_thread()\n \u003d\u003e wb_do_writeback()\n \u003d\u003e wb_writeback()\n \u003d\u003e writeback_inodes_wb()\n \u003d\u003e writeback_sb_inodes()\n \u003d\u003e writeback_single_inode()\n \u003d\u003e ext4_da_writepages() ---+ \n ^ infinite |\n | loop |\n +-------------+\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nThe reason why this hangup happens is described as follows:\n1) We write the last extent block of the file whose size is the filesystem \n maximum size.\n2) \"BH_Delay\" flag is set on the buffer_head of its block.\n3) - the member, \"m_lblk\" of struct mpage_da_data is 4294967295 (UINT_MAX)\n - the member, \"m_len\" of struct mpage_da_data is 1\n mpage_put_bnr_to_bhs() which is called via ext4_da_writepages()\n cannot clear \"BH_Delay\" flag of the buffer_head because the type of\n m_lblk is ext4_lblk_t and then m_lblk + m_len is overflow.\n\n Therefore an infinite loop occurs because ext4_da_writepages()\n cannot write the page (which corresponds to the block) since\n \"BH_Delay\" flag isn\u0027t cleared.\n----------------------------------------------------------------------\nstatic void mpage_put_bnr_to_bhs(struct mpage_da_data *mpd,\n\t\t\t\tstruct ext4_map_blocks *map)\n{\n...\n\tint blocks \u003d map-\u003em_len;\n...\n\t\tdo {\n\t\t\t// cur_logical \u003d 4294967295\n\t\t\t// map-\u003em_lblk \u003d 4294967295\n\t\t\t// blocks \u003d 1\n\t\t\t// *** map-\u003em_lblk + blocks \u003d\u003d 0 (OVERFLOW!) ***\n\t\t\t// (cur_logical \u003e\u003d map-\u003em_lblk + blocks) \u003d\u003e true\n\t\t\tif (cur_logical \u003e\u003d map-\u003em_lblk + blocks)\n\t\t\t\tbreak;\n----------------------------------------------------------------------\n\nNOTE: Mounting with the nodelalloc option will avoid this codepath,\nand thus, avoid this hang\n\nSigned-off-by: Toshiyuki Okajima \u003ctoshi.okajima@jp.fujitsu.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "b443e7339aa08574d30b0819b344618459c76214", "tree": "3c89ccd60deee6184b5cc9cf2bbb78291952b047", "parents": [ "659c6009ca2e3a01acc9881bafe5f55ef09c965b" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Wed Oct 27 21:30:03 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:03 2010 -0400" }, "message": "ext4: don\u0027t bump up LONG_MAX nr_to_write by a factor of 8\n\nI\u0027m uneasy with lots of stuff going on in ext4_da_writepages(),\nbut bumping nr_to_write from LLONG_MAX to -8 clearly isn\u0027t\nmaking anything better, so avoid the multiplier in that case.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "659c6009ca2e3a01acc9881bafe5f55ef09c965b", "tree": "c7d6b0a8cfb8f5979f3f8d0e0e5122ffd9c688be", "parents": [ "fb1813f4a8a27bbd4735967e46931e61fc837a3e" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Wed Oct 27 21:30:03 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Wed Oct 27 21:30:03 2010 -0400" }, "message": "ext4: stop looping in ext4_num_dirty_pages when max_pages reached\n\nToday we simply break out of the inner loop when we have accumulated\nmax_pages; this keeps scanning forwad and doing pagevec_lookup_tag()\nin the while (!done) loop, this does potentially a lot of work\nwith no net effect.\n\nWhen we have accumulated max_pages, just clean up and return.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "ebdec241d509cf69f6ebf1ecdc036359d3dbe154", "tree": "e3c23f9b213936cb8501c83f55522a01f4a69aca", "parents": [ "56b0dacfa2b8416815a2f2a5f4f51e46be4cf14c" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Wed Oct 06 10:47:23 2010 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Oct 25 21:18:20 2010 -0400" }, "message": "fs: kill block_prepare_write\n\n__block_write_begin and block_prepare_write are identical except for slightly\ndifferent calling conventions. Convert all callers to the __block_write_begin\ncalling conventions and drop block_prepare_write.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "5f248c9c251c60af3403902b26e08de43964ea0b", "tree": "6d3328e72a7e4015a64017eb30be18095c6a3c64", "parents": [ "f6cec0ae58c17522a7bc4e2f39dae19f199ab534", "dca332528bc69e05f67161e1ed59929633d5e63d" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Aug 10 11:26:52 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Aug 10 11:26:52 2010 -0700" }, "message": "Merge branch \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6\n\n* \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6: (96 commits)\n no need for list_for_each_entry_safe()/resetting with superblock list\n Fix sget() race with failing mount\n vfs: don\u0027t hold s_umount over close_bdev_exclusive() call\n sysv: do not mark superblock dirty on remount\n sysv: do not mark superblock dirty on mount\n btrfs: remove junk sb_dirt change\n BFS: clean up the superblock usage\n AFFS: wait for sb synchronization when needed\n AFFS: clean up dirty flag usage\n cifs: truncate fallout\n mbcache: fix shrinker function return value\n mbcache: Remove unused features\n add f_flags to struct statfs(64)\n pass a struct path to vfs_statfs\n update VFS documentation for method changes.\n All filesystems that need invalidate_inode_buffers() are doing that explicitly\n convert remaining -\u003eclear_inode() to -\u003eevict_inode()\n Make -\u003edrop_inode() just return whether inode needs to be dropped\n fs/inode.c:clear_inode() is gone\n fs/inode.c:evict() doesn\u0027t care about delete vs. non-delete paths now\n ...\n\nFix up trivial conflicts in fs/nilfs2/super.c\n" }, { "commit": "0930fcc1ee2f0a810b938bc283a3a262d7adccbb", "tree": "5e5d10894f1e31a7aede75110b43d7a41347631d", "parents": [ "7da08fd17a6e42d80f0f3897a5cbd682e77bcdb4" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Jun 07 13:16:22 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Aug 09 16:48:30 2010 -0400" }, "message": "convert ext4 to -\u003eevict_inode()\n\npretty much brute-force...\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "1025774ce411f2bd4b059ad7b53f0003569b74fa", "tree": "2be221c205cb5579652a6063e8ee27d1c72d1bbd", "parents": [ "eef2380c187890816b73b1a4cb89a09203759469" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Fri Jun 04 11:30:02 2010 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Aug 09 16:47:37 2010 -0400" }, "message": "remove inode_setattr\n\nReplace inode_setattr with opencoded variants of it in all callers. This\nmoves the remaining call to vmtruncate into the filesystem methods where it\ncan be replaced with the proper truncate sequence.\n\nIn a few cases it was obvious that we would never end up calling vmtruncate\nso it was left out in the opencoded variant:\n\n spufs: explicitly checks for ATTR_SIZE earlier\n btrfs,hugetlbfs,logfs,dlmfs: explicitly clears ATTR_SIZE earlier\n ufs: contains an opencoded simple_seattr + truncate that sets the filesize just above\n\nIn addition to that ncpfs called inode_setattr with handcrafted iattrs,\nwhich allowed to trim down the opencoded variant.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "6e1db88d536adcbbfe562b2d4b7d6425784fff12", "tree": "8cfcb5a6190722db6249b2e4978f39247975abcf", "parents": [ "f4e420dc423148fba637af1ab618fa8896dfb2d6" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Fri Jun 04 11:29:57 2010 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Aug 09 16:47:32 2010 -0400" }, "message": "introduce __block_write_begin\n\nSplit up the block_write_begin implementation - __block_write_begin is a new\ntrivial wrapper for block_prepare_write that always takes an already\nallocated page and can be either called from block_write_begin or filesystem\ncode that already has a page allocated. Remove the handling of already\nallocated pages from block_write_begin after switching all callers that\ndo it to __block_write_begin.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "eafdc7d190a944c755a9fe68573c193e6e0217e7", "tree": "915c3cc8004706fabf88eae1ab123a3fa0147516", "parents": [ "256249584bda1a9357e2d29987a37f5b2df035f6" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Fri Jun 04 11:29:53 2010 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Aug 09 16:47:29 2010 -0400" }, "message": "sort out blockdev_direct_IO variants\n\nMove the call to vmtruncate to get rid of accessive blocks to the callers\nin prepearation of the new truncate calling sequence. This was only done\nfor DIO_LOCKING filesystems, so the __blockdev_direct_IO_newtrunc variant\nwas not needed anyway. Get rid of blockdev_direct_IO_no_locking and\nits _newtrunc variant while at it as just opencoding the two additional\nparamters is shorted than the name suffix.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "56d35a4cd13e7bc5eca5b2dba5a41794afb17e11", "tree": "8173b2de9f0f2b596812a725ac1897efa0ba38fc", "parents": [ "0cfc9255a1efb0467de2162950197750570ecec0" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Aug 05 14:41:42 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Thu Aug 05 14:41:42 2010 -0400" }, "message": "ext4: Fix dirtying of journalled buffers in data\u003djournal mode\n\nIn data\u003djournal mode, we still use block_write_begin() to prepare\npage for writing. This function can occasionally mark buffer dirty\nwhich violates journalling assumptions - when a buffer is part of\na transaction, it should be dirty and a buffer can be already part\nof a forget list of some transaction when block_write_begin()\ngets called. This violation of journalling assumptions then results\nin \"JBD: Spotted dirty metadata buffer...\" warnings.\n\nIn fact, temporary dirtying the buffer while the page is still locked\ndoes not really cause problems to the journalling because we won\u0027t write\nthe buffer until the page gets unlocked. So we just have to make sure\nto clear dirty bits before unlocking the page.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "a931da6ac9331a6c80dd91c199105806f2336188", "tree": "2d4ea766def9a98d21c2379f41e796b0e57ccd6b", "parents": [ "a51dca9cd3bb4ec5a05bfb6feabf024a5c808a37" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Aug 03 21:35:12 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Aug 03 21:35:12 2010 -0400" }, "message": "jbd2: Change j_state_lock to be a rwlock_t\n\nLockstat reports have shown that j_state_lock is a major source of\nlock contention, especially on systems with more than 4 CPU cores. So\nchange it to be a read/write spinlock.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "4538821993f4486c76090dfb377c60c0a0e71ba3", "tree": "d196075a963896c25df9ceb983a19ce82f5eab9b", "parents": [ "f613dfcb3345dacb8cf99b7bb359acc1c18a1157" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Thu Jul 29 15:06:10 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Thu Jul 29 15:06:10 2010 -0400" }, "message": "ext4: drop inode from orphan list if ext4_delete_inode() fails\n\nThere were some error paths in ext4_delete_inode() which was not\ndropping the inode from the orphan list. This could lead to a BUG_ON\non umount when the orphan list is discovered to be non-empty.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n\n" }, { "commit": "e3570639c8b5f2c6a5018a2649c2b7c276af76d7", "tree": "07c497204ba370c5e64b5868aa704e269e5893a3", "parents": [ "d889dc8382c4d71b6d538b7b13777bc1ec51df10" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Tue Jul 27 11:56:08 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jul 27 11:56:08 2010 -0400" }, "message": "ext4: don\u0027t print scary messages for allocation failures post-abort\n\nI often get emails containing the \"This should not happen!!\" message,\nconveniently trimmed to remove things like:\n\nsd 0:0:0:0: [sda] Unhandled error code\nsd 0:0:0:0: [sda] Result: hostbyte\u003dDID_OK driverbyte\u003dDRIVER_TIMEOUT\nsd 0:0:0:0: [sda] CDB: Write(10): 2a 00 03 13 c9 70 00 00 28 00\nend_request: I/O error, dev sda, sector 51628400\nAborting journal on device dm-0-8.\nEXT4-fs error (device dm-0): ext4_journal_start_sb: Detected aborted journal\nEXT4-fs (dm-0): Remounting filesystem read-only\n\nI don\u0027t think there is any value to the verbosity if the reason is\ndue to a filesystem abort; it just obfuscates the root cause.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "79e8303677fc15f508b9877e0fea1925c4add6f3", "tree": "85891ab05b2a9e5dd47966fd16bc372df6d4bb88", "parents": [ "62d2b5f2dcd3707b070efb16bbfdf6947c38c194" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Tue Jul 27 11:56:07 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jul 27 11:56:07 2010 -0400" }, "message": "ext4: fix ext4_get_blocks references\n\next4_get_blocks got renamed to ext4_map_blocks, but left stale\ncomments and a prototype littered around.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "0c095c7f113e9fd05913d6e1b2cccbe356be039e", "tree": "f23477719c99d5c20b4f1817c0ebe302a74eb870", "parents": [ "506bf2d82165c09b179a5077e01037f6270a4db3" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jul 27 11:56:06 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jul 27 11:56:06 2010 -0400" }, "message": "ext4: Don\u0027t error out the fs if the user tries to make a file too big\n\nIf the user attempts to make a non-extent-mapped file to be too large,\nreturn EFBIG, but don\u0027t call ext4_std_err() which will end up marking\nthe file system as containing an error.\n\nThanks to Toshiyuki Okajima-san at Fujitsu for pointing this out.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "5b3ff237bef43b9e7fb7d1eb858e29b73fd664f9", "tree": "e3810d974a0e51a8c4b9046abdd36a5a4022abb3", "parents": [ "552ef8024f909d9b3a7442d0ab0d48a22de24e9e" ], "author": { "name": "jiayingz@google.com (Jiaying Zhang)", "email": "", "time": "Tue Jul 27 11:56:06 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jul 27 11:56:06 2010 -0400" }, "message": "ext4: move aio completion after unwritten extent conversion\n\nThis patch is to be applied upon Christoph\u0027s \"direct-io: move aio_complete\ninto -\u003eend_io\" patch. It adds iocb and result fields to struct ext4_io_end_t,\nso that we can call aio_complete from ext4_end_io_nolock() after the extent\nconversion has finished.\n\nI have verified with Christoph\u0027s aio-dio test that used to fail after a few\nruns on an original kernel but now succeeds on the patched kernel.\n\nSee http://thread.gmane.org/gmane.comp.file-systems.ext4/19659 for details.\n\nSigned-off-by: Jiaying Zhang \u003cjiayingz@google.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "552ef8024f909d9b3a7442d0ab0d48a22de24e9e", "tree": "868af331b76e12c8d17b8449094065a069e0d759", "parents": [ "5c521830cf3dfcf7638d409d8e02ed21020c064f" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Tue Jul 27 11:56:06 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jul 27 11:56:06 2010 -0400" }, "message": "direct-io: move aio_complete into -\u003eend_io\n\nFilesystems with unwritten extent support must not complete an AIO request\nuntil the transaction to convert the extent has been commited. That means\nthe aio_complete calls needs to be moved into the -\u003eend_io callback so\nthat the filesystem can control when to call it exactly.\n\nThis makes a bit of a mess out of dio_complete and the -\u003eend_io callback\nprototype even more complicated. \n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Jan Kara \u003cjack@suse.cz\u003e \nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "40389687382bf0ae71458e7c0f828137a438a956", "tree": "d2a49d494754e7fa28d33c2389f78a5b5da0db4f", "parents": [ "a271fe8527fe9637bdd82c97123b1356940dd84b" ], "author": { "name": "Amir G", "email": "amir73il@users.sourceforge.net", "time": "Tue Jul 27 11:56:05 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jul 27 11:56:05 2010 -0400" }, "message": "ext4: Fix block bitmap inconsistencies after a crash when deleting files\n\nWe have experienced bitmap inconsistencies after crash during file\ndelete under heavy load. The crash is not file system related and I\nthe following patch in ext4_free_branches() fixes the recovery\nproblem.\n\nIf the transaction is restarted and there is a crash before the new\ntransaction is committed, then after recovery, the blocks that this\nindirect block points to have been freed, but the indirect block\nitself has not been freed and may still point to some of the free\nblocks (because of the ext4_forget()).\n\nSo ext4_forget() should be called inside ext4_free_blocks() to avoid\nthis problem.\n\nSigned-off-by: Amir Goldstein \u003camir73il@users.sf.net\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "1c13d5c0872870cca3e612aa045d492ead9ab004", "tree": "6e3dd0d3f49ff56dda9fc6cd72c233759bc24e09", "parents": [ "c398eda0e43a791be0fca6f197a1e2bbb9f16070" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jul 27 11:56:03 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jul 27 11:56:03 2010 -0400" }, "message": "ext4: Save error information to the superblock for analysis\n\nSave number of file system errors, and the time function name, line\nnumber, block number, and inode number of the first and most recent\nerrors reported on the file system in the superblock.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "c398eda0e43a791be0fca6f197a1e2bbb9f16070", "tree": "d7b2b95490f96a75e116a3aa13c17767aa630342", "parents": [ "60fd4da34d55a9cc0d857fc76dc12cf8cab4ed02" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jul 27 11:56:40 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jul 27 11:56:40 2010 -0400" }, "message": "ext4: Pass line numbers to ext4_error() and friends\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "40e2e97316af6e62affab7a392e792494b8d9dde", "tree": "981ce3b464467893683d47f52ae5d35fdd32d46a", "parents": [ "696123fca877905696591829c97a2cef11c8d048" ], "author": { "name": "Christoph Hellwig", "email": "hch@infradead.org", "time": "Sun Jul 18 21:17:09 2010 +0000" }, "committer": { "name": "Alex Elder", "email": "aelder@sgi.com", "time": "Mon Jul 26 16:09:02 2010 -0500" }, "message": "direct-io: move aio_complete into -\u003eend_io\n\nFilesystems with unwritten extent support must not complete an AIO request\nuntil the transaction to convert the extent has been commited. That means\nthe aio_complete calls needs to be moved into the -\u003eend_io callback so\nthat the filesystem can control when to call it exactly.\n\nThis makes a bit of a mess out of dio_complete and the -\u003eend_io callback\nprototype even more complicated.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Alex Elder \u003caelder@sgi.com\u003e\n" }, { "commit": "e29136f80e775b0310273932b4297a62f5574a29", "tree": "d10d56b15b7968744ea0becdf61440aae7e609c5", "parents": [ "c67d859e39896e4286249da89c4ca0ef8bd949cb" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jun 29 12:54:28 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Jun 29 12:54:28 2010 -0400" }, "message": "ext4: Enhance ext4_grp_locked_error() to take block and function numbers\n\nAlso use a macro definition so that __func__ and __LINE__ is implicit.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "206f7ab4f49a2021fcb8687f25395be77711ddee", "tree": "19764d36a25ec1e088d32572a1c0936eeaf19636", "parents": [ "5a0790c2c4a18435759a70e1562450035d778339" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Mon Jun 14 14:42:49 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jun 14 14:42:49 2010 -0400" }, "message": "ext4: remove vestiges of nobh support\n\nThe nobh option was only supported for writeback mode, but given that all\nwrite paths actually create buffer heads it effectively was a no-op already.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "5a0790c2c4a18435759a70e1562450035d778339", "tree": "80acb12d0e37196cf60ae4ca150c6b556115f302", "parents": [ "07a038245b28df9196ffb2e8cc626e9b956a4e23" ], "author": { "name": "Andi Kleen", "email": "andi@firstfloor.org", "time": "Mon Jun 14 13:28:03 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jun 14 13:28:03 2010 -0400" }, "message": "ext4: remove initialized but not read variables\n\nNo real bugs found, just removed some dead code.\n\nFound by gcc 4.6\u0027s new warnings.\n\nSigned-off-by: Andi Kleen \u003cak@linux.intel.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "07a038245b28df9196ffb2e8cc626e9b956a4e23", "tree": "33faae4d5785d5cdd83381f0feff5798845feafc", "parents": [ "a0375156ca1041574b5d47cc7e32f10b891151b0" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jun 14 09:54:48 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon Jun 14 09:54:48 2010 -0400" }, "message": "ext4: Convert more i_flags references to use accessor functions\n\nThese changes are not ones which are likely to result in races, but\nthey should be fixed.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "84a8dce2710cc425089a2b92acc354d4fbb5788d", "tree": "2d83f638d52326b6a8080a26aa1423fa28b38ff1", "parents": [ "1f5a81e41f8b1a782c68d3843e9ec1bfaadf7d72" ], "author": { "name": "Dmitry Monakhov", "email": "dmonakhov@openvz.org", "time": "Sat Jun 05 11:51:27 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Jun 05 11:51:27 2010 -0400" }, "message": "ext4: Fix remaining racy updates of EXT4_I(inode)-\u003ei_flags\n\nA few functions were still modifying i_flags in a racy manner.\n\nSigned-off-by: Dmitry Monakhov \u003cdmonakhov@openvz.org\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "e4ce30f3779c2ddaa7dfaa4042209e5dbacbada5", "tree": "cc64c1dcd16b5dbf71ebc8338b339e6fb04abaee", "parents": [ "b899ebeb05da4287ce845976727e3e83dadd25d5", "14ece1028b3ed53ffec1b1213ffc6acaf79ad77c" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu May 27 10:26:37 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu May 27 10:26:37 2010 -0700" }, "message": "Merge branch \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4\n\n* \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4: (40 commits)\n ext4: Make fsync sync new parent directories in no-journal mode\n ext4: Drop whitespace at end of lines\n ext4: Fix compat EXT4_IOC_ADD_GROUP\n ext4: Conditionally define compat ioctl numbers\n tracing: Convert more ext4 events to DEFINE_EVENT\n ext4: Add new tracepoints to track mballoc\u0027s buddy bitmap loads\n ext4: Add a missing trace hook\n ext4: restart ext4_ext_remove_space() after transaction restart\n ext4: Clear the EXT4_EOFBLOCKS_FL flag only when warranted\n ext4: Avoid crashing on NULL ptr dereference on a filesystem error\n ext4: Use bitops to read/modify i_flags in struct ext4_inode_info\n ext4: Convert calls of ext4_error() to EXT4_ERROR_INODE()\n ext4: Convert callers of ext4_get_blocks() to use ext4_map_blocks()\n ext4: Add new abstraction ext4_map_blocks() underneath ext4_get_blocks()\n ext4: Use our own write_cache_pages()\n ext4: Show journal_checksum option\n ext4: Fix for ext4_mb_collect_stats()\n ext4: check for a good block group before loading buddy pages\n ext4: Prevent creation of files larger than RLIMIT_FSIZE using fallocate\n ext4: Remove extraneous newlines in ext4_msg() calls\n ...\n\nFixed up trivial conflict in fs/ext4/fsync.c\n" }, { "commit": "12755627bdcddcdb30a1bfb9a09395a52b1d6838", "tree": "b2d69696975d5457648020324f683a45302fbf3c", "parents": [ "fcbc59f96e38a0999e827be9d04d46b62b53b20a" ], "author": { "name": "Dmitry Monakhov", "email": "dmonakhov@openvz.org", "time": "Thu Apr 08 22:04:20 2010 +0400" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Fri May 21 19:30:45 2010 +0200" }, "message": "quota: unify quota init condition in setattr\n\nQuota must being initialized if size or uid/git changes requested.\nBut initialization performed in two different places:\nin case of i_size file system is responsible for dquot init\n, but in case of uid/gid init will be called internally in\ndquot_transfer().\nThis ambiguity makes code harder to understand.\nLet\u0027s move this logic to one common helper function.\n\nSigned-off-by: Dmitry Monakhov \u003cdmonakhov@openvz.org\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "60e6679e28518ccd67169c4a539d8cc7490eb8a6", "tree": "65f39d1e9da3006df5bc5532d0c8a7ec365599f0", "parents": [ "4d92dc0f00a775dc2e1267b0e00befb783902fe7" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon May 17 07:00:00 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon May 17 07:00:00 2010 -0400" }, "message": "ext4: Drop whitespace at end of lines\n\nThis patch was generated using:\n\n#!/usr/bin/perl -i\nwhile (\u003c\u003e) {\n s/[ \t]+$//;\n print;\n}\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "5a58ec8766e0ce98fd585eb404b3e56935afafe6", "tree": "191f9457a05ffe7803712f62d40d848d58987765", "parents": [ "0617b83fa239db9743a18ce6cc0e556f4d0fd567" ], "author": { "name": "Li Zefan", "email": "lizf@cn.fujitsu.com", "time": "Mon May 17 02:00:00 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Mon May 17 02:00:00 2010 -0400" }, "message": "ext4: Add a missing trace hook\n\nCommit f8ec9d6837241865cf99bed97bb99f4399fd5a03 added a\ntrace event ext4_da_release_space, but didn\u0027t add some\ncorresponding trace hook.\n\nSigned-off-by: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "12e9b892002d9af057655d35b44db8ee9243b0dc", "tree": "c5831b4bcf98eebdd39158d08dab97c198f5c683", "parents": [ "24676da469f50f433baa347845639662c561d1f6" ], "author": { "name": "Dmitry Monakhov", "email": "dmonakhov@openvz.org", "time": "Sun May 16 22:00:00 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun May 16 22:00:00 2010 -0400" }, "message": "ext4: Use bitops to read/modify i_flags in struct ext4_inode_info\n\nAt several places we modify EXT4_I(inode)-\u003ei_flags without holding\ni_mutex (ext4_do_update_inode, ...). These modifications are racy and\nwe can lose updates to i_flags. So convert handling of i_flags to use\nbitops which are atomic.\n\nhttps://bugzilla.kernel.org/show_bug.cgi?id\u003d15792\n\nSigned-off-by: Dmitry Monakhov \u003cdmonakhov@openvz.org\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "24676da469f50f433baa347845639662c561d1f6", "tree": "b4b8205f8b50376af286193d0dcbe76f2bc2d1e1", "parents": [ "2ed886852adfcb070bf350e66a0da0d98b2f3ab5" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun May 16 21:00:00 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun May 16 21:00:00 2010 -0400" }, "message": "ext4: Convert calls of ext4_error() to EXT4_ERROR_INODE()\n\nEXT4_ERROR_INODE() tends to provide better error information and in a\nmore consistent format. Some errors were not even identifying the inode\nor directory which was corrupted, which made them not very useful.\n\nAddresses-Google-Bug: #2507977\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "2ed886852adfcb070bf350e66a0da0d98b2f3ab5", "tree": "bcec0a1004f413b70087e2c43097892f87f21cc3", "parents": [ "e35fd6609b2fee54484d520deccb8f18bf7d38f3" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun May 16 20:00:00 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun May 16 20:00:00 2010 -0400" }, "message": "ext4: Convert callers of ext4_get_blocks() to use ext4_map_blocks()\n\nThis saves a huge amount of stack space by avoiding unnecesary struct\nbuffer_head\u0027s from being allocated on the stack.\n\nIn addition, to make the code easier to understand, collapse and\nrefactor ext4_get_block(), ext4_get_block_write(),\nnoalloc_get_block_write(), into a single function.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n\n" }, { "commit": "e35fd6609b2fee54484d520deccb8f18bf7d38f3", "tree": "9b786445602819074f599c282b31bead166e8c03", "parents": [ "8e48dcfbd7c0892b4cfd064d682cc4c95a29df32" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun May 16 19:00:00 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun May 16 19:00:00 2010 -0400" }, "message": "ext4: Add new abstraction ext4_map_blocks() underneath ext4_get_blocks()\n\nJack up ext4_get_blocks() and add a new function, ext4_map_blocks()\nwhich uses a much smaller structure, struct ext4_map_blocks which is\n20 bytes, as opposed to a struct buffer_head, which nearly 5 times\nbigger on an x86_64 machine. By switching things to use\next4_map_blocks(), we can save stack space by using ext4_map_blocks()\nsince we can avoid allocating a struct buffer_head on the stack.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "8e48dcfbd7c0892b4cfd064d682cc4c95a29df32", "tree": "653f12cc4eea9606c80142752612ad28f1ccdb45", "parents": [ "39a4bade8c1826b658316d66ee81c09b0a4d7d42" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun May 16 18:00:00 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun May 16 18:00:00 2010 -0400" }, "message": "ext4: Use our own write_cache_pages()\n\nMake a copy of write_cache_pages() for the benefit of\next4_da_writepages(). This allows us to simplify the code some, and\nwill allow us to further customize the code in future patches.\n\nThere are some nasty hacks in write_cache_pages(), which Linus has\n(correctly) characterized as vile. I\u0027ve just copied it into\nwrite_cache_pages_da(), without trying to clean those bits up lest I\nbreak something in the ext4\u0027s delalloc implementation, which is a bit\nfragile right now. This will allow Dave Chinner to clean up\nwrite_cache_pages() in mm/page-writeback.c, without worrying about\nbreaking ext4. Eventually write_cache_pages_da() will go away when I\nrewrite ext4\u0027s delayed allocation and create a general\next4_writepages() which is used for all of ext4\u0027s writeback. Until\nnow this is the lowest risk way to clean up the core\nwrite_cache_pages() function.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nCc: Dave Chinner \u003cdavid@fromorbit.com\u003e\n" }, { "commit": "fbe845ddf368f77f86aa7500f8fd2690f54c66a8", "tree": "81e62af0c35794a4c0a2802d0528cacb43f2b4de", "parents": [ "d4c402d9fd97a54bb7ed89f9e9869897eb4f6e1f" ], "author": { "name": "Curt Wohlgemuth", "email": "curtw@google.com", "time": "Sun May 16 13:00:00 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun May 16 13:00:00 2010 -0400" }, "message": "ext4: Remove extraneous newlines in ext4_msg() calls\n\nAddresses-Google-Bug: #2562325\n\nSigned-off-by: Curt Wohlgemuth \u003ccurtw@google.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "72b8ab9dde211ea518ff27e631b2046ef90c29a2", "tree": "f63fc1894bcc39c81060e2fd8b21bedd07a1e958", "parents": [ "0e05842bc117ea70ceb979cca798fd026879951b" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Sun May 16 11:00:00 2010 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sun May 16 11:00:00 2010 -0400" }, "message": "ext4: don\u0027t use quota reservation for speculative metadata\n\nBecause we can badly over-reserve metadata when we\ncalculate worst-case, it complicates things for quota, since\nwe must reserve and then claim later, retry on EDQUOT, etc.\nQuota is also a generally smaller pool than fs free blocks,\nso this over-reservation hurts more, and more often.\n\nI\u0027m of the opinion that it\u0027s not the worst thing to allow\nmetadata to push a user slightly over quota. This simplifies\nthe code and avoids the false quota rejections that result\nfrom worst-case speculation.\n\nThis patch stops the speculative quota-charging for\nworst-case metadata requirements, and just charges quota\nwhen the blocks are allocated at writeout. It also is\nable to remove the try-again loop on EDQUOT.\n\nThis patch has been tested indirectly by running the xfstests\nsuite with a hack to mount \u0026 enable quota prior to the test.\n\nI also did a more specific test of fragmenting freespace\nand then doing a large delalloc write under quota; quota\nstopped me at the right amount of file IO, and then the\nwriteout generated enough metadata (due to the fragmentation)\nthat it put me slightly over quota, as expected.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" } ], "next": "c445e3e0a5c2804524dec6e55f66d63f6bc5bc3e" }