)]}' { "log": [ { "commit": "dbf004d7883b3adb058c0c1a5635bc4ec27651c0", "tree": "cac67630ac8eaaba0ab6b7b4a24d617ae804d3f4", "parents": [ "2d13c8f0682bd38c74e89a76cc550f0324b610ba" ], "author": { "name": "Dave Jones", "email": "davej@redhat.com", "time": "Tue Jan 12 16:59:52 2010 -0500" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 12 20:56:52 2010 -0800" }, "message": "remove my email address from checkpatch.\n\nMaybe this will stop people emailing me about it.\n\nSigned-off-by: Dave Jones \u003cdavej@redhat.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5e8d8f6f2844d4a663415c660ab5cc92e2e2477d", "tree": "59df4708e3bc412cde2ba24769bc12087c4fc862", "parents": [ "2b474a1a566064b40bc7d9a45021ffbc4c894fa3" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:17 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: version 0.30\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2b474a1a566064b40bc7d9a45021ffbc4c894fa3", "tree": "9f65e5456a95272db6ec887eff472114bfcc5d31", "parents": [ "99423c2065b62fee41cdbd8da7e63bf1f8f9e9b0" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:16 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: fix false EXPORT_SYMBOL warning\n\nIngo reported that the following lines triggered a false warning,\n\nstatic struct lock_class_key rcu_lock_key;\nstruct lockdep_map rcu_lock_map \u003d\n STATIC_LOCKDEP_MAP_INIT(\"rcu_read_lock\", \u0026rcu_lock_key);\nEXPORT_SYMBOL_GPL(rcu_lock_map);\n\nfrom kernel/rcutree.c , and the false warning looked like this,\n\nWARNING: EXPORT_SYMBOL(foo); should immediately follow its\nfunction/variable\n+EXPORT_SYMBOL_GPL(rcu_lock_map);\n\nWe actually should be checking the statement before the EXPORT_* for a\nmention of the exported object, and complain where it is not there.\n\n[akpm@linux-foundation.org: coding-style fixes]\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nCc: Paul E. McKenney \u003cpaulmck@linux.vnet.ibm.com\u003e\nReported-by: Daniel Walker \u003cdwalker@fifo99.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "99423c2065b62fee41cdbd8da7e63bf1f8f9e9b0", "tree": "cce6a6498daee4630e0c1fa9f48ef922457cad68", "parents": [ "2ceb532b04b7a3b8f534d11a6e839f8b8bff94c1" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:15 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: fix __attribute__ matching\n\nIn the following code,\n\nunion thread_union init_thread_union\n\t__attribute__((__section__(\".data.init_task\"))) \u003d\n\t\t{ INIT_THREAD_INFO(init_task) };\n\nThere is a non-conforming declaration. It should really be like the\nfollowing,\n\nunion thread_union init_thread_union\n\t__attribute__((__section__(\".data.init_task\"))) \u003d {\n\t\tINIT_THREAD_INFO(init_task)\n};\n\nHowever, checkpatch doesn\u0027t catch this right now because it doesn\u0027t\ncorrectly evaluate the \"__attribute__\".\n\nIt is not at all clear that we care what preceeds an assignment style\nattribute when we find the open brace. Relax the test so we do not need\nto check the __attribute__.\n\nReported-by: Daniel Walker \u003cdwalker@fifo99.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2ceb532b04b7a3b8f534d11a6e839f8b8bff94c1", "tree": "44dd940b3f397dfc21344c94d4827a37985c2d50", "parents": [ "131edb3418018b6da297ed389b541e697043a8b6" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:14 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: fix false errors due to macro concatenation\n\nThe macro concatenation (##) sequence can cause false errors when checking\nmacro\u0027s. Checkpatch doesn\u0027t currently know about the operator.\n\nFor example this line,\n\n+ \tentry \u003d (struct ftrace_raw_##call *)raw_data; \\\n\nis correct but it produces the following error,\n\nERROR: need consistent spacing around \u0027*\u0027 (ctx:WxB)\n+ entry \u003d (struct ftrace_raw_##call *)raw_data;\\\n ^\n\nThe line above doesn\u0027t have any spacing problems, and if you remove the\nmacro concatenation sequence checkpatch doesn\u0027t give any errors.\n\nExtend identifier handling to include ## concatenation within the\ndefinition of an identifier.\n\nReported-by: Daniel Walker \u003cdwalker@fifo99.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "131edb3418018b6da297ed389b541e697043a8b6", "tree": "5db99acf8a14c2ddc18dcacae2fe5a9b8bb5d844", "parents": [ "cc77cdca5209c1199deb33f3a83df191ac32f4d6" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:14 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: update copyright dates\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "cc77cdca5209c1199deb33f3a83df191ac32f4d6", "tree": "23a1149ca4268d0e743b8e847d83fbda3f929067", "parents": [ "9a974fdbe3fbb4b0f6d552579dc79ac237412c61" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:13 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: correctly stop scanning at the bottom of a hunk\n\nWe are allowing context scanning checks to apply against the first line of\ncontext outside at the end of the hunk. This can lead to false matches to\npatch names leading to various perl warnings. Correctly stop at the\nbottom of the hunk.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9a974fdbe3fbb4b0f6d552579dc79ac237412c61", "tree": "bf865361b93077ae8464f459280cb86a9f414ad5", "parents": [ "1a83e175dc2c7be931a3ea9c7fb0769e6de55e90" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:12 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: possible types -- prevent illegal modifiers being added\n\nPrevent known non types being detected as modifiers. Ensure we do not\nlook at any type which starts with a keyword.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "42e41c54d61e32e8a349943607daa53205324d7f", "tree": "a38050a0b2e716100372601262273cdbd195baf8", "parents": [ "0487683096decad0720dfaf80b9d28173d5f6662" ], "author": { "name": "Mike Frysinger", "email": "vapier@gentoo.org", "time": "Mon Sep 21 17:04:40 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: add some common Blackfin checks\n\nAdd checks for Blackfin-specific issues that seem to crop up from time to\ntime. In particular, we have helper macros to break a 32bit address into\nthe hi/lo parts, and we want to make sure people use the csync/ssync\nvariant that includes fun anomaly workarounds.\n\nSigned-off-by: Mike Frysinger \u003cvapier@gentoo.org\u003e\nSigned-off-by: Bryan Wu \u003ccooloney@kernel.org\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0487683096decad0720dfaf80b9d28173d5f6662", "tree": "506241fcace0596fb4cf1e752d7f8aaa19295c8d", "parents": [ "fb9e9096ba94385b738a8ad6c5864b5778285957" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Sep 21 17:04:39 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: version 0.29\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fb9e9096ba94385b738a8ad6c5864b5778285957", "tree": "b066899e4c5a4ca033babb068acdc7d0132186c5", "parents": [ "ea71a0a019f913bdf506103bd90140d93a2b83f0" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Sep 21 17:04:38 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: limit sN/uN matches to actual bit sizes\n\nLimit our type matcher to the s/u/le/be etc sizes that actually exist to\nprevent miss categorising s2 as a type. Fix up the spelling of the error\nalso.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ea71a0a019f913bdf506103bd90140d93a2b83f0", "tree": "0d5cf1171809bf012054c7a028beb93450a664fa", "parents": [ "77f5b10a82bbd832c99ec4b120d5645342a5b140" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Sep 21 17:04:38 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: format strings should not have brackets in macros\n\nWe should not recommend braces for the following:\n\n #define pr_fmt(fmt) \"%s: \" fmt, __func__\n\nallow things with double quotes round them to avoid this check.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "77f5b10a82bbd832c99ec4b120d5645342a5b140", "tree": "13359c9798da6babc144262b59f777e664ac195e", "parents": [ "30dad6ebecffebddf6b9947d11e31377fa900ff3" ], "author": { "name": "Hannes Eder", "email": "hannes@hanneseder.net", "time": "Mon Sep 21 17:04:37 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: make -f alias --file, add --help, more verbose help message\n\nImpact:\n - More verbose help/usage message.\n - Make the option -f an alias for --file.\n - On -h, --help, and --version display help message and exit(0).\n - With no FILE(s) given, exit(1) with \"no input files\".\n - On invalid options display help/usage and exit(1).\n\nBased on a patch by Pavel Machek.\n\nSigned-off-by: Hannes Eder \u003channes@hanneseder.net\u003e\nAcked-by: Pavel Machek \u003cpavel@suse.cz\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "30dad6ebecffebddf6b9947d11e31377fa900ff3", "tree": "105febf76a8f69f2194383bf027cad7e8d257d1f", "parents": [ "113f04a836481e9ecc26e8dee8b0e4d52878a288" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Sep 21 17:04:36 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: indent checks -- stop when we run out of continuation lines\n\nEnsure we terminate when there are no futher continuation lines when\ntrying to determine relative indent of conditionals and their blocks.\n\nReported-by: John Daiker \u003cdaikerjohn@gmail.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "113f04a836481e9ecc26e8dee8b0e4d52878a288", "tree": "3f6261a456fd09d2219bb2fe80d90fd0c093f753", "parents": [ "463f28648586721c2191130c9b3c27589dcc11a0" ], "author": { "name": "Daniel Walker", "email": "dwalker@fifo99.com", "time": "Mon Sep 21 17:04:35 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:47 2009 -0700" }, "message": "checkpatch: handle C99 comments correctly (performance issue)\n\nThis fixes the sanitation process in checkpatch.pl so that it blocks out\nthe text after a C99 style comment the same way it does with block style\ncomments. This prevents the text from getting processed as regular code.\n\nSigned-off-by: Daniel Walker \u003cdwalker@fifo99.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "463f28648586721c2191130c9b3c27589dcc11a0", "tree": "6b9ae0d46a17cd4cd904168e5e818ef68b6c7a04", "parents": [ "fc0d8d944df0c58cd810f33db82f87dcf5dcc190" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Sep 21 17:04:34 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:47 2009 -0700" }, "message": "checkpatch: possible types -- else cannot start a type\n\nAn else cannot start a type, it would have to be within a block after the\nelse. This can trigger false modifier matching.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "bea5606d08a36a5fdcf815073d3593ddd2c8549e", "tree": "e9dcbbbe568da9b36dd68e8163d06b7c0ea29eb8", "parents": [ "417495eda3ce50f9c6d28f8e9ddb3bbb25f07f4c" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:09 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:22 2009 -0800" }, "message": "checkpatch: version 0.28\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "417495eda3ce50f9c6d28f8e9ddb3bbb25f07f4c", "tree": "f93d85862f5d97224b3541ec5e5d7998f3351c02", "parents": [ "9360b0e50e9f3e0fd70a077b4ede9885ebc21720" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:08 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:22 2009 -0800" }, "message": "checkpatch: add __ref as a sparse modifier\n\nAdd __ref as a sparse modifier.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9360b0e50e9f3e0fd70a077b4ede9885ebc21720", "tree": "065fa2a65de26e3a720a043b7eb699dc66dd7c42", "parents": [ "667026e7b082ad59eb7194d6b5d159ed6c340e05" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:08 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:22 2009 -0800" }, "message": "checkpatch: extend attribute testing to all modifiers\n\nWe should allow testing of all modifiers not just attributes. Extend\ntesting and test for all the know modifiers.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "667026e7b082ad59eb7194d6b5d159ed6c340e05", "tree": "3d3cab494ac822aee47d65847a09ed2ac8fa6332", "parents": [ "a3340b35787975414d5f6fee83e00640688be2cb" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:08 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:22 2009 -0800" }, "message": "checkpatch: a modifier is not an identifier at the end of a type\n\nWe must make sure we do not misrecognise a modifier as an Identifier\nwhen trying to match types. Prevent us matching this:\n\n\tvoid * __ref\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a3340b35787975414d5f6fee83e00640688be2cb", "tree": "48eadd0bde2f008de17ca1b780e428451b042942", "parents": [ "00ef4ece05096a5c523e265b8ce6627fb5e171c2" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:07 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:22 2009 -0800" }, "message": "checkpatch: pointer type star may have modifiers following\n\nWe may have any modifier following a pointer type star. Handle this:\n\n\tvoid * __user * __user foo;\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "00ef4ece05096a5c523e265b8ce6627fb5e171c2", "tree": "13e3db3b95e04ed3fd53dae599a947c87e87c799", "parents": [ "e2f7aa4b8bc811ebf8afbdf423caf90a5a03cb08" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:07 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:21 2009 -0800" }, "message": "checkpatch: correctly handle type spacing in the face of modifiers\n\nWe need to handle interspersed modifiers in the middle of pointer types,\nfor example:\n\n\tvoid * __user * __user bar;\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e2f7aa4b8bc811ebf8afbdf423caf90a5a03cb08", "tree": "2c3dc6651cbdf54d2a7234bdaa75664b93ca2945", "parents": [ "f4a8773676c21a68b0666fbe48af4fe1af89dfa9" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:06 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:21 2009 -0800" }, "message": "checkpatch: do not warn about -p0 patches when checking files\n\nWe are triggering the -p0 check for our own diffs generated using --file\ncommand line option. Suppress this check for files.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f4a8773676c21a68b0666fbe48af4fe1af89dfa9", "tree": "1ae344b48e791f3abf9310ec71bb15ddd72b2ae1", "parents": [ "cbb766766f3f2f6d9326c561b1020590642c6e39" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:05 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:21 2009 -0800" }, "message": "checkpatch: make in_atomic ok in the core\n\nWe say that in_atomic() is ok in the core kernel, but then always report\nit regardless of where in the kernel it is. Keep quiet if it is used in\nkernel/*.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "db92a6502d4e8cb885e85e862b24ba5c07036fbf", "tree": "6005f2c85621c1b7415e82e46bb8428667f0009b", "parents": [ "6903ffb2257266472ef2edd0092d526ae2dc00f7" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:07 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:39 2009 -0800" }, "message": "checkpatch: version: 0.27\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6903ffb2257266472ef2edd0092d526ae2dc00f7", "tree": "6892ad9fbef5b6aeabd0a0fd05d633c754defed1", "parents": [ "39667782362becd5527e48d6c976a9f9985b95e6" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:07 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:39 2009 -0800" }, "message": "checkpatch: struct seq_operations should normally be const\n\nIn the general use case struct seq_operations should be a const object.\nCheck for and warn where it is not.\n\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "39667782362becd5527e48d6c976a9f9985b95e6", "tree": "43fbe3e89848a863a857018d8e9e33ce07759bb8", "parents": [ "63f17f8973ccdb8260e59ce5b1b4e2b2ee0401f0" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:06 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:38 2009 -0800" }, "message": "checkpatch: if should not continue a preceeding brace\n\nWe should not be continuing a braced section with an if, for example:\n\n\tif (...) {\n\t} if (...) {\n\t}\n\nDetect this and suggest adding a newline.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "63f17f8973ccdb8260e59ce5b1b4e2b2ee0401f0", "tree": "d37e5333ccb5ea5467f6d98d2efd4c1daf681364", "parents": [ "f9a0b3d17a01fe1ba24ce1e9c18666a52052e011" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:06 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:38 2009 -0800" }, "message": "checkpatch: allow parentheses on return handle array values\n\nWhen we allow return to have surrounding parentheses when containing\ncomparison operators we are not correctly handling the case where the\nvalues contain array sufffixes. Squash them.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f9a0b3d17a01fe1ba24ce1e9c18666a52052e011", "tree": "09a19fe504f889ae3c2691641be992a21932978a", "parents": [ "a27506459c5e6ccc8437fca0adb6d3759c883c28" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:05 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:38 2009 -0800" }, "message": "checkpatch: type/cast spacing should not check prefix spacing\n\nWe should not be complaining about the prefix spacing for types and casts.\n We are triggering here because the check for spacing between \u0027*\u0027s is\noverly loose. Tighten this up.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a27506459c5e6ccc8437fca0adb6d3759c883c28", "tree": "7ebce7fae5d7d989952bbc152aa270043445ab1c", "parents": [ "c91192d66d6cea7878b8542c9d9f1873971aba92" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:04 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:38 2009 -0800" }, "message": "checkpatch: handle missing #if open in context\n\nIf the #if opening statement is not in the context then the context stack\ncan be empty. Handle this by ensuring there is always a blank entry in\nthe stack.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nTested-by: Dhaval Giani \u003cdhaval@linux.vnet.ibm.com\u003e\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "57b9c6d9c5074a06fda770a7f009d655593e0e29", "tree": "401b77bf8141f50c0c41095cbeda44f136fe8ce4", "parents": [ "21caa13c02d67f755fad50370996c489c34a9b15" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:30 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: version: 0.26\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "21caa13c02d67f755fad50370996c489c34a9b15", "tree": "adc788fef2b0eedcdd4fa35c6b321644979e499a", "parents": [ "2b6db5cb65cb1276a7aa363a6e7335b0a8a68393" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:30 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: fix the perlcritic errors\n\nClean up checkpatch using perlcritic.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2b6db5cb65cb1276a7aa363a6e7335b0a8a68393", "tree": "289e1048f76a56c551ef57aeb4adf54d4f9a3172", "parents": [ "b53c8e104ed071c47ada2adce194625ab03d9f3d" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:29 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: struct file_operations should normally be const\n\nIn the general use case struct file_operations should be a const object.\nCheck for and warn where it is not. As suggested by Steven and Ingo.\n\nAcked-by: Steven Rostedt \u003crostedt@goodmis.org\u003e\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b53c8e104ed071c47ada2adce194625ab03d9f3d", "tree": "52354de0c3b69be0cf5d0eb85510f82b74eb807a", "parents": [ "2d1bafd799ee0442979e6ce4145d58b69d3cade2" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:29 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: ensure we actually detect if assignments split across lines\n\nWhen checking for assignments within if conditionals we check the whole of\nthe condition, but the match is performed using a line constrained regular\nexpression. This means we can miss split conditionals or those on the\nsecond line. Allow the check to span lines.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2d1bafd799ee0442979e6ce4145d58b69d3cade2", "tree": "83002f1bac78f652032aa00d81233fe75cbac175", "parents": [ "4635f4fbaf51555509c747eed02a7e7a580ae1e1" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:28 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: do not report nr_static as a static declaration\n\nEnsure we do not report identifiers containing the word static as static\ndeclarations. For example this should not be reported as an unecessary\nassignement of 0:\n\n\tlong nr_static \u003d 0;\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4635f4fbaf51555509c747eed02a7e7a580ae1e1", "tree": "d3d9d3d26b1c7d302c1200110c5d51b5340183f6", "parents": [ "8b1b33786b06a222cf3430b1bf942a3681532104" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:27 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: track #ifdef/#else/#endif when tracking blocks\n\nWhen picking up a complete statement or block for analysis we cannot\nsimply track open/close/etc parenthesis we must take into account\npreprocessor section boundaries.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8b1b33786b06a222cf3430b1bf942a3681532104", "tree": "dcacb222ddc7320f67a30c93440a09b5bf2a0c76", "parents": [ "8054576dca7e76dd1f58c525af3309cfc9c74454" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:27 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: fix continuation detection when handling spacing on operators\n\nWe are miscategorising a continuation fragment following an operator\nwhich may lead to us thinking that there is a space after it when there is\nnot. Fix this up.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8054576dca7e76dd1f58c525af3309cfc9c74454", "tree": "f603d38b1ecbfaae5953dc32e0f9dae0b8c1bad6", "parents": [ "080ba929651a32f1840751d2b862e64c8ee1f0c6" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:26 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: loosen spacing on typedef function checks\n\nLoosen spacing checks to correctly detect this valid use of a typedef:\n\n\ttypedef struct rcu_data *(*get_data_func)(int);\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "080ba929651a32f1840751d2b862e64c8ee1f0c6", "tree": "a600273e6449d16d6256c66ea58ca060b22e8e6e", "parents": [ "86f9d059c6bc548f6337f01117897a4c823cb4ee" ], "author": { "name": "Mike Frysinger", "email": "vapier@gentoo.org", "time": "Tue Jan 06 14:41:25 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: try to catch missing VMLINUX_SYMBOL() in vmlinux.lds.h\n\nSeems like every other release we have someone who updates vmlinux.lds.h\nand adds C-visible symbols without VMLINUX_SYMBOL() around them. So start\nchecking the file and reject assignments which have plain symbols on\neither side.\n\n[apw@canonical.com: soften the check, add tests]\nSigned-off-by: Mike Frysinger \u003cvapier@gentoo.org\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "86f9d059c6bc548f6337f01117897a4c823cb4ee", "tree": "f7861404c3e84268a890f1cc3517bebaaa5bc49b", "parents": [ "1e85572697b348b1a126520349a29654f2ae6a12" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:24 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: allow parentheses on return for comparisons\n\nIt seems to be a common idiom to include braces on conditionals in all\ncontexts including return. Allow this exception to the return is not a\nfunction checks. Reported by Kay Sievers.\n\nCc: Kay Sievers \u003ckay.sievers@vrfy.org\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1e85572697b348b1a126520349a29654f2ae6a12", "tree": "1ce7febee025caa781c586090983718fde900c56", "parents": [ "2a5a2c25224e26c5ee491af0dc5d39e4a16f619c" ], "author": { "name": "Wolfram Sang", "email": "w.sang@pengutronix.de", "time": "Tue Jan 06 14:41:24 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: Add warning for p0-patches\n\nSome people work internally with -p0-patches which has the danger that one\nforgets to convert them to -p1 before mainlining. Bitten myself and seen\np0-patches in mailing lists occasionally, this patch adds a warning to\ncheckpatch.pl in case a patch is -p0. If you really want, you can fool\nthis check to generate false positives, this is why it just spits a\nwarning. Making the check 100% proof is trickier than it looks, so let\u0027s\nstart with a version which catches the cases of real use.\n\n[apw@canonical.com: update message language, handle null prefix, add tests]\nSigned-off-by: Wolfram Sang \u003cw.sang@pengutronix.de\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2a5a2c25224e26c5ee491af0dc5d39e4a16f619c", "tree": "958c4148a5db522cdc6ed8614332e0074cd53e39", "parents": [ "b0e0b4325375a360d33bace203e19471a9f9e067" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:23 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: update copyrights\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "50a7dcfb5062a5d9a0dcb28943a1e0cd5f0f60c2", "tree": "ced4023c0e9cc5c72e1fc986fe8496d4337bdc7c", "parents": [ "65863862ba112bf4d06d5ebc142b9d746d1ee955" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:21 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: version: 0.25\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "65863862ba112bf4d06d5ebc142b9d746d1ee955", "tree": "923755463967ded1f6f6d0e5a09cb92a628ac005", "parents": [ "fae17daed7312bae708df0cce7e93971308698b5" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:21 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: dissallow spaces between stars in pointer types\n\nDisallow spaces within multiple pointer stars (*) in both casts and\ndefinitions. Both of these would now be reported:\n\n\t(char * *)\n\tchar * *foo;\n\nAlso now consistently detects and reports the attributes within these\nstructures making the error report itself clearer.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fae17daed7312bae708df0cce7e93971308698b5", "tree": "c31028127007a5481dfec1b90a90f072e3517a89", "parents": [ "8e761b04a34288a3b0b29c0f49cdf157d7db8863" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:20 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: comment ends inside strings is most likely not an open comment\n\nWhen we are detecting whether a comment is open when we start a hunk we\ncheck for the first comment edge in the hunk and assume its inverse.\nHowever if the hunk contains something like below, then we will assume\nthat a comment was open. Update this heuristic to see if the comment edge\nis obviously within double quotes and ignore it if so:\n\n\tfoo(\" */);\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8e761b04a34288a3b0b29c0f49cdf157d7db8863", "tree": "70aa571d291926c33327acffa4923d0124cd9b12", "parents": [ "5fe3af119bed58d240e2097fe76f322ab51902d7" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:19 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: detect multiple bitfield declarations\n\nDetect the colons (:) which make up secondary bitfield declarations and\napply binary colon checks. For example the following is common idiom:\n\n\tint foo:1,\n\t bar:1;\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5fe3af119bed58d240e2097fe76f322ab51902d7", "tree": "6b0c8b5f9bf1fc78d0c3f1208da641031a51df4b", "parents": [ "383099fd636deacf698b91b4c96d0d6d01e6dc79" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:18 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: __weak is an official attribute\n\nAdd __weak as an official attribute. This tends to be used in a location\nwhere the automated attribute detector misses it.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "383099fd636deacf698b91b4c96d0d6d01e6dc79", "tree": "d7cbbc220794407a160863ce12f54e06244e95d6", "parents": [ "83242e0c239aaa33e757584605f788ac1eca2f0f" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:18 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: structure member assignments are not complex\n\nEnsure we do not trigger the complex macros checks on structure member\nassignment, for example:\n\n\t#define foo .bar \u003d 10\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "83242e0c239aaa33e757584605f788ac1eca2f0f", "tree": "fa114470eebf1bb00dc97ad6a0620a5f5cc4d308", "parents": [ "721c1cb60e0546d2e71b9aa50426c94e69c6521a" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:17 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: widen implied comment detection to allow multiple stars\n\nSome people use double star \u0027**\u0027 as a comment continuation, and start\ncomments with complete lines of stars. Widen the implied comment\ndetection to pick these up.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "721c1cb60e0546d2e71b9aa50426c94e69c6521a", "tree": "69c767f29569545e1ec8e950fce4b4a03ae970fe", "parents": [ "691d77b6b85c20e4166bafd12bd0131b28f95a16" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:16 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: comment detection may miss an implied comment on the last hunk\n\nWhen detecting implied comments from leading stars we may incorrectly\nthink we have detected an edge one way or the other when we have not if we\ndrop off the end of the last hunk. Fix this up.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "691d77b6b85c20e4166bafd12bd0131b28f95a16", "tree": "b7c8950fadd6d3cf3a949d3977597cd0388544e8", "parents": [ "94e2959e7a6a4ef0969932c30349ce6f4469a3cf" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:16 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: add checks for in_atomic()\n\nin_atomic() is not for driver use so report any such use as an ERROR.\nAlso in_atomic() is often used to determine if we may sleep, but it is not\nreliable in this use model therefore strongly discourage its use.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f4432c5caec5fa95ea7eefd00f8e6cee17e2e023", "tree": "677d41b0c8ad3f72157302ddb4e61428ccbee24e", "parents": [ "6da0b38f4433fb0f24615449d7966471b6e5eae0" ], "author": { "name": "Dave Jones", "email": "davej@redhat.com", "time": "Mon Oct 20 13:31:45 2008 -0400" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Oct 20 12:50:03 2008 -0700" }, "message": "Update email addresses.\n\nUpdate assorted email addresses and related info to point\nto a single current, valid address.\n\nadditionally\n- trivial CREDITS entry updates. (Not that this file means much any more)\n- remove arjans dead redhat.com address from powernow driver\n\nSigned-off-by: Dave Jones \u003cdavej@redhat.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6e144ee546b4bb4902524e639dc9c2cd4f7f97a4", "tree": "ee327fa420db4111e0b90ece3d7d21991d05763e", "parents": [ "3fef12d6cb832327a981b03326f8f07abebb51b7" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:36 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:38 2008 -0700" }, "message": "checkpatch: version: 0.24\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3fef12d6cb832327a981b03326f8f07abebb51b7", "tree": "418ea019c04e979862e47dd423ccb92ea5f04e3b", "parents": [ "740504c61f79a932564fb7117d79ad53d950b201" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:36 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: allow for comments either side of a brace on case\n\nWhen specifying case we may have comments and/or braces at the end without\nactually having a \u0027statement\u0027. Allow for these to occur in any order.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "740504c61f79a932564fb7117d79ad53d950b201", "tree": "932ad076982cb1fa4aaffbf8bb73c16667b772ea", "parents": [ "bb44ad39c886401e1ffe0876565f8b3fcea64e9d" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:35 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: suspect indent handle macro continuation\n\nWhen ignoring a macro in the middle of a conditional, we need to ignore\nthe macro start and any continuation lines.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "bb44ad39c886401e1ffe0876565f8b3fcea64e9d", "tree": "a204881902ff7b68dd45eefde815e43a78297a6a", "parents": [ "480120586464e5a8cd2289a90ffbb5c042e66ba0" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:34 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: trailing statements ensure we report the end of the line\n\nWhen reporting some complex trailing statements we report only the\nstarting line of the error, that tends to imply the shown line is in error\nand confuse the reader. As we do know where the actual error is report\nthat line too with an appropriate gap marker where applicable.\n\n #ERROR: trailing statements should be on next line\n #1: FILE: Z202.c:1:\n + for (pbh \u003d page_buffers(bh-\u003eb_page); pbh !\u003d bh;\n + pbh \u003d pbh-\u003eb_this_page, key++);\n #ERROR: trailing statements should be on next line\n #4: FILE: Z202.c:4:\n + for (pbh \u003d page_buffers(bh-\u003eb_page);\n [...]\n + pbh \u003d pbh-\u003eb_this_page, key++);\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "480120586464e5a8cd2289a90ffbb5c042e66ba0", "tree": "27485bdf461c4cf6323e5eec5a9ee55b8b90c8fc", "parents": [ "bf30d6ede099c2a31b13bbd05b1022dc0da684d5" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:34 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: DEFINE_ macros are real definitions for exports\n\nWhen we want to confirm an export is directly after its definition we need\nto allow for DEFINE_ style macros. Add these to the execeptions.\nRefactor the exceptions.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "bf30d6ede099c2a31b13bbd05b1022dc0da684d5", "tree": "54bf58e8077d06b7430b08044241cc230d5f5fca", "parents": [ "f16fa28f7b3d95e989fc64c8480e44c1bcf4bac3" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:33 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: complex macros checks miss square brackets\n\nWe are missing \u0027simple\u0027 values which include square brackets. Refactor to\nensure we handle nesting correctly and detect these simple forms.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f16fa28f7b3d95e989fc64c8480e44c1bcf4bac3", "tree": "e9a6c9f84efc907f4e24a96f386ea1645536fc90", "parents": [ "8ed22cad9ce16e3d8915ae75544a133c3050d96f" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:32 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: suspect code indent must stop at #else/#elif\n\nWhen we hit and #else or #elif we know we are meeting an alternative piece\nof code. All bets are off on indent if we did not see the open of the\ncontrol so stop checking.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8ed22cad9ce16e3d8915ae75544a133c3050d96f", "tree": "b82dc56ffae056078d65d385adb6053f7146b2ba", "parents": [ "afbe8d283b97b2317dab900fb11d2a8878ee3c23" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:32 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: pull out known acceptable typedefs\n\nWithin the type checker we have a number of common kernel types which must\nbe implemented as typedefs. Pull those out so that we can use the same\nexpressions to trigger exclusions.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "afbe8d283b97b2317dab900fb11d2a8878ee3c23", "tree": "ff555e381fef88472de262ad94c22e22943981dd", "parents": [ "b132e5d5865325a9aa42b122c4c466903bf48348" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:31 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: accept any sized le/be type\n\nWe are likely going to have 24 bit types. Expand the type matcher to\nmatch any size.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b132e5d5865325a9aa42b122c4c466903bf48348", "tree": "0032e6513e7ae5353357c0fbf605ecda6a9cf831", "parents": [ "170d3a22688f06fda42e353bbccd0f3df89f3d94" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:31 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: macros which define structure members are not complex\n\nWe often see macros which define structure members, these are not complex\nand necessarily do not have braces or brackets. For example:\n\n #define _PLIST_HEAD_INIT(head) \\\n .prio_list \u003d LIST_HEAD_INIT((head).prio_list), \\\n .node_list \u003d LIST_HEAD_INIT((head).node_list)\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "170d3a22688f06fda42e353bbccd0f3df89f3d94", "tree": "77dda2b9e7890d95452cfe3255d8d83187be579a", "parents": [ "a6a84062821738426ed4f58f4d584ecb7feb3dee" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:30 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: handle do without braces if we have enough context\n\nIf we have sufficient context detect and handle do without braces ({).\nElse these incorrectly trigger a trailing statements error for the\nassociated while.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a6a84062821738426ed4f58f4d584ecb7feb3dee", "tree": "7e3da286264b20d4f962fcd72c9019b13253a1d5", "parents": [ "0776e594606e32a045e0a99bb919b2280b945495" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:30 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: labels are not possible types\n\nA label is not a candidate for a possible type. Exclude them.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0776e594606e32a045e0a99bb919b2280b945495", "tree": "da5cb9f363484fcf343c72b7b48ada5191b97cf0", "parents": [ "5fdd23acf9cd7f658746b119436ed1d787326c46" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:29 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:36 2008 -0700" }, "message": "checkpatch: do is not a possible type\n\nA do without braces \u0027{\u0027 may trigger a false possible type \u0027do\u0027 and then\nthis may be interpreted as an external definition of foo():\n\n\tdo\n\t\tfoo();\n\twhile (bar);\n\nAdd do to the type exclusions. Fix up tests so we can check for them.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5fdd23acf9cd7f658746b119436ed1d787326c46", "tree": "0c555352123af8e330ceeb678acc69ffc1c11928", "parents": [ "306708547b566ef6a0ccd470c84568807571885c" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:28 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:36 2008 -0700" }, "message": "checkpatch: version: 0.23\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "306708547b566ef6a0ccd470c84568807571885c", "tree": "028c2ab4d3abefe272cf6ad02e11f10474d0b667", "parents": [ "6f779c18ca74358b6ac8eb8f5d502843fa92be4e" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:28 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:36 2008 -0700" }, "message": "checkpatch: ensure we only apply checks to the lines within hunks\n\nWe should only apply source checks to lines within hunks. Checks which\nare anchored in the context may falsly trigger in the commentory. Ensure\nthey only match within valid hunk lines.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6f779c18ca74358b6ac8eb8f5d502843fa92be4e", "tree": "c40e6fe4bd88c7f6c2f892cfcc965f972f0b9cad", "parents": [ "5368df20fb364e394da3ab88d3d60ee3c0a9e5ba" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:27 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:36 2008 -0700" }, "message": "checkpatch: suspect indent count condition lines correctly\n\nCorrect calculation of the number of lines of condition where we have\nsuspect indent.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5368df20fb364e394da3ab88d3d60ee3c0a9e5ba", "tree": "b81cf91c95ab0eb2014c6c62d3bec1491d2ff6cd", "parents": [ "81bc0e020232a1e1e7010376382bb59ca82927ac" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:27 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:36 2008 -0700" }, "message": "checkpatch: check line endings in text format files\n\nFirmware may be included in the kernel as .ihex files. These are\ninherantly text, but not source. The line ending checks are applicable to\nthese kinds of file, allow just these checks to apply to all files.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "81bc0e020232a1e1e7010376382bb59ca82927ac", "tree": "2b2efb18efca7c9a17d4e1f32d40f94f95101d57", "parents": [ "dea33496ddc2bf1a50e9def87b4ef14709d8cb6d" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:26 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:36 2008 -0700" }, "message": "checkpatch: handle comment/quote nesting correctly\n\nEnsure that a close comment cannot incorrectly trigger in the middle of a\nstring. Reported by Jaswinder Singh.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nCc: Jaswinder Singh \u003cjaswinder@infradead.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "dea33496ddc2bf1a50e9def87b4ef14709d8cb6d", "tree": "d0bd6df3188763f38a42ddc1fd562a1dd2fee0e2", "parents": [ "a1080bf80862c571b5f0a20cb601e24dd90e2026" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:25 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:36 2008 -0700" }, "message": "checkpatch: suppress errors triggered by short patch\n\nWhen the last hunk of a patch is short it will trigger errors from\ncheckpatch:\n\n Use of uninitialized value in pattern match (m//)\n\t at /usr/local/bin/checkpatch.pl line 394.\n Use of uninitialized value in concatenation (.) or string\n\t at /usr/local/bin/checkpatch.pl line 397.\n Use of uninitialized value in pattern match (m//)\n\nAvoid touching beyond the last line. Reported by Julien Brunel.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nCc: Julien Brunel \u003cbrunel@diku.dk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a1080bf80862c571b5f0a20cb601e24dd90e2026", "tree": "0aae05e30c0107a6286bce04692c7d17b4f1f632", "parents": [ "dea79cd3dfb4a50e4c3d0dcb7294f6d633b455d1" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:25 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:36 2008 -0700" }, "message": "checkpatch: case/default checks should only check changed lines\n\nWe should only be checking changes lines for the trailing statement check\non case/default statements.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "dea79cd3dfb4a50e4c3d0dcb7294f6d633b455d1", "tree": "23dea3a259163a03744de31f580c760c5ed75216", "parents": [ "b9ea10d691ecb616ce9e4d7a51400dfd93f52b2d" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:24 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: version: 0.22\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b9ea10d691ecb616ce9e4d7a51400dfd93f52b2d", "tree": "777d09db4fb4f27a44b3bd524bc4c4d3679d7670", "parents": [ "f055663c5853aa1d9f4c86351a4637462a0b9041" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:24 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: perform indent checks on perl\n\nSo that we eat our own dog food ensure the indent checks apply to perl\ntoo.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f055663c5853aa1d9f4c86351a4637462a0b9041", "tree": "ff000717ccecc62cea6832852f2e3e229007489b", "parents": [ "2a1bc5d5c5096f2dfb6f8b18f39ecb718f101535" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:23 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: report the correct lines for single statement blocks\n\nReport the correct lines for single statement blocks. Currently we are\nreporting the right number of lines, but not skipping the negative lines.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2a1bc5d5c5096f2dfb6f8b18f39ecb718f101535", "tree": "877a3ab1828a452f0592a58d0f171e2ffe86dc1a", "parents": [ "9bd49efe4e4bf88d9c1026db50325fd1b2e59519" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:23 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: %Lx tests should hand %% as a literal\n\nEnsure that we handle literal %\u0027s correctly when adjacent to a %Lx.\n\n\t%Lx\tbad\n\t%%Lx\tgood\n\t%%%Lx\tbad\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9bd49efe4e4bf88d9c1026db50325fd1b2e59519", "tree": "d768c2adcefd444c0bd8742ce8246e131be32a47", "parents": [ "4d001e4d88a57ba8347b43e3a20412cd6b67fbd7" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:22 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: suspect indent -- skip over preprocessor, label and blank lines\n\nWe should skip over and check the lines which follow preprocessor\nstatements, labels, and blank lines. These all have legitimate reasons to\nbe indented differently.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4d001e4d88a57ba8347b43e3a20412cd6b67fbd7", "tree": "9b329c20dd57496414b2b78bdddd9a9f5fc5dc6d", "parents": [ "6ecd967444223cea4a02d55fdc0f0510baa69523" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:21 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: report the real first line of all suspect indents\n\nWe are currently only reporting syspect indents if the conditional is\nmodified but the indent missmatch could be generated by the body changing,\nmake sure we catch both. Also only report the first line of the body, and\nmore importantly make sure we report the raw copy of the line. Finally\nreport the indent levels to make it easier to understand what is wrong.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6ecd967444223cea4a02d55fdc0f0510baa69523", "tree": "852a9a63f4dc4f13dd07126c81209d595e51097f", "parents": [ "e09dec4831bbb319987215ea0a280b2a620021b7" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:21 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: report any absolute references to kernel source files\n\nAbsolute references to kernel source files are generally only useful\nlocally to the originator of the patch. Check for any such references and\nreport them.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e09dec4831bbb319987215ea0a280b2a620021b7", "tree": "61a66f78f37b264a6e039eeef86453c75c4dd1ff", "parents": [ "c1ab33269a84d6056d2ffc728d8bbaa26377d3e3" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:20 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: reduce warnings for #include of asm/foo.h to check from arch/bar.c\n\nIt is much more likely that an architecture file will want to directly\ninclude asm header files. Reduce this WARNING to a CHECK when the\nreferencing file is in the arch directory.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c1ab33269a84d6056d2ffc728d8bbaa26377d3e3", "tree": "47b3f64f324e7569183857cfd26167b8609678a4", "parents": [ "01fa91471e9559d72c0c93ea7cca6f9fe6c2d1c3" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:20 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: include/asm checks should be anchored\n\nIt is possible to have other include/asm paths within the tree which are\nnot subject to the do not edit checks. Ignore those.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "01fa91471e9559d72c0c93ea7cca6f9fe6c2d1c3", "tree": "d019ae001cd1ec82eff617388dce2d0ce9ac3159", "parents": [ "636d140a80912693be466e8d978e658189972989" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:19 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: fix up comment checks search to scan the entire block\n\nWe are not counting the lines in the block correctly which causes the\ncomment scan to stop prematurly and thus miss comments which end at the\nend of the block. Fix this up.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "636d140a80912693be466e8d978e658189972989", "tree": "3b306a0ed7c7fc662d21a2e5db5deb22fd252792", "parents": [ "24e1d81acd447c3a7ec9eb90f24c00edc5a4b09f" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:18 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: complex macros -- fix up extension handling\n\nOnly pull in new extension lines where the current contents ends with a \\.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "24e1d81acd447c3a7ec9eb90f24c00edc5a4b09f", "tree": "e6b199e4a2a4f88329f02bd3919eb25bc1c8dea3", "parents": [ "a1ef277e2c88c80cfa00580469133e2215442c8d" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:18 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: ____cacheline_aligned et al are modifiers\n\nAdd the cacheline alignment modifiers to the attribute lists.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a1ef277e2c88c80cfa00580469133e2215442c8d", "tree": "d5306eda9a9d765fc05af689c7e0611a7b33e593", "parents": [ "1bdab9e5881fde3bf66528db5b91477ce4b35b3b" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:17 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:35 2008 -0700" }, "message": "checkpatch: add tests for the attribute matcher\n\nAdd support for direct testing of the attribute matcher, add basic tests\nfor it.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1bdab9e5881fde3bf66528db5b91477ce4b35b3b", "tree": "286e57468f42dd1acb83d810d049598b7e3978a6", "parents": [ "14b111c158116f02c1c862397075e28ac12d65d6" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:17 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:34 2008 -0700" }, "message": "checkpatch: switch indent allow plain return\n\nIt is a common and sane idiom to allow a single return on the end of a\ncase statement:\n\n\tswitch (...) {\n\tcase foo:\treturn bar;\n\t}\n\nAdd an exception for this.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "14b111c158116f02c1c862397075e28ac12d65d6", "tree": "136c634a2edfecfb1b8f85e3abbf9023faad80c5", "parents": [ "0d413866c7df63794790518e3fd5890969c206ad" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:16 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:34 2008 -0700" }, "message": "checkpatch: conditional indent -- labels have different indent rules\n\nLabels have different indent rules and must be ignored when checking the\nconditional indent levels. Also correct identify labels in single\nstatement conditionals.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0d413866c7df63794790518e3fd5890969c206ad", "tree": "2b5ab7a342959853fc30cb65584b603242f02bf4", "parents": [ "fe2a7dbc85f37c721133c83c856f845c4ce9b602" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:16 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:34 2008 -0700" }, "message": "checkpatch: values: double ampersand may be unary\n\nIt is possible to use double ampersand (\u0026\u0026) in unary context where it\nmeans the address of a goto label. Handle spacing for it.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fe2a7dbc85f37c721133c83c856f845c4ce9b602", "tree": "cbf28b825b378678812884be6543fddde0a87c41", "parents": [ "0fcff28f47194445f37264d750dbb13d3d894d0b" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:15 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:34 2008 -0700" }, "message": "checkpatch: square brackets -- exemption for array slices in braces\n\nIt is wholy reasonable to have square brackets representing array slices\nin braces on the same line. These should be spaced.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "33cba0657393a75e18e1781e3e13613303f18124", "tree": "81e492d8d9611cddd70165bd3def46a53773a482", "parents": [ "234fff6515a11cf3e67c793146689da426787fea" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:12 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "checkpatch: version 0.21\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "234fff6515a11cf3e67c793146689da426787fea", "tree": "a16d881c498f1db608ed4c571186a2c42e3f12e8", "parents": [ "292f1a9b342d763f94ea3915726a48905be4acd1" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:12 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: types cannot start mid word for pointer tests\n\nWhen checking spacing for pointer checks the type cannot start in the\nmiddle of a word, ie. this is not \u0027int * bar\u0027:\n\n\tx \u003d fooint * bar;\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "292f1a9b342d763f94ea3915726a48905be4acd1", "tree": "599e54b48cddb386cd373520ad85a4dc13b7087d", "parents": [ "74048ed811152a995a88945ba9e0dded34adfff4" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:11 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: complex macros need to ignore comments\n\nEnsure we ignore comments in complex macro detection else we incorrectly\nreport this:\n\n\t#define PFM_GROUP_PERM_ANY -1 /* any user/group */\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "74048ed811152a995a88945ba9e0dded34adfff4", "tree": "6a129872a995f6fe24d02f3754ec50b69a6bd3f6", "parents": [ "1f65f947a6a875e1fe7867dc08e981c4101d435d" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:10 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: variants -- move the main unary/binary operators to use variants\n\nNow that we have a variants system, move to using that to carry the\nunary/binary designation for +, -, \u0026, and *.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1f65f947a6a875e1fe7867dc08e981c4101d435d", "tree": "2dec76eed9d3dd6a48bc226fbe3a6d2fa813af9c", "parents": [ "d2506586586c59f5db0e2ce00d5d31ccec6260b8" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:10 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: add checks for question mark and colon spacing\n\nAdd checks for the question mark colon operator spacing, and also check\nthe other uses of colon. Colon means a number of things:\n\n - it introduces the else part of the ?: operator,\n - it terminates a goto label,\n - it terminates the case value,\n - it separates the identifier from the bit size on bit fields, and\n - it is used to introduce option types in asm().\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d2506586586c59f5db0e2ce00d5d31ccec6260b8", "tree": "f55f7723e9a1ad6bcb5826bbb9a73b2579f7b846", "parents": [ "0221f55c142b0ac8baf6f0b6c4e1ec89f0c98e96" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:09 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: possible modifiers -- handle multiple modifiers and trailing\n\nAdd support for multiple modifiers such as:\n\n\tint __one __two foo;\n\nAlso handle trailing known modifiers when defecting modifiers:\n\n\tint __one foo __read_mostly;\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0221f55c142b0ac8baf6f0b6c4e1ec89f0c98e96", "tree": "49e16ea22f6247213e7fe7bba664ceba026ea783", "parents": [ "8ea3eb9a20f39d5afa52900a34092b4b5f6b55cb" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:08 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: possible types -- known modifiers cannot be types\n\nEnsure we do not inadvertantly load known modifiers up as possible types.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8ea3eb9a20f39d5afa52900a34092b4b5f6b55cb", "tree": "ad79fe0bade637209967aadf23a34447c717fe1a", "parents": [ "b8f96a31f38c8e9fc75f0a89c6815e7cbc402858" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:08 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: handle return types of pointers to functions\n\nMake sure we correctly mark the return type of the pointer to a function\ndeclaration.\n\n const void *(*sb_tag)(struct sysfs_tag_info *info);\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b8f96a31f38c8e9fc75f0a89c6815e7cbc402858", "tree": "d68058c4329c6cb32255f905a2aac02a3bfac273", "parents": [ "d2172eb5bd4b7d06577113ec40635083619ca54a" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:07 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: macro complexity checks are meaningless in linker scripts\n\nExclude vmlinux.lds.h from the macro complexity checks. They will never\napply sanely here.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d2172eb5bd4b7d06577113ec40635083619ca54a", "tree": "1a60f2c34a4b5da1d256e1b2f281a994ebe91c15", "parents": [ "7429c6903e3628fc2cfea65ec7e13bac030c7bfe" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:07 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: possible modifiers are not being correctly matched\n\nAlthough we are finding the added modifier in the declaration below\nwe are not correctly matching it as a type. Fix the declaration.\n\n static void __ref *vmem_alloc_pages(unsigned int order)\n {\n }\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7429c6903e3628fc2cfea65ec7e13bac030c7bfe", "tree": "47f51d123e1e6d8b75a8e8337592638953252fe6", "parents": [ "389a2fe57ffc59a649bea39db4d7e6d2eff2b562" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:06 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: improve type matcher debug\n\nImprove type matcher debug so we can see what it does match. As part\nof this move us to to using the common debug framework.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" } ], "next": "389a2fe57ffc59a649bea39db4d7e6d2eff2b562" }