)]}' { "log": [ { "commit": "b3e19d924b6eaf2ca7d22cba99a517c5171007b6", "tree": "8c1fa4074114a883a4e2de2f7d12eb29ed91bdf1", "parents": [ "c6653a838b1b2738561aff0b8c0f62a9b714bdd9" ], "author": { "name": "Nick Piggin", "email": "npiggin@kernel.dk", "time": "Fri Jan 07 17:50:11 2011 +1100" }, "committer": { "name": "Nick Piggin", "email": "npiggin@kernel.dk", "time": "Fri Jan 07 17:50:33 2011 +1100" }, "message": "fs: scale mntget/mntput\n\nThe problem that this patch aims to fix is vfsmount refcounting scalability.\nWe need to take a reference on the vfsmount for every successful path lookup,\nwhich often go to the same mount point.\n\nThe fundamental difficulty is that a \"simple\" reference count can never be made\nscalable, because any time a reference is dropped, we must check whether that\nwas the last reference. To do that requires communication with all other CPUs\nthat may have taken a reference count.\n\nWe can make refcounts more scalable in a couple of ways, involving keeping\ndistributed counters, and checking for the global-zero condition less\nfrequently.\n\n- check the global sum once every interval (this will delay zero detection\n for some interval, so it\u0027s probably a showstopper for vfsmounts).\n\n- keep a local count and only taking the global sum when local reaches 0 (this\n is difficult for vfsmounts, because we can\u0027t hold preempt off for the life of\n a reference, so a counter would need to be per-thread or tied strongly to a\n particular CPU which requires more locking).\n\n- keep a local difference of increments and decrements, which allows us to sum\n the total difference and hence find the refcount when summing all CPUs. Then,\n keep a single integer \"long\" refcount for slow and long lasting references,\n and only take the global sum of local counters when the long refcount is 0.\n\nThis last scheme is what I implemented here. Attached mounts and process root\nand working directory references are \"long\" references, and everything else is\na short reference.\n\nThis allows scalable vfsmount references during path walking over mounted\nsubtrees and unattached (lazy umounted) mounts with processes still running\nin them.\n\nThis results in one fewer atomic op in the fastpath: mntget is now just a\nper-CPU inc, rather than an atomic inc; and mntput just requires a spinlock\nand non-atomic decrement in the common case. However code is otherwise bigger\nand heavier, so single threaded performance is basically a wash.\n\nSigned-off-by: Nick Piggin \u003cnpiggin@kernel.dk\u003e\n" }, { "commit": "ceb5bdc2d246f6d81cf61ed70f325308a11821d2", "tree": "65fc9e0227994d4ffc80530dd15bb5a9672a295e", "parents": [ "626d607435617cc0f033522083e2bb195b81813c" ], "author": { "name": "Nick Piggin", "email": "npiggin@kernel.dk", "time": "Fri Jan 07 17:50:05 2011 +1100" }, "committer": { "name": "Nick Piggin", "email": "npiggin@kernel.dk", "time": "Fri Jan 07 17:50:31 2011 +1100" }, "message": "fs: dcache per-bucket dcache hash locking\n\nWe can turn the dcache hash locking from a global dcache_hash_lock into\nper-bucket locking.\n\nSigned-off-by: Nick Piggin \u003cnpiggin@kernel.dk\u003e\n" }, { "commit": "ceefda6931806972ecf550bd8231dce4a4178953", "tree": "46ed42a053f1ed43c3c110a21637a7b071657c8a", "parents": [ "aed1d84f98738bcc1c605e1ff442de9890441315" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Jul 26 13:16:50 2010 +0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri Oct 29 04:17:03 2010 -0400" }, "message": "switch get_sb_ns() users\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "3c26ff6e499ee7e6f9f2bc7da5f2f30d80862ecf", "tree": "bd758d7f15f24aed225a64de77cc535785c50f96", "parents": [ "fc14f2fef682df677d64a145256dbd263df2aa7b" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sun Jul 25 11:46:36 2010 +0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri Oct 29 04:16:31 2010 -0400" }, "message": "convert get_sb_nodev() users\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "fc14f2fef682df677d64a145256dbd263df2aa7b", "tree": "74f6b939fbad959a43c04ec646cd0adc8af5f53a", "parents": [ "848b83a59b772b8f102bc5e3f1187c2fa5676959" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sun Jul 25 01:48:30 2010 +0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri Oct 29 04:16:28 2010 -0400" }, "message": "convert get_sb_single() users\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "152a08366671080f27b32e0c411ad620c5f88b57", "tree": "d13d16028f74839c678bce355ba8aac75d939fa8", "parents": [ "c96e41e92b4aaf11e1f9775ecf0d1c8cbff829ed" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sun Jul 25 00:46:55 2010 +0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri Oct 29 04:16:13 2010 -0400" }, "message": "new helper: mount_bdev()\n\n... and switch of the obvious get_sb_bdev() users to -\u003emount()\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "c96e41e92b4aaf11e1f9775ecf0d1c8cbff829ed", "tree": "5c24ad8aa541018a51e1704dccfc370116bb932f", "parents": [ "d893f1bc2a9f0f7dcb4b433452c59f9bedac0d7d" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sun Jul 25 00:17:56 2010 +0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri Oct 29 04:15:06 2010 -0400" }, "message": "beginning of transtion: -\u003emount()\n\neventual replacement for -\u003eget_sb() - does *not* get vfsmount,\nreturn ERR_PTR(error) or root of subtree to be mounted.\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "63997e98a3be68d7cec806d22bf9b02b2e1daabb", "tree": "acd366273dc459d6b34e7f67216c06eb56117a4a", "parents": [ "9843b76aae80293f5b5a0e275360627508595ce5" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Oct 25 20:49:35 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Oct 25 21:27:18 2010 -0400" }, "message": "split invalidate_inodes()\n\nPull removal of fsnotify marks into generic_shutdown_super().\nSplit umount-time work into a new function - evict_inodes().\nMake sure that invalidate_inodes() will be able to cope with\nI_FREEING once we change locking in iput().\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "6416ccb7899960868f5016751fb81bf25213d24f", "tree": "457069571211e4ece844dc332a2f9673705a5bde", "parents": [ "2dc91abe03d8ce6dd7f9251faffafca5f6b9e85d" ], "author": { "name": "Nick Piggin", "email": "npiggin@kernel.dk", "time": "Wed Aug 18 04:37:38 2010 +1000" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Aug 18 08:35:48 2010 -0400" }, "message": "fs: scale files_lock\n\nfs: scale files_lock\n\nImprove scalability of files_lock by adding per-cpu, per-sb files lists,\nprotected with an lglock. The lglock provides fast access to the per-cpu lists\nto add and remove files. It also provides a snapshot of all the per-cpu lists\n(although this is very slow).\n\nOne difficulty with this approach is that a file can be removed from the list\nby another CPU. We must track which per-cpu list the file is on with a new\nvariale in the file struct (packed into a hole on 64-bit archs). Scalability\ncould suffer if files are frequently removed from different cpu\u0027s list.\n\nHowever loads with frequent removal of files imply short interval between\nadding and removing the files, and the scheduler attempts to avoid moving\nprocesses too far away. Also, even in the case of cross-CPU removal, the\nhardware has much more opportunity to parallelise cacheline transfers with N\ncachelines than with 1.\n\nA worst-case test of 1 CPU allocating files subsequently being freed by N CPUs\ndegenerates to contending on a single lock, which is no worse than before. When\nmore than one CPU are allocating files, even if they are always freed by\ndifferent CPUs, there will be more parallelism than the single-lock case.\n\nTesting results:\n\nOn a 2 socket, 8 core opteron, I measure the number of times the lock is taken\nto remove the file, the number of times it is removed by the same CPU that\nadded it, and the number of times it is removed by the same node that added it.\n\nBooting: locks\u003d 25049 cpu-hits\u003d 23174 (92.5%) node-hits\u003d 23945 (95.6%)\nkbuild -j16 locks\u003d2281913 cpu-hits\u003d2208126 (96.8%) node-hits\u003d2252674 (98.7%)\ndbench 64 locks\u003d4306582 cpu-hits\u003d4287247 (99.6%) node-hits\u003d4299527 (99.8%)\n\nSo a file is removed from the same CPU it was added by over 90% of the time.\nIt remains within the same node 95% of the time.\n\nTim Chen ran some numbers for a 64 thread Nehalem system performing a compile.\n\n throughput\n2.6.34-rc2 24.5\n+patch 24.9\n\n us sys idle IO wait (in %)\n2.6.34-rc2 51.25 28.25 17.25 3.25\n+patch 53.75 18.5 19 8.75\n\nSo significantly less CPU time spent in kernel code, higher idle time and\nslightly higher throughput.\n\nSingle threaded performance difference was within the noise of microbenchmarks.\nThat is not to say penalty does not exist, the code is larger and more memory\naccesses required so it will be slightly slower.\n\nCc: linux-kernel@vger.kernel.org\nCc: Tim Chen \u003ctim.c.chen@linux.intel.com\u003e\nCc: Andi Kleen \u003cak@linux.intel.com\u003e\nSigned-off-by: Nick Piggin \u003cnpiggin@kernel.dk\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "dca332528bc69e05f67161e1ed59929633d5e63d", "tree": "0ec5576d52bead57c73983d2412cfe71814b5f8d", "parents": [ "7a4dec53897ecd3367efb1e12fe8a4edc47dc0e9" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sun Jul 25 02:31:46 2010 +0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Aug 09 16:49:02 2010 -0400" }, "message": "no need for list_for_each_entry_safe()/resetting with superblock list\n\njust delay __put_super() a bit\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "7a4dec53897ecd3367efb1e12fe8a4edc47dc0e9", "tree": "31d4639522e1453a7f5c38aa2436ffdd6df5c60b", "parents": [ "4f331f01b9c43bf001d3ffee578a97a1e0633eac" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Aug 09 12:05:43 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Aug 09 16:49:01 2010 -0400" }, "message": "Fix sget() race with failing mount\n\nIf sget() finds a matching superblock being set up, it\u0027ll\ngrab an active reference to it and grab s_umount. That\u0027s\nfine - we\u0027ll wait for completion of foofs_get_sb() that way.\nHowever, if said foofs_get_sb() fails we\u0027ll end up holding\nthe halfway-created superblock. deactivate_locked_super()\ncalled by foofs_get_sb() will just unlock the sucker since\nwe are holding another active reference to it.\n\nWhat we need is a way to tell if superblock has been successfully\nset up. Unfortunately, neither -\u003es_root nor the check for\nMS_ACTIVE quite fit. Cheap and easy way, suitable for backport:\nnew flag set by the (only) caller of -\u003eget_sb(). If that flag\nisn\u0027t present by the time sget() grabbed s_umount on preexisting\nsuperblock it has found, it\u0027s seeing a stillborn and should\njust bury it with deactivate_locked_super() (and repeat the search).\n\nLonger term we want to set that flag in -\u003eget_sb() instances (and\ncheck for it to distinguish between \"sget() found us a live sb\"\nand \"sget() has allocated an sb, we need to set it up\" in there,\ninstead of checking -\u003es_root as we do now).\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: stable@kernel.org\n" }, { "commit": "4f331f01b9c43bf001d3ffee578a97a1e0633eac", "tree": "77cd690ab7af2624e3fd7932563f6dc0f5d6441a", "parents": [ "719f2c879f4dda7d7f303bd387d37cd96db29d31" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Jul 20 15:18:07 2010 -0700" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Aug 09 16:48:59 2010 -0400" }, "message": "vfs: don\u0027t hold s_umount over close_bdev_exclusive() call\n\nFix an obscure AB-BA deadlock in get_sb_bdev().\n\nWhen a superblock is mounted more than once get_sb_bdev() calls\nclose_bdev_exclusive() to drop the extra bdev reference while holding\ns_umount. However, sb-\u003es_umount nests inside bd_mutex during\n__invalidate_device() and close_bdev_exclusive() acquires bd_mutex during\nblkdev_put(); thus creating an AB-BA deadlock.\n\nThis condition doesn\u0027t trigger frequently. For this condition to be\nvisible to lockdep, the filesystem must occupy the whole device (as\n__invalidate_device() only grabs bd_mutex for the whole device), the FS\nmust be mounted more than once and partition rescan should be issued while\nthe FS is still mounted.\n\nFix it by dropping s_umount over close_bdev_exclusive().\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReported-by: Ciprian Docan \u003cdocan@eden.rutgers.edu\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nAcked-by: Jens Axboe \u003caxboe@kernel.dk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "57439f878afafefad8836ebf5c49da2a0a746105", "tree": "ec11dd35704aa37d77a5fd8404fda57f297a3834", "parents": [ "5904b3b81d25166e5e39b9727645bb47937618e3" ], "author": { "name": "npiggin@suse.de", "email": "npiggin@suse.de", "time": "Thu Jun 24 13:02:14 2010 +1000" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jun 29 10:38:22 2010 -0700" }, "message": "fs: fix superblock iteration race\n\nlist_for_each_entry_safe is not suitable to protect against concurrent\nmodification of the list. 6754af6 introduced a race in sb walking.\n\nlist_for_each_entry can use the trick of pinning the current entry in\nthe list before we drop and retake the lock because it subsequently\nfollows cur-\u003enext. However list_for_each_entry_safe saves n\u003dcur-\u003enext\nfor following before entering the loop body, so when the lock is\ndropped, n may be deleted.\n\nSigned-off-by: Nick Piggin \u003cnpiggin@suse.de\u003e\nCc: Christoph Hellwig \u003chch@infradead.org\u003e\nCc: John Stultz \u003cjohnstul@us.ibm.com\u003e\nCc: Frank Mayhar \u003cfmayhar@google.com\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d28619f1563140526e2f84eae436f39206f40a69", "tree": "d93284016a0983c8f27b745a3c50738617e50995", "parents": [ "021fad8b706849c091f6e682bc5df3ce4f9ab4d7", "f32764bd2bbb6ea003c158b1d276b4dc9f900348" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun May 30 09:11:11 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun May 30 09:11:11 2010 -0700" }, "message": "Merge branch \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs-2.6\n\n* \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs-2.6:\n quota: Convert quota statistics to generic percpu_counter\n ext3 uses rb_node \u003d NULL; to zero rb_root.\n quota: Fixup dquot_transfer\n reiserfs: Fix resuming of quotas on remount read-write\n pohmelfs: Remove dead quota code\n ufs: Remove dead quota code\n udf: Remove dead quota code\n quota: rename default quotactl methods to dquot_\n quota: explicitly set -\u003edq_op and -\u003es_qcop\n quota: drop remount argument to -\u003equota_on and -\u003equota_off\n quota: move unmount handling into the filesystem\n quota: kill the vfs_dq_off and vfs_dq_quota_on_remount wrappers\n quota: move remount handling into the filesystem\n ocfs2: Fix use after free on remount read-only\n\nFix up conflicts in fs/ext4/super.c and fs/ufs/file.c\n" }, { "commit": "7000d3c424e5bb350e502a477fb0e1ed42f8b10e", "tree": "1a0b27d94942969d2ff9e25cfd53f8f20992b6b4", "parents": [ "0ab7620a0cefe6982b914a830a41f65ecccd74bd" ], "author": { "name": "Randy Dunlap", "email": "randy.dunlap@oracle.com", "time": "Mon May 24 22:22:34 2010 -0700" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu May 27 22:06:23 2010 -0400" }, "message": "fs/super: fix kernel-doc warning\n\nFix fs/super.c kernel-doc warning and function notation:\nWarning(fs/super.c:957): No description found for parameter \u0027sb\u0027\n\nSigned-off-by: Randy Dunlap \u003crandy.dunlap@oracle.com\u003e\nCc: Alexander Viro \u003cviro@zeniv.linux.org.uk\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "123e9caf1e85008ab7eb5f6cd58c44f9a5d73b2b", "tree": "a7a49a9aabb2136e8d19a3d86096bb525a16e0b9", "parents": [ "307ae18a56e5b706056a2050d52e8cc01b5171c0" ], "author": { "name": "Christoph Hellwig", "email": "hch@infradead.org", "time": "Wed May 19 07:16:44 2010 -0400" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon May 24 14:10:17 2010 +0200" }, "message": "quota: explicitly set -\u003edq_op and -\u003es_qcop\n\nOnly set the quota operation vectors if the filesystem actually supports\nquota instead of doing it for all filesystems in alloc_super().\n\n[Jan Kara: Export dquot_operations and vfs_quotactl_ops]\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "e0ccfd959cd8907bcb66cc2042e0f4fd7fcbff2b", "tree": "a62a84034243e75e07bb063526e10ea0b837062f", "parents": [ "0f0dd62fddcbd0f6830ed8ef3d3426ccc46b9250" ], "author": { "name": "Christoph Hellwig", "email": "hch@infradead.org", "time": "Wed May 19 07:16:42 2010 -0400" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon May 24 14:09:12 2010 +0200" }, "message": "quota: move unmount handling into the filesystem\n\nCurrently the VFS calls into the quotactl interface for unmounting\nfilesystems. This means filesystems with their own quota handling\ncan\u0027t easily distinguish between user-space originating quotaoff\nand an unount. Instead move the responsibily of the unmount handling\ninto the filesystem to be consistent with all other dquot handling.\n\nNote that we do call dquot_disable a lot later now, e.g. after\na sync_filesystem. But this is fine as the quota code does all its\nwrites via blockdev\u0027s mapping and that is synced even later.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "c79d967de3741ceb60c5bbbf1b6f97eab9a89838", "tree": "5494e7b504cffb0ddc6942d1542c2b4a472207ed", "parents": [ "eea7feb072f5914ecafa95b3d83be0c229244d90" ], "author": { "name": "Christoph Hellwig", "email": "hch@infradead.org", "time": "Wed May 19 07:16:40 2010 -0400" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon May 24 14:06:39 2010 +0200" }, "message": "quota: move remount handling into the filesystem\n\nCurrently do_remount_sb calls into the dquot code to tell it about going\nfrom rw to ro and ro to rw. Move this code into the filesystem to\nnot depend on the dquot code in the VFS - note ocfs2 already ignores\nthese calls and handles remount by itself. This gets rid of overloading\nthe quotactl calls and allows to unify the VFS and XFS codepaths in\nthat area later.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "51ee049e771c14a29aaee8ecd6cbbe14db088f3a", "tree": "594c6676eb50a59ce82625ee09fee73fd700a5ed", "parents": [ "cc9106247de92549e50abb0ba12d6b2fdbf0be55" ], "author": { "name": "Roland Dreier", "email": "rdreier@cisco.com", "time": "Tue Apr 27 14:23:57 2010 -0700" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:22 2010 -0400" }, "message": "vfs: add lockdep annotation to s_vfs_rename_key for ecryptfs\n\n \u003e \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n \u003e [ INFO: possible recursive locking detected ]\n \u003e 2.6.31-2-generic #14~rbd3\n \u003e ---------------------------------------------\n \u003e firefox-3.5/4162 is trying to acquire lock:\n \u003e (\u0026s-\u003es_vfs_rename_mutex){+.+.+.}, at: [\u003cffffffff81139d31\u003e] lock_rename+0x41/0xf0\n \u003e\n \u003e but task is already holding lock:\n \u003e (\u0026s-\u003es_vfs_rename_mutex){+.+.+.}, at: [\u003cffffffff81139d31\u003e] lock_rename+0x41/0xf0\n \u003e\n \u003e other info that might help us debug this:\n \u003e 3 locks held by firefox-3.5/4162:\n \u003e #0: (\u0026s-\u003es_vfs_rename_mutex){+.+.+.}, at: [\u003cffffffff81139d31\u003e] lock_rename+0x41/0xf0\n \u003e #1: (\u0026sb-\u003es_type-\u003ei_mutex_key#11/1){+.+.+.}, at: [\u003cffffffff81139d5a\u003e] lock_rename+0x6a/0xf0\n \u003e #2: (\u0026sb-\u003es_type-\u003ei_mutex_key#11/2){+.+.+.}, at: [\u003cffffffff81139d6f\u003e] lock_rename+0x7f/0xf0\n \u003e\n \u003e stack backtrace:\n \u003e Pid: 4162, comm: firefox-3.5 Tainted: G C 2.6.31-2-generic #14~rbd3\n \u003e Call Trace:\n \u003e [\u003cffffffff8108ae74\u003e] print_deadlock_bug+0xf4/0x100\n \u003e [\u003cffffffff8108ce26\u003e] validate_chain+0x4c6/0x750\n \u003e [\u003cffffffff8108d2e7\u003e] __lock_acquire+0x237/0x430\n \u003e [\u003cffffffff8108d585\u003e] lock_acquire+0xa5/0x150\n \u003e [\u003cffffffff81139d31\u003e] ? lock_rename+0x41/0xf0\n \u003e [\u003cffffffff815526ad\u003e] __mutex_lock_common+0x4d/0x3d0\n \u003e [\u003cffffffff81139d31\u003e] ? lock_rename+0x41/0xf0\n \u003e [\u003cffffffff81139d31\u003e] ? lock_rename+0x41/0xf0\n \u003e [\u003cffffffff8120eaf9\u003e] ? ecryptfs_rename+0x99/0x170\n \u003e [\u003cffffffff81552b36\u003e] mutex_lock_nested+0x46/0x60\n \u003e [\u003cffffffff81139d31\u003e] lock_rename+0x41/0xf0\n \u003e [\u003cffffffff8120eb2a\u003e] ecryptfs_rename+0xca/0x170\n \u003e [\u003cffffffff81139a9e\u003e] vfs_rename_dir+0x13e/0x160\n \u003e [\u003cffffffff8113ac7e\u003e] vfs_rename+0xee/0x290\n \u003e [\u003cffffffff8113c212\u003e] ? __lookup_hash+0x102/0x160\n \u003e [\u003cffffffff8113d512\u003e] sys_renameat+0x252/0x280\n \u003e [\u003cffffffff81133eb4\u003e] ? cp_new_stat+0xe4/0x100\n \u003e [\u003cffffffff8101316a\u003e] ? sysret_check+0x2e/0x69\n \u003e [\u003cffffffff8108c34d\u003e] ? trace_hardirqs_on_caller+0x14d/0x190\n \u003e [\u003cffffffff8113d55b\u003e] sys_rename+0x1b/0x20\n \u003e [\u003cffffffff81013132\u003e] system_call_fastpath+0x16/0x1b\n\nThe trace above is totally reproducible by doing a cross-directory\nrename on an ecryptfs directory.\n\nThe issue seems to be that sys_renameat() does lock_rename() then calls\ninto the filesystem; if the filesystem is ecryptfs, then\necryptfs_rename() again does lock_rename() on the lower filesystem, and\nlockdep can\u0027t tell that the two s_vfs_rename_mutexes are different. It\nseems an annotation like the following is sufficient to fix this (it\ndoes get rid of the lockdep trace in my simple tests); however I would\nlike to make sure I\u0027m not misunderstanding the locking, hence the CC\nlist...\n\nSigned-off-by: Roland Dreier \u003crdreier@cisco.com\u003e\nCc: Tyler Hicks \u003ctyhicks@linux.vnet.ibm.com\u003e\nCc: Dustin Kirkland \u003ckirkland@canonical.com\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "18e9e5104fcd9a973ffe3eed3816c87f2a1b6cd2", "tree": "635369c866fcb384223618c878e0b4c317790634", "parents": [ "e1e46bf1866317d4f86f66bf18d3f07317d9f9ee" ], "author": { "name": "Josef Bacik", "email": "josef@redhat.com", "time": "Tue Mar 23 10:34:56 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:18 2010 -0400" }, "message": "Introduce freeze_super and thaw_super for the fsfreeze ioctl\n\nCurrently the way we do freezing is by passing sb\u003es_bdev to freeze_bdev and then\nletting it do all the work. But freezing is more of an fs thing, and doesn\u0027t\nreally have much to do with the bdev at all, all the work gets done with the\nsuper. In btrfs we do not populate s_bdev, since we can have multiple bdev\u0027s\nfor one fs and setting s_bdev makes removing devices from a pool kind of tricky.\nThis means that freezing a btrfs filesystem fails, which causes us to corrupt\nwith things like tux-on-ice which use the fsfreeze mechanism. So instead of\npopulating sb-\u003es_bdev with a random bdev in our pool, I\u0027ve broken the actual fs\nfreezing stuff into freeze_super and thaw_super. These just take the\nsuper_block that we\u0027re freezing and does the appropriate work. It\u0027s basically\njust copy and pasted from freeze_bdev. I\u0027ve then converted freeze_bdev over to\nuse the new super helpers. I\u0027ve tested this with ext4 and btrfs and verified\neverything continues to work the same as before.\n\nThe only new gotcha is multiple calls to the fsfreeze ioctl will return EBUSY if\nthe fs is already frozen. I thought this was a better solution than adding a\nfreeze counter to the super_block, but if everybody hates this idea I\u0027m open to\nsuggestions. Thanks,\n\nSigned-off-by: Josef Bacik \u003cjosef@redhat.com\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "e1e46bf1866317d4f86f66bf18d3f07317d9f9ee", "tree": "cbaf0c3d64beff26bb9e37f1640811492fb3c617", "parents": [ "d3f2147307cce9eac56dd91d381709aa3f1615b3" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Tue Mar 23 13:56:07 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:17 2010 -0400" }, "message": "Trim includes in fs/super.c\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "d3f2147307cce9eac56dd91d381709aa3f1615b3", "tree": "c1512bc87bdd657d379c6cf67f9c84436ad8fb52", "parents": [ "7ed1ee6118ae77330cae2a6d5e9383532f7dfb48" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Tue Mar 23 11:11:05 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:17 2010 -0400" }, "message": "Move grabbing s_umount to callers of grab_super()\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "7ed1ee6118ae77330cae2a6d5e9383532f7dfb48", "tree": "5f91faf8ddb9b210f9f66b15bd5c82c04e9a54e9", "parents": [ "e8c26255992474a2161c63ce9d385827302e4530" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Tue Mar 23 10:37:36 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:17 2010 -0400" }, "message": "Take statfs variants to fs/statfs.c\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "01a05b337a5b647909e1d6670f57e7202318a5fb", "tree": "7877f08db14877d06346c8e1ef52aa17f2483e93", "parents": [ "35cf7ba0b46dc3582a01c3860b14bff122662aa3" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Tue Mar 23 06:06:58 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:16 2010 -0400" }, "message": "new helper: iterate_supers()\n\n... and switch the simple \"loop over superblocks and do something\"\nloops to it.\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "35cf7ba0b46dc3582a01c3860b14bff122662aa3", "tree": "2b38e9333600f468f0c8371c657c02e3aa8ec43b", "parents": [ "79893c17b45dec0d3c25bc22d28d9f319b14f573" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Mar 22 21:13:53 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:16 2010 -0400" }, "message": "Bury __put_super_and_need_restart()\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "df40c01a9249873e4ad0625ae5d9fb831962b75c", "tree": "9d049e176ad6a329e040faa32d6ee5933d1cea58", "parents": [ "1494583de59dfad2e3a6788ce9817e658d32df22" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Mar 22 20:23:25 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:16 2010 -0400" }, "message": "In get_super() and user_get_super() restarts are unconditional\n\nIf superblock had been still alive, we would\u0027ve returned it...\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "1494583de59dfad2e3a6788ce9817e658d32df22", "tree": "6f0a0fe022af703aa18ecc5f65a616fe44b9f8ad", "parents": [ "e7fe0585ca8793e2d43c57e77d4ca79042806acf" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Mar 22 20:15:33 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:15 2010 -0400" }, "message": "fix get_active_super()/umount() race\n\nThis one needs restarts...\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "e7fe0585ca8793e2d43c57e77d4ca79042806acf", "tree": "a68234ce86f5ff221f3f6260374f3a6437d77ce3", "parents": [ "6754af64641e8224c281ee5714e012e3ed41f701" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Mar 22 20:11:53 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:15 2010 -0400" }, "message": "fix do_emergency_remount()/umount() races\n\nneed list_for_each_entry_safe() here. Original didn\u0027t even\nhave restart logics, so if you race with umount() it blew up.\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "6754af64641e8224c281ee5714e012e3ed41f701", "tree": "248a8c01aae46f98505d8c196393fae629f9691a", "parents": [ "8edd64bd6089e21f47dcdebb14b598b713213ddc" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Mar 22 20:09:33 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:15 2010 -0400" }, "message": "Convert simple loops over superblocks to list_for_each_entry_safe\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "8edd64bd6089e21f47dcdebb14b598b713213ddc", "tree": "c356a358c7b823433728869ff430ad205c4b8a5d", "parents": [ "551de6f34dfeefbeeadb32909c387d393114ecc8" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Mar 22 19:56:42 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:15 2010 -0400" }, "message": "get rid of restarts in sync_filesystems()\n\nAt the same time we can kill s_need_restart and local mutex in there.\n__put_super() made public for a while; will be gone later.\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "551de6f34dfeefbeeadb32909c387d393114ecc8", "tree": "822af803e7e75ed476b0a176639c162e0395910d", "parents": [ "1712ac8fda7d8bc4dc921f5777b7423aacad7263" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Mar 22 19:36:35 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:14 2010 -0400" }, "message": "Leave superblocks on s_list until the end\n\nWe used to remove from s_list and s_instances at the same\ntime. So let\u0027s *not* do the former and skip superblocks\nthat have empty s_instances in the loops over s_list.\n\nThe next step, of course, will be to get rid of rescan logics\nin those loops.\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "1712ac8fda7d8bc4dc921f5777b7423aacad7263", "tree": "1493bc7166ace04d9ac2f4d5383eaab1d43e17c4", "parents": [ "b20bd1a5e78af267dc4b6e1ffed48d5d776302c5" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Mar 22 15:22:31 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:14 2010 -0400" }, "message": "Saner locking around deactivate_super()\n\nMake sure that s_umount is acquired *before* we drop the final\nactive reference; we still have the fast path (atomic_dec_unless)\nand we have gotten rid of the window between the moment when\ns_active hits zero and s_umount is acquired. Which simplifies\nthe living hell out of grab_super() and inotify pin_to_kill()\nstuff.\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "b20bd1a5e78af267dc4b6e1ffed48d5d776302c5", "tree": "d50982ee42500712d9add489435d4455580b9cac", "parents": [ "389b8be6ef419397e4f176652927ebad6ebb4b77" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Mar 22 08:53:19 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:14 2010 -0400" }, "message": "get rid of S_BIAS\n\nuse atomic_inc_not_zero(\u0026sb-\u003es_active) instead of playing games with\nchecking -\u003es_count \u003e S_BIAS\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "389b8be6ef419397e4f176652927ebad6ebb4b77", "tree": "941037c2296b94b30f4a883235f54930b6aa485e", "parents": [ "79d7e39ee1d4b423206f6cfd2cd2eed6253d95fe" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sun Mar 21 22:34:11 2010 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:14 2010 -0400" }, "message": "get rid of open-coded grab_super() in get_active_super()\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "a135aa2cd76a1de1a84312e0bb3498a5da76782d", "tree": "2933d7ee275896cfa3b5173fda0fc7c91fb0a398", "parents": [ "13e3c5e5b9c67e59074d24e29f3ff794bb4dfef0" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Mon Feb 01 21:55:52 2010 +0100" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 21 18:31:12 2010 -0400" }, "message": "remove incorrect comment in do_emergency_remount\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "5477d0face8a3ba4e9a1e7283692fff9c92f8e5e", "tree": "59bdad300f2be01911f9120e349b22664f199387", "parents": [ "79dba2eaa771c3173957eccfd288e0e0d12e4d3f" ], "author": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Thu Apr 29 20:33:35 2010 +0200" }, "committer": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Thu Apr 29 20:33:35 2010 +0200" }, "message": "fs: fs/super.c needs to include backing-dev.h for !CONFIG_BLOCK\n\nWhen CONFIG_BLOCK is set, it ends up getting backing-dev.h included.\nBut for !CONFIG_BLOCK, it isn\u0027t so lucky. The proper thing to do is\ninclude \u003clinux/backing-dev.h\u003e directly from the file it\u0027s used from,\nso do that.\n\nSigned-off-by: Jens Axboe \u003cjens.axboe@oracle.com\u003e\n" }, { "commit": "5129a469a91a91427334c40e29e64c6d0ab68caf", "tree": "141a17cbea94c7c9c038187cc7081e1c688eac55", "parents": [ "7e2455c1a123ceadbb35150a610d61e8443fd340" ], "author": { "name": "Jörn Engel", "email": "joern@logfs.org", "time": "Sun Apr 25 08:54:42 2010 +0200" }, "committer": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Sun Apr 25 08:54:42 2010 +0200" }, "message": "Catch filesystems lacking s_bdi\n\nnoop_backing_dev_info is used only as a flag to mark filesystems that\ndon\u0027t have any backing store, like tmpfs, procfs, spufs, etc.\n\nSigned-off-by: Joern Engel \u003cjoern@logfs.org\u003e\n\nChanged the BUG_ON() to a WARN_ON(). Note that adding dirty inodes\nto the noop_backing_dev_info is not legal and will not result in\nthem being flushed, but we already catch this condition in\n__mark_inode_dirty() when checking for a registered bdi.\n\nSigned-off-by: Jens Axboe \u003cjens.axboe@oracle.com\u003e\n" }, { "commit": "8089352a13b785d4e0df63d87bd2b71c76bb9aee", "tree": "e84db2c2a5c2095091d2012c00078023b90a3490", "parents": [ "d498b25a4f877be535246c4e5b6ee5890781a477" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri Feb 05 09:30:46 2010 -0500" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Mar 03 14:08:00 2010 -0500" }, "message": "Mirror MS_KERNMOUNT in -\u003emnt_flags\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "d208bbdda991b8808d9c033ce4d31cb1bd87dcfc", "tree": "8589a1f440a261008addb1ed97b75208eb37a6f1", "parents": [ "ec4f860597af41c6b71f4de86d8e86f710bfab54" ], "author": { "name": "Nick Piggin", "email": "npiggin@suse.de", "time": "Mon Dec 21 16:28:53 2009 -0800" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Mar 03 13:00:20 2010 -0500" }, "message": "fs: improve remount,ro vs buffercache coherency\n\nInvalidate sb-\u003es_bdev on remount,ro.\n\nFixes a problem reported by Jorge Boncompte who is seeing corruption\ntrying to snapshot a minix filesystem image. Some filesystems modify\ntheir metadata via a path other than the bdev buffer cache (eg. they may\nuse a private linear mapping for their metadata, or implement directories\nin pagecache, etc). Also, file data modifications usually go to the bdev\nvia their own mappings.\n\nThese updates are not coherent with buffercache IO (eg. via /dev/bdev)\nand never have been. However there could be a reasonable expectation that\nafter a mount -oremount,ro operation then the buffercache should\nsubsequently be coherent with previous filesystem modifications.\n\nSo invalidate the bdev mappings on a remount,ro operation to provide a\ncoherency point.\n\nThe problem was exposed when we switched the old rd to brd because old rd\ndidn\u0027t really function like a normal block device and updates to rd via\nmappings other than the buffercache would still end up going into its\nbuffercache. But the same problem has always affected other \"normal\"\nblock devices, including loop.\n\n[akpm@linux-foundation.org: repair comment layout]\nReported-by: \"Jorge Boncompte [DTI2]\" \u003cjorge@dti2.net\u003e\nTested-by: \"Jorge Boncompte [DTI2]\" \u003cjorge@dti2.net\u003e\nSigned-off-by: Nick Piggin \u003cnpiggin@suse.de\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "9329d1beaeed1a94f030c784dcec5ff973f402c4", "tree": "cbb0bc9153f6fc98db6156779c0265f7859bbec3", "parents": [ "f1f76f865b5f66db5b5c7f2d19874f2bb9b43b8d" ], "author": { "name": "Kay Sievers", "email": "kay.sievers@vrfy.org", "time": "Fri Dec 18 21:18:15 2009 +0100" }, "committer": { "name": "Greg Kroah-Hartman", "email": "gregkh@suse.de", "time": "Wed Dec 23 11:23:43 2009 -0800" }, "message": "vfs: get_sb_single() - do not pass options twice\n\nFilesystem code usually destroys the option buffer while\nparsing it. This leads to errors when the same buffer is\npassed twice. In case we fill a new superblock do not call\nremount.\n\nThis is needed to quite a warning that the debugfs code\ncauses every boot.\n\nCc: Miklos Szeredi \u003cmiklos@szeredi.hu\u003e\nSigned-off-by: Kay Sievers \u003ckay.sievers@vrfy.org\u003e\nSigned-off-by: Greg Kroah-Hartman \u003cgregkh@suse.de\u003e\n\n" }, { "commit": "4504230a71566785a05d3e6b53fa1ee071b864eb", "tree": "e73070fcad99b800f0324992c392d44c6dddc97c", "parents": [ "4fadd7bb20a1e7c774ed88dc703d8fbcd00ff917" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Mon Aug 03 23:28:35 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Sep 24 07:47:41 2009 -0400" }, "message": "freeze_bdev: grab active reference to frozen superblocks\n\nCurrently we held s_umount while a filesystem is frozen, despite that we\nmight return to userspace and unlock it from a different process. Instead\ngrab an active reference to keep the file system busy and add an explicit\ncheck for frozen filesystems in remount and reject the remount instead\nof blocking on s_umount.\n\nAdd a new get_active_super helper to super.c for use by freeze_bdev that\ngrabs an active reference to a superblock from a given block device.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "4fadd7bb20a1e7c774ed88dc703d8fbcd00ff917", "tree": "a6f3df6f19d27e81f35a93f8858b73bd4273f420", "parents": [ "1ba50bbe93ebb98e83b174a85eff76af430c4e5b" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Mon Aug 03 23:28:06 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Sep 24 07:47:39 2009 -0400" }, "message": "freeze_bdev: kill bd_mount_sem\n\nNow that we have the freeze count there is not much reason for bd_mount_sem\nanymore. The actual freeze/thaw operations are serialized using the\nbd_fsfreeze_mutex, and the only other place we take bd_mount_sem is\nget_sb_bdev which tries to prevent mounting a filesystem while the block\ndevice is frozen. Instead of add a check for bd_fsfreeze_count and\nreturn -EBUSY if a filesystem is frozen. While that is a change in user\nvisible behaviour a failing mount is much better for this case rather\nthan having the mount process stuck uninterruptible for a long time.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "42cb56ae2ab67390da34906b27bedc3f2ff1393b", "tree": "db4a6a4871feeb153f924a80a79b7790e4e2c90e", "parents": [ "5aa98b706e83da4cde4172c890d6e815915536a0" ], "author": { "name": "Jeff Layton", "email": "jlayton@redhat.com", "time": "Fri Sep 18 13:05:53 2009 -0700" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Sep 24 07:47:33 2009 -0400" }, "message": "vfs: change sb-\u003es_maxbytes to a loff_t\n\nsb-\u003es_maxbytes is supposed to indicate the maximum size of a file that can\nexist on the filesystem. It\u0027s declared as an unsigned long long.\n\nEven if a filesystem has no inherent limit that prevents it from using\nevery bit in that unsigned long long, it\u0027s still problematic to set it to\nanything larger than MAX_LFS_FILESIZE. There are places in the kernel\nthat cast s_maxbytes to a signed value. If it\u0027s set too large then this\ncast makes it a negative number and generally breaks the comparison.\n\nChange s_maxbytes to be loff_t instead. That should help eliminate the\ntemptation to set it too large by making it a signed value.\n\nAlso, add a warning for couple of releases to help catch filesystems that\nset s_maxbytes too large. Eventually we can either convert this to a\nBUG() or just remove it and in the hope that no one will get it wrong now\nthat it\u0027s a signed value.\n\nSigned-off-by: Jeff Layton \u003cjlayton@redhat.com\u003e\nCc: Johannes Weiner \u003channes@cmpxchg.org\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Robert Love \u003crlove@google.com\u003e\nCc: Mandeep Singh Baines \u003cmsb@google.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "b87221de6a4934eda856475a0065688d12973a04", "tree": "6bcf0628e106c4833538f4c23d710fbbe3d7609a", "parents": [ "0d54b217a247f39605361f867fefbb9e099a5432" ], "author": { "name": "Alexey Dobriyan", "email": "adobriyan@gmail.com", "time": "Mon Sep 21 17:01:09 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:24 2009 -0700" }, "message": "const: mark remaining super_operations const\n\nSigned-off-by: Alexey Dobriyan \u003cadobriyan@gmail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "32a88aa1b6dfb901cec64e1898cac78d0f25028a", "tree": "51aa6f56ccfca53f495d015645373317bdee3647", "parents": [ "c4a77a6c7dcff04a2abc7fe4b6b2ae605be41c5b" ], "author": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Wed Sep 16 15:02:33 2009 +0200" }, "committer": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Wed Sep 16 15:18:51 2009 +0200" }, "message": "fs: Assign bdi in super_block\n\nWe do this automatically in get_sb_bdev() from the set_bdev_super()\ncallback. Filesystems that have their own private backing_dev_info\nmust assign that in -\u003efill_super().\n\nNote that -\u003es_bdi assignment is required for proper writeback!\n\nAcked-by: Christoph Hellwig \u003chch@infradead.org\u003e\nSigned-off-by: Jens Axboe \u003cjens.axboe@oracle.com\u003e\n" }, { "commit": "03ba3782e8dcc5b0e1efe440d33084f066e38cae", "tree": "e5a6513b411de16a46199530ec98ef9b7f1efc50", "parents": [ "66f3b8e2e103a0b93b945764d98e9ba46cb926dd" ], "author": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Wed Sep 09 09:08:54 2009 +0200" }, "committer": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Fri Sep 11 09:20:25 2009 +0200" }, "message": "writeback: switch to per-bdi threads for flushing data\n\nThis gets rid of pdflush for bdi writeout and kupdated style cleaning.\npdflush writeout suffers from lack of locality and also requires more\nthreads to handle the same workload, since it has to work in a\nnon-blocking fashion against each queue. This also introduces lumpy\nbehaviour and potential request starvation, since pdflush can be starved\nfor queue access if others are accessing it. A sample ffsb workload that\ndoes random writes to files is about 8% faster here on a simple SATA drive\nduring the benchmark phase. File layout also seems a LOT more smooth in\nvmstat:\n\n r b swpd free buff cache si so bi bo in cs us sy id wa\n 0 1 0 608848 2652 375372 0 0 0 71024 604 24 1 10 48 42\n 0 1 0 549644 2712 433736 0 0 0 60692 505 27 1 8 48 44\n 1 0 0 476928 2784 505192 0 0 4 29540 553 24 0 9 53 37\n 0 1 0 457972 2808 524008 0 0 0 54876 331 16 0 4 38 58\n 0 1 0 366128 2928 614284 0 0 4 92168 710 58 0 13 53 34\n 0 1 0 295092 3000 684140 0 0 0 62924 572 23 0 9 53 37\n 0 1 0 236592 3064 741704 0 0 4 58256 523 17 0 8 48 44\n 0 1 0 165608 3132 811464 0 0 0 57460 560 21 0 8 54 38\n 0 1 0 102952 3200 873164 0 0 4 74748 540 29 1 10 48 41\n 0 1 0 48604 3252 926472 0 0 0 53248 469 29 0 7 47 45\n\nwhere vanilla tends to fluctuate a lot in the creation phase:\n\n r b swpd free buff cache si so bi bo in cs us sy id wa\n 1 1 0 678716 5792 303380 0 0 0 74064 565 50 1 11 52 36\n 1 0 0 662488 5864 319396 0 0 4 352 302 329 0 2 47 51\n 0 1 0 599312 5924 381468 0 0 0 78164 516 55 0 9 51 40\n 0 1 0 519952 6008 459516 0 0 4 78156 622 56 1 11 52 37\n 1 1 0 436640 6092 541632 0 0 0 82244 622 54 0 11 48 41\n 0 1 0 436640 6092 541660 0 0 0 8 152 39 0 0 51 49\n 0 1 0 332224 6200 644252 0 0 4 102800 728 46 1 13 49 36\n 1 0 0 274492 6260 701056 0 0 4 12328 459 49 0 7 50 43\n 0 1 0 211220 6324 763356 0 0 0 106940 515 37 1 10 51 39\n 1 0 0 160412 6376 813468 0 0 0 8224 415 43 0 6 49 45\n 1 1 0 85980 6452 886556 0 0 4 113516 575 39 1 11 54 34\n 0 2 0 85968 6452 886620 0 0 0 1640 158 211 0 0 46 54\n\nA 10 disk test with btrfs performs 26% faster with per-bdi flushing. A\nSSD based writeback test on XFS performs over 20% better as well, with\nthe throughput being very stable around 1GB/sec, where pdflush only\nmanages 750MB/sec and fluctuates wildly while doing so. Random buffered\nwrites to many files behave a lot better as well, as does random mmap\u0027ed\nwrites.\n\nA separate thread is added to sync the super blocks. In the long term,\nadding sync_supers_bdi() functionality could get rid of this thread again.\n\nSigned-off-by: Jens Axboe \u003cjens.axboe@oracle.com\u003e\n" }, { "commit": "66f3b8e2e103a0b93b945764d98e9ba46cb926dd", "tree": "442bf5664214f0a1448e4010b09868cc58fdd3d1", "parents": [ "d8a8559cd7a9ccac98d5f6f13297a2ff68a43627" ], "author": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Wed Sep 02 09:19:46 2009 +0200" }, "committer": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Fri Sep 11 09:20:25 2009 +0200" }, "message": "writeback: move dirty inodes from super_block to backing_dev_info\n\nThis is a first step at introducing per-bdi flusher threads. We should\nhave no change in behaviour, although sb_has_dirty_inodes() is now\nridiculously expensive, as there\u0027s no easy way to answer that question.\nNot a huge problem, since it\u0027ll be deleted in subsequent patches.\n\nSigned-off-by: Jens Axboe \u003cjens.axboe@oracle.com\u003e\n" }, { "commit": "f21f62208a6f60e2e05440b2e438d9541822dc4d", "tree": "e373be2998ac4914122f9da76398be980d0dbd47", "parents": [ "c63e09ecccb50f930e899d7005edc5411ee86d4f" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Jun 24 03:12:00 2009 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Jun 24 08:15:26 2009 -0400" }, "message": "... and the same for vfsmount id/mount group id\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "c63e09ecccb50f930e899d7005edc5411ee86d4f", "tree": "aafa5169cde98a2bb8327fcc948c76dba0746322", "parents": [ "7e325d3a6b117c7288bfc0755410e9d9d2b71326" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Jun 24 02:05:18 2009 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Jun 24 08:15:25 2009 -0400" }, "message": "Make allocation of anon devices cheaper\n\nStandard trick - add a new variable (start) such that\nfor each n \u003c start n is known to be busy. Allocation can\nskip checking everything in [0..start) and if it returns\nn, we can set start to n + 1. Freeing below start sets\nstart to what we\u0027d just freed.\n\nOf course, it still sucks if we do something like\n\tfree 0\n\tallocate\n\tallocate\nin a loop - still O(n^2) time. However, on saner loads it\nimproves the things a lot and the entire thing is not worth\nthe trouble of switching to something with better worst-case\nbehaviour.\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "b0895513f499b8f786d292ce48589ca210ca1d6e", "tree": "e7e7e684f19a930ca029afa08396aa5170e7fb3d", "parents": [ "210ad6aedb332e73167ece5af9bd47f0da8c2aca" ], "author": { "name": "J. R. Okajima", "email": "hooanon05@yahoo.co.jp", "time": "Wed Jun 17 01:16:50 2009 +0900" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Jun 17 00:36:35 2009 -0400" }, "message": "remove unlock_kernel() left accidentally\n\ncommit 337eb00a2c3a421999c39c94ce7e33545ee8baa7\nPush BKL down into -\u003eremount_fs()\nand\ncommit 4aa98cf768b6f2ea4b204620d949a665959214f6\nPush BKL down into do_remount_sb()\n\nwere uncorrectly merged.\nThe former removes one pair of lock/unlock_kernel(), but the latter adds\nseveral unlock_kernel(). Finally a few unlock_kernel() calls left.\n\nSigned-off-by: J. R. Okajima \u003chooanon05@yahoo.co.jp\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "337eb00a2c3a421999c39c94ce7e33545ee8baa7", "tree": "d9b780d095b638b1d8fa23841ff70347cf5daa08", "parents": [ "4195f73d1329e49727bcceb028e58cb38376c2b0" ], "author": { "name": "Alessio Igor Bogani", "email": "abogani@texware.it", "time": "Tue May 12 15:10:54 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:11 2009 -0400" }, "message": "Push BKL down into -\u003eremount_fs()\n\n[xfs, btrfs, capifs, shmem don\u0027t need BKL, exempt]\n\nSigned-off-by: Alessio Igor Bogani \u003cabogani@texware.it\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "ebc1ac164560a241d9bf1b7519062910c3f90a01", "tree": "db17fd3043b15f8269cce2c2d00213814022fc30", "parents": [ "01ba687577647beef6c5f2ea59bfb56fac9fcde2" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Mon May 11 23:35:03 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:09 2009 -0400" }, "message": "-\u003ewrite_super lock_super pushdown\n\nPush down lock_super into -\u003ewrite_super instances and remove it from the\ncaller.\n\nFollowing filesystem don\u0027t need -\u003es_lock in -\u003ewrite_super and are skipped:\n\n * bfs, nilfs2 - no other uses of s_lock and have internal locks in\n\t-\u003ewrite_super\n * ext2 - uses BKL in ext2_write_super and has internal calls without s_lock\n * reiserfs - no other uses of s_lock as has reiserfs_write_lock (BKL) in\n \t-\u003ewrite_super\n * xfs - no other uses of s_lock and uses internal lock (buffer lock on\n\tsuperblock buffer) to serialize -\u003ewrite_super. Also xfs_fs_write_super\n\tis superflous and will go away in the next merge window\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "4aa98cf768b6f2ea4b204620d949a665959214f6", "tree": "dd6f5be97396b9e1f24a9697524da19463e7a8da", "parents": [ "7f78d4cd4c5d01864943c22b79df1b6bde923129" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri May 08 13:36:58 2009 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:08 2009 -0400" }, "message": "Push BKL down into do_remount_sb()\n\n[folded fix from Jiri Slaby]\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "bbd6851a3213a525128473e978b692ab6ac11aba", "tree": "8ebddebadd8992871ab98456187cb00849a82058", "parents": [ "6cfd0148425e528b859b26e436b01f23f6926224" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed May 06 10:43:07 2009 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:08 2009 -0400" }, "message": "Push lock_super() into the -\u003eremount_fs() of filesystems that care about it\n\nNote that since we can\u0027t run into contention between remount_fs and write_super\n(due to exclusion on s_umount), we have to care only about filesystems that\ntouch lock_super() on their own. Out of those ext3, ext4, hpfs, sysv and ufs\ndo need it; fat doesn\u0027t since its -\u003eremount_fs() only accesses assign-once\ndata (basically, it\u0027s \"we have no atime on directories and only have atime on\nfiles for vfat; force nodiratime and possibly noatime into *flags\").\n\n[folded a build fix from hch]\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "6cfd0148425e528b859b26e436b01f23f6926224", "tree": "60e3257053554ff198fe5825e6f12a00c3b4422a", "parents": [ "a9e220f8322e2b0e0b8903fe00265461cffad3f0" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Tue May 05 15:40:36 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:07 2009 -0400" }, "message": "push BKL down into -\u003eput_super\n\nMove BKL into -\u003eput_super from the only caller. A couple of\nfilesystems had trivial enough -\u003eput_super (only kfree and NULLing of\ns_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,\nhugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most\nof them probably don\u0027t need it, but I\u0027d rather sort that out individually.\nPreferably after all the other BKL pushdowns in that area.\n\n[AV: original used to move lock_super() down as well; these changes are\nremoved since we don\u0027t do lock_super() at all in generic_shutdown_super()\nnow]\n[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "a9e220f8322e2b0e0b8903fe00265461cffad3f0", "tree": "b3be7d58b8eb9fd810636223f0458191ec1b9d75", "parents": [ "62c6943b4b1e818aea60c11c5a68a50785b83119" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Tue May 05 22:10:44 2009 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:07 2009 -0400" }, "message": "No need to do lock_super() for exclusion in generic_shutdown_super()\n\nWe can\u0027t run into contention on it. All other callers of lock_super()\neither hold s_umount (and we have it exclusive) or hold an active\nreference to superblock in question, which prevents the call of\ngeneric_shutdown_super() while the reference is held. So we can\nreplace lock_super(s) with get_fs_excl() in generic_shutdown_super()\n(and corresponding change for unlock_super(), of course).\n\nSince ext4 expects s_lock held for its put_super, take lock_super()\ninto it. The rest of filesystems do not care at all.\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "443b94baaa16771e98b29ca7c24f1e305738ffca", "tree": "cf498a25d012330928e0315222c46ea90c200530", "parents": [ "5af7926ff33b68b3ba46531471c6e0564b285efc" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Tue May 05 23:48:50 2009 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:07 2009 -0400" }, "message": "Make sure that all callers of remount hold s_umount exclusive\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "e5004753388dcf5e1b8a52ac0ab807d232340fbb", "tree": "4a74a93f1468acb111ba9a3e9ed4a55f338f51fe", "parents": [ "f3da392e9ff14b9f388e74319e6d195848991c07" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Tue May 05 16:08:56 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:06 2009 -0400" }, "message": "cleanup sync_supers\n\nMerge the write_super helper into sync_super and move the check for\n-\u003ewrite_super earlier so that we can avoid grabbing a reference to\na superblock that doesn\u0027t have it.\n\nWhile we\u0027re at it also add a little comment documenting sync_supers.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "8c85e125124a473d6f3e9bb187b0b84207f81d91", "tree": "d883424a156c00c55193e46567efdffddb6ef6b9", "parents": [ "517bfae28353e996160518add4d00033d3886e61" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Tue Apr 28 18:00:26 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:06 2009 -0400" }, "message": "remove -\u003ewrite_super call in generic_shutdown_super\n\nWe just did a full fs writeout using sync_filesystem before, and if\nthat\u0027s not enough for the filesystem it can perform it\u0027s own writeout\nin -\u003eput_super, which many filesystems already do.\n\nMove a call to foofs_write_super into every foofs_put_super for now to\nguarantee identical behaviour until it\u0027s cleaned up by the individual\nfilesystem maintainers.\n\nExceptions:\n\n - affs already has identical copy \u0026 pasted code at the beginning of\n affs_put_super so no need to do it twice.\n - xfs does the right thing without it and I have changes pending for\n the xfs tree touching this are so I don\u0027t really need conflicts\n here..\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "60b0680fa236ac4e17ce31a50048c9d75f9ec831", "tree": "c8ca34340a173326694247eab779e713c57202c2", "parents": [ "c15c54f5f056ee4819da9fde59a5f2cd45445f23" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Apr 27 16:43:53 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:04 2009 -0400" }, "message": "vfs: Rename fsync_super() to sync_filesystem() (version 4)\n\nRename the function so that it better describe what it really does. Also\nremove the unnecessary include of buffer_head.h.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "c15c54f5f056ee4819da9fde59a5f2cd45445f23", "tree": "0b8d142f0b8d44b71bf7ff9db7a373f90d0556a3", "parents": [ "5cee5815d1564bbbd505fea86f4550f1efdb5cd0" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Apr 27 16:43:52 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:04 2009 -0400" }, "message": "vfs: Move syncing code from super.c to sync.c (version 4)\n\nMove sync_filesystems(), __fsync_super(), fsync_super() from\nsuper.c to sync.c where it fits better.\n\n[build fixes folded]\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "5cee5815d1564bbbd505fea86f4550f1efdb5cd0", "tree": "ba99c38932dc534bf56f0d7dcfeeca153f50b007", "parents": [ "429479f031322a0cc5c921ffb2321a51718dc875" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Apr 27 16:43:51 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:03 2009 -0400" }, "message": "vfs: Make sys_sync() use fsync_super() (version 4)\n\nIt is unnecessarily fragile to have two places (fsync_super() and do_sync())\ndoing data integrity sync of the filesystem. Alter __fsync_super() to\naccommodate needs of both callers and use it. So after this patch\n__fsync_super() is the only place where we gather all the calls needed to\nproperly send all data on a filesystem to disk.\n\nNice bonus is that we get a complete livelock avoidance and write_supers()\nis now only used for periodic writeback of superblocks.\n\nsync_blockdevs() introduced a couple of patches ago is gone now.\n\n[build fixes folded]\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "429479f031322a0cc5c921ffb2321a51718dc875", "tree": "6741f7f1bfa1d889bbc4f44ab0489de97a3e47c0", "parents": [ "bfe881255c74800147523b59c85328a1a826ba21" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Apr 27 16:43:50 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:03 2009 -0400" }, "message": "vfs: Make __fsync_super() a static function (version 4)\n\n__fsync_super() does the same thing as fsync_super(). So change the only\ncaller to use fsync_super() and make __fsync_super() static. This removes\nunnecessarily duplicated call to sync_blockdev() and prepares ground\nfor the changes to __fsync_super() in the following patches.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "bfe881255c74800147523b59c85328a1a826ba21", "tree": "4ed9b761a440ee0b69a35a5c8bddc42c64195e47", "parents": [ "5a3e5cb8e08bd876e2542c1451c9a93dab1b0e39" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Apr 27 16:43:49 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:03 2009 -0400" }, "message": "vfs: Call -\u003esync_fs() even if s_dirt is 0 (version 4)\n\nsync_filesystems() has a condition that if wait \u003d\u003d 0 and s_dirt \u003d\u003d 0, then\n-\u003esync_fs() isn\u0027t called. This does not really make much sence since s_dirt is\ngenerally used by a filesystem to mean that -\u003ewrite_super() needs to be called.\nBut -\u003esync_fs() does different things. I even suspect that some filesystems\n(btrfs?) sets s_dirt just to fool this logic.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "5a3e5cb8e08bd876e2542c1451c9a93dab1b0e39", "tree": "3b792d21246f1001adeca8b67df24ca71593dd3f", "parents": [ "876a9f76abbcb775f8d21cbc99fa161f9e5937f1" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Apr 27 16:43:48 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:03 2009 -0400" }, "message": "vfs: Fix sys_sync() and fsync_super() reliability (version 4)\n\nSo far, do_sync() called:\n sync_inodes(0);\n sync_supers();\n sync_filesystems(0);\n sync_filesystems(1);\n sync_inodes(1);\n\nThis ordering makes it kind of hard for filesystems as sync_inodes(0) need not\nsubmit all the IO (for example it skips inodes with I_SYNC set) so e.g. forcing\ntransaction to disk in -\u003esync_fs() is not really enough. Therefore sys_sync has\nnot been completely reliable on some filesystems (ext3, ext4, reiserfs, ocfs2\nand others are hit by this) when racing e.g. with background writeback. A\nsimilar problem hits also other filesystems (e.g. ext2) because of\nwrite_supers() being called before the sync_inodes(1).\n\nChange the ordering of calls in do_sync() - this requires a new function\nsync_blockdevs() to preserve the property that block devices are always synced\nafter write_super() / sync_fs() call.\n\nThe same issue is fixed in __fsync_super() function used on umount /\nremount read-only.\n\n[AV: build fixes]\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "876a9f76abbcb775f8d21cbc99fa161f9e5937f1", "tree": "971a1ac276c365a53ef1563c9d9f71013a563f09", "parents": [ "864d7c4c068f23642efe91b33be3a84afe5f71e0" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Tue Apr 28 18:05:55 2009 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:02 2009 -0400" }, "message": "remove s_async_list\n\nRemove the unused s_async_list in the superblock, a leftover of the\nbroken async inode deletion code that leaked into mainline. Having this\nin the middle of the sync/unmount path is not helpful for the following\ncleanups.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "864d7c4c068f23642efe91b33be3a84afe5f71e0", "tree": "512b253428958e95ca99274a664ace103f6bb10e", "parents": [ "96029c4e09ccbd73a6d0ed2b29e80bf2586ad7ef" ], "author": { "name": "npiggin@suse.de", "email": "npiggin@suse.de", "time": "Sun Apr 26 20:25:56 2009 +1000" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Jun 11 21:36:02 2009 -0400" }, "message": "fs: move mark_files_ro into file_table.c\n\nThis function walks the s_files lock, and operates primarily on the\nfiles in a superblock, so it better belongs here (eg. see also\nfs_may_remount_ro).\n\n[AV: ... and it shouldn\u0027t be static after that move]\n\nSigned-off-by: Nick Piggin \u003cnpiggin@suse.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "ddbaaf3024d764ced700efb2d818709b90ea6fdd", "tree": "e8f3f970bb8a009a3847b6beba144016df8bbe4d", "parents": [ "db6c1fbb92eeb4cb52c6133e0c533602f49fc4bd" ], "author": { "name": "H Hartley Sweeten", "email": "hartleys@visionengravers.com", "time": "Wed Apr 29 20:14:57 2009 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sat May 09 10:49:41 2009 -0400" }, "message": "NULL noise in fs/super.c:kill_bdev_super()\n\nSigned-off-by: H Hartley Sweeten \u003chsweeten@visionengravers.com\u003e\nCc: Subrata Modak \u003csubrata@linux.vnet.ibm.com\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "74dbbdd7fdc11763f4698d2f3e684cf4446951e6", "tree": "f31d70174915b0d209fafeec35e996e8ed7e269d", "parents": [ "677c9b2e393a0cd203bd54e9c18b012b2c73305a" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed May 06 01:07:50 2009 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sat May 09 10:49:39 2009 -0400" }, "message": "New helper: deactivate_locked_super()\n\nDoes equivalent of up_write(\u0026s-\u003es_umount); deactivate_super(s);\nHowever, it does not does not unlock it until it\u0027s all over.\nAs the result, it\u0027s safe to use to dispose of new superblock on -\u003eget_sb()\nfailure exits - nobody will see the sucker until it\u0027s all over.\nEquivalent using up_write/deactivate_super is safe for that purpose\nif superblock is either\tsafe to use or has NULL -\u003es_root when we unlock.\nNormally filesystems take the required precautions, but\n\ta) we do have bugs in that area in some of them.\n\tb) up_write/deactivate_super sequence is extremely common,\nso the helper makes sense anyway.\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "909e6d94795654040ed416ac69858d5d2ce66dd3", "tree": "c0d873c341e3419c3bb54cffd964bbe850bbb4ab", "parents": [ "7ce5ba3c7ef26284f60babbe4465259d1f9968f3" ], "author": { "name": "Serge E. Hallyn", "email": "serue@us.ibm.com", "time": "Mon Apr 06 19:01:07 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Apr 07 08:31:09 2009 -0700" }, "message": "namespaces: move proc_net_get_sb to a generic fs/super.c helper\n\nThe mqueuefs filesystem will use this helper as well. Proc\u0027s main get_sb\ncould also be made to use it, but that will require a bit more rework.\n\nSigned-off-by: Serge E. Hallyn \u003cserue@us.ibm.com\u003e\nCc: Cedric Le Goater \u003cclg@fr.ibm.com\u003e\nCc: Alexey Dobriyan \u003cadobriyan@gmail.com\u003e\nCc: \"David S. Miller\" \u003cdavem@davemloft.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "800a964787faef3509d194fa33268628c3d1daa9", "tree": "37a722ed9d269d60bc26f6d8f0862d87e45a2424", "parents": [ "385e1ca5f21c4680ad6a46a3aa2ea8af99e99c92" ], "author": { "name": "David Howells", "email": "dhowells@redhat.com", "time": "Fri Apr 03 16:42:40 2009 +0100" }, "committer": { "name": "David Howells", "email": "dhowells@redhat.com", "time": "Fri Apr 03 16:42:40 2009 +0100" }, "message": "CacheFiles: Export things for CacheFiles\n\nExport a number of functions for CacheFiles\u0027s use.\n\nSigned-off-by: David Howells \u003cdhowells@redhat.com\u003e\nAcked-by: Steve Dickson \u003csteved@redhat.com\u003e\nAcked-by: Trond Myklebust \u003cTrond.Myklebust@netapp.com\u003e\nAcked-by: Rik van Riel \u003criel@redhat.com\u003e\nAcked-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nTested-by: Daire Byrne \u003cDaire.Byrne@framestore.com\u003e\n" }, { "commit": "3ae5080f4c2e293229508dabe7c8a90af4e4c460", "tree": "9cb11f26905a82b7fac9d3b8f9d61d58bc5c94b0", "parents": [ "2c9e15a011c55ff96b2b8d2b126d1b9a96abba20", "aabb8fdb41128705fd1627f56fdd571e45fdbcdb" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 27 16:23:12 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 27 16:23:12 2009 -0700" }, "message": "Merge branch \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6\n\n* \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6: (37 commits)\n fs: avoid I_NEW inodes\n Merge code for single and multiple-instance mounts\n Remove get_init_pts_sb()\n Move common mknod_ptmx() calls into caller\n Parse mount options just once and copy them to super block\n Unroll essentials of do_remount_sb() into devpts\n vfs: simple_set_mnt() should return void\n fs: move bdev code out of buffer.c\n constify dentry_operations: rest\n constify dentry_operations: configfs\n constify dentry_operations: sysfs\n constify dentry_operations: JFS\n constify dentry_operations: OCFS2\n constify dentry_operations: GFS2\n constify dentry_operations: FAT\n constify dentry_operations: FUSE\n constify dentry_operations: procfs\n constify dentry_operations: ecryptfs\n constify dentry_operations: CIFS\n constify dentry_operations: AFS\n ...\n" }, { "commit": "2c9e15a011c55ff96b2b8d2b126d1b9a96abba20", "tree": "6d9b27a07f88ad4509dcd86aa74a2cdecd0d5f4b", "parents": [ "805de022b100bcf796860fe88d7db4164066d1c3", "c16831b4cc9b0805adf8ca3001752a7ec10a17bf" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 27 14:48:34 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 27 14:48:34 2009 -0700" }, "message": "Merge branch \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-quota-2.6\n\n* \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-quota-2.6: (27 commits)\n ext2: Zero our b_size in ext2_quota_read()\n trivial: fix typos/grammar errors in fs/Kconfig\n quota: Coding style fixes\n quota: Remove superfluous inlines\n quota: Remove uppercase aliases for quota functions.\n nfsd: Use lowercase names of quota functions\n jfs: Use lowercase names of quota functions\n udf: Use lowercase names of quota functions\n ufs: Use lowercase names of quota functions\n reiserfs: Use lowercase names of quota functions\n ext4: Use lowercase names of quota functions\n ext3: Use lowercase names of quota functions\n ext2: Use lowercase names of quota functions\n ramfs: Remove quota call\n vfs: Use lowercase names of quota functions\n quota: Remove dqbuf_t and other cleanups\n quota: Remove NODQUOT macro\n quota: Make global quota locks cacheline aligned\n quota: Move quota files into separate directory\n ext4: quota reservation for delayed allocation\n ...\n" }, { "commit": "a3ec947c85ec339884b30ef6a08133e9311fdae1", "tree": "c3cc5859a6b6d8986547405b6c5bd11bc8916114", "parents": [ "585d3bc06f4ca57f975a5a1f698f65a45ea66225" ], "author": { "name": "Sukadev Bhattiprolu", "email": "sukadev@linux.vnet.ibm.com", "time": "Wed Mar 04 12:06:34 2009 -0800" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri Mar 27 14:44:03 2009 -0400" }, "message": "vfs: simple_set_mnt() should return void\n\nsimple_set_mnt() is defined as returning \u0027int\u0027 but always returns 0.\nCallers assume simple_set_mnt() never fails and don\u0027t properly cleanup if\nit were to _ever_ fail. For instance, get_sb_single() and get_sb_nodev()\nshould:\n\n up_write(sb-\u003es_unmount);\n deactivate_super(sb);\n\nif simple_set_mnt() fails.\n\nSince simple_set_mnt() never fails, would be cleaner if it did not\nreturn anything.\n\n[akpm@linux-foundation.org: fix build]\nSigned-off-by: Sukadev Bhattiprolu \u003csukadev@linux.vnet.ibm.com\u003e\nAcked-by: Serge Hallyn \u003cserue@us.ibm.com\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "a2a9537ac0b37a5da6fbe7e1e9cb06c524d2a9c4", "tree": "798376ab3cb0fdbea5fc067562e2adfabdb4d9d6", "parents": [ "6933c02e9cc47c2df3c016621a013ec79fb4203f" ], "author": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Tue Mar 17 09:38:40 2009 +0100" }, "committer": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Thu Mar 26 11:01:36 2009 +0100" }, "message": "Get rid of pdflush_operation() in emergency sync and remount\n\nOpencode a cheasy approach with kevent. The idea here is that we\u0027ll\nadd some generic delayed work infrastructure, which probably wont be\nbased on pdflush (or maybe it will, in which case we can just add it\nback).\n\nThis is in preparation for getting rid of pdflush completely.\n\nSigned-off-by: Jens Axboe \u003cjens.axboe@oracle.com\u003e\n" }, { "commit": "9e3509e273ecc2a5f937c493f9bb71e5e41ac2e5", "tree": "a7d9704e891f14b7196a275543b7f9c90f348b82", "parents": [ "d26ac1a8128f6e1fc467f145acaa9f9bf9e16b75" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Jan 26 16:45:12 2009 +0100" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Mar 26 02:18:35 2009 +0100" }, "message": "vfs: Use lowercase names of quota functions\n\nUse lowercase names of quota functions instead of old uppercase ones.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nCC: Alexander Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "a3cfbb53b1764a3d1f58ddc032737ab9edaa7d41", "tree": "818ca39043749382a4b91d0310f532bf2fdc22ce", "parents": [ "e5bc49ba7439b9726006d031d440cba96819f0f8" ], "author": { "name": "Li Zefan", "email": "lizf@cn.fujitsu.com", "time": "Thu Mar 12 14:31:29 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Mar 12 16:20:23 2009 -0700" }, "message": "vfs: add missing unlock in sget()\n\nIn sget(), destroy_super(s) is called with s-\u003es_umount held, which makes\nlockdep unhappy.\n\nSigned-off-by: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nCc: Al Viro \u003cviro@ZenIV.linux.org.uk\u003e\nAcked-by: Peter Zijlstra \u003ca.p.zijlstra@chello.nl\u003e\nCc: Paul Menage \u003cmenage@google.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ada723dcd681e2dffd7d73345cc8fda0eb0df9bd", "tree": "5f1b114d225721ae7a65fca08a6d053f89f36c43", "parents": [ "27c0c8e511fa9e2389503926840fac606d90a049" ], "author": { "name": "Peter Zijlstra", "email": "peterz@infradead.org", "time": "Wed Feb 18 14:48:30 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Feb 18 15:37:55 2009 -0800" }, "message": "fs/super.c: add lockdep annotation to s_umount\n\nLi Zefan said:\n\nThread 1:\n for ((; ;))\n {\n mount -t cpuset xxx /mnt \u003e /dev/null 2\u003e\u00261\n cat /mnt/cpus \u003e /dev/null 2\u003e\u00261\n umount /mnt \u003e /dev/null 2\u003e\u00261\n }\n\nThread 2:\n for ((; ;))\n {\n mount -t cpuset xxx /mnt \u003e /dev/null 2\u003e\u00261\n umount /mnt \u003e /dev/null 2\u003e\u00261\n }\n\n(Note: It is irrelevant which cgroup subsys is used.)\n\nAfter a while a lockdep warning showed up:\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n[ INFO: possible recursive locking detected ]\n2.6.28 #479\n---------------------------------------------\nmount/13554 is trying to acquire lock:\n (\u0026type-\u003es_umount_key#19){--..}, at: [\u003cc049d888\u003e] sget+0x5e/0x321\n\nbut task is already holding lock:\n (\u0026type-\u003es_umount_key#19){--..}, at: [\u003cc049da0c\u003e] sget+0x1e2/0x321\n\nother info that might help us debug this:\n1 lock held by mount/13554:\n #0: (\u0026type-\u003es_umount_key#19){--..}, at: [\u003cc049da0c\u003e] sget+0x1e2/0x321\n\nstack backtrace:\nPid: 13554, comm: mount Not tainted 2.6.28-mc #479\nCall Trace:\n [\u003cc044ad2e\u003e] validate_chain+0x4c6/0xbbd\n [\u003cc044ba9b\u003e] __lock_acquire+0x676/0x700\n [\u003cc044bb82\u003e] lock_acquire+0x5d/0x7a\n [\u003cc049d888\u003e] ? sget+0x5e/0x321\n [\u003cc061b9b8\u003e] down_write+0x34/0x50\n [\u003cc049d888\u003e] ? sget+0x5e/0x321\n [\u003cc049d888\u003e] sget+0x5e/0x321\n [\u003cc045a2e7\u003e] ? cgroup_set_super+0x0/0x3e\n [\u003cc045959f\u003e] ? cgroup_test_super+0x0/0x2f\n [\u003cc045bcea\u003e] cgroup_get_sb+0x98/0x2e7\n [\u003cc045cfb6\u003e] cpuset_get_sb+0x4a/0x5f\n [\u003cc049dfa4\u003e] vfs_kern_mount+0x40/0x7b\n [\u003cc049e02d\u003e] do_kern_mount+0x37/0xbf\n [\u003cc04af4a0\u003e] do_mount+0x5c3/0x61a\n [\u003cc04addd2\u003e] ? copy_mount_options+0x2c/0x111\n [\u003cc04af560\u003e] sys_mount+0x69/0xa0\n [\u003cc0403251\u003e] sysenter_do_call+0x12/0x31\n\nThe cause is after alloc_super() and then retry, an old entry in list\nfs_supers is found, so grab_super(old) is called, but both functions hold\ns_umount lock:\n\nstruct super_block *sget(...)\n{\n\t...\nretry:\n\tspin_lock(\u0026sb_lock);\n\tif (test) {\n\t\tlist_for_each_entry(old, \u0026type-\u003efs_supers, s_instances) {\n\t\t\tif (!test(old, data))\n\t\t\t\tcontinue;\n\t\t\tif (!grab_super(old)) \u003c--- 2nd: down_write(\u0026old-\u003es_umount);\n\t\t\t\tgoto retry;\n\t\t\tif (s)\n\t\t\t\tdestroy_super(s);\n\t\t\treturn old;\n\t\t}\n\t}\n\tif (!s) {\n\t\tspin_unlock(\u0026sb_lock);\n\t\ts \u003d alloc_super(type); \u003c--- 1th: down_write(\u0026s-\u003es_umount)\n\t\tif (!s)\n\t\t\treturn ERR_PTR(-ENOMEM);\n\t\tgoto retry;\n\t}\n\t...\n}\n\nIt seems like a false positive, and seems like VFS but not cgroup needs to\nbe fixed.\n\nPeter said:\n\nWe can simply put the new s_umount instance in a but lockdep doesn\u0027t\nparticularly cares about subclass order.\n\nIf there\u0027s any issue with the callers of sget() assuming the s_umount lock\nbeing of sublcass 0, then there is another annotation we can use to fix\nthat, but lets not bother with that if this is sufficient.\n\nAddresses http://bugzilla.kernel.org/show_bug.cgi?id\u003d12673\n\nSigned-off-by: Peter Zijlstra \u003ca.p.zijlstra@chello.nl\u003e\nTested-by: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nReported-by: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Paul Menage \u003cmenage@google.com\u003e\nCc: Arjan van de Ven \u003carjan@infradead.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "766ccb9ed406c230d13c145def08ebea1b932982", "tree": "952f74260d8baa66063fd8efa1b29d2dddb45c2b", "parents": [ "f30d5b307c694e03368ab55f2f96b0ca4131e775" ], "author": { "name": "Cornelia Huck", "email": "cornelia.huck@de.ibm.com", "time": "Tue Jan 20 15:31:31 2009 +0100" }, "committer": { "name": "Arjan van de Ven", "email": "arjan@linux.intel.com", "time": "Sun Feb 08 09:56:11 2009 -0800" }, "message": "async: Rename _special -\u003e _domain for clarity.\n\nRename the async_*_special() functions to async_*_domain(), which\ndescribes the purpose of these functions much better.\n[Broke up long lines to silence checkpatch]\n\nSigned-off-by: Cornelia Huck \u003ccornelia.huck@de.ibm.com\u003e\nSigned-off-by: Arjan van de Ven \u003carjan@linux.intel.com\u003e\n" }, { "commit": "257ac264d69017270fbc3cf5536953525db4076c", "tree": "4638386ef7a5ac2b5140b055807e973e52c47f4d", "parents": [ "bdc480e3bef6eb0e7071770834cbdda7e30a5436" ], "author": { "name": "Heiko Carstens", "email": "heiko.carstens@de.ibm.com", "time": "Wed Jan 14 14:14:13 2009 +0100" }, "committer": { "name": "Heiko Carstens", "email": "heiko.carstens@de.ibm.com", "time": "Wed Jan 14 14:15:23 2009 +0100" }, "message": "[CVE-2009-0029] System call wrappers part 11\n\nSigned-off-by: Heiko Carstens \u003cheiko.carstens@de.ibm.com\u003e\n" }, { "commit": "2150edc6c5cf00f7adb54538b9ea2a3e9cedca3f", "tree": "f72a0d85e66f500b4cead348a231e3d3b9f357bc", "parents": [ "cd764695b67386a81964f68e9c66efd9f13f4d29", "4b905671d2ea09fd48fed72c581df17e40823f39" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 08 17:14:59 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 08 17:14:59 2009 -0800" }, "message": "Merge branch \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4\n\n* \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4: (57 commits)\n jbd2: Fix oops in jbd2_journal_init_inode() on corrupted fs\n ext4: Remove \"extents\" mount option\n block: Add Kconfig help which notes that ext4 needs CONFIG_LBD\n ext4: Make printk\u0027s consistently prefixed with \"EXT4-fs: \"\n ext4: Add sanity checks for the superblock before mounting the filesystem\n ext4: Add mount option to set kjournald\u0027s I/O priority\n jbd2: Submit writes to the journal using WRITE_SYNC\n jbd2: Add pid and journal device name to the \"kjournald2 starting\" message\n ext4: Add markers for better debuggability\n ext4: Remove code to create the journal inode\n ext4: provide function to release metadata pages under memory pressure\n ext3: provide function to release metadata pages under memory pressure\n add releasepage hooks to block devices which can be used by file systems\n ext4: Fix s_dirty_blocks_counter if block allocation failed with nodelalloc\n ext4: Init the complete page while building buddy cache\n ext4: Don\u0027t allow new groups to be added during block allocation\n ext4: mark the blocks/inode bitmap beyond end of group as used\n ext4: Use new buffer_head flag to check uninit group bitmaps initialization\n ext4: Fix the race between read_inode_bitmap() and ext4_new_inode()\n ext4: code cleanup\n ...\n" }, { "commit": "96777fe7b042e5a5d0fe5fb861fcd6cd80ef9634", "tree": "a39a7a0a4817ec4b2815730d09a3f8b7b76a8ab2", "parents": [ "9e42d0cf5020aaf217433cad1a224745241d212a" ], "author": { "name": "Dave Kleikamp", "email": "shaggy@linux.vnet.ibm.com", "time": "Thu Jan 08 09:46:31 2009 -0600" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 08 08:15:39 2009 -0800" }, "message": "async: Don\u0027t call async_synchronize_full_special() while holding sb_lock\n\nsync_filesystems() shouldn\u0027t be calling async_synchronize_full_special\nwhile holding a spinlock. The second while loop in that function is the\nright place for this anyway.\n\nSigned-off-by: Dave Kleikamp \u003cshaggy@linux.vnet.ibm.com\u003e\nCc: Arjan van de Ven \u003carjan@linux.intel.com\u003e\nReported-by: Grissiom \u003cchaos.proton@gmail.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "efaee192063a54749c56b7383803e16fe553630e", "tree": "b18e3072904e53701bdd7889bb32babf8cc7bf7c", "parents": [ "f29d3b23238e1955a8094e038c72546e99308e61" ], "author": { "name": "Arjan van de Ven", "email": "arjan@linux.intel.com", "time": "Tue Jan 06 07:20:54 2009 -0800" }, "committer": { "name": "Arjan van de Ven", "email": "arjan@linux.intel.com", "time": "Wed Jan 07 08:47:24 2009 -0800" }, "message": "async: make the final inode deletion an asynchronous event\n\nthis makes \"rm -rf\" on a (names cached) kernel tree go from\n11.6 to 8.6 seconds on an ext3 filesystem\n\nSigned-off-by: Arjan van de Ven \u003carjan@linux.intel.com\u003e\n" }, { "commit": "87d8fe1ee6b8d2f95076142d58c440dba4e7bdc2", "tree": "8c91506978a16c22268b086f693e307de0ca57db", "parents": [ "0087d9fb3f29f59e8d42c8b058376d80e5adde4c" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Jan 03 09:47:09 2009 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Jan 03 09:47:09 2009 -0500" }, "message": "add releasepage hooks to block devices which can be used by file systems\n\nImplement blkdev_releasepage() to release the buffer_heads and pages\nafter we release private data belonging to a mounted filesystem.\n\nCc: Toshiyuki Okajima \u003ctoshi.okajima@jp.fujitsu.com\u003e\nCc: linux-fsdevel@vger.kernel.org\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "12204e24b1330428c3062faee10a0d80b8a5cb61", "tree": "d92ee705a86f0ec2bf85c8a797239dbb840d5927", "parents": [ "459c19f524a9d89c65717a7d061d5f11ecf6bcb8" ], "author": { "name": "James Morris", "email": "jmorris@namei.org", "time": "Fri Dec 19 10:44:42 2008 +1100" }, "committer": { "name": "James Morris", "email": "jmorris@namei.org", "time": "Sat Dec 20 09:02:39 2008 +1100" }, "message": "security: pass mount flags to security_sb_kern_mount()\n\nPass mount flags to security_sb_kern_mount(), so security modules\ncan determine if a mount operation is being performed by the kernel.\n\nSigned-off-by: James Morris \u003cjmorris@namei.org\u003e\nAcked-by: Stephen Smalley \u003csds@tycho.nsa.gov\u003e\n" }, { "commit": "22484856402bfa1ff3defe47f6029ab0418240d9", "tree": "140c67bf59674da350a7b51765d6ff7eb101b597", "parents": [ "5ed487bc2c44ca4e9668ef9cb54c830e2a9fac47", "56b26add02b4bdea81d5e0ebda60db1fe3311ad4" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 23 10:23:07 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 23 10:23:07 2008 -0700" }, "message": "Merge git://git.kernel.org/pub/scm/linux/kernel/git/viro/bdev\n\n* git://git.kernel.org/pub/scm/linux/kernel/git/viro/bdev: (66 commits)\n [PATCH] kill the rest of struct file propagation in block ioctls\n [PATCH] get rid of struct file use in blkdev_ioctl() BLKBSZSET\n [PATCH] get rid of blkdev_locked_ioctl()\n [PATCH] get rid of blkdev_driver_ioctl()\n [PATCH] sanitize blkdev_get() and friends\n [PATCH] remember mode of reiserfs journal\n [PATCH] propagate mode through swsusp_close()\n [PATCH] propagate mode through open_bdev_excl/close_bdev_excl\n [PATCH] pass fmode_t to blkdev_put()\n [PATCH] kill the unused bsize on the send side of /dev/loop\n [PATCH] trim file propagation in block/compat_ioctl.c\n [PATCH] end of methods switch: remove the old ones\n [PATCH] switch sr\n [PATCH] switch sd\n [PATCH] switch ide-scsi\n [PATCH] switch tape_block\n [PATCH] switch dcssblk\n [PATCH] switch dasd\n [PATCH] switch mtd_blkdevs\n [PATCH] switch mmc\n ...\n" }, { "commit": "ad76cbc63b9db7c98da49af3182a783ca1c80a5d", "tree": "221d8d42842e693e5512764ff03a3b98f49cdfd7", "parents": [ "6de24f0ed08054b2a202902e4d63beff27654db8" ], "author": { "name": "Alexey Dobriyan", "email": "adobriyan@gmail.com", "time": "Thu Aug 28 06:26:23 2008 +0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Oct 23 05:13:14 2008 -0400" }, "message": "[PATCH 2/2] anondev: switch to IDA\n\nSigned-off-by: Alexey Dobriyan \u003cadobriyan@gmail.com\u003e\n" }, { "commit": "6de24f0ed08054b2a202902e4d63beff27654db8", "tree": "91f378a0335b5b9756020d37e1c54bba4a2d6434", "parents": [ "8966c5e0fc867f5a7da5756b4cd1b8bbbed3d5dd" ], "author": { "name": "Alexey Dobriyan", "email": "adobriyan@gmail.com", "time": "Thu Aug 28 06:25:49 2008 +0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Thu Oct 23 05:13:13 2008 -0400" }, "message": "[PATCH 1/2] anondev: init IDR statically\n\nSigned-off-by: Alexey Dobriyan \u003cadobriyan@gmail.com\u003e\n" }, { "commit": "30c40d2c01f68c7eb1a41ab3552bdaf5dbf300d4", "tree": "38b69a80c4c0df13ef3b905f5195f6cadf930223", "parents": [ "9a1c3542768b5a58e45a9216921cd10a3bae1205" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri Feb 22 19:50:45 2008 -0500" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Tue Oct 21 07:49:00 2008 -0400" }, "message": "[PATCH] propagate mode through open_bdev_excl/close_bdev_excl\n\nreplace open_bdev_excl/close_bdev_excl with variants taking fmode_t.\nsuperblock gets the value used to mount it stored in sb-\u003es_mode\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "da3bbdd4632c0171406b2677e31494afa5bde2f8", "tree": "6a1947b2a32041ef0d14044e659ba7d546d55483", "parents": [ "3c82d0ce2c4f642b2f24ef98707a030543b06b90" ], "author": { "name": "Kentaro Makita", "email": "k-makita@np.css.fujitsu.com", "time": "Wed Jul 23 21:27:13 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:15 2008 -0700" }, "message": "fix soft lock up at NFS mount via per-SB LRU-list of unused dentries\n\n[Summary]\n\n Split LRU-list of unused dentries to one per superblock to avoid soft\n lock up during NFS mounts and remounting of any filesystem.\n\n Previously I posted here:\n http://lkml.org/lkml/2008/3/5/590\n\n[Descriptions]\n\n- background\n\n dentry_unused is a list of dentries which are not referenced.\n dentry_unused grows up when references on directories or files are\n released. This list can be very long if there is huge free memory.\n\n- the problem\n\n When shrink_dcache_sb() is called, it scans all dentry_unused linearly\n under spin_lock(), and if dentry-\u003ed_sb is differnt from given\n superblock, scan next dentry. This scan costs very much if there are\n many entries, and very ineffective if there are many superblocks.\n\n IOW, When we need to shrink unused dentries on one dentry, but scans\n unused dentries on all superblocks in the system. For example, we scan\n 500 dentries to unmount a filesystem, but scans 1,000,000 or more unused\n dentries on other superblocks.\n\n In our case , At mounting NFS*, shrink_dcache_sb() is called to shrink\n unused dentries on NFS, but scans 100,000,000 unused dentries on\n superblocks in the system such as local ext3 filesystems. I hear NFS\n mounting took 1 min on some system in use.\n\n* : NFS uses virtual filesystem in rpc layer, so NFS is affected by\n this problem.\n\n 100,000,000 is possible number on large systems.\n\n Per-superblock LRU of unused dentried can reduce the cost in\n reasonable manner.\n\n- How to fix\n\n I found this problem is solved by David Chinner\u0027s \"Per-superblock\n unused dentry LRU lists V3\"(1), so I rebase it and add some fix to\n reclaim with fairness, which is in Andrew Morton\u0027s comments(2).\n\n 1) http://lkml.org/lkml/2006/5/25/318\n 2) http://lkml.org/lkml/2006/5/25/320\n\n Split LRU-list of unused dentries to each superblocks. Then, NFS\n mounting will check dentries under a superblock instead of all. But\n this spliting will break LRU of dentry-unused. So, I\u0027ve attempted to\n make reclaim unused dentrins with fairness by calculate number of\n dentries to scan on this sb based on following way\n\n number of dentries to scan on this sb \u003d\n count * (number of dentries on this sb / number of dentries in the machine)\n\n- ToDo\n - I have to measuring performance number and do stress tests.\n\n - When unmount occurs during prune_dcache(), scanning on same\n superblock, It is unable to reach next superblock because it is gone\n away. We restart scannig superblock from first one, it causes\n unfairness of reclaim unused dentries on first superblock. But I think\n this happens very rarely.\n\n- Test Results\n\n Result on 6GB boxes with excessive unused dentries.\n\nWithout patch:\n\n$ cat /proc/sys/fs/dentry-state\n10181835 10180203 45 0 0 0\n# mount -t nfs 10.124.60.70:/work/kernel-src nfs\nreal 0m1.830s\nuser 0m0.001s\nsys 0m1.653s\n\n With this patch:\n$ cat /proc/sys/fs/dentry-state\n10236610 10234751 45 0 0 0\n# mount -t nfs 10.124.60.70:/work/kernel-src nfs\nreal 0m0.106s\nuser 0m0.002s\nsys 0m0.032s\n\n[akpm@linux-foundation.org: fix comments]\nSigned-off-by: Kentaro Makita \u003ck-makita@np.css.fujitsu.com\u003e\nCc: Neil Brown \u003cneilb@suse.de\u003e\nCc: Trond Myklebust \u003ctrond.myklebust@fys.uio.no\u003e\nCc: David Chinner \u003cdgc@sgi.com\u003e\nCc: \"J. Bruce Fields\" \u003cbfields@fieldses.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6b09ae66922ca198e5830c0a4d74400a507a9170", "tree": "f434f8927f972e98637cc1cfdbc226d6f3c742de", "parents": [ "8b1919a1e8b8968e0ac9030a4f14f0d2cd69e7cf" ], "author": { "name": "Adrian Bunk", "email": "bunk@kernel.org", "time": "Tue Apr 29 00:58:54 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Apr 29 08:06:00 2008 -0700" }, "message": "make __put_super() static\n\nMake the needlessly global __put_super() static.\n\nSigned-off-by: Adrian Bunk \u003cbunk@kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0ff5af8340aa6be44220d7237ef4a654314cf795", "tree": "a9536ea573725931cd4eb3139f4885887e3f8bf8", "parents": [ "03f6e92bdd467aed9d7571a571868563ae6ad288" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Apr 28 02:14:33 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 28 08:58:33 2008 -0700" }, "message": "quota: quota core changes for quotaon on remount\n\nCurrently, we just turn quotas off on remount of filesystem to read-only\nstate. The patch below adds necessary framework so that we can turn quotas\noff on remount RO but we are able to automatically reenable them again when\nfilesystem is remounted to RW state. All we need to do is to keep references\nto inodes of quota files when remounting RO and using these references to\nreenable quotas when remounting RW.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6d59e7f582ef1c1988542d0fc3b36d0087b757ce", "tree": "2e6e2e7d42af8f89f7b87aeaf5261d4cfbd9b625", "parents": [ "807501475fce0ebe68baedf87f202c3e4ee0d12c" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sat Mar 22 15:48:17 2008 -0400" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Apr 21 23:11:01 2008 -0400" }, "message": "[PATCH] move a bunch of declarations to fs/internal.h\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "ad775f5a8faa5845377f093ca11caf577404add9", "tree": "f124ff1038672b8d2ef004d75c844f740d8fe52b", "parents": [ "2e4b7fcd926006531935a4c79a5e9349fe51125b" ], "author": { "name": "Dave Hansen", "email": "haveblue@us.ibm.com", "time": "Fri Feb 15 14:38:01 2008 -0800" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sat Apr 19 00:29:28 2008 -0400" }, "message": "[PATCH] r/o bind mounts: debugging for missed calls\n\nThere have been a few oopses caused by \u0027struct file\u0027s with NULL f_vfsmnts.\nThere was also a set of potentially missed mnt_want_write()s from\ndentry_open() calls.\n\nThis patch provides a very simple debugging framework to catch these kinds of\nbugs. It will WARN_ON() them, but should stop us from having any oopses or\nmnt_writer count imbalances.\n\nI\u0027m quite convinced that this is a good thing because it found bugs in the\nstuff I was working on as soon as I wrote it.\n\n[hch: made it conditional on a debug option.\n But it\u0027s still a little bit too ugly]\n\n[hch: merged forced remount r/o fix from Dave and akpm\u0027s fix for the fix]\n\nSigned-off-by: Dave Hansen \u003chaveblue@us.ibm.com\u003e\nAcked-by: Al Viro \u003cviro@ZenIV.linux.org.uk\u003e\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "49e0d02cf018d4edf24bfc8531a816a26367e4ce", "tree": "f1695d9ec2298b726ff39f42aaf8d4fd3ade8487", "parents": [ "aceaf78da92a53f5e1b105649a1b8c0afdb2135c" ], "author": { "name": "Dave Hansen", "email": "haveblue@us.ibm.com", "time": "Fri Feb 15 14:37:32 2008 -0800" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sat Apr 19 00:25:33 2008 -0400" }, "message": "[PATCH] r/o bind mounts: drop write during emergency remount\n\nThe emergency remount code forcibly removes FMODE_WRITE from\nfilps. The r/o bind mount code notices that this was done\nwithout a proper mnt_drop_write() and properly gives a\nwarning.\n\nThis patch does a mnt_drop_write() to keep everything\nbalanced.\n\nAcked-by: Al Viro \u003cviro@ZenIV.linux.org.uk\u003e\nSigned-off-by: Christoph Hellwig \u003chch@infradead.org\u003e\nSigned-off-by: Dave Hansen \u003chaveblue@us.ibm.com\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "7ed7fe5e82c9fc8473974fbd7389d169b8f17c77", "tree": "ff6ff57c88c887133f1585473e7d74981d0dc88c", "parents": [ "a4083c9271e0a697278e089f2c0b9a95363ada0a", "a02f76c34d7d6d30b63ac64a8b34dea68593e8da" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Mar 25 08:57:47 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Mar 25 08:57:47 2008 -0700" }, "message": "Merge branch \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6\n\n* \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6:\n [PATCH] get stack footprint of pathname resolution back to relative sanity\n [PATCH] double iput() on failure exit in hugetlb\n [PATCH] double dput() on failure exit in tiny-shmem\n [PATCH] fix up new filp allocators\n [PATCH] check for null vfsmount in dentry_open()\n [PATCH] reiserfs: eliminate private use of struct file in xattr\n [PATCH] sanitize hppfs\n hppfs pass vfsmount to dentry_open()\n [PATCH] restore export of do_kern_mount()\n" }, { "commit": "a6b91919e0881a0d0a4ae5211d5c879a8c7ca92b", "tree": "148aabc0a92a297f9220174435e822f30c951215", "parents": [ "5366dc9fd1cb74023790a8edf29e4fe42c886dcf" ], "author": { "name": "Randy Dunlap", "email": "randy.dunlap@oracle.com", "time": "Wed Mar 19 17:01:00 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Mar 19 18:53:36 2008 -0700" }, "message": "fs: fix kernel-doc notation warnings\n\nFix kernel-doc notation warnings in fs/.\n\nWarning(mmotm-2008-0314-1449//fs/super.c:560): missing initial short description on line:\n *\tmark_files_ro\nWarning(mmotm-2008-0314-1449//fs/locks.c:1277): missing initial short description on line:\n *\tlease_get_mtime\nWarning(mmotm-2008-0314-1449//fs/locks.c:1277): missing initial short description on line:\n *\tlease_get_mtime\nWarning(mmotm-2008-0314-1449//fs/namei.c:1368): missing initial short description on line:\n * lookup_one_len: filesystem helper to lookup single pathname component\nWarning(mmotm-2008-0314-1449//fs/buffer.c:3221): missing initial short description on line:\n * bh_uptodate_or_lock: Test whether the buffer is uptodate\nWarning(mmotm-2008-0314-1449//fs/buffer.c:3240): missing initial short description on line:\n * bh_submit_read: Submit a locked buffer for reading\nWarning(mmotm-2008-0314-1449//fs/fs-writeback.c:30): missing initial short description on line:\n * writeback_acquire: attempt to get exclusive writeback access to a device\nWarning(mmotm-2008-0314-1449//fs/fs-writeback.c:47): missing initial short description on line:\n * writeback_in_progress: determine whether there is writeback in progress\nWarning(mmotm-2008-0314-1449//fs/fs-writeback.c:58): missing initial short description on line:\n * writeback_release: relinquish exclusive writeback access against a device.\nWarning(mmotm-2008-0314-1449//include/linux/jbd.h:351): contents before sections\nWarning(mmotm-2008-0314-1449//include/linux/jbd.h:561): contents before sections\nWarning(mmotm-2008-0314-1449//fs/jbd/transaction.c:1935): missing initial short description on line:\n * void journal_invalidatepage()\n\nSigned-off-by: Randy Dunlap \u003crandy.dunlap@oracle.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8a4e98d9d758d0eb751916e906fae40bda151b11", "tree": "c7d94a18308b55cb9de1837f839af7fdfb8b624e", "parents": [ "bde4f8fa8db2abd5ac9c542d76012d0fedab050f" ], "author": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Sun Feb 24 01:43:03 2008 -0500" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Mar 17 22:58:04 2008 -0400" }, "message": "[PATCH] restore export of do_kern_mount()\n\nvfs_kern_mount() requires having a reference to fs type, which\nmakes it impossible for module to create procfs, etc. private\nmount. Open-coding is not an option, since e.g. put_filesystem()\nis _not_ exported, and for a good reason.\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "e0007529893c1c064be90bd21422ca0da4a0198e", "tree": "c2334ba940e682183a18d18972cf95bd3a3da46a", "parents": [ "29e8c3c304b62f31b799565c9ee85d42bd163f80" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Wed Mar 05 10:31:54 2008 -0500" }, "committer": { "name": "James Morris", "email": "jmorris@namei.org", "time": "Thu Mar 06 08:40:53 2008 +1100" }, "message": "LSM/SELinux: Interfaces to allow FS to control mount options\n\nIntroduce new LSM interfaces to allow an FS to deal with their own mount\noptions. This includes a new string parsing function exported from the\nLSM that an FS can use to get a security data blob and a new security\ndata blob. This is particularly useful for an FS which uses binary\nmount data, like NFS, which does not pass strings into the vfs to be\nhandled by the loaded LSM. Also fix a BUG() in both SELinux and SMACK\nwhen dealing with binary mount data. If the binary mount data is less\nthan one page the copy_page() in security_sb_copy_data() can cause an\nillegal page fault and boom. Remove all NFSisms from the SELinux code\nsince they were broken by past NFS changes.\n\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\nAcked-by: Stephen Smalley \u003csds@tycho.nsa.gov\u003e\nAcked-by: Casey Schaufler \u003ccasey@schaufler-ca.com\u003e\nSigned-off-by: James Morris \u003cjmorris@namei.org\u003e\n" }, { "commit": "66191dc622f5ff0a541524c4e96fdacfacfda206", "tree": "6bd6c7402d5f71f43c161e694d04c535ffc98b57", "parents": [ "28ae094c625a9b719c01cf5ec45b8640e6911f53" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Fri Feb 08 04:22:13 2008 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@woody.linux-foundation.org", "time": "Fri Feb 08 09:22:44 2008 -0800" }, "message": "quota: turn quotas off when remounting read-only\n\nTurn off quotas before filesystem is remounted read only. Otherwise quota\nwill try to write to read-only filesystem which does no good... We could\nalso just refuse to remount ro when quota is enabled but turning quota off\nis consistent with what we do on umount.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nCc: \u003cstable@kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" } ], "next": "b3b304a23a8f7ae4c40c7b512ee45afae0010a70" }