)]}' { "log": [ { "commit": "aabb8fdb41128705fd1627f56fdd571e45fdbcdb", "tree": "bae6e9abf167cf20b9a2d3e5c38520d3f17b777d", "parents": [ "1bd7903560f1f713e85188a5aaf4d2428b6c8b50" ], "author": { "name": "Nick Piggin", "email": "npiggin@suse.de", "time": "Wed Mar 11 13:17:36 2009 -0700" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Fri Mar 27 14:44:05 2009 -0400" }, "message": "fs: avoid I_NEW inodes\n\nTo be on the safe side, it should be less fragile to exclude I_NEW inodes\nfrom inode list scans by default (unless there is an important reason to\nhave them).\n\nNormally they will get excluded (eg. by zero refcount or writecount etc),\nhowever it is a bit fragile for list walkers to know exactly what parts of\nthe inode state is set up and valid to test when in I_NEW. So along these\nlines, move I_NEW checks upward as well (sometimes taking I_FREEING etc\nchecks with them too -- this shouldn\u0027t be a problem should it?)\n\nSigned-off-by: Nick Piggin \u003cnpiggin@suse.de\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "f04b30de3c82528f1ab4c58b3dd4c975f5341901", "tree": "1d3410190d93a72c0a98961704086ba17c21d326", "parents": [ "be50344e604f956891fc0013f1ba78823a758124" ], "author": { "name": "Ingo Molnar", "email": "mingo@elte.hu", "time": "Wed Feb 18 14:48:43 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Feb 18 15:37:56 2009 -0800" }, "message": "inotify: fix GFP_KERNEL related deadlock\n\nEnhanced lockdep coverage of __GFP_NOFS turned up this new lockdep\nassert:\n\n[ 1093.677775]\n[ 1093.677781] \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n[ 1093.680031] [ INFO: inconsistent lock state ]\n[ 1093.680031] 2.6.29-rc5-tip-01504-gb49eca1-dirty #1\n[ 1093.680031] ---------------------------------\n[ 1093.680031] inconsistent {RECLAIM_FS-ON-W} -\u003e {IN-RECLAIM_FS-W} usage.\n[ 1093.680031] kswapd0/308 [HC0[0]:SC0[0]:HE1:SE1] takes:\n[ 1093.680031] (\u0026inode-\u003einotify_mutex){+.+.?.}, at: [\u003cc0205942\u003e] inotify_inode_is_dead+0x20/0x80\n[ 1093.680031] {RECLAIM_FS-ON-W} state was registered at:\n[ 1093.680031] [\u003cc01696b9\u003e] mark_held_locks+0x43/0x5b\n[ 1093.680031] [\u003cc016baa4\u003e] lockdep_trace_alloc+0x6c/0x6e\n[ 1093.680031] [\u003cc01cf8b0\u003e] kmem_cache_alloc+0x20/0x150\n[ 1093.680031] [\u003cc040d0ec\u003e] idr_pre_get+0x27/0x6c\n[ 1093.680031] [\u003cc02056e3\u003e] inotify_handle_get_wd+0x25/0xad\n[ 1093.680031] [\u003cc0205f43\u003e] inotify_add_watch+0x7a/0x129\n[ 1093.680031] [\u003cc020679e\u003e] sys_inotify_add_watch+0x20f/0x250\n[ 1093.680031] [\u003cc010389e\u003e] sysenter_do_call+0x12/0x35\n[ 1093.680031] [\u003cffffffff\u003e] 0xffffffff\n[ 1093.680031] irq event stamp: 60417\n[ 1093.680031] hardirqs last enabled at (60417): [\u003cc018d5f5\u003e] call_rcu+0x53/0x59\n[ 1093.680031] hardirqs last disabled at (60416): [\u003cc018d5b9\u003e] call_rcu+0x17/0x59\n[ 1093.680031] softirqs last enabled at (59656): [\u003cc0146229\u003e] __do_softirq+0x157/0x16b\n[ 1093.680031] softirqs last disabled at (59651): [\u003cc0106293\u003e] do_softirq+0x74/0x15d\n[ 1093.680031]\n[ 1093.680031] other info that might help us debug this:\n[ 1093.680031] 2 locks held by kswapd0/308:\n[ 1093.680031] #0: (shrinker_rwsem){++++..}, at: [\u003cc01b0502\u003e] shrink_slab+0x36/0x189\n[ 1093.680031] #1: (\u0026type-\u003es_umount_key#4){+++++.}, at: [\u003cc01e6d77\u003e] shrink_dcache_memory+0x110/0x1fb\n[ 1093.680031]\n[ 1093.680031] stack backtrace:\n[ 1093.680031] Pid: 308, comm: kswapd0 Not tainted 2.6.29-rc5-tip-01504-gb49eca1-dirty #1\n[ 1093.680031] Call Trace:\n[ 1093.680031] [\u003cc016947a\u003e] valid_state+0x12a/0x13d\n[ 1093.680031] [\u003cc016954e\u003e] mark_lock+0xc1/0x1e9\n[ 1093.680031] [\u003cc016a5b4\u003e] ? check_usage_forwards+0x0/0x3f\n[ 1093.680031] [\u003cc016ab74\u003e] __lock_acquire+0x2c6/0xac8\n[ 1093.680031] [\u003cc01688d9\u003e] ? register_lock_class+0x17/0x228\n[ 1093.680031] [\u003cc016b3d3\u003e] lock_acquire+0x5d/0x7a\n[ 1093.680031] [\u003cc0205942\u003e] ? inotify_inode_is_dead+0x20/0x80\n[ 1093.680031] [\u003cc08824c4\u003e] __mutex_lock_common+0x3a/0x4cb\n[ 1093.680031] [\u003cc0205942\u003e] ? inotify_inode_is_dead+0x20/0x80\n[ 1093.680031] [\u003cc08829ed\u003e] mutex_lock_nested+0x2e/0x36\n[ 1093.680031] [\u003cc0205942\u003e] ? inotify_inode_is_dead+0x20/0x80\n[ 1093.680031] [\u003cc0205942\u003e] inotify_inode_is_dead+0x20/0x80\n[ 1093.680031] [\u003cc01e6672\u003e] dentry_iput+0x90/0xc2\n[ 1093.680031] [\u003cc01e67a3\u003e] d_kill+0x21/0x45\n[ 1093.680031] [\u003cc01e6a46\u003e] __shrink_dcache_sb+0x27f/0x355\n[ 1093.680031] [\u003cc01e6dc5\u003e] shrink_dcache_memory+0x15e/0x1fb\n[ 1093.680031] [\u003cc01b05ed\u003e] shrink_slab+0x121/0x189\n[ 1093.680031] [\u003cc01b0d12\u003e] kswapd+0x39f/0x561\n[ 1093.680031] [\u003cc01ae499\u003e] ? isolate_pages_global+0x0/0x233\n[ 1093.680031] [\u003cc0157eae\u003e] ? autoremove_wake_function+0x0/0x43\n[ 1093.680031] [\u003cc01b0973\u003e] ? kswapd+0x0/0x561\n[ 1093.680031] [\u003cc0157daf\u003e] kthread+0x41/0x82\n[ 1093.680031] [\u003cc0157d6e\u003e] ? kthread+0x0/0x82\n[ 1093.680031] [\u003cc01043ab\u003e] kernel_thread_helper+0x7/0x10\n\ninotify_handle_get_wd() does idr_pre_get() which does a\nkmem_cache_alloc() without __GFP_FS - and is hence deadlockable under\nextreme MM pressure.\n\nSigned-off-by: Ingo Molnar \u003cmingo@elte.hu\u003e\nAcked-by: Peter Zijlstra \u003ca.p.zijlstra@chello.nl\u003e\nCc: MinChan Kim \u003cminchan.kim@gmail.com\u003e\nCc: Nick Piggin \u003cnickpiggin@yahoo.com.au\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3632dee2f8b8a9720329f29eeaa4ec4669a3aff8", "tree": "602fc5cc96145472210a4254680d539c81cb02e7", "parents": [ "aeb565dfc3ac4c8b47c5049085b4c7bfb2c7d5d7" ], "author": { "name": "Vegard Nossum", "email": "vegard.nossum@gmail.com", "time": "Thu Jan 22 15:29:45 2009 +0100" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jan 26 10:08:05 2009 -0800" }, "message": "inotify: clean up inotify_read and fix locking problems\n\nIf userspace supplies an invalid pointer to a read() of an inotify\ninstance, the inotify device\u0027s event list mutex is unlocked twice.\nThis causes an unbalance which effectively leaves the data structure\nunprotected, and we can trigger oopses by accessing the inotify\ninstance from different tasks concurrently.\n\nThe best fix (contributed largely by Linus) is a total rewrite\nof the function in question:\n\nOn Thu, Jan 22, 2009 at 7:05 AM, Linus Torvalds wrote:\n\u003e The thing to notice is that:\n\u003e\n\u003e - locking is done in just one place, and there is no question about it\n\u003e not having an unlock.\n\u003e\n\u003e - that whole double-while(1)-loop thing is gone.\n\u003e\n\u003e - use multiple functions to make nesting and error handling sane\n\u003e\n\u003e - do error testing after doing the things you always need to do, ie do\n\u003e this:\n\u003e\n\u003e mutex_lock(..)\n\u003e ret \u003d function_call();\n\u003e mutex_unlock(..)\n\u003e\n\u003e .. test ret here ..\n\u003e\n\u003e instead of doing conditional exits with unlocking or freeing.\n\u003e\n\u003e So if the code is written in this way, it may still be buggy, but at least\n\u003e it\u0027s not buggy because of subtle \"forgot to unlock\" or \"forgot to free\"\n\u003e issues.\n\u003e\n\u003e This _always_ unlocks if it locked, and it always frees if it got a\n\u003e non-error kevent.\n\nCc: John McCutchan \u003cttb@tentacle.dhs.org\u003e\nCc: Robert Love \u003crlove@google.com\u003e\nCc: \u003cstable@kernel.org\u003e\nSigned-off-by: Vegard Nossum \u003cvegard.nossum@gmail.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2e4d0924eb0c403ce4014fa139d1d61bf2c44fee", "tree": "58249b615c3a7a77154d4c9d006ea9acd04bbef9", "parents": [ "938bb9f5e840eddbf54e4f62f6c5ba9b3ae12c9d" ], "author": { "name": "Heiko Carstens", "email": "heiko.carstens@de.ibm.com", "time": "Wed Jan 14 14:14:31 2009 +0100" }, "committer": { "name": "Heiko Carstens", "email": "heiko.carstens@de.ibm.com", "time": "Wed Jan 14 14:15:30 2009 +0100" }, "message": "[CVE-2009-0029] System call wrappers part 29\n\nSigned-off-by: Heiko Carstens \u003cheiko.carstens@de.ibm.com\u003e\n" }, { "commit": "938bb9f5e840eddbf54e4f62f6c5ba9b3ae12c9d", "tree": "a25324159ed8cc96b97a4d39aaf228bbd07e3824", "parents": [ "1e7bfb2134dfec37ce04fb3a4ca89299e892d10c" ], "author": { "name": "Heiko Carstens", "email": "heiko.carstens@de.ibm.com", "time": "Wed Jan 14 14:14:30 2009 +0100" }, "committer": { "name": "Heiko Carstens", "email": "heiko.carstens@de.ibm.com", "time": "Wed Jan 14 14:15:30 2009 +0100" }, "message": "[CVE-2009-0029] System call wrappers part 28\n\nSigned-off-by: Heiko Carstens \u003cheiko.carstens@de.ibm.com\u003e\n" }, { "commit": "4ae8978cf92a96257cd8998a49e781be83571d64", "tree": "5c5e2719c17093309b4e22bfbf4deb7bd3e91ac8", "parents": [ "2f1169e2dc0c70e213f79ada88a10912cc2fbe94" ], "author": { "name": "Michael Kerrisk", "email": "mtk.manpages@googlemail.com", "time": "Mon Jan 05 07:19:16 2009 -0500" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Mon Jan 05 11:54:29 2009 -0500" }, "message": "inotify: fix type errors in interfaces\n\nThe problems lie in the types used for some inotify interfaces, both at the kernel level and at the glibc level. This mail addresses the kernel problem. I will follow up with some suggestions for glibc changes.\n\nFor the sys_inotify_rm_watch() interface, the type of the \u0027wd\u0027 argument is\ncurrently \u0027u32\u0027, it should be \u0027__s32\u0027 . That is Robert\u0027s suggestion, and\nis consistent with the other declarations of watch descriptors in the\nkernel source, in particular, the inotify_event structure in\ninclude/linux/inotify.h:\n\nstruct inotify_event {\n __s32 wd; /* watch descriptor */\n __u32 mask; /* watch mask */\n __u32 cookie; /* cookie to synchronize two events */\n __u32 len; /* length (including nulls) of name */\n char name[0]; /* stub for possible name */\n};\n\nThe patch makes the changes needed for inotify_rm_watch().\n\nSigned-off-by: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nCc: Robert Love \u003crlove@google.com\u003e\nCc: Vegard Nossum \u003cvegard.nossum@gmail.com\u003e\nCc: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "272eb01485dda98e3b8910c7c1a53d597616b0a0", "tree": "6a1dcd34c1dd668b465c166c2d6d2596924eff5f", "parents": [ "c2acf7b90821785fe812cc0aa05148e5a1f84204" ], "author": { "name": "Eric Paris", "email": "eparis@redhat.com", "time": "Wed Dec 17 13:59:41 2008 -0500" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Dec 31 18:07:43 2008 -0500" }, "message": "filesystem notification: create fs/notify to contain all fs notification\n\nCreating a generic filesystem notification interface, fsnotify, which will be\nused by inotify, dnotify, and eventually fanotify is really starting to\nclutter the fs directory. This patch simply moves inotify and dnotify into\nfs/notify/inotify and fs/notify/dnotify respectively to make both current fs/\nand future notification tidier.\n\nSigned-off-by: Eric Paris \u003ceparis@redhat.com\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" } ] }