)]}' { "log": [ { "commit": "72fa396bf57b31e8e2a401a21a3a088c0cc6b043", "tree": "c4094d3f8db3265dd122952867c1e8ff4e6abb63", "parents": [ "f31624831a79b9e3f129f6c3b0a1b83903a7b61e" ], "author": { "name": "Vasu Dev", "email": "vasu.dev@intel.com", "time": "Fri Feb 25 15:03:01 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Mon Feb 28 18:31:53 2011 -0600" }, "message": "[SCSI] fcoe, libfc: initialize EM anchors list and then update npiv EMs\n\nEM anchors list initialization for only master port was not enough to\nkeep npiv working as described here:-\nhttps://lists.open-fcoe.org/pipermail/devel/2011-January/011063.html\n\nSo this patch moves fc_exch_mgr_list_clone to update npiv ports\nEMs once EM anchors list initialized.\n\nAlso some cleanup, no need to set lport \u003d NULL as that always\nget initialized later.\n\nSigned-off-by: Vasu Dev \u003cvasu.dev@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "f31624831a79b9e3f129f6c3b0a1b83903a7b61e", "tree": "f3ab9ff37a648ae0e1b3cd330d34bacaa633b939", "parents": [ "fe5e3f1aec310779a4b830022a26842b8d587228" ], "author": { "name": "Parikh, Neerav", "email": "neerav.parikh@intel.com", "time": "Fri Feb 25 15:02:56 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Mon Feb 28 18:31:13 2011 -0600" }, "message": "[SCSI] Revert \"[SCSI] libfc: fix exchange being deleted when the abort itself is timed out\"\n\nWhen abort for an exchange timed out it didn\u0027t release the reference to\nthe exchange resulting in a memory leak.\n\nAfter discussion with the author of the patch (CC) that introduced this\nbug it was suggested to revert that patch.\n\nThis reverts commit ea3e2e72eeb3e8a9440a5da965914f9b12088626.\n\nSigned-off by: Neerav Parikh \u003cNeerav.Parikh@intel.com\u003e\nTested-by: Ross Brattain \u003cross.b.brattain@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "fe5e3f1aec310779a4b830022a26842b8d587228", "tree": "03de79c89ad0a9d725e7bca2b952a7279e8ff135", "parents": [ "00fa2b191b4bd74e9d22ac177e3d9e8ecd3582d3" ], "author": { "name": "Parikh, Neerav", "email": "neerav.parikh@intel.com", "time": "Fri Feb 25 15:02:51 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Mon Feb 28 18:28:45 2011 -0600" }, "message": "[SCSI] libfc: Fixing a memory leak when destroying an interface\n\nWhen an fcoe interface is being destroyed; in the process the\nfcoe driver will try to release all the resources it had allocated\nfor that interface including rports. But, it seems that it does not\nrelease the reference held for the name server rport in that process\nresulting into a memory leak. This patch fixes that memory leak.\n\nSigned-off-by: Neerav Parikh \u003cneerav.parikh@intel.com\u003e\nTested-by: Ross Brattain \u003cross.b.brattain@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "75a2792df296c77004a72056c76628a1f835bc93", "tree": "767bafd5718fc112d440bf3d8d1369eeb1d557e9", "parents": [ "acc1a921659561c4ea97eca6e3c2633adecbcd81" ], "author": { "name": "Bhanu Prakash Gollapudi", "email": "bprakash@broadcom.com", "time": "Fri Jan 28 16:05:27 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 11:09:04 2011 -0600" }, "message": "[SCSI] libfc: introduce LLD event callback\n\nThis patch enables LLD to listen to rport events and perform LLD\nspecific operations based on the rport event. This patch also stores\nsp_features and spp_type in rdata for further reference by LLD.\n\nSigned-off-by: Bhanu Prakash Gollapudi \u003cbprakash@broadcom.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "acc1a921659561c4ea97eca6e3c2633adecbcd81", "tree": "50f99072fc7fbdcc7c317b52154ca47b0bd1b963", "parents": [ "78a582463c1e3a262aeaf2a291e06a93a7b34212" ], "author": { "name": "Kiran Patil", "email": "kiran.patil@intel.com", "time": "Fri Jan 28 16:05:22 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 11:08:22 2011 -0600" }, "message": "[SCSI] libfc: Extending lport\u0027s roles for target if there is a registered target.\n\nProblem:\n\nFrom initaitor machine, when queried role of target (other end of connection),\nit is \"initiator\", hence SCSI-ml doesn\u0027t send any LUN Inquiry commands.\n\nFix:\n\nIf there is a registered target for FC_TYPE_FCP, extend lport\u0027s params\n(capability) to be target as well, By default lport params are\nINITIATOR only. Having this fix, caused initiator to send SCSI LUN\ninquiry command to target.\n\nSigned-off-by: Kiran Patil \u003ckiran.patil@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "6c8cc1c003cee1c4290f5d8c684912d60354056a", "tree": "883c9a03940b76da5751f67d7171a235a336c23a", "parents": [ "62bdb6455e8326f864ae1b43b4c4db7f630edc1c" ], "author": { "name": "Kiran Patil", "email": "kiran.patil@intel.com", "time": "Fri Jan 28 16:04:39 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 11:04:27 2011 -0600" }, "message": "[SCSI] libfc: Enhanced exchange ID selection mechanism and fix related EMA selection logic.\n\nProblem:\n\nIn case of exchange responder case, EMA selection was defaulted to the\nlast EMA from EMA list (lport.ema_list). If exchange ID is selected\nfrom offload pool and not setup DDP, resulting into incorrect\nselection of EMA, and eventually dropping the packet because unable to\nfind exchange.\n\nFix:\n\nEnhanced the exchange ID selection (depending upon request type and\nexchange responder) Made necessary enhancement in EMA selection\nalgorithm.\n\nSigned-off-by: Kiran Patil \u003ckiran.patil@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "62bdb6455e8326f864ae1b43b4c4db7f630edc1c", "tree": "a802a76583670b42d7d36f69241e6bb31ff49b16", "parents": [ "04885b16a1ec86b4670702b99a81805e66bf9f30" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Jan 28 16:04:34 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 11:03:40 2011 -0600" }, "message": "[SCSI] libfc: export seq_release() for users of seq_assign()\n\nTarget modules using lport-\u003ett.seq_assign() get a hold on the\nexchange but have no way of releasing it. Add that.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "04885b16a1ec86b4670702b99a81805e66bf9f30", "tree": "136525d2615f044bd1a362790529c4ac2b45cdd5", "parents": [ "925cedae2b223d44d59a02df1b35902fc8bdd6d2" ], "author": { "name": "Robert Love", "email": "robert.w.love@intel.com", "time": "Fri Jan 28 16:04:29 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 11:02:25 2011 -0600" }, "message": "[SCSI] libfc: Remove usage of the Scsi_Host\u0027s host_lock\n\nThis patch removes the use of the Scsi_Host\u0027s host_lock\nwithin fc_queuecommand. It also removes the DEF_SCSI_QCMD\nusage so that libfc has fully moved on to the new\nqueuecommand interface.\n\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nTested-by: Ross Brattain \u003cross.b.brattain@intel.com\u003e\nReviewed-by: Nicholas A. Bellinger \u003cnab@linux-iscsi.org\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "925cedae2b223d44d59a02df1b35902fc8bdd6d2", "tree": "4fe2398d8761fd967a3ade45265ac6ce46319e9e", "parents": [ "70d53b046a6221e3ceb3bd8eaa807ef6a1c53762" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Jan 28 16:04:23 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 11:02:22 2011 -0600" }, "message": "[SCSI] libfc: use PRLI hook to get parameters when sending outgoing PRLI\n\nWhen sending an outgoing PRLI as an initiator, get the parameters\nfrom registered providers so that they all get a chance to decide\non roles.\n\nThe passive provider is called last, and could override the\ninitiator role.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "70d53b046a6221e3ceb3bd8eaa807ef6a1c53762", "tree": "f1ab4e0de20a8db091ea04df564a03a689698b40", "parents": [ "baf9fdf076a8976431b5de565aef2b98816caecf" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Jan 28 16:04:18 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 11:02:20 2011 -0600" }, "message": "[SCSI] libfc: add hook to notify providers of local port changes\n\nWhen an SCST provider is registered, it needs to know what\nlocal ports are available for configuration as targets.\n\nAdd a notifier chain that is invoked when any local port\nthat is added or deleted.\n\nMaintain a global list of local ports and add an\ninterator function that calls a given function for\nevery existing local port. This is used when first\nloading a provider.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "1a5c2d7e5c8ef239804cb08b68363e0cd2f74a3d", "tree": "1131440f3cb543911c0df18fb64e476b27866559", "parents": [ "96ad846445ae33dcae1805b68752e3d5c840e3ed" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Jan 28 16:04:08 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 11:01:21 2011 -0600" }, "message": "[SCSI] libfc: add method for setting handler for incoming exchange\n\nAdd a method for setting handler for incoming exchange.\nFor multi-sequence exchanges, this allows the target driver\nto add a response handler for handling subsequent sequences,\nand exchange manager resets.\n\nThe new function is called fc_seq_set_resp().\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "96ad846445ae33dcae1805b68752e3d5c840e3ed", "tree": "e73ea227c24d90654d58f0cfbec00f689bdac081", "parents": [ "55204909bb687c997d5601e9f24a25cf9e915d78" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Jan 28 16:04:02 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 11:00:40 2011 -0600" }, "message": "[SCSI] libfc: add hook for FC-4 provider registration\n\nAllow FC-4 provider modules to hook into libfc, mostly for targets.\nThis should allow any FC-4 module to handle PRLI requests and maintain\nprocess-association states.\n\nEach provider registers its ops with libfc and then will be called for\nany incoming PRLI for that FC-4 type on any instance. The provider\ncan decide whether to handle that particular instance using any method\nit likes, such as ACLs or other configuration information.\n\nA count is kept of the number of successful PRLIs from the remote port.\nProviders are called back with an implicit PRLO when the remote port\nis about to be deleted or has been reset.\n\nfc_lport_recv_req() now sends incoming FC-4 requests to FC-4 providers,\nand there is a built-in provider always registered for handling\nincoming ELS requests.\n\nThe call to provider recv() routines uses rcu_read_lock()\nso that providers aren\u0027t removed during the call. That lock is very\ncheap and shouldn\u0027t affect any performance on ELS requests.\nProviders can rely on the RCU lock to protect a session lookup as well.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "55204909bb687c997d5601e9f24a25cf9e915d78", "tree": "de207b0f51dc40de1e08cdac22a019abc9b8b0e9", "parents": [ "52ee832195b0ae33f12e334e61cf43d1087f24d6" ], "author": { "name": "Randy Dunlap", "email": "randy.dunlap@oracle.com", "time": "Fri Jan 28 16:03:57 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 11:00:08 2011 -0600" }, "message": "[SCSI] libfc: fix sparse static and non-ANSI warnings\n\nFix sparse warning for non-ANSI function declaration.\nDeclare workqueue structs as static.\n\nSigned-off-by: Randy Dunlap \u003crandy.dunlap@oracle.com\u003e\nCc:\tRobert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "e4a9a98289606392f2b1b24b4ca4e29154ec4d15", "tree": "2f2b31f1dddebe7a0bc6d8d97034272314861833", "parents": [ "28a4af1e43047531ab612564e32ab9969c9dd965" ], "author": { "name": "Dan Carpenter", "email": "error27@gmail.com", "time": "Fri Jan 28 16:03:31 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 10:57:54 2011 -0600" }, "message": "[SCSI] libfc:prevent dereferencing ERR_PTR in fc_tm_done()\n\nIf we goto out, then it tries to call kfree_skb() on an ERR_PTR which\nwill oops. Just return directly.\n\nSigned-off-by: Dan Carpenter \u003cerror27@gmail.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "28a4af1e43047531ab612564e32ab9969c9dd965", "tree": "2c91320742f7d6110d034b7627684f4090724d3b", "parents": [ "fa79dbdbdd166025b5835bddaff152bb57c4440a" ], "author": { "name": "Hillf Danton", "email": "dhillf@gmail.com", "time": "Fri Jan 28 16:03:26 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 10:57:22 2011 -0600" }, "message": "[SCSI] libfc: Cleanup return paths in fc_rport_error_retry\n\nThis patch makes it so that we only have one call to\nfc_rport_error. This patch does not completely\nconsolidate return statements, there is still one return\nused when not calling fc_rport_error, but alternative\nsolutions made the code more confusing.\n\n[ Patch modified by Robert Love ]\n[ Patch title and commit message edited by Robert Love\n to make it more relevant ]\n\nSigned-off-by: Hillf Danton \u003cdhillf@gmail.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "fa79dbdbdd166025b5835bddaff152bb57c4440a", "tree": "f631eae1377cee65a35d7559d23839cf3ebdbf5e", "parents": [ "f56635a8695f6b4fccf546cb2d5cf246d1892a0f" ], "author": { "name": "Hillf Danton", "email": "dhillf@gmail.com", "time": "Fri Jan 28 16:03:21 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 10:57:06 2011 -0600" }, "message": "[SCSI] libfc: Return a valid return code in fc_fcp_pkt_abort()\n\nHere ticks_left is added to record the result of\nwait_for_completion_timeout().\n\n[ Patch title and description edited by Robert Love\n to make it more descriptive ]\n\nSigned-off-by: Hillf Danton \u003cdhillf@gmail.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "f56635a8695f6b4fccf546cb2d5cf246d1892a0f", "tree": "9ed9c69c322e34e6c0bdbcd3e1d6e1b863d50d9f", "parents": [ "79775567e0439ca47eb9f501e52c4b713d44cf89" ], "author": { "name": "Yi Zou", "email": "yi.zou@intel.com", "time": "Fri Jan 28 16:03:15 2011 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Feb 12 10:56:53 2011 -0600" }, "message": "[SCSI] libfc: always initialize the FCoE DDP exchange id for fsp as FC_XID_UNKNOWN\n\nThe fsp\u0027s xfer_ddp is used as indication of the exchange id for the DDPed\nI/O. We should always initialize it as FC_XID_UNKNOWN for a newly allocated\nfsp, otherwise the fsp allocated in fc_fcp, i.e., not from queuecommand like\nLUN RESET that is not doing DDP may still think DDP is setup for it since xid\n0 is valid and goes on to call fc_fcp_ddp_done() in fc_fcp_resp() from\nfc_tm_done(). So, set xfer_ddp as FC_XID_UNKNOWN in fc_fcp_pkt_alloc() now.\n\nAlso removes the setting of fsp-\u003elp as it\u0027s already done when fsp is allocated.\n\nSigned-off-by: Yi Zou \u003cyi.zou@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "008d23e4852d78bb2618f2035f8b2110b6a6b968", "tree": "81c88f744f6f3fc84132527c1ddc0b4da410c5e2", "parents": [ "8f685fbda43deccd130d192c9fcef1444649eaca", "bfc672dcf323877228682aff79dff8ecd9f30ff8" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 10:05:56 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 10:05:56 2011 -0800" }, "message": "Merge branch \u0027for-next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial\n\n* \u0027for-next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (43 commits)\n Documentation/trace/events.txt: Remove obsolete sched_signal_send.\n writeback: fix global_dirty_limits comment runtime -\u003e real-time\n ppc: fix comment typo singal -\u003e signal\n drivers: fix comment typo diable -\u003e disable.\n m68k: fix comment typo diable -\u003e disable.\n wireless: comment typo fix diable -\u003e disable.\n media: comment typo fix diable -\u003e disable.\n remove doc for obsolete dynamic-printk kernel-parameter\n remove extraneous \u0027is\u0027 from Documentation/iostats.txt\n Fix spelling milisec -\u003e ms in snd_ps3 module parameter description\n Fix spelling mistakes in comments\n Revert conflicting V4L changes\n i7core_edac: fix typos in comments\n mm/rmap.c: fix comment\n sound, ca0106: Fix assignment to \u0027channel\u0027.\n hrtimer: fix a typo in comment\n init/Kconfig: fix typo\n anon_inodes: fix wrong function name in comment\n fix comment typos concerning \"consistent\"\n poll: fix a typo in comment\n ...\n\nFix up trivial conflicts in:\n - drivers/net/wireless/iwlwifi/iwl-core.c (moved to iwl-legacy.c)\n - fs/ext4/ext4.h\n\nAlso fix missed \u0027diabled\u0027 typo in drivers/net/bnx2x/bnx2x.h while at it.\n" }, { "commit": "4b7bd364700d9ac8372eff48832062b936d0793b", "tree": "0dbf78c95456a0b02d07fcd473281f04a87e266d", "parents": [ "c0d8768af260e2cbb4bf659ae6094a262c86b085", "90a8a73c06cc32b609a880d48449d7083327e11a" ], "author": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Wed Dec 22 18:57:02 2010 +0100" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Wed Dec 22 18:57:02 2010 +0100" }, "message": "Merge branch \u0027master\u0027 into for-next\n\nConflicts:\n\tMAINTAINERS\n\tarch/arm/mach-omap2/pm24xx.c\n\tdrivers/scsi/bfa/bfa_fcpim.c\n\nNeeded to update to apply fixes for which the old branch was too\noutdated.\n" }, { "commit": "5f0e385fdafb7d6c8ded6464fa6421c735d96caf", "tree": "f589124e9cf33dc10deb6084456e68245f6dbea5", "parents": [ "ba9cd5d095b42271588c20ccd6ddd561d0e4cc1e" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Nov 30 16:20:18 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:34 2010 -0600" }, "message": "[SCSI] libfc: fix statistics for FCP input/output megabytes\n\nThe statistics for InputMegabytes and OutputMegabytes are\nmisnamed. They\u0027re accumulating bytes, not megabytes.\n\nThe statistic returned via /sys must be in megabytes, however,\nwhich is what the HBA-API wants. The FCP code needs to accumulate\nit in bytes and then divide by 1,000,000 (not 2^20) before it\npresented via sysfs.\n\nThis affects fcoe.ko only, not fnic. The fnic driver\ncorrectly by accumulating bytes and then converts to megabytes.\n\nI checked that libhbalinux is using the /sys file directly without\nconversion.\n\nBTW, qla2xxx does divide by 2^20, which I\u0027m not fixing here.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "b5fe5e953c65cd0ec4e9ffd001072700e5b89317", "tree": "07fb2fcd313e43663de51b354ef7b0f259d71048", "parents": [ "3a91090fe0df10091c5612db8528ee7a822ab83d" ], "author": { "name": "Yi Zou", "email": "yi.zou@intel.com", "time": "Tue Nov 30 16:19:35 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:27 2010 -0600" }, "message": "[SCSI] libfc: fix fc_tm_done not freeing the allocated fsp pkt\n\nFrame should be freed in fc_tm_done, this is an updated patch on the one\ninitially submitted by Hillf Danton.\n\nSigned-off-by: Hillf Danton \u003cdhillf@gmail.com\u003e\nSigned-off-by: Yi Zou \u003cyi.zou@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "3a91090fe0df10091c5612db8528ee7a822ab83d", "tree": "7c9f8a57f2ca9a398faa9319f22e3401c9aa4b0c", "parents": [ "ea3e2e72eeb3e8a9440a5da965914f9b12088626" ], "author": { "name": "Yi Zou", "email": "yi.zou@intel.com", "time": "Tue Nov 30 16:19:30 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:27 2010 -0600" }, "message": "[SCSI] libfc: the timeout for the REC itself is 2 * R_A_TOV_els\n\nThe timeout for the exchange carrying REC itself is 2 * R_A_TOV_els.\n\nSigned-off-by: Yi Zou \u003cyi.zou@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "ea3e2e72eeb3e8a9440a5da965914f9b12088626", "tree": "c997326d053a0247f03fc09b22abe1d78ab3eb56", "parents": [ "d889b30a9196c453120ca54323fe80acb4c27b94" ], "author": { "name": "Yi Zou", "email": "yi.zou@intel.com", "time": "Tue Nov 30 16:19:25 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:26 2010 -0600" }, "message": "[SCSI] libfc: fix exchange being deleted when the abort itself is timed out\n\nShould not continue when the abort itself is being timeout since in that case\nthe exchange will be deleted and relesased. We still want to call the\nassociated response handler to let the layer, e.g., fcp, know the exchange\nitself is being timed out.\n\nSigned-off-by: Yi Zou \u003cyi.zou@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "d889b30a9196c453120ca54323fe80acb4c27b94", "tree": "4625c193d2a7b2ae2c6f23f3cfed0e6ea84a2754", "parents": [ "9b90dc80ba2e566a48585174b1e5ab00e16f0456" ], "author": { "name": "Yi Zou", "email": "yi.zou@intel.com", "time": "Tue Nov 30 16:19:20 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:25 2010 -0600" }, "message": "[SCSI] libfc: do not fc_io_compl on fsp w/o any scsi_cmnd associated\n\nDo not call fc_io_compl() on fsp w/o any scsi_cmnd, e.g., lun reset is built\ninside fc_fcp, not from a scsi command from queuecommnd from scsi-ml, so in\nin case target is buggy that is invalid flags in the FCP_RSP, as we have seen\nin some SAN Blaze target where all bits in flags are 0, we do not want to call\nio_compl on this fsp.\n\n[ Comment block added by Robert Love ]\n\nSigned-off-by: Yi Zou \u003cyi.zou@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "9b90dc80ba2e566a48585174b1e5ab00e16f0456", "tree": "c4d9c836c6afb9bdeeabeaaba6e4a7421f615f8b", "parents": [ "11aa99001afdbe5fe152e833aa1fea82b85dbeda" ], "author": { "name": "Yi Zou", "email": "yi.zou@intel.com", "time": "Tue Nov 30 16:19:15 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:25 2010 -0600" }, "message": "[SCSI] libfc: add print of exchange id for debugging fc_fcp\n\nThis is very helpful to match up the corresponding exchange to the actual I/O\ndescribed by the fsp, particularly when you do a side-by-side comparison of\nthe syslog with your trace.\n\nSigned-off-by: Yi Zou \u003cyi.zou@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "0e9e3d3b155c35d5750805c2b8bb6d5b6e6a3bfb", "tree": "c47b35dee5b002531d40a9f5126e343906f4bdfe", "parents": [ "72e0daad555bc0ca2e7abd68593087d098d866a8" ], "author": { "name": "Hillf Danton", "email": "dhillf@gmail.com", "time": "Tue Nov 30 16:19:04 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:24 2010 -0600" }, "message": "[SCSI] libfc: fix memory leakage in remote port\n\nThere seems rdata should get put before return.\n\nSigned-off-by: Hillf Danton \u003cdhillf@gmail.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "72e0daad555bc0ca2e7abd68593087d098d866a8", "tree": "838e338bc811a418579b4138ed7f683e73da77c2", "parents": [ "2d6dfb005e24d7e3404f4c0d333a94b050059173" ], "author": { "name": "Hillf Danton", "email": "dhillf@gmail.com", "time": "Tue Nov 30 16:18:59 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:23 2010 -0600" }, "message": "[SCSI] libfc: fix memory leakage in local port\n\nThere seems info should get freed when error encountered.\n\nSigned-off-by: Hillf Danton \u003cdhillf@gmail.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "2d6dfb005e24d7e3404f4c0d333a94b050059173", "tree": "0695eb258a1cb9860a5dccf9a21e899025e843c9", "parents": [ "05fee645e96e732a79ad083cab8ddd4efd108e2c" ], "author": { "name": "Hillf Danton", "email": "dhillf@gmail.com", "time": "Tue Nov 30 16:18:54 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:23 2010 -0600" }, "message": "[SCSI] libfc: fix memory leakage in local port\n\nThere seems info should get freed when error encountered.\n\nSigned-off-by: Hillf Danton \u003cdhillf@gmail.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "05fee645e96e732a79ad083cab8ddd4efd108e2c", "tree": "597d8d29d6f53261ebd46b3a925187075482b426", "parents": [ "e0883a3c3e7766b390971a49bf728004816c9520" ], "author": { "name": "john fastabend", "email": "john.r.fastabend@intel.com", "time": "Tue Nov 30 16:18:49 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:22 2010 -0600" }, "message": "[SCSI] libfc: remove tgt_flags from fc_fcp_pkt struct\n\nWe can easily remove the tgt_flags from fc_fcp_pkt struct\nand use rpriv-\u003etgt_flags directly where needed.\n\nSigned-off-by: John Fastabend \u003cjohn.r.fastabend@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "e0883a3c3e7766b390971a49bf728004816c9520", "tree": "503e3ad2aa159def3f97e8001338bfeab4649b2f", "parents": [ "ac17ea8d7d45d0495316edff13faa0dfd6bb2225" ], "author": { "name": "john fastabend", "email": "john.r.fastabend@intel.com", "time": "Tue Nov 30 16:18:44 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:22 2010 -0600" }, "message": "[SCSI] libfc: use rport timeout values for fcp recovery\n\nUse the rport value for rec_tov for timeout values when\nsending fcp commands. Currently, defaults are being used\nwhich may or may not match the advertised values.\n\nThe default may cause i/o to timeout on networks that\nset this value larger then the default value. To make\nthe timeout more configurable in the non-REC mode we\nremove the FC_SCSI_ER_TIMEOUT completely allowing the\nscsi-ml to do the timeout. This removes an unneeded\ntimer and allows the i/o timeout to be configured\nusing the scsi-ml knobs.\n\nSigned-off-by: John Fastabend \u003cjohn.r.fastabend@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "ac17ea8d7d45d0495316edff13faa0dfd6bb2225", "tree": "6c8d0935d8b59ed3205fdfe9d074ab0b0a978fa2", "parents": [ "e90ff5ef0aab1d40f0e92a44d66f8d45a20d8c95" ], "author": { "name": "john fastabend", "email": "john.r.fastabend@intel.com", "time": "Tue Nov 30 16:18:39 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:21 2010 -0600" }, "message": "[SCSI] libfc: incorrect scsi host byte codes returned to scsi-ml\n\nThe fcp packet recovery handler fc_fcp_recover() is called\nwhen errors occurr in a fcp session. Currently it is\ngenerically setting the status code to FC_CMD_RECOVERY for\nall error types. This results in DID_BUS_BUSY errors\nbeing returned to the scsi-ml.\n\nDID_BUS_BUSY errors indicate \"BUS stayed busy through time\nout period\" according to scsi.h. Many of the error reported\nby fc_rcp_recovery() are pkt errors. Here we update\nfc_fcp_recovery to use better host byte codes.\n\nWith certain FAST FAIL flags set DID_BUS_BUSY and DID_ERROR\nwill have different behaviors this was causing dm multipath\nto fail quickly in some cases where a retry would be a\nbetter action.\n\nSigned-off-by: John Fastabend \u003cjohn.r.fastabend@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "e90ff5ef0aab1d40f0e92a44d66f8d45a20d8c95", "tree": "98ba8bd84832b20a52a9481862b3e9bd0c04ca8f", "parents": [ "530994d69e5b6b4eca2db4a21b6d945d13646053" ], "author": { "name": "Hillf Danton", "email": "dhillf@gmail.com", "time": "Tue Nov 30 16:18:33 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:21 2010 -0600" }, "message": "[SCSI] libfc: fix stats computation in fc_queuecommand()\n\nThere seems accumulation needed.\n\nSigned-off-by: Hillf Danton \u003cdhillf@gmail.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "530994d69e5b6b4eca2db4a21b6d945d13646053", "tree": "cbac6fca2e6996e97072524f1a9f18e0c53ddf44", "parents": [ "3c2c3bf23cbef8eed6cf815715d0bece5cb7b5ec" ], "author": { "name": "Hillf Danton", "email": "dhillf@gmail.com", "time": "Tue Nov 30 16:18:28 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:20 2010 -0600" }, "message": "[SCSI] libfc: fix mem leak in fc_seq_assign()\n\nThere is a typo cleaned, which triggers memory leakage.\n\nSigned-off-by: Hillf Danton \u003cdhillf@gmail.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "3c2c3bf23cbef8eed6cf815715d0bece5cb7b5ec", "tree": "3cca737e6945e452aeb8888c3aa36939d76aa338", "parents": [ "2034c19ce8f8503aa14cb1e763fbfe60316aaa8e" ], "author": { "name": "Robert Love", "email": "robert.w.love@intel.com", "time": "Tue Nov 30 16:18:23 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:20 2010 -0600" }, "message": "[SCSI] libfc: Fix incorrect locking and unlocking in FCP\n\nThe error handler grabs the si-\u003escsi_queue_lock, but\nin the case where the fsp pointer is NULL it releases\nthe scsi_host lock. This can lead to a variety of\nsystem hangs depending on which is used first- the\nscsi_host lock or the scsi_queue_lock.\n\nThis patch simply unlocks the correct lock when fcp\nis NULL.\n\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nTested-by: Ross Brattain \u003cross.b.brattain@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "2034c19ce8f8503aa14cb1e763fbfe60316aaa8e", "tree": "a041e219fe6342d6268d71581d94c02073f681f6", "parents": [ "8236554a27af870ecd1cd588d9558ccdc212037b" ], "author": { "name": "Hillf Danton", "email": "dhillf@gmail.com", "time": "Tue Nov 30 16:18:17 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:19 2010 -0600" }, "message": "[SCSI] libfc: tune fc_exch_em_alloc() to be O(2)\n\nFor allocating new exch from pool, scanning for free slot in exch\narray fluctuates when exch pool is close to exhaustion.\n\nThe fluctuation is smoothed, and the scan looks to be O(2).\n\nSigned-off-by: Hillf Danton \u003cdhillf@gmail.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "8236554a27af870ecd1cd588d9558ccdc212037b", "tree": "ed2ae4cd11eca91313721684c968e263e66d509a", "parents": [ "80e736f8a37bebeb5bff18f2aec31caab4104b8b" ], "author": { "name": "Hillf Danton", "email": "dhillf@gmail.com", "time": "Tue Nov 30 16:18:12 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:19 2010 -0600" }, "message": "[SCSI] libfc: fix mem leak in fc_exch_recv_seq_resp()\n\nThere seems that ep should get released, or it will no longer get freed.\n\nSigned-off-by: Hillf Danton \u003cdhillf@gmail.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "12137f5c28284cc51b5f50932c8d02a5823fcd3c", "tree": "18ebbcf55f9169ac9fbafcb6df94a184af016555", "parents": [ "50444a340028119ce5ba45d60b4cf44e3e6e1b32" ], "author": { "name": "Hillf Danton", "email": "dhillf@gmail.com", "time": "Tue Nov 30 16:18:01 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Dec 21 12:24:18 2010 -0600" }, "message": "[SCSI] libfc: remove define of fc_seq_exch in fc_exch.c\n\nThe define for fc_seq_exch is unnecessary, since it also appears in scsi/libfc.h\n\nSigned-off-by: Hillf Danton \u003cdhillf@gmail.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "f281233d3eba15fb225d21ae2e228fd4553d824a", "tree": "51134454ba8acb558735f90be5540f7d756483e3", "parents": [ "bdbd01ac444bffb3c9aefed3059d12554059b320" ], "author": { "name": "Jeff Garzik", "email": "jeff@garzik.org", "time": "Tue Nov 16 02:10:29 2010 -0500" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Nov 16 13:33:23 2010 -0800" }, "message": "SCSI host lock push-down\n\nMove the mid-layer\u0027s -\u003equeuecommand() invocation from being locked\nwith the host lock to being unlocked to facilitate speeding up the\ncritical path for drivers who don\u0027t need this lock taken anyway.\n\nThe patch below presents a simple SCSI host lock push-down as an\nequivalent transformation. No locking or other behavior should change\nwith this patch. All existing bugs and locking orders are preserved.\n\nAdditionally, add one parameter to queuecommand,\n\tstruct Scsi_Host *\nand remove one parameter from queuecommand,\n\tvoid (*done)(struct scsi_cmnd *)\n\nScsi_Host* is a convenient pointer that most host drivers need anyway,\nand \u0027done\u0027 is redundant to struct scsi_cmnd-\u003escsi_done.\n\nMinimal code disturbance was attempted with this change. Most drivers\nneeded only two one-line modifications for their host lock push-down.\n\nSigned-off-by: Jeff Garzik \u003cjgarzik@redhat.com\u003e\nAcked-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b595076a180a56d1bb170e6eceda6eb9d76f4cd3", "tree": "bc01ec7283808013e0b8ce7713fd6fc40f810429", "parents": [ "6aaccece1c483f189f76f1282b3984ff4c7ecb0a" ], "author": { "name": "Uwe Kleine-König", "email": "u.kleine-koenig@pengutronix.de", "time": "Mon Nov 01 15:38:34 2010 -0400" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Mon Nov 01 15:38:34 2010 -0400" }, "message": "tree-wide: fix comment/printk typos\n\n\"gadget\", \"through\", \"command\", \"maintain\", \"maintain\", \"controller\", \"address\",\n\"between\", \"initiali[zs]e\", \"instead\", \"function\", \"select\", \"already\",\n\"equal\", \"access\", \"management\", \"hierarchy\", \"registration\", \"interest\",\n\"relative\", \"memory\", \"offset\", \"already\",\n\nSigned-off-by: Uwe Kleine-König \u003cu.kleine-koenig@pengutronix.de\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "c531b9b49b146e1535dbed006d15e58f4f528f7e", "tree": "85da9abe1a8b169f578312d8904a8075b91eebc5", "parents": [ "8b7ac2bb07bbadb0636f21f51564e6d363bb6d20" ], "author": { "name": "Bhanu Prakash Gollapudi", "email": "bprakash@broadcom.com", "time": "Fri Oct 08 17:12:36 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Mon Oct 25 15:11:37 2010 -0500" }, "message": "[SCSI] libfc: Do not let disc work cancel itself\n\nWhen number of NPIV ports created are greater than the xids\nallocated per pool -- for eg., creating 255 NPIV ports on a\nsystem with nr_cpu_ids of 32, with each pool containing 128\nxids -- and then generating a link event - for eg.,\nshutdown/no shutdown -- on the switch port causes the hang\nwith the following stack trace.\n\nCall Trace:\nschedule_timeout+0x19d/0x230\nwait_for_common+0xc0/0x170\n__cancel_work_timer+0xcf/0x1b0\nfc_disc_stop+0x16/0x30 [libfc]\nfc_lport_reset_locked+0x47/0x90 [libfc]\nfc_lport_enter_reset+0x67/0xe0 [libfc]\nfc_lport_disc_callback+0xbc/0xe0 [libfc]\nfc_disc_done+0xa8/0xf0 [libfc]\nfc_disc_timeout+0x29/0x40 [libfc]\nrun_workqueue+0xb8/0x140\nworker_thread+0x96/0x110\nkthread+0x96/0xa0\nchild_rip+0xa/0x20\n\nFix is to not cancel the disc_work if discovery is already\nstopped, thus allowing lport state machine to restart and try\ndiscovery again.\n\nSigned-off-by: Bhanu Prakash Gollapudi \u003cbprakash@broadcom.com\u003e\nAcked-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "8b7ac2bb07bbadb0636f21f51564e6d363bb6d20", "tree": "788c08b32a719f6c473482e7897ec5835dd9e03e", "parents": [ "3067817a5d3ef99c5b1a4e4ca8c5b15bc7fc468d" ], "author": { "name": "Vasu Dev", "email": "vasu.dev@intel.com", "time": "Fri Oct 08 17:12:31 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Mon Oct 25 15:11:35 2010 -0500" }, "message": "[SCSI] libfc: possible race could panic system due to NULL fsp-\u003ecmd\n\nIt is unlikely but in case if it hits then it would cause panic\ndue to null cmd ptr, so far only one instance seen recently with\nESX though this was introduced long ago with this commit:-\n\ncommit c1ecb90a66c5afc7cc5c9349f9c3714eef4a5cfb\nAuthor: Chris Leech \u003cchristopher.leech@intel.com\u003e\nDate: Thu Dec 10 09:59:26 2009 -0800\n[SCSI] libfc: reduce hold time on SCSI host lock\n\nCurrently fsp-\u003ecmd is set to NULL w/o scsi_queue_lock before\ndequeuing from scsi_pkt_queue and that could cause NULL\nfsp-\u003ecmd in fc_fcp_cleanup_each_cmd for cmd completing\nwith fsp-\u003ecmd \u003d NULL after fc_fcp_cleanup_each_cmd taken\nreference. No need to set fsp-\u003ecmd to NULL as this is also\nprotected by fc_fcp_lock_pkt(), for above race the\nfc_fcp_lock_pkt() in fc_fcp_cleanup_each_cmd() will fail\nas that cmd is already done.\n\nMike mentioned same issue at\nhttp://www.open-fcoe.org/pipermail/devel/2010-September/010533.html\n\nSimilarly moved sc_cmd-\u003eSCp.ptr \u003d NULL under scsi_queue_lock so\nthat scsi abort error handler won\u0027t abort on completed cmds.\n\nSigned-off-by: Vasu Dev \u003cvasu.dev@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "60a3c4dfb7830845a97a20e73b7d938dc2fde6c1", "tree": "589a230cf3fad5a3aae823f7087db35bb9f6297d", "parents": [ "75eee7252466342e0dfa6675106bcd3955090f67" ], "author": { "name": "Vasu Dev", "email": "vasu.dev@intel.com", "time": "Fri Oct 08 17:12:20 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Mon Oct 25 15:11:32 2010 -0500" }, "message": "[SCSI] libfc: adds flogi retry in case DID is zero in RJT\n\nSometimes switch in NPV mode rejects flogi request with DID\nzero and in that case flogi is not tried again and port\nremains offline, so this patch validates DID for non zero\nalong with only ACC response to allow flogi retry\nfor RJT with DID\u003d0 also succeed FLOGI in next try.\n\nSigned-off-by: Vasu Dev \u003cvasu.dev@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "75eee7252466342e0dfa6675106bcd3955090f67", "tree": "425b0946272f0c5207ad8b02ceba17b942ea9068", "parents": [ "73b4376477672a4336cba5f26ede2e277511ce70" ], "author": { "name": "Vasu Dev", "email": "vasu.dev@intel.com", "time": "Fri Oct 08 17:12:15 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Mon Oct 25 15:11:31 2010 -0500" }, "message": "[SCSI] libfc: use DID_TRANSPORT_DISRUPTED while lport not ready\n\nThis is per Mile Christie feedback since in this case IO\ncould get retried for tape devices and therefore DID_REQUEUE\ncannot be used, more details in this thread.\n\nhttp://marc.info/?l\u003dlinux-scsi\u0026m\u003d127970522630136\u0026w\u003d2\n\nSigned-off-by: Vasu Dev \u003cvasu.dev@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "73b4376477672a4336cba5f26ede2e277511ce70", "tree": "05aa0d3783ec8e56630ee739b85da9ef5d1cb1f7", "parents": [ "f63ae56e4e97fb12053590e41a4fa59e7daa74a4" ], "author": { "name": "Mike Christie", "email": "michaelc@cs.wisc.edu", "time": "Fri Oct 08 17:12:10 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Mon Oct 25 15:11:29 2010 -0500" }, "message": "[SCSI] libfc: fix setting of rport dev loss\n\nThere does not seem to be a reason why libfc adds a 5\nsecond delay to the user requested value for the dev loss\ntmo. There also does not seem to be a reason to allow\nsetting it to 0 (or really close).\n\nThis patch removes the extra 5 sec delay, and for 0 it\nsets it to 1 like other fc drivers. We should actually\nbe able to set it to 0 since the queue_delayed_work API\nwill just call queue_work, but other drivers set it to 1 in\nthat case.\n\nSigned-off-by: Mike Christie \u003cmichaelc@cs.wisc.edu\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "be948fc30dabc347e4fba4daf4da9fd83d2abf49", "tree": "38324d0bb068bc1e21f8972643290f9af4317fe5", "parents": [ "26845f585fad66dc23d87dad89d403cd64b48780" ], "author": { "name": "Mike Christie", "email": "michaelc@cs.wisc.edu", "time": "Mon Aug 02 16:02:24 2010 -0500" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Fri Aug 06 11:00:26 2010 -0500" }, "message": "[SCSI] libfc: call fc_remote_port_chkready under the host lock.\n\nThe rport port state and flags are set under the host lock,\nso this patch calls fc_remote_port_chkready with the host lock\nheld like is also done in the other fc drivers.\n\nSigned-off-by: Mike Christie \u003cmichaelc@cs.wisc.edu\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "3cfc2c42c1cbc8e238bb9c0612c0df4565e3a8b4", "tree": "5adc1ff2eaf64d450bf28bb6b2ce890db2567288", "parents": [ "5cf65713f87775c548e3eb48dbafa32e12f28000", "0ea6e61122196509af82cc4f36cbdaacbefb8227" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Aug 04 15:31:02 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Aug 04 15:31:02 2010 -0700" }, "message": "Merge branch \u0027for-next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial\n\n* \u0027for-next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (48 commits)\n Documentation: update broken web addresses.\n fix comment typo \"choosed\" -\u003e \"chosen\"\n hostap:hostap_hw.c Fix typo in comment\n Fix spelling contorller -\u003e controller in comments\n Kconfig.debug: FAIL_IO_TIMEOUT: typo Faul -\u003e Fault\n fs/Kconfig: Fix typo Userpace -\u003e Userspace\n Removing dead MACH_U300_BS26\n drivers/infiniband: Remove unnecessary casts of private_data\n fs/ocfs2: Remove unnecessary casts of private_data\n libfc: use ARRAY_SIZE\n scsi: bfa: use ARRAY_SIZE\n drm: i915: use ARRAY_SIZE\n drm: drm_edid: use ARRAY_SIZE\n synclink: use ARRAY_SIZE\n block: cciss: use ARRAY_SIZE\n comment typo fixes: charater \u003d\u003e character\n fix comment typos concerning \"challenge\"\n arm: plat-spear: fix typo in kerneldoc\n reiserfs: typo comment fix\n update email address\n ...\n" }, { "commit": "7f985231d274ef3e6e4d56a2939a534906299021", "tree": "eddb8ddca9d31d9111b2895cd768171b08b1f619", "parents": [ "cf4aebcafb44a8810af10006dd4a5fcfb07bb810" ], "author": { "name": "Bhanu Prakash Gollapudi", "email": "bprakash@broadcom.com", "time": "Tue Jul 20 15:21:27 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:06:04 2010 -0500" }, "message": "[SCSI] libfc: Add retry logic to lport state machine when receiving LS_RJT\n\nCall fc_lport_error to retry upto max retry count when\nFLOGI/SCR/NS gets rejected.\n\nSigned-off-by: Bhanu Prakash Gollapudi \u003cbprakash@broadcom.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "922611569572d3c1aa0ed6491d21583fb3fcca22", "tree": "f7cb42bf5519d1c42853808f2f784188afe1bc2e", "parents": [ "239e81048b7dcd27448db40c845f88ac7c68424e" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Jul 20 15:21:12 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:06:02 2010 -0500" }, "message": "[SCSI] libfc: don\u0027t require a local exchange for incoming requests\n\nIncoming requests shouldn\u0027t require a local exchange if we\u0027re\njust going to reply with one or two frames and don\u0027t expect\nanything further. Don\u0027t allocate exchanges for such requests\nuntil requested by the upper-layer protocol.\n\nThe sequence is always NULL for new requests, so remove\nthat as an argument to request handlers.\n\nAlso change the first argument to lport-\u003ett.seq_els_rsp_send\nfrom the sequence pointer to the received frame pointer, to\nsupply the exchange IDs and destination ID info.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "239e81048b7dcd27448db40c845f88ac7c68424e", "tree": "c6d316b365e593a274511fca9562c87db2252a7e", "parents": [ "24f089e2f2c800f88039e9d536d558ec6e349fad" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Jul 20 15:21:07 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:06:01 2010 -0500" }, "message": "[SCSI] libfc: add interface to allocate a sequence for incoming requests\n\nFor incoming ELS and FCP requests, we often don\u0027t require an\nexchange and sequence, however, sometimes we do. For those cases,\n(primarily FCP requests for targets) add a function to set up\nthe exchange and sequence.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "24f089e2f2c800f88039e9d536d558ec6e349fad", "tree": "59cf263f112e176015a3a37c3928cc3d2a4dfcb5", "parents": [ "251748a99e631a2c46edcf9e519cfc60fae8153d" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Jul 20 15:21:01 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:06:00 2010 -0500" }, "message": "[SCSI] libfc: add fc_fill_reply_hdr() and fc_fill_hdr()\n\nAdd functions to fill in an FC header given a request header.\nThese reduces code lines in fc_lport and fc_rport and works\nwithout an exchange/sequence assigned.\n\nfc_fill_reply_hdr() fills a header for a final reply frame.\n\nfc_fill_hdr() which is similar but allows specifying the\nf_ctl parameter.\n\nAdd defines for F_CTL values FC_FCTL_REQ and FC_FCTL_RESP.\nThese can be used for most request and response sequences.\n\nv2 of patch adds a line to copy the frame encapsulation\ninfo from the received frame.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "251748a99e631a2c46edcf9e519cfc60fae8153d", "tree": "6255e513473fffde4691f761c53e82440d763d18", "parents": [ "079ecd8cfe95dfd28b74f3a00d66fdbcdfc8c611" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Jul 20 15:20:56 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:05:59 2010 -0500" }, "message": "[SCSI] libfc: add fc_frame_sid() and fc_frame_did() functions\n\nTo pave the way for eliminating exchanges from incoming requests,\nadd simple inline fc_frame_sid() and fc_frame_did() functions\nwhich get the FC_IDs from the frame header. This can be almost\nas efficient as getting them from the sequence/exchange.\n\nMove ntohll, htonll, ntoh24 and hton24 to \u003cscsi/fc_frame.h\u003e\nsince we need them there and that\u0027s included by \u003cscsi/libfc.h\u003e\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "079ecd8cfe95dfd28b74f3a00d66fdbcdfc8c611", "tree": "474d1f3851f6e33f04843f91f6ed1d7a3ca41765", "parents": [ "1dd454d9e5205f9a61d51fb97159afeffa0a506c" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Jul 20 15:20:51 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:05:58 2010 -0500" }, "message": "[SCSI] libfc: eliminate rport LOGO state\n\nThe LOGO state hasn\u0027t been used in a while, except in a brief\ntransition to DELETE state while holding the rport mutex.\nAll port LOGO responses have been ignored as well as any timeout\nif we don\u0027t get a response.\n\nSo this patch just removes LOGO state and simplifies the response handler.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "f60e12e9c778c8256a646f80603d1b88ba5ce891", "tree": "732e918fc85cc441cd539be5e389e0dfd29a2199", "parents": [ "a7b12a279faaad26837276065104a1f9cf60e962" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Jul 20 15:20:14 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:05:54 2010 -0500" }, "message": "[SCSI] libfc: track FIP exchanges\n\nWhen an exchange is received with a FIP encapsulation, we need\nto know that the response must be sent via FIP and what the original\nELS opcode was. This becomes important for VN2VN mode, where we may\nreceive FLOGI or LOGO from several peer VN_ports, and the LS_ACC or\nLS_RJT must be sent FIP-encapsulated with the correct sub-type.\n\nAdd a field to the struct fc_frame, fr_encaps, to indicate the\nencapsulation values. That term is chosen to be neutral and\nLLD-agnostic in case non-FCoE/FIP LLDs might find it useful.\n\nThe frame fr_encaps is transferred from the ingress frame to the\nexchange by fc_exch_recv_req(), and back to the outgoing frame\nby fc_seq_send().\n\nThis is taking the last byte in the skb-\u003ecb array. If needed,\nwe could combine the info in sof, eof, flags, and encaps\ntogether into one field, but it\u0027d be better to do that if\nand when its needed.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "a7b12a279faaad26837276065104a1f9cf60e962", "tree": "3537d1a5b984f4c9f89b7c549df2afcafce8c940", "parents": [ "3726f3584e113697b68d3d4ff1ecf1042a06f800" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Jul 20 15:20:08 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:05:53 2010 -0500" }, "message": "[SCSI] libfc: add FLOGI state to rport for VN2VN\n\nThe FIP proposal for VN_port to VN_port point-to-multipoint\noperation requires a FLOGI be sent to each remote port.\nThe FLOGI is sent with the assigned S_ID and D_IDs of the\nlocal and remote ports. This and the response get\nFIP-encapsulated for Ethernet.\n\nAdd FLOGI state to the remote port state machine.\nThis will be skipped if not in point-to-multipoint mode.\n\nTo reduce a little duplication between PLOGI and FLOGI\nresponse handling, added fc_rport_login_complete(), which\nhandles the parameters for the rdata struct.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "3726f3584e113697b68d3d4ff1ecf1042a06f800", "tree": "2e452d689739c4c2516f50d018f8587bf7d58e41", "parents": [ "3d902ac09a2812b359edf633425d1327a18399e9" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Jul 20 15:20:03 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:05:53 2010 -0500" }, "message": "[SCSI] libfc: Add local port point-to-multipoint flag\n\nFor VN_port to VN_port mode, the transport sets the port_id and\nthere\u0027s no lport FLOGI. This is similar to FC loop mode.\n\nAdd a point_to_multipoint flag that indicates the local port is in\npoint-to-multipoint mode. This skips FLOGI and discovery.\nIt also skips resetting the port_id on resets other than link down.\n\nAdd function fc_lport_set_local_id() that sets the local port_id.\nThis is called by libfcoe on behalf of the low-level driver\nto set the port_id when the link comes up.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "0685230c59b5482e04ab50e7afc51119ceaba651", "tree": "64fbf16efb314efc5cba7e313342f0d57ce81e95", "parents": [ "fdb068c6cd6e30d43664f856d3530715a5742713" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Jul 20 15:19:53 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:05:52 2010 -0500" }, "message": "[SCSI] libfc: add discovery-private pointer for LLD\n\nFor VN_port to VN_port mode, FIP will do discovery and needs a\nway to find its state from the local port or discovery structure.\nIt seems that any other LLD that implements its own discovery\nwould also need something like this.\n\nReplace disc-\u003elport with disc-\u003epriv, and use container_of to\nfind the lport. We could use disc-\u003epriv for that, but\ncontainer_of is smaller and faster.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "f90377abcab2e305450ee76a0f9042907560c5d8", "tree": "6ed2f707f8c15162bcca4a7f44a3a97ba09172ad", "parents": [ "42e9041467cf5fd33501b91b27e26807c259c896" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Jul 20 15:19:42 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:05:49 2010 -0500" }, "message": "[SCSI] libfc: provide space for LLD after remote port structure\n\nAdd pre-zeroed space after the allocation for fc_rport_priv\nfor use by the lower-level driver.\n\nThis is primarily for VN2VN FIP mode, but could be used in\nother ways someday.\n\nThe space required is specified in lport-\u003erport_priv_size.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "42e9041467cf5fd33501b91b27e26807c259c896", "tree": "41a335a931e151f3fa00f384b5d1fb024421b7d2", "parents": [ "519e5135e2537c9dbc1cbcc0891b0a936ff5dcd2" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Jul 20 15:19:37 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:05:48 2010 -0500" }, "message": "[SCSI] libfc: convert rport lookup to be RCU safe\n\nTo allow LLD to do lookups on rports without grabbing a mutex,\nmake them RCU-safe. The caller of lport-\u003ett.rport_lookup will\nhave the choice of holding disc_mutex or the rcu_read_lock().\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "e0d93c5bc47ae270ea38192c9a49f660e0406060", "tree": "a9afbd6d43a53f3daef25885026984924888d740", "parents": [ "d058fd31c7f44960b00566bda39c85377f461a7b" ], "author": { "name": "Vasu Dev", "email": "vasu.dev@intel.com", "time": "Tue Jul 20 15:19:20 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:05:45 2010 -0500" }, "message": "[SCSI] libfc: IO errors on link down due to cable unplug\n\nIn this case, sync IO fails with EIO(5) errors as:-\n\n\"Thread:1 System call error:5 - Input/output error (::pwrite() failed)\".\n\nThis is due to IO time out while libfc doing link down processing\nto block all rports and if timed out IO was at last retry\nattempt then it fails to user with EIO error followed by\nthese log messages.\n\n[77848.612169] host2: rport bf0015: Delete port\n[77848.612221] host2: rport e10aef: work delete\n[77848.612232] host2: rport e10002: work event 3\n[77848.612422] sd 2:0:1:1: [sdi] Unhandled error code\n[77848.612426] sd 2:0:1:1: [sdi] Result: hostbyte\u003dDID_ERROR\ndriverbyte\u003dDRIVER_OK\n[77848.612431] sd 2:0:1:1: [sdi] CDB: Write(10): 2a 00 00 00 11 20 00 00 20 00\n[77848.612445] end_request: I/O error, dev sdi, sector 4384\n[77848.612553] sd 2:0:1:2: [sdj] Unhandled error code\n\nTo fix these EIO errors, such timed out incomplete IOs needs\nto be re-queued without counting retry attempt and this patch\ndoes that using DID_REQUEUE scsi code.\n\nSigned-off-by: Vasu Dev \u003cvasu.dev@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "ba402804ac2447ad41f4919603bf3e6f6db63110", "tree": "86ae6efbc2456403a816e33594d6d849cbd854b7", "parents": [ "2cf75f1c8aa4cab3ace57f9159f1dc85cba69d38" ], "author": { "name": "Yi Zou", "email": "yi.zou@intel.com", "time": "Tue Jul 20 15:19:10 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Jul 28 09:05:44 2010 -0500" }, "message": "[SCSI] libfc: fix slowpath error from WARN_ON in fc_fcp_send_data\n\nThis is exposed by a mpio test using EMC CLARiiON targets when LUN\ntresspassing happens, the burst length from the XFER_READY for the\nMODE SELECT(10) is 19 bytes, much smaller than FC_MIN_MAX_PAYLOAD as\n256 bytes. This patch removes the related two WARN_ON()s.\n\nSigned-off-by: Yi Zou \u003cyi.zou@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "f034260db330bb3ffc815fcb682b1c84aca09591", "tree": "4570860e30b7dfcaedceff905eeb1ab244b1a504", "parents": [ "4b2164d4d212e437c9f080023a67f8f9356d2c4c" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Jun 11 16:44:57 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Jul 27 12:01:53 2010 -0500" }, "message": "[SCSI] libfc: fix indefinite rport restart\n\nRemote ports were restarting indefinitely after getting\nrejects in PRLI.\n\nFix by adding a counter of restarts and limiting that with\nthe port login retry limit as well.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "4b2164d4d212e437c9f080023a67f8f9356d2c4c", "tree": "aaa86c0e2b1532b87780f568b35921e56342557d", "parents": [ "0db6f4353d68c0108b5fe0bad8259de0197589c6" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Jun 11 16:44:51 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Jul 27 12:01:52 2010 -0500" }, "message": "[SCSI] libfc: Fix remote port restart problem\n\nThis patch somewhat combines two fixes to remote port handing in libfc.\n\nThe first problem was that rport work could be queued on a deleted\nand freed rport. This is handled by not resetting rdata-\u003eevent\nton NONE if the rdata is about to be deleted.\n\nHowever, that fix led to the second problem, described by\nBhanu Gollapudi, as follows:\n\u003e Here is the sequence of events. T1 is first LOGO receive thread, T2 is\n\u003e fc_rport_work() scheduled by T1 and T3 is second LOGO receive thread and\n\u003e T4 is fc_rport_work scheduled by T3.\n\u003e\n\u003e 1. (T1)Received 1st LOGO in state Ready\n\u003e 2. (T1)Delete port \u0026 enter to RESTART state.\n\u003e 3. (T1)schdule event_work, since event is RPORT_EV_NONE.\n\u003e 4. (T1)set event \u003d RPORT_EV_LOGO\n\u003e 5. (T1)Enter RESTART state as disc_id is set.\n\u003e 6. (T2)remember to PLOGI, and set event \u003d RPORT_EV_NONE\n\u003e 6. (T3)Received 2nd LOGO\n\u003e 7. (T3)Delete Port \u0026 enter to RESTART state.\n\u003e 8. (T3)schedule event_work, since event is RPORT_EV_NONE.\n\u003e 9. (T3)Enter RESTART state as disc_id is set.\n\u003e 9. (T3)set event \u003d RPORT_EV_LOGO\n\u003e 10.(T2)work restart, enter PLOGI state and issues PLOGI\n\u003e 11.(T4)Since state is not RESTART anymore, restart is not set, and the\n\u003e event is not reset to RPORT_EV_NONE. (current event is RPORT_EV_LOGO).\n\u003e 12. Now, PLOGI succeeds and fc_rport_enter_ready() will not schedule\n\u003e event_work, and hence the rport will never be created, eventually losing\n\u003e the target after dev_loss_tmo.\n\nSo, the problem here is that we were tracking the desire for\nthe rport be restarted by state RESTART, which was otherwise\nequivalent to DELETE. A contributing factor is that we dropped\nthe lock between steps 6 and 10 in thread T2, which allows the\nstate to change, and we didn\u0027t completely re-evaluate then.\n\nThis is hopefully corrected by the following minor redesign:\n\nSimplify the rport restart logic by making the decision to\nrestart after deleting the transport rport. That decision\nis based on a new STARTED flag that indicates fc_rport_login()\nhas been called and fc_rport_logoff() has not been called\nsince then. This replaces the need for the RESTART state.\n\nOnly restart if the rdata is still in DELETED state\nand only if it still has the STARTED flag set.\n\nAlso now, since we clear the event code much later in the\nwork thread, allow for the possibility that the rport may\nhave become READY again via incoming PLOGI, and if so,\nqueue another event to handle that.\n\nIn the problem scenario, the second LOGO received will\ncause the LOGO event to occur again.\n\nReported-by: Bhanu Gollapudi \u003cbprakash@broadcom.com\u003e\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "1c4bfe6305215f09f3e80a14a824e4ae45b2c7ed", "tree": "ae1d6ce1cdf0f23938cef84507d411de1ea9b2d2", "parents": [ "be61331d902e63011138723da3f737d34506f797" ], "author": { "name": "Yi Zou", "email": "yi.zou@intel.com", "time": "Fri Jun 11 16:44:41 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Jul 27 12:01:51 2010 -0500" }, "message": "[SCSI] libfc: lport state is enum not bit mask\n\nlport state is enum not bit mask.\n\nSigned-off-by: Yi Zou \u003cyi.zou@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "f8fc6c2c99b8085368119d6cf39b997255052826", "tree": "d1ba9ea7fc49fd8c96143cdcf81a8a9892716ee5", "parents": [ "5d4a2e29fba5b2bef95b96a46b338ec4d76fa4fd" ], "author": { "name": "Bhanu Prakash Gollapudi", "email": "bprakash@broadcom.com", "time": "Fri Jun 11 16:44:04 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Jul 27 12:01:46 2010 -0500" }, "message": "[SCSI] libfc: Handle unsolicited PRLO request\n\nResubmitting after incorporating Joe\u0027s review comment.\n\nUnsolicited PRLO request is now handled by sending LS_ACC,\nand then relogin to the remote port if an N-port login\nsession exists for that remote port.\n\nNote that this patch should be applied on top of Joe Eykholt\u0027s\n\"Fix remote port restart problem\" patch.\n\nSigned-off-by: Bhanu Prakash Gollapudi \u003cbprakash@broadcom.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "618461c02b00a658ec8aa07d409cd496a7e254e2", "tree": "d4e3baa7fee94a79c8882c85f93422a45a9be5a2", "parents": [ "292e40b956982601dfc61fe8f0470eb18a616d7e" ], "author": { "name": "Bhanu Prakash Gollapudi", "email": "bprakash@broadcom.com", "time": "Fri Jun 11 16:43:54 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Jul 27 12:01:45 2010 -0500" }, "message": "[SCSI] libfc: Honor LS_ACC response codes for PRLI\n\nAs per FC-LS Rev 1.62 table 46, response codes are handled as follows:\n\n1. If the Req executed is true, PRLI is accepted.\n2. If Req executed is not set, if resp code is 5,\n PRLI is not retried and port is logged out.\n3. If resp code is anything apart from 1 or 5, PRLI is retired\n upto max retry count.\n\nSigned-off-by: Bhanu Prakash Gollapudi \u003cbprakash@broadcom.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "292e40b956982601dfc61fe8f0470eb18a616d7e", "tree": "2a89484df1d379c49706d856eb193e8ac57d543b", "parents": [ "516a648631c912e84e0035590f98eef1d716f4ea" ], "author": { "name": "Bhanu Prakash Gollapudi", "email": "bprakash@broadcom.com", "time": "Fri Jun 11 16:43:49 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Tue Jul 27 12:01:44 2010 -0500" }, "message": "[SCSI] libfc: Retry a rejected PRLI request\n\nRetry upto max_rport_retry_count when a target responds with\nLS_RJT for a PRLI request.\n\nSigned-off-by: Bhanu Prakash Gollapudi \u003cbprakash@broadcom.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "7156fffaaa15aeb0e0247736eff0a86f75f49f81", "tree": "9bc9f9ad5fd99b6f5dce04a588b061a453d5f92f", "parents": [ "501af8d110f1fca597ff61c8611d018360ff9bf7" ], "author": { "name": "Kulikov Vasiliy", "email": "segooon@gmail.com", "time": "Mon Jun 28 15:55:12 2010 +0400" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Tue Jul 20 17:15:32 2010 +0200" }, "message": "libfc: use ARRAY_SIZE\n\nChange sizeof(x) / sizeof(*x) to ARRAY_SIZE(x).\n\nSigned-off-by: Kulikov Vasiliy \u003csegooon@gmail.com\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "732bee7af3102cad811fb047dee8d15966efe569", "tree": "1a260fdc7a7155e8b22944dc114af4c2cd56a100", "parents": [ "22c1d8b4f8f04882046ebe592f9a9eaea443cb45" ], "author": { "name": "Uwe Kleine-König", "email": "u.kleine-koenig@pengutronix.de", "time": "Fri Jun 11 12:16:59 2010 +0200" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Wed Jun 16 18:03:14 2010 +0200" }, "message": "fix typos concerning \"hierarchy\"\n\nSigned-off-by: Uwe Kleine-König \u003cu.kleine-koenig@pengutronix.de\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "7b2787ec15b9d1c2f716da61b0eec21a3f5e6520", "tree": "39b098d4253fa266ea75bf1f7feb75458e78b77d", "parents": [ "5e4f8fe7b58f4da5043b7f219fe9193cddd9262e" ], "author": { "name": "Robert Love", "email": "robert.w.love@intel.com", "time": "Fri May 07 15:18:41 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun May 16 22:22:34 2010 -0400" }, "message": "[SCSI] libfc: Move the port_id into lport\n\nThis patch creates a port_id member in struct fc_lport.\nThis allows libfc to just deal with fc_lport instances\ninstead of calling into the fc_host to get the port_id.\n\nThis change helps in only using symbols necessary for\noperation from the libfc structures. libfc still needs\nto change the fc_host_port_id() if the port_id changes\nso the presentation layer (scsi_transport_fc) can provide\nthe user with the correct value, but libfc shouldn\u0027t\nrely on the presentation layer for operational values.\n\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "1b80e0f91c41db4633c0a61f727de169a9e9b275", "tree": "eda3295e4b1f609727bbb661410dd17093f62e96", "parents": [ "721cafafb66f57b461226aa197997f3e5b296f91" ], "author": { "name": "Robert Love", "email": "robert.w.love@intel.com", "time": "Fri May 07 15:18:24 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun May 16 22:22:29 2010 -0400" }, "message": "[SCSI] libfc: Remove unused fc_get_host_port_type\n\nRemove this unused routine.\n\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "b3667f9177359b0594e4f2cd5cc01115f8c7e2af", "tree": "07fe41c0fd9ffb0e9a6763b469fc0783beda14d5", "parents": [ "f1af6208c8cef81e313ec2e64b44e783c3a11c13" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri May 07 15:18:13 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun May 16 22:22:25 2010 -0400" }, "message": "[SCSI] libfc: set seq_id for incoming sequence\n\nAfter the recent patch \"fixes unnecessary seq id jump\"\nthe SCST module fcst stopped working because multi-sequence\nwrite data wasn\u0027t finding the sequence after the first frame.\n\nAdd back the setting of the seq_id when the first frame arrives.\nAlso fix indentation on two lines.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "9f8f3aa640ae5da220eea95215317f19ace91481", "tree": "ef2d97aee5de5f83e53fe2645a7a30aa8a3980c7", "parents": [ "ce8b5df04292e93a117d9f863af206245bf61271" ], "author": { "name": "Chris Leech", "email": "christopher.leech@intel.com", "time": "Fri Apr 09 14:23:16 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 14:02:42 2010 -0500" }, "message": "[SCSI] libfc, fcoe: normalize format specifies for world wide names\n\nPrint all world wide node names (node, port and fabric) with the same\nformat specifier of \"%16.16llx\". That makes sure they all print as a\n16 character hex string, with lower case letters, no 0x prefix, and\nwithout stripping off any leading 0s.\n\nSigned-off-by: Chris Leech \u003cchristopher.leech@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "ce8b5df04292e93a117d9f863af206245bf61271", "tree": "fb10dd4b931756765b3352402d83033a326b9c30", "parents": [ "63ac4bbffb40f2cb3bc7e8b11bac47598813ea13" ], "author": { "name": "Chris Leech", "email": "christopher.leech@intel.com", "time": "Fri Apr 09 14:23:10 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 14:02:41 2010 -0500" }, "message": "[SCSI] libfc: set both precision and field with when printing FC IDs\n\nMost of the prints of fabric IDs were specified as %6x, which will not\nprint any leading 0s. It\u0027s nice to see leading 0s for identifiers\nlike this, which are a fixed length. This patch sets the precision\nmodifier as well, making the specifier %6.6x, which forces the\nprinting of leading 0s.\n\nSigned-off-by: Chris Leech \u003cchristopher.leech@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "63ac4bbffb40f2cb3bc7e8b11bac47598813ea13", "tree": "1b0abf1576e58549f3a89e218e3ab67e55f205e1", "parents": [ "da87bfab8a7e6cfd0e1e5c5874d7fd4f7d11e64e" ], "author": { "name": "Yi Zou", "email": "yi.zou@intel.com", "time": "Fri Apr 09 14:23:05 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 14:02:40 2010 -0500" }, "message": "[SCSI] libfc: bug in erroring out upon FCP_RSP_LEN_VAL in fc_fcp_resp\n\nfc_fcp_resp is assuming when FCP_SNS_LEN_VAL is set, the FCP_RSP_LEN_VAL\nis not, which is not true. This leads to not copying the sense data and\nerror out a valid FCP_RSP.\n\nSigned-off-by: Yi Zou \u003cyi.zou@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "3b719d01617288f4c11307fcb933997d7ca895c3", "tree": "ef32a4a92838107a17b539f50963f1347af1f9c6", "parents": [ "03d29bc1d58dcfc2fa30aed7af199f24444c2052" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Apr 09 14:22:33 2010 -0700" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 14:02:33 2010 -0500" }, "message": "[SCSI] libfc: remove unneeded variables in fc_exch_recv_req()\n\nfc_exch_recv_req has variables eof, sof, and f_ctl,\nwhich are set but never used. Delete them.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "f018b73af6db4f330ad5da9ac53997a699c30c42", "tree": "4f4e9405d923c0021771549dbdec34569c0e27a7", "parents": [ "b3ef990c1514859bffae221b9e82e46a38f1e7bf" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Mar 12 16:08:55 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 09:23:44 2010 -0500" }, "message": "[SCSI] libfc, libfcoe, fcoe: use smp_processor_id() only when preempt disabled\n\nWhen the kernel is configured for preemption, using smp_processor_id()\nwhen preemption is enabled causes a warning backtrace and is wrong\nsince we could move off of that CPU as soon as we get the ID,\nand we would be referencing the wrong CPU, and possibly an invalid one\nif it could be hotswapped out.\n\nRemove the fc_lport_get_stats() function and explicitly use per_cpu_ptr()\nto get the statistics. Where preemption has been disabled by holding\na _bh lock continue to use smp_processor_id(), but otherwise use\nget_cpu()/put_cpu().\n\nIn fcoe_recv_frame() also changed the cases where we return in the\nmiddle to do a goto to the code which bumps ErrorFrames and does\na put_cpu(). Two of these cases didn\u0027t bump ErrorFrames before, but\ndoing so is harmless because they \"can\u0027t happen\", due to prior length\nchecks.\n\nAlso rearranged code in fcoe_recv_frame() to have only one call to\nfc_exch_recv(). It\u0027s just as efficient and saves a call to put_cpu().\n\nIn fc_fcp.c, adjusted a FIXME comment for code which doesn\u0027t need fixing.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "b3ef990c1514859bffae221b9e82e46a38f1e7bf", "tree": "0c1c7887fa668883d49856303c8ed51b2e09afd5", "parents": [ "5c12c418e905aac2826bb70f947648944c079ed9" ], "author": { "name": "Robert Love", "email": "robert.w.love@intel.com", "time": "Fri Mar 12 16:08:50 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 09:23:44 2010 -0500" }, "message": "[SCSI] libfc: Add debug statements when fc_fcp returns DID_ERROR to scsi-ml\n\nDID_ERROR cases can be ambigouos. Debugging FCP error cases\nwill be much easier if we have debug statements when we hit\nthese error conditions.\n\nThis patch simply adds debug messages using the FC_FCP_DBG\nmacro when we return DID_ERROR to SCSI. This way if a DID_ERROR\nis reproducible turning on debug_logging will give a clue\nto developers as to what the problem might be.\n\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "5c12c418e905aac2826bb70f947648944c079ed9", "tree": "802e2e53f57361a6d3899bee226354813c94597f", "parents": [ "3e22760d4db6fd89e0be46c3d132390a251da9c6" ], "author": { "name": "Vasu Dev", "email": "vasu.dev@intel.com", "time": "Fri Mar 12 16:08:44 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 09:23:42 2010 -0500" }, "message": "[SCSI] libfc: fix fcp pkt recovery in fc_fcp_recv_data\n\nCurrently fc_fcp_recv_data calls fc_fcp_retry_cmd to\nretry failed IO but in this case tgt is still sending\ndata frames, therefore exchange needs to be aborted\nfirst before initiating retry. So this patch fixes\nthis by aborting exchange first then have retry.\n\nRenames fc_timeout_error to fc_fcp_recovery since\nfc_timeout_error is already called from several other\nplaces beside from fcp timeout handler and then\nused fc_fcp_recovery for abort \u0026 retry from\nfc_fcp_recv_data, this rename also required renaming\nFC_CMD_TIME_OUT status to FC_CMD_RECOVERY to be\nconsistent with new fc_fcp_recovery.\n\nData frames are not expected for an DDPed exchange and\npotentially it could be tampered data frame, so does\nrecovery in this case by calling fc_fcp_recovery.\n\nSigned-off-by: Vasu Dev \u003cvasu.dev@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "3e22760d4db6fd89e0be46c3d132390a251da9c6", "tree": "d5a80fbf99483362473956913f8a136dbb2c3c66", "parents": [ "a104c844576c6bdc44c6f1336e30a5fcd90fef1c" ], "author": { "name": "Vasu Dev", "email": "vasu.dev@intel.com", "time": "Fri Mar 12 16:08:39 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 09:23:41 2010 -0500" }, "message": "[SCSI] libfc: use offload EM instance again instead jumping to next EM\n\nSince use of offloads is more efficient than switching\nto non-offload EM. However kept logic same to call em_match\nif it is provided in the list of EMs.\n\nConverted fc_exch_alloc to inline being now tiny a function\nand already not an exported libfc API any more.\n\nSigned-off-by: Vasu Dev \u003cvasu.dev@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "a104c844576c6bdc44c6f1336e30a5fcd90fef1c", "tree": "663dcc3412254f0f004d014b93f2f96b402e14a1", "parents": [ "cc3593d3882ffa7dfaa739a8302b256955be7d99" ], "author": { "name": "Vasu Dev", "email": "vasu.dev@intel.com", "time": "Fri Mar 12 16:08:34 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 09:23:41 2010 -0500" }, "message": "[SCSI] libfc: fixes unnecessary seq id jump\n\nIn some cases seq is incremented twice causing unnecessary\nseq jump, for instance fc_exch_recv_seq_resp increments\nseq id when fc_sof_is_init is true and that is true for\neach incoming xfer ready but then fc_fcp_send_data does\nanother seq increment to send data for xfer ready.\n\nThis patch removes all such seq id jumps, at least it\neliminates few calls to fc_seq_start_next using ex_lock.\n\nAlso removes seq id update with incoming frame\u0027s seq id\nas this is not needed since each end (I or T) just need\nto send incremented their own seq id on each TSI from\nother end \u0026 before sending new sequence within a\nexchange.\n\nSigned-off-by: Vasu Dev \u003cvasu.dev@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "cc3593d3882ffa7dfaa739a8302b256955be7d99", "tree": "37e31656c73be8a19a1a6cea48597d14315db163", "parents": [ "4291365784c9622c9d643cf23421f9c7b9662d71" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Mar 12 16:08:29 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 09:23:40 2010 -0500" }, "message": "[SCSI] libfc: fix sequence-initiative WARN in fc_seq_start_next\n\nWhen starting a new response sequence in a multi-sequence\nexchange, a warning was issued that sequence initiative\nwasn\u0027t held.\n\nThe bug was that sequence initiative was cleared by the previous\nsequence due to the END_SEQ flag being on. The intent may have\nbeen to check LAST_SEQ. Change just to check SEQ_INIT.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "ccfc3098029229d5298d4fc07f1b2c967526e56b", "tree": "b3f2e03df96a0968aa4ff0c434cdfca6134a8eb2", "parents": [ "f4568b8b9766d083c0e61346173bb22274128208" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Mar 12 16:08:12 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 09:23:37 2010 -0500" }, "message": "[SCSI] libfc: send point-to-poin FLOGI LS_ACC to assigned D_DID\n\nThe method we\u0027ve been using for point-to-point mode requires\nthat the LS_ACC for the FLOGI uses the D_ID and S_ID assigned\nto the remote port and local port, not those in the exchange.\n\nThis is not the correct method, but for now, it\u0027s what works\nwith the old target, as well as with new targets based on libfc.\n\nThis patch changes the addresses used accordingly.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "f4568b8b9766d083c0e61346173bb22274128208", "tree": "ef55e06fd86a64127a19eb9100f7cbd114e8564b", "parents": [ "7d65b0df6c5951271cd368170bca8601aa2e65c7" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Mar 12 16:08:07 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 09:23:37 2010 -0500" }, "message": "[SCSI] libfc: recognize incoming FLOGI for point-to-point mode\n\nWhen receiving a FLOGI request from a point-to-point peer,\nthe D_ID of 0xfffffe was not recognized as belonging to one\nof the lports, so it was dropped.\n\nChange fc_vport_id_lookup() to treat d_id 0xfffffe as a match.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "2f2ac4a0df8c4beee6e4057a69fa973b6040a573", "tree": "2ff71d9b1f13ff9cc0ed120725f68f003d7b9ae7", "parents": [ "4dc7ccf7e9d9bca1989b840be9e8e84911387cf2" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Mar 12 16:07:46 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 09:23:34 2010 -0500" }, "message": "[SCSI] libfc: fix oops in point-to-point mode\n\nIn point-to-point mode, if the PLOGI to the remote port times\nout, it can get deleted by the remote port module. Since there\u0027s\nno reference by the local port, lport-\u003eptp_data points to a freed\nrport, and when the local port is reset and tries to logout again,\nan oops occurs in mutex_lock_nested().\n\nHold a reference count on the point-to-point rdata.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "a2f6a024e1a7ce37f424a567733501d98b8555d7", "tree": "df6fd29c5b7b8459077c09be3dac6829b22ae58a", "parents": [ "fc193172e63af2c749e198816a1ee694dd6395e6" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Fri Mar 12 16:07:36 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sun Apr 11 09:23:33 2010 -0500" }, "message": "[SCSI] libfc: recode incoming PRLI handling\n\nReduce indentation in fc_rport_recv_prli_req() using gotos.\nAlso add payload length checks.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "5a0e3ad6af8660be21ca98a971cd00f331318c05", "tree": "5bfb7be11a03176a87296a43ac6647975c00a1d1", "parents": [ "ed391f4ebf8f701d3566423ce8f17e614cde9806" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 24 17:04:11 2010 +0900" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 30 22:02:32 2010 +0900" }, "message": "include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h\n\npercpu.h is included by sched.h and module.h and thus ends up being\nincluded when building most .c files. percpu.h includes slab.h which\nin turn includes gfp.h making everything defined by the two files\nuniversally available and complicating inclusion dependencies.\n\npercpu.h -\u003e slab.h dependency is about to be removed. Prepare for\nthis change by updating users of gfp and slab facilities include those\nheaders directly instead of assuming availability. As this conversion\nneeds to touch large number of source files, the following script is\nused as the basis of conversion.\n\n http://userweb.kernel.org/~tj/misc/slabh-sweep.py\n\nThe script does the followings.\n\n* Scan files for gfp and slab usages and update includes such that\n only the necessary includes are there. ie. if only gfp is used,\n gfp.h, if slab is used, slab.h.\n\n* When the script inserts a new include, it looks at the include\n blocks and try to put the new include such that its order conforms\n to its surrounding. It\u0027s put in the include block which contains\n core kernel includes, in the same order that the rest are ordered -\n alphabetical, Christmas tree, rev-Xmas-tree or at the end if there\n doesn\u0027t seem to be any matching order.\n\n* If the script can\u0027t find a place to put a new include (mostly\n because the file doesn\u0027t have fitting include block), it prints out\n an error message indicating which .h file needs to be added to the\n file.\n\nThe conversion was done in the following steps.\n\n1. The initial automatic conversion of all .c files updated slightly\n over 4000 files, deleting around 700 includes and adding ~480 gfp.h\n and ~3000 slab.h inclusions. The script emitted errors for ~400\n files.\n\n2. Each error was manually checked. Some didn\u0027t need the inclusion,\n some needed manual addition while adding it to implementation .h or\n embedding .c file was more appropriate for others. This step added\n inclusions to around 150 files.\n\n3. The script was run again and the output was compared to the edits\n from #2 to make sure no file was left behind.\n\n4. Several build tests were done and a couple of problems were fixed.\n e.g. lib/decompress_*.c used malloc/free() wrappers around slab\n APIs requiring slab.h to be added manually.\n\n5. The script was run on all .h files but without automatically\n editing them as sprinkling gfp.h and slab.h inclusions around .h\n files could easily lead to inclusion dependency hell. Most gfp.h\n inclusion directives were ignored as stuff from gfp.h was usually\n wildly available and often used in preprocessor macros. Each\n slab.h inclusion directive was examined and added manually as\n necessary.\n\n6. percpu.h was updated not to include slab.h.\n\n7. Build test were done on the following configurations and failures\n were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my\n distributed build env didn\u0027t work with gcov compiles) and a few\n more options had to be turned off depending on archs to make things\n build (like ipr on powerpc/64 which failed due to missing writeq).\n\n * x86 and x86_64 UP and SMP allmodconfig and a custom test config.\n * powerpc and powerpc64 SMP allmodconfig\n * sparc and sparc64 SMP allmodconfig\n * ia64 SMP allmodconfig\n * s390 SMP allmodconfig\n * alpha SMP allmodconfig\n * um on x86_64 SMP allmodconfig\n\n8. percpu.h modifications were reverted so that it could be applied as\n a separate patch and serve as bisection point.\n\nGiven the fact that I had only a couple of failures from tests on step\n6, I\u0027m fairly confident about the coverage of this conversion patch.\nIf there is a breakage, it\u0027s likely to be something in one of the arch\nheaders which should be easily discoverable easily on most builds of\nthe specific arch.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nGuess-its-ok-by: Christoph Lameter \u003ccl@linux-foundation.org\u003e\nCc: Ingo Molnar \u003cmingo@redhat.com\u003e\nCc: Lee Schermerhorn \u003cLee.Schermerhorn@hp.com\u003e\n" }, { "commit": "318ae2edc3b29216abd8a2510f3f80b764f06858", "tree": "ce595adde342f57f379d277b25e4dd206988a052", "parents": [ "25cf84cf377c0aae5dbcf937ea89bc7893db5176", "3e58974027b04e84f68b964ef368a6cd758e2f84" ], "author": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Mon Mar 08 16:55:37 2010 +0100" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Mon Mar 08 16:55:37 2010 +0100" }, "message": "Merge branch \u0027for-next\u0027 into for-linus\n\nConflicts:\n\tDocumentation/filesystems/proc.txt\n\tarch/arm/mach-u300/include/mach/debug-macro.S\n\tdrivers/net/qlge/qlge_ethtool.c\n\tdrivers/net/qlge/qlge_main.c\n\tdrivers/net/typhoon.c\n" }, { "commit": "b248df30fca3aeee1d650b570e8cbc4e8cc45710", "tree": "fefe362a9c9513aa3a0e59a643827952d5ad383e", "parents": [ "3b709150b73205710d05128b925090aac048ed23" ], "author": { "name": "Hugh Daschbach", "email": "hdasch@broadcom.com", "time": "Thu Jan 21 10:15:55 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Feb 17 09:57:01 2010 -0600" }, "message": "[SCSI] libfc: Don\u0027t assume response request present.\n\nFix NULL pointer dereference crash occurs in fc_lport_bsg_request()\nfor bsg requests that do not contain a response request.\nSpecifically, FC_BSG_HST_ADD_RPORT and FC_BSG_HST_DEL_RPORT bsg\nrequests are not guaranteed to include a response request.\n\nSigned-off-by: Hugh Daschbach \u003chdasch@broadcom.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "3b709150b73205710d05128b925090aac048ed23", "tree": "f49d1974c3fd1a04cdacb0fa999ab874fc61e58d", "parents": [ "10897ae71dd6e205969726e0f817f3327ef32f83" ], "author": { "name": "Hugh Daschbach", "email": "hdasch@broadcom.com", "time": "Thu Jan 21 10:15:49 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Feb 17 09:56:59 2010 -0600" }, "message": "[SCSI] libfc: Fix e_d_tov ns -\u003e ms scaling factor in PLOGI response.\n\nBoth PLOGI and RTV response processing conditionally scale e_d_tov,\nbut use different scaling factors. The scaling factor is correct in\nRTV response processing. Bring PLOGI e_d_tov scaling in line with RTV\ncommon service parameter inspection.\n\nSigned-off-by: Hugh Daschbach \u003chdasch@broadcom.com\u003e\nAcked-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "10897ae71dd6e205969726e0f817f3327ef32f83", "tree": "1521dd75fa922bd42e8a91dc2d82ec6b06a7c696", "parents": [ "fee099b278894a1c7383a08cb3c62a5b62a134e8" ], "author": { "name": "Vasu Dev", "email": "vasu.dev@intel.com", "time": "Thu Jan 21 10:15:44 2010 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Wed Feb 17 09:56:57 2010 -0600" }, "message": "[SCSI] libfc: call ddp setup for only FCP reads to avoid accessing junk fsp pointer\n\nAdds check to call fc_fcp_ddp_setup for only FCP read cmds to avoid\naccessing junk fsp pointer at least in ESX since non FCP frame had\njunk fsp value, though fsp is implicitly initialized to null\nby __alloc_skb but with this patch no more relying on fsp\ninitialized to null value and hitting junk fsp ptr access.\n\nRemoves fsp pointer checking in fc_fcp_ddp_setup as this is not\nneeded any more since its only caller for FCP read will always\nhave a valid fsp.\n\nReported by: Frank Zhang \u003cfrank_1.zhang@intel.com\u003e\nReported by: Rob Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: Vasu Dev \u003cvasu.dev@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "3ad2f3fbb961429d2aa627465ae4829758bc7e07", "tree": "f365c513e8f5b477a61336a600ff54f32b7ad6e1", "parents": [ "1537a3638cbf741d3826c1002026cce487a6bee0" ], "author": { "name": "Daniel Mack", "email": "daniel@caiaq.de", "time": "Wed Feb 03 08:01:28 2010 +0800" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Tue Feb 09 11:13:56 2010 +0100" }, "message": "tree-wide: Assorted spelling fixes\n\nIn particular, several occurances of funny versions of \u0027success\u0027,\n\u0027unknown\u0027, \u0027therefore\u0027, \u0027acknowledge\u0027, \u0027argument\u0027, \u0027achieve\u0027, \u0027address\u0027,\n\u0027beginning\u0027, \u0027desirable\u0027, \u0027separate\u0027 and \u0027necessary\u0027 are fixed.\n\nSigned-off-by: Daniel Mack \u003cdaniel@caiaq.de\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nCc: Junio C Hamano \u003cgitster@pobox.com\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "9ddc5b6f18fbac07d2746566b73b89e89fdd4e6a", "tree": "aaf691482ac8e36ccccb413b9b698063e6d0b489", "parents": [ "659431fcafd820cc426afedadcc4548933224985" ], "author": { "name": "Uwe Kleine-König", "email": "u.kleine-koenig@pengutronix.de", "time": "Wed Jan 20 17:02:24 2010 +0100" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Fri Feb 05 12:22:40 2010 +0100" }, "message": "tree-wide: fix typos \"ammount\" -\u003e \"amount\"\n\nSigned-off-by: Uwe Kleine-König \u003cu.kleine-koenig@pengutronix.de\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "55a66d3c1e57f7e3e554d6ec8011e840f3802f20", "tree": "b13e6446ce4d397e5c7d774bf942a2563e1248e5", "parents": [ "c1ecb90a66c5afc7cc5c9349f9c3714eef4a5cfb" ], "author": { "name": "Vasu Dev", "email": "vasu.dev@intel.com", "time": "Thu Dec 10 09:59:31 2009 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Dec 12 16:30:34 2009 -0600" }, "message": "[SCSI] fcoe, libfc: adds enable/disable for fcoe interface\n\nThis is to allow fcoemon util to enable or disable a fcoe interface\naccording to DCB link state change.\n\nAdds sysfs module param enable and disable for this and also\nupdates existing other module param description to be consistent\nand more accurate since older description had double \"fcoe\" word\nwith less meaningful netdev reference to user space.\n\nAdds code to ignore redundant fc_lport_enter_reset handling for a\nalready disabled fcoe interface by checking LPORT_ST_DISABLED\nor LPORT_ST_LOGO states, this also prevents lport state transition\non link flap on a disabled interface.\n\nAbove changes required lport state transition to get out of\ndisabled or logo state on call to fc_fabric_login.\n\nSigned-off-by: Vasu Dev \u003cvasu.dev@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "c1ecb90a66c5afc7cc5c9349f9c3714eef4a5cfb", "tree": "9240283c872e0c110c0fef2e424180fc62bed487", "parents": [ "5543c72e2bbb30e5ba5938b18ec26617b8b3fb04" ], "author": { "name": "Chris Leech", "email": "christopher.leech@intel.com", "time": "Thu Dec 10 09:59:26 2009 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Dec 12 16:30:33 2009 -0600" }, "message": "[SCSI] libfc: reduce hold time on SCSI host lock\n\nIntroduce a new lock to protect the list of fc_fcp_pkt structs in libfc\ninstead of using the host lock. This reduces the contention of this heavily\nused lock, and I see up to a 25% performance gain in CPU bound small I/O\ntests when scaling out across multiple quad-core CPUs.\n\nThe big win is in removing the host lock from the completion path\ncompletely, as it does not need to be held around the call to scsi_done.\n\nSigned-off-by: Chris Leech \u003cchristopher.leech@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "5543c72e2bbb30e5ba5938b18ec26617b8b3fb04", "tree": "eca32103b2d2b70f8aa8499144a8db2c40b00645", "parents": [ "83e7332941e3e2621502aadb0e5c8a3b11fd1197" ], "author": { "name": "Abhijeet Joglekar", "email": "abjoglek@cisco.com", "time": "Thu Dec 10 09:59:20 2009 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Sat Dec 12 16:29:47 2009 -0600" }, "message": "[SCSI] libfc: remote port gets stuck in restart state without really restarting\n\nWe ran into a scenario where a remote port goes into RESTART state, but\nnever gets added to scsi transport. The running vmcore showed the following:\na) Port was in RESTART state\nb) rdata-\u003eevent was STOP\nc) no work gets scheduled for the remote work to fc_rport_work\n\nAfter this point, shut/no-shut of the remote port did not cause the port\nto get re-discovered. The port would move betwen DELETE and RESTART states,\nbut the event would always be STOP, no work would get scheduled to\nfc_rport_work and the port would not get added to scsi_transport.\n\nThe problem is that rdata-\u003eevent is not set to NONE after a port is\nrestarted. After this point, no more work gets scheduled for the remote port\nsince new work is scheduled only if rdata-\u003eevent is non-NONE. So, the event\nand state keep changing, but fc_rport_work does not get scheduled to actually\nhandle the event.\n\nHere\u0027s a transition of states that explains the above observation:\n\n) Port is first in READY State, event is NONE\n\n2) RSCN on shut, port goes to DELETED, event is stop\n\n3) Before fc_rport_work runs, RSCN on no-shut, port goes to RESTART, event is\nstill STOP\n\n4) fc_rport_work gets scheduled, removes the port from transport, sees state\nas RESTART, begins the PLOGI state machine, event remains as STOP (event NOT\nchanged to NONE, this is the bug)\n\n5) Plogi state machine completes, port state goes to READY, event goes to\nREADY, but no work is scheduled since event was STOP (non-NONE) before.\nFc_rport_work is not scheduled, port remains in READY state, but is not added\nto transport.\n\nThings are broken at this point. Libfc rport is ready, but no transport rport\ncreated.\n\n6) now a shut causes port state to change to DELETE, event to change to STOP,\nno work gets scheduled\n\n7) no-shut causes port state to change to RESTART, event remains at STOP,\nno work gets scheduled\n\n(6) and (7) now get repeated everytime we do shut/no-shut. No way to get out\nof this state. Fcc reset does not help too.\n\nOnly way to get out is to load/unload module.\n\nFix is to set rdata-\u003eevent to NONE while processing the STOP/LOGO/FAILED\nevents, inside the discovery and rport locks.\n\nSigned-off-by: Abhijeet Joglekar \u003cabjoglek@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "4ef58d4e2ad1fa2a3e5bbf41af2284671fca8cf8", "tree": "856ba96302a36014736747e8464f80eeb827bbdd", "parents": [ "f6c4c8195b5e7878823caa1181be404d9e86d369", "d014d043869cdc591f3a33243d3481fa4479c2d0" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Dec 09 19:43:33 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Dec 09 19:43:33 2009 -0800" }, "message": "Merge branch \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial\n\n* \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (42 commits)\n tree-wide: fix misspelling of \"definition\" in comments\n reiserfs: fix misspelling of \"journaled\"\n doc: Fix a typo in slub.txt.\n inotify: remove superfluous return code check\n hdlc: spelling fix in find_pvc() comment\n doc: fix regulator docs cut-and-pasteism\n mtd: Fix comment in Kconfig\n doc: Fix IRQ chip docs\n tree-wide: fix assorted typos all over the place\n drivers/ata/libata-sff.c: comment spelling fixes\n fix typos/grammos in Documentation/edac.txt\n sysctl: add missing comments\n fs/debugfs/inode.c: fix comment typos\n sgivwfb: Make use of ARRAY_SIZE.\n sky2: fix sky2_link_down copy/paste comment error\n tree-wide: fix typos \"couter\" -\u003e \"counter\"\n tree-wide: fix typos \"offest\" -\u003e \"offset\"\n fix kerneldoc for set_irq_msi()\n spidev: fix double \"of of\" in comment\n comment typo fix: sybsystem -\u003e subsystem\n ...\n" }, { "commit": "63e27fb80c2010678681cef7b528ab8af3624fe9", "tree": "2ce41c886c976ead202044eb32d3e9aacc97e023", "parents": [ "b84056bf68404a5fe06b452ea9790b9927e793a6" ], "author": { "name": "Yi Zou", "email": "yi.zou@intel.com", "time": "Fri Nov 20 14:55:24 2009 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Fri Dec 04 12:01:59 2009 -0600" }, "message": "[SCSI] libfc: add support of receiving ELS_RLS\n\nUpon receiving ELS_RLS, send the Link Error Status Block (LESB) back.\n\nSigned-off-by: Yi Zou \u003cyi.zou@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "70d919fbd9ab78f3eca5ea7bd060fefd7b508641", "tree": "569a8f9d127e962fbdc6df0b7ac9156534e36baf", "parents": [ "2a7045212cef90337588f72f5dabf497f5f93a90" ], "author": { "name": "Yi Zou", "email": "yi.zou@intel.com", "time": "Fri Nov 20 14:54:41 2009 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Fri Dec 04 12:01:54 2009 -0600" }, "message": "[SCSI] libfc: fix payload size passed to fc_frame_alloc() in fc_lport_els_request\n\nFrame header room is already incluced, just pass the length of payload.\n\nSigned-off-by: Yi Zou \u003cyi.zou@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "b94f8951bf256674eca3f2a490df17521442afef", "tree": "ae6b246eb65f7ef73167a2b582ce7e670158a958", "parents": [ "be276cbe1bd680ab1f6c297017dd658e5a6b10d2" ], "author": { "name": "Joe Eykholt", "email": "jeykholt@cisco.com", "time": "Tue Nov 03 11:50:21 2009 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Fri Dec 04 12:01:27 2009 -0600" }, "message": "[SCSI] libfc fcoe: increase ELS and CT timeouts\n\nThe FC-LS spec. says ELS timeouts should be 2 x R_A_TOV.\nThe FC-GS spec. says CT timeouts should be 3 x R_A_TOV.\n\nWe\u0027ve been using E_D_TOV for both of those.\n\nChange for all ELS and CT requests except FLOGI, which we\nleave at 2 seconds (using E_D_TOV). One could argue that\nR_A_TOV is locally determined until after FLOGI succeeds.\n\nThis does change FLOGI for vports which becomes FDISC.\nThis does not change the REC/SRR timeout which is 2 seconds.\n\nSigned-off-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" }, { "commit": "4ae1e19f251335a24ce6cd13f08b4af560ed8765", "tree": "2a22a5722e3e6740f9dfad1d59f92cac7229c988", "parents": [ "18fa11efc279c20af5eefff2bbe814ca067e51ae" ], "author": { "name": "Vasu Dev", "email": "vasu.dev@intel.com", "time": "Tue Nov 03 11:50:10 2009 -0800" }, "committer": { "name": "James Bottomley", "email": "James.Bottomley@suse.de", "time": "Fri Dec 04 12:01:26 2009 -0600" }, "message": "[SCSI] libfc: fix an issue of pending exch/es after i/f destroyed or rmmod fcoe\n\nAll exches must be freed before its EM mempool destroyed in this\ncase but currently some exches could be still pending in their\nscheduled delayed work after EM mempool is destroyed causing\nthis issue discussed and reported in this latest email thread:-\n\n http://www.open-fcoe.org/pipermail/devel/2009-October/004788.html\n\nThis patch fixes this issue by adding dedicated work queue thread\nfc_exch_workqueue for exch delayed work and then flush this work\nqueue before destroying EM mempool.\n\nThe cancel_delayed_work_sync cannot be called during final\nfc_exch_reset due to lport and exch locking ordering, so removes\nrelated comment block not relevant any more with this patch.\n\nReported-by: Joe Eykholt \u003cjeykholt@cisco.com\u003e\nSigned-off-by: Vasu Dev \u003cvasu.dev@intel.com\u003e\nSigned-off-by: Robert Love \u003crobert.w.love@intel.com\u003e\nSigned-off-by: James Bottomley \u003cJames.Bottomley@suse.de\u003e\n" } ], "next": "18fa11efc279c20af5eefff2bbe814ca067e51ae" }