)]}' { "log": [ { "commit": "84994e16f25dabe234be4fc2d323ec9db95b87cb", "tree": "d30cc0144afe0f4640e432b4c0bd4a0f1f86c9ed", "parents": [ "0c0b0aca66b3a58e12a216d992a0b534eff210e0" ], "author": { "name": "Harvey Harrison", "email": "harvey.harrison@gmail.com", "time": "Fri May 02 16:44:07 2008 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Fri May 02 16:44:07 2008 -0700" }, "message": "dccp: ccid2.c, ccid3.c use clamp(), clamp_t()\n\nMakes the intention of the nested min/max clear.\n\nSigned-off-by: Harvey Harrison \u003charvey.harrison@gmail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "c4e18dade1f878db33ed38927de22e63d550970d", "tree": "514e2321c39618ae4c7ad4b15f7ae0d65eefb66c", "parents": [ "cf35f43e6e41b160d8dedd80a127210fd3be9ada" ], "author": { "name": "Ilpo Järvinen", "email": "ilpo.jarvinen@helsinki.fi", "time": "Sat Jan 05 23:13:58 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 15:00:44 2008 -0800" }, "message": "[CCID3]: Kill some bloat\n\nWithout a number of CONFIG.*DEBUG:\n\nnet/dccp/ccids/ccid3.c:\n ccid3_hc_tx_update_x | -170\n ccid3_hc_tx_packet_sent | -175\n ccid3_hc_tx_packet_recv | -169\n ccid3_hc_tx_no_feedback_timer | -192\n ccid3_hc_tx_send_packet | -144\n 5 functions changed, 850 bytes removed, diff: -850\n\nnet/dccp/ccids/ccid3.c:\n ccid3_update_send_interval | +191\n 1 function changed, 191 bytes added, diff: +191\n\nnet/dccp/ccids/ccid3.o:\n 6 functions changed, 191 bytes added, 850 bytes removed, diff: -659\n\nSigned-off-by: Ilpo Järvinen \u003cilpo.jarvinen@helsinki.fi\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "52515e77a7a69867c479db4c9efb6be832b82179", "tree": "d4246af065a53f7e2ae92070ec07d59ba892baf6", "parents": [ "d8d1252f744cb7cebd6ba3a4b7feec31ff23ccde" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 17 12:57:43 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:58:23 2008 -0800" }, "message": "[CCID3]: Nofeedback timer according to rfc3448bis\n\nThis implements the changes to the nofeedback timer handling suggested\nin draft rfc3448bis00, section 4.4. In particular, these changes mean:\n\n * better handling of the lossless case (p \u003d\u003d 0)\n * the timestamp for computing t_ld becomes obsolete\n * much more recent document (RFC 3448 is almost 5 years old)\n * concepts in rfc3448bis arose from a real, working implementation\n (cf. sec. 12)\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "d8d1252f744cb7cebd6ba3a4b7feec31ff23ccde", "tree": "acb47c9a5e654a6b5ca3ebf60c8c60d783fb3a65", "parents": [ "5bd370a63daf62bb5520c258f04e91a4d9d274dd" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 17 12:48:47 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:58:22 2008 -0800" }, "message": "[CCID3]: Implement rfc3448bis changes to feedback reception\n\nThis implements the algorithm to update the allowed sending rate X upon\nreceiving feedback packets, as described in draft rfc3448bis, 4.2/4.3.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "5bd370a63daf62bb5520c258f04e91a4d9d274dd", "tree": "acec316f81c7d2b4e87373a229875a2f78b6ca96", "parents": [ "8e138e7949490eebdccbd65b1f660a0488149a6b" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 17 10:25:06 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:58:22 2008 -0800" }, "message": "[CCID3]: Remove two irrelevant states in TX feedback handling\n\n * the NO_SENT state is only triggered in bidirectional mode,\n costing unnecessary processing.\n * the TERM (terminating) state is irrelevant.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "8e138e7949490eebdccbd65b1f660a0488149a6b", "tree": "8013f8f699f3bac8daa9747183a704854150c496", "parents": [ "17159b0b494ad27f397f914d6eab1b91faf57630" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 17 10:07:44 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:58:21 2008 -0800" }, "message": "[CCID3]: Use a function to update p_inv, and p is never used\n\nThis patch\n 1) concentrates previously scattered computation of p_inv into one function;\n 2) removes the `p\u0027 element of the CCID3 RX sock (it is redundant);\n 3) makes the tfrc_rx_info structure standalone, only used on demand.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "84a97b0af8c29aa5a47cc5271968a9c6004fb91e", "tree": "8fb3da66a7c0cc0933b714de884f210f0ecb90e0", "parents": [ "9cb2345a8c49ea380437d02bb9fd9f291c0a005d" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Dec 13 23:33:25 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:57:58 2008 -0800" }, "message": "[CCID]: More informative registration\n\nThe patch makes the registration messages of CCID 2/3 a bit more\ninformative: instead of repeating the CCID number as currently done,\n\n \"CCID: Registered CCID 2 (ccid2)\" or\n \"CCID: Registered CCID 3 (ccid3)\",\n\nthe descriptive names of the CCID\u0027s (from RFCs) are now used:\n\n\t\"CCID: Registered CCID 2 (TCP-like)\" and\n\t\"CCID: Registered CCID 3 (TCP-Friendly Rate Control)\".\n\nTo allow spaces in the name, the slab name string has been changed to\nrefer to the numeric CCID identifier, using the same format as before.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "3f71c81ac37b27b824e9ce18fe17438dc2af4a16", "tree": "0291ca60c033aec233443faec78777f603e5e419", "parents": [ "954c2db868ce896325dced91d5fba5e2226897a4" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Dec 12 14:23:08 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:57:20 2008 -0800" }, "message": "[TFRC]: Remove previous loss intervals implementation\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "954c2db868ce896325dced91d5fba5e2226897a4", "tree": "d74b480530878c25eb770293d786f2e78ace90e7", "parents": [ "de0d411cb8ea51175f52d935faead5c542b6e007" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Dec 12 14:06:14 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:57:20 2008 -0800" }, "message": "[CCID3]: Interface CCID3 code with newer Loss Intervals Database\n\nThis hooks up the TFRC Loss Interval database with CCID 3 packet reception.\nIn addition, it makes the CCID-specific computation of the first loss\ninterval (which requires access to all the guts of CCID3) local to ccid3.c.\n\nThe patch also fixes an omission in the DCCP code, that of a default /\nfallback RTT value (defined in section 3.4 of RFC 4340 as 0.2 sec); while\nat it, the upper bound of 4 seconds for an RTT sample has been reduced to\nmatch the initial TCP RTO value of 3 seconds from[RFC 1122, 4.2.3.1].\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "de0d411cb8ea51175f52d935faead5c542b6e007", "tree": "d26398b1da10d52a4138728ff11e955d9d1fba04", "parents": [ "db64196038e79b0460245d558e54ff4a21a52d1f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Dec 12 14:03:01 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:57:19 2008 -0800" }, "message": "[TFRC]: CCID3 (and CCID4) needs to access these inlines\n\nThis moves two inlines back to packet_history.h: these are not private\nto packet_history.c, but are needed by CCID3/4 to detect whether a new\nloss is indicated, or whether a loss is already pending.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "db64196038e79b0460245d558e54ff4a21a52d1f", "tree": "c24ee13b726832a85a95a2824f01293fe84dcc75", "parents": [ "8a9c7e92e0ca97632126feee32ba2698b4eb6c8f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Dec 12 13:57:14 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:57:18 2008 -0800" }, "message": "[CCID3]: Redundant debugging output / documentation\n\nEach time feedback is sent two lines are printed:\n\n\tccid3_hc_rx_send_feedback: client ... - entry\n\tccid3_hc_rx_send_feedback: Interval ...usec, X_recv\u003d..., 1/p\u003d...\n\nThe first line is redundant and thus removed.\n\nFurther, documentation of ccid3_hc_rx_sock (capitalisation) is made consistent.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "8a9c7e92e0ca97632126feee32ba2698b4eb6c8f", "tree": "b569d6e39f3630f7a973814a925502035c63904b", "parents": [ "8995a238ef6869bc5c80240440bc58452c7af283" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Dec 12 13:50:51 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:57:18 2008 -0800" }, "message": "[TFRC]: Ringbuffer to track loss interval history\n\nA ringbuffer-based implementation of loss interval history is easier to\nmaintain, allocate, and update.\n\nThe `swap\u0027 routine to keep the RX history sorted is due to and was written\nby Arnaldo Carvalho de Melo, simplifying an earlier macro-based variant.\n\nDetails:\n * access to the Loss Interval Records via macro wrappers (with safety checks);\n * simplified, on-demand allocation of entries (no extra memory consumption on\n lossless links); cache allocation is local to the module / exported as service;\n * provision of RFC-compliant algorithm to re-compute average loss interval;\n * provision of comprehensive, new loss detection algorithm\n \t- support for all cases of loss, including re-ordered/duplicate packets;\n \t- waiting for NDUPACK\u003d3 packets to fill the hole;\n\t- updating loss records when a late-arriving packet fills a hole.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "8995a238ef6869bc5c80240440bc58452c7af283", "tree": "40850acfd1042ecdf9bf3f745358871ef42772bb", "parents": [ "df8f83fdd6369e1ba85f089fd6fe26bb2ddcb36f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Dec 12 12:28:40 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:57:16 2008 -0800" }, "message": "[TFRC]: Loss interval code needs the macros/inlines that were moved\n\nThis moves the inlines (which were previously declared as macros) back into\npacket_history.h since the loss detection code needs to be able to read entries\nfrom the RX history in order to create the relevant loss entries: it needs at\nleast tfrc_rx_hist_loss_prev() and tfrc_rx_hist_last_rcv(), which in turn\nrequire the definition of the other inlines (macros).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "df8f83fdd6369e1ba85f089fd6fe26bb2ddcb36f", "tree": "8ddb2e0b70d5ed99837919ada6664e70c876f119", "parents": [ "2aaef4e47fef8a6c0bc7fc5d9d3eea4af290e04c" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Dec 12 12:24:49 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:57:15 2008 -0800" }, "message": "[TFRC]: Put RX/TX initialisation into tfrc.c\n\nThis separates RX/TX initialisation and puts all packet history / loss intervals\ninitialisation into tfrc.c.\nThe organisation is uniform: slab declaration -\u003e {rx,tx}_init() -\u003e {rx,tx}_exit()\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "385ac2e3f226c09cb71733df1899658e33a7850f", "tree": "d3b9754ec75c550b784ef51ab02b25e00aa70c34", "parents": [ "797eba424d4332f6aff5b741600b61e3d4b3d3f2" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Dec 08 16:26:59 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:57:04 2008 -0800" }, "message": "[CCID3]: HC-receiver should not insert timestamps as HC-sender doesn\u0027t uses it\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "797eba424d4332f6aff5b741600b61e3d4b3d3f2", "tree": "f29150076bb9032eb1e11a9a83c974b7875b3553", "parents": [ "78282d2af598a1840934e2049a5c196885647f6a" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Dec 08 16:08:41 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:57:03 2008 -0800" }, "message": "[TFRC]: The function tfrc_rx_hist_entry_delete() is not used anymore\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "78282d2af598a1840934e2049a5c196885647f6a", "tree": "19f2a626bc2a8741b3740a44ccaa9f0e02e21d34", "parents": [ "c69bce20dda7f79160856a338298d65a284ba303" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Dec 08 15:08:08 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:57:03 2008 -0800" }, "message": "[TFRC]: Move comment.\n\nMoved up the comment \"Receiver routines\" above the first occurrence of\nRX history routines.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "b84a2189c4e1835c51fd6b974a0497be9bc4ba87", "tree": "d488b0a45618ac37c605b10b093f8f03a050a7fc", "parents": [ "30a0eacd479f1c7c15fe0496585ff29f76de3378" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Thu Dec 06 13:18:11 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:56:43 2008 -0800" }, "message": "[TFRC]: New rx history code\n\nCredit here goes to Gerrit Renker, that provided the initial implementation for\nthis new codebase.\n\nI modified it just to try to make it closer to the existing API, renaming some\nfunctions, add namespacing and fix one bug where the tfrc_rx_hist_alloc was not\nfreeing the allocated ring entries on the error path.\n\nOriginal changeset comment from Gerrit:\n -----------\nThis provides a new, self-contained and generic RX history service for TFRC\nbased protocols.\n\nDetails:\n * new data structure, initialisation and cleanup routines;\n * allocation of dccp_rx_hist entries local to packet_history.c,\n as a service exported by the dccp_tfrc_lib module.\n * interface to automatically track highest-received seqno;\n * receiver-based RTT estimation (needed for instance by RFC 3448, 6.3.1);\n * a generic function to test for `data packets\u0027 as per RFC 4340, sec. 7.7.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "30a0eacd479f1c7c15fe0496585ff29f76de3378", "tree": "eed98813afd0814e0d0999428b50477c5d36471e", "parents": [ "d58d1af03a6a3ddf296ae3aeb4ff234af4b15958" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Dec 06 12:29:07 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:56:43 2008 -0800" }, "message": "[CCID3]: The receiver of a half-connection does not set window counter values\n\nOnly the sender sets window counters [RFC 4342, sections 5 and 8.1].\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "d58d1af03a6a3ddf296ae3aeb4ff234af4b15958", "tree": "44194b47b1c1b188f300ec1d1f6f0eed6e9a8849", "parents": [ "34a9e7ea91bb4acb45ae5331e7403304029329b2" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Thu Dec 06 12:28:39 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:56:42 2008 -0800" }, "message": "[TFRC]: Rename dccp_rx_ to tfrc_rx_\n\nThis is in preparation for merging the new rx history code written by Gerrit Renker.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "34a9e7ea91bb4acb45ae5331e7403304029329b2", "tree": "196c60bbe79f4d480cefa9d141a6096f3450fa75", "parents": [ "e9c8b24a6ade50315f3c080799da45ddadf42269" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Thu Dec 06 12:28:13 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:56:41 2008 -0800" }, "message": "[TFRC]: Make the rx history slab be global\n\nThis is in preparation for merging the new rx history code written by Gerrit Renker.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "e9c8b24a6ade50315f3c080799da45ddadf42269", "tree": "bf7c9aabba852c4f54f3f38223e0c41445bb2f50", "parents": [ "2180c41ca5c1a36c67f4140e80154699333109d2" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Thu Dec 06 12:27:49 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:56:40 2008 -0800" }, "message": "[TFRC]: Rename tfrc_tx_hist to tfrc_tx_hist_slab, for consistency\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "c40616c597bf02a2346cbf2f120283734b436245", "tree": "2fb6f82ed8fec01038f4607b489086a8f2a719f9", "parents": [ "f8b33fdfafea0f909712a55fbb3d83b89f70f3f5" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Dec 06 12:26:38 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:56:39 2008 -0800" }, "message": "[TFRC]: Provide central source file and debug facility\n\nThis patch changes the tfrc_lib module in the following manner:\n\n (1) a dedicated tfrc source file to call the packet history \u0026\n loss interval init/exit functions.\n (2) a dedicated tfrc_pr_debug macro with toggle switch `tfrc_debug\u0027.\n\nCommiter note: renamed tfrc_module.c to tfrc.c, and made CONFIG_IP_DCCP_CCID3\nselect IP_DCCP_TFRC_LIB.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "9108d5f4b2cd82f55ad178caa0be66a866a06dcc", "tree": "c706ab8146fa93ab56c72037b7daa2a6f78e4062", "parents": [ "95bdfccb2bf4ea21c0065772c6a2c75cbaf6ad0d" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Thu Nov 29 22:47:15 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:55:19 2008 -0800" }, "message": "[TFRC]: Hide tx history details from the CCIDs\n\nBased on a previous patch by Gerrit Renker.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "276f2edc52e309b38a216245952e05880e182c83", "tree": "3f581eb831a6f7f16ab30bd0f8e8d80b5b97fe50", "parents": [ "ea4f76ae13b4240dac304ed50636391d6b22e9c5" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Wed Nov 28 11:15:40 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:55:11 2008 -0800" }, "message": "[TFRC]: Migrate TX history to singly-linked lis\n\nThis patch was based on another made by Gerrit Renker, his changelog was:\n\n ------------------------------------------------------\nThe patch set migrates TFRC TX history to a singly-linked list.\n\nThe details are:\n * use of a consistent naming scheme (all TFRC functions now begin with `tfrc_\u0027);\n * allocation and cleanup are taken care of internally;\n * provision of a lookup function, which is used by the CCID TX infrastructure\n to determine the time a packet was sent (in turn used for RTT sampling);\n * integration of the new interface with the present use in CCID3.\n ------------------------------------------------------\n\nSimplifications I did:\n\n. removing the tfrc_tx_hist_head that had a pointer to the list head and\n another for the slabcache.\n. No need for creating a slabcache for each CCID that wants to use the TFRC\n tx history routines, create a single slabcache when the dccp_tfrc_lib module\n init routine is called.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "dcfbc7e97a2e3a0d73a2e41e1bddb988dcca701e", "tree": "72f3e847a2cff031e8d9d7728065716da3ca0be9", "parents": [ "a302002516a094015e5d004b8d939a8a34559c82" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 22:12:06 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:55:01 2008 -0800" }, "message": "[CCID2]: Remove misleading comment\n\nThis removes a comment which identifies an `issue\u0027 with dccp_write_xmit() where there is none.\nThe comment assumes it is possible that a packet is sent between the calls to\n\n\tccid_hc_tx_send_packet(),\n\tdccp_transmit_skb(),\n\tccid_hc_tx_packet_sent()\n\n(in the above order) in dccp_write_xmit().\n\nI think that this is impossible, since dccp_write_xmit() is always called under lock:\n\n * when called as dccp_write_xmit(sk, 1) from dccp_send_close(), the socket is locked\n (see code comment above dccp_send_close());\n * when called as dccp_write_xmit(sk, 0) from dccp_send_msg(), it is after lock_sock() has been called;\n * when called as dccp_write_xmit(sk, 0) from dccp_write_xmit_timer(), bh_lock_sock() has been called\n and the if/else statement has made sure that sk_lock.owner is not set;\n * there are no other places where dccp_write_xmit() is called.\n\nFurthermore, the debug statement for printing the sequence number of the packet just sent has been\nremoved, since the entire list is being printed anyway and so the entry of that number appears last.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "a302002516a094015e5d004b8d939a8a34559c82", "tree": "681d5be6c6e283f6889152d3e97af3e833f473ba", "parents": [ "83399361c30f2ffae20ee348ba9ada9a856d499a" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 22:10:29 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:55:00 2008 -0800" }, "message": "[CCID2]: Remove redundant ack-counting variable\n\nThe code used two different variables to count Acks, one of them redundant.\nThis patch reduces the number of Ack counters to one.\n\nThe type of the Ack counter has also been changed to u32 (twice the range of int);\nand the variable has been renamed into `packets_acked\u0027 - for consistency with\nRFC 3465 (and similarly named variables are used by TCP and SCTP).\n\nLastly, a slightly less aggressive `maxincr\u0027 increment is used (for even Ack Ratios,\nmaxincr was Ack Ratio/2 + 1 instead of Ack Ratio/2).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "83399361c30f2ffae20ee348ba9ada9a856d499a", "tree": "51f5399c9d394ab4ec1483d7bb908566a19e8792", "parents": [ "da98e0b5d4c1f88b7c9e63e8918783cd4905be2b" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 22:09:35 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:59 2008 -0800" }, "message": "[CCID2]: Remove redundant synchronisation variable\n\nThis removes the synchronisation variable `ccid2hctx_sendwait\u0027, which is set to 1\nwhen the CCID2 sender may send a new packet, and which is set to 0 otherwise\n\nThe variable is redundant, since it is only used in combination with the hc_tx_send_packet/\nhc_tx_packet_sent function pair. Both functions are called under socket lock, so the\nfollowing happens when the CCID2 may send a new packet:\n\n * it sets sendwait \u003d 1 in tx_send_packet and returns 0;\n * the subsequent call to tx_packet_sent clears the sendwait flag;\n * since tx_send_packet returns 0 if and only if sendwait \u003d\u003d 1, the BUG_ON condition\n in tx_packet_sent is never satisfied, since that function is never called when\n tx_send_packet returns a value different from 0 (cf. dccp_write_xmit);\n * the call to tx_packet_sent clears the flag so that the condition \"!sendwait\" is\n true the next time tx_packet_sent is called.\n\nIn other words, it is sufficient to just return 0 / not-0 to synchronise tx_send_packet\nand tx_packet_sent -- which is what the patch does.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "da98e0b5d4c1f88b7c9e63e8918783cd4905be2b", "tree": "4a0dcc5d424b325b67c3b9f7d9a90dea9a4b1780", "parents": [ "95b21d7e9d099f1cffca08e40f292d6658a88b3c" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 22:08:27 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:59 2008 -0800" }, "message": "[CCID2]: Redundant debugging output\n\nThis reduces the amount of redundant debugging messages:\n\n * pipe/cwnd are printed in both tx_send_packet() and tx_packet_sent().\n Both functions are called immediately after one another, so one occurrence is sufficient.\n\n * Since tx_packet_sent() prints pipe/cwnd already, the second printk for pipe is redundant.\n\n * In tx_packet_sent() the check_sanity function is called twice (at the begin and at the end).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "95b21d7e9d099f1cffca08e40f292d6658a88b3c", "tree": "23f30c58c1bbe6344c6077552b4220a442b94624", "parents": [ "3deeadd74bbf916b502d307222833ffcf68db557" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 22:06:52 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:58 2008 -0800" }, "message": "[CCID2]: Replace pipe assignment-function with assignment\n\nThe function ccid2_change_pipe only does an assignment. This patch simplifies the code by\nreplacing the function with the assignment it performs.\n\nFurthermore, the type of pipe is promoted from `signed\u0027 to unsigned (increasing the range).\nAs a result, a BUG_ON test for negative values now becomes obsolete (for safety not removed,\nbut replaced with a less annoying `DCCP_BUG\u0027).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "3deeadd74bbf916b502d307222833ffcf68db557", "tree": "86f33bdcbab3a6b48157e6aa381a5a1668935ed7", "parents": [ "63df18ad7fb91c65dafc89d3cf94a58a486ad416" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 22:05:51 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:57 2008 -0800" }, "message": "[CCID2]: Replace cwnd assignment-function with assignment\n\nThe current function ccid2_change_cwnd in effect makes only an assignment, as\nthe test whether cwnd has reached 0 is only required when cwnd is halved.\n\nThis patch simplifies the code by replacing the function with the assignment\nit performs.\n\nFurthermore, since ssthresh derives from cwnd and appears in many assignments and\ncomparisons, the type of ssthresh has also been changed to match that of cwnd.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "63df18ad7fb91c65dafc89d3cf94a58a486ad416", "tree": "63172fb7125c990516430ef8b4e50648079d89fd", "parents": [ "7792cd8885954eb7ac38e781a7a9faae5a80a3d8" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 22:04:35 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:57 2008 -0800" }, "message": "[CCID2]: Replace read-only variable with constant\n\nThis replaces the field member `numdupack\u0027, which was used as a read-only\nconstant in the code, with a #define.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "7792cd8885954eb7ac38e781a7a9faae5a80a3d8", "tree": "4f96ef45b1ab85eb4b1d79d16d11e2bc8bc27051", "parents": [ "900bfed4718126e6c32244903b6f43e0990d04ad" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 22:01:56 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:56 2008 -0800" }, "message": "[CCID2]: Remove unused variable\n\nThis removes a variable `ccid2hctx_sent\u0027 which is incremented but\nnever referenced/read (i.e., dead code).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "900bfed4718126e6c32244903b6f43e0990d04ad", "tree": "d4644ea4770657046d762d9997d7a8e1d794ff94", "parents": [ "b00d2bbc45a287c9a72374582ce42205f3412419" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 21:58:33 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:55 2008 -0800" }, "message": "[CCID2]: Disable broken Ack Ratio adaptation algorithm\n\nThis comments out a problematic section comprising a half-finished algorithm:\n\n - The variable `ccid2hctx_ackloss\u0027 is never initialised to a value different from 0 and\n hence in fact is a read-only constant.\n - The `arsent\u0027 variable counts packets other than Acks (it is incremented for every packet),\n and there is no test for Ack Loss.\n - The concept of counting Acks as such leads to a complex calculation, and the calculation\n at the moment is inconsistent with this concept.\n The problem is that the number of Acks - rather than the number of windows - is counted,\n which leads to a complex (cubic/quadratic) expression - this is not even implemented.\n\nIn its current state, the commented-out algorithm interfers with normal processing by\nchanging Ack Ratio incorrectly, and at the wrong times.\n\nA new algorithm is necessary, which will not necessarily use the same variables as used by\nthe unfinished one; hence the old variables have been removed.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "b00d2bbc45a287c9a72374582ce42205f3412419", "tree": "22a301fc6d05fe98b142cf53ec75967e847ac02e", "parents": [ "e18d7a9857cb620a8f70622c4e400be477c264cf" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 21:44:30 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:55 2008 -0800" }, "message": "[CCID2]: Larger initial windows also for CCID2\n\nRFC 4341, sec. 5 states that \"The cwnd parameter is initialized to at most\nfour packets for new connections, following the rules from [RFC3390]\", which\nis implemented by this patch.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "d50ad163e6db2dcc365b8d02b30350220f86df04", "tree": "56998d89dcf4b748c09b4f5fe82bd2b7742ea3cb", "parents": [ "df054e1d00fdafa2e2920319df326ddb3f0d0413" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 21:40:24 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:53 2008 -0800" }, "message": "[CCID2]: Deadlock and spurious timeouts when Ack Ratio \u003e cwnd\n\nThis patch removes a bug in the current code. I agree with Andrea\u0027s comment\nthat there is a problem here but the way it is treated does not fix it.\n\nThe problem is that whenever Ack Ratio \u003e cwnd, starvation/deadlock occurs:\n * the receiver will not send an Ack until (Ack Ratio - cwnd) data packets\n have arrived;\n * the sender will not send any data packet before the receipt of an Ack\n advances the send window.\nThe only way that the connection then progresses was via RTO timeout. In one\nextreme case (bulk transfer), it was observed that this happened for every single\npacket; i.e. hundreds of packets, each a RTO timeout of 1..3 seconds apart:\na transfer which normally would take a fraction of a second thus grew to\nseveral minutes.\n\nThe solution taken by this approach is to observe the relation\n\n \"Ack Ratio \u003c\u003d cwnd\"\n\nby using the constraint (1) from RFC 4341, 6.1.2; i.e. set\n\n Ack Ratio \u003d ceil(cwnd / 2)\n\nand update it whenever either Ack Ratio or cwnd change. This ensures that\nthe deadlock problem can not arise.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "df054e1d00fdafa2e2920319df326ddb3f0d0413", "tree": "4c5178212391dc2b1fe0d329da5e8552bcab4a55", "parents": [ "cfbbeabc8864902c4af1c0cadf0972b352930a26" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 21:32:53 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:53 2008 -0800" }, "message": "[CCID2]: Don\u0027t assign negative values to Ack Ratio\n\nSince it makes not sense to assign negative values to Ack Ratio, this\npatch disallows this possibility.\n\nAs a consequence, a Bug test for negative Ack Ratio values becomes obsolete.\n\nFurthermore, a check against overflow (as Ack Ratio may not exceed 2 bytes,\ndue to RFC 4340, 11.3) has been added.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "cfbbeabc8864902c4af1c0cadf0972b352930a26", "tree": "90b544b5ad57bd49c25715a595ccd23d227dd714", "parents": [ "3de5489f47febe0333b142e0eb6389b9924b2634" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 20:43:59 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:52 2008 -0800" }, "message": "[CCID2]: Fix sequence number arithmetic/comparisons\n\nThis replaces use of normal subtraction with modulo-48 subtraction.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "3de5489f47febe0333b142e0eb6389b9924b2634", "tree": "6ac340c65f64245d14c21a4bca03580c3d9789fe", "parents": [ "a47c51044a77124ce66cd8513bba6f4d7673e43d" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Nov 24 20:37:48 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:51 2008 -0800" }, "message": "[CCID2]: Bug in reading Ack Vectors\n\nIn CCID2 the receiver-history is sorted in ascending order of sequence number,\nbut the processing of received Ack Vectors requires the list traversal in the\nopposite direction.\n\nThe current code has a bug in this regard: the list traversal is upwards. As a\nconsequence, only Ack Vectors with a run length of 1 will pass, in all other\nAck Vectors the remaining (acked) sequence numbers are missed, and may later\nfalsely be identified as lost.\n\nNote: This bug is only visible when Ack Ratio \u003e 1, since otherwise the run\n lengths of Ack Vectors are 0.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "6d57b43bf810cd66ccf252c04ba65c3e8e56cbb1", "tree": "cd3ed95ee320ce230ce1c94f5fed52af4df4c452", "parents": [ "e333b3edc489151afda2a4f6c798842c64cb67a4" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Nov 21 10:11:52 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:46 2008 -0800" }, "message": "[DCCP]: Remove redundant dependency on IP_DCCP\n\nThis cleans up the consequences of an earlier patch which\nintroduced the `if IP_DCCP\u0027 clause into net/dccp/Kconfig.\n\nThe CCID Kconfig menu is sourced within this clause; as a\nconsequence, all tests of type `depends on IP_DCCP\u0027 are now\nredundant.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "e333b3edc489151afda2a4f6c798842c64cb67a4", "tree": "b392052fe3a4c8cdc4d0026709d1b9cd5e215921", "parents": [ "ebe6f7e73c3efec1de295205806b4550fcb468cd" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Nov 21 10:09:56 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:46 2008 -0800" }, "message": "[DCCP]: Promote CCID2 as default CCID\n\nThis patch addresses the following problems:\n\n 1. DCCP relies for its proper functioning on having at least one CCID module\n enabled (as in TCP plugable congestion control). Currently it is possible to\n disable both CCIDs and thus leave the DCCP module in a compiled, but entirely\n non-functional state: no sockets can be created when no CCID is available.\n Furthermore, the protocol is (again like TCP) not intended to be used without\n CCIDs. Last, a non-empty CCID list is needed for doing CCID feature negotiation.\n\n 2. Internally the default CCID that is advertised by the Linux host is set to CCID2\n (DCCPF_INITIAL_CCID in include/linux/dccp.h). Disabling CCID2 in the Kconfig\n menu without changing the defaults leads to a failure `module not found\u0027 when\n trying to load the dccp module (which internally tries to load the default CCID).\n\n 3. The specification (RFC 4340, sec. 10) treats CCID2 somewhat like a\n `minimum common denominator\u0027; the specification says that:\n\n * \"New connections start with CCID 2 for both endpoints\"\n\n * \"A DCCP implementation intended for general use, such as an implementation in a\n general-purpose operating system kernel, SHOULD implement at least CCID 2.\n The intent is to make CCID 2 broadly available for interoperability [...]\"\n\n Providing CCID2 as minimum-required CCID (like Reno/Cubic in TCP) thus seems reasonable.\n\nHence this patch automatically selects CCID2 when DCCP is enabled. Documentation also added.\n\nDiscussions with Ian McDonald on this subject are gratefully acknowledged.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "c3ada46a009001e144b29736880962f24ee2afdf", "tree": "a475095e2ef5bff2f0d94a24ca94776578fe1c75", "parents": [ "a5358fdc9c52e44d79dcd144375e089e166508d7" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Nov 20 18:09:59 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:43 2008 -0800" }, "message": "[CCID3]: Inline for moving average\n\nThe moving average computation occurs so frequently in the CCID 3 code that\nit merits an inline function of its own. This is uses a suggestion by\nArnaldo as per http://www.mail-archive.com/dccp@vger.kernel.org/msg01662.html\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "a5358fdc9c52e44d79dcd144375e089e166508d7", "tree": "ddd84d7a6115700ff93f24d367d59c8ad03a9adc", "parents": [ "eb279b79c46be767ecffadaa8ed6be3e3555e93d" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Nov 20 18:01:59 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:42 2008 -0800" }, "message": "[CCID3]: Accurately determine idle \u0026 application-limited periods\n\nThis fixes/updates the handling of idle and application-limited periods in CCID3,\nwhich currently is broken: there is no detection as to how long a sender has been\nidle - there is only one flag which is toggled in between function calls.\n\nBeing obsolete now, the `idle\u0027 flag is removed.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "eb279b79c46be767ecffadaa8ed6be3e3555e93d", "tree": "f7695df96e2d129beb65263617ac7ed533e1689a", "parents": [ "6c08b2cf4843788e66a5e69b5512538e686ae3e3" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Nov 20 18:00:39 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:42 2008 -0800" }, "message": "[CCID3]: Ignore trivial amounts of elapsed time\n\nThis patch fixes a previously undiscovered bug; the problem is in computing\nthe elapsed time as the time between `receiving\u0027 the packet (i.e. skb enters\nCCID module) and sending feedback:\n\n - there is no layer-processing, queueing, or delay involved,\n - hence the elapsed time is in the order of 1 function call\n - this is in the dimension of maximally 50..100usec\n - which renders the use of elapsed time almost entirely useless.\n\nThe fix is simply to ignore such trivial amounts of elapsed time.\n\nAs a further advantage, the now useless elapsed_time field can be removed from\nthe socket, which reduces the socket structure by another four bytes.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "6c08b2cf4843788e66a5e69b5512538e686ae3e3", "tree": "ec4ddefc1600d0fed860670e4d1457632d37b1f1", "parents": [ "ebb53d75657f86587ac8cf3e38ab0c860a8e3d4f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Nov 20 17:33:17 2007 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:54:41 2008 -0800" }, "message": "[CCID3]: Revert use of MSS instead of s\n\nThis updates the CCID3 code with regard to two instances of using `MSS\u0027 in place of `s\u0027:\n\n 1. The RFC3390-based initial rate: both rfc3448bis as well as the Faster Restart\n draft now consistently use `s\u0027 instead of MSS.\n\n 2. Now agrees with section 4.2 of rfc3448bis: \"If the sender is ready to send data when\n it does not yet have a round trip sample, the value of X is set to s bytes per\n second, for segment size s [...]\"\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "b24b8a247ff65c01b252025926fe564209fae4fc", "tree": "8a9e0ea1e24b4733d8b9433d41877659505e9da4", "parents": [ "a92aa318b4b369091fd80433c80e62838db8bc1c" ], "author": { "name": "Pavel Emelyanov", "email": "xemul@openvz.org", "time": "Wed Jan 23 21:20:07 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Jan 28 14:53:35 2008 -0800" }, "message": "[NET]: Convert init_timer into setup_timer\n\nMany-many code in the kernel initialized the timer-\u003efunction\nand timer-\u003edata together with calling init_timer(timer). There\nis already a helper for this. Use it for networking code.\n\nThe patch is HUGE, but makes the code 130 lines shorter\n(98 insertions(+), 228 deletions(-)).\n\nSigned-off-by: Pavel Emelyanov \u003cxemul@openvz.org\u003e\nAcked-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "5e8e034cc5154abd639aa5c05d13e24e535c6a9c", "tree": "4d28c765f9fc0a6e909038339f2f13388be6673c", "parents": [ "f4ab2f72e9340207ae95e2a7622a74220a61f46a" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Dec 20 13:59:39 2007 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Thu Dec 20 13:59:39 2007 -0800" }, "message": "[DCCP]: Spelling fixes\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "4756daa3b63e806d8ef093c8b4b5f56ee34250a2", "tree": "55a3d11dfd4615f02142aa3e94123e77db4797a2", "parents": [ "5487796f0c9475586277a0a7a91211ce5746fa6a" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Nov 19 23:46:02 2007 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Nov 19 23:46:02 2007 -0800" }, "message": "[DCCP]: Add missing \"space\"\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "24c667db59a9cc4caaafe4f77f6f4ef85899a454", "tree": "9470e271eb74375c79aad804d7400644e3762cca", "parents": [ "76fd1e87d9456c8185b8df76ac5e533e0c8b39bb" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Oct 24 10:53:01 2007 -0200" }, "committer": { "name": "Arnaldo Carvalho de Melo", "email": "acme@ghostprotocols.net", "time": "Wed Oct 24 10:53:01 2007 -0200" }, "message": "[CCID2/3]: Initialisation assignments of 0 are redundant\n\nAssigning initial values of `0\u0027 is redundant when loading a new CCID structure,\nsince in net/dccp/ccid.c the entire CCID structure is zeroed out prior to\ninitialisation in ccid_new():\n\n \tstruct ccid {\n \t\tstruct ccid_operations *ccid_ops;\n \t\tchar\t\t ccid_priv[0];\n \t};\n\n \t// ...\n \tif (rx) {\n \t\tmemset(ccid + 1, 0, ccid_ops-\u003eccid_hc_rx_obj_size);\n \t\tif (ccid-\u003eccid_ops-\u003eccid_hc_rx_init !\u003d NULL \u0026\u0026\n \t\t ccid-\u003eccid_ops-\u003eccid_hc_rx_init(ccid, sk) !\u003d 0)\n \t\t\tgoto out_free_ccid;\n \t} else {\n \t\tmemset(ccid + 1, 0, ccid_ops-\u003eccid_hc_tx_obj_size);\n \t\t/* analogous to the rx case */\n \t}\n\nThis patch therefore removes the redundant assignments. Thanks to Arnaldo for\nthe inspiration.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\n" }, { "commit": "76fd1e87d9456c8185b8df76ac5e533e0c8b39bb", "tree": "2706975f5e479de467afd959d68866dd12bbb363", "parents": [ "d8ef2c29a0dcfccb2d90cac990143d1a4668708a" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Oct 24 10:46:58 2007 -0200" }, "committer": { "name": "Arnaldo Carvalho de Melo", "email": "acme@ghostprotocols.net", "time": "Wed Oct 24 10:46:58 2007 -0200" }, "message": "[DCCP]: Unaligned pointer access\n\nThis fixes `unaligned (read) access\u0027 errors of the type\n\nKernel unaligned access at TPC[100f970c] dccp_parse_options+0x4f4/0x7e0 [dccp]\nKernel unaligned access at TPC[1011f2e4] ccid3_hc_tx_parse_options+0x1ac/0x380 [dccp_ccid3]\nKernel unaligned access at TPC[100f9898] dccp_parse_options+0x680/0x880 [dccp]\n\nby using the get_unaligned macro for parsing options.\n\nCommiter note: Preserved the sparse __be{16,32} annotations.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\n" }, { "commit": "5e28599a6e45eb8ce7e50510b06c3a34ebf1a8fa", "tree": "ff6a34c677f1c16a5fd0921f75fbe58a1568ca6e", "parents": [ "6c583248083c30c5305ec561e79f666ca465b376" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Oct 04 14:43:09 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:54:35 2007 -0700" }, "message": "[CCID2]: Sequence number wraparound issues\n\nThis replaces several uses of standard arithmetic with the DCCP\nsequence number arithmetic functions. The problem here is that the\nsequence number wrap-around was not taken into consideration.\n\n * Condition \"seqp-\u003eccid2s_seq \u003c\u003d prev-\u003eccid2s_seq\" has been replaced\n by\n\n \tdccp_delta_seqno(seqp-\u003eccid2s_seq, prev-\u003eccid2s_seq) \u003e\u003d 0\n\n since if seqp is `before\u0027 prev, then the delta_seqno() is positive.\n\n * The test whether sequence numbers `a\u0027 and `b\u0027 are consecutive has\n the form\n\n \tdccp_delta_seqno(a, b) \u003d\u003d 1\n\n * Increment of ccid2hctx_rpseq could be done using dccp_inc_seqno(),\n but since here the incremented ccid2hctx_rpseq \u003d\u003d seqno, used\n assignment instead.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "6c583248083c30c5305ec561e79f666ca465b376", "tree": "b23e2787e6ce0208395aa7b879b924470592c8e3", "parents": [ "ee196c2186d24d82088c94962598470e5abc081f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Oct 04 14:42:19 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:54:35 2007 -0700" }, "message": "[CCID2]: Remove redundant case block\n\nskb\u0027s passed to ccid2_hc_tx_send_packet() are headerless, the packet\ntype is decided later, in dccp_write_xmit(). Therefore the first test\nof the switch/case block is always true, the others are never reached.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "ee196c2186d24d82088c94962598470e5abc081f", "tree": "18d6f4382ae847c9e6091de8f766eb2918f11a99", "parents": [ "7d9e8931f93683e575679e41f188d3b465269f08" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Oct 04 14:41:55 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:54:34 2007 -0700" }, "message": "[CCID2]: Remove redundant BUG_ON\n\nThis removes a test for `val \u003c 1\u0027 which would only have been triggered\nwhen val \u003c 0, due to a preceding test for 0. Fixed by using an\nunsigned type for cwnd (as in TCP) instead.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "7d9e8931f93683e575679e41f188d3b465269f08", "tree": "6ce6b1c15dae53beedf3330d1500a44be86f842d", "parents": [ "cd1f7d347c9e51f348119811bd41b74346ec57b8" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Oct 04 14:41:26 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:54:34 2007 -0700" }, "message": "[CCID2]: Remove ugly BUG_ON\n\nThis removes an ugly BUG_ON which has been pointed out by Arnaldo.\n\nInstead of freezing up the machine, a `critical\u0027 message is now issued\nto the system log.\n\nThere is potential of doing this more gracefully (eg. there are a few\ninternal variables which could be updated despite the lack of memory),\nbut that requires more complicated changes to the algorithm; thus a\n`FIXME\u0027 has been added.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "cd1f7d347c9e51f348119811bd41b74346ec57b8", "tree": "1c444753fb2587fbeaeb2679facbeff03903f8b3", "parents": [ "126acd5bf769fcb80e38a5360ad12b842d6d29d4" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Oct 04 14:41:00 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:54:33 2007 -0700" }, "message": "[CCID2]: Simplify interface\n\nThis patch simplifies the interface of ccid2_hc_tx_alloc_seq():\n\n * ccid2_hc_tx_alloc_seq() is always called with an argument of\n CCID2_SEQBUF_LEN;\n\n * other code - ccid2_hc_tx_check_sanity() - even depends on the\n assumption that ccid2_hc_tx_alloc_seq() has been called with this\n particular size;\n\n * passing the `gfp_t\u0027 argument to ccid2_hc_tx_alloc_seq() is\n redundant with gfp_any().\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "042d18f9f39a51716683b4e156fbee689314bb22", "tree": "63038a347f9a9321c5c671cff606b71186b5f967", "parents": [ "7c559a9e44ee61faf2f339604ce708decb345a93" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Oct 04 14:39:53 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:54:32 2007 -0700" }, "message": "[DCCP]: Make all `debug\u0027 parameters bool\n\nThis just sets the parameter to bool, since debugging messages are\neither on or off.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "bb293e6a24cc2031f74775d95925e003e7250232", "tree": "aac9c26203189543a0818e3ec11c7be8df7133ac", "parents": [ "cecd8d0ec4cb4fec728f67163bb0a78f80c292eb" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@ghostprotocols.net", "time": "Wed Sep 26 19:38:55 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:52:45 2007 -0700" }, "message": "[CCID3]: Remove ifdef surrounding BUG_ON\n\nAs suggested by DaveM.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\n" }, { "commit": "2e86908f7dfb71b67ca4739d9a6c678b83b01078", "tree": "34000d4935057601e86b448698ff5fa55910b852", "parents": [ "08831700cc65f85a497d6b32b1c83ca84d71de4a" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Sep 26 11:24:28 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:52:41 2007 -0700" }, "message": "[CCID3]: Move NULL-protection into function\n\nThis moves several instances of testing against NULL into the function which is\nused to de-reference the CCID-private data.\n\nCommitter note: Made the BUG_ON depend on having CONFIG_IP_DCCP_CCID3_DEBUG, as it\n is too much to have this on production code. Also made sure that\n the macro is used only after checking if sk_state is not LISTEN,\n to make it equivalent to what we had before.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\n" }, { "commit": "3393da8241ae3a53e183ba15f8bd822995ec97cd", "tree": "28e6d2823d901976844982319e4c53b76a55967c", "parents": [ "4c70f383e0c0273c4092c4efdb414be0966978b7" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Sep 25 22:40:44 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:52:35 2007 -0700" }, "message": "[DCCP]: Simplify interface of dccp_sample_rtt\n\nThe third parameter of dccp_sample_rtt now becomes useless and is removed.\n\nAlso combined the subtraction of the timestamp echo and the elapsed time.\nThis is safe, since (a) presence of timestamp echo is tested first and (b)\nelapsed time is either present and non-zero or it is not set and equals 0\ndue to the memset in dccp_parse_options.\n\nTo avoid measuring option-processing time, the timestamp for measuring the\ninitial Request/Response RTT sample is taken directly when the function is\ncalled (the Linux implementation always adds a timestamp on the Request,\nso there is no loss in doing this).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "aa97efd97acefb7d3dcd864adb878c7ce34061b3", "tree": "1cad4e0193364c6b601c1ebc2ec8bc4aa8f600ae", "parents": [ "e0eb68596232788bc352368f2fbc3cb088e42e41" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Sep 25 22:39:16 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:52:34 2007 -0700" }, "message": "[DCCP]: Reuse ktime_get_real() calls again\n\nThis patch reduces the number of timestamps taken in the receive path\nfor each packet.\n\nThe ccid3_hc_tx_update_x() routine is called in\n * the receive path for each CCID3-controlled packet\n * for the nofeedback timer (if no feedback arrives during 4 RTT)\n\nCurrently, when there is no loss, each packet gets timestamped twice.\nThe patch resolves this by recycling the first timestamp taken on packet\nreception for RTT sampling.\n\nWhen the no_feedback_timer() is called, then the timestamp argument is\nsimply set to NULL - so that ccid3_hc_tx_update_x() takes care of the logic.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "0740d49c2465bdd2644455c4bc49794395b73433", "tree": "2c8e2ef42b4b6d78730561f01b3607ca08888cd2", "parents": [ "e7c2335794b949292ecfd01902c429e2ac3937e1" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@ghostprotocols.net", "time": "Sun Aug 19 17:18:13 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:48:15 2007 -0700" }, "message": "[DCCP] packet_history: Convert dccphtx_tstamp to ktime_t\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "e7c2335794b949292ecfd01902c429e2ac3937e1", "tree": "1e10116e6635e1b4c1da7890817fd89d6eab285d", "parents": [ "b8bda9d70842dab7902f0681e1297dcf0460fc94" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@ghostprotocols.net", "time": "Sun Aug 19 17:17:51 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:48:14 2007 -0700" }, "message": "[DCCP] packet_history: convert dccphrx_tstamp to ktime_t\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "668348a4232d3dd0ee48b3dc13228b5a7eb57565", "tree": "901c41d72c9202a503333acf854d761cb6121e6e", "parents": [ "9823b7b5542858afe5b6a1e2df83b3847c28f3d6" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@ghostprotocols.net", "time": "Sun Aug 19 17:17:02 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:48:13 2007 -0700" }, "message": "[DCCP] CCID3: Stop using dccp_timestamp\n\nNow to convert the ackvec code to ktime_t so that we can get rid of\ndccp_timestamp and the epoch thing in dccp_sock.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "9823b7b5542858afe5b6a1e2df83b3847c28f3d6", "tree": "14be62612143fbcec66cd1b28a1d76564c578453", "parents": [ "a272378d1128d1c60a463a315646c86d174ff74c" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@ghostprotocols.net", "time": "Sun Aug 19 17:16:35 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:48:13 2007 -0700" }, "message": "[DCCP]: Convert dccp_sample_rtt to ktime_t\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "e7a81c6d62cbefdeb23d92ad891f429bde1c49d2", "tree": "a0261c00db634bb307ee9e5a583c371307ec905d", "parents": [ "1faf0a1f5d9cafe031b8faa91636b67cdca726a3" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@ghostprotocols.net", "time": "Sun Aug 19 17:15:37 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:48:12 2007 -0700" }, "message": "[DCCP]: Convert ccid3hcrx_tstamp_last_feedback to ktime_t\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "1faf0a1f5d9cafe031b8faa91636b67cdca726a3", "tree": "0bff5703afba827e3abe6c3ba713d3cd179ed84d", "parents": [ "23f062af6e90654ef939462c2c060ad103dec6f2" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@ghostprotocols.net", "time": "Sun Aug 19 17:15:13 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:48:11 2007 -0700" }, "message": "[DCCP]: Convert ccid3hcrx_tstamp_last_ack to ktime_t\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "23f062af6e90654ef939462c2c060ad103dec6f2", "tree": "d4583cbd5cae080cff0b9af699e375f2e5c1e892", "parents": [ "ac198ea8d94a46830080372a539420cf4a8de4a3" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@ghostprotocols.net", "time": "Sun Aug 19 17:14:52 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:48:11 2007 -0700" }, "message": "[DCCP]: Convert ccid3hctx_t_ld to ktime_t\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "ac198ea8d94a46830080372a539420cf4a8de4a3", "tree": "c7d78474bf451d63c93f155f4d145b69f3b4371c", "parents": [ "4d93df0abd50b9c9e2d4561439a1a1d21ec5e68f" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@ghostprotocols.net", "time": "Sun Aug 19 17:14:27 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Oct 10 16:48:10 2007 -0700" }, "message": "[DCCP]: Make ccid3_hc_tx_update_x get a timestamp if needed\n\nThe code was too complicated, if p \u003e 0 in ccid3_hc_tx_no_feedback_timer the\ntimestamp was being obtained to be passed to ccid3_hc_tx_update_x, where only\nif p \u003e 0 the timestamp was needed, so just leave it to ccid3_hc_tx_update_x to\nobtain the timestamp if needed.\n\nThis will help in the upcoming changesets where we\u0027ll convert t_ld to ktime_t.\nWe\u0027ll eventually try to reuse ktime_get_real() calls again.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "39dad26c37fdb1382e4173172a2704fa278f7fd6", "tree": "3c53ca38e7879b309e0e93b3106987afd885a18f", "parents": [ "cb00e99c0abd844b884c64c6b54aa3b7d345ebb1" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Aug 19 17:12:50 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Aug 21 20:58:06 2007 -0700" }, "message": "[DCCP]: Allocation in atomic context\n\nThis fixes the following bug reported in syslog:\n\n[ 4039.051658] BUG: sleeping function called from invalid context at /usr/src/davem-2.6/mm/slab.c:3032\n[ 4039.051668] in_atomic():1, irqs_disabled():0\n[ 4039.051670] INFO: lockdep is turned off.\n[ 4039.051674] [\u003cc0104c0f\u003e] show_trace_log_lvl+0x1a/0x30\n[ 4039.051687] [\u003cc0104d4d\u003e] show_trace+0x12/0x14\n[ 4039.051691] [\u003cc0104d65\u003e] dump_stack+0x16/0x18\n[ 4039.051695] [\u003cc011371e\u003e] __might_sleep+0xaf/0xbe\n[ 4039.051700] [\u003cc0157b66\u003e] __kmalloc+0xb1/0xd0\n[ 4039.051706] [\u003cf090416f\u003e] ccid2_hc_tx_alloc_seq+0x35/0xc3 [dccp_ccid2]\n[ 4039.051717] [\u003cf09048d6\u003e] ccid2_hc_tx_packet_sent+0x27f/0x2d9 [dccp_ccid2]\n[ 4039.051723] [\u003cf085486b\u003e] dccp_write_xmit+0x1eb/0x338 [dccp]\n[ 4039.051741] [\u003cf085603d\u003e] dccp_sendmsg+0x113/0x18f [dccp]\n[ 4039.051750] [\u003cc03907fc\u003e] inet_sendmsg+0x2e/0x4c\n[ 4039.051758] [\u003cc033a47d\u003e] sock_aio_write+0xd5/0x107\n[ 4039.051766] [\u003cc015abc1\u003e] do_sync_write+0xcd/0x11c\n[ 4039.051772] [\u003cc015b296\u003e] vfs_write+0x118/0x11f\n[ 4039.051840] [\u003cc015b932\u003e] sys_write+0x3d/0x64\n[ 4039.051845] [\u003cc0103e7c\u003e] syscall_call+0x7/0xb\n[ 4039.051848] \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nThe problem was that GFP_KERNEL was used; fixed by using gfp_any().\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "20c2df83d25c6a95affe6157a4c9cac4cf5ffaac", "tree": "415c4453d2b17a50abe7a3e515177e1fa337bd67", "parents": [ "64fb98fc40738ae1a98bcea9ca3145b89fb71524" ], "author": { "name": "Paul Mundt", "email": "lethal@linux-sh.org", "time": "Fri Jul 20 10:11:58 2007 +0900" }, "committer": { "name": "Paul Mundt", "email": "lethal@linux-sh.org", "time": "Fri Jul 20 10:11:58 2007 +0900" }, "message": "mm: Remove slab destructors from kmem_cache_create().\n\nSlab destructors were no longer supported after Christoph\u0027s\nc59def9f222d44bb7e2f0a559f2906191a0862d7 change. They\u0027ve been\nBUGs for both slab and slub, and slob never supported them\neither.\n\nThis rips out support for the dtor pointer from kmem_cache_create()\ncompletely and fixes up every single callsite in the kernel (there were\nabout 224, not including the slab allocator definitions themselves,\nor the documentation references).\n\nSigned-off-by: Paul Mundt \u003clethal@linux-sh.org\u003e\n" }, { "commit": "23248005fbe5fa32a3f6d00cdec1ecfb115d28eb", "tree": "06ff4987adb7cdebe1edbd6fe11da0f32bd16fcd", "parents": [ "40b77c943468236c6dfad3e7b94348fe70c70331" ], "author": { "name": "YOSHIFUJI Hideaki", "email": "yoshfuji@linux-ipv6.org", "time": "Thu Jul 19 10:43:28 2007 +0900" }, "committer": { "name": "YOSHIFUJI Hideaki", "email": "yoshfuji@linux-ipv6.org", "time": "Thu Jul 19 10:43:28 2007 +0900" }, "message": "[NET] DCCP: Fix whitespace errors.\n\nSigned-off-by: YOSHIFUJI Hideaki \u003cyoshfuji@linux-ipv6.org\u003e\n" }, { "commit": "4fda25a2cd7a18e0ef9f29ba3dd6f6cd9b7ca43f", "tree": "ad9e55895315b49c7bcf43a949cb07c4e0c6a8ec", "parents": [ "aa4291108f434a183207e645379414270118dccb" ], "author": { "name": "Adrian Bunk", "email": "bunk@stusta.de", "time": "Mon Jul 09 13:18:57 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:18:52 2007 -0700" }, "message": "[DCCP]: Make struct dccp_li_cachep static.\n\nSigned-off-by: Adrian Bunk \u003cbunk@stusta.de\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "49d66a70cf9fd94057aacd6055334299ab3a5eac", "tree": "2feed7f094e3b2a45b7d3a211c2a3b33c61cbfb1", "parents": [ "8132da4d412ad51c34bad11133a8f0941e2a1972" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Jun 16 13:48:50 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:15:34 2007 -0700" }, "message": "[CCID3]: Fix a bug in the send time processing\n\nccid3_hc_tx_send_packet currently returns 0 when the time difference between\ncurrent time and t_nom is less than 1000 microseconds.\n\nIn this case the packet is sent immediately; but, unlike other packets that can\nbe emitted on first attempt, it will not have its window counter updated and\nits options set as required. This is a bug.\n\nFix: Require the time difference to be at least 1000 microseconds. The\nalgorithm then converges: time differences \u003e 1000 microseconds trigger the\ntimer in dccp_write_xmit; after timer expiry this function is tried again; when\nthe time difference is less than 1000, the packet will have its options added\nand window counter updated as required.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\n" }, { "commit": "8132da4d412ad51c34bad11133a8f0941e2a1972", "tree": "9c8539609c1fce671d3b060cef98ad98e0c59fe6", "parents": [ "1e180f726a58089d15637b5495fecbad8c50c833" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sat Jun 16 13:34:02 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:15:27 2007 -0700" }, "message": "[CCID3]: Sending time: update to ktime_t\n\nThis updates the computation of t_nom and t_last_win_count to use the newer\ngettimeofday interface.\n\nCommitter note: used ktime_to_timeval to set the \u0027now\u0027 variable to t_ld in\n ccid3hctx_no_feedback_timer\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\n" }, { "commit": "dd36a9aba44e4ddbac011de2cb14a70444487303", "tree": "6a218c6b7300c8b710ecc1ea2788cad6fe2f53b1", "parents": [ "cc4d6a3a34ce3976d7d01d044f3093cddc2921c2" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Mon May 28 18:56:44 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:15:24 2007 -0700" }, "message": "loss_interval: make struct dccp_li_hist_entry private\n\nnet/dccp/ccids/lib/loss_interval.c is the only place where this struct is used.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\n" }, { "commit": "cc4d6a3a34ce3976d7d01d044f3093cddc2921c2", "tree": "ddf0a5d4aaac4661f3bb1fadd60082febc21b9ef", "parents": [ "c70b729e662a1b3ee2ef5370c1e4c9bc3ddc239f" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Mon May 28 18:53:08 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:15:23 2007 -0700" }, "message": "loss_interval: Nuke dccp_li_hist\n\nIt had just a slab cache, so, for the sake of simplicity just make\ndccp_trfc_lib module init routine create the slab cache, no need for users of\nthe lib to create a private loss_interval object.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\n" }, { "commit": "c70b729e662a1b3ee2ef5370c1e4c9bc3ddc239f", "tree": "eddbd3ddd84e5ebfc0513f8c4dbe23c9eabd8492", "parents": [ "8c281780c6f867460c84bd78d9c3885c10f00ae1" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Mon May 28 18:25:12 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:15:22 2007 -0700" }, "message": "loss_interval: Make dccp_li_hist_entry_{new,delete} private\n\nNot used outside the loss_interval code anymore.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\n" }, { "commit": "8c281780c6f867460c84bd78d9c3885c10f00ae1", "tree": "01e690f1fb96bb671dc2c730c2c5391a96931aa4", "parents": [ "cc0a910b942d11069d35f52b2c0ed0e229e2fb46" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Mon May 28 18:21:53 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:15:21 2007 -0700" }, "message": "loss_interval: unexport dccp_li_hist_interval_new\n\nNow its only used inside the loss_interval code.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\n" }, { "commit": "cc0a910b942d11069d35f52b2c0ed0e229e2fb46", "tree": "9d378b79a25b7c5f03ce9f713f00648781953dbd", "parents": [ "878ac60023c4ba11a7fbf0b1dfe07b8472c0d6ce" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Thu Jun 14 17:41:28 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:15:20 2007 -0700" }, "message": "[DCCP] loss_interval: Move ccid3_hc_rx_update_li to loss_interval\n\nRenaming it to dccp_li_update_li.\n\nAlso based on previous work by Ian McDonald.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\n" }, { "commit": "878ac60023c4ba11a7fbf0b1dfe07b8472c0d6ce", "tree": "91c32ebc926cc34906dbe2766da169d4302aff92", "parents": [ "d83258a3da1d3c7ae7b75549c8bf7ed689562c62" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Thu Jun 14 12:24:46 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:15:19 2007 -0700" }, "message": "[CCID3]: Pass ccid3_li_hist to ccid3_hc_rx_update_li\n\nNow ccid3_hc_rx_update_li is ready to be moved to\nnet/dccp/ccids/lib/loss_interval, it uses the same interface as the other\nfunctions there.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\n" }, { "commit": "d83258a3da1d3c7ae7b75549c8bf7ed689562c62", "tree": "e19e448fd411c9006e96d6add09ed56d8c5a9e4e", "parents": [ "6bc7efe8efa627077f8f65d01dbb762fc9356a2f" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Mon May 28 18:04:14 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:15:18 2007 -0700" }, "message": "Remove accesses to ccid3_hc_rx_sock in ccid3_hc_rx_{update,calc_first}_li\n\nThis is a preparatory patch for moving these loss interval functions from\nnet/dccp/ccids/ccid3.c to net/dccp/ccids/lib/loss_interval.c.\n\nBased on a patch by Ian McDonald.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\n" }, { "commit": "6bc7efe8efa627077f8f65d01dbb762fc9356a2f", "tree": "0e84e3602911a290e0d49bd5523cc2b09c479d0a", "parents": [ "e961811fcde4202ae5c3c9ce81dcfc244e8959bb" ], "author": { "name": "Ian McDonald", "email": "ian.mcdonald@jandi.co.nz", "time": "Mon May 28 16:37:45 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:15:06 2007 -0700" }, "message": "loss_interval: Fix timeval initialisation\n\nWhen compiling with EXTRA_CFLAGS\u003d-W noticed that tstamp is not initialised\ncorrectly in dccp_li_calc_first_li.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\n" }, { "commit": "b2f41ff4139c0df8d06f352acc962a62fc07a0c3", "tree": "6c099cbecccb37aafee2c0bbd2d6cfd0e1f3d5b1", "parents": [ "07b5b17e157b7018d0ca40ca0d1581a23096fb45" ], "author": { "name": "Ian McDonald", "email": "ian.mcdonald@jandi.co.nz", "time": "Mon May 28 12:23:29 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Tue Jul 10 22:15:04 2007 -0700" }, "message": "ccid3: Update copyrights\n\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\n" }, { "commit": "1b07a95a5be77dc1291de12b216f930aee04eb4f", "tree": "16778348c496625d9374db9c2395aec3e514e152", "parents": [ "cb283ead710c342d9856af8507e2a42bf5c6576c" ], "author": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed May 23 17:43:11 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Thu May 24 16:36:55 2007 -0700" }, "message": "[DCCP]: Fix build warning when debugging is disabled.\n\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "b2449fdc30ccac550344df5e60d38bb8427b109c", "tree": "e0371a1474a6d28cbb2826c2401abf2a1a7fcbcf", "parents": [ "cb8c181f288a1157bc717cc7a02412d4d1dc19bc" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Fri Apr 20 13:02:55 2007 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:28:54 2007 -0700" }, "message": "[DCCP]: Fix bug in the calculation of very low sending rates\n\nThis fixes an error in the calculation of t_ipi when X converges towards\nvery low sending rates (between 1 and 64 bytes per second).\n\nAlthough this case may not sound likely, it can be reproduced by connecting,\nhitting enter (1 byte sent) and waiting for some time, during which the\nnofeedback timer halves the sending rate until finally it reaches the region\n1..64 bytes/sec. Computing X is handled correctly (tested separately); but by\ndividing X _before_ entering the calculation of t_ipi, X becomes zero as\na result. This in turn triggers a BUG condition caught in scaled_div().\n\nFixed by replacing with equivalent statement and explicit typecast for good\nmeasure.\n\nCalculation verified and effect of patch tested - reduced never below 1 byte\nper 64 seconds afterwards, i.e. not allowing divide-by-zero.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@ghostprotocols.net\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "30833ffead66e1f0052150a51db0b45151189ac1", "tree": "2fcd4907a8d6295455c686e54aa6d02fa9533934", "parents": [ "89560b53b92a07c529e13a462aa7fd87a844f1f5" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Mar 20 15:31:56 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:27:04 2007 -0700" }, "message": "[CCID3]: Use initial RTT sample from SYN exchange\n\nThe patch follows the following recommendation made in an erratum to RFC 4342:\n\n \"Senders MAY additionally make use of other available RTT measurements,\n including those from the initial Request-Response packet exchange.\"\n\nIt implements larger initial windows with regard to this inital RTT measurement,\nusing the mechanism suggested in draft-ietf-dccp-rfc3448bis, section 4.2.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "7dfee1a9c07f80a82aa5fbad340146f2b5c794b4", "tree": "e59036f22f10b1fa8527537158a435d86f82f048", "parents": [ "4712a792ee661921374c163eb6a4d06e33fd305f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Mar 20 15:24:37 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:27:01 2007 -0700" }, "message": "[CCID3]: Use function for RTT sampling\n\nThis replaces the existing occurrences of RTT sampling with\nthe use of the new function dccp_sample_rtt.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "0c150efb280986db7958cf2a559b91d826241e59", "tree": "f74291b4ea523ad2461192f680b892d2e19f2652", "parents": [ "a21f9f96cd035b0d9aec32d80ea0152672fbed42" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Mar 20 15:19:07 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:26:59 2007 -0700" }, "message": "[CCID3]: Handle Idle and Application-Limited periods\n\nThis updates the code with regard to handling idle and application-limited\nperiods as specified in [RFC 4342, 5.1].\n\nBackground:\n" }, { "commit": "a21f9f96cd035b0d9aec32d80ea0152672fbed42", "tree": "fa868d6bc48b46eae10ed864e74bb9f790579dfc", "parents": [ "1761f7d7fea32c2290710f5c0afa0c3d93220593" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Mar 20 15:12:10 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:26:58 2007 -0700" }, "message": "[CCID3]: Wrap computation of RFC3390-initial rate into separate function\n\nThe CCID 3 and TFRC specs (RFC 4342, RFC 3448, draft-3448bis) make frequent\nreference to the computation of the RFC-3390 initial sending rate:\n\n 1. Initial sending rate when RTT is known (RFC 4342, p. 6)\n 2. Response to Idle/Application-Limited periods (RFC 4342, 5.1)\n\nThis warrants putting the code into its own function, for later code reuse.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "1761f7d7fea32c2290710f5c0afa0c3d93220593", "tree": "834c1eefb9e75ea708be860ec372b0554b550614", "parents": [ "fddc2feb94c1f734dc27d44d166e97ab2e005ec1" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Mar 20 15:04:30 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:26:57 2007 -0700" }, "message": "[CCID3]: Remove build warnings for 64bit\n\nThis clears the following sparc64 build warnings:\n 1) warning: format \"%ld\" expects type \"long int\", but argument 3 has type \"suseconds_t\"\n 2) warning: format \"%llu\" expects type \"long long unsigned int\", but argument 3 has type \"__u64\"\nFixed by using typecast to unsigned. This is argued to be safe, since the quantities, after\nde-scaling (factor 2^6) fit all in u32.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "1266adee12d25385a25e1c57b1e3ff05a90bb4d7", "tree": "eb42be8ede3ca9d5ac00076ebee20be5771c30ee", "parents": [ "8699be7d240e37c91a84bdf32e79941d72bc7bd5" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Mar 20 14:56:11 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:26:52 2007 -0700" }, "message": "[CCID3]: Remove race condition and update t_ipi when `s\u0027 changes\n\nThis:\n\n 1. removes a race condition in the access to the scheduled send time t_nom which\n results from allowing asynchronous r/w access to t_nom without locks;\n\n 2. updates the inter-packet interval t_ipi \u003d s/X when `s\u0027 changes, following a\n suggestion by Ian McDonald.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "8699be7d240e37c91a84bdf32e79941d72bc7bd5", "tree": "cad4d9eb3b408899b7476ce9abc7de93b167ce87", "parents": [ "551dc5f7a11cfb66685bfd36cbbdb209c5a11d14" ], "author": { "name": "Ian McDonald", "email": "ian.mcdonald@jandi.co.nz", "time": "Tue Mar 20 14:49:20 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:26:51 2007 -0700" }, "message": "[CCID3]: More verbose debugging\n\nThis adds a few debugging statements to ccid3.c\n\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "551dc5f7a11cfb66685bfd36cbbdb209c5a11d14", "tree": "54fe446ac294e4bbe8229bb5dc9921e84a468916", "parents": [ "371fe7779cad6557a58df9a1b5543652e067400f" ], "author": { "name": "Ian McDonald", "email": "ian.mcdonald@jandi.co.nz", "time": "Tue Mar 20 14:46:52 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:26:50 2007 -0700" }, "message": "[CCID3]: Fix use of invalid loss intervals\n\nThis fixes a bug which uses an invalid comparison.\nThe bug resulted in the use of invalid loss intervals.\n\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nAcked-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "371fe7779cad6557a58df9a1b5543652e067400f", "tree": "037be0b166906ff91f2b4a7c7d11a01180a0db61", "parents": [ "9bf17475eb658a920125bd8f05edf9c57c2dd950" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Mar 20 14:28:44 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:26:49 2007 -0700" }, "message": "[CCID3]: Use MSS for larger initial windows\n\nThis improves the slow-start phase by using the MSS\n(as suggested in RFC 4342, sec. 5) instead of the packet size s.\nAlso figured out that __u32 is ample resource enough.\n\nAfter applying, I got the following in the logs:\n\n ccid3_hc_tx_packet_recv: client(f7421700), s\u003d6, MSS\u003d1424, w_init\u003d4380, R_sample\u003d176us, X\u003d24886363\n\nHad the previous variant been used, w_init would have been as low as 24.\n\nCommitter note: removed unneeded cast to unsigned long long that was\n causing a compiler warning on 64bit architectures.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "9bf17475eb658a920125bd8f05edf9c57c2dd950", "tree": "2e3e66c47ad4326771118397ed52d0231b503595", "parents": [ "353b13e10a3f1a18c6b33858fb3337bcd2692eb5" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Mar 20 13:11:24 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:26:48 2007 -0700" }, "message": "[CCID3]: Re-order CCID 3 source file\n\nNo code change at all.\nThis splits ccid3.c into a RX and a TX section, so that the file has an\norganisation similar to the other ones (e.g. packet_history.{h,c}).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "353b13e10a3f1a18c6b33858fb3337bcd2692eb5", "tree": "de428797382777f58a30648a64296825f03cd8a5", "parents": [ "8d13bf9a0bd4984756e234ce54299b92acefab99" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Mar 20 13:10:15 2007 -0300" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Apr 25 22:26:47 2007 -0700" }, "message": "[CCID3]: Remove redundant `len\u0027 test\n\nSince CCID3 avoids sending 0-byte data packets (cf. ccid3_hc_tx_send_packet),\ntesting for zero-payload length, as performed by ccid3_hc_tx_update_s, is\nredundant - hence removed by this patch.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "151a99317ee9efcfd3e642da62e1edf4f47fcb3e", "tree": "8abf1427c3e25fc7ec6d48c863a4a2cf33ddc004", "parents": [ "286930797d74b2c9a5beae84836044f6a836235f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Mar 07 12:53:48 2007 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Mar 07 16:08:07 2007 -0800" }, "message": "[DCCP]: Revert patch which disables bidirectional mode\n\nThis reverts an earlier patch which disabled bidirectional mode, meaning that\na listening (passive) socket was not allowed to write to the other (active)\nend of the connection.\n\nThis mode had been disabled when there were problems with CCID3, but it\nimposes a constraint on socket programming and thus hinders deployment.\n\nA change is included to ignore RX feedback received by the TX CCID3 module.\n\nMany thanks to Andre Noll for pointing out this issue.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "c9eaf17341834de00351bf79f16b2d879c8aea96", "tree": "d8b2005197444fa6b6bdf8e8c8fd6eaf2db9ecd7", "parents": [ "4ec93edb14fe5fdee9fae6335f2cbba204627eac" ], "author": { "name": "YOSHIFUJI Hideaki", "email": "yoshfuji@linux-ipv6.org", "time": "Fri Feb 09 23:24:38 2007 +0900" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Sat Feb 10 23:19:27 2007 -0800" }, "message": "[NET] DCCP: Fix whitespace errors.\n\nSigned-off-by: YOSHIFUJI Hideaki \u003cyoshfuji@linux-ipv6.org\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "0f08461ebf89e10f7db9042fb028359b810c3c81", "tree": "3a8bdeebfd307483d3a6ab094a770449112b4135", "parents": [ "919afbd68863550665b328a78107bc2919c5e3f4" ], "author": { "name": "Andrew Morton", "email": "akpm@linux-foundation.org", "time": "Mon Feb 05 18:18:21 2007 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Thu Feb 08 12:38:56 2007 -0800" }, "message": "[DCCP]: Warning fixes.\n\nnet/dccp/ccids/ccid3.c: In function `ccid3_hc_rx_packet_recv\u0027:\nnet/dccp/ccids/ccid3.c:1007: warning: long int format, different type arg (arg 3)\nnet/dccp/ccids/ccid3.c:1007: warning: long int format, different type arg (arg 4)\n\nopaque types must be suitably cast for printing.\n\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "832e3ca62d6ee1893db05f5202c24ae5331e19ba", "tree": "c6cf0507bd9a4e48363748b0a2f2c89ad40ab6ab", "parents": [ "e1b4b9f3986b80d5785d91dbd8d72cfaf9fd1117" ], "author": { "name": "Ian McDonald", "email": "ian.mcdonald@jandi.co.nz", "time": "Tue Dec 12 00:47:59 2006 -0200" }, "committer": { "name": "David S. Miller", "email": "davem@sunset.davemloft.net", "time": "Wed Dec 13 16:48:24 2006 -0800" }, "message": "[DCCP] ccid3: return value in ccid3_hc_rx_calc_first_li\n\nIn a recent patch we introduced invalid return codes which will result in the\nopposite of what is intended (i.e. send more packets in face of peculiar\nnetwork conditions).\n\nThis fixes it by returning ~0 which means not calculated as per\ndccp_li_hist_calc_i_mean.\n\nSigned-off-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@mandriva.com\u003e\n" } ], "next": "8109b02b5397ed52a32c116163a62a34f4768b26" }