)]}'
{
  "log": [
    {
      "commit": "218854af84038d828a32f061858b1902ed2beec6",
      "tree": "d5c688bc9856b3763e354619ff46ebe20edad891",
      "parents": [
        "7d98ffd8c2d1da6cec5d84eba42c4aa836a93f85"
      ],
      "author": {
        "name": "Dan Rosenberg",
        "email": "drosenberg@vsecurity.com",
        "time": "Wed Nov 17 06:37:16 2010 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Wed Nov 17 12:20:52 2010 -0800"
      },
      "message": "rds: Integer overflow in RDS cmsg handling\n\nIn rds_cmsg_rdma_args(), the user-provided args-\u003enr_local value is\nrestricted to less than UINT_MAX.  This seems to need a tighter upper\nbound, since the calculation of total iov_size can overflow, resulting\nin a small sock_kmalloc() allocation.  This would probably just result\nin walking off the heap and crashing when calling rds_rdma_pages() with\na high count value.  If it somehow doesn\u0027t crash here, then memory\ncorruption could occur soon after.\n\nSigned-off-by: Dan Rosenberg \u003cdrosenberg@vsecurity.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "d139ff0907dac9ef72fb2cf301e345bac3aec42f",
      "tree": "0ba63235a10b7640bc8b613da0d0cda220a55087",
      "parents": [
        "fc8162e3c034af743d8def435fda6396603d321f"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Thu Oct 28 15:40:59 2010 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Sat Oct 30 16:34:18 2010 -0700"
      },
      "message": "RDS: Let rds_message_alloc_sgs() return NULL\n\nEven with the previous fix, we still are reading the iovecs once\nto determine SGs needed, and then again later on. Preallocating\nspace for sg lists as part of rds_message seemed like a good idea\nbut it might be better to not do this. While working to redo that\ncode, this patch attempts to protect against userspace rewriting\nthe rds_iovec array between the first and second accesses.\n\nThe consequences of this would be either a too-small or too-large\nsg list array. Too large is not an issue. This patch changes all\ncallers of message_alloc_sgs to handle running out of preallocated\nsgs, and fail gracefully.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "fc8162e3c034af743d8def435fda6396603d321f",
      "tree": "b003a652740eb0de1fe71c634618b6666e9bae3c",
      "parents": [
        "f4a3fc03c1d73753879fb655b8cd628b29f6706b"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Thu Oct 28 15:40:58 2010 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Sat Oct 30 16:34:17 2010 -0700"
      },
      "message": "RDS: Copy rds_iovecs into kernel memory instead of rereading from userspace\n\nChange rds_rdma_pages to take a passed-in rds_iovec array instead\nof doing copy_from_user itself.\n\nChange rds_cmsg_rdma_args to copy rds_iovec array once only. This\neliminates the possibility of userspace changing it after our\nsanity checks.\n\nImplement stack-based storage for small numbers of iovecs, based\non net/socket.c, to save an alloc in the extremely common case.\n\nAlthough this patch reduces iovec copies in cmsg_rdma_args to 1,\nwe still do another one in rds_rdma_extra_size. Getting rid of\nthat one will be trickier, so it\u0027ll be a separate patch.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "f4a3fc03c1d73753879fb655b8cd628b29f6706b",
      "tree": "ad16a35e587408a396f2ab8e485428b8730fe733",
      "parents": [
        "a09f69c49b84b161ebd4dd09d3cce1b68297f1d3"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Thu Oct 28 15:40:57 2010 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Sat Oct 30 16:34:17 2010 -0700"
      },
      "message": "RDS: Clean up error handling in rds_cmsg_rdma_args\n\nWe don\u0027t need to set ret \u003d 0 at the end -- it\u0027s initialized to 0.\n\nAlso, don\u0027t increment s_send_rdma stat if we\u0027re exiting with an\nerror.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "a09f69c49b84b161ebd4dd09d3cce1b68297f1d3",
      "tree": "295290736f0a4dbbfc495e035adbbe0cafe447e4",
      "parents": [
        "1b1f693d7ad6d193862dcb1118540a030c5e761f"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Thu Oct 28 15:40:56 2010 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Sat Oct 30 16:34:16 2010 -0700"
      },
      "message": "RDS: Return -EINVAL if rds_rdma_pages returns an error\n\nrds_cmsg_rdma_args would still return success even if rds_rdma_pages\nreturned an error (or overflowed).\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "1b1f693d7ad6d193862dcb1118540a030c5e761f",
      "tree": "cf216d1bfb8a51f3df2c989dcffd5381a0e446f1",
      "parents": [
        "bdfa3d8fe123a940be121daf374581727b3b6547"
      ],
      "author": {
        "name": "Linus Torvalds",
        "email": "torvalds@linux-foundation.org",
        "time": "Thu Oct 28 15:40:55 2010 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Sat Oct 30 16:34:16 2010 -0700"
      },
      "message": "net: fix rds_iovec page count overflow\n\nAs reported by Thomas Pollet, the rdma page counting can overflow.  We\nget the rdma sizes in 64-bit unsigned entities, but then limit it to\nUINT_MAX bytes and shift them down to pages (so with a possible \"+1\" for\nan unaligned address).\n\nSo each individual page count fits comfortably in an \u0027unsigned int\u0027 (not\neven close to overflowing into signed), but as they are added up, they\nmight end up resulting in a signed return value. Which would be wrong.\n\nCatch the case of tot_pages turning negative, and return the appropriate\nerror code.\n\nReported-by: Thomas Pollet \u003cthomas.pollet@gmail.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "9b9d2e00bfa592aceda7b43da76c670df61faa97",
      "tree": "8412e35fd4e379c4075e09a8f23c245663f91e59",
      "parents": [
        "0746556beab1a57f1afb5c9d6f393d98528ce682"
      ],
      "author": {
        "name": "Dan Carpenter",
        "email": "error27@gmail.com",
        "time": "Sat Sep 18 13:42:25 2010 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Sun Sep 19 11:59:43 2010 -0700"
      },
      "message": "rds: signedness bug\n\nIn the original code if the copy_from_user() fails in rds_rdma_pages()\nthen the error handling fails and we get a stack trace from kmalloc().\n\nSigned-off-by: Dan Carpenter \u003cerror27@gmail.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "20c72bd5f5f902e5a8745d51573699605bf8d21c",
      "tree": "6df337e07d423a0859ab92f25525570e134baba1",
      "parents": [
        "59f740a6aeb2cde2f79fe0df38262d4c1ef35cd8"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Aug 25 05:51:28 2010 -0700"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:16:51 2010 -0700"
      },
      "message": "RDS: Implement masked atomic operations\n\nAdd two CMSGs for masked versions of cswp and fadd. args\nstruct modified to use a union for different atomic op type\u0027s\narguments. Change IB to do masked atomic ops. Atomic op type\nin rds_message similarly unionized.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "2c3a5f9abb1dc5efdab8ba9a568b1661c65fd1e3",
      "tree": "72b6a4c5298fecf46637987fd8ae42296dc90a97",
      "parents": [
        "7e3bd65ebfd5d6cd76b8b979920c632d6e6b4b2a"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Mon Mar 01 16:10:40 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:12:06 2010 -0700"
      },
      "message": "RDS: Add flag for silent ops. Do atomic op before RDMA\n\nAdd a flag to the API so users can indicate they want\nsilent operations. This is needed because silent ops\ncannot be used with USE_ONCE MRs, so we can\u0027t just\nassume silent.\n\nAlso, change send_xmit to do atomic op before rdma op if\nboth are present, and centralize the hairy logic to determine if\nwe want to attempt silent, or not.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "7e3bd65ebfd5d6cd76b8b979920c632d6e6b4b2a",
      "tree": "eb43094639021ef9c2d587b6e386be2aa9643dbe",
      "parents": [
        "940786eb0a0faf3f30898a1cc7c1540d54c1aff6"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Mon Mar 01 16:04:59 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:12:05 2010 -0700"
      },
      "message": "RDS: Move some variables around for consistency\n\nAlso, add a comment.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "f8b3aaf2ba8ca9e27b47f8bfdff07c8b968f2c05",
      "tree": "42de574167e590ca2e413314b6486df916cd1f31",
      "parents": [
        "d0ab25a83c4a08cd98b73a37d3f4c069f7b4f50b"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Mon Mar 01 14:11:53 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:58 2010 -0700"
      },
      "message": "RDS: Remove struct rds_rdma_op\n\nA big changeset, but it\u0027s all pretty dumb.\n\nstruct rds_rdma_op was already embedded in struct rm_rdma_op.\nRemove rds_rdma_op and put its members in rm_rdma_op. Rename\nmembers with \"op_\" prefix instead of \"r_\", for consistency.\n\nOf course this breaks a lot, so fixup the code accordingly.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "d0ab25a83c4a08cd98b73a37d3f4c069f7b4f50b",
      "tree": "d21dad44f483e684c35209f61b905b53ae582050",
      "parents": [
        "4324879df06ba4db01a0b455af2d003f117e6aa3"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Jan 27 16:15:48 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:57 2010 -0700"
      },
      "message": "RDS: purge atomic resources too in rds_message_purge()\n\nAdd atomic_free_op function, analogous to rdma_free_op,\nand call it in rds_message_purge().\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "4324879df06ba4db01a0b455af2d003f117e6aa3",
      "tree": "04629863049eb51433052669541ccd300b33c74a",
      "parents": [
        "241eef3e2f51fe4ad50abacd7f79c4e2d468197e"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Jan 27 16:07:30 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:56 2010 -0700"
      },
      "message": "RDS: Inline rdma_prepare into cmsg_rdma_args\n\ncmsg_rdma_args just calls rdma_prepare and does a little\narg checking -- not quite enough to justify its existence.\nPlus, it is the only caller of rdma_prepare().\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "6200ed7799d9225f363f157ab61f1566cfd80e19",
      "tree": "2c623f0c0c28bdb3b67a911b60b07a9a7566b9f0",
      "parents": [
        "d22faec22c2ab2364fd8fc3c8159b0b5b28b0fd1"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Tue Jan 12 10:53:05 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:44 2010 -0700"
      },
      "message": "RDS: Whitespace\n\nTidy up some whitespace issues.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "d22faec22c2ab2364fd8fc3c8159b0b5b28b0fd1",
      "tree": "90a286b17b500447e413d8d6a1f119f696a06e3c",
      "parents": [
        "40589e74f7ba855f3a887c9d4abe9d100c5b039c"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Tue Jan 12 10:52:28 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:43 2010 -0700"
      },
      "message": "RDS: Do not mask address when pinning pages\n\nThis does not appear to be necessary.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "40589e74f7ba855f3a887c9d4abe9d100c5b039c",
      "tree": "f32b0414ae3cfe8868fbdb130f9b24ac19794ae3",
      "parents": [
        "15133f6e67d8d646d0744336b4daa3135452cb0d"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Tue Jan 12 10:50:48 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:42 2010 -0700"
      },
      "message": "RDS: Base init_depth and responder_resources on hw values\n\nInstead of using a constant for initiator_depth and\nresponder_resources, read the per-QP values when the\ndevice is enumerated, and then use these values when creating\nthe connection.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "15133f6e67d8d646d0744336b4daa3135452cb0d",
      "tree": "e5675d5a3ab240edc9a66af6b891dd75fa9eabae",
      "parents": [
        "a63273d4992603979ddb181b6a8f07082839b39f"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Tue Jan 12 14:33:38 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:41 2010 -0700"
      },
      "message": "RDS: Implement atomic operations\n\nImplement a CMSG-based interface to do FADD and CSWP ops.\n\nAlter send routines to handle atomic ops.\n\nAdd atomic counters to stats.\n\nAdd xmit_atomic() to struct rds_transport\n\nInline rds_ib_send_unmap_rdma into unmap_rm\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "f4dd96f7b27743e568cec519eff0f951c56833c6",
      "tree": "7190122e832f3ce6ed394fb7293c037562b346f6",
      "parents": [
        "ff87e97a9d70c9ae133d3d3d7792b26ab85f4297"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Tue Jan 12 14:17:31 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:39 2010 -0700"
      },
      "message": "RDS: make sure all sgs alloced are initialized\n\nrds_message_alloc_sgs() now returns correctly-initialized\nsg lists, so calleds need not do this themselves.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "ff87e97a9d70c9ae133d3d3d7792b26ab85f4297",
      "tree": "32de73cdf5e4353e89b3351eaae695f69faa868b",
      "parents": [
        "21f79afa5fda2820671a8f64c3d0e43bb118053b"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Tue Jan 12 14:13:15 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:38 2010 -0700"
      },
      "message": "RDS: make m_rdma_op a member of rds_message\n\nThis eliminates a separate memory alloc, although\nit is now necessary to add an \"r_active\" flag, since\nit is no longer to use the m_rdma_op pointer as an\nindicator of if an rdma op is present.\n\nrdma SGs allocated from rm sg pool.\n\nrds_rm_size also gets bigger. It\u0027s a little inefficient to\nrun through CMSGs twice, but it makes later steps a lot smoother.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "21f79afa5fda2820671a8f64c3d0e43bb118053b",
      "tree": "54029e0dbe3e4a68d579c02c5e9ed9d1fb63cfae",
      "parents": [
        "fc445084f185cdd877bec323bfe724a361e2292a"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Tue Jan 12 12:57:27 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:37 2010 -0700"
      },
      "message": "RDS: fold rdma.h into rds.h\n\nRDMA is now an intrinsic part of RDS, so it\u0027s easier to just have\na single header.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "3ef13f3c22aaea28aff383cb0883481d24885456",
      "tree": "2d7277a9401c5d47c0a42d5de3e27f1df042da6b",
      "parents": [
        "e779137aa76d38d5c33a98ed887092ae4e4f016f"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Tue Jan 12 12:37:17 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:35 2010 -0700"
      },
      "message": "RDS: cleanup/fix rds_rdma_unuse\n\nFirst, it looks to me like the atomic_inc is wrong.\nWe should be decrementing refcount only once here, no? It\u0027s\nalready being done by the mr_put() at the end.\n\nSecond, simplify the logic a bit by bailing early (with a warning)\nif !mr.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "e779137aa76d38d5c33a98ed887092ae4e4f016f",
      "tree": "af0a34f9334bd11ca507d4e63a963c561ff981ae",
      "parents": [
        "8690bfa17aea4c42da1bcf90a7af93d161eca624"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Tue Jan 12 12:15:02 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:33 2010 -0700"
      },
      "message": "RDS: break out rdma and data ops into nested structs in rds_message\n\nClearly separate rdma-related variables in rm from data-related ones.\nThis is in anticipation of adding atomic support.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "8690bfa17aea4c42da1bcf90a7af93d161eca624",
      "tree": "88c4c5fa63aab0c18cf13228c4b3a6f980aa74be",
      "parents": [
        "2dc393573430f853e56e25bf4b41c34ba2aa8fd6"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Tue Jan 12 11:56:44 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:11:32 2010 -0700"
      },
      "message": "RDS: cleanup: remove \"\u003d\u003d NULL\"s and \"!\u003d NULL\"s in ptr comparisons\n\nFavor \"if (foo)\" style over \"if (foo !\u003d NULL)\".\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "35b52c70534cb7193b218ec12efe6bc595312097",
      "tree": "8370e4b3e9d0ed1cc353f8b23531c97f8cc63ddc",
      "parents": [
        "9e2effba2c16fc3bd47da605116485afe01e0be0"
      ],
      "author": {
        "name": "Tina Yang",
        "email": "tina.yang@oracle.com",
        "time": "Thu Apr 01 14:09:00 2010 -0700"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:07:31 2010 -0700"
      },
      "message": "RDS: Fix corrupted rds_mrs\n\nOn second look at this bug (OFED #2002), it seems that the\ncollision is not with the retransmission queue (packet acked\nby the peer), but with the local send completion.  A theoretical\nsequence of events (from time t0 to t3) is thought to be as\nfollows,\n\nThread #1\nt0:\n    sock_release\n    rds_release\n    rds_send_drop_to /* wait on send completion */\nt2:\n    rds_rdma_drop_keys()   /* destroy \u0026 free all mrs */\n\nThread #2\nt1:\n    rds_ib_send_cq_comp_handler\n    rds_ib_send_unmap_rm\n    rds_message_unmapped   /* wake up #1 @ t0 */\nt3:\n    rds_message_put\n    rds_message_purge\n    rds_mr_put   /* memory corruption detected */\n\nThe problem with the rds_rdma_drop_keys() is it could\nremove a mr\u0027s refcount more than its due (i.e. repeatedly\nas long as it still remains in the tree (mr-\u003er_refcount \u003e 0)).\nTheoretically it should remove only one reference - reference\nby the tree.\n\n        /* Release any MRs associated with this socket */\n        while ((node \u003d rb_first(\u0026rs-\u003ers_rdma_keys))) {\n                mr \u003d container_of(node, struct rds_mr, r_rb_node);\n                if (mr-\u003er_trans \u003d\u003d rs-\u003ers_transport)\n                        mr-\u003er_invalidate \u003d 0;\n                rds_mr_put(mr);\n        }\n\nI think the correct way of doing it is to remove the mr from\nthe tree and rds_destroy_mr it first, then a rds_mr_put()\nto decrement its reference count by one.  Whichever thread\nholds the last reference will free the mr via rds_mr_put().\n\nSigned-off-by: Tina Yang \u003ctina.yang@oracle.com\u003e\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "9e2effba2c16fc3bd47da605116485afe01e0be0",
      "tree": "a423d21a3abee4a5979ce13f7627d81e558c32ed",
      "parents": [
        "db40980fcdb560d7992b0511df16cdd3f7e381f3"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Fri Mar 12 16:22:32 2010 -0800"
      },
      "committer": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Wed Sep 08 18:07:31 2010 -0700"
      },
      "message": "RDS: Fix BUG_ONs to not fire when in a tasklet\n\nin_interrupt() is true in softirqs. The BUG_ONs are supposed\nto check for if irqs are disabled, so we should use\nBUG_ON(irqs_disabled()) instead, duh.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\n"
    },
    {
      "commit": "871039f02f8ec4ab2e5e9010718caa8e085786f1",
      "tree": "f0d2b3127fc48c862967d68c46c2d46668137515",
      "parents": [
        "e4077e018b5ead3de9951fc01d8bf12eeeeeefed",
        "4a1032faac94ebbf647460ae3e06fc21146eb280"
      ],
      "author": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Sun Apr 11 14:53:53 2010 -0700"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Sun Apr 11 14:53:53 2010 -0700"
      },
      "message": "Merge branch \u0027master\u0027 of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6\n\nConflicts:\n\tdrivers/net/stmmac/stmmac_main.c\n\tdrivers/net/wireless/wl12xx/wl1271_cmd.c\n\tdrivers/net/wireless/wl12xx/wl1271_main.c\n\tdrivers/net/wireless/wl12xx/wl1271_spi.c\n\tnet/core/ethtool.c\n\tnet/mac80211/scan.c\n"
    },
    {
      "commit": "5a0e3ad6af8660be21ca98a971cd00f331318c05",
      "tree": "5bfb7be11a03176a87296a43ac6647975c00a1d1",
      "parents": [
        "ed391f4ebf8f701d3566423ce8f17e614cde9806"
      ],
      "author": {
        "name": "Tejun Heo",
        "email": "tj@kernel.org",
        "time": "Wed Mar 24 17:04:11 2010 +0900"
      },
      "committer": {
        "name": "Tejun Heo",
        "email": "tj@kernel.org",
        "time": "Tue Mar 30 22:02:32 2010 +0900"
      },
      "message": "include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h\n\npercpu.h is included by sched.h and module.h and thus ends up being\nincluded when building most .c files.  percpu.h includes slab.h which\nin turn includes gfp.h making everything defined by the two files\nuniversally available and complicating inclusion dependencies.\n\npercpu.h -\u003e slab.h dependency is about to be removed.  Prepare for\nthis change by updating users of gfp and slab facilities include those\nheaders directly instead of assuming availability.  As this conversion\nneeds to touch large number of source files, the following script is\nused as the basis of conversion.\n\n  http://userweb.kernel.org/~tj/misc/slabh-sweep.py\n\nThe script does the followings.\n\n* Scan files for gfp and slab usages and update includes such that\n  only the necessary includes are there.  ie. if only gfp is used,\n  gfp.h, if slab is used, slab.h.\n\n* When the script inserts a new include, it looks at the include\n  blocks and try to put the new include such that its order conforms\n  to its surrounding.  It\u0027s put in the include block which contains\n  core kernel includes, in the same order that the rest are ordered -\n  alphabetical, Christmas tree, rev-Xmas-tree or at the end if there\n  doesn\u0027t seem to be any matching order.\n\n* If the script can\u0027t find a place to put a new include (mostly\n  because the file doesn\u0027t have fitting include block), it prints out\n  an error message indicating which .h file needs to be added to the\n  file.\n\nThe conversion was done in the following steps.\n\n1. The initial automatic conversion of all .c files updated slightly\n   over 4000 files, deleting around 700 includes and adding ~480 gfp.h\n   and ~3000 slab.h inclusions.  The script emitted errors for ~400\n   files.\n\n2. Each error was manually checked.  Some didn\u0027t need the inclusion,\n   some needed manual addition while adding it to implementation .h or\n   embedding .c file was more appropriate for others.  This step added\n   inclusions to around 150 files.\n\n3. The script was run again and the output was compared to the edits\n   from #2 to make sure no file was left behind.\n\n4. Several build tests were done and a couple of problems were fixed.\n   e.g. lib/decompress_*.c used malloc/free() wrappers around slab\n   APIs requiring slab.h to be added manually.\n\n5. The script was run on all .h files but without automatically\n   editing them as sprinkling gfp.h and slab.h inclusions around .h\n   files could easily lead to inclusion dependency hell.  Most gfp.h\n   inclusion directives were ignored as stuff from gfp.h was usually\n   wildly available and often used in preprocessor macros.  Each\n   slab.h inclusion directive was examined and added manually as\n   necessary.\n\n6. percpu.h was updated not to include slab.h.\n\n7. Build test were done on the following configurations and failures\n   were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my\n   distributed build env didn\u0027t work with gcov compiles) and a few\n   more options had to be turned off depending on archs to make things\n   build (like ipr on powerpc/64 which failed due to missing writeq).\n\n   * x86 and x86_64 UP and SMP allmodconfig and a custom test config.\n   * powerpc and powerpc64 SMP allmodconfig\n   * sparc and sparc64 SMP allmodconfig\n   * ia64 SMP allmodconfig\n   * s390 SMP allmodconfig\n   * alpha SMP allmodconfig\n   * um on x86_64 SMP allmodconfig\n\n8. percpu.h modifications were reverted so that it could be applied as\n   a separate patch and serve as bisection point.\n\nGiven the fact that I had only a couple of failures from tests on step\n6, I\u0027m fairly confident about the coverage of this conversion patch.\nIf there is a breakage, it\u0027s likely to be something in one of the arch\nheaders which should be easily discoverable easily on most builds of\nthe specific arch.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nGuess-its-ok-by: Christoph Lameter \u003ccl@linux-foundation.org\u003e\nCc: Ingo Molnar \u003cmingo@redhat.com\u003e\nCc: Lee Schermerhorn \u003cLee.Schermerhorn@hp.com\u003e\n"
    },
    {
      "commit": "561c7df63e259203515509a7ad075382a42bff0c",
      "tree": "80d3d382ba155d4bced37b716dcac0e31062f2c5",
      "parents": [
        "450d06c0208ad195ccd74a7edd11321e316791ad"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Thu Mar 11 13:50:06 2010 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Tue Mar 16 21:17:01 2010 -0700"
      },
      "message": "RDS: Do not call set_page_dirty() with irqs off\n\nset_page_dirty() unconditionally re-enables interrupts, so\nif we call it with irqs off, they will be on after the call,\nand that\u0027s bad. This patch moves the call after we\u0027ve re-enabled\ninterrupts in send_drop_to(), so it\u0027s safe.\n\nAlso, add BUG_ONs to let us know if we ever do call set_page_dirty\nwith interrupts off.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "f64f9e719261a87818dd192a3a2352e5b20fbd0f",
      "tree": "b2d5cbaef3df615295f6061d8c4d6a912690556c",
      "parents": [
        "152b6a62aea2d43359dd37004e9c218bf7bdeb3b"
      ],
      "author": {
        "name": "Joe Perches",
        "email": "joe@perches.com",
        "time": "Sun Nov 29 16:55:45 2009 -0800"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Sun Nov 29 16:55:45 2009 -0800"
      },
      "message": "net: Move \u0026\u0026 and || to end of previous line\n\nNot including net/atm/\n\nCompiled tested x86 allyesconfig only\nAdded a \u003e 80 column line or two, which I ignored.\nExisting checkpatch plaints willfully, cheerfully ignored.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "244546f0d3101c5441f5b14cfe8a79d62679eaea",
      "tree": "52ba3f802e695e6b052aeb3c38ae76fb5f5f0be6",
      "parents": [
        "6639104bd826e0b1388c69a6b7564fffc636c8a8"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Fri Oct 30 08:54:53 2009 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Fri Oct 30 15:06:37 2009 -0700"
      },
      "message": "RDS: Add GET_MR_FOR_DEST sockopt\n\nRDS currently supports a GET_MR sockopt to establish a\nmemory region (MR) for a chunk of memory. However, the fastreg\nmethod ties a MR to a particular destination. The GET_MR_FOR_DEST\nsockopt allows the remote machine to be specified, and thus\nsupport for fastreg (aka FRWRs).\n\nNote that this patch does *not* do all of this - it simply\nimplements the new sockopt in terms of the old one, so applications\ncan begin to use the new sockopt in preparation for cutover to\nFRWRs.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "830eb7d56c18ff4c29acd8b0bb48db404660321f",
      "tree": "5c467f39c1627d3048c6bb08fa314b12c2ee7c03",
      "parents": [
        "49f696914100780f6bf8e652d3468de0015d6172"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Thu Apr 09 14:09:42 2009 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Thu Apr 09 17:21:20 2009 -0700"
      },
      "message": "RDS: use get_user_pages_fast()\n\nUse the new function that is simpler and faster.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "7acd4a794c1530af063e51f3f7171e75556458f3",
      "tree": "4c213f984afa23fbb704a9e94f6f754ed50bdb5d",
      "parents": [
        "7b70d0336da777c00395cc7a503497c2cdabd1a8"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Thu Apr 09 14:09:40 2009 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Thu Apr 09 17:21:18 2009 -0700"
      },
      "message": "RDS: Fix ordering in a conditional\n\nPutting the constant first is a supposed \"best practice\" that actually makes\nthe code harder to read.\n\nThanks to Roland Dreier for finding a bug in this \"simple, obviously correct\"\npatch.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    },
    {
      "commit": "eff5f53bef75c0864a5da06bb688939092b848dc",
      "tree": "116790e2c93ba3adbbce52704810569cd5517492",
      "parents": [
        "bdbe6fbc6a2f2ccfb384b141b257677d2a8d36fb"
      ],
      "author": {
        "name": "Andy Grover",
        "email": "andy.grover@oracle.com",
        "time": "Tue Feb 24 15:30:29 2009 +0000"
      },
      "committer": {
        "name": "David S. Miller",
        "email": "davem@davemloft.net",
        "time": "Thu Feb 26 23:39:29 2009 -0800"
      },
      "message": "RDS: RDMA support\n\nSome transports may support RDMA features. This handles the\nnon-transport-specific parts, like pinning user pages and\ntracking mapped regions.\n\nSigned-off-by: Andy Grover \u003candy.grover@oracle.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n"
    }
  ]
}