)]}' { "log": [ { "commit": "4dbc242ed3c94ff1cc10640d2119279ba0be943e", "tree": "d409eaa2691d192cc1088aefbfe27a8399a48159", "parents": [ "08168f7164fed494852361ab900358cd7a6b95d6" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Jan 11 00:17:22 2009 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Jan 11 00:17:22 2009 -0800" }, "message": "dccp ccid-3: Fix RFC reference\n\nThanks to Wei and Arnaldo for pointing out the correct\nnew reference for CCID-3.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "1b6725dea766b7437d885661140b6e0340d47613", "tree": "1a0122409eba1f3e3bd330a3d200e0198e2b6fdb", "parents": [ "a7ee2f73f3ce90d73736de1cf432339c35a3faf2" ], "author": { "name": "Leonardo Potenza", "email": "lpotenza@inwind.it", "time": "Fri Jan 09 23:06:28 2009 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Jan 11 00:11:28 2009 -0800" }, "message": "net: fix section mismatch warnings in dccp/ccids/lib/tfrc.c\n\nRemoved the __exit annotation of tfrc_lib_exit(), in order to suppress the following section mismatch messages:\n\nWARNING: net/dccp/dccp.o(.text+0xd9): Section mismatch in reference from the function ccid_cleanup_builtins() to the function .exit.text:tfrc_lib_exit()\nThe function ccid_cleanup_builtins() references a function in an exit section.\nOften the function tfrc_lib_exit() has valid usage outside the exit section\nand the fix is to remove the __exit annotation of tfrc_lib_exit.\n\nWARNING: net/dccp/dccp.o(.init.text+0x48): Section mismatch in reference from the function ccid_initialize_builtins() to the function .exit.text:tfrc_lib_exit()\nThe function __init ccid_initialize_builtins() references\na function __exit tfrc_lib_exit().\nThis is often seen when error handling in the init function\nuses functionality in the exit path.\nThe fix is often to remove the __exit annotation of\ntfrc_lib_exit() so it may be used outside an exit section.\n\nSigned-off-by: Leonardo Potenza \u003clpotenza@inwind.it\u003e\nAcked-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nAcked-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "129fa44785a399248ae2466b6cb5c655e96668f7", "tree": "c2440b83e752c6cf3e6ec6f60492b85ddb8932a9", "parents": [ "e5fd56ca4eb3a130882bbef69d6952ef6aca5c8d" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Jan 04 21:45:33 2009 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Jan 04 21:45:33 2009 -0800" }, "message": "dccp: Integrate the TFRC library with DCCP\n\nThis patch integrates the TFRC library, which is a dependency of CCID-3 (and\nCCID-4), with the new use of CCIDs in the DCCP module.\t\t\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "e5fd56ca4eb3a130882bbef69d6952ef6aca5c8d", "tree": "4e0c6670335f2434fbe8f44554988ca9832a685a", "parents": [ "ddebc973c56b51b4e5d84d606f0430d81b895d67" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Jan 04 21:43:23 2009 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Jan 04 21:43:23 2009 -0800" }, "message": "dccp: Clean up ccid.c after integration of CCID plugins\n\nThis patch cleans up after integrating the CCID modules and, in addition,\n\n * moves the if/else cases from ccid_delete() into ccid_hc_{tx,rx}_delete();\n * removes the \u0027gfp\u0027 argument to ccid_new() - since it is always gfp_any().\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "ddebc973c56b51b4e5d84d606f0430d81b895d67", "tree": "cebe0e4461346072b2063132fc1d9cf8c3e148f1", "parents": [ "6ea2fde13abd3444008ab5e9585f9ed249e6047e" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Jan 04 21:42:53 2009 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Jan 04 21:42:53 2009 -0800" }, "message": "dccp: Lockless integration of CCID congestion-control plugins\n\nBased on Arnaldo\u0027s earlier patch, this patch integrates the standardised\nCCID congestion control plugins (CCID-2 and CCID-3) of DCCP with dccp.ko:\n\n * enables a faster connection path by eliminating the need to always go \n through the CCID registration lock;\n\n * updates the implementation to use only a single array whose size equals\n the number of configured CCIDs instead of the maximum (256);\n\n * since the CCIDs are now fixed array elements, synchronization is no\n longer needed, simplifying use and implementation.\n\nCCID-2 is suggested as minimum for a basic DCCP implementation (RFC 4340, 10);\nCCID-3 is a standards-track CCID supported by RFC 4342 and RFC 5348.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "eb4dea5853046727bfbb579f0c9a8cae7369f7c6", "tree": "79e18d6284494ab63a890885b0eecce9431a9597", "parents": [ "0f23174aa8c1aa7a2a6050a72a60d290ef9ee578" ], "author": { "name": "Herbert Xu", "email": "herbert@gondor.apana.org.au", "time": "Mon Dec 29 23:04:08 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 29 23:04:08 2008 -0800" }, "message": "net: Fix percpu counters deadlock\n\nWhen we converted the protocol atomic counters such as the orphan\ncount and the total socket count deadlocks were introduced due to\nthe mismatch in BH status of the spots that used the percpu counter\noperations.\n\nBased on the diagnosis and patch by Peter Zijlstra, this patch\nfixes these issues by disabling BH where we may be in process\ncontext.\n\nReported-by: Jeff Kirsher \u003cjeffrey.t.kirsher@intel.com\u003e\nTested-by: Ingo Molnar \u003cmingo@elte.hu\u003e\nSigned-off-by: Herbert Xu \u003cherbert@gondor.apana.org.au\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "a693722aec4ce26fb46c21cf4bf4422484a397a7", "tree": "003b408f7473bbc9804e185f850cf6f6017e7f1d", "parents": [ "9732d523212060c44a4723332bdc5ee429eeabc3" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Wed Dec 17 16:08:01 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Wed Dec 17 16:08:01 2008 -0800" }, "message": "dccp_diag: LISTEN sockets don\u0027t have CCIDs\n\nAnd thus when we try to use \u0027ss -danemi\u0027 on these sockets that have no\nccid blocks (data collected using systemtap after I fixed the problem):\n\ndccp_diag_get_info sk\u003d0xffff8801220a3100, dp-\u003edccps_hc_rx_ccid\u003d0x0000000000000000, dp-\u003edccps_hc_tx_ccid\u003d0x0000000000000000\n\nWe get an OOPS:\n\nmica.ghostprotocols.net login: BUG: unable to handle kernel NULL pointer\ndereferenc0\nIP: [\u003cffffffffa0136082\u003e] dccp_diag_get_info+0x82/0xc0 [dccp_diag]\nPGD 12106f067 PUD 122488067 PMD 0\nOops: 0000 [#1] PREEMPT\n\nFix is trivial, and \u0027ss -d\u0027 is working again:\n\n[root@mica ~]# ss -danemi\nState Recv-Q Send-Q Local Address:Port Peer Address:Port \nLISTEN 0 0 *:5001 *:*\nino:7288 sk:220a3100ffff8801\n\t mem:(r0,w0,f0,t0) cwnd:0 ssthresh:0\n[root@mica ~]# \n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "6fdd34d43bff8be9bb925b49d87a0ee144d2ab07", "tree": "547cf602983db37d573d3d191ac11660f1698e8f", "parents": [ "4098dce5be537a157eed4a326efd464109825b8b" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 08 01:19:06 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 08 01:19:06 2008 -0800" }, "message": "dccp ccid-2: Phase out the use of boolean Ack Vector sysctl\n\nThis removes the use of the sysctl and the minisock variable for the Send Ack\nVector feature, as it now is handled fully dynamically via feature negotiation\n(i.e. when CCID-2 is enabled, Ack Vectors are automatically enabled as per\n RFC 4341, 4.).\n\nUsing a sysctl in parallel to this implementation would open the door to\ncrashes, since much of the code relies on tests of the boolean minisock /\nsysctl variable. Thus, this patch replaces all tests of type\n\n\tif (dccp_msk(sk)-\u003edccpms_send_ack_vector)\n\t\t/* ... */\nwith\n\tif (dp-\u003edccps_hc_rx_ackvec !\u003d NULL)\n\t\t/* ... */\n\nThe dccps_hc_rx_ackvec is allocated by the dccp_hdlr_ackvec() when feature\nnegotiation concluded that Ack Vectors are to be used on the half-connection.\nOtherwise, it is NULL (due to dccp_init_sock/dccp_create_openreq_child),\nso that the test is a valid one.\n\nThe activation handler for Ack Vectors is called as soon as the feature\nnegotiation has concluded at the\n * server when the Ack marking the transition RESPOND \u003d\u003e OPEN arrives;\n * client after it has sent its ACK, marking the transition REQUEST \u003d\u003e PARTOPEN.\n\nAdding the sequence number of the Response packet to the Ack Vector has been\nremoved, since\n (a) connection establishment implies that the Response has been received;\n (b) the CCIDs only look at packets received in the (PART)OPEN state, i.e.\n this entry will always be ignored;\n (c) it can not be used for anything useful - to detect loss for instance, only\n packets received after the loss can serve as pseudo-dupacks.\n\nThere was a FIXME to change the error code when dccp_ackvec_add() fails.\nI removed this after finding out that:\n * the check whether ackno \u003c ISN is already made earlier,\n * this Response is likely the 1st packet with an Ackno that the client gets,\n * so when dccp_ackvec_add() fails, the reason is likely not a packet error.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "4098dce5be537a157eed4a326efd464109825b8b", "tree": "f7116e98853d805eb874c4f2345c3cce2acbfaa7", "parents": [ "0049bab5e765aa74cf767a834fa336e19453fc5e" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 08 01:18:37 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 08 01:18:37 2008 -0800" }, "message": "dccp: Remove manual influence on NDP Count feature\n\nUpdating the NDP count feature is handled automatically now:\n * for CCID-2 it is disabled, since the code does not use NDP counts;\n * for CCID-3 it is enabled, as NDP counts are used to determine loss lengths.\n\nAllowing the user to change NDP values leads to unpredictable and failing\nbehaviour, since it is then possible to disable NDP counts even when they\nare needed (e.g. in CCID-3).\n\nThis means that only those user settings are sensible that agree with the\nvalues for Send NDP Count implied by the choice of CCID. But those settings\nare already activated by the feature negotiation (CCID dependency tracking),\nhence this form of support is redundant.\n\nAt startup the initialisation of the NDP count feature uses the default\nvalue of 0, which is done implicitly by the zeroing-out of the socket when\nit is allocated. If the choice of CCID or feature negotiation enables NDP\ncount, this will then be updated via the NDP activation handler.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "0049bab5e765aa74cf767a834fa336e19453fc5e", "tree": "f3210e13c5645dbedffe90a4b1f1dca787673bb0", "parents": [ "63b8e2861f31868dce9c92fd7444f212a5a8a775" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 08 01:18:05 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 08 01:18:05 2008 -0800" }, "message": "dccp: Remove obsolete parts of the old CCID interface\n\nThe TX/RX CCIDs of the minisock are now redundant: similar to the Ack Vector\ncase, their value equals initially that of the sysctl, but at the end of\nfeature negotiation may be something different.\n\nThe old interface removed by this patch thus has been replaced by the newer\ninterface to dynamically query the currently loaded CCIDs.\n\nAlso removed are the constructors for the TX CCID and the RX CCID, since the\nswitch \"rx \u003c-\u003e non-rx\" is done by the handler in minisocks.c (and the handler\nis the only place in the code where CCIDs are loaded).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "63b8e2861f31868dce9c92fd7444f212a5a8a775", "tree": "086f7deee646fb9b69d58f06509e58664eeba27a", "parents": [ "991d927c8652b2ab51bd8eef2b773bb2c77d457b" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 08 01:17:32 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 08 01:17:32 2008 -0800" }, "message": "dccp: Clean up old feature-negotiation infrastructure\n\nThe code removed by this patch is no longer referenced or used, the added\nlines update documentation and copyrights.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "991d927c8652b2ab51bd8eef2b773bb2c77d457b", "tree": "b21cab0ebe4b9f93a2c57b6dc6cd2f38ec828301", "parents": [ "192b27ff35bad4cf76cc4239419e9f805935e4f8" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 08 01:16:27 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 08 01:16:27 2008 -0800" }, "message": "dccp: Integration of dynamic feature activation - part 3 (client side)\n\nThis integrates feature-activation in the client:\n\n 1. When dccp_parse_options() fails, the reset code is already set; request_sent\\\n _state_process() currently overrides this with `Packet Error\u0027, which is not\n intended - changed to use the reset code supplied by dccp_parse_options().\n\n 2. When feature negotiation fails, the socket should be marked as not usable,\n so that the application is notified that an error occurred. This is achieved\n by a new label \u0027unable_to_proceed\u0027: generating an error code of `Aborted\u0027,\n setting the socket state to CLOSED, returning with ECOMM in sk_err.\n\n 3. Avoids parsing the Ack twice in Respond state by not doing option processing\n again in dccp_rcv_respond_partopen_state_process (as option processing has\n already been done on the request_sock in dccp_check_req).\n\nSince this addresses congestion-control initialisation, a corresponding\nFIXME has been removed.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "192b27ff35bad4cf76cc4239419e9f805935e4f8", "tree": "8ad3bdb36f4cf7ef4f15c737c22f3b4d6b9578d3", "parents": [ "6eb55d172b5f6de65afdae6285f8d732e4785bf7" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 08 01:15:55 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 08 01:15:55 2008 -0800" }, "message": "dccp: Integration of dynamic feature activation - part 2 (server side)\n\nThis patch integrates the activation of features at the end of negotiation\ninto the server-side code.\n\nNote regarding the removal of \u0027const\u0027:\n--------------------------------------\n The \u0027const\u0027 attribute has been removed from \u0027dreq\u0027 since dccp_activate_values()\n needs to operate on dreq\u0027s feature list. Part of the activation is to remove\n those options from the list that have already been confirmed, hence it is not\n purely read-only.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "6eb55d172b5f6de65afdae6285f8d732e4785bf7", "tree": "dbc81b2610db0e62cf2c69a0da9dfa68ea3ff8c1", "parents": [ "b74ca3a896b9ab5f952bc440154758e708c48884" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 08 01:15:26 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 08 01:15:26 2008 -0800" }, "message": "dccp: Integration of dynamic feature activation - part 1 (socket setup)\n\nThis first patch out of three replaces the hardcoded default settings with\ninitialisation code for the dynamic feature negotiation.\n\nThe patch also ensures that the client feature-negotiation queue is flushed\nonly when entering the OPEN state.\n\nSince confirmed Change options are removed as soon as they are confirmed\n(in the DCCP-Response), this ensures that Confirm options are retransmitted.\n\nNote on retransmitting Confirm options:\n---------------------------------------\nImplementation experience showed that it is necessary to retransmit Confirm\noptions. Thanks to Leandro Melo de Sales who reported a bug in an earlier\nrevision of the patch set, resulting from not retransmitting these options.\n\nAs long as the client is in PARTOPEN, it needs to retransmit the Confirm\noptions for the Change options received on the DCCP-Response from the server.\n\nOtherwise, if the packet containing the Confirm options gets dropped in the\nnetwork, the connection aborts due to undefined feature negotiation state.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "61c1d052a3c7d5acba3bd535aaffa5bb5d085181", "tree": "c638a390d7f3967bd43a84a0cfe4ca35f1b629a2", "parents": [ "d2b88814c6a63e4018cd299826907a12068ffdb7" ], "author": { "name": "Ilpo Järvinen", "email": "ilpo.jarvinen@helsinki.fi", "time": "Fri Dec 05 22:39:49 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Fri Dec 05 22:39:49 2008 -0800" }, "message": "dccp: use roundup instead of opencoding\n\nSigned-off-by: Ilpo Järvinen \u003cilpo.jarvinen@helsinki.fi\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "422d9cdcb85b3622d08a590fed66021af7aea333", "tree": "e40520346933d4c1d27ad7712f09bcd45fb25fca", "parents": [ "b1ad00422ecba0449f8e3a8f2ec9267bc994bf8f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 01 23:34:01 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 01 23:34:01 2008 -0800" }, "message": "dccp: Feature activation handlers\n\nThis patch provides the post-processing of feature negotiation state, after\nthe negotiation has completed.\n\nTo this purpose, handlers are used and added to the dccp_feat_table. Each\nhandler is passed a boolean flag whether the RX or TX side of the feature\nis meant.\n\nSeveral handlers are provided already, new handlers can easily be added.\n\nThe initialisation is now fully dynamic, i.e. CCIDs are activated only\nafter the feature negotiation. The integration of this dynamic activation\nis done in the subsequent patches.\n\nThanks to Wei Yongjun for pointing out the necessity of skipping over empty\nConfirm options while copying the negotiated feature values.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "b1ad00422ecba0449f8e3a8f2ec9267bc994bf8f", "tree": "6a3923ca76d60dd0e39b7323c8abaa74bbc7db20", "parents": [ "e77b8363b2ea7c0d89919547c1a8b0562f298b57" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 01 23:33:18 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 01 23:33:18 2008 -0800" }, "message": "dccp: Processing Confirm options\n\nAnalogous to the previous patch, this adds code to interpret incoming Confirm\nfeature-negotiation options. Both functions operate on the feature-negotiation\nlist of either the request_sock (server) or the dccp_sock (client).\n\nThanks to Wei Yongjun for pointing out that it is overly restrictive to check\nthe entire list of confirmed SP values.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "e77b8363b2ea7c0d89919547c1a8b0562f298b57", "tree": "9fdef240be3aeb49c012fd00d41f9ee90afe776c", "parents": [ "75757a7d0c54f8fdd414c74a6005d275032b0115" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 01 23:32:35 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 01 23:32:35 2008 -0800" }, "message": "dccp: Process incoming Change feature-negotiation options\n\nThis adds/replaces code for processing incoming ChangeL/R options.\nThe main difference is that:\n * mandatory FN options are now interpreted inside the function\n (there are too many individual cases to do this externally);\n * the function returns an appropriate Reset code or 0,\n which is then used to fill in the data for the Reset packet.\n\nOld code, which is no longer used or referenced, has been removed.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "75757a7d0c54f8fdd414c74a6005d275032b0115", "tree": "768c07adad4a6f42723acfeada434c045f36a489", "parents": [ "8b7b6c75c6387527b195bb69100182288da94f84" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 01 23:31:04 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 01 23:31:04 2008 -0800" }, "message": "dccp: Preference list reconciliation\n\nThis provides two functions to\n * reconcile preference lists (with appropriate return codes) and\n * reorder the preference list if successful reconciliation changed the\n preferred value.\n\nThe patch also removes the old code for processing SP/NN Change options, since\nnew code to process these is mostly there already; related references have been\ncommented out.\n\nThe code for processing Change options follows in the next patch.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "8b7b6c75c6387527b195bb69100182288da94f84", "tree": "4a87cbdcacf5736c41eae01481c31c2729bea1a6", "parents": [ "0971d17ca3d80f61863f4750091a64448bf91600" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 01 23:29:30 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 01 23:29:30 2008 -0800" }, "message": "dccp: Integrate feature-negotiation insertion code\n\nThe patch implements insertion of feature negotiation at the server (listening\nand request socket) and the client (connecting socket).\n\nIn dccp_insert_options(), several statements have been grouped together now\nto achieve (it is hoped) better efficiency by reducing the number of tests\neach packet has to go through:\n - Ack Vectors are sent if the packet is neither a Data or a Request packet;\n - a previous issue is corrected - feature negotiation options are allowed\n on DataAck packets (5.8).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "0971d17ca3d80f61863f4750091a64448bf91600", "tree": "4f4a4f334b382c873462788adf915e85230f5363", "parents": [ "25f13048bce61f33f6a102e0bf377fd3922ed364" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Mon Dec 01 23:27:31 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Mon Dec 01 23:27:31 2008 -0800" }, "message": "dccp: Insert feature-negotiation options into skb\n\nThis patch replaces the earlier insertion routine from options.c, so that\ncode specific to feature negotiation can remain in feat.c. This is possible\nby calling a function already existing in options.c.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "dd24c00191d5e4a1ae896aafe33c6b8095ab4bd1", "tree": "e955c09e0b288e50c706b6ee409229d5a930c80c", "parents": [ "1748376b6626acf59c24e9592ac67b3fe2a0e026" ], "author": { "name": "Eric Dumazet", "email": "dada1@cosmosbay.com", "time": "Tue Nov 25 21:17:14 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Tue Nov 25 21:17:14 2008 -0800" }, "message": "net: Use a percpu_counter for orphan_count\n\nInstead of using one atomic_t per protocol, use a percpu_counter\nfor \"orphan_count\", to reduce cache line contention on\nheavy duty network servers. \n\nSigned-off-by: Eric Dumazet \u003cdada1@cosmosbay.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "52479b623d3d41df84c499325b6a8c7915413032", "tree": "196f303f296b53dc89a05954d9c03226a9b4158b", "parents": [ "cdcbca7c1f1946758cfacb69bc1c7eeaccb11e2d" ], "author": { "name": "Alexey Dobriyan", "email": "adobriyan@gmail.com", "time": "Tue Nov 25 17:35:18 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Tue Nov 25 17:35:18 2008 -0800" }, "message": "netns xfrm: lookup in netns\n\nPass netns to xfrm_lookup()/__xfrm_lookup(). For that pass netns\nto flow_cache_lookup() and resolver callback.\n\nTake it from socket or netdevice. Stub DECnet to init_net.\n\nSigned-off-by: Alexey Dobriyan \u003cadobriyan@gmail.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "3ed7cc0f8b29da4304825a7bcef25fc83f84c1ae", "tree": "ee7dcfc216faa1668b763b25af55ad569e920f28", "parents": [ "b71e839f9a33abf8634b1eea4875bc8057fe39e2" ], "author": { "name": "Ingo Molnar", "email": "mingo@elte.hu", "time": "Tue Nov 25 16:57:30 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Tue Nov 25 16:57:30 2008 -0800" }, "message": "dccp: fix warning in net/dccp/options.c\n\nthis warning:\n\n net/dccp/options.c: In function ‘dccp_parse_options’:\n net/dccp/options.c:67: warning: ‘value’ may be used uninitialized in this function\n\nis a bogus GCC warning. The compiler does not recognize the relation\nbetween \"value\" and \"mandatory\" variables: the code flow can ever reach\nthe \"out_invalid_option:\" label if \u0027mandatory\u0027 is set to 1, and when\n\u0027mandatory\u0027 is non-zero, we\u0027ll always have \u0027value\u0027 initialized.\n\nHelp out the compiler by annotating the variable.\n\nSigned-off-by: Ingo Molnar \u003cmingo@elte.hu\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "8c862c23e2563e6aedfc6c4aa6827cadb83f2414", "tree": "55550ae7c2b62e5b93a09487278db91c334d615a", "parents": [ "d371056695ef993d36c57b73d654e66080377a9c" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Nov 23 16:10:23 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Nov 23 16:10:23 2008 -0800" }, "message": "dccp: Header option insertion routine for feature-negotiation\n\nThe patch extends existing code:\n * Confirm options divide into the confirmed value plus an optional preference\n list for SP values. Previously only the preference list was echoed for SP\n values, now the confirmed value is added as per RFC 4340, 6.1;\n * length and sanity checks are added to avoid illegal memory (or NULL) access.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "d371056695ef993d36c57b73d654e66080377a9c", "tree": "85e587e5558cf00232d8b24b4e28a390d3856d2a", "parents": [ "02fa460ef553faabc7e0b15ff9f607f028739808" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Nov 23 16:09:11 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Nov 23 16:09:11 2008 -0800" }, "message": "dccp: Support for Mandatory options\n\nSupport for Mandatory options is provided by this patch, which will\nbe used by subsequent feature-negotiation patches.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nAcked-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "02fa460ef553faabc7e0b15ff9f607f028739808", "tree": "04342d781df0b0a1953cfcc6c52cbca7e172896a", "parents": [ "71c262a3dd42dea73700646d969b0af7a4102edf" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Nov 23 16:07:53 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Nov 23 16:07:53 2008 -0800" }, "message": "dccp: Increase the scope of variable-length htonl/ntohl functions\n\nThis extends the scope of two available functions,\nencode|decode_value_var, to work up to 6 (8) bytes, to match maximum\nrequirements in the RFC.\n\nThese functions are going to be used both by general option processing\nand feature negotiation code, hence declarations have been put into\nfeat.h.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nAcked-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "71c262a3dd42dea73700646d969b0af7a4102edf", "tree": "7586f62639805bc6b6854b71294e53be66490f2c", "parents": [ "b20a9c24d5c5d466d7e4a25c6f1bedbd2d16ad4f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Nov 23 16:04:59 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Nov 23 16:04:59 2008 -0800" }, "message": "dccp: API to query the current TX/RX CCID\n\nThis provides function to query the current TX/RX CCID dynamically,\nwithout reliance on the minisock value, using dynamic information\navailable in the currently loaded CCID module.\n\nThis query function is then used to\n (a) provide the getsockopt part for getting/setting CCIDs via sockopts;\n (b) replace the current test for \"which CCID is in use\" in probe.c.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "b20a9c24d5c5d466d7e4a25c6f1bedbd2d16ad4f", "tree": "17789215657f693caf36e22d3e724cc1b1e07ba6", "parents": [ "2c62ad7b56fa8e2658253c0256ef4c4de228a0b9" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Nov 23 16:02:31 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Nov 23 16:02:31 2008 -0800" }, "message": "dccp: Set per-connection CCIDs via socket options\n\nWith this patch, TX/RX CCIDs can now be changed on a per-connection\nbasis, which overrides the defaults set by the global sysctl variables\nfor TX/RX CCIDs.\n\nTo make full use of this facility, the remaining patches of this patch\nset are needed, which track dependencies and activate negotiated\nfeature values.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "3d3e35aa78c9498eed3209c9d82376085ed0c36f", "tree": "76c349b4017f63ed8e0ac7f9d96ce5b64c8118b0", "parents": [ "f4bdd264b43cc60dccb617afce2859dffdd7a935" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Nov 20 01:03:08 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Thu Nov 20 01:03:08 2008 -0800" }, "message": "dccp: Fix bracing in dccp_feat_list_lookup.\n\nFrom: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "5caea4ea7088e80ac5410d04660346094608b909", "tree": "fad95133683c002d24ff5de7fb756dad806b41ed", "parents": [ "d8b83c57a7e497cba9b5cb156e63176323035785" ], "author": { "name": "Eric Dumazet", "email": "dada1@cosmosbay.com", "time": "Thu Nov 20 00:40:07 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Thu Nov 20 00:40:07 2008 -0800" }, "message": "net: listening_hash get a spinlock per bucket\n\nThis patch prepares RCU migration of listening_hash table for\nTCP/DCCP protocols.\n\nlistening_hash table being small (32 slots per protocol), we add\na spinlock for each slot, instead of a single rwlock for whole table.\n\nThis should reduce hold time of readers, and writers concurrency.\n\nSigned-off-by: Eric Dumazet \u003cdada1@cosmosbay.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "a7a0d6a87b70f7b2bab5281fc0fd443772bd0795", "tree": "adb4978c449d9ae570e848910ac777dd513277ac", "parents": [ "14e943db133489c98d426a0dcfce4a99c6e8ad97" ], "author": { "name": "Eric Dumazet", "email": "dada1@cosmosbay.com", "time": "Wed Nov 19 15:43:27 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Wed Nov 19 15:43:27 2008 -0800" }, "message": "net: inet_diag_handler structs can be const\n\nSigned-off-by: Eric Dumazet \u003cdada1@cosmosbay.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "191029963630719e867d8bd0c315d32c822622cb", "tree": "fb8284951c59eb8f3547c9cde09c189c07b702c1", "parents": [ "dd9c0e363cef32b7d6f23d4c87e8dfe4f91fd1c5" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Nov 16 22:56:55 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Nov 16 22:56:55 2008 -0800" }, "message": "dccp: Tidy up setsockopt calls\n\nThis splits the setsockopt calls into two groups, depending on whether an\ninteger argument (val) is required and whether routines being called do\ntheir own locking.\n\nSome options (such as setting the CCID) use u8 rather than int, so that for\nthese the test with regard to integer-sizeof can not be used.\n\nThe second switch-case statement now only has those statements which need\nlocking and which make use of `val\u0027.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nAcked-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nReviewed-by: Eugene Teo \u003ceugeneteo@kernel.sg\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "dd9c0e363cef32b7d6f23d4c87e8dfe4f91fd1c5", "tree": "2ae48a033a925169f0fd71bdc18a683a308f46c4", "parents": [ "29450559849da7066813601effb7666966869853" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Nov 16 22:55:08 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Nov 16 22:55:08 2008 -0800" }, "message": "dccp: Deprecate Ack Ratio sysctl\n\nThis patch deprecates the Ack Ratio sysctl, since\n * Ack Ratio is entirely ignored by CCID-3 and CCID-4,\n * Ack Ratio currently doesn\u0027t work in CCID-2 (i.e. is always set to 1);\n * even if it would work in CCID-2, there is no point for a user to change it:\n - Ack Ratio is constrained by cwnd (RFC 4341, 6.1.2),\n - if Ack Ratio \u003e cwnd, the system resorts to spurious RTO timeouts\n (since waiting for Acks which will never arrive in this window),\n - cwnd is not a user-configurable value.\n\nThe only reasonable place for Ack Ratio is to print it for debugging. It is\nplanned to do this later on, as part of e.g. dccp_probe.\n\nWith this patch Ack Ratio is now under full control of feature negotiation:\n * Ack Ratio is resolved as a dependency of the selected CCID;\n * if the chosen CCID supports it (i.e. CCID \u003d\u003d CCID-2), Ack Ratio is set to\n the default of 2, following RFC 4340, 11.3 - \"New connections start with Ack\n Ratio 2 for both endpoints\";\n * what happens then is part of another patch set, since it concerns the\n dynamic update of Ack Ratio while the connection is in full flight.\n\nThanks to Tomasz Grobelny for discussion leading up to this patch.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "29450559849da7066813601effb7666966869853", "tree": "5a55d997460a85da733e1960bc74de0f170e8106", "parents": [ "49aebc66d6b896f9c7c5739d85c4548c00015aa7" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Nov 16 22:53:48 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Nov 16 22:53:48 2008 -0800" }, "message": "dccp: Feature negotiation for minimum-checksum-coverage\n\nThis provides feature negotiation for server minimum checksum coverage\nwhich so far has been missing.\n\nSince sender/receiver coverage values range only from 0...15, their\ntype has also been reduced in size from u16 to u4.\n\nFeature-negotiation options are now generated for both sender and receiver\ncoverage, i.e. when the peer has `forgotten\u0027 to enable partial coverage\nthen feature negotiation will automatically enable (negotiate) the partial\ncoverage value for this connection.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "49aebc66d6b896f9c7c5739d85c4548c00015aa7", "tree": "0b12afdd2e742c3eb481aef8d2adcb7b1aeca9f1", "parents": [ "0c1168398ecbfacbb27203b281bde20ec9f78017" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Nov 16 22:51:23 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Nov 16 22:51:23 2008 -0800" }, "message": "dccp: Deprecate old setsockopt framework\n\nThe previous setsockopt interface, which passed socket options via struct\ndccp_so_feat, is complicated/difficult to use. Continuing to support it leads to\nugly code since the old approach did not distinguish between NN and SP values.\n\nThis patch removes the old setsockopt interface and replaces it with two new\nfunctions to register NN/SP values for feature negotiation. \nThese are essentially wrappers around the internal __feat_register functions,\nwith checking added to avoid\n\n * wrong usage (type);\n * changing values while the connection is in progress.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "0c1168398ecbfacbb27203b281bde20ec9f78017", "tree": "3298379e950bba174b46e53102f265829340fa6d", "parents": [ "3f2c31d90327f21d76d296af34aa4ca547932ff4" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Nov 16 22:49:52 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Nov 16 22:49:52 2008 -0800" }, "message": "dccp: Mechanism to resolve CCID dependencies\n\nThis adds a hook to resolve features whose value depends on the choice of\nCCID. It is done at the server since it can only be done after the CCID\nvalues have been negotiated; i.e. the client will add its CCID preference\nlist on the Change options sent in the Request, which will be reconciled\nwith the local preference list of the server.\n\nThe concept is documented on\nhttp://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/feature_negotiation/\\\n\t\t\t\timplementation_notes.html#ccid_dependencies\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "3ab5aee7fe840b5b1b35a8d1ac11c3de5281e611", "tree": "468296b7be813643248d4ca67497d6ddb6934fc6", "parents": [ "88ab1932eac721c6e7336708558fa5ed02c85c80" ], "author": { "name": "Eric Dumazet", "email": "dada1@cosmosbay.com", "time": "Sun Nov 16 19:40:17 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Nov 16 19:40:17 2008 -0800" }, "message": "net: Convert TCP \u0026 DCCP hash tables to use RCU / hlist_nulls\n\nRCU was added to UDP lookups, using a fast infrastructure :\n- sockets kmem_cache use SLAB_DESTROY_BY_RCU and dont pay the\n price of call_rcu() at freeing time.\n- hlist_nulls permits to use few memory barriers.\n\nThis patch uses same infrastructure for TCP/DCCP established\nand timewait sockets.\n\nThanks to SLAB_DESTROY_BY_RCU, no slowdown for applications\nusing short lived TCP connections. A followup patch, converting\nrwlocks to spinlocks will even speedup this case.\n\n__inet_lookup_established() is pretty fast now we dont have to\ndirty a contended cache line (read_lock/read_unlock)\n\nOnly established and timewait hashtable are converted to RCU\n(bind table and listen table are still using traditional locking)\n\nSigned-off-by: Eric Dumazet \u003cdada1@cosmosbay.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "9eca0a47dee201a73967026985b5f0a79a46bd36", "tree": "beb39fbd3c28865705d7409aa35fd59914257da9", "parents": [ "d90ebcbfa7f5a8b4e20518c9f94c5c4e4cd3c2e5" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Nov 12 00:48:44 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Wed Nov 12 00:48:44 2008 -0800" }, "message": "dccp: Resolve dependencies of features on choice of CCID\n\nThis provides a missing link in the code chain, as several features implicitly\ndepend and/or rely on the choice of CCID. Most notably, this is the Send Ack Vector\nfeature, but also Ack Ratio and Send Loss Event Rate (also taken care of).\n\nFor Send Ack Vector, the situation is as follows:\n * since CCID2 mandates the use of Ack Vectors, there is no point in allowing \n endpoints which use CCID2 to disable Ack Vector features such a connection;\n\n * a peer with a TX CCID of CCID2 will always expect Ack Vectors, and a peer\n with a RX CCID of CCID2 must always send Ack Vectors (RFC 4341, sec. 4);\n\n * for all other CCIDs, the use of (Send) Ack Vector is optional and thus\n negotiable. However, this implies that the code negotiating the use of Ack\n Vectors also supports it (i.e. is able to supply and to either parse or\n ignore received Ack Vectors). Since this is not the case (CCID-3 has no Ack\n Vector support), the use of Ack Vectors is here disabled, with a comment\n in the source code.\n\nAn analogous consideration arises for the Send Loss Event Rate feature,\nsince the CCID-3 implementation does not support the loss interval options\nof RFC 4342. To make such use explicit, corresponding feature-negotiation\noptions are inserted which signal the use of the loss event rate option,\nas it is used by the CCID3 code.\n\nLastly, the values of the Ack Ratio feature are matched to the choice of CCID.\n\nThe patch implements this as a function which is called after the user has\nmade all other registrations for changing default values of features.\n\nThe table is variable-length, the reserved (and hence for feature-negotiation\ninvalid, confirmed by considering section 19.4 of RFC 4340) feature number `0\u0027\nis used to mark the end of the table.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "d90ebcbfa7f5a8b4e20518c9f94c5c4e4cd3c2e5", "tree": "b1fb407c7ee1adbe8215311675d133a83a2d55b5", "parents": [ "e8ef967a54f401ac5e8637b7f7f8bddb006144c4" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Nov 12 00:47:26 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Wed Nov 12 00:47:26 2008 -0800" }, "message": "dccp: Query supported CCIDs\n\nThis provides a data structure to record which CCIDs are locally supported\nand three accessor functions:\n - a test function for internal use which is used to validate CCID requests\n made by the user;\n - a copy function so that the list can be used for feature-negotiation; \n - documented getsockopt() support so that the user can query capabilities.\n\nThe data structure is a table which is filled in at compile-time with the\nlist of available CCIDs (which in turn depends on the Kconfig choices).\n\nUsing the copy function for cloning the list of supported CCIDs is useful for\nfeature negotiation, since the negotiation is now with the full list of available\nCCIDs (e.g. {2, 3}) instead of the default value {2}. This means negotiation \nwill not fail if the peer requests to use CCID3 instead of CCID2. \n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "e8ef967a54f401ac5e8637b7f7f8bddb006144c4", "tree": "37f7e6b384f27f30158e8f5d750fa3235951265d", "parents": [ "f74e91b6cca5889e667193c7e794186db73c2000" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Nov 12 00:43:40 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Wed Nov 12 00:43:40 2008 -0800" }, "message": "dccp: Registration routines for changing feature values\n\nTwo registration routines, for SP and NN features, are provided by this patch,\nreplacing a previous routine which was used for both feature types.\n\nThese are internal-only routines and therefore start with `__feat_register\u0027.\n\nIt further exports the known limits of Sequence Window and Ack Ratio as symbolic\nconstants.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "f74e91b6cca5889e667193c7e794186db73c2000", "tree": "10f6a612d97b3ab5ba4ecd75b6decb669f178d76", "parents": [ "6bb3ce25d05f2990c8a19adaf427531430267c1f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Wed Nov 12 00:42:58 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Wed Nov 12 00:42:58 2008 -0800" }, "message": "dccp: Limit feature negotiation to connection setup phase\n\nThis patch limits feature (capability) negotation to the connection setup phase:\n\n 1. Although it is theoretically possible to perform feature negotiation at any\n time (and RFC 4340 supports this), in practice this is prohibitively complex,\n as it requires to put traffic on hold for each new negotiation.\n 2. As a byproduct of restricting feature negotiation to connection setup, the\n feature-negotiation retransmit timer is no longer required. This part is now\n mapped onto the protocol-level retransmission.\n Details indicating why timers are no longer needed can be found on\n http://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/feature_negotiation/\\\n\t implementation_notes.html\n\nThis patch disables anytime negotiation, subsequent patches work out full\nfeature negotiation support for connection setup.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "d99a7bd210a14001007fc5233597c78877f0a11c", "tree": "366ef8703e0453608ed39e0e7c2f4f4d043a46e9", "parents": [ "ac75773c2742d82cbcb078708df406e9017224b7" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Nov 04 23:56:30 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Tue Nov 04 23:56:30 2008 -0800" }, "message": "dccp: Cleanup routines for feature negotiation\n\nThis inserts the required de-allocation routines for memory allocated\nby feature negotiation in the socket destructors, replacing\ndccp_feat_clean() in one instance.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "ac75773c2742d82cbcb078708df406e9017224b7", "tree": "7e7b1aa5131c4a61aabd9d86d7332eca98d66a89", "parents": [ "61e6473efbd6087e1db3aaa93a5266c5bfd8aa99" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Nov 04 23:55:49 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Tue Nov 04 23:55:49 2008 -0800" }, "message": "dccp: Per-socket initialisation of feature negotiation\n\nThis provides feature-negotiation initialisation for both DCCP sockets\nand DCCP request_sockets, to support feature negotiation during\nconnection setup.\n\nIt also resolves a FIXME regarding the congestion control\ninitialisation.\n\nThanks to Wei Yongjun for help with the IPv6 side of this patch.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "61e6473efbd6087e1db3aaa93a5266c5bfd8aa99", "tree": "4717cfb41ad603d5def3db557628e5d96a918e63", "parents": [ "7d43d1a0f2cf535167ec7247f110a1f85cecac43" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Nov 04 23:54:04 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Tue Nov 04 23:54:04 2008 -0800" }, "message": "dccp: List management for new feature negotiation\n\nThis adds list initial fields and list management functions for the\nnew feature negotiation implementation.\n\nThanks to Arnaldo for suggestions and improvements.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "7d43d1a0f2cf535167ec7247f110a1f85cecac43", "tree": "3dc4411cfe27b3ffd0368a65f8ec17dd809157a7", "parents": [ "bd012f2e7be9f69a47d240ded0fa491967d9827c" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Nov 04 23:43:47 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Tue Nov 04 23:43:47 2008 -0800" }, "message": "dccp: Implement lookup table for feature-negotiation information\n\nA lookup table for feature-negotiation information, extracted from RFC\n4340/42, is provided by this patch. All currently known features can\nbe found in this table, along with their feature location, their\ndefault value, and type.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\nAcked-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "bd012f2e7be9f69a47d240ded0fa491967d9827c", "tree": "940cc895a7da7a065847cf604cddfab097e385cc", "parents": [ "d5f642384e9da75393160350f75bbb9a527f7c58" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Nov 04 23:38:20 2008 -0800" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Tue Nov 04 23:38:20 2008 -0800" }, "message": "dccp: Basic data structure for feature negotiation\n\nThis patch prepares for the new and extended feature-negotiation\nroutines.\n\nThe following feature-negotiation data structures are provided:\n\t* a container for the various (SP or NN) values,\n\t* symbolic state names to track feature states,\n\t* an entry struct which holds all current information together,\n\t* elementary functions to fill in and process these structures.\n\nEntry structs are arranged as FIFO for the following reason: RFC 4340\nspecifies that if multiple options of the same type are present, they\nare processed in the order of their appearance in the packet; which\nmeans that this order needs to be preserved in the local data\nstructure (the later insertion code also respects this order).\n\nThe struct list_head has been chosen for the following reasons: the most\nfrequent operations are\n\n * add new entry at tail (when receiving Change or setting socket\n options);\n * delete entry (when Confirm has been received);\n * deep copy of entire list (cloning from listening socket onto\n request socket).\n\nThe NN value has been set to 64 bit, which is a currently sufficient\nupper limit (Sequence Window feature has 48 bit).\n\nThanks to Arnaldo, who contributed the streamlined layout of the entry\nstruct.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "21454aaad30651ba0dcc16fe5271bc12ee21f132", "tree": "eb525494d6f80a0e855840bc588ae1f422348b04", "parents": [ "14d5e834f6b36667c7da56374645f99b6cf30814" ], "author": { "name": "Harvey Harrison", "email": "harvey.harrison@gmail.com", "time": "Fri Oct 31 00:54:56 2008 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Fri Oct 31 00:54:56 2008 -0700" }, "message": "net: replace NIPQUAD() in net/*/\n\nUsing NIPQUAD() with NIPQUAD_FMT, %d.%d.%d.%d or %u.%u.%u.%u\ncan be replaced with %pI4\n\nSigned-off-by: Harvey Harrison \u003charvey.harrison@gmail.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "944f750227fa0beb2b440709687415621e2533a4", "tree": "ca4120450381f13e831de3e7cfc0bca40a68fed2", "parents": [ "fd5070370c74c32b7a98090eabb46c53baf41733" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Sun Oct 19 23:36:47 2008 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Sun Oct 19 23:36:47 2008 -0700" }, "message": "dccp: Port redirection support for DCCP\n\nCommit a3116ac5c216fc3c145906a46df9ce542ff7dcf2 from 1st October (\"tcp: Port\nredirection support for TCP\") broke DCCP skb lookup by changing inet_csk_clone,\nwhich is used by DCCP to generate the child socket after the handshake.\n\nThis patch updates DCCP to use \u0027loc_port\u0027 instead of \u0027sport\u0027, which fixes the\nproblem, and thus inheriting port redirection support via the new interface.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nSigned-off-by: KOVACS Krisztian \u003chidden@sch.bme.hu\u003e\nAcked-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "95a5afca4a8d2e1cb77e1d4bc6ff9f718dc32f7a", "tree": "15452d28df4e4d76fc1276e791a7cc3c6e1a9b3a", "parents": [ "00269b54edbf25f3bb0dccb558ae23a6fc77ed86" ], "author": { "name": "Johannes Berg", "email": "johannes@sipsolutions.net", "time": "Thu Oct 16 15:24:51 2008 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Thu Oct 16 15:24:51 2008 -0700" }, "message": "net: Remove CONFIG_KMOD from net/ (towards removing CONFIG_KMOD entirely)\n\nSome code here depends on CONFIG_KMOD to not try to load\nprotocol modules or similar, replace by CONFIG_MODULES\nwhere more than just request_module depends on CONFIG_KMOD\nand and also use try_then_request_module in ebtables.\n\nSigned-off-by: Johannes Berg \u003cjohannes@sipsolutions.net\u003e\nSigned-off-by: Rusty Russell \u003crusty@rustcorp.com.au\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "e41b5368e029e79d11acb5952bc73284e5026c62", "tree": "82d519911fb97171259260655e9b86a20fcfe378", "parents": [ "a862f6a6dc89c57dd3a959a1636b59f0c27169c2" ], "author": { "name": "Denis V. Lunev", "email": "den@openvz.org", "time": "Wed Oct 08 10:33:26 2008 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Wed Oct 08 11:14:13 2008 -0700" }, "message": "ipv6: added net argument to ICMP6_INC_STATS_BH\n\nSigned-off-by: Denis V. Lunev \u003cden@openvz.org\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "9a1f27c48065ce713eb47f2fd475b717e63ef239", "tree": "79ebeb8386b98aca595625b9d2db26bd52a8077d", "parents": [ "c7004482e8dcb7c3c72666395cfa98a216a4fb70" ], "author": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Tue Oct 07 11:41:57 2008 -0700" }, "committer": { "name": "David S. Miller", "email": "davem@davemloft.net", "time": "Tue Oct 07 11:41:57 2008 -0700" }, "message": "inet_hashtables: Add inet_lookup_skb helpers\n\nTo be able to use the cached socket reference in the skb during input\nprocessing we add a new set of lookup functions that receive the skb on\ntheir argument list.\n\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nSigned-off-by: KOVACS Krisztian \u003chidden@sch.bme.hu\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n" }, { "commit": "410e27a49bb98bc7fa3ff5fc05cc313817b9f253", "tree": "88bb1fcf84f9ebfa4299c9a8dcd9e6330b358446", "parents": [ "0a68a20cc3eafa73bb54097c28b921147d7d3685" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Sep 09 13:27:22 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Tue Sep 09 13:27:22 2008 +0200" }, "message": "This reverts \"Merge branch \u0027dccp\u0027 of git://eden-feed.erg.abdn.ac.uk/dccp_exp\"\nas it accentally contained the wrong set of patches. These will be\nsubmitted separately.\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "a3cbdde8e9c38b66b4f13ac5d6ff1939ded0ff20", "tree": "8e66f40579776dbc07fdacb206c4d56e1b351e86", "parents": [ "53ac9570c8145710aaed9e1eb850c2e991a4ebc1" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:43 2008 +0200" }, "message": "dccp ccid-3: Preventing Oscillations\n\nThis implements [RFC 3448, 4.5], which performs congestion avoidance behaviour\nby reducing the transmit rate as the queueing delay (measured in terms of\nlong-term RTT) increases.\n\nOscillation can be turned on/off via a module option (do_osc_prev) and via sysfs\n(using mode 0644), the default is off.\n\nOverflow analysis:\n------------------\n * oscillation prevention is done after update_x(), so that t_ipi \u003c\u003d 64000;\n * hence the multiplication \"t_ipi * sqrt(R_sample)\" needs 64 bits;\n * done using u64 for sqrt_sample and explicit typecast of t_ipi;\n * the divisor, R_sqmean, is non-zero because oscillation prevention is first\n called when receiving the second feedback packet, and tfrc_scaled_rtt() \u003e 0.\n\nA detailed discussion of the algorithm (with plots) is on\nhttp://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/ccid3/sender_notes/oscillation_prevention/\n\nThe algorithm has negative side effects:\n * when allowing to decrease t_ipi (leads to a large RTT) and\n * when using it during slow-start;\nboth uses are therefore disabled.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "53ac9570c8145710aaed9e1eb850c2e991a4ebc1", "tree": "61aed967a24d95e5572ea311bdac04012f51e3b2", "parents": [ "c8f41d50adc380bfb38538ce39ca0ffea5926221" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:43 2008 +0200" }, "message": "dccp ccid-3: Simplify computing and range-checking of t_ipi\n\nThis patch simplifies the computation of t_ipi, avoiding expensive computations\nto enforce the minimum sending rate.\n\nBoth RFC 3448 and rfc3448bis (revision #06), as well as RFC 4342 sec 5., require\nat various stages that at least one packet must be sent per t_mbi \u003d 64 seconds.\nThis requires frequent divisions of the type X_min \u003d s/t_mbi, which are later\nconverted back into an inter-packet-interval t_ipi_max \u003d s/X_min \u003d t_mbi.\n\nThe patch removes the expensive indirection; in the unlikely case of having\na sending rate less than one packet per 64 seconds, it also re-adjusts X.\n\nThe following cases document conformance with RFC 3448 / rfc3448bis-06:\n 1) Time until receiving the first feedback packet:\n * if the sender has no initial RTT sample then X \u003d s/1 Bps \u003e s/t_mbi;\n * if the sender has an initial RTT sample or when the first feedback\n packet is received, X \u003d W_init/R \u003e s/t_mbi.\n\n 2) Slow-start (p \u003d\u003d 0 and feedback packets come in):\n * RFC 3448 (current code) enforces a minimum of s/R \u003e s/t_mbi;\n * rfc3448bis (future code) enforces an even higher minimum of W_init/R.\n\n 3) Congestion avoidance with no absence of feedback (p \u003e 0):\n * when X_calc or X_recv/2 are too low, the minimum of X_min \u003d s/t_mbi\n is enforced in update_x() when calling update_send_interval();\n * update_send_interval() is, as before, only called when X changes\n (i.e. either when increasing or decreasing, not when in equilibrium).\n\n 4) Reduction of X without prior feedback or during slow-start (p\u003d\u003d0):\n * both RFC 3448 and rfc3448bis here halve X directly;\n * the associated constraint X \u003e\u003d s/t_mbi is nforced here by send_interval().\n\n 5) Reduction of X when p \u003e 0:\n * X is modified indirectly via X_recv (RFC 3448) or X_recv_set (rfc3448bis);\n * in both cases, control goes back to section 4.3 (in both documents);\n * since p \u003e 0, both documents use X \u003d max(min(...), s/t_mbi), which is\n enforced in this patch by calling send_interval() from update_x().\n\nI think that this analysis is exhaustive. Should I have forgotten a case,\nthe worst-case consideration arises when X sinks below s/t_mbi, and is then\nincreased back up to this minimum value. Even under this assumption, the\nbehaviour is correct, since all lower limits of X in RFC 3448 / rfc3448bis\nare either equal to or greater than s/t_mbi.\n\nNote on the condition X \u003e\u003d s/t_mbi \u003c\u003d\u003d\u003e t_ipi \u003d s/X \u003c\u003d t_mbi: since X is\nscaled by 64, and all time units are in microseconds, the coded condition is:\n\n t_ipi \u003d s * 64 * 10^6 usec / X \u003c\u003d 64 * 10^6 usec\n\nThis simplifies to s / X \u003c\u003d 1 second \u003c\u003d\u003d\u003e X * 1 second \u003e\u003d s \u003e 0.\n(A zero `s\u0027 is not allowed by the CCID-3 code).\t\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "c8f41d50adc380bfb38538ce39ca0ffea5926221", "tree": "ad2d9b674e2782b271f5ae15eb35630848055fbb", "parents": [ "891e4d8a402427bc40dee4c8413213a584710372" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:42 2008 +0200" }, "message": "dccp ccid-3: Measuring the packet size s with regard to rfc3448bis-06\n\nrfc3448bis allows three different ways of tracking the packet size `s\u0027: \n\n 1. using the MSS/MPS (at initialisation, 4.2, and in 4.1 (1));\n 2. using the average of `s\u0027 (in 4.1);\n 3. using the maximum of `s\u0027 (in 4.2).\n\nInstead of hard-coding a single interpretation of rfc3448bis, this implements\na choice of all three alternatives and suggests the first as default, since it\nis the option which is most consistent with other parts of the specification.\n\nThe patch further deprecates the update of t_ipi whenever `s\u0027 changes. The\ngains of doing this are only small since a change of s takes effect at the\nnext instant X is updated:\n * when the next feedback comes in (within one RTT or less);\n * when the nofeedback timer expires (within at most 4 RTTs).\n \nFurther, there are complications caused by updating t_ipi whenever s changes:\n * if t_ipi had previously been updated to effect oscillation prevention (4.5),\n then it is impossible to make the same adjustment to t_ipi again, thus\n counter-acting the algorithm;\n * s may be updated any time and a modification of t_ipi depends on the current\n state (e.g. no oscillation prevention is done in the absence of feedback);\n * in rev-06 of rfc3448bis, there are more possible cases, depending on whether\n the sender is in slow-start (t_ipi \u003c\u003d R/W_init), or in congestion-avoidance,\n limited by X_recv or the throughput equation (t_ipi \u003c\u003d t_mbi).\n\nThus there are side effects of always updating t_ipi as s changes. These may not\nbe desirable. The only case I can think of where such an update makes sense is\nto recompute X_calc when p \u003e 0 and when s changes (not done by this patch).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "891e4d8a402427bc40dee4c8413213a584710372", "tree": "e1e49c235c25c9d87a06b04ece4f534d79a40e51", "parents": [ "9d497a2c9120e31ff417e75f9f5576c4cde11281" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:42 2008 +0200" }, "message": "dccp ccid-3: Tidy up CCID-Kconfig dependencies\n\nThe per-CCID menu has several dependencies on EXPERIMENTAL. These are redundant,\nsince net/dccp/ccids/Kconfig is sourced by net/dccp/Kconfig and since the\nlatter menu in turn asserts a dependency on EXPERIMENTAL.\n\nThe patch removes the redundant dependencies as well as the repeated reference\nwithin the sub-menu.\n\nFurther changes:\n----------------\nTwo single dependencies on CCID-3 are replaced with a single enclosing `if\u0027.\n \nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "9d497a2c9120e31ff417e75f9f5576c4cde11281", "tree": "5837bcdc7b78195e428a9ab7f6297c6b4acae3f3", "parents": [ "88e97a93342c0b9e835d510921e7b2df8547d1bd" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:42 2008 +0200" }, "message": "dccp ccid-3: Implement rfc3448bis change to initial-rate computation\n\nThe patch updates CCID-3 with regard to the latest rfc3448bis-06: \n * in the first revisions of the draft, MSS was used for the RFC 3390 window; \n * then (from revision #1 to revision #2), it used the packet size `s\u0027;\n * now, in this revision (and apparently final), the value is back to MSS.\n\nThis change has an implication for the case when no RTT sample is available,\nat the time of sending the first packet:\n\n * with RTT sample, 2*MSS/RTT \u003c\u003d initial_rate \u003c\u003d 4*MSS/RTT;\n * without RTT sample, the initial rate is one packet (s bytes) per second\n (sec. 4.2), but using s instead of MSS here creates an imbalance, since\n this would further reduce the initial sending rate.\n\nHence the patch uses MSS (called MPS in RFC 4340) in all places.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "88e97a93342c0b9e835d510921e7b2df8547d1bd", "tree": "0e8406050b02487b213b062f4d37528051f465e3", "parents": [ "68c89ee53571a441799c03d5e240c6441bced620" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:42 2008 +0200" }, "message": "dccp ccid-3: Update the RX history records in one place\n\nThis patch is a requirement for enabling ECN support later on. With that change\nin mind, the following preparations are done:\n * renamed handle_loss() into congestion_event() since it returns true when a\n congestion event happens (it will eventually also take care of ECN packets);\n * lets tfrc_rx_congestion_event() always update the RX history records, since\n this routine needs to be called for each non-duplicate packet anyway;\n * made all involved boolean-type functions to have return type `bool\u0027;\n\nUpdating the RX history records is now only necessary for the packets received\nup to sending the first feedback. The receiver code becomes again simpler.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "68c89ee53571a441799c03d5e240c6441bced620", "tree": "a355d77fd0bf9e57375601286bf4b792456b423e", "parents": [ "22338f09bd60434a3f1d6608f0fa55972067985f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:42 2008 +0200" }, "message": "dccp ccid-3: Update the computation of X_recv\n\nThis updates the computation of X_recv with regard to Errata 610/611 for\nRFC 4342 and draft rfc3448bis-06, ensuring that at least an interval of 1\nRTT is used to compute X_recv. The change is wrapped into a new function\nccid3_hc_rx_x_recv().\n\nFurther changes:\n----------------\n * feedback is not sent when no data packets arrived (bytes_recv \u003d\u003d 0), as per\n rfc3448bis-06, 6.2;\n * take the timestamp for the feedback /after/ dccp_send_ack() returns, to avoid\n taking the transmission time into account (in case layer-2 is busy);\n * clearer handling of failure in ccid3_first_li().\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "22338f09bd60434a3f1d6608f0fa55972067985f", "tree": "c7ec32e782d5c96a060e56cf4b34ddf78c60aadf", "parents": [ "49ffc29a0223adbe0ea7005eea3ab2a03abbeb06" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:42 2008 +0200" }, "message": "dccp tfrc: Increase number of RTT samples\n\nThis improves the receiver RTT sampling algorithm so that it tries harder to get\nas many RTT samples as possible. \n\nThe algorithm is based the concepts presented in RFC 4340, 8.1, using timestamps\nand the CCVal window counter. There exist 4 cases for the CCVal difference:\n * \u003d\u003d 0: less than RTT/4 passed since last packet -- unusable;\n * \u003e 4: (much) more than 1 RTT has passed since last packet -- also unusable;\n * \u003d\u003d 4: perfect sample (exactly one RTT has passed since last packet);\n * 1..3: sub-optimal sample (between RTT/4 and 3*RTT/4 has passed).\n\nIn the last case the algorithm tried to optimise by storing away the candidate\nand then re-trying next time. The problem is that\n * a large number of samples is needed to smooth out the inaccuracies of the\n algorithm;\n * the sender may not be sending enough packets to warrant a \"next time\";\n * hence it is better to use suboptimal samples whenever possible.\nThe algorithm now stores away the current sample only if the difference is 0.\n\nApplicability and background\n----------------------------\nA realistic example is MP3 streaming where packets are sent at a rate of less\nthan one packet per RTT, which means that suitable samples are absent for a\nvery long time.\n\nThe effectiveness of using suboptimal samples (with a delta between 1 and 4) was\nconfirmed by instrumenting the algorithm with counters. The results of two 20\nsecond test runs were:\n * With the old algorithm and a total of 38442 function calls, only 394 of these\n calls resulted in usable RTT samples (about 1%), and 378 out of these were\n \"perfect\" samples and 28013 (unused) samples had a delta of 1..3.\n * With the new algorithm and a total of 37057 function calls, 1702 usable RTT\n samples were retrieved (about 4.6%), 5 out of these were \"perfect\" samples.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "49ffc29a0223adbe0ea7005eea3ab2a03abbeb06", "tree": "d7bf19858c85b5dbb6bded3f543fbf8a6a355a2e", "parents": [ "2b81143aa3505e2460b24b357996c2f21840ea58" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:41 2008 +0200" }, "message": "dccp: Clamping RTT values\n\nThis extracts the clamping part of dccp_sample_rtt() and makes it available\nto other parts of the code (as e.g. used in the next patch).\n\nNote: The function dccp_sample_rtt() now reduces to subtracting the elapsed\ntime. This could be eliminated but would require shorter prefixes and thus\nis not done by this patch - maybe an idea for later.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "2b81143aa3505e2460b24b357996c2f21840ea58", "tree": "37f752fb85c563f965655cec834bb289fd831137", "parents": [ "2f3e3bbad917c426d3aba03a535809e5699de156" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:41 2008 +0200" }, "message": "dccp ccid-3: Always perform receiver RTT sampling\n\nThis updates the CCID-3 receiver in part with regard to errata 610 and 611\n(http://www.rfc-editor.org/errata_list.php), which change RFC 4342 to use the\nReceive Rate as specified in rfc3448bis, requiring to constantly sample the\nRTT (or use a sender RTT).\n\nDoing this requires reusing the RX history structure after dealing with a loss.\n\nThe patch does not resolve how to compute X_recv if the interval is less\nthan 1 RTT. A FIXME has been added (and is resolved in subsequent patch).\n\nFurthermore, since this is all TFRC-based functionality, the RTT estimation\nis now also performed by the dccp_tfrc_lib module. This further simplifies\nthe CCID-3 code.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "2f3e3bbad917c426d3aba03a535809e5699de156", "tree": "e00bd5c8ccfad4444e8cc6ee8eb0d90223292390", "parents": [ "34a081be8e14b7ada70e069b65b05d54db4af497" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:41 2008 +0200" }, "message": "dccp ccid-3: Remove duplicate RX states\n\nThe only state information that the CCID-3 receiver keeps is whether initial \nfeedback has been sent or not. Further, this overlaps with use of feedback:\n\n * state \u003d\u003d TFRC_RSTATE_NO_DATA as long as no feedback has been sent;\n * state \u003d\u003d TFRC_RSTATE_DATA as soon as the first feedback has been sent.\n\nThis patch reduces the duplication, by memorising the type of the last feedback.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "34a081be8e14b7ada70e069b65b05d54db4af497", "tree": "0304cc3c06e1ee9139d6dab01df07c8d073cd323", "parents": [ "3ca7aea04152255bb65275b0018d3c673bc1f4e7" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:41 2008 +0200" }, "message": "dccp tfrc: Let dccp_tfrc_lib do the sampling work\n\nThis migrates more TFRC-related code into the dccp_tfrc_lib:\n * sampling of the packet size `s\u0027 (which is only needed until the first\n loss interval is computed (ccid3_first_li));\n * updating the byte-counter `bytes_recvd\u0027 in between sending feedbacks.\nThe result is a better separation of CCID-3 specific and TFRC specific\ncode, which aids future integration with ECN and e.g. CCID-4.\n\nFurther changes:\n----------------\n * replaced magic number of 536 with equivalent constant TCP_MIN_RCVMSS;\n (this constant is also used when no estimate for `s\u0027 is available).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "3ca7aea04152255bb65275b0018d3c673bc1f4e7", "tree": "828ffb82255e3a5f164039223e87145af0d611e5", "parents": [ "d20ed95f8bf3d98d31dbbab8b00bb4c1a4a140f3" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:41 2008 +0200" }, "message": "dccp tfrc: Return type of update_i_mean is void\n\nThis changes the return type of tfrc_lh_update_i_mean() to void, since that \nfunction returns always `false\u0027. This is due to \n\n \tlen \u003d dccp_delta_seqno(cur-\u003eli_seqno, DCCP_SKB_CB(skb)-\u003edccpd_seq) + 1;\n \n \tif (len - (s64)cur-\u003eli_length \u003c\u003d 0)\t/* duplicate or reordered */\n\t\treturn 0;\n\nwhich means that update_i_mean can only increase the length of the open loss\ninterval I_0, and hence the value of I_tot0 (RFC 3448, 5.4). Consequently the\ntest `i_mean \u003c old_i_mean\u0027 at the end of the function always evaluates to false.\n\nThere is no known way by which a loss interval can suddenly become shorter,\ntherefore the return type of the function is changed to void. (That is, under\nthe given circumstances step (3) in RFC 3448, 6.1 will not occur.)\n\nFurther changes:\n----------------\n * the function is now called from tfrc_rx_handle_loss, which is equivalent\n to the previous way of calling from rx_packet_recv (it was called whenever\n there was no new or pending loss, now it is also updated when there is\n a pending loss - this increases the accuracy a bit);\n * added a FIXME to possibly consider NDP counting as per RFC 4342 (this is\n not implemented yet).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "d20ed95f8bf3d98d31dbbab8b00bb4c1a4a140f3", "tree": "a740d35fd710618863a63e4b86ecaedc2ea5497b", "parents": [ "24b8d343215919c7a2ba18b9f89a0961e1459cad" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:40 2008 +0200" }, "message": "dccp tfrc: Perform early loss detection\n\nThis enables the TFRC code to begin loss detection (as soon as the module\nis loaded), using the latest updates from rfc3448bis-06, 6.3.1:\n\n * when the first data packet(s) are lost or marked, set\n * X_target \u003d s/(2*R) \u003d\u003e f(p) \u003d s/(R * X_target) \u003d 2,\n * corresponding to a loss rate of ~ 20.64%.\n\nThe handle_loss() function is now called right at the begin of rx_packet_recv()\nand thus no longer protected against duplicates: hence a call to rx_duplicate()\nhas been added. Such a call makes sense now, as the previous patch initialises\nthe first entry with a sequence number of GSR.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "24b8d343215919c7a2ba18b9f89a0961e1459cad", "tree": "2b97062dae6e80bb178a0cd0354aa71fe884ef30", "parents": [ "8b67ad12b04ef7bdf5d2b4de24fe5a609b26cf12" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:40 2008 +0200" }, "message": "dccp tfrc: Receiver history initialisation routine\n\nThis patch \n 1) separates history allocation and initialisation, to facilitate early\n loss detection (implemented by a subsequent patch);\n\n 2) removes duplication by using the existing tfrc_rx_hist_purge() if the\n allocation fails. This is now possible, since the initialisation routine\n 3) zeroes out the entire history before using it. \n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "8b67ad12b04ef7bdf5d2b4de24fe5a609b26cf12", "tree": "e434f1de89f42008020f6aa4767c0dc0b81c9e17", "parents": [ "d0c05fe4448db5cbdd886186860581f736f59ae9" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:40 2008 +0200" }, "message": "dccp tfrc: Suppress unavoidable \"below resolution\" warning\n\nIn the congestion-avoidance phase a decay of p towards 0 is natural once fewer\nlosses are encountered. Hence the warning message \"p is below resolution\" is\nnot necessary, and thus turned into a debug message by this patch.\n\nThe TFRC_SMALLEST_P is needed since in theory p never actually reaches 0. When\nno further losses are encountered, the loss interval I_0 grows in length, \ncausing p to decrease towards 0, causing X_calc \u003d s/(RTT * f(p)) to increase.\n\nWith the given minimum-resolution this congestion avoidance phase stops at some\nfixed value, an approximation formula has been added to the documentation.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "d0c05fe4448db5cbdd886186860581f736f59ae9", "tree": "883543f6992615a8cf9404a8904d35cdde46ddc3", "parents": [ "f76fd327a8b32d3ad5b51639faf6f54d18be0981" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:40 2008 +0200" }, "message": "dccp ccid-3: Simplified handling of TX states\n\nSince CCIDs are only used during the established phase of a connection,\nthey have very little internal state; this specifically reduces to:\n\n * \"no packet sent\" if and only if s \u003d\u003d 0, for the TX packet size s;\n\n * when the first packet has been sent (i.e. `s\u0027 \u003e 0), the question is whether\n or not feedback has been received:\n - if a feedback packet is received, \"feedback \u003d yes\" is set,\n - if the nofeedback timer expires, \"feedback \u003d no\" is set.\n\nThus the CCID only needs to remember state about whether or not feedback\nhas been received. This is now implemented using a boolean flag, which is\ntoggled when a feedback packet arrives or the nofeedback timer expires.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "f76fd327a8b32d3ad5b51639faf6f54d18be0981", "tree": "86de66d77206ff624cce7402f73f97ea3575a6c9", "parents": [ "7d1af6a8d935678248d057564e75e1452409a53c" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:40 2008 +0200" }, "message": "dccp ccid-3: Runtime verification of timer resolution\n\nThe DCCP base time resolution is 10 microseconds (RFC 4340, 13.1 ... 13.3).\n\nUsing a timer with a lower resolution was found to trigger the following\nbug warnings/problems on high-speed networks (e.g. local loopback):\n * RTT samples are rounded down to 0 if below resolution;\n * in some cases, negative RTT samples were observed;\n * the CCID-3 feedback timer complains that the feedback interval is 0,\n since the feedback interval is in the order of 1 RTT or less and RTT\n measurement rounded this down to 0;\nOn an Intel computer this will for instance happen when using a\nboot-time parameter of \"clocksource\u003djiffies\".\n\nThe following system log messages were observed:\n 11:24:00 kernel: BUG: delta (0) \u003c\u003d 0 at ccid3_hc_rx_send_feedback()\n 11:26:12 kernel: BUG: delta (0) \u003c\u003d 0 at ccid3_hc_rx_send_feedback()\n 11:26:30 kernel: dccp_sample_rtt: unusable RTT sample 0, using min\n 11:26:30 last message repeated 5 times\n\nThis patch defines a global constant for the time resolution, adds this in\ntimer.c, and checks the available clock resolution at CCID-3 module load time.\n\nWhen the resolution is worse than 10 microseconds, module loading exits with\na message \"socket type not supported\".\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "7d1af6a8d935678248d057564e75e1452409a53c", "tree": "06ea5f0d3e819e99609df3ef741574cdfac4aab9", "parents": [ "d6da3511d6b558d0b017777b61dc08b8fbc06ea4" ], "author": { "name": "Tomasz Grobelny", "email": "tomasz@grobelny.oswiecenia.net", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:40 2008 +0200" }, "message": "dccp qpolicy: Parameter checking of cmsg qpolicy parameters\n\nEnsure that cmsg-\u003ecmsg_type value is valid for qpolicy \nthat is currently in use.\n\nSigned-off-by: Tomasz Grobelny \u003ctomasz@grobelny.oswiecenia.net\u003e\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "d6da3511d6b558d0b017777b61dc08b8fbc06ea4", "tree": "473f9131b9e641d803bfbea174cf1dfc45aea3ca", "parents": [ "ddab05568eaa70fc92b2aae957136f188f724e9c" ], "author": { "name": "Tomasz Grobelny", "email": "tomasz@grobelny.oswiecenia.net", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:39 2008 +0200" }, "message": "dccp: Policy-based packet dequeueing infrastructure\n\nThis patch adds a generic infrastructure for policy-based dequeueing of \nTX packets and provides two policies:\n * a simple FIFO policy (which is the default) and\n * a priority based policy (set via socket options).\nBoth policies honour the tx_qlen sysctl for the maximum size of the write\nqueue (can be overridden via socket options). \n\nThe priority policy uses skb-\u003epriority internally to assign an u32 priority\nidentifier, using the same ranking as SO_PRIORITY. The skb-\u003epriority field\nis set to 0 when the packet leaves DCCP. The priority is supplied as ancillary\ndata using cmsg(3), the patch also provides the requisite parsing routines.\n\nSigned-off-by: Tomasz Grobelny \u003ctomasz@grobelny.oswiecenia.net\u003e\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "ddab05568eaa70fc92b2aae957136f188f724e9c", "tree": "895f53c4e418987c97aec350996d34e166dedfdc", "parents": [ "6224877b2ca4be5de96270a8ae490fe2ba11b0e0" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:39 2008 +0200" }, "message": "dccp: Clean up slow-path input processing\n\nThis patch rearranges the order of statements of the slow-path input processing\n(i.e. any other state than OPEN), to resolve the following issues.\n\n 1. Dependencies: the order of statements now better matches RFC 4340, 8.5, i.e.\n step 7 is before step 9 (previously 9 was before 7), and parsing options in\n step 8 (which can consume resources) now comes after step 7.\n 2. Bug-fix: in state CLOSED, there should not be any sequence number checking\n or option processing. This is why the test for CLOSED has been moved after\n the test for LISTEN.\n 3. As before sequence number checks are omitted if in state LISTEN/REQUEST, due\n to the note underneath the table in RFC 4340, 7.5.3.\n 4. Packets are now passed on to Ack Vector / CCID processing only after\n - step 7 (receive unexpected packets), \n - step 9 (receive Reset),\n - step 13 (receive CloseReq),\n - step 14 (receive Close)\n and only if the state is PARTOPEN. This simplifies CCID processing:\n - in LISTEN/CLOSED the CCIDs are non-existent;\n - in RESPOND/REQUEST the CCIDs have not yet been negotiated;\n - in CLOSEREQ and active-CLOSING the node has already closed this socket;\n - in passive-CLOSING the client is waiting for its Reset.\n In the last case, RFC 4340, 8.3 leaves it open to ignore further incoming\n data, which is the approach taken here.\n\nAs a result of (3), CCID processing is now indeed confined to OPEN/PARTOPEN\nstates, i.e. congestion control is performed only on the flow of data packets. \n\nThis avoids pathological cases of doing congestion control on those messages\nwhich set up and terminate the connection. \n\nI have done a few checks to see if this creates a problem in other parts of\nthe code. This seems not to be the case; even if there were one, it would be\nbetter to fix it than to perform congestion control on Close/Request/Response\nmessages. Similarly for Ack Vectors (as they depend on the negotiated CCID).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "6224877b2ca4be5de96270a8ae490fe2ba11b0e0", "tree": "95eef39293311959842e5476eace895e457eb780", "parents": [ "b25b0c60b0c39a82bc651aeb6443bcb36cd17f76" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:39 2008 +0200" }, "message": "tcp/dccp: Consolidate common code for RFC 3390 conversion\n\nThis patch consolidates the code common to TCP and CCID-2:\n * TCP uses RFC 3390 in a packet-oriented manner (tcp_input.c) and\n * CCID-2 uses RFC 3390 in packet-oriented manner (RFC 4341).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "b25b0c60b0c39a82bc651aeb6443bcb36cd17f76", "tree": "fbb808a03b513922b93354c240fc73b1cc914de8", "parents": [ "20bbd0f75ee4b72c1dafc8e5fb6ad39ba506a75c" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:39 2008 +0200" }, "message": "dccp: Combine the functionality of enqeueing and cloning\n\nRealising the following call pattern,\n * first dccp_entail() is called to enqueue a new skb and\n * then skb_clone() is called to transmit a clone of that skb,\n\nthis patch integrates both interrelated steps into dccp_entail().\n\nNote: the return value of skb_clone is not checked. It may be an idea to add a\n warning if this occurs. In both instances, however, a timer is set for\n retransmission, so that cloning is re-tried via dccp_retransmit_skb().\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "20bbd0f75ee4b72c1dafc8e5fb6ad39ba506a75c", "tree": "c67263fcc9ed4bab01ecbdb43393b1cb2a0dfd36", "parents": [ "1435562d7e0412e4885b661843f69859013f9d25" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:39 2008 +0200" }, "message": "dccp ccid-2: Remove wrappers around sk_{reset,stop}_timer()\n\nThis removes the wrappers around the sk timer functions as it makes the code\nclearer and not much is gained from using wrappers: the BUG_ON in \nstart_rto_timer will never trigger since that function was called only when\n * the RTO timer expired (rto_expire, and then timer_pending() is false);\n * in tx_packet_sent only if !timer_pending() (BUG_ON is redundant here);\n * previously in new_ack, after stopping the timer (timer_pending() false).\n\nOne further motive behind this patch is to replace the RTO timer with the\nicsk retransmission timer, as it is already part of the DCCP socket.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "1435562d7e0412e4885b661843f69859013f9d25", "tree": "8357027ac15fa199051e8d85aa448115c3bdd2c2", "parents": [ "e9803c0104564698d3b8e84ccdb0b8b0e65427e2" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:39 2008 +0200" }, "message": "dccp ccid-2: Replace broken RTT estimator with better algorithm\n\nThe current CCID-2 RTT estimator code is in parts broken and lags behind the\nsuggestions in RFC2988 of using scaled variants for SRTT/RTTVAR. \nThat code is replaced by the present patch, which reuses the Linux TCP RTT\nestimator code - reasons for this code duplication are given below.\n\nFurther details:\n----------------\n 1. The minimum RTO of previously one second has been replaced with TCP\u0027s, since\n RFC4341, sec. 5 says that the minimum of 1 sec. (suggested in RFC2988, 2.4)\n is not necessary. Instead, the TCP_RTO_MIN is used, which agrees with DCCP\u0027s\n concept of a default RTT (RFC 4340, 3.4). \n 2. The maximum RTO has been set to DCCP_RTO_MAX (64 sec), which agrees with \n RFC2988, (2.5). \n 3. De-inlined the function ccid2_new_ack().\n 4. Added a FIXME: the RTT is sampled several times per Ack Vector, which will\n give the wrong estimate. It should be replaced with one sample per Ack.\n However, at the moment this can not be resolved easily, since \n - it depends on TX history code (which also needs some work),\n - the cleanest solution is not to use the `sent\u0027 time at all (saves 4 bytes\n per entry) and use DCCP timestamps / elapsed time to estimated the RTT,\n which however is non-trivial to get right (but needs to be done).\n\nReasons for reusing the Linux TCP estimator algorithm: \n------------------------------------------------------\nSome time was spent to find a better alternative, using basic RFC2988 as a first\nstep. Further analysis and experimentation showed that the Linux TCP RTO\nestimator is superior to a basic RFC2988 implementation. A summary is on\nhttp://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/ccid2/rto_estimator/\n\nIn addition, this estimator fared well in a recent empirical evaluation:\n\n Rewaskar, Sushant, Jasleen Kaur and F. Donelson Smith.\n A Performance Study of Loss Detection/Recovery in Real-world TCP\n Implementations. Proceedings of 15th IEEE International\n Conference on Network Protocols (ICNP-07). 2007.\n\nThus there is significant benefit in reusing the existing TCP code.\n\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "e9803c0104564698d3b8e84ccdb0b8b0e65427e2", "tree": "2bdc72974473e43d48366b7484615d723a782e05", "parents": [ "c6f0f2e71f3088a0f05502d6adb0f667b84028c3" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:38 2008 +0200" }, "message": "dccp ccid-2: Simplify dec_pipe and rearming of RTO timer\n\nThis removes the dec_pipe function and improves the way the RTO timer is rearmed\nwhen a new acknowledgment comes in.\n\nDetails and justification for removal:\n--------------------------------------\n 1) The BUG_ON in dec_pipe is never triggered: pipe is only decremented for TX \n history entries between tail and head, for which it had previously been \n incremented in tx_packet_sent; and it is not decremented twice for the same\n entry, since it is\n - either decremented when a corresponding Ack Vector cell in state 0 or 1 \n was received (and then ccid2s_acked\u003d\u003d1),\n - or it is decremented when ccid2s_acked\u003d\u003d0, as part of the loss detection\n in tx_packet_recv (and hence it can not have been decremented earlier).\n\n 2) Restarting the RTO timer happens for every single entry in each Ack Vector\n parsed by tx_packet_recv (according to RFC 4340, 11.4 this can happen up to\n 16192 times per Ack Vector). \n\n 3) The RTO timer should not be restarted when all outstanding data has been\n acknowledged. This is currently done similar to (2), in dec_pipe, when\n pipe has reached 0.\n\nThe patch onsolidates the code which rearms the RTO timer, combining the\nsegments from new_ack and dec_pipe. As a result, the code becomes clearer\n(compare with tcp_rearm_rto()).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "c6f0f2e71f3088a0f05502d6adb0f667b84028c3", "tree": "6ab76387d836075f75fcb7ece70c0b76f241b509", "parents": [ "83337dae6ca94d801b6700600244865cd694205b" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:38 2008 +0200" }, "message": "dccp ccid-2: Remove redundant sanity tests\n\nThis removes the ccid2_hc_tx_check_sanity function: it is redundant.\n\nDetails:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nThe tx_check_sanity function performs three tests:\n 1) it checks that the circular TX list is sorted\n - in ascending order of sequence number (ccid2s_seq) \n - and time (ccid2s_sent),\n - in the direction from `tail\u0027 (hctx_seqt) to `head\u0027 (hctx_seqh);\n 2) it ensures that the entire list has the length seqbufc * CCID2_SEQBUF_LEN;\n 3) it ensures that pipe equals the number of packets that were not\n marked `acked\u0027 (ccid2s_acked) between `tail\u0027 and `head\u0027.\n\nThe following argues that each of these tests is redundant, this can be verified\nby going through the code.\n\n(1) is not necessary, since both time and GSS increase from one packet to the\nnext, so that subsequent insertions in tx_packet_sent (which advance the `head\u0027\npointer) will be in ascending order of time and sequence number.\n\nIn (2), the length of the list is always equal to seqbufc times CCID2_SEQBUF_LEN\n(set to 1024) unless allocation caused an earlier failure, because:\n * at initialisation (tx_init), there is one chunk of size 1024 and seqbufc\u003d1;\n * subsequent calls to tx_alloc_seq take place whenever head-\u003enext \u003d\u003d tail in \n tx_packet_sent; then a new chunk of size 1024 is inserted between head and\n tail, and seqbufc is incremented by one.\n\nTo show that (3) is redundant requires looking at two cases. \n\nThe `pipe\u0027 variable of the TX socket is incremented only in tx_packet_sent, and \ndecremented in tx_packet_recv. When head \u003d\u003d tail (TX history empty) then pipe\nshould be 0, which is the case directly after initialisation and after a\nretransmission timeout has occurred (ccid2_hc_tx_rto_expire).\n\nThe first case involves parsing Ack Vectors for packets recorded in the live\nportion of the buffer, between tail and head. For each packet marked by the\nreceiver as received (state 0) or ECN-marked (state 1), pipe is decremented by\none, so for all such packets the BUG_ON in tx_check_sanity will not trigger.\n\nThe second case is the loss detection in the second half of tx_packet_recv,\nbelow the comment \"Check for NUMDUPACK\".\n\nThe first while-loop here ensures that the sequence number of `seqp\u0027 is either\nabove or equal to `high_ack\u0027, or otherwise equal to the highest sequence number\nsent so far (of the entry head-\u003eprev, as head points to the next unsent entry).\nThe next while-loop (\"while (1)\") counts the number of acked packets starting\nfrom that position of seqp, going backwards in the direction from head-\u003eprev to\ntail. If NUMDUPACK\u003d3 such packets were counted within this loop, `seqp\u0027 points\nto the last acknowledged packet of these, and the \"if (done \u003d\u003d NUMDUPACK)\" block\nis entered next. \nThe while-loop contained within that block in turn traverses the list backwards,\nfrom head to tail; the position of `seqp\u0027 is saved in the variable `last_acked\u0027. \nFor each packet not marked as `acked\u0027, a congestion event is triggered within \nthe loop, and pipe is decremented. The loop terminates when `seqp\u0027 has reached\n`tail\u0027, whereupon tail is set to the position previously stored in `last_acked\u0027.\nThus, between `last_acked\u0027 and the previous position of `tail\u0027, \n - pipe has been decremented earlier if the packet was marked as state 0 or 1;\n - pipe was decremented if the packet was not marked as acked.\nThat is, pipe has been decremented by the number of packets between `last_acked\u0027\nand the previous position of `tail\u0027. As a consequence, pipe now again reflects\nthe number of packets which have not (yet) been acked between the new position\nof tail (at `last_acked\u0027) and head-\u003eprev, or 0 if head\u003d\u003dtail. The result is that\nthe BUG_ON condition in check_sanity will also not be triggered, hence the test\n(3) is also redundant.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "83337dae6ca94d801b6700600244865cd694205b", "tree": "8d46dcc50324ce3842f94c40a332b9689e488eab", "parents": [ "146993cf5174472644ed11bd5fb539f0af8bfa49" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:38 2008 +0200" }, "message": "dccp ccid-2: Stop polling\n\nThis updates CCID2 to use the CCID dequeuing mechanism, converting from\nprevious constant-polling to a now event-driven mechanism.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "146993cf5174472644ed11bd5fb539f0af8bfa49", "tree": "b2c5343ad610fe113425a3663f0dc3ddb478911b", "parents": [ "e7937772d7a2b0127cc4cbc67bc594e139fdaf63" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:38 2008 +0200" }, "message": "dccp: Refine the wait-for-ccid mechanism\n\nThis extends the existing wait-for-ccid routine so that it may be used with\ndifferent types of CCID. It further addresses the problems listed below.\n\nThe code looks if the write queue is non-empty and grants the TX CCID up to\n`timeout\u0027 jiffies to drain the queue. It will instead purge that queue if\n * the delay suggested by the CCID exceeds the time budget;\n * a socket error occurred while waiting for the CCID;\n * there is a signal pending (eg. annoyed user pressed Control-C);\n * the CCID does not support delays (we don\u0027t know how long it will take).\n\n\n D e t a i l s [can be removed]\n -------------------------------\nDCCP\u0027s sending mechanism functions a bit like non-blocking I/O: dccp_sendmsg()\nwill enqueue up to net.dccp.default.tx_qlen packets (default\u003d5), without waiting\nfor them to be released to the network.\n\nRate-based CCIDs, such as CCID3/4, can impose sending delays of up to maximally\n64 seconds (t_mbi in RFC 3448). Hence the write queue may still contain packets\nwhen the application closes. Since the write queue is congestion-controlled by\nthe CCID, draining the queue is also under control of the CCID.\n\nThere are several problems that needed to be addressed:\n 1) The queue-drain mechanism only works with rate-based CCIDs. If CCID2 for\n example has a full TX queue and becomes network-limited just as the\n application wants to close, then waiting for CCID2 to become unblocked could\n lead to an indefinite delay (i.e., application \"hangs\").\n 2) Since each TX CCID in turn uses a feedback mechanism, there may be changes\n in its sending policy while the queue is being drained. This can lead to\n further delays during which the application will not be able to terminate.\n 3) The minimum wait time for CCID3/4 can be expected to be the queue length\n times the current inter-packet delay. For example if tx_qlen\u003d100 and a delay\n of 15 ms is used for each packet, then the application would have to wait\n for a minimum of 1.5 seconds before being allowed to exit.\n 4) There is no way for the user/application to control this behaviour. It would\n be good to use the timeout argument of dccp_close() as an upper bound. Then\n the maximum time that an application is willing to wait for its CCIDs to can\n be set via the SO_LINGER option.\n\nThese problems are addressed by giving the CCID a grace period of up to the\n`timeout\u0027 value.\n\nThe wait-for-ccid function is, as before, used when the application \n (a) has read all the data in its receive buffer and\n (b) if SO_LINGER was set with a non-zero linger time, or\n (c) the socket is either in the OPEN (active close) or in the PASSIVE_CLOSEREQ\n state (client application closes after receiving CloseReq).\n\nIn addition, there is a catch-all case by calling __skb_queue_purge() after \nwaiting for the CCID. This is necessary since the write queue may still have\ndata when\n (a) the host has been passively-closed,\n (b) abnormal termination (unread data, zero linger time),\n (c) wait-for-ccid could not finish within the given time limit.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "e7937772d7a2b0127cc4cbc67bc594e139fdaf63", "tree": "3d56098b6fcdecbf70453d74c2065a8e33134d1e", "parents": [ "f4a66ca4d2ff093c0f9111b449a248ffb8209b4d" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:38 2008 +0200" }, "message": "dccp: Extend CCID packet dequeueing interface\n\nThis extends the packet dequeuing interface of dccp_write_xmit() to allow\n 1. CCIDs to take care of timing when the next packet may be sent;\n 2. delayed sending (as before, with an inter-packet gap up to 65.535 seconds).\n\nThe main purpose is to take CCID2 out of its polling mode (when it is network-\nlimited, it tries every millisecond to send, without interruption).\nThe interface can also be used to support other CCIDs.\n\nThe mode of operation for (2) is as follows:\n * new packet is enqueued via dccp_sendmsg() \u003d\u003e dccp_write_xmit(),\n * ccid_hc_tx_send_packet() detects that it may not send (e.g. window full), \n * it signals this condition via `CCID_PACKET_WILL_DEQUEUE_LATER\u0027,\n * dccp_write_xmit() returns without further action;\n * after some time the wait-condition for CCID becomes true,\n * that CCID schedules the tasklet,\n * tasklet function calls ccid_hc_tx_send_packet() via dccp_write_xmit(),\n * since the wait-condition is now true, ccid_hc_tx_packet() returns \"send now\",\n * packet is sent, and possibly more (since dccp_write_xmit() loops).\n\nCode reuse: the taskled function calls dccp_write_xmit(), the timer function\n reduces to a wrapper around the same code.\n\nIf the tasklet finds that the socket is locked, it re-schedules the tasklet\nfunction (not the tasklet) after one jiffy.\n\nChanged DCCP_BUG to dccp_pr_debug when transmit_skb returns an error (e.g. when a\nlocal qdisc is used, NET_XMIT_DROP\u003d1 can be returned for many packets).\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "f4a66ca4d2ff093c0f9111b449a248ffb8209b4d", "tree": "0643f7420a1d0b071f12c719129750d2028bb6e1", "parents": [ "c8bf462bc567c3dcb083ff95cc13060dd06f138c" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:38 2008 +0200" }, "message": "dccp: Return-value convention of hc_tx_send_packet()\n\nThis patch reorganises the return value convention of the CCID TX sending\nfunction, to permit more flexible schemes, as required by subsequent patches.\n\nCurrently the convention is \n * values \u003c 0 mean error,\n * a value \u003d\u003d 0 means \"send now\", and\n * a value x \u003e 0 means \"send in x milliseconds\".\n\nThe patch provides symbolic constants and a function to interpret return values.\nIn addition, it caps the maximum positive return value to 0xFFFF milliseconds,\ncorresponding to 65.535 seconds. \n\nThis is possible since in CCID-3 the maximum inter-packet gap is t_mbi \u003d 64 sec.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "c8bf462bc567c3dcb083ff95cc13060dd06f138c", "tree": "c612129b23db7bb8613fff4c6e2d51301bc77f65", "parents": [ "5a577b488f687f339dea62e7bb4f4c5793ad523f" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:37 2008 +0200" }, "message": "dccp ccid-2: Separate option parsing from CCID processing\n\nThis patch replaces an almost identical replication of code: large parts\nof dccp_parse_options() re-appeared as ccid2_ackvector() in ccid2.c.\n\nApart from the duplication, this caused two more problems:\n 1. CCIDs should not need to be concerned with parsing header options;\n 2. one can not assume that Ack Vectors appear as a contiguous area within an\n skb, it is legal to insert other options and/or padding in between. The\n current code would throw an error and stop reading in such a case.\n\nThe patch provides a new data structure and associated list housekeeping.\n\nOnly small changes were necessary to integrate with CCID-2: data structure\ninitialisation, adapt list traversal routine, and add call to the provided\ncleanup routine.\n\nThe latter also lead to fixing the following BUG: CCID-2 so far ignored\nAck Vectors on all packets other than Ack/DataAck, which is incorrect,\nsince Ack Vectors can be present on any packet that has an Ack field.\n\nDetails:\n--------\n * received Ack Vectors are parsed by dccp_parse_options() alone, which passes\n the result on to the CCID-specific routine ccid_hc_tx_parse_options();\n * CCIDs interested in using/decoding Ack Vector information will add code\n to fetch parsed Ack Vectors via this interface;\n * a data structure, `struct dccp_ackvec_parsed\u0027 is provided as interface;\n * this structure arranges Ack Vectors of the same skb into a FIFO order;\n * a doubly-linked list is used to keep the required FIFO code small.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "5a577b488f687f339dea62e7bb4f4c5793ad523f", "tree": "7be4c34a22de21e66f33d5b4bdfc2eb547f67091", "parents": [ "c2f42077bd06f300ae959204f3c007f820f5e769" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:37 2008 +0200" }, "message": "dccp ccid-2: Remove old infrastructure\n\nThis removes\n * functions for which updates have been provided in the preceding patches and\n * the @av_vec_len field - it is no longer necessary since the buffer length is\n now always computed dynamically;\n * conditional debugging code (CONFIG_IP_DCCP_ACKVEC).\n\nThe reason for removing the conditional debugging code is that Ack Vectors are \nan almost inevitable necessity - RFC 4341 says that for CCID-2, Ack Vectors must\nbe used. Furthermore, the code would be only interesting for coding - after some \nextensive testing with this patch set, having the debug code around is no longer\nof real help.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "c2f42077bd06f300ae959204f3c007f820f5e769", "tree": "7e3d9c3c8b18f18b35a6ce19d84467ae8711521c", "parents": [ "283fb4a5f39d1521d53e1044bff0ba2654acf145" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:37 2008 +0200" }, "message": "dccp ccid-2: Schedule Sync as out-of-band mechanism\n\nThe problem with Ack Vectors is that \n\n i) their length is variable and can in principle grow quite large,\n ii) it is hard to predict exactly how large they will be.\n\nDue to the second point it seems not a good idea to reduce the MPS; in\nparticular when on average there is enough room for the Ack Vector and an\nincrease in length is momentarily due to some burst loss, after which the\nAck Vector returns to its normal/average length.\n\nThe solution taken by this patch is to subtract a minimum-expected Ack Vector\nlength from the MPS (previous patch), and to defer any larger Ack Vectors onto\na separate Sync - but only if indeed there is no space left on the skb.\n\nThis patch provides the infrastructure to schedule Sync-packets for transporting\n(urgent) out-of-band data. Its signalling is quicker than scheduling an Ack, since\nit does not need to wait for new application data.\n\nIt can thus serve other parts of the DCCP code as well.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "283fb4a5f39d1521d53e1044bff0ba2654acf145", "tree": "e813566d7b3530702410d470f85cf2162e443bb3", "parents": [ "e28fe59f9c82ef55fc9b55e745531c9fed86f00a" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:37 2008 +0200" }, "message": "dccp ccid-2: Consolidate Ack-Vector processing within main DCCP module\n\nThis aggregates Ack Vector processing (handling input and clearing old state)\ninto one function, for the following reasons and benefits:\n * all Ack Vector-specific processing is now in one place;\n * duplicated code is removed;\n * ensuring sanity: from an Ack Vector point of view, it is better to clear the\n old state first before entering new state;\n * Ack Event handling happens mostly within the CCIDs, not the main DCCP module.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e \n" }, { "commit": "e28fe59f9c82ef55fc9b55e745531c9fed86f00a", "tree": "3b469804ebeb8e772c9f935015381706495cdd18", "parents": [ "68b1de15765f2b0e0925e692dab2b2fa2abd93fc" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:37 2008 +0200" }, "message": "dccp ccid-2: Update code for the Ack Vector input/registration routine\n\nThis patch uupdates the code which registers new packets as received, using the\nnew circular buffer interface. It contributes a new algorithm which \n\t* supports both tail/head pointers and buffer wrap-around and\n\t* deals with overflow (head/tail move in lock-step).\n\nThe updated code is also partioned differently, into\n\t1. dealing with the empty buffer,\n\t2. adding new packets into non-empty buffer,\n\t3. reserving space when encountering a `hole\u0027 in the sequence space,\n\t4. updating old state and deciding when old state is irrelevant.\n\nProtection against large burst losses: With regard to (3), it is too costly to\nreserve space when there are large bursts of losses. When bursts get too large,\nthe code does no longer reserve space and just fills in cells normally. This\nmeasure reduces space consumption by a factor of 63.\n\nThe code reuses in part the previous implementation by Arnaldo de Melo.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "68b1de15765f2b0e0925e692dab2b2fa2abd93fc", "tree": "893594a088a7d9ba4bff6c1820ec014740ca62bf", "parents": [ "d7dc7e5f49299739e610ea8febf9ea91a4dc1ae9" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:37 2008 +0200" }, "message": "dccp ccid-2: Algorithm to update buffer state\n\nThis provides a routine to consistently update the buffer state when the\npeer acknowledges receipt of Ack Vectors; updating state in the list of Ack\nVectors as well as in the circular buffer.\n\nWhile based on RFC 4340, several additional (and necessary) precautions were\nadded to protect the consistency of the buffer state. These additions are\nessential, since analysis and experience showed that the basic algorithm was\ninsufficient for this task (which lead to problems that were hard to debug).\n\nThe algorithm now\n * deals with HC-sender acknowledging to HC-receiver and vice versa,\n * keeps track of the last unacknowledged but received seqno in tail_ackno,\n * has special cases to reset the overflow condition when appropriate,\n * is protected against receiving older information (would mess up buffer state).\n\nNote: The older code performed an unnecessary step, where the sender cleared\nAck Vector state by parsing the Ack Vector received by the HC-receiver. Doing\nthis was entirely redundant, since\n * the receiver always puts the full acknowledgment window (groups 2,3 in 11.4.2)\n into the Ack Vectors it sends; hence the HC-receiver is only interested in the\n highest state that the HC-sender received;\n * this means that the acknowledgment number on the (Data)Ack from the HC-sender\n is sufficient; and work done in parsing earlier state is not necessary, since\n the later state subsumes the earlier one (see also RFC 4340, A.4).\nThis older interface (dccp_ackvec_parse()) is therefore removed.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "d7dc7e5f49299739e610ea8febf9ea91a4dc1ae9", "tree": "30a2e1c3b9e99b1a386ca99efa71769415437885", "parents": [ "4829007c7bc689cbc290fc09eccbe90bd52c2a5e" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:36 2008 +0200" }, "message": "dccp ccid-2: Implementation of circular Ack Vector buffer with overflow handling\n\nThis completes the implementation of a circular buffer for Ack Vectors, by \nextending the current (linear array-based) implementation. The changes are:\n\n (a) An `overflow\u0027 flag to deal with the case of overflow. As before, dynamic\n growth of the buffer will not be supported; but code will be added to deal\n robustly with overflowing Ack Vector buffers.\n\n (b) A `tail_seqno\u0027 field. When naively implementing the algorithm of Appendix A\n in RFC 4340, problems arise whenever subsequent Ack Vector records overlap,\n which can bring the entire run length calculation completely out of synch.\n (This is documented on http://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/\\\n ack_vectors/tracking_tail_ackno/ .)\n (c) The buffer lengthi is now computed dynamically (i.e. current fill level),\n as the span between head to tail.\n\nAs a result, dccp_ackvec_pending() is now simpler - the #ifdef is no longer \nnecessary since buf_empty is always true when IP_DCCP_ACKVEC is not configured.\n\nNote on overflow handling: \n-------------------------\n The Ack Vector code previously simply started to drop packets when the\n Ack Vector buffer overflowed. This means that the userspace application\n will not be able to receive, only because of an Ack Vector storage problem.\n \n Furthermore, overflow may be transient, so that applications may later\n recover from the overflow. Recovering from dropped packets is more difficult\n (e.g. video key frames).\n \n Hence the patch uses a different policy: when the buffer overflows, the oldest\n entries are subsequently overwritten. This has a higher chance of recovery.\n Details are on http://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/ack_vectors/\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "4829007c7bc689cbc290fc09eccbe90bd52c2a5e", "tree": "f8f2058b9db8e8df7b4cb2f1f850ca3115e5c58f", "parents": [ "ff49e27089ec363b7fc3849504e0435d447ab18a" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:36 2008 +0200" }, "message": "dccp ccid-2: Separate internals of Ack Vectors from option-parsing code\n\nThis patch\n * separates Ack Vector housekeeping code from option-insertion code;\n * shifts option-specific code from ackvec.c into options.c;\n * introduces a dedicated routine to take care of the Ack Vector records;\n * simplifies the dccp_ackvec_insert_avr() routine: the BUG_ON was redundant, \n since the list is automatically arranged in descending order of ack_seqno.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "ff49e27089ec363b7fc3849504e0435d447ab18a", "tree": "eb6f7d4ec829f2c0ca206c0769c15c08e592743c", "parents": [ "b8c6bcee1dbc1aadcd67af998e414e73fa166a7d" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:36 2008 +0200" }, "message": "dccp ccid-2: Ack Vector interface clean-up\n\nThis patch brings the Ack Vector interface up to date. Its main purpose is\nto lay the basis for the subsequent patches of this set, which will use the\nnew data structure fields and routines.\n\nThere are no real algorithmic changes, rather an adaptation:\n\n (1) Replaced the static Ack Vector size (2) with a #define so that it can\n be adapted (with low loss / Ack Ratio, a value of 1 works, so 2 seems\n to be sufficient for the moment) and added a solution so that computing\n the ECN nonce will continue to work - even with larger Ack Vectors.\n\n (2) Replaced the #defines for Ack Vector states with a complete enum.\n\n (3) Replaced #defines to compute Ack Vector length and state with general\n purpose routines (inlines), and updated code to use these.\n\n (4) Added a `tail\u0027 field (conversion to circular buffer in subsequent patch).\n\n (5) Updated the (outdated) documentation for Ack Vector struct.\n\n (6) All sequence number containers now trimmed to 48 bits.\n\n (7) Removal of unused bits:\n * removed dccpav_ack_nonce from struct dccp_ackvec, since this is already\n redundantly stored in the `dccpavr_ack_nonce\u0027 (of Ack Vector record);\n * removed Elapsed Time for Ack Vectors (it was nowhere used);\n * replaced semantics of dccpavr_sent_len with dccpavr_ack_runlen, since\n the code needs to be able to remember the old run length; \n * reduced the de-/allocation routines (redundant / duplicate tests).\n\n\nJustification for removing Elapsed Time information [can be removed]:\n---------------------------------------------------------------------\n 1. The Elapsed Time information for Ack Vectors was nowhere used in the code.\n 2. DCCP does not implement rate-based pacing of acknowledgments. The only\n recommendation for always including Elapsed Time is in section 11.3 of\n RFC 4340: \"Receivers that rate-pace acknowledgements SHOULD [...]\n include Elapsed Time options\". But such is not the case here.\n 3. It does not really improve estimation accuracy. The Elapsed Time field only\n records the time between the arrival of the last acknowledgeable packet and\n the time the Ack Vector is sent out. Since Linux does not (yet) implement\n delayed Acks, the time difference will typically be small, since often the\n arrival of a data packet triggers sending feedback at the HC-receiver.\n\n\nJustification for changes in de-/allocation routines [can be removed]:\n----------------------------------------------------------------------\n * INIT_LIST_HEAD in dccp_ackvec_record_new was redundant, since the list\n pointers were later overwritten when the node was added via list_add();\n * dccp_ackvec_record_new() was called in a single place only;\n * calls to list_del_init() before calling dccp_ackvec_record_delete() were\n redundant, since subsequently the entire element was k-freed;\n * since all calls to dccp_ackvec_record_delete() were preceded to a call to\n list_del_init(), the WARN_ON test would never evaluate to true;\n * since all calls to dccp_ackvec_record_delete() were made from within\n list_for_each_entry_safe(), the test for avr \u003d\u003d NULL was redundant;\n * list_empty() in ackvec_free was redundant, since the same condition is\n embedded in the loop condition of the subsequent list_for_each_entry_safe().\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "b8c6bcee1dbc1aadcd67af998e414e73fa166a7d", "tree": "ac391375ffdbb5c3617fcb8672b83c6eff72bbe6", "parents": [ "a9c1656ab10480cc6f6d34f193bcde2729fe8037" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:36 2008 +0200" }, "message": "dccp: Reduce noise in output and convert to ktime_t\n\nThis fixes the problem that dccp_probe output can grow quite large without\napparent benefit (many identical data points), creating huge files (up to\nover one Gigabyte for a few minutes\u0027 test run) which are very hard to \npost-process (in one instance it got so bad that gnuplot ate up all memory\nplus swap).\n\nThe cause for the problem is that the kprobe is inserted into dccp_sendmsg(),\nwhich can be called in a polling-mode (whenever the TX queue is full due to\ncongestion-control issues, EAGAIN is returned). This creates many very \nsimilar data points, i.e. the increase of processing time does not increase\nthe quality/information of the probe output.\n\nThe fix is to attach the probe to a different function -- write_xmit was\nchosen since it gets called continually (both via userspace and timer);\nan input-path function would stop sampling as soon as the other end stops\nsending feedback.\n\nFor comparison the output file sizes for the same 20 second test\nrun over a lossy link:\n * before / without patch: 118 Megabytes\n * after / with patch: 1.2 Megabytes\nand there was much less noise in the output. \n\nTo allow backward compatibility with scripts that people use, the now-unused\n`size\u0027 field in the output has been replaced with the CCID identifier. This\nalso serves for future compatibility - support for CCID2 is work in progress\n(depends on the still unfinished SRTT/RTTVAR updates).\n\nWhile at it, the update to ktime_t was also performed.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\nAcked-by: Ian McDonald \u003cian.mcdonald@jandi.co.nz\u003e\n" }, { "commit": "a9c1656ab10480cc6f6d34f193bcde2729fe8037", "tree": "ec5f69d1d95fa718d6f930b4d42060918ab64e5c", "parents": [ "bfbddd085a5bced6efb9e1bc4d029438f9639784" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:35 2008 +0200" }, "message": "dccp: Merge now-reduced connect_init() function\n\nAfter moving the assignment of GAR/ISS from dccp_connect_init() to\ndccp_transmit_skb(), the former function becomes very small, so that\na merger with dccp_connect() suggests itself.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "bfbddd085a5bced6efb9e1bc4d029438f9639784", "tree": "2187b8a4a2d4864419bd5897ccfdff57a6bc3b48", "parents": [ "2975abd251d795810932b20354729ba236d95bf9" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:35 2008 +0200" }, "message": "dccp: Fix the adjustments to AWL and SWL\n\nThis fixes a problem and a potential loophole with regard to seqno/ackno\nvalidity: the problem is that the initial adjustments to AWL/SWL were\nonly performed at the begin of the connection, during the handshake.\n\nSince the Sequence Window feature is always greater than Wmin\u003d32 (7.5.2), \nit is however necessary to perform these adjustments at least for the first\nW/W\u0027 (variables as per 7.5.1) packets in the lifetime of a connection.\n\nThis requirement is complicated by the fact that W/W\u0027 can change at any time\nduring the lifetime of a connection.\n\nTherefore the consequence is to perform this safety check each time SWL/AWL\nare updated.\n\nA second problem solved by this patch is that the remote/local Sequence Window\nfeature values (which set the bounds for AWL/SWL/SWH) are undefined until the\nfeature negotiation has completed.\n\nDuring the initial handshake we have more stringent sequence number protection,\nthe changes added by this patch effect that {A,S}W{L,H} are within the correct\nbounds at the instant that feature negotiation completes (since the SeqWin\nfeature activation handlers call dccp_update_gsr/gss()). \n\nA detailed rationale is below -- can be removed from the commit message.\n\n\n1. Server sequence number checks during initial handshake\n---------------------------------------------------------\nThe server can not use the fields of the listening socket for seqno/ackno checks\nand thus needs to store all relevant information on a per-connection basis on\nthe dccp_request socket. This is a size-constrained structure and has currently\nonly ISS (dreq_iss) and ISR (dreq_isr) defined.\nAdding further fields (SW{L,H}, AW{L,H}) would increase the size of the struct\nand it is questionable whether this will have any practical gain. The currently\nimplemented solution is as follows.\n * receiving first Request: dccp_v{4,6}_conn_request sets \n ISR :\u003d P.seqno, ISS :\u003d dccp_v{4,6}_init_sequence()\n\n * sending first Response: dccp_v{4,6}_send_response via dccp_make_response()\t\n sets P.seqno :\u003d ISS, sets P.ackno :\u003d ISR\n\n * receiving retransmitted Request: dccp_check_req() overrides ISR :\u003d P.seqno\n\n * answering retransmitted Request: dccp_make_response() sets ISS +\u003d 1,\n otherwise as per first Response\n\n * completing the handshake: succeeds in dccp_check_req() for the first Ack\n where P.ackno \u003d\u003d ISS (P.seqno is not tested)\n\n * creating child socket: ISS, ISR are copied from the request_sock\n\nThis solution will succeed whenever the server can receive the Request and the\nsubsequent Ack in succession, without retransmissions. If there is packet loss,\nthe client needs to retransmit until this condition succeeds; it will otherwise\neventually give up. Adding further fields to the request_sock could increase\nthe robustness a bit, in that it would make possible to let a reordered Ack\n(from a retransmitted Response) pass. The argument against such a solution is\nthat if the packet loss is not persistent and an Ack gets through, why not\nwait for the one answering the original response: if the loss is persistent, it\nis probably better to not start the connection in the first place.\n\nLong story short: the present design (by Arnaldo) is simple and will likely work\njust as well as a more complicated solution. As a consequence, {A,S}W{L,H} are\nnot needed until the moment the request_sock is cloned into the accept queue.\n\nAt that stage feature negotiation has completed, so that the values for the local\nand remote Sequence Window feature (7.5.2) are known, i.e. we are now in a better\nposition to compute {A,S}W{L,H}.\n\n\n2. Client sequence number checks during initial handshake\n---------------------------------------------------------\nUntil entering PARTOPEN the client does not need the adjustments, since it \nconstrains the Ack window to the packet it sent.\n\n * sending first Request: dccp_v{4,6}_connect() choose ISS, \n dccp_connect() then sets GAR :\u003d ISS (as per 8.5),\n\t\t\t dccp_transmit_skb() (with the previous bug fix) sets\n\t\t\t GSS :\u003d ISS, AWL :\u003d ISS, AWH :\u003d GSS\n * n-th retransmitted Request (with previous patch):\n\t dccp_retransmit_skb() via timer calls\n\t\t\t dccp_transmit_skb(), which sets GSS :\u003d ISS+n\n and then AWL :\u003d ISS, AWH :\u003d ISS+n\n\t \n * receiving any Response: dccp_rcv_request_sent_state_process() \n\t -- accepts packet if AWL \u003c\u003d P.ackno \u003c\u003d AWH;\n\t\t\t -- sets GSR \u003d ISR \u003d P.seqno\n\n * sending the Ack completing the handshake: dccp_send_ack() calls \n dccp_transmit_skb(), which sets GSS +\u003d 1\n\t\t\t and AWL :\u003d ISS, AWH :\u003d GSS\n\t\t\t \n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "2975abd251d795810932b20354729ba236d95bf9", "tree": "343733773977a67eb5aa7692ff301466125871e8", "parents": [ "d0995e6a9e3328cdc76b4c45882dee118284f960" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:35 2008 +0200" }, "message": "dccp: Schedule an Ack when receiving timestamps\n\nThis schedules an Ack when receiving a timestamp, exploiting the\nexisting inet_csk_schedule_ack() function, saving one case in the\n`dccp_ack_pending()\u0027 function.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "d0995e6a9e3328cdc76b4c45882dee118284f960", "tree": "ee9e65f8ed5aa6b51228394e0241126ed04a85ea", "parents": [ "5fe94963a163fecc34b7b51bf2ca525f9f50d7bf" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:35 2008 +0200" }, "message": "dccp ccid-3: Remove dead states\n\nThis patch is thanks to an investigation by Leandro Sales de Melo and his\ncolleagues. They worked out two state diagrams which highlight the fact that\nthe xxx_TERM states in CCID-3/4 are in fact not necessary.\n\nAnd this can be confirmed by in turn looking at the code: the xxx_TERM states\nare only ever set in ccid3_hc_{rx,tx}_exit(). These two functions are part\nof the following call chain:\n\n * ccid_hc_{tx,rx}_exit() are called from ccid_delete() only;\n * ccid_delete() invokes ccid_hc_{tx,rx}_exit() in the way of a destructor:\n after calling ccid_hc_{tx,rx}_exit(), the CCID is released from memory;\n * ccid_delete() is in turn called only by ccid_hc_{tx,rx}_delete();\n * ccid_hc_{tx,rx}_delete() is called only if \n - feature negotiation failed (dccp_feat_activate_values()),\n - when changing the RX/TX CCID (to eject the current CCID),\n - when destroying the socket (in dccp_destroy_sock()).\n\nIn other words, when CCID-3 sets the state to xxx_TERM, it is at a time where\nno more processing should be going on, hence it is not necessary to introduce\na dedicated exit state - this is implicit when unloading the CCID.\n\nThe patch removes this state, one switch-statement collapses as a result.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "5fe94963a163fecc34b7b51bf2ca525f9f50d7bf", "tree": "b21a61e047541d39bbe6940ef9531a64c074b40e", "parents": [ "c506d91d9ab7681e058afcd750e9118c6cdaabc1" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:35 2008 +0200" }, "message": "dccp ccid-3: Remove duplicate documentation\n\nThis removes RX-socket documentation which is either duplicate or non-existent.\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" }, { "commit": "c506d91d9ab7681e058afcd750e9118c6cdaabc1", "tree": "09d4061932f1f76a6bba7423c9eeabaef27d0960", "parents": [ "f10ecaee6dc2c6d56783462b2a82e98bc81b55f4" ], "author": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:30:19 2008 +0200" }, "committer": { "name": "Gerrit Renker", "email": "gerrit@erg.abdn.ac.uk", "time": "Thu Sep 04 07:45:35 2008 +0200" }, "message": "dccp: Unused argument in CCID tx function\n\nThis removes the argument `more\u0027 from ccid_hc_tx_packet_sent, since it was\nnowhere used in the entire code.\n\n(Anecdotally, this argument was not even used in the original KAME code where\n the function originally came from; compare the variable moreToSend in the\n freebsd61-dccp-kame-28.08.2006.patch now maintained by Emmanuel Lochin.)\n\nSigned-off-by: Gerrit Renker \u003cgerrit@erg.abdn.ac.uk\u003e\n" } ], "next": "f10ecaee6dc2c6d56783462b2a82e98bc81b55f4" }