)]}' { "log": [ { "commit": "3d130fd03e06672f7700e2cb694b29f9a98227ca", "tree": "65608fc8841362c586cdfd06b69389165753ae93", "parents": [ "88f8831c055858179a7844d9dd4ddd7d3621322e" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jan 12 17:00:00 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 08:03:11 2011 -0800" }, "message": "checkpatch.pl: add \"prefer __packed\" check\n\nThere\u0027s a __packed #define for __attribute__((packed)). Add a checkpatch\nto tell people about it.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "88f8831c055858179a7844d9dd4ddd7d3621322e", "tree": "b8f5c4cdb714ec2fbb7ecf4ca34fff6dbbeb304d", "parents": [ "c023e4734c3e8801e0ecb5e81b831d42a374d861" ], "author": { "name": "Dave Jones", "email": "davej@redhat.com", "time": "Wed Jan 12 16:59:59 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 08:03:11 2011 -0800" }, "message": "checkpatch: check for world-writeable sysfs/debugfs files\n\nExporting world writable sysfs/debugfs files is usually a bad thing. Warn\nabout it.\n\nSigned-off-by: Dave Jones \u003cdavej@redhat.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c023e4734c3e8801e0ecb5e81b831d42a374d861", "tree": "a497964957d6dd30baa52ffe7a175737599ebca0", "parents": [ "caf2a54f101a55ec318c2a20253a1977802f7de4" ], "author": { "name": "Florian Mickler", "email": "florian@mickler.org", "time": "Wed Jan 12 16:59:58 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 08:03:11 2011 -0800" }, "message": "checkpatch.pl: fix CAST detection\n\nWe should only claim that something is a cast if we did not encouter a\ntoken before, that did set av_pending.\n\nThis fixes the operator * in the line below to be detected as binary (vs\nunary).\n\nkmalloc(sizeof(struct alphatrack_ocmd) * true_size, GFP_KERNEL);\n\nReported-by: Audun Hoem \u003caudun.hoem@gmail.com\u003e\nSigned-off-by: Florian Mickler \u003cflorian@mickler.org\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "caf2a54f101a55ec318c2a20253a1977802f7de4", "tree": "0eaa61afa0af0754a42b8a1f5c642500c4a54026", "parents": [ "78c377d1b5e7ef15c8c307c2aa2511602a0829c3" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jan 12 16:59:56 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 08:03:11 2011 -0800" }, "message": "scripts/checkpatch.pl: add check for multiple terminating semicolons and casts of vmalloc\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4882720b267b7b1d1b0ce08334b205f0329d4615", "tree": "dd54880f84b7b7fb2bbdb529ffada434aca1e4d9", "parents": [ "45f4d0243525b6bc747c946937ced437b135a84d" ], "author": { "name": "Thomas Gleixner", "email": "tglx@linutronix.de", "time": "Tue Sep 07 14:34:01 2010 +0000" }, "committer": { "name": "Thomas Gleixner", "email": "tglx@linutronix.de", "time": "Sat Oct 30 12:12:50 2010 +0200" }, "message": "semaphore: Remove mutex emulation\n\nSemaphores used as mutexes have been deprecated for years. Now that\nall users are either converted to real semaphores or to mutexes remove\nthe cruft.\n\nSigned-off-by: Thomas Gleixner \u003ctglx@linutronix.de\u003e\nCc: Peter Zijlstra \u003cpeterz@infradead.org\u003e\nCc: Christoph Hellwig \u003chch@infradead.org\u003e\nLKML-Reference: \u003c20100907125057.562399240@linutronix.de\u003e\n\n" }, { "commit": "93ed0e2d07b25aff4db1d61bfbcd1e82074c0ad5", "tree": "7b0c7f31bbf7ca0f083c1372e2cf6ebc3eaac20a", "parents": [ "cb710eca6820493add0ddd3d7e8e3ee53f2b6e57" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Oct 26 14:23:21 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:21 2010 -0700" }, "message": "scripts/checkpatch.pl: add check for declaration of pci_device_id\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "cb710eca6820493add0ddd3d7e8e3ee53f2b6e57", "tree": "752ca452a0d2fa3f9cb085c4f4e050a5e657f5f5", "parents": [ "267ad8f42644c2fa4ff6c2e7596d2b02c7397c85" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Oct 26 14:23:20 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:21 2010 -0700" }, "message": "scripts/checkpatch.pl: add warnings for static char that could be static const char\n\nAdd warnings for possible missing const uses of\n\tstatic char foo[] \u003d \"bar\"\n that could be\n\tstatic const char foo[] \u003d \"bar\"\nand\n\tstatic const char *foo[] \u003d {\"bar\", \"baz\"}\n that could be\n\tstatic const char * const foo[] \u003d {\"bar\", \"baz\"}\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Mike Frysinger \u003cvapier.adi@gmail.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "267ad8f42644c2fa4ff6c2e7596d2b02c7397c85", "tree": "3ee37f7c98f3f0f54ddc3d165bf48c576205eb17", "parents": [ "01464f30a97c5c30bf9633309b27cce055cef8fd" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:19 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:21 2010 -0700" }, "message": "checkpatch: version 0.31\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "01464f30a97c5c30bf9633309b27cce055cef8fd", "tree": "5ba4eb55ff1b520cbbc82f5f32a7bc81c666d8da", "parents": [ "3cbf62df3a8ce61cb1aa20b7dae964058988bfdd" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:19 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:21 2010 -0700" }, "message": "checkpatch: statement/block context analyser should look at sanitised lines\n\nWhen tracking context to find a block or statement we need to use the\nsanitised lines, else perentheses \u0027(\u0027 \u0026 \u0027)\u0027 and braces \u0027{\u0027 \u0026 \u0027}\u0027 can throw\nthe scanner out. Also fix up a couple of error outputs which include\nthose sanitised lines incorrectly.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3cbf62df3a8ce61cb1aa20b7dae964058988bfdd", "tree": "46a2d31b34c07ae6547d743a27e60b682b84c3e8", "parents": [ "5eaa20b984eb316533b4a098d8de3912e434df6a" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:18 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:21 2010 -0700" }, "message": "checkpatch: handle EXPORT_SYMBOL for DEVICE_ATTR and similar\n\nHandly definitions similar to below. The definition macro spits out a\nsymbol with a prefix. Add matching of any identifier prefix:\n\n DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR,\n ata_scsi_lpm_show, ata_scsi_lpm_put);\n EXPORT_SYMBOL_GPL(dev_attr_link_power_management_policy);\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5eaa20b984eb316533b4a098d8de3912e434df6a", "tree": "91df836f5b4fdd7745fde745adec27c4edeccb1a", "parents": [ "015830be9779aeae7de7060b07a3157a8e41bcb4" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:18 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: clean up structure definition macro handline\n\nHandle definitions such as the following correctly, it is not\na complex statement:\n\n #define PREALLOC(NAME, START, END, FLAGS) { \\\n\t\t .name \u003d (NAME), \\\n\t\t .start \u003d (START), \\\n\t\t .end \u003d (END), \\\n\t\t .flags \u003d (FLAGS) \\\n\t },\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "015830be9779aeae7de7060b07a3157a8e41bcb4", "tree": "6a6044c2e3129b42f1b5d7dfd3763fc54f76ea76", "parents": [ "03f1df7da5696ddfa6e167b37e0c0ce5aad3de79" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:17 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: update copyright dates\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "03f1df7da5696ddfa6e167b37e0c0ce5aad3de79", "tree": "46e1ac76d5a6a31f96f1ca040fb2620eb93f4a36", "parents": [ "3bf9a009fccea422bc355414a3bdf5f35fff9f36" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Oct 26 14:23:16 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: Add additional attribute #defines\n\nOn Wed, 2010-08-11 at 12:35 -0400, Dave Jones wrote:\n\u003e I just got this from a patch I merged..\n\u003e\n\u003e ERROR: need consistent spacing around \u0027*\u0027 (ctx:WxV)\n\u003e #121: FILE: arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c:113:\n\u003e +static struct pcc_cpu __percpu *pcc_cpu_info;\n\u003e ^\n\u003e which doesn\u0027t seem right.\n\nPerhaps these need to be added to checkpatch.\n\n[apw@canonical.com: added tests]\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Dave Jones \u003cdavej@codemonkey.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3bf9a009fccea422bc355414a3bdf5f35fff9f36", "tree": "18a47ff24bae81950fae0e8b550835723da17cd1", "parents": [ "9fe287d79b0af983050d24e7916cf3d1f019f553" ], "author": { "name": "Rabin Vincent", "email": "rabin.vincent@stericsson.com", "time": "Tue Oct 26 14:23:16 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: check for incorrect permissions\n\nThrow an error when a source file has been given execute permissions using\nthe mode change line present in git diffs. Also alow the filename\nmatching to use the \"diff\" line in addition to the \"+++\" line, since the\nmode change lines appear before any \"+++\" lines.\n\n[apw@canonical.com: simplified filename logic slightly, added tests]\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nAcked-by: Linus Walleij \u003clinus.walleij@stericsson.com\u003e\nSigned-off-by: Rabin Vincent \u003crabin.vincent@stericsson.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9fe287d79b0af983050d24e7916cf3d1f019f553", "tree": "46683d872be3d6976ad895f6ad94996acc06344c", "parents": [ "0c73b4eb7a825a5aff16d8a9701f6c28056de058" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:15 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: ensure kconfig help checks only apply when we are adding help\n\nWhen checking the length of the help we need to be sure we are seeing the\nwhole story before erroring. Firstly we only want to check when adding\nthe help in the first place. Second we need to be sure that we are seeing\nthe end of the entry, nominally when there is no context below or that\ncontext shows the start of the next entry.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0c73b4eb7a825a5aff16d8a9701f6c28056de058", "tree": "bbc5cec929a9406ad53c6d5df36c980259e60546", "parents": [ "8cf6de7145943caa38c56c61cd83b17687afd900" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:15 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: simplify and consolidate \"missing space after\" checks\n\nCommonise the code for missing spaces after struct, union, and enum such\nthat they share the same code. Ensure we cover all the common cases in\neach case. Check against the sanitised line to ensure we do not report on\ncomments and strings.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8cf6de7145943caa38c56c61cd83b17687afd900", "tree": "f32e86109cce060816afdcbd9e55cd7c991a495b", "parents": [ "53a3c4487a05b8f26ef72fe434a750a3402c998f" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:14 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: add check for space after struct, union, and enum\n\nAdd spacing checks for struct, union, and enum definitions. Check the\nspacing after type and before the equals (\u003d) and open brace ({).\n\nBased on a patch by Joe Perches.\n\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "53a3c4487a05b8f26ef72fe434a750a3402c998f", "tree": "dfe0b1f85cbf1082ceb52b71bb157cc715e22293", "parents": [ "9446ef569c288e683225fec8337a0b2b81e75cc5" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:14 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: returning errno typically should be negative\n\nAdd a (strict mode only) test to check for non-negative returns of what\nappear to be errno values as the majority case these should indeed be\nnegative.\n\nSuggested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9446ef569c288e683225fec8337a0b2b81e75cc5", "tree": "a46d6265a77f637f882c9136c914483b5d4598d8", "parents": [ "fb2d2c1b5825503d30fb6f2dc328dbe4a47d9794" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:13 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: handle casts better fixing false categorisation of : as binary\n\nThe following incantation is triggering categorisation of its colon (:) as\na binary form, which it is not:\n\n\treturn foo ? (s8)bar : baz;\n\nHandle casts differently from types in the categoriser, allowing us to\nbetter track (s8)bar as a value and not a declaration.\n\nReported-by: Jean Delvare \u003ckhali@linux-fr.org\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fb2d2c1b5825503d30fb6f2dc328dbe4a47d9794", "tree": "6fba2ec80498dcb83615ea27907c89e979902c85", "parents": [ "d2c0a23514d8ac4ed10a8e742467cfb72ca3bed8" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:12 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:19 2010 -0700" }, "message": "checkpatch: ensure we do not collapse bracketed sections into constants\n\nWhen determining if a return () sequence is a function style bracketing we\nsimplify the expression one bracket at a time replacing each with a\nconstant. However this can trigger a false merge with expressions as\nbelow:\n\n\treturn (foo)0;\n\nPrevent this false merging.\n\nReported-by: Hitoshi Mitake \u003cmitake@dcl.info.waseda.ac.jp\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d2c0a23514d8ac4ed10a8e742467cfb72ca3bed8", "tree": "a3c0283ee6cdcaa92ecf9ae2ec7a4f1e627c359c", "parents": [ "e91b6e263ed6735c766cb14bbe63b9c7bd774526" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:12 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:19 2010 -0700" }, "message": "checkpatch: suggest cleanpatch and cleanfile when appropriate\n\nWhen we hit types of whitespace which may be fixed by scripts/cleanpatch\nand scripts/cleanfile suggest their use in our report.\n\nSuggested-by: Bartlomiej Zolnierkiewicz \u003cbzolnier@gmail.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e91b6e263ed6735c766cb14bbe63b9c7bd774526", "tree": "aeb8283e01f9ec0fe3250f60ec83da4fe2399e2e", "parents": [ "6b4c5bebcebb0a48d29947e9aa749650751a7696" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:11 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:19 2010 -0700" }, "message": "checkpatch: types may sit on a line on their own\n\nWhen the following form is used we have a type which fully fills a line.\nThis means that a type may end at the end of line as well as at the\nfollowing identifier.\n\n\tint **\n\tfoo;\n\nReported-by: Daniel Walker \u003cdwalker@fifo99.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6b4c5bebcebb0a48d29947e9aa749650751a7696", "tree": "95a5dcebb9046e280ed829391f2d2f8458cd349e", "parents": [ "658716d19f8f155c67d4677ba68034b8e492dfbe" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:11 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:19 2010 -0700" }, "message": "checkpatch: fix regressions in \"fix handling of leading spaces\"\n\nThe patch \"checkpatch: fix handling of leading spaces\" added checks for\nleading spaces on lines, but this introduces regressions. Firstly it does\nnot correctly detect when we are in a comment. Secondly it does not allow\nfor preprocessor command spacing. Finally it does not allow for label\nindentation which is required to be less than one tab. Fix these up:\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b998e001e6ce6540ea04a264debc50ae44d2db7a", "tree": "6a265af53f8317691ed5bd39b30f55f0df0f9c1a", "parents": [ "09ef87255da0e005dd0ab39ca25714208cf29cb3" ], "author": { "name": "Patrick Pannuto", "email": "ppannuto@codeaurora.org", "time": "Mon Aug 09 17:21:03 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Aug 09 20:45:09 2010 -0700" }, "message": "checkpatch: fix extraneous EXPORT_SYMBOL* warnings\n\nThese are caused by checkpatch incorrectly parsing its internal\nrepresentation of a statement block for struct\u0027s (or anything else that is\na statement block encapsulated in {}\u0027s that also ends with a \u0027;\u0027). Fix\nthis by properly parsing a statement block.\n\nAn example:\n\n\t+struct dummy_type dummy \u003d {\n\t+\t.foo\t\u003d \"baz\",\n\t+};\n\t+EXPORT_SYMBOL_GPL(dummy);\n\t+\n\t+static int dummy_func(void)\n\t+{\n\t+\treturn -EDUMMYCODE;\n\t+}\n\t+EXPORT_SYMBOL_GPL(dummy_func);\n\n\tWARNING: EXPORT_SYMBOL(foo); should immediately \\\n\t\tfollow its function/variable\n\t#19: FILE: dummy.c:4:\n\t+EXPORT_SYMBOL_GPL(dummy);\n\nThe above warning is issued when it should not be.\n\nSigned-off-by: Patrick Pannuto \u003cppannuto@codeaurora.org\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "09ef87255da0e005dd0ab39ca25714208cf29cb3", "tree": "e792086e6e088f08496a5fe03f8abca8d32b1c1b", "parents": [ "1a15a250862fda3fbdf8454cc7131e24de904e7c" ], "author": { "name": "Patrick Pannuto", "email": "ppannuto@codeaurora.org", "time": "Mon Aug 09 17:21:02 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Aug 09 20:45:09 2010 -0700" }, "message": "checkpatch: warn about unexpectedly long msleep\u0027s\n\nAs explained in Documentation/timers/timers-howto.txt, msleep\u0027s of \u003c 20ms\nmay sleep for as long as 20ms. Caller\u0027s of msleep(1) or msleep(2), etc\nare likely not to expect this quirky behavior - warn them.\n\nSigned-off-by: Patrick Pannuto \u003cppannuto@codeaurora.org\u003e\nCc: Thomas Gleixner \u003ctglx@linutronix.de\u003e\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1a15a250862fda3fbdf8454cc7131e24de904e7c", "tree": "23fab33bd014d426750ca486d0be7cf59d65eb31", "parents": [ "8bbea968f9022c3f66a36902509574597611be99" ], "author": { "name": "Patrick Pannuto", "email": "ppannuto@codeaurora.org", "time": "Mon Aug 09 17:21:01 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Aug 09 20:45:09 2010 -0700" }, "message": "checkpatch: prefer usleep_range over udelay\n\nWhen possible, sleeping is (usually) better than delaying; however, don\u0027t\nbother callers of udelay \u003c 10us, as those cases are generally not worth\nthe switch to usleep\n\n[akpm@linux-foundation.org: fix mismatched parentheses]\nSigned-off-by: Patrick Pannuto \u003cppannuto@codeaurora.org\u003e\nCc: Thomas Gleixner \u003ctglx@linutronix.de\u003e\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8bbea968f9022c3f66a36902509574597611be99", "tree": "4d0a274a811cbe9169ce03267dbfce1dd99b8403", "parents": [ "5150bda43c58cdce7eb851c3fe2ca913524459a0" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Aug 09 17:21:01 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Aug 09 20:45:09 2010 -0700" }, "message": "checkpatch: add more exceptions to 80 char lines\n\nAdd new logging functions netdev_\u003clevel\u003e and netif_\u003clevel\u003e.\nDon\u0027t complain if the only thing on a line is a quoted string.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nCc: Wolfram Sang \u003cw.sang@pengutronix.de\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5150bda43c58cdce7eb851c3fe2ca913524459a0", "tree": "ec0a7222c7cb97bdf25823ec9d64d6e17b649fc8", "parents": [ "5f7ddae6104d85e27c0fbcb508cfe8286a01a5e1" ], "author": { "name": "Joe Eloff", "email": "kagen101@gmail.com", "time": "Mon Aug 09 17:21:00 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Aug 09 20:45:09 2010 -0700" }, "message": "checkpatch: change externals to globals\n\nMake error message say \u0027ERROR: do not initialise globals to 0 or NULL\u0027\nrather than \u0027ERROR: do not initialise externals to 0 or NULL\u0027. Makes more\nsense in the context since there is an extern keyword in C and that is a\nglobal declaration within the scope of the current file.\n\nSigned-off-by: Joe Eloff \u003ckagen101@gmail.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nCc: Wolfram Sang \u003cw.sang@pengutronix.de\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5f7ddae6104d85e27c0fbcb508cfe8286a01a5e1", "tree": "2bd6316f18a27b8c2575b9f0844c47ff392d8fca", "parents": [ "7840a94cd12559d8aee6382fafb85fbc9eb3a2c2" ], "author": { "name": "Raffaele Recalcati", "email": "raffaele.recalcati@bticino.it", "time": "Mon Aug 09 17:20:59 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Aug 09 20:45:09 2010 -0700" }, "message": "checkpatch: fix handling of leading spaces\n\nI\u0027ve got a false positive when spaces are present at the beginning of a\nline.\n\nSo I add this check, obviously excluding to check the lines in the middle of\ncomments.\n\nFor instance this code passes the checkpatch test:\n\n+struct davinci_mcbsp_data {\n+ unsigned int fmt;\n+ int clk_div;\n+};\n+\n+static struct davinci_mcbsp_data mcbsp_data;\n\nWhere, before the string \"int clk_div\", I have 4 spaces (\\040\nascii character).\n\nWith v2.6.34 scripts/checkpatch.pl script I get:\n\nscripts/checkpatch.pl 0001-ASoC-DaVinci-Added-support-for-stereo-I2S.patch\ntotal: 0 errors, 0 warnings, 201 lines checked\n0001-ASoC-DaVinci-Added-support-for-stereo-I2S.patch has no obvious style\nproblems and is ready for submission.\n\nThat is not correct. Instead with the proposed patch I get:\n\nscripts/checkpatch.pl 0001-ASoC-DaVinci-Added-support-for-stereo-I2S.patch\nWARNING: please, no space for starting a line,\n excluding comments\n#63: FILE: sound/soc/davinci/davinci-i2s.c:165:\n+ int clk_div;$\n\nWARNING: please, no space for starting a line,\n excluding comments\n#95: FILE: sound/soc/davinci/davinci-i2s.c:406:\n+ return 0;$\n\ntotal: 0 errors, 2 warnings, 201 lines checked\n\nThat is correct.\n\nSigned-off-by: Raffaele Recalcati \u003craffaele.recalcati@bticino.it\u003e\nCc: Wolfram Sang \u003cw.sang@pengutronix.de\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7840a94cd12559d8aee6382fafb85fbc9eb3a2c2", "tree": "6d3dad4d269f55aec1f21c0d40e40df54212632b", "parents": [ "1986aaf828ac8398b3d8d9b4151b08c840414ffe" ], "author": { "name": "Wolfram Sang", "email": "w.sang@pengutronix.de", "time": "Mon Aug 09 17:20:57 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Aug 09 20:45:09 2010 -0700" }, "message": "checkpatch: refactor \u0027allowed asm includes\u0027 and add memory.h\n\nChange the check suggesting replacement of asm-includes with\nlinux-includes. Exceptions to this rule are easier to extend now. Add\nmemory.h because ARM has a custom one.\n\nSigned-off-by: Wolfram Sang \u003cw.sang@pengutronix.de\u003e\nCc: Russell King \u003clinux@arm.linux.org.uk\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d4977c78e9c7dd042f96f4a21d957bc25a561333", "tree": "19a50489a8d974b4841edde9e92aae7ec147756a", "parents": [ "3354957a4f8b9bb4b43625232acdf0626851c82f" ], "author": { "name": "Tobias Klauser", "email": "tklauser@distanz.ch", "time": "Mon May 24 14:33:30 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue May 25 08:07:06 2010 -0700" }, "message": "checkpatch: warn on declaration with storage class not at the beginning\n\nThe C99 specification states in section 6.11.5:\n\nThe placement of a storage-class specifier other than at the beginning\nof the declaration specifiers in a declaration is an obsolescent\nfeature.\n\nSigned-off-by: Tobias Klauser \u003ctklauser@distanz.ch\u003e\nAcked-by: Jean Delvare \u003ckhali@linux-fr.org\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3354957a4f8b9bb4b43625232acdf0626851c82f", "tree": "8b6b363e9114611a3261c600f937bce75c81cbdd", "parents": [ "965fd9e9a2d6d0a2704815e4579008a9f65282a0" ], "author": { "name": "Andi Kleen", "email": "ak@linux.intel.com", "time": "Mon May 24 14:33:29 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue May 25 08:07:06 2010 -0700" }, "message": "checkpatch: add check for too short Kconfig descriptions\n\nI\u0027ve seen various new Kconfigs with rather unhelpful one liner\ndescriptions. Add a Kconfig warning for a minimum length of the Kconfig\nhelp section.\n\nRight now I arbitarily chose 4. The exact value can be debated.\n\n[akpm@linux-foundation.org: coding-style fixes]\nSigned-off-by: Andi Kleen \u003cak@linux.intel.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1704f47b50b5d9e1b825e43e1baaf2c5897baf03", "tree": "60617ff867624f915f75a502f2207de5e586757a", "parents": [ "3142788b7967ccfd2f1813ee9e11aeb1e1cf7de2" ], "author": { "name": "Peter Zijlstra", "email": "peterz@infradead.org", "time": "Fri Mar 19 01:37:42 2010 +0100" }, "committer": { "name": "Greg Kroah-Hartman", "email": "gregkh@suse.de", "time": "Fri May 21 09:37:30 2010 -0700" }, "message": "lockdep: Add novalidate class for dev-\u003emutex conversion\n\nThe conversion of device-\u003esem to device-\u003emutex resulted in lockdep\nwarnings. Create a novalidate class for now until the driver folks\ncome up with separate classes. That way we have at least the basic\nmutex debugging coverage.\n\nAdd a checkpatch error so the usage is reserved for device-\u003emutex.\n\n[ tglx: checkpatch and compile fix for LOCKDEP\u003dn ]\n\nSigned-off-by: Peter Zijlstra \u003cpeterz@infradead.org\u003e\nSigned-off-by: Thomas Gleixner \u003ctglx@linutronix.de\u003e\nSigned-off-by: Greg Kroah-Hartman \u003cgregkh@suse.de\u003e\n\n" }, { "commit": "5e79d96eed306a8b4af67b3f35f6867edfabeebc", "tree": "fdd6da6cc21c874b386e40ac9d7e5b8de6441cb9", "parents": [ "08e4436566250cb98b3f3ac37643b1cf09481256" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 05 13:43:55 2010 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Mar 06 11:26:44 2010 -0800" }, "message": "checkpatch: warn on unnecessary spaces before quoted newlines\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "08e4436566250cb98b3f3ac37643b1cf09481256", "tree": "c669f150a8db7cacdcb7a720d61937f08d96d8c1", "parents": [ "79404849e90a41ea2109bd0e2f7c7164b0c4ce73" ], "author": { "name": "Alberto Panizzo", "email": "maramaopercheseimorto@gmail.com", "time": "Fri Mar 05 13:43:54 2010 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Mar 06 11:26:44 2010 -0800" }, "message": "checkpatch.pl: warn if an adding line introduce spaces before tabs.\n\nSigned-off-by: Alberto Panizzo \u003cmaramaopercheseimorto@gmail.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "79404849e90a41ea2109bd0e2f7c7164b0c4ce73", "tree": "9784e94c01de0b154711954d1b6df90467264b70", "parents": [ "22fd2d3e4f75a2596ccdfdcbdfd505c9c60bf346" ], "author": { "name": "Emese Revfy", "email": "re.emese@gmail.com", "time": "Fri Mar 05 13:43:53 2010 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Mar 06 11:26:44 2010 -0800" }, "message": "checkpatch.pl: extend list of expected-to-be-const structures\n\nBased on Arjan\u0027s suggestion, extend the list of ops structures that should\nbe const.\n\nSigned-off-by: Emese Revfy \u003cre.emese@gmail.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nCc: Arjan van de Ven \u003carjan@infradead.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "22fd2d3e4f75a2596ccdfdcbdfd505c9c60bf346", "tree": "fc9072d2d42a3da4b5ad5145b14b3f738582288d", "parents": [ "52131292c069b74f4b5f3c786ff66ff6e82b0e69" ], "author": { "name": "Stefani Seibold", "email": "stefani@seibold.net", "time": "Fri Mar 05 13:43:52 2010 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Mar 06 11:26:44 2010 -0800" }, "message": "checkpatch.pl: add union and struct to the exceptions list\n\nHere is a small code snippet, which will be complained about by\ncheckpatch.pl:\n\n#define __STRUCT_KFIFO_COMMON(recsize, ptrtype) \\\n\tunion { \\\n\t\tstruct { \\\n\t\t\tunsigned int\tin; \\\n\t\t\tunsigned int\tout; \\\n\t\t}; \\\n\t\tchar\t\trectype[recsize]; \\\n\t\tptrtype\t\t*ptr; \\\n\t\tconst ptrtype\t*ptr_const; \\\n\t};\n\nThis construct is legal and safe, so checkpatch.pl should accept this. It\nshould be also true for struct defined in a macro.\n\nAdd the `struct\u0027 and `union\u0027 keywords to the exceptions list of the\ncheckpatch.pl script, to prevent error message \"Macros with multiple\nstatements should be enclosed in a do - while loop\". Otherwise it is not\npossible to build a struct or union with a macro.\n\nSigned-off-by: Stefani Seibold \u003cstefani@seibold.net\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "52131292c069b74f4b5f3c786ff66ff6e82b0e69", "tree": "b84324464503adc35bda0573c1c35f7497d9ecce", "parents": [ "691e669ba8c64d31ac08d87b1751e6acfa3ff65e" ], "author": { "name": "Wolfram Sang", "email": "w.sang@pengutronix.de", "time": "Fri Mar 05 13:43:51 2010 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Mar 06 11:26:44 2010 -0800" }, "message": "checkpatch: fix false positive on __initconst\n\ncheckpatch falsely complained about \u0027__initconst\u0027 because it thought the\n\u0027const\u0027 needed a space before. Fix this by changing the list of\nattributes:\n\n- add \u0027__initconst\u0027\n- force plain \u0027init\u0027 to contain a word-boundary at the end\n\nSigned-off-by: Wolfram Sang \u003cw.sang@pengutronix.de\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "691e669ba8c64d31ac08d87b1751e6acfa3ff65e", "tree": "aaa04265a19b350a6292af1da60fc0870458f6a1", "parents": [ "42bdf74c95b6935f3c09a09ba4bead6cad11b540" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 05 13:43:51 2010 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Mar 06 11:26:44 2010 -0800" }, "message": "checkpatch.pl: allow \u003e 80 char lines for logging functions not just printk\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "42bdf74c95b6935f3c09a09ba4bead6cad11b540", "tree": "ef37ea657ba74ea1cd4c8ebeb239bb65e3946b32", "parents": [ "8f53a9b80f011080555c498d2ca2dc6b1a77c42c" ], "author": { "name": "Hidetoshi Seto", "email": "seto.hidetoshi@jp.fujitsu.com", "time": "Fri Mar 05 13:43:50 2010 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Mar 06 11:26:44 2010 -0800" }, "message": "checkpatch: trivial fix for trailing statements check\n\nIn case if the statement and the conditional are in one line, the line\nappears in the report doubly.\n\nAnd items of this check have no blank line before the next item.\n\nThis patch fixes these trivial problems, to improve readability of the\nreport.\n\n[sample.c]\n \u003e if (cond1\n \u003e \u0026\u0026 cond2\n \u003e \u0026\u0026 cond3) func_foo();\n \u003e\n \u003e if (cond4) func_bar();\n\nBefore:\n \u003e ERROR: trailing statements should be on next line\n \u003e #1: FILE: sample.c:1:\n \u003e +if (cond1\n \u003e [...]\n \u003e + \u0026\u0026 cond3) func_foo();\n \u003e ERROR: trailing statements should be on next line\n \u003e #5: FILE: sample.c:5:\n \u003e +if (cond4) func_bar();\n \u003e +if (cond4) func_bar();\n \u003e total: 2 errors, 0 warnings, 5 lines checked\n\nAfter:\n \u003e ERROR: trailing statements should be on next line\n \u003e #1: FILE: sample.c:1:\n \u003e +if (cond1\n \u003e [...]\n \u003e + \u0026\u0026 cond3) func_foo();\n \u003e\n \u003e ERROR: trailing statements should be on next line\n \u003e #5: FILE: sample.c:5:\n \u003e +if (cond4) func_bar();\n \u003e\n \u003e total: 2 errors, 0 warnings, 5 lines checked\n\nSigned-off-by: Hidetoshi Seto \u003cseto.hidetoshi@jp.fujitsu.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8f53a9b80f011080555c498d2ca2dc6b1a77c42c", "tree": "b4636535f12817c107ba8fc1932882984eee9e46", "parents": [ "849382948992cc6482c778b1e854c19368b60c05" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 05 13:43:48 2010 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Mar 06 11:26:44 2010 -0800" }, "message": "scripts/checkpatch.pl: add WARN on sizeof(\u0026foo)\n\nsizeof(\u0026foo) is frequently an error. Warn on its use.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "dbf004d7883b3adb058c0c1a5635bc4ec27651c0", "tree": "cac67630ac8eaaba0ab6b7b4a24d617ae804d3f4", "parents": [ "2d13c8f0682bd38c74e89a76cc550f0324b610ba" ], "author": { "name": "Dave Jones", "email": "davej@redhat.com", "time": "Tue Jan 12 16:59:52 2010 -0500" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 12 20:56:52 2010 -0800" }, "message": "remove my email address from checkpatch.\n\nMaybe this will stop people emailing me about it.\n\nSigned-off-by: Dave Jones \u003cdavej@redhat.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5e8d8f6f2844d4a663415c660ab5cc92e2e2477d", "tree": "59df4708e3bc412cde2ba24769bc12087c4fc862", "parents": [ "2b474a1a566064b40bc7d9a45021ffbc4c894fa3" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:17 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: version 0.30\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2b474a1a566064b40bc7d9a45021ffbc4c894fa3", "tree": "9f65e5456a95272db6ec887eff472114bfcc5d31", "parents": [ "99423c2065b62fee41cdbd8da7e63bf1f8f9e9b0" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:16 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: fix false EXPORT_SYMBOL warning\n\nIngo reported that the following lines triggered a false warning,\n\nstatic struct lock_class_key rcu_lock_key;\nstruct lockdep_map rcu_lock_map \u003d\n STATIC_LOCKDEP_MAP_INIT(\"rcu_read_lock\", \u0026rcu_lock_key);\nEXPORT_SYMBOL_GPL(rcu_lock_map);\n\nfrom kernel/rcutree.c , and the false warning looked like this,\n\nWARNING: EXPORT_SYMBOL(foo); should immediately follow its\nfunction/variable\n+EXPORT_SYMBOL_GPL(rcu_lock_map);\n\nWe actually should be checking the statement before the EXPORT_* for a\nmention of the exported object, and complain where it is not there.\n\n[akpm@linux-foundation.org: coding-style fixes]\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nCc: Paul E. McKenney \u003cpaulmck@linux.vnet.ibm.com\u003e\nReported-by: Daniel Walker \u003cdwalker@fifo99.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "99423c2065b62fee41cdbd8da7e63bf1f8f9e9b0", "tree": "cce6a6498daee4630e0c1fa9f48ef922457cad68", "parents": [ "2ceb532b04b7a3b8f534d11a6e839f8b8bff94c1" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:15 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: fix __attribute__ matching\n\nIn the following code,\n\nunion thread_union init_thread_union\n\t__attribute__((__section__(\".data.init_task\"))) \u003d\n\t\t{ INIT_THREAD_INFO(init_task) };\n\nThere is a non-conforming declaration. It should really be like the\nfollowing,\n\nunion thread_union init_thread_union\n\t__attribute__((__section__(\".data.init_task\"))) \u003d {\n\t\tINIT_THREAD_INFO(init_task)\n};\n\nHowever, checkpatch doesn\u0027t catch this right now because it doesn\u0027t\ncorrectly evaluate the \"__attribute__\".\n\nIt is not at all clear that we care what preceeds an assignment style\nattribute when we find the open brace. Relax the test so we do not need\nto check the __attribute__.\n\nReported-by: Daniel Walker \u003cdwalker@fifo99.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2ceb532b04b7a3b8f534d11a6e839f8b8bff94c1", "tree": "44dd940b3f397dfc21344c94d4827a37985c2d50", "parents": [ "131edb3418018b6da297ed389b541e697043a8b6" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:14 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: fix false errors due to macro concatenation\n\nThe macro concatenation (##) sequence can cause false errors when checking\nmacro\u0027s. Checkpatch doesn\u0027t currently know about the operator.\n\nFor example this line,\n\n+ \tentry \u003d (struct ftrace_raw_##call *)raw_data; \\\n\nis correct but it produces the following error,\n\nERROR: need consistent spacing around \u0027*\u0027 (ctx:WxB)\n+ entry \u003d (struct ftrace_raw_##call *)raw_data;\\\n ^\n\nThe line above doesn\u0027t have any spacing problems, and if you remove the\nmacro concatenation sequence checkpatch doesn\u0027t give any errors.\n\nExtend identifier handling to include ## concatenation within the\ndefinition of an identifier.\n\nReported-by: Daniel Walker \u003cdwalker@fifo99.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "131edb3418018b6da297ed389b541e697043a8b6", "tree": "5db99acf8a14c2ddc18dcacae2fe5a9b8bb5d844", "parents": [ "cc77cdca5209c1199deb33f3a83df191ac32f4d6" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:14 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: update copyright dates\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "cc77cdca5209c1199deb33f3a83df191ac32f4d6", "tree": "23a1149ca4268d0e743b8e847d83fbda3f929067", "parents": [ "9a974fdbe3fbb4b0f6d552579dc79ac237412c61" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:13 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: correctly stop scanning at the bottom of a hunk\n\nWe are allowing context scanning checks to apply against the first line of\ncontext outside at the end of the hunk. This can lead to false matches to\npatch names leading to various perl warnings. Correctly stop at the\nbottom of the hunk.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9a974fdbe3fbb4b0f6d552579dc79ac237412c61", "tree": "bf865361b93077ae8464f459280cb86a9f414ad5", "parents": [ "1a83e175dc2c7be931a3ea9c7fb0769e6de55e90" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Oct 26 16:50:12 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 29 07:39:31 2009 -0700" }, "message": "checkpatch: possible types -- prevent illegal modifiers being added\n\nPrevent known non types being detected as modifiers. Ensure we do not\nlook at any type which starts with a keyword.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "42e41c54d61e32e8a349943607daa53205324d7f", "tree": "a38050a0b2e716100372601262273cdbd195baf8", "parents": [ "0487683096decad0720dfaf80b9d28173d5f6662" ], "author": { "name": "Mike Frysinger", "email": "vapier@gentoo.org", "time": "Mon Sep 21 17:04:40 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: add some common Blackfin checks\n\nAdd checks for Blackfin-specific issues that seem to crop up from time to\ntime. In particular, we have helper macros to break a 32bit address into\nthe hi/lo parts, and we want to make sure people use the csync/ssync\nvariant that includes fun anomaly workarounds.\n\nSigned-off-by: Mike Frysinger \u003cvapier@gentoo.org\u003e\nSigned-off-by: Bryan Wu \u003ccooloney@kernel.org\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0487683096decad0720dfaf80b9d28173d5f6662", "tree": "506241fcace0596fb4cf1e752d7f8aaa19295c8d", "parents": [ "fb9e9096ba94385b738a8ad6c5864b5778285957" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Sep 21 17:04:39 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: version 0.29\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fb9e9096ba94385b738a8ad6c5864b5778285957", "tree": "b066899e4c5a4ca033babb068acdc7d0132186c5", "parents": [ "ea71a0a019f913bdf506103bd90140d93a2b83f0" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Sep 21 17:04:38 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: limit sN/uN matches to actual bit sizes\n\nLimit our type matcher to the s/u/le/be etc sizes that actually exist to\nprevent miss categorising s2 as a type. Fix up the spelling of the error\nalso.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ea71a0a019f913bdf506103bd90140d93a2b83f0", "tree": "0d5cf1171809bf012054c7a028beb93450a664fa", "parents": [ "77f5b10a82bbd832c99ec4b120d5645342a5b140" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Sep 21 17:04:38 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: format strings should not have brackets in macros\n\nWe should not recommend braces for the following:\n\n #define pr_fmt(fmt) \"%s: \" fmt, __func__\n\nallow things with double quotes round them to avoid this check.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "77f5b10a82bbd832c99ec4b120d5645342a5b140", "tree": "13359c9798da6babc144262b59f777e664ac195e", "parents": [ "30dad6ebecffebddf6b9947d11e31377fa900ff3" ], "author": { "name": "Hannes Eder", "email": "hannes@hanneseder.net", "time": "Mon Sep 21 17:04:37 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: make -f alias --file, add --help, more verbose help message\n\nImpact:\n - More verbose help/usage message.\n - Make the option -f an alias for --file.\n - On -h, --help, and --version display help message and exit(0).\n - With no FILE(s) given, exit(1) with \"no input files\".\n - On invalid options display help/usage and exit(1).\n\nBased on a patch by Pavel Machek.\n\nSigned-off-by: Hannes Eder \u003channes@hanneseder.net\u003e\nAcked-by: Pavel Machek \u003cpavel@suse.cz\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "30dad6ebecffebddf6b9947d11e31377fa900ff3", "tree": "105febf76a8f69f2194383bf027cad7e8d257d1f", "parents": [ "113f04a836481e9ecc26e8dee8b0e4d52878a288" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Sep 21 17:04:36 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:48 2009 -0700" }, "message": "checkpatch: indent checks -- stop when we run out of continuation lines\n\nEnsure we terminate when there are no futher continuation lines when\ntrying to determine relative indent of conditionals and their blocks.\n\nReported-by: John Daiker \u003cdaikerjohn@gmail.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "113f04a836481e9ecc26e8dee8b0e4d52878a288", "tree": "3f6261a456fd09d2219bb2fe80d90fd0c093f753", "parents": [ "463f28648586721c2191130c9b3c27589dcc11a0" ], "author": { "name": "Daniel Walker", "email": "dwalker@fifo99.com", "time": "Mon Sep 21 17:04:35 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:47 2009 -0700" }, "message": "checkpatch: handle C99 comments correctly (performance issue)\n\nThis fixes the sanitation process in checkpatch.pl so that it blocks out\nthe text after a C99 style comment the same way it does with block style\ncomments. This prevents the text from getting processed as regular code.\n\nSigned-off-by: Daniel Walker \u003cdwalker@fifo99.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "463f28648586721c2191130c9b3c27589dcc11a0", "tree": "6b9ae0d46a17cd4cd904168e5e818ef68b6c7a04", "parents": [ "fc0d8d944df0c58cd810f33db82f87dcf5dcc190" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Sep 21 17:04:34 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 22 07:17:47 2009 -0700" }, "message": "checkpatch: possible types -- else cannot start a type\n\nAn else cannot start a type, it would have to be within a block after the\nelse. This can trigger false modifier matching.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "bea5606d08a36a5fdcf815073d3593ddd2c8549e", "tree": "e9dcbbbe568da9b36dd68e8163d06b7c0ea29eb8", "parents": [ "417495eda3ce50f9c6d28f8e9ddb3bbb25f07f4c" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:09 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:22 2009 -0800" }, "message": "checkpatch: version 0.28\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "417495eda3ce50f9c6d28f8e9ddb3bbb25f07f4c", "tree": "f93d85862f5d97224b3541ec5e5d7998f3351c02", "parents": [ "9360b0e50e9f3e0fd70a077b4ede9885ebc21720" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:08 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:22 2009 -0800" }, "message": "checkpatch: add __ref as a sparse modifier\n\nAdd __ref as a sparse modifier.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9360b0e50e9f3e0fd70a077b4ede9885ebc21720", "tree": "065fa2a65de26e3a720a043b7eb699dc66dd7c42", "parents": [ "667026e7b082ad59eb7194d6b5d159ed6c340e05" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:08 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:22 2009 -0800" }, "message": "checkpatch: extend attribute testing to all modifiers\n\nWe should allow testing of all modifiers not just attributes. Extend\ntesting and test for all the know modifiers.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "667026e7b082ad59eb7194d6b5d159ed6c340e05", "tree": "3d3cab494ac822aee47d65847a09ed2ac8fa6332", "parents": [ "a3340b35787975414d5f6fee83e00640688be2cb" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:08 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:22 2009 -0800" }, "message": "checkpatch: a modifier is not an identifier at the end of a type\n\nWe must make sure we do not misrecognise a modifier as an Identifier\nwhen trying to match types. Prevent us matching this:\n\n\tvoid * __ref\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a3340b35787975414d5f6fee83e00640688be2cb", "tree": "48eadd0bde2f008de17ca1b780e428451b042942", "parents": [ "00ef4ece05096a5c523e265b8ce6627fb5e171c2" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:07 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:22 2009 -0800" }, "message": "checkpatch: pointer type star may have modifiers following\n\nWe may have any modifier following a pointer type star. Handle this:\n\n\tvoid * __user * __user foo;\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "00ef4ece05096a5c523e265b8ce6627fb5e171c2", "tree": "13e3db3b95e04ed3fd53dae599a947c87e87c799", "parents": [ "e2f7aa4b8bc811ebf8afbdf423caf90a5a03cb08" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:07 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:21 2009 -0800" }, "message": "checkpatch: correctly handle type spacing in the face of modifiers\n\nWe need to handle interspersed modifiers in the middle of pointer types,\nfor example:\n\n\tvoid * __user * __user bar;\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e2f7aa4b8bc811ebf8afbdf423caf90a5a03cb08", "tree": "2c3dc6651cbdf54d2a7234bdaa75664b93ca2945", "parents": [ "f4a8773676c21a68b0666fbe48af4fe1af89dfa9" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:06 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:21 2009 -0800" }, "message": "checkpatch: do not warn about -p0 patches when checking files\n\nWe are triggering the -p0 check for our own diffs generated using --file\ncommand line option. Suppress this check for files.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f4a8773676c21a68b0666fbe48af4fe1af89dfa9", "tree": "1ae344b48e791f3abf9310ec71bb15ddd72b2ae1", "parents": [ "cbb766766f3f2f6d9326c561b1020590642c6e39" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Feb 27 14:03:05 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Feb 27 16:26:21 2009 -0800" }, "message": "checkpatch: make in_atomic ok in the core\n\nWe say that in_atomic() is ok in the core kernel, but then always report\nit regardless of where in the kernel it is. Keep quiet if it is used in\nkernel/*.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "db92a6502d4e8cb885e85e862b24ba5c07036fbf", "tree": "6005f2c85621c1b7415e82e46bb8428667f0009b", "parents": [ "6903ffb2257266472ef2edd0092d526ae2dc00f7" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:07 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:39 2009 -0800" }, "message": "checkpatch: version: 0.27\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6903ffb2257266472ef2edd0092d526ae2dc00f7", "tree": "6892ad9fbef5b6aeabd0a0fd05d633c754defed1", "parents": [ "39667782362becd5527e48d6c976a9f9985b95e6" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:07 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:39 2009 -0800" }, "message": "checkpatch: struct seq_operations should normally be const\n\nIn the general use case struct seq_operations should be a const object.\nCheck for and warn where it is not.\n\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "39667782362becd5527e48d6c976a9f9985b95e6", "tree": "43fbe3e89848a863a857018d8e9e33ce07759bb8", "parents": [ "63f17f8973ccdb8260e59ce5b1b4e2b2ee0401f0" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:06 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:38 2009 -0800" }, "message": "checkpatch: if should not continue a preceeding brace\n\nWe should not be continuing a braced section with an if, for example:\n\n\tif (...) {\n\t} if (...) {\n\t}\n\nDetect this and suggest adding a newline.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "63f17f8973ccdb8260e59ce5b1b4e2b2ee0401f0", "tree": "d37e5333ccb5ea5467f6d98d2efd4c1daf681364", "parents": [ "f9a0b3d17a01fe1ba24ce1e9c18666a52052e011" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:06 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:38 2009 -0800" }, "message": "checkpatch: allow parentheses on return handle array values\n\nWhen we allow return to have surrounding parentheses when containing\ncomparison operators we are not correctly handling the case where the\nvalues contain array sufffixes. Squash them.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f9a0b3d17a01fe1ba24ce1e9c18666a52052e011", "tree": "09a19fe504f889ae3c2691641be992a21932978a", "parents": [ "a27506459c5e6ccc8437fca0adb6d3759c883c28" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:05 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:38 2009 -0800" }, "message": "checkpatch: type/cast spacing should not check prefix spacing\n\nWe should not be complaining about the prefix spacing for types and casts.\n We are triggering here because the check for spacing between \u0027*\u0027s is\noverly loose. Tighten this up.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a27506459c5e6ccc8437fca0adb6d3759c883c28", "tree": "7ebce7fae5d7d989952bbc152aa270043445ab1c", "parents": [ "c91192d66d6cea7878b8542c9d9f1873971aba92" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Thu Jan 15 13:51:04 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 15 16:39:38 2009 -0800" }, "message": "checkpatch: handle missing #if open in context\n\nIf the #if opening statement is not in the context then the context stack\ncan be empty. Handle this by ensuring there is always a blank entry in\nthe stack.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nTested-by: Dhaval Giani \u003cdhaval@linux.vnet.ibm.com\u003e\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "57b9c6d9c5074a06fda770a7f009d655593e0e29", "tree": "401b77bf8141f50c0c41095cbeda44f136fe8ce4", "parents": [ "21caa13c02d67f755fad50370996c489c34a9b15" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:30 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: version: 0.26\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "21caa13c02d67f755fad50370996c489c34a9b15", "tree": "adc788fef2b0eedcdd4fa35c6b321644979e499a", "parents": [ "2b6db5cb65cb1276a7aa363a6e7335b0a8a68393" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:30 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: fix the perlcritic errors\n\nClean up checkpatch using perlcritic.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2b6db5cb65cb1276a7aa363a6e7335b0a8a68393", "tree": "289e1048f76a56c551ef57aeb4adf54d4f9a3172", "parents": [ "b53c8e104ed071c47ada2adce194625ab03d9f3d" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:29 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: struct file_operations should normally be const\n\nIn the general use case struct file_operations should be a const object.\nCheck for and warn where it is not. As suggested by Steven and Ingo.\n\nAcked-by: Steven Rostedt \u003crostedt@goodmis.org\u003e\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b53c8e104ed071c47ada2adce194625ab03d9f3d", "tree": "52354de0c3b69be0cf5d0eb85510f82b74eb807a", "parents": [ "2d1bafd799ee0442979e6ce4145d58b69d3cade2" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:29 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: ensure we actually detect if assignments split across lines\n\nWhen checking for assignments within if conditionals we check the whole of\nthe condition, but the match is performed using a line constrained regular\nexpression. This means we can miss split conditionals or those on the\nsecond line. Allow the check to span lines.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2d1bafd799ee0442979e6ce4145d58b69d3cade2", "tree": "83002f1bac78f652032aa00d81233fe75cbac175", "parents": [ "4635f4fbaf51555509c747eed02a7e7a580ae1e1" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:28 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: do not report nr_static as a static declaration\n\nEnsure we do not report identifiers containing the word static as static\ndeclarations. For example this should not be reported as an unecessary\nassignement of 0:\n\n\tlong nr_static \u003d 0;\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4635f4fbaf51555509c747eed02a7e7a580ae1e1", "tree": "d3d9d3d26b1c7d302c1200110c5d51b5340183f6", "parents": [ "8b1b33786b06a222cf3430b1bf942a3681532104" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:27 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: track #ifdef/#else/#endif when tracking blocks\n\nWhen picking up a complete statement or block for analysis we cannot\nsimply track open/close/etc parenthesis we must take into account\npreprocessor section boundaries.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8b1b33786b06a222cf3430b1bf942a3681532104", "tree": "dcacb222ddc7320f67a30c93440a09b5bf2a0c76", "parents": [ "8054576dca7e76dd1f58c525af3309cfc9c74454" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:27 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: fix continuation detection when handling spacing on operators\n\nWe are miscategorising a continuation fragment following an operator\nwhich may lead to us thinking that there is a space after it when there is\nnot. Fix this up.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8054576dca7e76dd1f58c525af3309cfc9c74454", "tree": "f603d38b1ecbfaae5953dc32e0f9dae0b8c1bad6", "parents": [ "080ba929651a32f1840751d2b862e64c8ee1f0c6" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:26 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:17 2009 -0800" }, "message": "checkpatch: loosen spacing on typedef function checks\n\nLoosen spacing checks to correctly detect this valid use of a typedef:\n\n\ttypedef struct rcu_data *(*get_data_func)(int);\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "080ba929651a32f1840751d2b862e64c8ee1f0c6", "tree": "a600273e6449d16d6256c66ea58ca060b22e8e6e", "parents": [ "86f9d059c6bc548f6337f01117897a4c823cb4ee" ], "author": { "name": "Mike Frysinger", "email": "vapier@gentoo.org", "time": "Tue Jan 06 14:41:25 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: try to catch missing VMLINUX_SYMBOL() in vmlinux.lds.h\n\nSeems like every other release we have someone who updates vmlinux.lds.h\nand adds C-visible symbols without VMLINUX_SYMBOL() around them. So start\nchecking the file and reject assignments which have plain symbols on\neither side.\n\n[apw@canonical.com: soften the check, add tests]\nSigned-off-by: Mike Frysinger \u003cvapier@gentoo.org\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "86f9d059c6bc548f6337f01117897a4c823cb4ee", "tree": "f7861404c3e84268a890f1cc3517bebaaa5bc49b", "parents": [ "1e85572697b348b1a126520349a29654f2ae6a12" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:24 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: allow parentheses on return for comparisons\n\nIt seems to be a common idiom to include braces on conditionals in all\ncontexts including return. Allow this exception to the return is not a\nfunction checks. Reported by Kay Sievers.\n\nCc: Kay Sievers \u003ckay.sievers@vrfy.org\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1e85572697b348b1a126520349a29654f2ae6a12", "tree": "1ce7febee025caa781c586090983718fde900c56", "parents": [ "2a5a2c25224e26c5ee491af0dc5d39e4a16f619c" ], "author": { "name": "Wolfram Sang", "email": "w.sang@pengutronix.de", "time": "Tue Jan 06 14:41:24 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: Add warning for p0-patches\n\nSome people work internally with -p0-patches which has the danger that one\nforgets to convert them to -p1 before mainlining. Bitten myself and seen\np0-patches in mailing lists occasionally, this patch adds a warning to\ncheckpatch.pl in case a patch is -p0. If you really want, you can fool\nthis check to generate false positives, this is why it just spits a\nwarning. Making the check 100% proof is trickier than it looks, so let\u0027s\nstart with a version which catches the cases of real use.\n\n[apw@canonical.com: update message language, handle null prefix, add tests]\nSigned-off-by: Wolfram Sang \u003cw.sang@pengutronix.de\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2a5a2c25224e26c5ee491af0dc5d39e4a16f619c", "tree": "958c4148a5db522cdc6ed8614332e0074cd53e39", "parents": [ "b0e0b4325375a360d33bace203e19471a9f9e067" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 06 14:41:23 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: update copyrights\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "50a7dcfb5062a5d9a0dcb28943a1e0cd5f0f60c2", "tree": "ced4023c0e9cc5c72e1fc986fe8496d4337bdc7c", "parents": [ "65863862ba112bf4d06d5ebc142b9d746d1ee955" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:21 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: version: 0.25\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "65863862ba112bf4d06d5ebc142b9d746d1ee955", "tree": "923755463967ded1f6f6d0e5a09cb92a628ac005", "parents": [ "fae17daed7312bae708df0cce7e93971308698b5" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:21 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:16 2009 -0800" }, "message": "checkpatch: dissallow spaces between stars in pointer types\n\nDisallow spaces within multiple pointer stars (*) in both casts and\ndefinitions. Both of these would now be reported:\n\n\t(char * *)\n\tchar * *foo;\n\nAlso now consistently detects and reports the attributes within these\nstructures making the error report itself clearer.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fae17daed7312bae708df0cce7e93971308698b5", "tree": "c31028127007a5481dfec1b90a90f072e3517a89", "parents": [ "8e761b04a34288a3b0b29c0f49cdf157d7db8863" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:20 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: comment ends inside strings is most likely not an open comment\n\nWhen we are detecting whether a comment is open when we start a hunk we\ncheck for the first comment edge in the hunk and assume its inverse.\nHowever if the hunk contains something like below, then we will assume\nthat a comment was open. Update this heuristic to see if the comment edge\nis obviously within double quotes and ignore it if so:\n\n\tfoo(\" */);\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8e761b04a34288a3b0b29c0f49cdf157d7db8863", "tree": "70aa571d291926c33327acffa4923d0124cd9b12", "parents": [ "5fe3af119bed58d240e2097fe76f322ab51902d7" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:19 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: detect multiple bitfield declarations\n\nDetect the colons (:) which make up secondary bitfield declarations and\napply binary colon checks. For example the following is common idiom:\n\n\tint foo:1,\n\t bar:1;\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5fe3af119bed58d240e2097fe76f322ab51902d7", "tree": "6b0c8b5f9bf1fc78d0c3f1208da641031a51df4b", "parents": [ "383099fd636deacf698b91b4c96d0d6d01e6dc79" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:18 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: __weak is an official attribute\n\nAdd __weak as an official attribute. This tends to be used in a location\nwhere the automated attribute detector misses it.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "383099fd636deacf698b91b4c96d0d6d01e6dc79", "tree": "d7cbbc220794407a160863ce12f54e06244e95d6", "parents": [ "83242e0c239aaa33e757584605f788ac1eca2f0f" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:18 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: structure member assignments are not complex\n\nEnsure we do not trigger the complex macros checks on structure member\nassignment, for example:\n\n\t#define foo .bar \u003d 10\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "83242e0c239aaa33e757584605f788ac1eca2f0f", "tree": "fa114470eebf1bb00dc97ad6a0620a5f5cc4d308", "parents": [ "721c1cb60e0546d2e71b9aa50426c94e69c6521a" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:17 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: widen implied comment detection to allow multiple stars\n\nSome people use double star \u0027**\u0027 as a comment continuation, and start\ncomments with complete lines of stars. Widen the implied comment\ndetection to pick these up.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "721c1cb60e0546d2e71b9aa50426c94e69c6521a", "tree": "69c767f29569545e1ec8e950fce4b4a03ae970fe", "parents": [ "691d77b6b85c20e4166bafd12bd0131b28f95a16" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:16 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: comment detection may miss an implied comment on the last hunk\n\nWhen detecting implied comments from leading stars we may incorrectly\nthink we have detected an edge one way or the other when we have not if we\ndrop off the end of the last hunk. Fix this up.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "691d77b6b85c20e4166bafd12bd0131b28f95a16", "tree": "b7c8950fadd6d3cf3a949d3977597cd0388544e8", "parents": [ "94e2959e7a6a4ef0969932c30349ce6f4469a3cf" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Tue Jan 06 14:41:16 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 06 15:59:15 2009 -0800" }, "message": "checkpatch: add checks for in_atomic()\n\nin_atomic() is not for driver use so report any such use as an ERROR.\nAlso in_atomic() is often used to determine if we may sleep, but it is not\nreliable in this use model therefore strongly discourage its use.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f4432c5caec5fa95ea7eefd00f8e6cee17e2e023", "tree": "677d41b0c8ad3f72157302ddb4e61428ccbee24e", "parents": [ "6da0b38f4433fb0f24615449d7966471b6e5eae0" ], "author": { "name": "Dave Jones", "email": "davej@redhat.com", "time": "Mon Oct 20 13:31:45 2008 -0400" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Oct 20 12:50:03 2008 -0700" }, "message": "Update email addresses.\n\nUpdate assorted email addresses and related info to point\nto a single current, valid address.\n\nadditionally\n- trivial CREDITS entry updates. (Not that this file means much any more)\n- remove arjans dead redhat.com address from powernow driver\n\nSigned-off-by: Dave Jones \u003cdavej@redhat.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6e144ee546b4bb4902524e639dc9c2cd4f7f97a4", "tree": "ee327fa420db4111e0b90ece3d7d21991d05763e", "parents": [ "3fef12d6cb832327a981b03326f8f07abebb51b7" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:36 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:38 2008 -0700" }, "message": "checkpatch: version: 0.24\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3fef12d6cb832327a981b03326f8f07abebb51b7", "tree": "418ea019c04e979862e47dd423ccb92ea5f04e3b", "parents": [ "740504c61f79a932564fb7117d79ad53d950b201" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:36 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: allow for comments either side of a brace on case\n\nWhen specifying case we may have comments and/or braces at the end without\nactually having a \u0027statement\u0027. Allow for these to occur in any order.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "740504c61f79a932564fb7117d79ad53d950b201", "tree": "932ad076982cb1fa4aaffbf8bb73c16667b772ea", "parents": [ "bb44ad39c886401e1ffe0876565f8b3fcea64e9d" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:35 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: suspect indent handle macro continuation\n\nWhen ignoring a macro in the middle of a conditional, we need to ignore\nthe macro start and any continuation lines.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "bb44ad39c886401e1ffe0876565f8b3fcea64e9d", "tree": "a204881902ff7b68dd45eefde815e43a78297a6a", "parents": [ "480120586464e5a8cd2289a90ffbb5c042e66ba0" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:34 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: trailing statements ensure we report the end of the line\n\nWhen reporting some complex trailing statements we report only the\nstarting line of the error, that tends to imply the shown line is in error\nand confuse the reader. As we do know where the actual error is report\nthat line too with an appropriate gap marker where applicable.\n\n #ERROR: trailing statements should be on next line\n #1: FILE: Z202.c:1:\n + for (pbh \u003d page_buffers(bh-\u003eb_page); pbh !\u003d bh;\n + pbh \u003d pbh-\u003eb_this_page, key++);\n #ERROR: trailing statements should be on next line\n #4: FILE: Z202.c:4:\n + for (pbh \u003d page_buffers(bh-\u003eb_page);\n [...]\n + pbh \u003d pbh-\u003eb_this_page, key++);\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "480120586464e5a8cd2289a90ffbb5c042e66ba0", "tree": "27485bdf461c4cf6323e5eec5a9ee55b8b90c8fc", "parents": [ "bf30d6ede099c2a31b13bbd05b1022dc0da684d5" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:34 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: DEFINE_ macros are real definitions for exports\n\nWhen we want to confirm an export is directly after its definition we need\nto allow for DEFINE_ style macros. Add these to the execeptions.\nRefactor the exceptions.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "bf30d6ede099c2a31b13bbd05b1022dc0da684d5", "tree": "54bf58e8077d06b7430b08044241cc230d5f5fca", "parents": [ "f16fa28f7b3d95e989fc64c8480e44c1bcf4bac3" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:33 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: complex macros checks miss square brackets\n\nWe are missing \u0027simple\u0027 values which include square brackets. Refactor to\nensure we handle nesting correctly and detect these simple forms.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f16fa28f7b3d95e989fc64c8480e44c1bcf4bac3", "tree": "e9a6c9f84efc907f4e24a96f386ea1645536fc90", "parents": [ "8ed22cad9ce16e3d8915ae75544a133c3050d96f" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Oct 15 22:02:32 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 16 11:21:37 2008 -0700" }, "message": "checkpatch: suspect code indent must stop at #else/#elif\n\nWhen we hit and #else or #elif we know we are meeting an alternative piece\nof code. All bets are off on indent if we did not see the open of the\ncontrol so stop checking.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" } ], "next": "8ed22cad9ce16e3d8915ae75544a133c3050d96f" }