)]}'
{
  "commit": "e385ea63f44b475e034a78b6d8bc6bb50caf72ca",
  "tree": "11b1a9122920c596f76ddf7ae0ac288f36f51ec2",
  "parents": [
    "363f66fe06c75270b669c88e321e6b354ba0201e"
  ],
  "author": {
    "name": "David Brownell",
    "email": "dbrownell@users.sourceforge.net",
    "time": "Tue Sep 02 14:35:46 2008 -0700"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@linux-foundation.org",
    "time": "Tue Sep 02 19:21:38 2008 -0700"
  },
  "message": "mmc: at91_mci: don\u0027t use coherent dma buffers\n\nAt91_mci is abusing dma_free_coherent(), which may not be called with IRQs\ndisabled.  I saw \"mkfs.ext3\" on an MMC card objecting voluminously as each\nwrite completed:\n\n WARNING: at arch/arm/mm/consistent.c:368 dma_free_coherent+0x2c/0x224()\n [\u003cc002726c\u003e] (dump_stack+0x0/0x14) from [\u003cc00387d4\u003e] (warn_on_slowpath+0x4c/0x68)\n [\u003cc0038788\u003e] (warn_on_slowpath+0x0/0x68) from [\u003cc0028768\u003e] (dma_free_coherent+0x2c/0x224)\n  r6:00008008 r5:ffc06000 r4:00000000\n [\u003cc002873c\u003e] (dma_free_coherent+0x0/0x224) from [\u003cc01918ac\u003e] (at91_mci_irq+0x374/0x420)\n [\u003cc0191538\u003e] (at91_mci_irq+0x0/0x420) from [\u003cc0065d9c\u003e] (handle_IRQ_event+0x2c/0x6c)\n ...\n\nThis bug has been around for a LONG time.  The MM warning is from late\n2005, but the driver merged a year later ...  so I\u0027m puzzled why nobody\nnoticed this before now.\n\nThe fix involves noting that this buffer shouldn\u0027t be DMA-coherent; it\u0027s\njust used for normal DMA writes.  So replace it with standard kmalloc()\nbuffering and DMA mapping calls.\n\nThis is the quickie fix.  A better one would not rely on allocating large\nbounce buffers.  (Note that dma_alloc_coherent could have failed too, but\nthat case was ignored...  kmalloc is a bit more likely to fail though.)\n\nSigned-off-by: David Brownell \u003cdbrownell@users.sourceforge.net\u003e\nAcked-by: Pierre Ossman \u003cdrzeus-mmc@drzeus.cx\u003e\nCc: Andrew Victor \u003clinux@maxim.org.za\u003e\nAcked-by: Nicolas Ferre \u003cnicolas.ferre@atmel.com\u003e\nCc: Russell King \u003crmk@arm.linux.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6915f40ac8ab4c293775563ed932a95d326bbbdb",
      "old_mode": 33188,
      "old_path": "drivers/mmc/host/at91_mci.c",
      "new_id": "1f8b5b36222c26645576c3a338673839178ad267",
      "new_mode": 33188,
      "new_path": "drivers/mmc/host/at91_mci.c"
    }
  ]
}