usb: dwc3: use a helper function for operation mode setting
There are two where need to set operational mode:
- during initialization while we decide to run in host,device or DRD
mode
- at runtime via the debugfs interface.
This patch provides a new function which sets the operational mode and
moves its initialiation to the mode switch instead in the gadget code
itself.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>
diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index b5370e7..ca4be0a 100644
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@ -443,29 +443,26 @@
struct seq_file *s = file->private_data;
struct dwc3 *dwc = s->private;
unsigned long flags;
- u32 reg;
+ u32 mode = 0;
char buf[32];
if (copy_from_user(&buf, ubuf, min_t(size_t, sizeof(buf) - 1, count)))
return -EFAULT;
- spin_lock_irqsave(&dwc->lock, flags);
- reg = dwc3_readl(dwc->regs, DWC3_GCTL);
-
- reg &= ~(DWC3_GCTL_PRTCAPDIR(DWC3_GCTL_PRTCAP_OTG));
-
if (!strncmp(buf, "host", 4))
- reg |= DWC3_GCTL_PRTCAP(DWC3_GCTL_PRTCAP_HOST);
+ mode |= DWC3_GCTL_PRTCAP_HOST;
if (!strncmp(buf, "device", 6))
- reg |= DWC3_GCTL_PRTCAP(DWC3_GCTL_PRTCAP_DEVICE);
+ mode |= DWC3_GCTL_PRTCAP_DEVICE;
if (!strncmp(buf, "otg", 3))
- reg |= DWC3_GCTL_PRTCAP(DWC3_GCTL_PRTCAP_OTG);
+ mode |= DWC3_GCTL_PRTCAP_OTG;
- dwc3_writel(dwc->regs, DWC3_GCTL, reg);
- spin_unlock_irqrestore(&dwc->lock, flags);
-
+ if (mode) {
+ spin_lock_irqsave(&dwc->lock, flags);
+ dwc3_set_mode(dwc, mode);
+ spin_unlock_irqrestore(&dwc->lock, flags);
+ }
return count;
}