)]}' { "commit": "83a0944fa919fb2ebcfc1f8933d86e437b597ca6", "tree": "814906744656554a1bc07cdad6b84b3581565358", "parents": [ "6baa0a5ae0954fb2486c480a20556a9f1aee0965" ], "author": { "name": "Ingo Molnar", "email": "mingo@elte.hu", "time": "Sat Aug 15 12:26:57 2009 +0200" }, "committer": { "name": "Ingo Molnar", "email": "mingo@elte.hu", "time": "Sun Aug 16 10:47:47 2009 +0200" }, "message": "perf: Enable more compiler warnings\n\nRelated to a shadowed variable bug fix Valdis Kletnieks noticed\nthat perf does not get built with -Wshadow, which could have\nhelped us avoid the bug.\n\nSo enable -Wshadow and also enable the following warnings on\nperf builds, in addition to the already enabled -Wall -Wextra\n-std\u003dgnu99 warnings:\n\n -Wcast-align\n -Wformat\u003d2\n -Wshadow\n -Winit-self\n -Wpacked\n -Wredundant-decls\n -Wstack-protector\n -Wstrict-aliasing\u003d3\n -Wswitch-default\n -Wswitch-enum\n -Wno-system-headers\n -Wundef\n -Wvolatile-register-var\n -Wwrite-strings\n -Wbad-function-cast\n -Wmissing-declarations\n -Wmissing-prototypes\n -Wnested-externs\n -Wold-style-definition\n -Wstrict-prototypes\n -Wdeclaration-after-statement\n\nAnd change/fix the perf code to build cleanly under GCC 4.3.2.\n\nThe list of warnings enablement is rather arbitrary: it\u0027s based\non my (quick) reading of the GCC manpages and trying them on\nperf.\n\nI categorized the warnings based on individually enabling them\nand looking whether they trigger something in the perf build.\nIf i liked those warnings (i.e. if they trigger for something\nthat arguably could be improved) i enabled the warning.\n\nIf the warnings seemed to come from language laywers spamming\nthe build with tons of nuisance warnings i generally kept them\noff. Most of the sign conversion related warnings were in\nthis category. (A second patch enabling some of the sign\nwarnings might be welcome - sign bugs can be nasty.)\n\nI also kept warnings that seem to make sense from their manpage\ndescription and which produced no actual warnings on our code\nbase. These warnings might still be turned off if they end up\nbeing a nuisance.\n\nI also left out a few warnings that are not supported in older\ncompilers.\n\n[ Note that these changes might break the build on older\n compilers i did not test, or on non-x86 architectures that\n produce different warnings, so more testing would be welcome. ]\n\nReported-by: Valdis.Kletnieks@vt.edu\nCc: Peter Zijlstra \u003ca.p.zijlstra@chello.nl\u003e\nCc: Mike Galbraith \u003cefault@gmx.de\u003e\nCc: Paul Mackerras \u003cpaulus@samba.org\u003e\nCc: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\nCc: Frederic Weisbecker \u003cfweisbec@gmail.com\u003e\nLKML-Reference: \u003cnew-submission\u003e\nSigned-off-by: Ingo Molnar \u003cmingo@elte.hu\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "0056405e4c93d13e24d4697eef399efd9ced818b", "old_mode": 33188, "old_path": "tools/perf/Makefile", "new_id": "8608c06f806e5fa0c144b882c68ee8f6e9b28571", "new_mode": 33188, "new_path": "tools/perf/Makefile" }, { "type": "modify", "old_id": "3bedaa5d21d29882e021021e34811822304c3d2e", "old_mode": 33188, "old_path": "tools/perf/builtin-annotate.c", "new_id": "32ff9838351efa727f0cff7fc9aeaceeffb08b61", "new_mode": 33188, "new_path": "tools/perf/builtin-annotate.c" }, { "type": "modify", "old_id": "2599d86a733b404db9be615519fec61b3517a1dd", "old_mode": 33188, "old_path": "tools/perf/builtin-help.c", "new_id": "4fb8734a796e992513cbae3f0cb2a5d8851ec113", "new_mode": 33188, "new_path": "tools/perf/builtin-help.c" }, { "type": "modify", "old_id": "298f26b8ac7899b79f3de1df5b93bd17d91e35f9", "old_mode": 33188, "old_path": "tools/perf/builtin-report.c", "new_id": "3b9d24dc0edadfbf2469dcab426881d8365ae65c", "new_mode": 33188, "new_path": "tools/perf/builtin-report.c" }, { "type": "modify", "old_id": "9a6dbbff9a9f0b80c28b737036bcb2078b481572", "old_mode": 33188, "old_path": "tools/perf/builtin-top.c", "new_id": "06f763e4b35b9220f0b544e52c881a08350ee864", "new_mode": 33188, "new_path": "tools/perf/builtin-top.c" }, { "type": "modify", "old_id": "61d33b81fc979ad66f9843872ac94720f3398f33", "old_mode": 33188, "old_path": "tools/perf/util/abspath.c", "new_id": "a791dd4672615e1315259dc70c23dd9fb2157f1c", "new_mode": 33188, "new_path": "tools/perf/util/abspath.c" }, { "type": "modify", "old_id": "4b50c412b9c574ecafc10c1c4cbaa48d8535194e", "old_mode": 33188, "old_path": "tools/perf/util/cache.h", "new_id": "6f8ea9d210b6d822f2e2ee57e99a3a520f516b73", "new_mode": 33188, "new_path": "tools/perf/util/cache.h" }, { "type": "modify", "old_id": "01147341164280a4f5a92fe3f5a4152ef40aa03e", "old_mode": 33188, "old_path": "tools/perf/util/callchain.c", "new_id": "3b8380f1b478804bfd01f1a2f9484297db4d9934", "new_mode": 33188, "new_path": "tools/perf/util/callchain.c" }, { "type": "modify", "old_id": "90a044d1fe7dffe526a50d8afdb5ac888ff31209", "old_mode": 33188, "old_path": "tools/perf/util/color.c", "new_id": "e47fdeb85391bfcda7a20361ebc180f8f779dc21", "new_mode": 33188, "new_path": "tools/perf/util/color.c" }, { "type": "modify", "old_id": "706cec50bd25188d3f123c338e4c22436f859d80", "old_mode": 33188, "old_path": "tools/perf/util/color.h", "new_id": "43d0d1b67c45c1afaaffb7854f11e9058bb28404", "new_mode": 33188, "new_path": "tools/perf/util/color.h" }, { "type": "modify", "old_id": "780df541006dd2dae77608ade75ad23069203d5f", "old_mode": 33188, "old_path": "tools/perf/util/config.c", "new_id": "8784649109ce88de709c08e30eeb06f25aaa04f4", "new_mode": 33188, "new_path": "tools/perf/util/config.c" }, { "type": "modify", "old_id": "34a3528673822622019687929f0499c4ebc0de1a", "old_mode": 33188, "old_path": "tools/perf/util/exec_cmd.c", "new_id": "2745605dba11f4d334c15a294326aa0c7ac2bfc9", "new_mode": 33188, "new_path": "tools/perf/util/exec_cmd.c" }, { "type": "modify", "old_id": "ddabe925d65dcf7b3feb75d9520d4948ceadb16e", "old_mode": 33188, "old_path": "tools/perf/util/module.c", "new_id": "3d567fe59c799285ac75dfa21b7343fd763b18f5", "new_mode": 33188, "new_path": "tools/perf/util/module.c" }, { "type": "modify", "old_id": "044178408783004c66429f48f75e937d61e32e8a", "old_mode": 33188, "old_path": "tools/perf/util/parse-events.c", "new_id": "1cda97b3911863bb10f86d6334efdf62c98d791d", "new_mode": 33188, "new_path": "tools/perf/util/parse-events.c" }, { "type": "modify", "old_id": "192a962e3a0fbe15b294dc6f1f5e9e787f68e32e", "old_mode": 33188, "old_path": "tools/perf/util/parse-events.h", "new_id": "9b1aeea01636f9d104bc1045d271ba00909f8804", "new_mode": 33188, "new_path": "tools/perf/util/parse-events.h" }, { "type": "modify", "old_id": "1bf67190c820041edb9e751c3aa56713394fcdce", "old_mode": 33188, "old_path": "tools/perf/util/parse-options.c", "new_id": "6d8af48c925eb6b0f9f094164e89bb000963afe1", "new_mode": 33188, "new_path": "tools/perf/util/parse-options.c" }, { "type": "modify", "old_id": "a501a40dd2cbeec12cc2d9b4ced0f5b3ea09842e", "old_mode": 33188, "old_path": "tools/perf/util/path.c", "new_id": "fd1f2faaade48542581b481804fb77c739578ce0", "new_mode": 33188, "new_path": "tools/perf/util/path.c" }, { "type": "modify", "old_id": "a3935343091ab0a8cac2759b0765a916feaeae19", "old_mode": 33188, "old_path": "tools/perf/util/run-command.c", "new_id": "2b615acf94d7bc69dff1af8ab6439e7c5f93b86b", "new_mode": 33188, "new_path": "tools/perf/util/run-command.c" }, { "type": "modify", "old_id": "0b9862351260f9794331ba8bdf6a74de0486963e", "old_mode": 33188, "old_path": "tools/perf/util/symbol.c", "new_id": "3159d47ae1cc7478ee52fc45b8c40e086ef7bfa1", "new_mode": 33188, "new_path": "tools/perf/util/symbol.c" }, { "type": "modify", "old_id": "48b8e5759af9f58101285fa1011c0776d74df97f", "old_mode": 33188, "old_path": "tools/perf/util/symbol.h", "new_id": "6e8490716408770b15905437bcebf07a4c89cc70", "new_mode": 33188, "new_path": "tools/perf/util/symbol.h" }, { "type": "modify", "old_id": "614cfaf4712afa1555ac36d02b7985f248e5ba27", "old_mode": 33188, "old_path": "tools/perf/util/values.c", "new_id": "1c15e39f99e3c90b4b6b974078685e45269491bc", "new_mode": 33188, "new_path": "tools/perf/util/values.c" }, { "type": "modify", "old_id": "f8960fde0547c3b385065f450e11e17ba27e2f5e", "old_mode": 33188, "old_path": "tools/perf/util/values.h", "new_id": "cadf8cf2a590c7169a2f3be58fdd9aded515cd43", "new_mode": 33188, "new_path": "tools/perf/util/values.h" } ] }