commit a461103ba2e22cbb70771588b36f40df39a50f46
author Ben Hutchings <bhutchings@solarflare.com> Thu Feb 24 23:59:15 2011 +0000
committer Ben Hutchings <bhutchings@solarflare.com> Mon Feb 28 23:57:23 2011 +0000
tree 526fe1532d3c69d9b322a458b8b26341058c6aa3
parent e5f0fd278084d79d6be0920043519749374b0507

sfc: Do not read STAT1.FAULT in efx_mdio_check_mmd()

This field does not exist in all MMDs we want to check, and all
callers allow it to be set (fault_fatal = 0).

Remove the loopback condition, as STAT2.DEVPRST should be valid
regardless of any fault.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>

drivers/net/sfc/txc43128_phy.c

diff --git a/drivers/net/sfc/txc43128_phy.c b/drivers/net/sfc/txc43128_phy.c
index 351794a..4e2b48a 100644
--- a/drivers/net/sfc/txc43128_phy.c
+++ b/drivers/net/sfc/txc43128_phy.c
@@ -193,7 +193,7 @@
 		goto fail;
 
 	/* Check that all the MMDs we expect are present and responding. */
-	rc = efx_mdio_check_mmds(efx, TXC_REQUIRED_DEVS, 0);
+	rc = efx_mdio_check_mmds(efx, TXC_REQUIRED_DEVS);
 	if (rc < 0)
 		goto fail;