commit b09ac64b7b2d93efab3998033588f5cb0e470ccf
author David Vrabel <david.vrabel@csr.com> Mon Oct 27 15:14:03 2008 +0000
committer David Vrabel <david.vrabel@csr.com> Tue Oct 28 12:06:59 2008 +0000
tree 9b4148f5010a4a45f2a835681f7269fe49ce1393
parent 6a4b58707903cb0901966ac8dad5d6ec7f2d432f

wusb: release mutex in the error path of whci-hcd's whc_do_gencmd()

Signed-off-by: David Vrabel <david.vrabel@csr.com>

drivers/usb/host/whci/hw.c

diff --git a/drivers/usb/host/whci/hw.c b/drivers/usb/host/whci/hw.c
index ac86e59..d498e72 100644
--- a/drivers/usb/host/whci/hw.c
+++ b/drivers/usb/host/whci/hw.c
@@ -50,6 +50,7 @@
 	unsigned long flags;
 	dma_addr_t dma_addr;
 	int t;
+	int ret = 0;
 
 	mutex_lock(&whc->mutex);
 
@@ -61,7 +62,8 @@
 		dev_err(&whc->umc->dev, "generic command timeout (%04x/%04x)\n",
 			le_readl(whc->base + WUSBGENCMDSTS),
 			le_readl(whc->base + WUSBGENCMDPARAMS));
-		return -ETIMEDOUT;
+		ret = -ETIMEDOUT;
+		goto out;
 	}
 
 	if (addr) {
@@ -80,8 +82,8 @@
 		  whc->base + WUSBGENCMDSTS);
 
 	spin_unlock_irqrestore(&whc->lock, flags);
-
+out:
 	mutex_unlock(&whc->mutex);
 
-	return 0;
+	return ret;
 }