)]}'
{
  "commit": "bcdddfb66cc998252d34758ce4109cedc0d24a5c",
  "tree": "8cea3d0275dce00f12b8b4ac853fac6841a1c6b9",
  "parents": [
    "0f2452855d86901ba3766826ccb5606ea4e15ab9"
  ],
  "author": {
    "name": "Linus Torvalds",
    "email": "torvalds@woody.linux-foundation.org",
    "time": "Tue Jan 30 14:11:12 2007 -0800"
  },
  "committer": {
    "name": "Linus Torvalds",
    "email": "torvalds@woody.linux-foundation.org",
    "time": "Tue Jan 30 14:11:12 2007 -0800"
  },
  "message": "Revert \"net: ifb error path loop fix\"\n\nThis reverts commit 0c0b3ae68ec93b1db5c637d294647d1cca0df763.\n\nQuoth David:\n\n  \"Jeff, please revert\n\n   It\u0027s wrong.  We had a lengthy analysis of this piece of code\n   several months ago, and it is correct.\n\n   Consider, if we run the loop and we get an error\n   the following happens:\n\n   1) attempt of ifb_init_one(i) fails, therefore we should\n      not try to \"ifb_free_one()\" on \"i\" since it failed\n   2) the loop iteration first increments \"i\", then it\n      check for error\n\n   Therefore we must decrement \"i\" twice before the first\n   free during the cleanup.  One to \"undo\" the for() loop\n   increment, and one to \"skip\" the ifb_init_one() case which\n   failed.\"\n\nReported-by: David Miller \u003cdavem@davemloft.net\u003e\nAcked-by: Jeff Garzik \u003cjgarzik@pobox.com\u003e\nCc: Andrew Morton \u003cakpm@osdl.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c4ca7c930a46cec4fdcb6187407958224fbf77d4",
      "old_mode": 33188,
      "old_path": "drivers/net/ifb.c",
      "new_id": "ca2b21f9d44489f4008761764f520f90a8956053",
      "new_mode": 33188,
      "new_path": "drivers/net/ifb.c"
    }
  ]
}