)]}' { "log": [ { "commit": "12ee4fc67c00895b3d740297f7ca447239c1983b", "tree": "a6e57caeada640e5b11100400e5acbec5f28425d", "parents": [ "7dbc725e4749d822eb6dc962526049af1586f041" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Wed Mar 20 03:28:01 2013 +0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 20 10:19:09 2013 -0700" }, "message": "workqueue: add missing POOL_FREEZING\n\nget_unbound_pool() forgot to set POOL_FREEZING if workqueue_freezing\nis set and a new pool could go out of sync with the global freezing\nstate.\n\nFix it by adding POOL_FREEZING if workqueue_freezing. wq_mutex is\nalready held so no further locking is necessary. This also removes\nthe unused static variable warning when !CONFIG_FREEZER.\n\ntj: Updated commit message.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "7dbc725e4749d822eb6dc962526049af1586f041", "tree": "b102c68e70c38739ce128102fa818f3e91b8056d", "parents": [ "a9ab775bcadf122d91e1a201eb66ae2eec90365a" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 19 13:45:21 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 19 13:45:21 2013 -0700" }, "message": "workqueue: restore CPU affinity of unbound workers on CPU_ONLINE\n\nWith the recent addition of the custom attributes support, unbound\npools may have allowed cpumask which isn\u0027t full. As long as some of\nCPUs in the cpumask are online, its workers will maintain cpus_allowed\nas set on worker creation; however, once no online CPU is left in\ncpus_allowed, the scheduler will reset cpus_allowed of any workers\nwhich get scheduled so that they can execute.\n\nTo remain compliant to the user-specified configuration, CPU affinity\nneeds to be restored when a CPU becomes online for an unbound pool\nwhich doesn\u0027t currently have any online CPUs before.\n\nThis patch implement restore_unbound_workers_cpumask(), which is\ncalled from CPU_ONLINE for all unbound pools, checks whether the\ncoming up CPU is the first allowed online one, and, if so, invokes\nset_cpus_allowed_ptr() with the configured cpumask on all workers.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "a9ab775bcadf122d91e1a201eb66ae2eec90365a", "tree": "98f30f2272d2ad62258744a48570c49ecfab66af", "parents": [ "bd7c089eb25b26d2e03fd34f97e5517a4463f871" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 19 13:45:21 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 19 13:45:21 2013 -0700" }, "message": "workqueue: directly restore CPU affinity of workers from CPU_ONLINE\n\nRebinding workers of a per-cpu pool after a CPU comes online involves\na lot of back-and-forth mostly because only the task itself could\nadjust CPU affinity if PF_THREAD_BOUND was set.\n\nAs CPU_ONLINE itself couldn\u0027t adjust affinity, it had to somehow\ncoerce the workers themselves to perform set_cpus_allowed_ptr(). Due\nto the various states a worker can be in, this led to three different\npaths a worker may be rebound. worker-\u003erebind_work is queued to busy\nworkers. Idle ones are signaled by unlinking worker-\u003eentry and call\nidle_worker_rebind(). The manager isn\u0027t covered by either and\nimplements its own mechanism.\n\nPF_THREAD_BOUND has been relaced with PF_NO_SETAFFINITY and CPU_ONLINE\nitself now can manipulate CPU affinity of workers. This patch\nreplaces the existing rebind mechanism with direct one where\nCPU_ONLINE iterates over all workers using for_each_pool_worker(),\nrestores CPU affinity, and clears WORKER_UNBOUND.\n\nThere are a couple subtleties. All bound idle workers should have\ntheir runqueues set to that of the bound CPU; however, if the target\ntask isn\u0027t running, set_cpus_allowed_ptr() just updates the\ncpus_allowed mask deferring the actual migration to when the task\nwakes up. This is worked around by waking up idle workers after\nrestoring CPU affinity before any workers can become bound.\n\nAnother subtlety is stems from matching @pool-\u003enr_running with the\nnumber of running unbound workers. While DISASSOCIATED, all workers\nare unbound and nr_running is zero. As workers become bound again,\nnr_running needs to be adjusted accordingly; however, there is no good\nway to tell whether a given worker is running without poking into\nscheduler internals. Instead of clearing UNBOUND directly,\nrebind_workers() replaces UNBOUND with another new NOT_RUNNING flag -\nREBOUND, which will later be cleared by the workers themselves while\npreparing for the next round of work item execution. The only change\nneeded for the workers is clearing REBOUND along with PREP.\n\n* This patch leaves for_each_busy_worker() without any user. Removed.\n\n* idle_worker_rebind(), busy_worker_rebind_fn(), worker-\u003erebind_work\n and rebind logic in manager_workers() removed.\n\n* worker_thread() now looks at WORKER_DIE instead of testing whether\n @worker-\u003eentry is empty to determine whether it needs to do\n something special as dying is the only special thing now.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "bd7c089eb25b26d2e03fd34f97e5517a4463f871", "tree": "17b8a08678910689293e1cf06942f20bea42929c", "parents": [ "822d8405d13931062d653e0c2cc0199ed801b072" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 19 13:45:21 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 19 13:45:21 2013 -0700" }, "message": "workqueue: relocate rebind_workers()\n\nrebind_workers() will be reimplemented in a way which makes it mostly\ndecoupled from the rest of worker management. Move rebind_workers()\nso that it\u0027s located with other CPU hotplug related functions.\n\nThis patch is pure function relocation.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "822d8405d13931062d653e0c2cc0199ed801b072", "tree": "388738869c771c58d20bc24d25729fabc0aab171", "parents": [ "14a40ffccd6163bbcd1d6f32b28a88ffe6149fc6" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 19 13:45:21 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 19 13:45:21 2013 -0700" }, "message": "workqueue: convert worker_pool-\u003eworker_ida to idr and implement for_each_pool_worker()\n\nMake worker_ida an idr - worker_idr and use it to implement\nfor_each_pool_worker() which will be used to simplify worker rebinding\non CPU_ONLINE.\n\npool-\u003eworker_idr is protected by both pool-\u003emanager_mutex and\npool-\u003elock so that it can be iterated while holding either lock.\n\n* create_worker() allocates ID without installing worker pointer and\n installs the pointer later using idr_replace(). This is because\n worker ID is needed when creating the actual task to name it and the\n new worker shouldn\u0027t be visible to iterations before fully\n initialized.\n\n* In destroy_worker(), ID removal is moved before kthread_stop().\n This is again to guarantee that only fully working workers are\n visible to for_each_pool_worker().\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "14a40ffccd6163bbcd1d6f32b28a88ffe6149fc6", "tree": "eb61e5bf7b64c3e67f3e33fe6b07fde4ee1d4d43", "parents": [ "2e109a2855bf6cf675a8b74dbd89b6492e8def42" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 19 13:45:20 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 19 13:45:20 2013 -0700" }, "message": "sched: replace PF_THREAD_BOUND with PF_NO_SETAFFINITY\n\nPF_THREAD_BOUND was originally used to mark kernel threads which were\nbound to a specific CPU using kthread_bind() and a task with the flag\nset allows cpus_allowed modifications only to itself. Workqueue is\ncurrently abusing it to prevent userland from meddling with\ncpus_allowed of workqueue workers.\n\nWhat we need is a flag to prevent userland from messing with\ncpus_allowed of certain kernel tasks. In kernel, anyone can\n(incorrectly) squash the flag, and, for worker-type usages,\nrestricting cpus_allowed modification to the task itself doesn\u0027t\nprovide meaningful extra proection as other tasks can inject work\nitems to the task anyway.\n\nThis patch replaces PF_THREAD_BOUND with PF_NO_SETAFFINITY.\nsched_setaffinity() checks the flag and return -EINVAL if set.\nset_cpus_allowed_ptr() is no longer affected by the flag.\n\nThis will allow simplifying workqueue worker CPU affinity management.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nAcked-by: Ingo Molnar \u003cmingo@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nCc: Peter Zijlstra \u003cpeterz@infradead.org\u003e\nCc: Thomas Gleixner \u003ctglx@linutronix.de\u003e\n" }, { "commit": "2e109a2855bf6cf675a8b74dbd89b6492e8def42", "tree": "22357bb67654f29db07d0f80b83e4e845cbee8c2", "parents": [ "794b18bc8a3f80445e1f85c9c87c74de9575c93a" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:40 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:40 2013 -0700" }, "message": "workqueue: rename workqueue_lock to wq_mayday_lock\n\nWith the recent locking updates, the only thing protected by\nworkqueue_lock is workqueue-\u003emaydays list. Rename workqueue_lock to\nwq_mayday_lock.\n\nThis patch is pure rename.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "794b18bc8a3f80445e1f85c9c87c74de9575c93a", "tree": "460e370381780ad497514abc1079f7cd20467ce0", "parents": [ "5bcab3355a555a9c1bd4becb136cbd3651c8eafa" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:40 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:40 2013 -0700" }, "message": "workqueue: separate out pool_workqueue locking into pwq_lock\n\nThis patch continues locking cleanup from the previous patch. It\nbreaks out pool_workqueue synchronization from workqueue_lock into a\nnew spinlock - pwq_lock. The followings are protected by pwq_lock.\n\n* workqueue-\u003epwqs\n* workqueue-\u003esaved_max_active\n\nThe conversion is straight-forward. workqueue_lock usages which cover\nthe above two are converted to pwq_lock. New locking label PW added\nfor things protected by pwq_lock and FR is updated to mean flush_mutex\n+ pwq_lock + sched-RCU.\n\nThis patch shouldn\u0027t introduce any visible behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "5bcab3355a555a9c1bd4becb136cbd3651c8eafa", "tree": "21b724b2fdaa0b78a4805cef9267499b61824963", "parents": [ "7d19c5ce6682fd0390049b5340d4b6bb6065d677" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:40 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:40 2013 -0700" }, "message": "workqueue: separate out pool and workqueue locking into wq_mutex\n\nCurrently, workqueue_lock protects most shared workqueue resources -\nthe pools, workqueues, pool_workqueues, draining, ID assignments,\nmayday handling and so on. The coverage has grown organically and\nthere is no identified bottleneck coming from workqueue_lock, but it\nhas grown a bit too much and scheduled rebinding changes need the\npools and workqueues to be protected by a mutex instead of a spinlock.\n\nThis patch breaks out pool and workqueue synchronization from\nworkqueue_lock into a new mutex - wq_mutex. The followings are\nprotected by wq_mutex.\n\n* worker_pool_idr and unbound_pool_hash\n* pool-\u003erefcnt\n* workqueues list\n* workqueue-\u003eflags, -\u003enr_drainers\n\nMost changes are mostly straight-forward. workqueue_lock is replaced\nwith wq_mutex where applicable and workqueue_lock lock/unlocks are\nadded where wq_mutex conversion leaves data structures not protected\nby wq_mutex without locking. irq / preemption flippings were added\nwhere the conversion affects them. Things worth noting are\n\n* New WQ and WR locking lables added along with\n assert_rcu_or_wq_mutex().\n\n* worker_pool_assign_id() now expects to be called under wq_mutex.\n\n* create_mutex is removed from get_unbound_pool(). It now just holds\n wq_mutex.\n\nThis patch shouldn\u0027t introduce any visible behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "7d19c5ce6682fd0390049b5340d4b6bb6065d677", "tree": "da5a04e853d217510d044da83891c09a3f3385da", "parents": [ "cd549687a7ee5e619a26f55af4059c4ae585811c" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:40 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:40 2013 -0700" }, "message": "workqueue: relocate global variable defs and function decls in workqueue.c\n\nThey\u0027re split across debugobj code for some reason. Collect them.\n\nThis patch is pure relocation.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "cd549687a7ee5e619a26f55af4059c4ae585811c", "tree": "5e24dfb098b57da5c267bef55e6c946c0e320e45", "parents": [ "ebf44d16ec4619c8a8daeacd987dd86d420ea2c3" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:39 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:39 2013 -0700" }, "message": "workqueue: better define locking rules around worker creation / destruction\n\nWhen a manager creates or destroys workers, the operations are always\ndone with the manager_mutex held; however, initial worker creation or\nworker destruction during pool release don\u0027t grab the mutex. They are\nstill correct as initial worker creation doesn\u0027t require\nsynchronization and grabbing manager_arb provides enough exclusion for\npool release path.\n\nStill, let\u0027s make everyone follow the same rules for consistency and\nsuch that lockdep annotations can be added.\n\nUpdate create_and_start_worker() and put_unbound_pool() to grab\nmanager_mutex around thread creation and destruction respectively and\nadd lockdep assertions to create_worker() and destroy_worker().\n\nThis patch doesn\u0027t introduce any visible behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "ebf44d16ec4619c8a8daeacd987dd86d420ea2c3", "tree": "501bb8fbeda2ff67d71af733c3c56150053a4351", "parents": [ "bc3a1afc92aea46d6df18d38e5d15867b17c69f6" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:39 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:39 2013 -0700" }, "message": "workqueue: factor out initial worker creation into create_and_start_worker()\n\nget_unbound_pool(), workqueue_cpu_up_callback() and init_workqueues()\nhave similar code pieces to create and start the initial worker factor\nthose out into create_and_start_worker().\n\nThis patch doesn\u0027t introduce any functional changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "bc3a1afc92aea46d6df18d38e5d15867b17c69f6", "tree": "0436a0916d33ef4b8a9acdaca0584f0a8f935327", "parents": [ "8425e3d5bdbe8e741d2c73cf3189ed59b4038b84" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:39 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 19:47:39 2013 -0700" }, "message": "workqueue: rename worker_pool-\u003eassoc_mutex to -\u003emanager_mutex\n\nManager operations are currently governed by two mutexes -\npool-\u003emanager_arb and -\u003eassoc_mutex. The former is used to decide who\ngets to be the manager and the latter to exclude the actual manager\noperations including creation and destruction of workers. Anyone who\ngrabs -\u003emanager_arb must perform manager role; otherwise, the pool\nmight stall.\n\nGrabbing -\u003eassoc_mutex blocks everyone else from performing manager\noperations but doesn\u0027t require the holder to perform manager duties as\nit\u0027s merely blocking manager operations without becoming the manager.\n\nBecause the blocking was necessary when [dis]associating per-cpu\nworkqueues during CPU hotplug events, the latter was named\nassoc_mutex. The mutex is scheduled to be used for other purposes, so\nthis patch gives it a more fitting generic name - manager_mutex - and\nupdates / adds comments to explain synchronization around the manager\nrole and operations.\n\nThis patch is pure rename / doc update.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "8425e3d5bdbe8e741d2c73cf3189ed59b4038b84", "tree": "5880573b3804d2b313b0b6b640836e57df63a5e9", "parents": [ "611c92a0203091bb022edec7e2d8b765fe148622" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:36 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:36 2013 -0700" }, "message": "workqueue: inline trivial wrappers\n\nThere\u0027s no reason to make these trivial wrappers full (exported)\nfunctions. Inline the followings.\n\n queue_work()\n queue_delayed_work()\n mod_delayed_work()\n schedule_work_on()\n schedule_work()\n schedule_delayed_work_on()\n schedule_delayed_work()\n keventd_up()\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "611c92a0203091bb022edec7e2d8b765fe148622", "tree": "84b1792c60c547f6d5e08b791fc62b5671a65a58", "parents": [ "c5aa87bbf4b23f5e4f167489406daeb0ed275c47" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:36 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:36 2013 -0700" }, "message": "workqueue: rename @id to @pi in for_each_each_pool()\n\nRename @id argument of for_each_pool() to @pi so that it doesn\u0027t get\nreused accidentally when for_each_pool() is used in combination with\nother iterators.\n\nThis patch is purely cosmetic.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "c5aa87bbf4b23f5e4f167489406daeb0ed275c47", "tree": "c0a8218033a0dd61fb840cbd300287405043ba70", "parents": [ "983ca25e738ee0c9c5435a503a6bb0034d4552b0" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:36 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:36 2013 -0700" }, "message": "workqueue: update comments and a warning message\n\n* Update incorrect and add missing synchronization labels.\n\n* Update incorrect or misleading comments. Add new comments where\n clarification is necessary. Reformat / rephrase some comments.\n\n* drain_workqueue() can be used separately from destroy_workqueue()\n but its warning message was incorrectly referring to destruction.\n\nOther than the warning message change, this patch doesn\u0027t make any\nfunctional changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "983ca25e738ee0c9c5435a503a6bb0034d4552b0", "tree": "24d945cc7c5476220f5d7c3a1fefddbc2f056373", "parents": [ "699ce097efe8f45bc5c055e4f12cb1e271c270d9" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:35 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:35 2013 -0700" }, "message": "workqueue: fix max_active handling in init_and_link_pwq()\n\nSince 9e8cd2f589 (\"workqueue: implement apply_workqueue_attrs()\"),\ninit_and_link_pwq() may be called to initialize a new pool_workqueue\nfor a workqueue which is already online, but the function was setting\npwq-\u003emax_active to wq-\u003esaved_max_active without proper\nsynchronization.\n\nFix it by calling pwq_adjust_max_active() under proper locking instead\nof manually setting max_active.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "699ce097efe8f45bc5c055e4f12cb1e271c270d9", "tree": "db116c908ed97eaf621c4dc99a4896acd51e56a2", "parents": [ "0fbd95aa8a056194933fba4ae78c50fc20f0704e" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:35 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:35 2013 -0700" }, "message": "workqueue: implement and use pwq_adjust_max_active()\n\nRename pwq_set_max_active() to pwq_adjust_max_active() and move\npool_workqueue-\u003emax_active synchronization and max_active\ndetermination logic into it.\n\nThe new function should be called with workqueue_lock held for stable\nworkqueue-\u003esaved_max_active, determines the current max_active value\nthe target pool_workqueue should be using from @wq-\u003esaved_max_active\nand the state of the associated pool, and applies it with proper\nsynchronization.\n\nThe current two users - workqueue_set_max_active() and\nthaw_workqueues() - are updated accordingly. In addition, the manual\nfreezing handling in __alloc_workqueue_key() and\nfreeze_workqueues_begin() are replaced with calls to\npwq_adjust_max_active().\n\nThis centralizes max_active handling so that it\u0027s less error-prone.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "0fbd95aa8a056194933fba4ae78c50fc20f0704e", "tree": "f9f092a3f5268dbb30c1b233f51917b81c452008", "parents": [ "e62676169118bc2d42e5008b3f8872646313f077" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:35 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 13 16:51:35 2013 -0700" }, "message": "workqueue: relocate pwq_set_max_active()\n\npwq_set_max_active() is gonna be modified and used during\npool_workqueue init. Move it above init_and_link_pwq().\n\nThis patch is pure code reorganization and doesn\u0027t introduce any\nfunctional changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "e62676169118bc2d42e5008b3f8872646313f077", "tree": "98ce7e6b03a8a18fa322de7997248a8e0b7b2f84", "parents": [ "226223ab3c4118ddd10688cc2c131135848371ab" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 17:41:37 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 17:42:01 2013 -0700" }, "message": "workqueue: implement current_is_workqueue_rescuer()\n\nImplement a function which queries whether it currently is running off\na workqueue rescuer. This will be used to convert writeback to\nworkqueue.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "226223ab3c4118ddd10688cc2c131135848371ab", "tree": "050da70ca30d34cbc9e21f628935e020c4106894", "parents": [ "36b519dfc7b57b8f91940a6e346d9a248e501e0d" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:05 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:37:07 2013 -0700" }, "message": "workqueue: implement sysfs interface for workqueues\n\nThere are cases where workqueue users want to expose control knobs to\nuserland. e.g. Unbound workqueues with custom attributes are\nscheduled to be used for writeback workers and depending on\nconfiguration it can be useful to allow admins to tinker with the\npriority or allowed CPUs.\n\nThis patch implements workqueue_sysfs_register(), which makes the\nworkqueue visible under /sys/bus/workqueue/devices/WQ_NAME. There\ncurrently are two attributes common to both per-cpu and unbound pools\nand extra attributes for unbound pools including nice level and\ncpumask.\n\nIf alloc_workqueue*() is called with WQ_SYSFS,\nworkqueue_sysfs_register() is called automatically as part of\nworkqueue creation. This is the preferred method unless the workqueue\nuser wants to apply workqueue_attrs before making the workqueue\nvisible to userland.\n\nv2: Disallow exposing ordered workqueues as ordered workqueues can\u0027t\n be tuned in any way.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "8719dceae2f98a578507c0f6b49c93f320bd729c", "tree": "3132f4c6ed84ec893bcad3aaec230fa78cede95d", "parents": [ "618b01eb426dd2d73a4b5e5ebc6379e4eee3b123" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "message": "workqueue: reject adjusting max_active or applying attrs to ordered workqueues\n\nAdjusting max_active of or applying new workqueue_attrs to an ordered\nworkqueue breaks its ordering guarantee. The former is obvious. The\nlatter is because applying attrs creates a new pwq (pool_workqueue)\nand there is no ordering constraint between the old and new pwqs.\n\nMake apply_workqueue_attrs() and workqueue_set_max_active() trigger\nWARN_ON() if those operations are requested on an ordered workqueue\nand fail / ignore respectively.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "618b01eb426dd2d73a4b5e5ebc6379e4eee3b123", "tree": "9068381e7a25dde3d4d72fd8b9fe8a814bc85efe", "parents": [ "9e8cd2f5898ab6710ad81f4583fada08bf8049a4" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "message": "workqueue: make it clear that WQ_DRAINING is an internal flag\n\nWe\u0027re gonna add another internal WQ flag. Let\u0027s make the distinction\nclear. Prefix WQ_DRAINING with __ and move it to bit 16.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "9e8cd2f5898ab6710ad81f4583fada08bf8049a4", "tree": "bb3950d07a5e23be7817eaaa0517066b7d5f82fb", "parents": [ "c9178087acd71b4ea010ea48e147cf66952d2da9" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "message": "workqueue: implement apply_workqueue_attrs()\n\nImplement apply_workqueue_attrs() which applies workqueue_attrs to the\nspecified unbound workqueue by creating a new pwq (pool_workqueue)\nlinked to worker_pool with the specified attributes.\n\nA new pwq is linked at the head of wq-\u003epwqs instead of tail and\n__queue_work() verifies that the first unbound pwq has positive refcnt\nbefore choosing it for the actual queueing. This is to cover the case\nwhere creation of a new pwq races with queueing. As base ref on a pwq\nwon\u0027t be dropped without making another pwq the first one,\n__queue_work() is guaranteed to make progress and not add work item to\na dead pwq.\n\ninit_and_link_pwq() is updated to return the last first pwq the new\npwq replaced, which is put by apply_workqueue_attrs().\n\nNote that apply_workqueue_attrs() is almost identical to unbound pwq\npart of alloc_and_link_pwqs(). The only difference is that there is\nno previous first pwq. apply_workqueue_attrs() is implemented to\nhandle such cases and replaces unbound pwq handling in\nalloc_and_link_pwqs().\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "c9178087acd71b4ea010ea48e147cf66952d2da9", "tree": "0b226a810036ee110d0f894c821df50df64db29b", "parents": [ "75ccf5950f828d53aebfd3a852283a00abf2c5bf" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "message": "workqueue: perform non-reentrancy test when queueing to unbound workqueues too\n\nBecause per-cpu workqueues have multiple pwqs (pool_workqueues) to\nserve the CPUs, to guarantee that a single work item isn\u0027t queued on\none pwq while still executing another, __queue_work() takes a look at\nthe previous pool the target work item was on and if it\u0027s still\nexecuting there, queue the work item on that pool.\n\nTo support changing workqueue_attrs on the fly, unbound workqueues too\nwill have multiple pwqs and thus need non-reentrancy test when\nqueueing. This patch modifies __queue_work() such that the reentrancy\ntest is performed regardless of the workqueue type.\n\nper_cpu_ptr(wq-\u003ecpu_pwqs, cpu) used to be used to determine the\nmatching pwq for the last pool. This can\u0027t be used for unbound\nworkqueues and is replaced with worker-\u003ecurrent_pwq which also happens\nto be simpler.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "75ccf5950f828d53aebfd3a852283a00abf2c5bf", "tree": "3a2085d3deec15d600cfed31107164d92600e078", "parents": [ "8864b4e59f7945a636eeb27671f10486149be6e6" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "message": "workqueue: prepare flush_workqueue() for dynamic creation and destrucion of unbound pool_workqueues\n\nUnbound pwqs (pool_workqueues) will be dynamically created and\ndestroyed with the scheduled unbound workqueue w/ custom attributes\nsupport. This patch synchronizes pwq linking and unlinking against\nflush_workqueue() so that its operation isn\u0027t disturbed by pwqs coming\nand going.\n\nLinking and unlinking a pwq into wq-\u003epwqs is now protected also by\nwq-\u003eflush_mutex and a new pwq\u0027s work_color is initialized to\nwq-\u003ework_color during linking. This ensures that pwqs changes don\u0027t\ndisturb flush_workqueue() in progress and the new pwq\u0027s work coloring\nstays in sync with the rest of the workqueue.\n\nflush_mutex during unlinking isn\u0027t strictly necessary but it\u0027s simpler\nto do it anyway.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "8864b4e59f7945a636eeb27671f10486149be6e6", "tree": "74382658daf648a612e0bda94cb161cac84f0523", "parents": [ "d2c1d40487bb1884be085c187233084f80df052d" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "message": "workqueue: implement get/put_pwq()\n\nAdd pool_workqueue-\u003erefcnt along with get/put_pwq(). Both per-cpu and\nunbound pwqs have refcnts and any work item inserted on a pwq\nincrements the refcnt which is dropped when the work item finishes.\n\nFor per-cpu pwqs the base ref is never dropped and destroy_workqueue()\nfrees the pwqs as before. For unbound ones, destroy_workqueue()\nsimply drops the base ref on the first pwq. When the refcnt reaches\nzero, pwq_unbound_release_workfn() is scheduled on system_wq, which\nunlinks the pwq, puts the associated pool and frees the pwq and wq as\nnecessary. This needs to be done from a work item as put_pwq() needs\nto be protected by pool-\u003elock but release can\u0027t happen with the lock\nheld - e.g. put_unbound_pool() involves blocking operations.\n\nUnbound pool-\u003elocks are marked with lockdep subclas 1 as put_pwq()\nwill schedule the release work item on system_wq while holding the\nunbound pool\u0027s lock and triggers recursive locking warning spuriously.\n\nThis will be used to implement dynamic creation and destruction of\nunbound pwqs.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "d2c1d40487bb1884be085c187233084f80df052d", "tree": "11ea6d2f331ed75935d0e65643d657f74278d881", "parents": [ "493008a8e475771a2126e0ce95a73e35b371d277" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:04 2013 -0700" }, "message": "workqueue: restructure __alloc_workqueue_key()\n\n* Move initialization and linking of pool_workqueues into\n init_and_link_pwq().\n\n* Make the failure path use destroy_workqueue() once pool_workqueue\n initialization succeeds.\n\nThese changes are to prepare for dynamic management of pool_workqueues\nand don\u0027t introduce any functional changes.\n\nWhile at it, convert list_del(\u0026wq-\u003elist) to list_del_init() as a\nprecaution as scheduled changes will make destruction more complex.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "493008a8e475771a2126e0ce95a73e35b371d277", "tree": "0e67b51ade42bb623456aa186cec7a5722a8420c", "parents": [ "ac6104cdf87cc162b0a0d78280d1dcb9752e25bb" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:03 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:03 2013 -0700" }, "message": "workqueue: drop WQ_RESCUER and test workqueue-\u003erescuer for NULL instead\n\nWQ_RESCUER is superflous. WQ_MEM_RECLAIM indicates that the user\nwants a rescuer and testing wq-\u003erescuer for NULL can answer whether a\ngiven workqueue has a rescuer or not. Drop WQ_RESCUER and test\nwq-\u003erescuer directly.\n\nThis will help simplifying __alloc_workqueue_key() failure path by\nallowing it to use destroy_workqueue() on a partially constructed\nworkqueue, which in turn will help implementing dynamic management of\npool_workqueues.\n\nWhile at it, clear wq-\u003erescuer after freeing it in\ndestroy_workqueue(). This is a precaution as scheduled changes will\nmake destruction more complex.\n\nThis patch doesn\u0027t introduce any functional changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "ac6104cdf87cc162b0a0d78280d1dcb9752e25bb", "tree": "dd62f586800cd7e0eb491469eaba763316c3f1cd", "parents": [ "f02ae73aaa4f285199683862ac59972877a11c5d" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:03 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:03 2013 -0700" }, "message": "workqueue: add pool ID to the names of unbound kworkers\n\nThere are gonna be multiple unbound pools. Include pool ID in the\nname of unbound kworkers.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "f02ae73aaa4f285199683862ac59972877a11c5d", "tree": "ca517312e1ed5bfaff9b18ebefcd8faf064ad040", "parents": [ "7a62c2c87e3bc174fe4b9e9720e148427510fcfb" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:03 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:03 2013 -0700" }, "message": "workqueue: drop \"std\" from cpu_std_worker_pools and for_each_std_worker_pool()\n\nAll per-cpu pools are standard, so there\u0027s no need to use both \"cpu\"\nand \"std\" and for_each_std_worker_pool() is confusing in that it can\nbe used only for per-cpu pools.\n\n* s/cpu_std_worker_pools/cpu_worker_pools/\n\n* s/for_each_std_worker_pool()/for_each_cpu_worker_pool()/\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "7a62c2c87e3bc174fe4b9e9720e148427510fcfb", "tree": "9da41de39c7d55d0b54250eadb2980d12e1e825d", "parents": [ "29c91e9912bed7060df6116af90286500f5a700d" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:03 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:03 2013 -0700" }, "message": "workqueue: remove unbound_std_worker_pools[] and related helpers\n\nWorkqueue no longer makes use of unbound_std_worker_pools[]. All\nunbound worker_pools are created dynamically and there\u0027s nothing\nspecial about the standard ones. With unbound_std_worker_pools[]\nunused, workqueue no longer has places where it needs to treat the\nper-cpu pools-cpu and unbound pools together.\n\nRemove unbound_std_worker_pools[] and the helpers wrapping it to\npresent unified per-cpu and unbound standard worker_pools.\n\n* for_each_std_worker_pool() now only walks through per-cpu pools.\n\n* for_each[_online]_wq_cpu() which don\u0027t have any users left are\n removed.\n\n* std_worker_pools() and std_worker_pool_pri() are unused and removed.\n\n* get_std_worker_pool() is removed. Its only user -\n alloc_and_link_pwqs() - only used it for per-cpu pools anyway. Open\n code per_cpu access in alloc_and_link_pwqs() instead.\n\nThis patch doesn\u0027t introduce any functional changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "29c91e9912bed7060df6116af90286500f5a700d", "tree": "f5de35e3da85b2f90bda13f7bfb5ea98fbd4d86d", "parents": [ "7a4e344c5675eefbde93ed9a98ef45e0e4957bc2" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:03 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:03 2013 -0700" }, "message": "workqueue: implement attribute-based unbound worker_pool management\n\nThis patch makes unbound worker_pools reference counted and\ndynamically created and destroyed as workqueues needing them come and\ngo. All unbound worker_pools are hashed on unbound_pool_hash which is\nkeyed by the content of worker_pool-\u003eattrs.\n\nWhen an unbound workqueue is allocated, get_unbound_pool() is called\nwith the attributes of the workqueue. If there already is a matching\nworker_pool, the reference count is bumped and the pool is returned.\nIf not, a new worker_pool with matching attributes is created and\nreturned.\n\nWhen an unbound workqueue is destroyed, put_unbound_pool() is called\nwhich decrements the reference count of the associated worker_pool.\nIf the refcnt reaches zero, the worker_pool is destroyed in sched-RCU\nsafe way.\n\nNote that the standard unbound worker_pools - normal and highpri ones\nwith no specific cpumask affinity - are no longer created explicitly\nduring init_workqueues(). init_workqueues() only initializes\nworkqueue_attrs to be used for standard unbound pools -\nunbound_std_wq_attrs[]. The pools are spawned on demand as workqueues\nare created.\n\nv2: - Comment added to init_worker_pool() explaining that @pool should\n be in a condition which can be passed to put_unbound_pool() even\n on failure.\n\n - pool-\u003erefcnt reaching zero and the pool being removed from\n unbound_pool_hash should be dynamic. pool-\u003erefcnt is converted\n to int from atomic_t and now manipulated inside workqueue_lock.\n\n - Removed an incorrect sanity check on nr_idle in\n put_unbound_pool() which may trigger spuriously.\n\n All changes were suggested by Lai Jiangshan.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "7a4e344c5675eefbde93ed9a98ef45e0e4957bc2", "tree": "7a4383063512328184db9d20e27164824c44dc2c", "parents": [ "4e1a1f9a051b4c9a2821a2a0f7f4a27c701fba51" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "message": "workqueue: introduce workqueue_attrs\n\nIntroduce struct workqueue_attrs which carries worker attributes -\ncurrently the nice level and allowed cpumask along with helper\nroutines alloc_workqueue_attrs() and free_workqueue_attrs().\n\nEach worker_pool now carries -\u003eattrs describing the attributes of its\nworkers. All functions dealing with cpumask and nice level of workers\nare updated to follow worker_pool-\u003eattrs instead of determining them\nfrom other characteristics of the worker_pool, and init_workqueues()\nis updated to set worker_pool-\u003eattrs appropriately for all standard\npools.\n\nNote that create_worker() is updated to always perform set_user_nice()\nand use set_cpus_allowed_ptr() combined with manual assertion of\nPF_THREAD_BOUND instead of kthread_bind(). This simplifies handling\nrandom attributes without affecting the outcome.\n\nThis patch doesn\u0027t introduce any behavior changes.\n\nv2: Missing cpumask_var_t definition caused build failure on some\n archs. linux/cpumask.h included.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReported-by: kbuild test robot \u003cfengguang.wu@intel.com\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "4e1a1f9a051b4c9a2821a2a0f7f4a27c701fba51", "tree": "637cab0901bc51e12b1453c4f67a5387b8a673d1", "parents": [ "34a06bd6b6fa92ccd9d3e6866b6cb91264c3cd20" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "message": "workqueue: separate out init_worker_pool() from init_workqueues()\n\nThis will be used to implement unbound pools with custom attributes.\n\nThis patch doesn\u0027t introduce any functional changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "34a06bd6b6fa92ccd9d3e6866b6cb91264c3cd20", "tree": "546c715508dd2d4a80c754b24e41e1d4d2899775", "parents": [ "fa1b54e69bc6c04674c9bb96a6cfa8b2c9f44771" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "message": "workqueue: replace POOL_MANAGING_WORKERS flag with worker_pool-\u003emanager_arb\n\nPOOL_MANAGING_WORKERS is used to synchronize the manager role.\nSynchronizing among workers doesn\u0027t need blocking and that\u0027s why it\u0027s\nimplemented as a flag.\n\nIt got converted to a mutex a while back to add blocking wait from CPU\nhotplug path - 6037315269 (\"workqueue: use mutex for global_cwq\nmanager exclusion\"). Later it turned out that synchronization among\nworkers and cpu hotplug need to be done separately. Eventually,\nPOOL_MANAGING_WORKERS is restored and workqueue-\u003emanager_mutex got\nmorphed into workqueue-\u003eassoc_mutex - 552a37e936 (\"workqueue: restore\nPOOL_MANAGING_WORKERS\") and b2eb83d123 (\"workqueue: rename\nmanager_mutex to assoc_mutex\").\n\nNow, we\u0027re gonna need to be able to lock out managers from\ndestroy_workqueue() to support multiple unbound pools with custom\nattributes making it again necessary to be able to block on the\nmanager role. This patch replaces POOL_MANAGING_WORKERS with\nworker_pool-\u003emanager_arb.\n\nThis patch doesn\u0027t introduce any behavior changes.\n\nv2: s/manager_mutex/manager_arb/\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "fa1b54e69bc6c04674c9bb96a6cfa8b2c9f44771", "tree": "d04342a5015b1b88fdefeceabdb1f26479dcff65", "parents": [ "76af4d936153afec176c53378e6ba8671e7e237d" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "message": "workqueue: update synchronization rules on worker_pool_idr\n\nMake worker_pool_idr protected by workqueue_lock for writes and\nsched-RCU protected for reads. Lockdep assertions are added to\nfor_each_pool() and get_work_pool() and all their users are converted\nto either hold workqueue_lock or disable preemption/irq.\n\nworker_pool_assign_id() is updated to hold workqueue_lock when\nallocating a pool ID. As idr_get_new() always performs RCU-safe\nassignment, this is enough on the writer side.\n\nAs standard pools are never destroyed, there\u0027s nothing to do on that\nside.\n\nThe locking is superflous at this point. This is to help\nimplementation of unbound pools/pwqs with custom attributes.\n\nThis patch doesn\u0027t introduce any behavior changes.\n\nv2: Updated for_each_pwq() use if/else for the hidden assertion\n statement instead of just if as suggested by Lai. This avoids\n confusing the following else clause.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "76af4d936153afec176c53378e6ba8671e7e237d", "tree": "94db54e019cc5c66305381f532506cc767df1930", "parents": [ "7fb98ea79cecb14fc1735544146be06fdb1944c3" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "message": "workqueue: update synchronization rules on workqueue-\u003epwqs\n\nMake workqueue-\u003epwqs protected by workqueue_lock for writes and\nsched-RCU protected for reads. Lockdep assertions are added to\nfor_each_pwq() and first_pwq() and all their users are converted to\neither hold workqueue_lock or disable preemption/irq.\n\nalloc_and_link_pwqs() is updated to use list_add_tail_rcu() for\nconsistency which isn\u0027t strictly necessary as the workqueue isn\u0027t\nvisible. destroy_workqueue() isn\u0027t updated to sched-RCU release pwqs.\nThis is okay as the workqueue should have on users left by that point.\n\nThe locking is superflous at this point. This is to help\nimplementation of unbound pools/pwqs with custom attributes.\n\nThis patch doesn\u0027t introduce any behavior changes.\n\nv2: Updated for_each_pwq() use if/else for the hidden assertion\n statement instead of just if as suggested by Lai. This avoids\n confusing the following else clause.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "7fb98ea79cecb14fc1735544146be06fdb1944c3", "tree": "1110c0288884b507b1fcf4dddb823ea626415be2", "parents": [ "420c0ddb1f205a3511b766d0dfee2cc87ed9dae0" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:30:00 2013 -0700" }, "message": "workqueue: replace get_pwq() with explicit per_cpu_ptr() accesses and first_pwq()\n\nget_pwq() takes @cpu, which can also be WORK_CPU_UNBOUND, and @wq and\nreturns the matching pwq (pool_workqueue). We want to move away from\nusing @cpu for identifying pools and pwqs for unbound pools with\ncustom attributes and there is only one user - workqueue_congested() -\nwhich makes use of the WQ_UNBOUND conditional in get_pwq(). All other\nusers already know whether they\u0027re dealing with a per-cpu or unbound\nworkqueue.\n\nReplace get_pwq() with explicit per_cpu_ptr(wq-\u003ecpu_pwqs, cpu) for\nper-cpu workqueues and first_pwq() for unbound ones, and open-code\nWQ_UNBOUND conditional in workqueue_congested().\n\nNote that this makes workqueue_congested() behave sligntly differently\nwhen @cpu other than WORK_CPU_UNBOUND is specified. It ignores @cpu\nfor unbound workqueues and always uses the first pwq instead of\noopsing.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "420c0ddb1f205a3511b766d0dfee2cc87ed9dae0", "tree": "b40f69b265def3d67d2ea67b06584bc2e7437678", "parents": [ "d84ff0512f1bfc0d8c864efadb4523fce68919cc" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:59 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:59 2013 -0700" }, "message": "workqueue: remove workqueue_struct-\u003epool_wq.single\n\nworkqueue-\u003epool_wq union is used to point either to percpu pwqs\n(pool_workqueues) or single unbound pwq. As the first pwq can be\naccessed via workqueue-\u003epwqs list, there\u0027s no reason for the single\npointer anymore.\n\nUse list_first_entry(workqueue-\u003epwqs) to access the unbound pwq and\ndrop workqueue-\u003epool_wq.single pointer and the pool_wq union. It\nsimplifies the code and eases implementing multiple unbound pools w/\ncustom attributes.\n\nThis patch doesn\u0027t introduce any visible behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "d84ff0512f1bfc0d8c864efadb4523fce68919cc", "tree": "b91fe48e9bd59e0709b00869cd200c79f882afff", "parents": [ "493a1724fef9a3e931d9199f1a19e358e526a6e7" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:59 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:59 2013 -0700" }, "message": "workqueue: consistently use int for @cpu variables\n\nWorkqueue is mixing unsigned int and int for @cpu variables. There\u0027s\nno point in using unsigned int for cpus - many of cpu related APIs\ntake int anyway. Consistently use int for @cpu variables so that we\ncan use negative values to mark special ones.\n\nThis patch doesn\u0027t introduce any visible behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "493a1724fef9a3e931d9199f1a19e358e526a6e7", "tree": "5cb9ae483904b26b885ae5fb9fc7e7fdca635e71", "parents": [ "24b8a84718ed28a51b452881612c267ba3f2b263" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:59 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:59 2013 -0700" }, "message": "workqueue: add wokrqueue_struct-\u003emaydays list to replace mayday cpu iterators\n\nSimilar to how pool_workqueue iteration used to be, raising and\nservicing mayday requests is based on CPU numbers. It\u0027s hairy because\ncpumask_t may not be able to handle WORK_CPU_UNBOUND and cpumasks are\nassumed to be always set on UP. This is ugly and can\u0027t handle\nmultiple unbound pools to be added for unbound workqueues w/ custom\nattributes.\n\nAdd workqueue_struct-\u003emaydays. When a pool_workqueue needs rescuing,\nit gets chained on the list through pool_workqueue-\u003emayday_node and\nrescuer_thread() consumes the list until it\u0027s empty.\n\nThis patch doesn\u0027t introduce any visible behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "24b8a84718ed28a51b452881612c267ba3f2b263", "tree": "af47f74e181a6a431aee517f149015f769b7ed0a", "parents": [ "171169695555831e8cc41dbc1783700868631ea5" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:58 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:58 2013 -0700" }, "message": "workqueue: restructure pool / pool_workqueue iterations in freeze/thaw functions\n\nThe three freeze/thaw related functions - freeze_workqueues_begin(),\nfreeze_workqueues_busy() and thaw_workqueues() - need to iterate\nthrough all pool_workqueues of all freezable workqueues. They did it\nby first iterating pools and then visiting all pwqs (pool_workqueues)\nof all workqueues and process it if its pwq-\u003epool matches the current\npool. This is rather backwards and done this way partly because\nworkqueue didn\u0027t have fitting iteration helpers and partly to avoid\nthe number of lock operations on pool-\u003elock.\n\nWorkqueue now has fitting iterators and the locking operation overhead\nisn\u0027t anything to worry about - those locks are unlikely to be\ncontended and the same CPU visiting the same set of locks multiple\ntimes isn\u0027t expensive.\n\nRestructure the three functions such that the flow better matches the\nlogical steps and pwq iteration is done using for_each_pwq() inside\nworkqueue iteration.\n\n* freeze_workqueues_begin(): Setting of FREEZING is moved into a\n separate for_each_pool() iteration. pwq iteration for clearing\n max_active is updated as described above.\n\n* freeze_workqueues_busy(): pwq iteration updated as described above.\n\n* thaw_workqueues(): The single for_each_wq_cpu() iteration is broken\n into three discrete steps - clearing FREEZING, restoring max_active,\n and kicking workers. The first and last steps use for_each_pool()\n and the second step uses pwq iteration described above.\n\nThis makes the code easier to understand and removes the use of\nfor_each_wq_cpu() for walking pwqs, which can\u0027t support multiple\nunbound pwqs which will be needed to implement unbound workqueues with\ncustom attributes.\n\nThis patch doesn\u0027t introduce any visible behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "171169695555831e8cc41dbc1783700868631ea5", "tree": "62e774a7298eadb486a7148796b2e8cd627d6e77", "parents": [ "49e3cf44df0663a521aa71e7667c52a9dbd0fce9" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:58 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:58 2013 -0700" }, "message": "workqueue: introduce for_each_pool()\n\nWith the scheduled unbound pools with custom attributes, there will be\nmultiple unbound pools, so it wouldn\u0027t be able to use\nfor_each_wq_cpu() + for_each_std_worker_pool() to iterate through all\npools.\n\nIntroduce for_each_pool() which iterates through all pools using\nworker_pool_idr and use it instead of for_each_wq_cpu() +\nfor_each_std_worker_pool() combination in freeze_workqueues_begin().\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "49e3cf44df0663a521aa71e7667c52a9dbd0fce9", "tree": "6abded05fad30819d5f417cd967ffe468d25b629", "parents": [ "30cdf2496d8ac2ef94b9b85f1891cf069490c8c4" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:58 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:58 2013 -0700" }, "message": "workqueue: replace for_each_pwq_cpu() with for_each_pwq()\n\nIntroduce for_each_pwq() which iterates all pool_workqueues of a\nworkqueue using the recently added workqueue-\u003epwqs list and replace\nfor_each_pwq_cpu() usages with it.\n\nThis is primarily to remove the single unbound CPU assumption from pwq\niteration for the scheduled unbound pools with custom attributes\nsupport which would introduce multiple unbound pwqs per workqueue;\nhowever, it also simplifies iterator users.\n\nNote that pwq-\u003epool initialization is moved to alloc_and_link_pwqs()\nas that now is the only place which is explicitly handling the two pwq\ntypes.\n\nThis patch doesn\u0027t introduce any visible behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "30cdf2496d8ac2ef94b9b85f1891cf069490c8c4", "tree": "0a3e95d353c7395cf92f03b3a23b5d2a9c86bb10", "parents": [ "e904e6c2668bba78497c660aec812ca3f77f4ef9" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:57 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:57 2013 -0700" }, "message": "workqueue: add workqueue_struct-\u003epwqs list\n\nAdd workqueue_struct-\u003epwqs list and chain all pool_workqueues\nbelonging to a workqueue there. This will be used to implement\ngeneric pool_workqueue iteration and handle multiple pool_workqueues\nfor the scheduled unbound pools with custom attributes.\n\nThis patch doesn\u0027t introduce any visible behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "e904e6c2668bba78497c660aec812ca3f77f4ef9", "tree": "96aa53109506d97703c1195bc2dba7a47553d702", "parents": [ "e98d5b16cf4df992c40a7c83f1eae61db5bb03da" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:57 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:57 2013 -0700" }, "message": "workqueue: introduce kmem_cache for pool_workqueues\n\npool_workqueues need to be aligned to 1 \u003c\u003c WORK_STRUCT_FLAG_BITS as\nthe lower bits of work-\u003edata are used for flags when they\u0027re pointing\nto pool_workqueues.\n\nDue to historical reasons, unbound pool_workqueues are allocated using\nkzalloc() with sufficient buffer area for alignment and aligned\nmanually. The original pointer is stored at the end which free_pwqs()\nretrieves when freeing it.\n\nThere\u0027s no reason for this hackery anymore. Set alignment of struct\npool_workqueue to 1 \u003c\u003c WORK_STRUCT_FLAG_BITS, add kmem_cache for\npool_workqueues with proper alignment and replace the hacky alloc and\nfree implementation with plain kmem_cache_zalloc/free().\n\nIn case WORK_STRUCT_FLAG_BITS gets shrunk too much and makes fields of\npool_workqueues misaligned, trigger WARN if the alignment of struct\npool_workqueue becomes smaller than that of long long.\n\nNote that assertion on IS_ALIGNED() is removed from alloc_pwqs(). We\nalready have another one in pwq init loop in __alloc_workqueue_key().\n\nThis patch doesn\u0027t introduce any visible behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "e98d5b16cf4df992c40a7c83f1eae61db5bb03da", "tree": "57bb6a301fde2b7e5a8bf8f2a8198e3b344acdd2", "parents": [ "6183c009f6cd94b42e5812adcfd4ba6220a196e1" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:57 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:57 2013 -0700" }, "message": "workqueue: make workqueue_lock irq-safe\n\nworkqueue_lock will be used to synchronize areas which require\nirq-safety and there isn\u0027t much benefit in keeping it not irq-safe.\nMake it irq-safe.\n\nThis patch doesn\u0027t introduce any visible behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "6183c009f6cd94b42e5812adcfd4ba6220a196e1", "tree": "a0df8377ea42816c541a45fce4a1700f3cb342c1", "parents": [ "b31041042a8cdece67f925e4bae55b5f5fd754ca" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:57 2013 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 12 11:29:57 2013 -0700" }, "message": "workqueue: make sanity checks less punshing using WARN_ON[_ONCE]()s\n\nWorkqueue has been using mostly BUG_ON()s for sanity checks, which\nfail unnecessarily harshly when the assertion doesn\u0027t hold. Most\nassertions can converted to be less drastic such that things can limp\nalong instead of dying completely. Convert BUG_ON()s to\nWARN_ON[_ONCE]()s with softer failure behaviors - e.g. if assertion\ncheck fails in destroy_worker(), trigger WARN and silently ignore\ndestruction request.\n\nMost conversions are trivial. Note that sanity checks in\ndestroy_workqueue() are moved above removal from workqueues list so\nthat it can bail out without side-effects if assertion checks fail.\n\nThis patch doesn\u0027t introduce any visible behavior changes during\nnormal operation.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "b31041042a8cdece67f925e4bae55b5f5fd754ca", "tree": "6392271c537c05d59e0d72ac72463343d2a29249", "parents": [ "f36dc67b27a689eeb3631b11ebef17bbff257fbb" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Tue Feb 19 12:17:02 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 04 09:44:58 2013 -0800" }, "message": "workqueue: better define synchronization rule around rescuer-\u003epool updates\n\nRescuers visit different worker_pools to process work items from pools\nunder pressure. Currently, rescuer-\u003epool is updated outside any\nlocking and when an outsider looks at a rescuer, there\u0027s no way to\ntell when and whether rescuer-\u003epool is gonna change. While this\ndoesn\u0027t currently cause any problem, it is nasty.\n\nWith recent worker_maybe_bind_and_lock() changes, we can move\nrescuer-\u003epool updates inside pool locks such that if rescuer-\u003epool\nequals a locked pool, it\u0027s guaranteed to stay that way until the pool\nis unlocked.\n\nMove rescuer-\u003epool inside pool-\u003elock.\n\nThis patch doesn\u0027t introduce any visible behavior difference.\n\ntj: Updated the description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "f36dc67b27a689eeb3631b11ebef17bbff257fbb", "tree": "d93c4310742fae4633af6ebddf53fe649ca4965d", "parents": [ "f5faa0774e07eada85b0c55ec789b3f337d01412" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Tue Feb 19 12:17:02 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 04 09:44:58 2013 -0800" }, "message": "workqueue: change argument of worker_maybe_bind_and_lock() to @pool\n\nworker_maybe_bind_and_lock() currently takes @worker but only cares\nabout @worker-\u003epool. This patch updates worker_maybe_bind_and_lock()\nto take @pool instead of @worker. This will be used to better define\nsynchronization rules regarding rescuer-\u003epool updates.\n\nThis doesn\u0027t introduce any functional change.\n\ntj: Updated the comments and description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "f5faa0774e07eada85b0c55ec789b3f337d01412", "tree": "439566bd5b8d0187d380b950ef386c349448aca9", "parents": [ "45d9550a0e7e9230606ca3c4c6f4dc6297848b2f" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Tue Feb 19 12:17:02 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 04 09:44:58 2013 -0800" }, "message": "workqueue: use %current instead of worker-\u003etask in worker_maybe_bind_and_lock()\n\nworker_maybe_bind_and_lock() uses both @worker-\u003etask and @current at\nthe same time. As worker_maybe_bind_and_lock() can only be called by\nthe current worker task, they are always the same.\n\nUpdate worker_maybe_bind_and_lock() to use %current consistently.\n\nThis doesn\u0027t introduce any functional change.\n\ntj: Massaged the description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "b67bfe0d42cac56c512dd5da4b1b347a23f4b70a", "tree": "3d465aea12b97683f26ffa38eba8744469de9997", "parents": [ "1e142b29e210b5dfb2deeb6ce2210b60af16d2a6" ], "author": { "name": "Sasha Levin", "email": "sasha.levin@oracle.com", "time": "Wed Feb 27 17:06:00 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Feb 27 19:10:24 2013 -0800" }, "message": "hlist: drop the node parameter from iterators\n\nI\u0027m not sure why, but the hlist for each entry iterators were conceived\n\n list_for_each_entry(pos, head, member)\n\nThe hlist ones were greedy and wanted an extra parameter:\n\n hlist_for_each_entry(tpos, pos, head, member)\n\nWhy did they need an extra pos parameter? I\u0027m not quite sure. Not only\nthey don\u0027t really need it, it also prevents the iterator from looking\nexactly like the list iterator, which is unfortunate.\n\nBesides the semantic patch, there was some manual work required:\n\n - Fix up the actual hlist iterators in linux/list.h\n - Fix up the declaration of other iterators based on the hlist ones.\n - A very small amount of places were using the \u0027node\u0027 parameter, this\n was modified to use \u0027obj-\u003emember\u0027 instead.\n - Coccinelle didn\u0027t handle the hlist_for_each_entry_safe iterator\n properly, so those had to be fixed up manually.\n\nThe semantic patch which is mostly the work of Peter Senna Tschudin is here:\n\n@@\niterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;\n\ntype T;\nexpression a,c,d,e;\nidentifier b;\nstatement S;\n@@\n\n-T b;\n \u003c+... when !\u003d b\n(\nhlist_for_each_entry(a,\n- b,\nc, d) S\n|\nhlist_for_each_entry_continue(a,\n- b,\nc) S\n|\nhlist_for_each_entry_from(a,\n- b,\nc) S\n|\nhlist_for_each_entry_rcu(a,\n- b,\nc, d) S\n|\nhlist_for_each_entry_rcu_bh(a,\n- b,\nc, d) S\n|\nhlist_for_each_entry_continue_rcu_bh(a,\n- b,\nc) S\n|\nfor_each_busy_worker(a, c,\n- b,\nd) S\n|\nax25_uid_for_each(a,\n- b,\nc) S\n|\nax25_for_each(a,\n- b,\nc) S\n|\ninet_bind_bucket_for_each(a,\n- b,\nc) S\n|\nsctp_for_each_hentry(a,\n- b,\nc) S\n|\nsk_for_each(a,\n- b,\nc) S\n|\nsk_for_each_rcu(a,\n- b,\nc) S\n|\nsk_for_each_from\n-(a, b)\n+(a)\nS\n+ sk_for_each_from(a) S\n|\nsk_for_each_safe(a,\n- b,\nc, d) S\n|\nsk_for_each_bound(a,\n- b,\nc) S\n|\nhlist_for_each_entry_safe(a,\n- b,\nc, d, e) S\n|\nhlist_for_each_entry_continue_rcu(a,\n- b,\nc) S\n|\nnr_neigh_for_each(a,\n- b,\nc) S\n|\nnr_neigh_for_each_safe(a,\n- b,\nc, d) S\n|\nnr_node_for_each(a,\n- b,\nc) S\n|\nnr_node_for_each_safe(a,\n- b,\nc, d) S\n|\n- for_each_gfn_sp(a, c, d, b) S\n+ for_each_gfn_sp(a, c, d) S\n|\n- for_each_gfn_indirect_valid_sp(a, c, d, b) S\n+ for_each_gfn_indirect_valid_sp(a, c, d) S\n|\nfor_each_host(a,\n- b,\nc) S\n|\nfor_each_host_safe(a,\n- b,\nc, d) S\n|\nfor_each_mesh_entry(a,\n- b,\nc, d) S\n)\n ...+\u003e\n\n[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]\n[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]\n[akpm@linux-foundation.org: checkpatch fixes]\n[akpm@linux-foundation.org: fix warnings]\n[akpm@linux-foudnation.org: redo intrusive kvm changes]\nTested-by: Peter Senna Tschudin \u003cpeter.senna@gmail.com\u003e\nAcked-by: Paul E. McKenney \u003cpaulmck@linux.vnet.ibm.com\u003e\nSigned-off-by: Sasha Levin \u003csasha.levin@oracle.com\u003e\nCc: Wu Fengguang \u003cfengguang.wu@intel.com\u003e\nCc: Marcelo Tosatti \u003cmtosatti@redhat.com\u003e\nCc: Gleb Natapov \u003cgleb@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1438ade5670b56d5386c220e1ad4b5a824a1e585", "tree": "3642109a131da8a00a39c409d746618b2c6db797", "parents": [ "112202d9098aae2c36436e5178c0cf3ced423c7b" ], "author": { "name": "Konstantin Khlebnikov", "email": "khlebnikov@openvz.org", "time": "Thu Jan 24 16:36:31 2013 +0400" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Feb 19 10:09:13 2013 -0800" }, "message": "workqueue: un-GPL function delayed_work_timer_fn()\n\ncommit d8e794dfd51c368ed3f686b7f4172830b60ae47b (\"workqueue: set\ndelayed_work-\u003etimer function on initialization\") exports function\ndelayed_work_timer_fn() only for GPL modules. This makes delayed-works\nunusable for non-GPL modules, because initialization macro now requires\nGPL symbol. For example schedule_delayed_work() available for non-GPL.\n\nSigned-off-by: Konstantin Khlebnikov \u003ckhlebnikov@openvz.org\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: stable@vger.kernel.org # 3.7\n" }, { "commit": "112202d9098aae2c36436e5178c0cf3ced423c7b", "tree": "2297f17b2ba0c556173566560f33fe7a1b20a904", "parents": [ "8d03ecfe471802d6afe97da97722b6924533aa82" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 13 19:29:12 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 13 19:29:12 2013 -0800" }, "message": "workqueue: rename cpu_workqueue to pool_workqueue\n\nworkqueue has moved away from global_cwqs to worker_pools and with the\nscheduled custom worker pools, wforkqueues will be associated with\npools which don\u0027t have anything to do with CPUs. The workqueue code\nwent through significant amount of changes recently and mass renaming\nisn\u0027t likely to hurt much additionally. Let\u0027s replace \u0027cpu\u0027 with\n\u0027pool\u0027 so that it reflects the current design.\n\n* s/struct cpu_workqueue_struct/struct pool_workqueue/\n* s/cpu_wq/pool_wq/\n* s/cwq/pwq/\n\nThis patch is purely cosmetic.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "8d03ecfe471802d6afe97da97722b6924533aa82", "tree": "1178cacfdd36358665f9a4c6325329346b221dd0", "parents": [ "1dd638149f1f9d7d7dbb32591d5c7c2a0ea36264" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 13 19:29:10 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 13 19:29:10 2013 -0800" }, "message": "workqueue: reimplement is_chained_work() using current_wq_worker()\n\nis_chained_work() was added before current_wq_worker() and implemented\nits own ham-fisted way of finding out whether %current is a workqueue\nworker - it iterates through all possible workers.\n\nDrop the custom implementation and reimplement using\ncurrent_wq_worker().\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "1dd638149f1f9d7d7dbb32591d5c7c2a0ea36264", "tree": "454399689b5d5016eefbd9f12e39b2674a8ebb33", "parents": [ "8594fade39d3ad02ef856b8c53b5d7cc538a55f5" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 13 19:29:07 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 13 19:29:07 2013 -0800" }, "message": "workqueue: fix is_chained_work() regression\n\nc9e7cf273f (\"workqueue: move busy_hash from global_cwq to\nworker_pool\") incorrectly converted is_chained_work() to use\nget_gcwq() inside for_each_gcwq_cpu() while removing get_gcwq().\n\nAs cwq might not exist for all possible workqueue CPUs, @cwq can be\nNULL and the following cwq deferences can lead to oops.\n\nFix it by using for_each_cwq_cpu() instead, which is the better one to\nuse anyway as we only need to check pools that the wq is associated\nwith.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "8594fade39d3ad02ef856b8c53b5d7cc538a55f5", "tree": "7f14598186e3fbc5feb91b1c25905b51d106a104", "parents": [ "54d5b7d079dffa74597715a892473b474babd5b5" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Thu Feb 07 13:14:20 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Feb 07 13:17:51 2013 -0800" }, "message": "workqueue: pick cwq instead of pool in __queue_work()\n\nCurrently, __queue_work() chooses the pool to queue a work item to and\nthen determines cwq from the target wq and the chosen pool. This is a\nbit backwards in that we can determine cwq first and simply use\ncwq-\u003epool. This way, we can skip get_std_worker_pool() in queueing\npath which will be a hurdle when implementing custom worker pools.\n\nUpdate __queue_work() such that it chooses the target cwq and then use\ncwq-\u003epool instead of the other way around. While at it, add missing\n{} in an if statement.\n\nThis patch doesn\u0027t introduce any functional changes.\n\ntj: The original patch had two get_cwq() calls - the first to\n determine the pool by doing get_cwq(cpu, wq)-\u003epool and the second\n to determine the matching cwq from get_cwq(pool-\u003ecpu, wq).\n Updated the function such that it chooses cwq instead of pool and\n removed the second call. Rewrote the description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "54d5b7d079dffa74597715a892473b474babd5b5", "tree": "33aa61fc2a98acff099a2393665318328448e137", "parents": [ "e19e397a85f33100bfa4210e256bec82fe22e167" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Thu Feb 07 13:14:20 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Feb 07 13:14:20 2013 -0800" }, "message": "workqueue: make get_work_pool_id() cheaper\n\nget_work_pool_id() currently first obtains pool using get_work_pool()\nand then return pool-\u003eid. For an off-queue work item, this involves\nobtaining pool ID from worker-\u003edata, performing idr_find() to find the\nmatching pool and then returning its pool-\u003eid which of course is the\nsame as the one which went into idr_find().\n\nJust open code WORK_STRUCT_CWQ case and directly return pool ID from\nwork-\u003edata.\n\ntj: The original patch dropped on-queue work item handling and renamed\n the function to offq_work_pool_id(). There isn\u0027t much benefit in\n doing so. Handling it only requires a single if() and we need at\n least BUG_ON(), which is also a branch, even if we drop on-queue\n handling. Open code WORK_STRUCT_CWQ case and keep the function in\n line with get_work_pool(). Rewrote the description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "e19e397a85f33100bfa4210e256bec82fe22e167", "tree": "18b9b0f883561584027a0085586d4f31abcba213", "parents": [ "1606283622689bdc460052b4a1281c36de13fe49" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:39:44 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Feb 07 13:14:20 2013 -0800" }, "message": "workqueue: move nr_running into worker_pool\n\nAs nr_running is likely to be accessed from other CPUs during\ntry_to_wake_up(), it was kept outside worker_pool; however, while less\nfrequent, other fields in worker_pool are accessed from other CPUs\nfor, e.g., non-reentrancy check. Also, with recent pool related\nchanges, accessing nr_running matching the worker_pool isn\u0027t as simple\nas it used to be.\n\nMove nr_running inside worker_pool. Keep it aligned to cacheline and\ndefine CPU pools using DEFINE_PER_CPU_SHARED_ALIGNED(). This should\ngive at least the same cacheline behavior.\n\nget_pool_nr_running() is replaced with direct pool-\u003enr_running\naccesses.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Joonsoo Kim \u003cjs1304@gmail.com\u003e\n" }, { "commit": "1606283622689bdc460052b4a1281c36de13fe49", "tree": "7e23128500a97cd006a9580e96583e681e0084a1", "parents": [ "0b3dae68ac199fac224fea9a31907b44f0d257b3" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "message": "workqueue: cosmetic update in try_to_grab_pending()\n\nWith the recent is-work-queued-here test simplification, the nested\nif() in try_to_grab_pending() can be collapsed. Collapse it.\n\nThis patch is purely cosmetic.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "0b3dae68ac199fac224fea9a31907b44f0d257b3", "tree": "909b0b1d33123c9e8cbd0117e5f42df12e3becde", "parents": [ "4468a00fd9a274fe1b30c886370d662e4a439efb" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "message": "workqueue: simplify is-work-item-queued-here test\n\nCurrently, determining whether a work item is queued on a locked pool\ninvolves somewhat convoluted memory barrier dancing. It goes like the\nfollowing.\n\n* When a work item is queued on a pool, work-\u003edata is updated before\n work-\u003eentry is linked to the pending list with a wmb() inbetween.\n\n* When trying to determine whether a work item is currently queued on\n a pool pointed to by work-\u003edata, it locks the pool and looks at\n work-\u003eentry. If work-\u003eentry is linked, we then do rmb() and then\n check whether work-\u003edata points to the current pool.\n\nThis works because, work-\u003edata can only point to a pool if it\ncurrently is or were on the pool and,\n\n* If it currently is on the pool, the tests would obviously succeed.\n\n* It it left the pool, its work-\u003eentry was cleared under pool-\u003elock,\n so if we\u0027re seeing non-empty work-\u003eentry, it has to be from the work\n item being linked on another pool. Because work-\u003edata is updated\n before work-\u003eentry is linked with wmb() inbetween, work-\u003edata update\n from another pool is guaranteed to be visible if we do rmb() after\n seeing non-empty work-\u003eentry. So, we either see empty work-\u003eentry\n or we see updated work-\u003edata pointin to another pool.\n\nWhile this works, it\u0027s convoluted, to put it mildly. With recent\nupdates, it\u0027s now guaranteed that work-\u003edata points to cwq only while\nthe work item is queued and that updating work-\u003edata to point to cwq\nor back to pool is done under pool-\u003elock, so we can simply test\nwhether work-\u003edata points to cwq which is associated with the\ncurrently locked pool instead of the convoluted memory barrier\ndancing.\n\nThis patch replaces the memory barrier based \"are you still here,\nreally?\" test with much simpler \"does work-\u003edata points to me?\" test -\nif work-\u003edata points to a cwq which is associated with the currently\nlocked pool, the work item is guaranteed to be queued on the pool as\nwork-\u003edata can start and stop pointing to such cwq only under\npool-\u003elock and the start and stop coincide with queue and dequeue.\n\ntj: Rewrote the comments and description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "4468a00fd9a274fe1b30c886370d662e4a439efb", "tree": "6ead9c97eea5cdb16cfd7fca3b80d1b184949e3e", "parents": [ "60c057bca22285efefbba033624763a778f243bf" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "message": "workqueue: make work-\u003edata point to pool after try_to_grab_pending()\n\nWe plan to use work-\u003edata pointing to cwq as the synchronization\ninvariant when determining whether a given work item is on a locked\npool or not, which requires work-\u003edata pointing to cwq only while the\nwork item is queued on the associated pool.\n\nWith delayed_work updated not to overload work-\u003edata for target\nworkqueue recording, the only case where we still have off-queue\nwork-\u003edata pointing to cwq is try_to_grab_pending() which doesn\u0027t\nupdate work-\u003edata after stealing a queued work item. There\u0027s no\nreason for try_to_grab_pending() to not update work-\u003edata to point to\nthe pool instead of cwq, like the normal execution does.\n\nThis patch adds set_work_pool_and_keep_pending() which makes\nwork-\u003edata point to pool instead of cwq but keeps the pending bit\nunlike set_work_pool_and_clear_pending() (surprise!).\n\nAfter this patch, it\u0027s guaranteed that only queued work items point to\ncwqs.\n\nThis patch doesn\u0027t introduce any visible behavior change.\n\ntj: Renamed the new helper function to match\n set_work_pool_and_clear_pending() and rewrote the description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "60c057bca22285efefbba033624763a778f243bf", "tree": "8e469c390b5b60ad6b4d7c94bc07522f857032bc", "parents": [ "038366c5cf23ae737b9f72169dd8ade2d105755b" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "message": "workqueue: add delayed_work-\u003ewq to simplify reentrancy handling\n\nTo avoid executing the same work item from multiple CPUs concurrently,\na work_struct records the last pool it was on in its -\u003edata so that,\non the next queueing, the pool can be queried to determine whether the\nwork item is still executing or not.\n\nA delayed_work goes through timer before actually being queued on the\ntarget workqueue and the timer needs to know the target workqueue and\nCPU. This is currently achieved by modifying delayed_work-\u003ework.data\nsuch that it points to the cwq which points to the target workqueue\nand the last CPU the work item was on. __queue_delayed_work()\nextracts the last CPU from delayed_work-\u003ework.data and then combines\nit with the target workqueue to create new work.data.\n\nThe only thing this rather ugly hack achieves is encoding the target\nworkqueue into delayed_work-\u003ework.data without using a separate field,\nwhich could be a trade off one can make; unfortunately, this entangles\nwork-\u003edata management between regular workqueue and delayed_work code\nby setting cwq pointer before the work item is actually queued and\nbecomes a hindrance for further improvements of work-\u003edata handling.\n\nThis can be easily made sane by adding a target workqueue field to\ndelayed_work. While delayed_work is used widely in the kernel and\nthis does make it a bit larger (\u003c5%), I think this is the right\ntrade-off especially given the prospect of much saner handling of\nwork-\u003edata which currently involves quite tricky memory barrier\ndancing, and don\u0027t expect to see any measureable effect.\n\nAdd delayed_work-\u003ewq and drop the delayed_work-\u003ework.data overloading.\n\ntj: Rewrote the description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "038366c5cf23ae737b9f72169dd8ade2d105755b", "tree": "7119031b23ba32e02b3fc8621cc8666b41f95f8a", "parents": [ "6be195886ac26abe0194ed1bc7a9224f8a97c310" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "message": "workqueue: make work_busy() test WORK_STRUCT_PENDING first\n\nCurrently, work_busy() first tests whether the work has a pool\nassociated with it and if not, considers it idle. This works fine\neven for delayed_work.work queued on timer, as __queue_delayed_work()\nsets cwq on delayed_work.work - a queued delayed_work always has its\ncwq and thus pool associated with it.\n\nHowever, we\u0027re about to update delayed_work queueing and this won\u0027t\nhold. Update work_busy() such that it tests WORK_STRUCT_PENDING\nbefore the associated pool. This doesn\u0027t make any noticeable behavior\ndifference now.\n\nWith work_pending() test moved, the function read a lot better with\n\"if (!pool)\" test flipped to positive. Flip it.\n\nWhile at it, lose the comment about now non-existent reentrant\nworkqueues.\n\ntj: Reorganized the function and rewrote the description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "6be195886ac26abe0194ed1bc7a9224f8a97c310", "tree": "a414324b9232efaa2fd8f1dc4a28d308aa5d99f5", "parents": [ "706026c2141113886f61e1ad2738c9a7723ec69c" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Feb 06 18:04:53 2013 -0800" }, "message": "workqueue: replace WORK_CPU_NONE/LAST with WORK_CPU_END\n\nNow that workqueue has moved away from gcwqs, workqueue no longer has\nthe need to have a CPU identifier indicating \"no cpu associated\" - we\nnow use WORK_OFFQ_POOL_NONE instead - and most uses of WORK_CPU_NONE\nare gone.\n\nThe only left usage is as the end marker for for_each_*wq*()\niterators, where the name WORK_CPU_NONE is confusing w/o actual\nWORK_CPU_NONE usages. Similarly, WORK_CPU_LAST which equals\nWORK_CPU_NONE no longer makes sense.\n\nReplace both WORK_CPU_NONE and LAST with WORK_CPU_END. This patch\ndoesn\u0027t introduce any functional difference.\n\ntj: s/WORK_CPU_LAST/WORK_CPU_END/ and rewrote the description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "706026c2141113886f61e1ad2738c9a7723ec69c", "tree": "c61ffa31567cf6b7536a3209503d498f22c6ace6", "parents": [ "e6e380ed92555533740d5f670640f6f1868132de" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:34 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:34 2013 -0800" }, "message": "workqueue: post global_cwq removal cleanups\n\nRemove remaining references to gcwq.\n\n* __next_gcwq_cpu() steals __next_wq_cpu() name. The original\n __next_wq_cpu() became __next_cwq_cpu().\n\n* s/for_each_gcwq_cpu/for_each_wq_cpu/\n s/for_each_online_gcwq_cpu/for_each_online_wq_cpu/\n\n* s/gcwq_mayday_timeout/pool_mayday_timeout/\n\n* s/gcwq_unbind_fn/wq_unbind_fn/\n\n* Drop references to gcwq in comments.\n\nThis patch doesn\u0027t introduce any functional changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "e6e380ed92555533740d5f670640f6f1868132de", "tree": "fd24f4293e1c6fa9ab728c59ddc25d26146fd98e", "parents": [ "a60dc39c016a65bfdbd05c43b3707962d5ed04c7" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:34 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:34 2013 -0800" }, "message": "workqueue: rename nr_running variables\n\nRename per-cpu and unbound nr_running variables such that they match\nthe pool variables.\n\nThis patch doesn\u0027t introduce any functional changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "a60dc39c016a65bfdbd05c43b3707962d5ed04c7", "tree": "c16982dba52f5f83dc09817c37e86ec201f84c03", "parents": [ "4e8f0a609677a25f504527e50981df146c5b3d08" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:34 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:34 2013 -0800" }, "message": "workqueue: remove global_cwq\n\nglobal_cwq is now nothing but a container for per-cpu standard\nworker_pools. Declare the worker pools directly as\ncpu/unbound_std_worker_pools[] and remove global_cwq.\n\n* ____cacheline_aligned_in_smp moved from global_cwq to worker_pool.\n This probably would have made sense even before this change as we\n want each pool to be aligned.\n\n* get_gcwq() is replaced with std_worker_pools() which returns the\n pointer to the standard pool array for a given CPU.\n\n* __alloc_workqueue_key() updated to use get_std_worker_pool() instead\n of open-coding pool determination.\n\nThis is part of an effort to remove global_cwq and make worker_pool\nthe top level abstraction, which in turn will help implementing worker\npools with user-specified attributes.\n\nv2: Joonsoo pointed out that it\u0027d better to align struct worker_pool\n rather than the array so that every pool is aligned.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nCc: Joonsoo Kim \u003cjs1304@gmail.com\u003e\n" }, { "commit": "4e8f0a609677a25f504527e50981df146c5b3d08", "tree": "e8fc37f309cf58c18bc2d0f0dfc00ccbadda7f4d", "parents": [ "38db41d984f17938631420ff78160dda7f182d24" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:34 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:34 2013 -0800" }, "message": "workqueue: remove worker_pool-\u003egcwq\n\nThe only remaining user of pool-\u003egcwq is std_worker_pool_pri().\nReimplement it using get_gcwq() and remove worker_pool-\u003egcwq.\n\nThis is part of an effort to remove global_cwq and make worker_pool\nthe top level abstraction, which in turn will help implementing worker\npools with user-specified attributes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "38db41d984f17938631420ff78160dda7f182d24", "tree": "4591d50ecb7fe9749dc5d48b735d3f43aa0b80a7", "parents": [ "a1056305fa98c7e13b38718658a8b07a5d926460" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:34 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:34 2013 -0800" }, "message": "workqueue: replace for_each_worker_pool() with for_each_std_worker_pool()\n\nfor_each_std_worker_pool() takes @cpu instead of @gcwq.\n\nThis is part of an effort to remove global_cwq and make worker_pool\nthe top level abstraction, which in turn will help implementing worker\npools with user-specified attributes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "a1056305fa98c7e13b38718658a8b07a5d926460", "tree": "d20ce512fdd0e3f07d972d62ecc9cb357c3db69e", "parents": [ "94cf58bb2907bd2702fce2266955e29ab5261f53" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "message": "workqueue: make freezing/thawing per-pool\n\nInstead of holding locks from both pools and then processing the pools\ntogether, make freezing/thwaing per-pool - grab locks of one pool,\nprocess it, release it and then proceed to the next pool.\n\nWhile this patch changes processing order across pools, order within\neach pool remains the same. As each pool is independent, this\nshouldn\u0027t break anything.\n\nThis is part of an effort to remove global_cwq and make worker_pool\nthe top level abstraction, which in turn will help implementing worker\npools with user-specified attributes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "94cf58bb2907bd2702fce2266955e29ab5261f53", "tree": "32b7998f475bf41754c74e9e55c45213263c89df", "parents": [ "d565ed6309300304de4a865a04adef07a85edc45" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "message": "workqueue: make hotplug processing per-pool\n\nInstead of holding locks from both pools and then processing the pools\ntogether, make hotplug processing per-pool - grab locks of one pool,\nprocess it, release it and then proceed to the next pool.\n\nrebind_workers() is updated to take and process @pool instead of @gcwq\nwhich results in a lot of de-indentation. gcwq_claim_assoc_and_lock()\nand its counterpart are replaced with in-line per-pool locking.\n\nWhile this patch changes processing order across pools, order within\neach pool remains the same. As each pool is independent, this\nshouldn\u0027t break anything.\n\nThis is part of an effort to remove global_cwq and make worker_pool\nthe top level abstraction, which in turn will help implementing worker\npools with user-specified attributes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "d565ed6309300304de4a865a04adef07a85edc45", "tree": "b79e83064232d5bbf47550b090d6b1e288e123fb", "parents": [ "ec22ca5eab0bd225588c69ccd06b16504cb05adf" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "message": "workqueue: move global_cwq-\u003elock to worker_pool\n\nMove gcwq-\u003elock to pool-\u003elock. The conversion is mostly\nstraight-forward. Things worth noting are\n\n* In many places, this removes the need to use gcwq completely. pool\n is used directly instead. get_std_worker_pool() is added to help\n some of these conversions. This also leaves get_work_gcwq() without\n any user. Removed.\n\n* In hotplug and freezer paths, the pools belonging to a CPU are often\n processed together. This patch makes those paths hold locks of all\n pools, with highpri lock nested inside, to keep the conversion\n straight-forward. These nested lockings will be removed by\n following patches.\n\nThis is part of an effort to remove global_cwq and make worker_pool\nthe top level abstraction, which in turn will help implementing worker\npools with user-specified attributes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "ec22ca5eab0bd225588c69ccd06b16504cb05adf", "tree": "3282a2b587235879c3f2d286896a003900ab6563", "parents": [ "c9e7cf273fa1876dee8effdb201a6f65eefab3a7" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "message": "workqueue: move global_cwq-\u003ecpu to worker_pool\n\nMove gcwq-\u003ecpu to pool-\u003ecpu. This introduces a couple places where\ngcwq-\u003epools[0].cpu is used. These will soon go away as gcwq is\nfurther reduced.\n\nThis is part of an effort to remove global_cwq and make worker_pool\nthe top level abstraction, which in turn will help implementing worker\npools with user-specified attributes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "c9e7cf273fa1876dee8effdb201a6f65eefab3a7", "tree": "fab0d36f4cd595d1d4bc9fb091d323ea66a692e1", "parents": [ "7c3eed5cd60d0f736516e6ade77d90c6255860bd" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "message": "workqueue: move busy_hash from global_cwq to worker_pool\n\nThere\u0027s no functional necessity for the two pools on the same CPU to\nshare the busy hash table. It\u0027s also likely to be a bottleneck when\nimplementing pools with user-specified attributes.\n\nThis patch makes busy_hash per-pool. The conversion is mostly\nstraight-forward. Changes worth noting are,\n\n* Large block of changes in rebind_workers() is moving the block\n inside for_each_worker_pool() as now there are separate hash tables\n for each pool. This changes the order of operations but doesn\u0027t\n break anything.\n\n* Thre for_each_worker_pool() loops in gcwq_unbind_fn() are combined\n into one. This again changes the order of operaitons but doesn\u0027t\n break anything.\n\nThis is part of an effort to remove global_cwq and make worker_pool\nthe top level abstraction, which in turn will help implementing worker\npools with user-specified attributes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "7c3eed5cd60d0f736516e6ade77d90c6255860bd", "tree": "bfc017307b98a4db8c919ba9fb53399189ecf0ad", "parents": [ "9daf9e678d18585433a4ad90ec51a448e5fd054c" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "message": "workqueue: record pool ID instead of CPU in work-\u003edata when off-queue\n\nCurrently, when a work item is off-queue, work-\u003edata records the CPU\nit was last on, which is used to locate the last executing instance\nfor non-reentrance, flushing, etc.\n\nWe\u0027re in the process of removing global_cwq and making worker_pool the\ntop level abstraction. This patch makes work-\u003edata point to the pool\nit was last associated with instead of CPU.\n\nAfter the previous WORK_OFFQ_POOL_CPU and worker_poo-\u003eid additions,\nthe conversion is fairly straight-forward. WORK_OFFQ constants and\nfunctions are modified to record and read back pool ID instead.\nworker_pool_by_id() is added to allow looking up pool from ID.\nget_work_pool() replaces get_work_gcwq(), which is reimplemented using\nget_work_pool(). get_work_pool_id() replaces work_cpu().\n\nThis patch shouldn\u0027t introduce any observable behavior changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "9daf9e678d18585433a4ad90ec51a448e5fd054c", "tree": "e21d85aa3280cabe420c8c8c992f59e11b4aab82", "parents": [ "715b06b864c99a18cb8368dfb187da4f569788cd" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "message": "workqueue: add worker_pool-\u003eid\n\nAdd worker_pool-\u003eid which is allocated from worker_pool_idr. This\nwill be used to record the last associated worker_pool in work-\u003edata.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "715b06b864c99a18cb8368dfb187da4f569788cd", "tree": "599ab1152a1c93b83d1be05aaeb370cac2e7e3eb", "parents": [ "35b6bb63b8a288f90e07948867941a553b3d97bc" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "message": "workqueue: introduce WORK_OFFQ_CPU_NONE\n\nCurrently, when a work item is off queue, high bits of its data\nencodes the last CPU it was on. This is scheduled to be changed to\npool ID, which will make it impossible to use WORK_CPU_NONE to\nindicate no association.\n\nThis patch limits the number of bits which are used for off-queue cpu\nnumber to 31 (so that the max fits in an int) and uses the highest\npossible value - WORK_OFFQ_CPU_NONE - to indicate no association.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "35b6bb63b8a288f90e07948867941a553b3d97bc", "tree": "275528f970a80c9bf403a66450808a006db65ba8", "parents": [ "2464757086b4de0591738d5e30f069d068d70ec0" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "message": "workqueue: make GCWQ_FREEZING a pool flag\n\nMake GCWQ_FREEZING a pool flag POOL_FREEZING. This patch doesn\u0027t\nchange locking - FREEZING on both pools of a CPU are set or clear\ntogether while holding gcwq-\u003elock. It shouldn\u0027t cause any functional\ndifference.\n\nThis leaves gcwq-\u003eflags w/o any flags. Removed.\n\nWhile at it, convert BUG_ON()s in freeze_workqueue_begin() and\nthaw_workqueues() to WARN_ON_ONCE().\n\nThis is part of an effort to remove global_cwq and make worker_pool\nthe top level abstraction, which in turn will help implementing worker\npools with user-specified attributes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "2464757086b4de0591738d5e30f069d068d70ec0", "tree": "2e7994351d92c24fc20fdb38108a64342bef0daf", "parents": [ "e34cdddb03bdfe98f20c58934fd4c45019f13ae5" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "message": "workqueue: make GCWQ_DISASSOCIATED a pool flag\n\nMake GCWQ_DISASSOCIATED a pool flag POOL_DISASSOCIATED. This patch\ndoesn\u0027t change locking - DISASSOCIATED on both pools of a CPU are set\nor clear together while holding gcwq-\u003elock. It shouldn\u0027t cause any\nfunctional difference.\n\nThis is part of an effort to remove global_cwq and make worker_pool\nthe top level abstraction, which in turn will help implementing worker\npools with user-specified attributes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "e34cdddb03bdfe98f20c58934fd4c45019f13ae5", "tree": "3c98a24a407e1f2794e06a48961a2b9da8e208ae", "parents": [ "e2905b29122173b72b612c962b138e3fa07476b8" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:33 2013 -0800" }, "message": "workqueue: use std_ prefix for the standard per-cpu pools\n\nThere are currently two worker pools per cpu (including the unbound\ncpu) and they are the only pools in use. New class of pools are\nscheduled to be added and some pool related APIs will be added\ninbetween. Call the existing pools the standard pools and prefix them\nwith std_. Do this early so that new APIs can use std_ prefix from\nthe beginning.\n\nThis patch doesn\u0027t introduce any functional difference.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "e2905b29122173b72b612c962b138e3fa07476b8", "tree": "66d7a8545f1fda113962c4a817673ff5b453c336", "parents": [ "84b233adcca3cacd5cfa8013a5feda7a3db4a9af" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:32 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 24 11:01:32 2013 -0800" }, "message": "workqueue: unexport work_cpu()\n\nThis function no longer has any external users. Unexport it. It will\nbe removed later on.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\n" }, { "commit": "2eaebdb33e1911c0cf3d44fd3596c42c6f502fab", "tree": "240924aae7c1ce31dc850a290ef53e268f071ebd", "parents": [ "ea138446e51f7bfe55cdeffa3f1dd9cafc786bd8" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Jan 18 14:05:55 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Jan 18 14:05:55 2013 -0800" }, "message": "workqueue: move struct worker definition to workqueue_internal.h\n\nThis will be used to implement an inline function to query whether\n%current is a workqueue worker and, if so, allow determining which\nwork item it\u0027s executing.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ea138446e51f7bfe55cdeffa3f1dd9cafc786bd8", "tree": "a441a0546a062817946eb1c28f7d2f9cdaf6062a", "parents": [ "111c225a5f8d872bc9327ada18d13b75edaa34be" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Jan 18 14:05:55 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Jan 18 14:05:55 2013 -0800" }, "message": "workqueue: rename kernel/workqueue_sched.h to kernel/workqueue_internal.h\n\nWorkqueue wants to expose more interface internal to kernel/. Instead\nof adding a new header file, repurpose kernel/workqueue_sched.h.\nRename it to workqueue_internal.h and add include protector.\n\nThis patch doesn\u0027t introduce any functional changes.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\nCc: Ingo Molnar \u003cmingo@redhat.com\u003e\nCc: Peter Zijlstra \u003cpeterz@infradead.org\u003e\n" }, { "commit": "111c225a5f8d872bc9327ada18d13b75edaa34be", "tree": "8bb9e31b8345f67c50f5370e6ba03f613afd5b65", "parents": [ "023f27d3d6fcc9048754d879fe5e7d63402a5b16" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 17 17:16:24 2013 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Jan 17 17:19:58 2013 -0800" }, "message": "workqueue: set PF_WQ_WORKER on rescuers\n\nPF_WQ_WORKER is used to tell scheduler that the task is a workqueue\nworker and needs wq_worker_sleeping/waking_up() invoked on it for\nconcurrency management. As rescuers never participate in concurrency\nmanagement, PF_WQ_WORKER wasn\u0027t set on them.\n\nThere\u0027s a need for an interface which can query whether %current is\nexecuting a work item and if so which. Such interface requires a way\nto identify all tasks which may execute work items and PF_WQ_WORKER\nwill be used for that. As all normal workers always have PF_WQ_WORKER\nset, we only need to add it to rescuers.\n\nAs rescuers start with WORKER_PREP but never clear it, it\u0027s always\nNOT_RUNNING and there\u0027s no need to worry about it interfering with\nconcurrency management even if PF_WQ_WORKER is set; however, unlike\nnormal workers, rescuers currently don\u0027t have its worker struct as\nkthread_data(). It uses the associated workqueue_struct instead.\nThis is problematic as wq_worker_sleeping/waking_up() expect struct\nworker at kthread_data().\n\nThis patch adds worker-\u003erescue_wq and start rescuer kthreads with\nworker struct as kthread_data and sets PF_WQ_WORKER on rescuers.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "023f27d3d6fcc9048754d879fe5e7d63402a5b16", "tree": "0836e744e107c7506dee26ef87257d7951341441", "parents": [ "a2c1c57be8d9fd5b716113c8991d3d702eeacf77" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Dec 19 11:24:06 2012 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Dec 19 11:24:06 2012 -0800" }, "message": "workqueue: fix find_worker_executing_work() brekage from hashtable conversion\n\n42f8570f43 (\"workqueue: use new hashtable implementation\") incorrectly\nmade busy workers hashed by the pointer value of worker instead of\nwork. This broke find_worker_executing_work() which in turn broke a\nlot of fundamental operations of workqueue - non-reentrancy and\nflushing among others. The flush malfunction triggered warning in\ndisk event code in Fengguang\u0027s automated test.\n\n write_dev_root_ (3265) used greatest stack depth: 2704 bytes left\n ------------[ cut here ]------------\n WARNING: at /c/kernel-tests/src/stable/block/genhd.c:1574 disk_clear_events+0x\\\ncf/0x108()\n Hardware name: Bochs\n Modules linked in:\n Pid: 3328, comm: ata_id Not tainted 3.7.0-01930-gbff6343 #1167\n Call Trace:\n [\u003cffffffff810997c4\u003e] warn_slowpath_common+0x83/0x9c\n [\u003cffffffff810997f7\u003e] warn_slowpath_null+0x1a/0x1c\n [\u003cffffffff816aea77\u003e] disk_clear_events+0xcf/0x108\n [\u003cffffffff811bd8be\u003e] check_disk_change+0x27/0x59\n [\u003cffffffff822e48e2\u003e] cdrom_open+0x49/0x68b\n [\u003cffffffff81ab0291\u003e] idecd_open+0x88/0xb7\n [\u003cffffffff811be58f\u003e] __blkdev_get+0x102/0x3ec\n [\u003cffffffff811bea08\u003e] blkdev_get+0x18f/0x30f\n [\u003cffffffff811bebfd\u003e] blkdev_open+0x75/0x80\n [\u003cffffffff8118f510\u003e] do_dentry_open+0x1ea/0x295\n [\u003cffffffff8118f5f0\u003e] finish_open+0x35/0x41\n [\u003cffffffff8119c720\u003e] do_last+0x878/0xa25\n [\u003cffffffff8119c993\u003e] path_openat+0xc6/0x333\n [\u003cffffffff8119cf37\u003e] do_filp_open+0x38/0x86\n [\u003cffffffff81190170\u003e] do_sys_open+0x6c/0xf9\n [\u003cffffffff8119021e\u003e] sys_open+0x21/0x23\n [\u003cffffffff82c1c3d9\u003e] system_call_fastpath+0x16/0x1b\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReported-by: Fengguang Wu \u003cfengguang.wu@intel.com\u003e\nCc: Sasha Levin \u003csasha.levin@oracle.com\u003e\n" }, { "commit": "a2c1c57be8d9fd5b716113c8991d3d702eeacf77", "tree": "dd275d53f76528c37e4f8f71fbfd4e2e9954f70b", "parents": [ "42f8570f437b65aaf3ef176a38ad7d7fc5847d8b" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Dec 18 10:35:02 2012 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Dec 18 10:56:14 2012 -0800" }, "message": "workqueue: consider work function when searching for busy work items\n\nTo avoid executing the same work item concurrenlty, workqueue hashes\ncurrently busy workers according to their current work items and looks\nup the the table when it wants to execute a new work item. If there\nalready is a worker which is executing the new work item, the new item\nis queued to the found worker so that it gets executed only after the\ncurrent execution finishes.\n\nUnfortunately, a work item may be freed while being executed and thus\nrecycled for different purposes. If it gets recycled for a different\nwork item and queued while the previous execution is still in\nprogress, workqueue may make the new work item wait for the old one\nalthough the two aren\u0027t really related in any way.\n\nIn extreme cases, this false dependency may lead to deadlock although\nit\u0027s extremely unlikely given that there aren\u0027t too many self-freeing\nwork item users and they usually don\u0027t wait for other work items.\n\nTo alleviate the problem, record the current work function in each\nbusy worker and match it together with the work item address in\nfind_worker_executing_work(). While this isn\u0027t complete, it ensures\nthat unrelated work items don\u0027t interact with each other and in the\nvery unlikely case where a twisted wq user triggers it, it\u0027s always\nonto itself making the culprit easy to spot.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReported-by: Andrey Isakov \u003candy51@gmx.ru\u003e\nBugzilla: https://bugzilla.kernel.org/show_bug.cgi?id\u003d51701\nCc: stable@vger.kernel.org\n" }, { "commit": "42f8570f437b65aaf3ef176a38ad7d7fc5847d8b", "tree": "be5eee8505b195f952afb4d5a7655142a9de1b12", "parents": [ "848b81415c42ff3dc9a4204749087b015c37ef66" ], "author": { "name": "Sasha Levin", "email": "sasha.levin@oracle.com", "time": "Mon Dec 17 10:01:23 2012 -0500" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Dec 18 09:21:13 2012 -0800" }, "message": "workqueue: use new hashtable implementation\n\nSwitch workqueues to use the new hashtable implementation. This reduces the\namount of generic unrelated code in the workqueues.\n\nThis patch depends on d9b482c (\"hashtable: introduce a small and naive\nhashtable\") which was merged in v3.6.\n\nAcked-by: Tejun Heo \u003ctj@kernel.org\u003e\nSigned-off-by: Sasha Levin \u003csasha.levin@oracle.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "e7b55b8fcd3a32ba1f95ccd95fb9a11ccfa63563", "tree": "04d6191dcc1110074c48d569747e3ac94b595f45", "parents": [ "50851c6248e1a13c45d97c41f6ebcf716093aa5e", "3657600040a7279e52252af3f9d7e253f4f49ef0" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Dec 12 08:15:13 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Dec 12 08:15:13 2012 -0800" }, "message": "Merge branch \u0027for-3.8\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq\n\nPull workqueue changes from Tejun Heo:\n \"Nothing exciting. Just two trivial changes.\"\n\n* \u0027for-3.8\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq:\n workqueue: add WARN_ON_ONCE() on CPU number to wq_worker_waking_up()\n workqueue: trivial fix for return statement in work_busy()\n" }, { "commit": "fc4b514f2727f74a4587c31db87e0e93465518c3", "tree": "83c8758213d3492b4c48541c8a3782bdd47adf99", "parents": [ "c1d390d8e6128b050f0f66b1c33d390760deb3f4" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Dec 04 07:40:39 2012 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Dec 04 07:58:47 2012 -0800" }, "message": "workqueue: convert BUG_ON()s in __queue_delayed_work() to WARN_ON_ONCE()s\n\n8852aac25e (\"workqueue: mod_delayed_work_on() shouldn\u0027t queue timer on\n0 delay\") unexpectedly uncovered a very nasty abuse of delayed_work in\nmegaraid - it allocated work_struct, casted it to delayed_work and\nthen pass that into queue_delayed_work().\n\nPreviously, this was okay because 0 @delay short-circuited to\nqueue_work() before doing anything with delayed_work. 8852aac25e\nmoved 0 @delay test into __queue_delayed_work() after sanity check on\ndelayed_work making megaraid trigger BUG_ON().\n\nAlthough megaraid is already fixed by c1d390d8e6 (\"megaraid: fix\nBUG_ON() from incorrect use of delayed work\"), this patch converts\nBUG_ON()s in __queue_delayed_work() to WARN_ON_ONCE()s so that such\nabusers, if there are more, trigger warning but don\u0027t crash the\nmachine.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Xiaotian Feng \u003cxtfeng@gmail.com\u003e\n" }, { "commit": "3657600040a7279e52252af3f9d7e253f4f49ef0", "tree": "1cc95124c9108e24ee18a7d9af2e511fd735daae", "parents": [ "999767beb1b4a10eabf90e6017e496536cf4db0b" ], "author": { "name": "Joonsoo Kim", "email": "js1304@gmail.com", "time": "Fri Oct 26 23:03:49 2012 +0900" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sat Dec 01 16:45:45 2012 -0800" }, "message": "workqueue: add WARN_ON_ONCE() on CPU number to wq_worker_waking_up()\n\nRecently, workqueue code has gone through some changes and we found\nsome bugs related to concurrency management operations happening on\nthe wrong CPU. When a worker is concurrency managed\n(!WORKER_NOT_RUNNIG), it should be bound to its associated cpu and\nwoken up to that cpu. Add WARN_ON_ONCE() to verify this.\n\nSigned-off-by: Joonsoo Kim \u003cjs1304@gmail.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "999767beb1b4a10eabf90e6017e496536cf4db0b", "tree": "52025d802a2d350e42b0857502cb1ac7b473f31b", "parents": [ "8852aac25e79e38cc6529f20298eed154f60b574" ], "author": { "name": "Joonsoo Kim", "email": "js1304@gmail.com", "time": "Sun Oct 21 01:30:06 2012 +0900" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sat Dec 01 16:45:40 2012 -0800" }, "message": "workqueue: trivial fix for return statement in work_busy()\n\nReturn type of work_busy() is unsigned int.\nThere is return statement returning boolean value, \u0027false\u0027 in work_busy().\nIt is not problem, because \u0027false\u0027 may be treated \u00270\u0027.\nHowever, fixing it would make code robust.\n\nSigned-off-by: Joonsoo Kim \u003cjs1304@gmail.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "8852aac25e79e38cc6529f20298eed154f60b574", "tree": "dba9304157032b33339db9c8165b3d4a5a2d05b0", "parents": [ "412d32e6c98527078779e5b515823b2810e40324" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sat Dec 01 16:23:42 2012 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sat Dec 01 16:43:18 2012 -0800" }, "message": "workqueue: mod_delayed_work_on() shouldn\u0027t queue timer on 0 delay\n\n8376fe22c7 (\"workqueue: implement mod_delayed_work[_on]()\")\nimplemented mod_delayed_work[_on]() using the improved\ntry_to_grab_pending(). The function is later used, among others, to\nreplace [__]candel_delayed_work() + queue_delayed_work() combinations.\n\nUnfortunately, a delayed_work item w/ zero @delay is handled slightly\ndifferently by mod_delayed_work_on() compared to\nqueue_delayed_work_on(). The latter skips timer altogether and\ndirectly queues it using queue_work_on() while the former schedules\ntimer which will expire on the closest tick. This means, when @delay\nis zero, that [__]cancel_delayed_work() + queue_delayed_work_on()\nmakes the target item immediately executable while\nmod_delayed_work_on() may induce delay of upto a full tick.\n\nThis somewhat subtle difference breaks some of the converted users.\ne.g. block queue plugging uses delayed_work for deferred processing\nand uses mod_delayed_work_on() when the queue needs to be immediately\nunplugged. The above problem manifested as noticeably higher number\nof context switches under certain circumstances.\n\nThe difference in behavior was caused by missing special case handling\nfor 0 delay in mod_delayed_work_on() compared to\nqueue_delayed_work_on(). Joonsoo Kim posted a patch to add it -\n(\"workqueue: optimize mod_delayed_work_on() when @delay \u003d\u003d 0\")[1].\nThe patch was queued for 3.8 but it was described as optimization and\nI missed that it was a correctness issue.\n\nAs both queue_delayed_work_on() and mod_delayed_work_on() use\n__queue_delayed_work() for queueing, it seems that the better approach\nis to move the 0 delay special handling to the function instead of\nduplicating it in mod_delayed_work_on().\n\nFix the problem by moving 0 delay special case handling from\nqueue_delayed_work_on() to __queue_delayed_work(). This replaces\nJoonsoo\u0027s patch.\n\n[1] http://thread.gmane.org/gmane.linux.kernel/1379011/focus\u003d1379012\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReported-and-tested-by: Anders Kaseorg \u003candersk@MIT.EDU\u003e\nReported-and-tested-by: Zlatko Calusic \u003czlatko.calusic@iskon.hr\u003e\nLKML-Reference: \u003calpine.DEB.2.00.1211280953350.26602@dr-wily.mit.edu\u003e\nLKML-Reference: \u003c50A78AA9.5040904@iskon.hr\u003e\nCc: Joonsoo Kim \u003cjs1304@gmail.com\u003e\n" }, { "commit": "412d32e6c98527078779e5b515823b2810e40324", "tree": "0221e047afeb05d753d29821a457eef9dbe917d7", "parents": [ "b3c3a9cf2a28ee4a8d0b62e2e58c61e9ca9bb47b" ], "author": { "name": "Mike Galbraith", "email": "mgalbraith@suse.de", "time": "Wed Nov 28 07:17:18 2012 +0100" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sat Dec 01 15:56:42 2012 -0800" }, "message": "workqueue: exit rescuer_thread() as TASK_RUNNING\n\nA rescue thread exiting TASK_INTERRUPTIBLE can lead to a task scheduling\noff, never to be seen again. In the case where this occurred, an exiting\nthread hit reiserfs homebrew conditional resched while holding a mutex,\nbringing the box to its knees.\n\nPID: 18105 TASK: ffff8807fd412180 CPU: 5 COMMAND: \"kdmflush\"\n #0 [ffff8808157e7670] schedule at ffffffff8143f489\n #1 [ffff8808157e77b8] reiserfs_get_block at ffffffffa038ab2d [reiserfs]\n #2 [ffff8808157e79a8] __block_write_begin at ffffffff8117fb14\n #3 [ffff8808157e7a98] reiserfs_write_begin at ffffffffa0388695 [reiserfs]\n #4 [ffff8808157e7ad8] generic_perform_write at ffffffff810ee9e2\n #5 [ffff8808157e7b58] generic_file_buffered_write at ffffffff810eeb41\n #6 [ffff8808157e7ba8] __generic_file_aio_write at ffffffff810f1a3a\n #7 [ffff8808157e7c58] generic_file_aio_write at ffffffff810f1c88\n #8 [ffff8808157e7cc8] do_sync_write at ffffffff8114f850\n #9 [ffff8808157e7dd8] do_acct_process at ffffffff810a268f\n [exception RIP: kernel_thread_helper]\n RIP: ffffffff8144a5c0 RSP: ffff8808157e7f58 RFLAGS: 00000202\n RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000\n RDX: 0000000000000000 RSI: ffffffff8107af60 RDI: ffff8803ee491d18\n RBP: 0000000000000000 R8: 0000000000000000 R9: 0000000000000000\n R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000\n R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000\n ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018\n\nSigned-off-by: Mike Galbraith \u003cmgalbraith@suse.de\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: stable@vger.kernel.org\n" }, { "commit": "c0158ca64da5732dfb86a3f28944e9626776692f", "tree": "2ce9ff8057b9273905424b2932b35a080cfdbf38", "parents": [ "ddffeb8c4d0331609ef2581d84de4d763607bd37" ], "author": { "name": "Dan Magenheimer", "email": "dan.magenheimer@oracle.com", "time": "Thu Oct 18 16:31:37 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Oct 24 12:38:16 2012 -0700" }, "message": "workqueue: cancel_delayed_work() should return %false if work item is idle\n\n57b30ae77b (\"workqueue: reimplement cancel_delayed_work() using\ntry_to_grab_pending()\") made cancel_delayed_work() always return %true\nunless someone else is also trying to cancel the work item, which is\nbroken - if the target work item is idle, the return value should be\n%false.\n\ntry_to_grab_pending() indicates that the target work item was idle by\nzero return value. Use it for return. Note that this brings\ncancel_delayed_work() in line with __cancel_work_timer() in return\nvalue handling.\n\nSigned-off-by: Dan Magenheimer \u003cdan.magenheimer@oracle.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nLKML-Reference: \u003c444a6439-b1a4-4740-9e7e-bc37267cfe73@default\u003e\n" }, { "commit": "033d9959ed2dc1029217d4165f80a71702dc578e", "tree": "3d306316e44bdabce2e0bf2ef7e466e525f90b4c", "parents": [ "974a847e00cf3ff1695e62b276892137893706ab", "7c6e72e46c9ea4a88f3f8ba96edce9db4bd48726" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 02 09:54:49 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 02 09:54:49 2012 -0700" }, "message": "Merge branch \u0027for-3.7\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq\n\nPull workqueue changes from Tejun Heo:\n \"This is workqueue updates for v3.7-rc1. A lot of activities this\n round including considerable API and behavior cleanups.\n\n * delayed_work combines a timer and a work item. The handling of the\n timer part has always been a bit clunky leading to confusing\n cancelation API with weird corner-case behaviors. delayed_work is\n updated to use new IRQ safe timer and cancelation now works as\n expected.\n\n * Another deficiency of delayed_work was lack of the counterpart of\n mod_timer() which led to cancel+queue combinations or open-coded\n timer+work usages. mod_delayed_work[_on]() are added.\n\n These two delayed_work changes make delayed_work provide interface\n and behave like timer which is executed with process context.\n\n * A work item could be executed concurrently on multiple CPUs, which\n is rather unintuitive and made flush_work() behavior confusing and\n half-broken under certain circumstances. This problem doesn\u0027t\n exist for non-reentrant workqueues. While non-reentrancy check\n isn\u0027t free, the overhead is incurred only when a work item bounces\n across different CPUs and even in simulated pathological scenario\n the overhead isn\u0027t too high.\n\n All workqueues are made non-reentrant. This removes the\n distinction between flush_[delayed_]work() and\n flush_[delayed_]_work_sync(). The former is now as strong as the\n latter and the specified work item is guaranteed to have finished\n execution of any previous queueing on return.\n\n * In addition to the various bug fixes, Lai redid and simplified CPU\n hotplug handling significantly.\n\n * Joonsoo introduced system_highpri_wq and used it during CPU\n hotplug.\n\n There are two merge commits - one to pull in IRQ safe timer from\n tip/timers/core and the other to pull in CPU hotplug fixes from\n wq/for-3.6-fixes as Lai\u0027s hotplug restructuring depended on them.\"\n\nFixed a number of trivial conflicts, but the more interesting conflicts\nwere silent ones where the deprecated interfaces had been used by new\ncode in the merge window, and thus didn\u0027t cause any real data conflicts.\n\nTejun pointed out a few of them, I fixed a couple more.\n\n* \u0027for-3.7\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq: (46 commits)\n workqueue: remove spurious WARN_ON_ONCE(in_irq()) from try_to_grab_pending()\n workqueue: use cwq_set_max_active() helper for workqueue_set_max_active()\n workqueue: introduce cwq_set_max_active() helper for thaw_workqueues()\n workqueue: remove @delayed from cwq_dec_nr_in_flight()\n workqueue: fix possible stall on try_to_grab_pending() of a delayed work item\n workqueue: use hotcpu_notifier() for workqueue_cpu_down_callback()\n workqueue: use __cpuinit instead of __devinit for cpu callbacks\n workqueue: rename manager_mutex to assoc_mutex\n workqueue: WORKER_REBIND is no longer necessary for idle rebinding\n workqueue: WORKER_REBIND is no longer necessary for busy rebinding\n workqueue: reimplement idle worker rebinding\n workqueue: deprecate __cancel_delayed_work()\n workqueue: reimplement cancel_delayed_work() using try_to_grab_pending()\n workqueue: use mod_delayed_work() instead of __cancel + queue\n workqueue: use irqsafe timer for delayed_work\n workqueue: clean up delayed_work initializers and add missing one\n workqueue: make deferrable delayed_work initializer names consistent\n workqueue: cosmetic whitespace updates for macro definitions\n workqueue: deprecate system_nrt[_freezable]_wq\n workqueue: deprecate flush[_delayed]_work_sync()\n ...\n" }, { "commit": "7c6e72e46c9ea4a88f3f8ba96edce9db4bd48726", "tree": "05f92ef6f69cfa5f0aac1401c4ca4d4fdc2a7ab7", "parents": [ "70369b117a8fc5ac18a635ced23ee49f8e722e7b" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Sep 20 10:03:19 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Sep 20 10:03:19 2012 -0700" }, "message": "workqueue: remove spurious WARN_ON_ONCE(in_irq()) from try_to_grab_pending()\n\ne0aecdd874 (\"workqueue: use irqsafe timer for delayed_work\") made\ntry_to_grab_pending() safe to use from irq context but forgot to\nremove WARN_ON_ONCE(in_irq()). Remove it.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReported-by: Fengguang Wu \u003cfengguang.wu@intel.com\u003e\n" }, { "commit": "70369b117a8fc5ac18a635ced23ee49f8e722e7b", "tree": "deec5ade1639ccebe8db218e5b8a5632d86317ac", "parents": [ "9f4bd4cddbb50d7617353102e10ce511c5ef6df2" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Wed Sep 19 10:40:48 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Sep 19 10:40:48 2012 -0700" }, "message": "workqueue: use cwq_set_max_active() helper for workqueue_set_max_active()\n\nworkqueue_set_max_active() may increase -\u003emax_active without\nactivating delayed works and may make the activation order differ from\nthe queueing order. Both aren\u0027t strictly bugs but the resulting\nbehavior could be a bit odd.\n\nTo make things more consistent, use cwq_set_max_active() helper which\nimmediately makes use of the newly increased max_mactive if there are\ndelayed work items and also keeps the activation order.\n\ntj: Slight update to description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "9f4bd4cddbb50d7617353102e10ce511c5ef6df2", "tree": "2f204e107cb878fcc4c0152fe167133570376cc9", "parents": [ "b3f9f405a21a29c06c31fb2d6ab36ef9ba7c027b" ], "author": { "name": "Lai Jiangshan", "email": "laijs@cn.fujitsu.com", "time": "Wed Sep 19 10:40:48 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Sep 19 10:40:48 2012 -0700" }, "message": "workqueue: introduce cwq_set_max_active() helper for thaw_workqueues()\n\nUsing a helper instead of open code makes thaw_workqueues() clearer.\nThe helper will also be used by the next patch.\n\ntj: Slight update to comment and description.\n\nSigned-off-by: Lai Jiangshan \u003claijs@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" } ], "next": "ed48ece27cd3d5ee0354c32bbaec0f3e1d4715c3" }