)]}' { "log": [ { "commit": "a6aae4dd0ffad299a33d122f8a339b399bee5381", "tree": "958b015be27d97d079a3c14694576571ca916600", "parents": [ "f70b7e52aa23c9aea5346b9730b402fb55f9079b" ], "author": { "name": "Artem Bityutskiy", "email": "artem.bityutskiy@linux.intel.com", "time": "Wed May 16 20:11:23 2012 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "artem.bityutskiy@linux.intel.com", "time": "Wed May 16 20:11:23 2012 +0300" }, "message": "UBIFS: get rid of dbg_err\n\nThis patch removes the \u0027dbg_err()\u0027 macro and we now use \u0027ubifs_err()\u0027 instead.\nThe idea of \u0027dbg_err()\u0027 was to compile out some error message to make the\nbinary a bit smaller - but I think it was a bad idea.\n\nSigned-off-by: Artem Bityutskiy \u003cartem.bityutskiy@linux.intel.com\u003e\n" }, { "commit": "f70b7e52aa23c9aea5346b9730b402fb55f9079b", "tree": "20882b6e8345b8836d395248fd7f31fce7d09236", "parents": [ "1baafd28dc17422f10be9b2a3a75432154e3abc7" ], "author": { "name": "Artem Bityutskiy", "email": "artem.bityutskiy@linux.intel.com", "time": "Wed May 16 19:53:46 2012 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "artem.bityutskiy@linux.intel.com", "time": "Wed May 16 19:53:46 2012 +0300" }, "message": "UBIFS: remove Kconfig debugging option\n\nHave the debugging stuff always compiled-in instead. It simplifies maintanance\na lot.\n\nSigned-off-by: Artem Bityutskiy \u003cartem.bityutskiy@linux.intel.com\u003e\n" }, { "commit": "edf6be245fd34a4438646375cecb11f5feb92646", "tree": "ca1ddfc1900d5875d5434c6c7f39ca4966ef3baa", "parents": [ "7c46d0ae29ba880963db283706950de7aa86c0a0" ], "author": { "name": "Artem Bityutskiy", "email": "artem.bityutskiy@linux.intel.com", "time": "Wed May 16 19:15:56 2012 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "artem.bityutskiy@linux.intel.com", "time": "Wed May 16 19:15:56 2012 +0300" }, "message": "UBIFS: rename dumping functions\n\nThis commit re-names all functions which dump something from \"dbg_dump_*()\" to\n\"ubifs_dump_*()\". This is done for consistency with UBI and because this way it\nwill be more logical once we remove the debugging sompilation option.\n\nSigned-off-by: Artem Bityutskiy \u003cartem.bityutskiy@linux.intel.com\u003e\n" }, { "commit": "8d7819b4af697eec45339cc24db7c3fe45fea0e7", "tree": "2a32526fbf5a4cac8a3056352efcd6b69c4785b6", "parents": [ "2b1844a8c934723134ee1ff313e51d0d281cdef1" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Fri Jun 03 08:53:35 2011 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "dedekind1@gmail.com", "time": "Mon Jul 04 10:54:28 2011 +0300" }, "message": "UBIFS: lessen amount of debugging check types\n\nWe have too many different debugging checks - lessen the amount by merging all\nindex-related checks into one. At the same time, move the \"force in-the-gap\"\ntest to the \"index checks\" class, because it is too heavy for the \"general\"\nclass.\n\nThis patch merges TNC, Old index, and Index size check and calles this just\n\"index checks\".\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "2b1844a8c934723134ee1ff313e51d0d281cdef1", "tree": "1c490adba95a54eb14f9b00890ce9b09050358f7", "parents": [ "d808efb407e1a2cf83a8d21411157195f26bdef9" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Fri Jun 03 08:31:29 2011 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "dedekind1@gmail.com", "time": "Mon Jul 04 10:54:28 2011 +0300" }, "message": "UBIFS: introduce helper functions for debugging checks and tests\n\nThis patch introduces helper functions for all debugging checks, so instead of\ndoing\n\nif (!(ubifs_chk_flags \u0026 UBIFS_CHK_GEN))\n\nwe now do\n\nif (!dbg_is_chk_gen(c))\n\nThis is a preparation to further changes where the flags will go away, and\nwe\u0027ll need to only change the helper functions, but the code which utilizes\nthem won\u0027t be touched.\n\nAt the same time this patch removes \u0027dbg_force_in_the_gaps()\u0027,\n\u0027dbg_force_in_the_gaps_enabled()\u0027, and dbg_failure_mode helpers for\nconsistency.\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "f42eed7cba7f83197b0ffbb023e7d89a0b2fd71d", "tree": "b5590faffe190cd1401945e13c66684bec2f5b48", "parents": [ "1f42596ec0a7d3d50a494d95e3f1afbd117250f8" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Mon May 30 14:45:30 2011 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "dedekind1@gmail.com", "time": "Mon Jul 04 10:54:27 2011 +0300" }, "message": "UBIFS: harmonize znode flag helpers\n\nWe have 3 znode flags: cow, obsolete, dirty. For the last flag we have a\n\u0027ubifs_zn_dirty()\u0027 helper function, but for the other 2 flags we use\n\u0027test_bit()\u0027 directly.\n\nThis patch makes the situation more consistent and introduces helpers for the\nother 2 flags: \u0027ubifs_zn_cow()\u0027 and \u0027ubifs_zn_obsolete()\u0027.\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "549c999a768a7a144c60a0faa58f34c48f39112b", "tree": "c1bdefb19fafb74164331c21ebaee7b2a987441c", "parents": [ "b0af8dfdd67699e25083478c63eedef2e72ebd85" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Thu May 26 16:57:14 2011 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "dedekind1@gmail.com", "time": "Mon Jul 04 10:54:26 2011 +0300" }, "message": "UBIFS: return EROFS in case of broken commit\n\nIf commit failed and it is in broken state, UBIFS switches to R/O mode. Most\noperations return -EROFS in this case, except of commit which returns -EINVAL.\nMake it return -EROFS too for consistency. This is also important for our power\ncut emulation testing.\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "b137545c44fc0c80fb778abb0c582bda5601e8f8", "tree": "fb3da759a3c64587bee8bacf408cf774adb8b09a", "parents": [ "cc64f774b4acd4954abe54f5919f50d78aba1e5f" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Tue Mar 29 18:04:05 2011 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Fri May 13 19:23:53 2011 +0300" }, "message": "UBIFS: introduce a separate structure for budgeting info\n\nThis patch separates out all the budgeting-related information\nfrom \u0027struct ubifs_info\u0027 to \u0027struct ubifs_budg_info\u0027. This way the\ncode looks a bit cleaner. However, the main driver for this is\nthat we want to save budgeting information and print it later,\nso a separate data structure for this is helpful.\n\nThis patch is a preparation for the further debugging output\nimprovements.\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "8b229c76765816796eec7ccd428f03bd8de8b525", "tree": "fa8e30710d9365d0f26215d0027dd5408ee2d5fc", "parents": [ "0ce790e7d736cedc563e1fb4e998babf5a4dbc3d" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Fri Mar 25 18:33:57 2011 +0200" }, "committer": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Tue Apr 05 10:39:40 2011 +0300" }, "message": "UBIFS: do not read flash unnecessarily\n\nThis fix makes the \u0027dbg_check_old_index()\u0027 function return\nimmediately if debugging is disabled, instead of executing\nincorrect \u0027goto out\u0027 which causes UBIFS to:\n\n1. Allocate memory\n2. Read the flash\n\nOn every commit. OK, we do not commit that often, but it is\nstill silly to do unneeded I/O anyway.\n\nCredits to coverity for spotting this silly issue.\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\nCc: stable@kernel.org\n" }, { "commit": "944fdef52ca9fc0fe077578f51201ef397e30abe", "tree": "c24c589edf911fcb66b0b1968fe3b283193787ff", "parents": [ "18d1d7fbcc260e67d249bf90b454d8cf34288453" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Sun Jan 16 19:22:02 2011 +0200" }, "committer": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Tue Jan 25 10:21:13 2011 +0200" }, "message": "UBIFS: do not start the commit if there is nothing to commit\n\nThis patch fixes suboptimal UBIFS \u0027sync_fs()\u0027 implementation which causes\nflash I/O even if the file-system is synchronized. E.g., a \u0027printk()\u0027\nin the MTD erasure function (e.g., \u0027nand_erase_nand()\u0027) can show that\nfor every \u0027sync\u0027 shell command UBIFS erases at least one eraseblock.\n\nSo \u0027$ while true; do sync; done\u0027 will cause huge amount of flash I/O.\n\nThe reason for this is that UBIFS commits in \u0027sync_fs()\u0027, and starts the\ncommit even if there is nothing to commit, e.g., it anyway changes the\nlog. This patch adds a check in the \u0027do_commit()\u0027 UBIFS functions which\nprevents the commit if there is nothing to commit.\n\nReported-by: Hans J. Koch \u003chjk@linutronix.de\u003e\nTested-by: John Ogness \u003cjohn.ogness@linutronix.de\u003e\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "2ef13294d29bcfb306e0d360f1b97f37b647b0c0", "tree": "877e1ece00c14de0f0d79e86b6480d284d309216", "parents": [ "2680d722bf2c5f75225dd9acb3ec9e5a9e2652f4" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Sun Sep 19 18:34:26 2010 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Sun Sep 19 21:07:58 2010 +0300" }, "message": "UBIFS: introduce new flags for RO mounts\n\nCommit 2fde99cb55fb9d9b88180512a5e8a5d939d27fec \"UBIFS: mark VFS SB RO too\"\nintroduced regression. This commit made UBIFS set the \u0027MS_RDONLY\u0027 flag in the\nVFS superblock when it switches to R/O mode due to an error. This was done\nto make VFS show the R/O UBIFS flag in /proc/mounts.\n\nHowever, several places in UBIFS relied on the \u0027MS_RDONLY\u0027 flag and assume this\nflag can only change when we re-mount. For example, \u0027ubifs_put_super()\u0027.\n\nThis patch introduces new UBIFS flag - \u0027c-\u003ero_mount\u0027 which changes only when\nwe re-mount, and preserves the way UBIFS was originally mounted (R/W or R/O).\nThis allows us to de-initialize UBIFS cleanly in \u0027ubifs_put_super()\u0027.\n\nThis patch also changes all \u0027ubifs_assert(!c-\u003ero_media)\u0027 assertions to\n\u0027ubifs_assert(!c-\u003ero_media \u0026\u0026 !c-\u003ero_mount)\u0027, because we never should write\nanything if the FS was mounter R/O.\n\nAll the places where we test for \u0027MS_RDONLY\u0027 flag in the VFS SB were changed\nand now we test the \u0027c-\u003ero_mount\u0027 flag instead, because it preserves the\noriginal UBIFS mount type, unlike the \u0027MS_RDONLY\u0027 flag.\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "2680d722bf2c5f75225dd9acb3ec9e5a9e2652f4", "tree": "af016ede5f300a33ddd3ad66a8c3c0e6bf05774e", "parents": [ "8c893a5545ca772744376295690723dcb0b47d96" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Fri Sep 17 16:44:28 2010 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Fri Sep 17 17:08:09 2010 +0300" }, "message": "UBIFS: introduce new flag for RO due to errors\n\nThe R/O state may have various reasons:\n\n1. The UBI volume is R/O\n2. The FS is mounted R/O\n3. The FS switched to R/O mode because of an error\n\nHowever, in UBIFS we have only one variable which represents cases\n1 and 3 - \u0027c-\u003ero_media\u0027. Indeed, we set this to 1 if we switch to\nR/O mode due to an error, and then we test it in many places to\nmake sure that we stop writing as soon as the error happens.\n\nBut this is very unclean. One consequence of this, for example, is\nthat in \u0027ubifs_remount_fs()\u0027 we use \u0027c-\u003ero_media\u0027 to check whether\nwe are in R/O mode because on an error, and we print a message\nin this case. However, if we are in R/O mode because the media\nis R/O, our message is bogus.\n\nThis patch introduces new flag - \u0027c-\u003ero_error\u0027 which is set when\nwe switch to R/O mode because of an error. It also changes all\n\"if (c-\u003ero_media)\" checks to \"if (c-\u003ero_error)\" checks, because\nthis is what the checks actually mean. We do not need to check\nfor \u0027c-\u003ero_media\u0027 because if the UBI volume is in R/O mode, we\ndo not allow R/W mounting, and now writes can happen. This is\nguaranteed by VFS. But it is good to double-check this, so this\npatch also adds many \"ubifs_assert(!c-\u003ero_media)\" checks.\n\nIn the \u0027ubifs_remount_fs()\u0027 function this patch makes a bit more\nchanges - it fixes the error messages as well.\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "5a0e3ad6af8660be21ca98a971cd00f331318c05", "tree": "5bfb7be11a03176a87296a43ac6647975c00a1d1", "parents": [ "ed391f4ebf8f701d3566423ce8f17e614cde9806" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 24 17:04:11 2010 +0900" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 30 22:02:32 2010 +0900" }, "message": "include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h\n\npercpu.h is included by sched.h and module.h and thus ends up being\nincluded when building most .c files. percpu.h includes slab.h which\nin turn includes gfp.h making everything defined by the two files\nuniversally available and complicating inclusion dependencies.\n\npercpu.h -\u003e slab.h dependency is about to be removed. Prepare for\nthis change by updating users of gfp and slab facilities include those\nheaders directly instead of assuming availability. As this conversion\nneeds to touch large number of source files, the following script is\nused as the basis of conversion.\n\n http://userweb.kernel.org/~tj/misc/slabh-sweep.py\n\nThe script does the followings.\n\n* Scan files for gfp and slab usages and update includes such that\n only the necessary includes are there. ie. if only gfp is used,\n gfp.h, if slab is used, slab.h.\n\n* When the script inserts a new include, it looks at the include\n blocks and try to put the new include such that its order conforms\n to its surrounding. It\u0027s put in the include block which contains\n core kernel includes, in the same order that the rest are ordered -\n alphabetical, Christmas tree, rev-Xmas-tree or at the end if there\n doesn\u0027t seem to be any matching order.\n\n* If the script can\u0027t find a place to put a new include (mostly\n because the file doesn\u0027t have fitting include block), it prints out\n an error message indicating which .h file needs to be added to the\n file.\n\nThe conversion was done in the following steps.\n\n1. The initial automatic conversion of all .c files updated slightly\n over 4000 files, deleting around 700 includes and adding ~480 gfp.h\n and ~3000 slab.h inclusions. The script emitted errors for ~400\n files.\n\n2. Each error was manually checked. Some didn\u0027t need the inclusion,\n some needed manual addition while adding it to implementation .h or\n embedding .c file was more appropriate for others. This step added\n inclusions to around 150 files.\n\n3. The script was run again and the output was compared to the edits\n from #2 to make sure no file was left behind.\n\n4. Several build tests were done and a couple of problems were fixed.\n e.g. lib/decompress_*.c used malloc/free() wrappers around slab\n APIs requiring slab.h to be added manually.\n\n5. The script was run on all .h files but without automatically\n editing them as sprinkling gfp.h and slab.h inclusions around .h\n files could easily lead to inclusion dependency hell. Most gfp.h\n inclusion directives were ignored as stuff from gfp.h was usually\n wildly available and often used in preprocessor macros. Each\n slab.h inclusion directive was examined and added manually as\n necessary.\n\n6. percpu.h was updated not to include slab.h.\n\n7. Build test were done on the following configurations and failures\n were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my\n distributed build env didn\u0027t work with gcov compiles) and a few\n more options had to be turned off depending on archs to make things\n build (like ipr on powerpc/64 which failed due to missing writeq).\n\n * x86 and x86_64 UP and SMP allmodconfig and a custom test config.\n * powerpc and powerpc64 SMP allmodconfig\n * sparc and sparc64 SMP allmodconfig\n * ia64 SMP allmodconfig\n * s390 SMP allmodconfig\n * alpha SMP allmodconfig\n * um on x86_64 SMP allmodconfig\n\n8. percpu.h modifications were reverted so that it could be applied as\n a separate patch and serve as bisection point.\n\nGiven the fact that I had only a couple of failures from tests on step\n6, I\u0027m fairly confident about the coverage of this conversion patch.\nIf there is a breakage, it\u0027s likely to be something in one of the arch\nheaders which should be easily discoverable easily on most builds of\nthe specific arch.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nGuess-its-ok-by: Christoph Lameter \u003ccl@linux-foundation.org\u003e\nCc: Ingo Molnar \u003cmingo@redhat.com\u003e\nCc: Lee Schermerhorn \u003cLee.Schermerhorn@hp.com\u003e\n" }, { "commit": "83ef2ecdbbd49cb0fbbfc7012b111b71664e386d", "tree": "a45f4b7f106f36f766494126aea2b74fd4ddc32e", "parents": [ "4be3bd7849165e7efa6b0b35a23d6a3598d97465" ], "author": { "name": "Subrata Modak", "email": "subrata@linux.vnet.ibm.com", "time": "Wed Jul 15 07:49:03 2009 +0530" }, "committer": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Fri Jul 24 15:14:54 2009 +0300" }, "message": "UBIFS: suppress compilation warning\n\nFix \"using uninitialized variable\" compilation warning by using\nthe \"unititialized_var()\" helper.\n\nSigned-off-by: Subrata Modak\u003csubrata@linux.vnet.ibm.com\u003e\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "17c2f9f85c896b48a5d74a9155d99ec5b241a0e6", "tree": "9d3e38e673d1d3af650072388a671ec767d3941a", "parents": [ "5dd7cbc083f3a91fa7454125fe992826701b67bc" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Fri Oct 17 13:31:39 2008 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Wed Dec 03 13:14:33 2008 +0200" }, "message": "UBIFS: separate debugging fields out\n\nIntroduce a new data structure which contains all debugging\nstuff inside. This is cleaner than having debugging stuff\ndirectly in \u0027c\u0027.\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "069782a1ee55105220e5ae2db448495dac267cb1", "tree": "b25f2fadb18c795e04761d1a5c8bbdcba5589bcd", "parents": [ "45beca08dd8b6d6a65c5ffd730af2eac7a2c7a03" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Tue Oct 21 12:56:31 2008 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Thu Nov 06 11:06:14 2008 +0200" }, "message": "UBIFS: remove printk\n\nRemove the \"UBIFS background thread ubifs_bgd0_0 started\" message.\nWe kill the background thread when we switch to R/O mode, and\nstart it again whan we switch to R/W mode. OLPC is doing this\nmany times during boot, and we see this message many times as\nwell, which is irritating. So just kill the message.\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "014eb04b03202dc75c1c749df4246d98045f5e69", "tree": "99edd8f2907b478616bba8d44a308b6b750ead99", "parents": [ "fd6c6b51e3677937090314b20b00f2194900d81b" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Mon Jul 21 17:14:29 2008 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Wed Aug 13 11:27:47 2008 +0300" }, "message": "UBIFS: increment commit number earlier\n\nIncrement the commit number at the beginnig of the commit, instead\nof doing this after the commit. This is needed for further\noptimizations.\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\n" }, { "commit": "1e51764a3c2ac05a23a22b2a95ddee4d9bffb16d", "tree": "919debdd48aef9eee9ff0e8f465ef2649325b993", "parents": [ "e56a99d5a42dcb91e622ae7a0289d8fb2ddabffb" ], "author": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Mon Jul 14 19:08:37 2008 +0300" }, "committer": { "name": "Artem Bityutskiy", "email": "Artem.Bityutskiy@nokia.com", "time": "Tue Jul 15 17:35:15 2008 +0300" }, "message": "UBIFS: add new flash file system\n\nThis is a new flash file system. See\nhttp://www.linux-mtd.infradead.org/doc/ubifs.html\n\nSigned-off-by: Artem Bityutskiy \u003cArtem.Bityutskiy@nokia.com\u003e\nSigned-off-by: Adrian Hunter \u003cext-adrian.hunter@nokia.com\u003e\n" } ] }