)]}' { "log": [ { "commit": "c707a81de71a27a499fde60fbb963f60602c1a94", "tree": "38f6a128f256ba3d2e95b470e83d8ac88c60b2cb", "parents": [ "dcb6b45254e2281b6f99ea7f2d51343954aa3ba8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 08 16:00:43 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jul 09 10:33:25 2013 -0700" }, "message": "checkpatch: make the CamelCase cache work for non-git trees too\n\nMight as well check include timestamps and cache the include file\nCamelCase uses for the non-git case too.\n\nThe camelcase cache file is now named:\n\n for git: .checkpatch-camelcase.git.\u003ccommit_id\u003e\n for non-git: .checkpatch-camelcase.date.\u003cYYYYMMDDhhmm\u003e\n\nAll .checkpatch-camelcase* files are deleted if not current.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "351b2a1fe2d06f44b4c06d377744b2ac408b7407", "tree": "94566bc117b757bfab5c282d56c251121a7f33f9", "parents": [ "7d0b6594e1055e3d4efcc28af11a8e42dd85ded4" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:36 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: cache last camelcase hash as .checkpatch-camelcase.\u003ccommit\u003e\n\nAdd a file to cache the CamelCase variables found by \u003ccommit\u003e to reduce\nthe time it takes to scan the include/ directory.\n\nFilename is \u0027.checkpatch-camelcase.\u003ccommit\u003e\u0027 and it is created only only\nif a .git directory exists.\n\n\u003ccommit\u003e is determined by the last non-merge commit id in the\ninclude/ path.\n\nReduces checkpatch run time by ~12 cpu seconds on my little netbook.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7d0b6594e1055e3d4efcc28af11a8e42dd85ded4", "tree": "bedce15993d5f37ff1b7af79a5e1b4c1a58b9392", "parents": [ "3445686af721534ac1086a9c6d48b3470dfb6946" ], "author": { "name": "Jacob Keller", "email": "jacob.e.keller@intel.com", "time": "Wed Jul 03 15:05:35 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: allow longer logging function names\n\nThe current $logFunction regular expression allows names like dev_warn,\ne_dbg, netdev_info, etc, but some log functions are now written like\ne_dev_warn, so allow 1 or 2 word blocks with an underscore before the\nlogging level.\n\nSigned-off-by: Jacob Keller \u003cjacob.e.keller@intel.com\u003e\nTested-by: Aaron Brown \u003caaron.f.brown@intel.com\u003e\nSigned-off-by: Jeff Kirsher \u003cjeffrey.t.kirsher@intel.com\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3445686af721534ac1086a9c6d48b3470dfb6946", "tree": "d3b3ece795d3a83e19c8f9e788d3433d275b0bda", "parents": [ "22735ce857a2d9f4e6eec37c36be3fcf9d21d154" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:34 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: ignore existing CamelCase uses from include/...\n\nWhen using --strict, CamelCase uses are described with CHECK: messages.\nThese CamelCase uses may be acceptable and should not generate these\nmessages when the variable is already defined in a file from the\ninclude/... path.\n\nSo, change checkpatch to read all the .h files in include/... and look\nfor preexisting CamelCase #defines, typedefs and function prototypes.\n\nAdd these to the existing camelcase hash so that any uses in the patch or\nfile can be ignored.\n\nThere are currently ~3500 files in include/. It takes about 10 cpu\nseconds on my little netbook to grep for and preseed these existing uses.\n\nThat\u0027s about 4x the time for a similar git grep.\n\nThis preseeding is only done once when using --strict and only when there\nis a CamelCase use found.\n\nIf a .git directory is found, it uses \u0027git ls-files include\u0027 If not, it\nuses \u0027find $root/include -name \"*.h\"\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "22735ce857a2d9f4e6eec37c36be3fcf9d21d154", "tree": "ef64119a99ffce6a804a7ff2d9a0e316934b2654", "parents": [ "786b632622800d73d9b0355c9a79b3f3b5792c6c" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:33 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: ignore SI unit CamelCase variants like \"_uV\"\n\nMany existing variable names use SI like variants that should be otherwise\nobvious and acceptable.\n\nWhitelist them from the CamelCase message.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Phil Carmody \u003cphil.carmody@partner.samsung.com\u003e\nAcked-by: Phil Carmody \u003cphil.carmody@partner.samsung.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "786b632622800d73d9b0355c9a79b3f3b5792c6c", "tree": "e78b97a8730cbbe1c713a6ae4f1811ad78aab871", "parents": [ "3705ce5bcc1037b68e9d20f90ab50bc7f64edd00" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:32 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: move test for space before semicolon after operator spacing\n\nMoving this test allows the --fix option to work better.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3705ce5bcc1037b68e9d20f90ab50bc7f64edd00", "tree": "3f5f6e5a5a749c88418e114a34ee85b9c99fad28", "parents": [ "23f780c90496eb1cc158e862e7035c8468dfa052" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:31 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: create an EXPERIMENTAL --fix option to correct patches\n\nSome patches have simple defects in whitespace and formatting that\ncheckpatch could correct automatically. Attempt to do so.\n\nAdd a --fix option to create a \"\u003cinputfile\u003e.EXPERIMENTAL-checkpatch-fixes\"\nfile that tries to use normal kernel style for some of these formatting\nerrors.\n\nAdd warnings against using this file without verifying the changes.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "23f780c90496eb1cc158e862e7035c8468dfa052", "tree": "568616787bf5f25ad3bc5da9520ed321e5b02383", "parents": [ "179f8f40fc3ae7cd49e96b3a7d5182166c36bdab" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:31 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: improve \"no space after cast\" test\n\nSome false positives exist on this test.\n\nFor instance:\n\t*va_arg(args, signed char *) \u003d val.s;\nor\n\tmemset(foo, 0, sizeof(struct bar *) * baz));\n\nIgnore lines that have an arithmetic operator or assignment\nafter what appears to be a cast to a pointer \"(foo *)\".\n\nAdd $Arithmetic convenience variable.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "179f8f40fc3ae7cd49e96b3a7d5182166c36bdab", "tree": "b2660986886bf926f82efd7960b40db57c0f350c", "parents": [ "77b9a53a627491df83a75361440485629c35aa91" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:30 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: add a --strict test for comparison to true/false\n\nComparing to true or false is error prone.\n\nAdd tests for the various forms of (foo \u003d\u003d true) \u0026\u0026 (false !\u003d bar)\nthat are only reported with --strict.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "77b9a53a627491df83a75361440485629c35aa91", "tree": "8a3176a5cc00a3e8173e03b73b8459f21c8cdf3b", "parents": [ "c4a62ef9102bfa39f3bb89be2ae1ae11a23ebe28" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:29 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: don\u0027t warn on blank lines before/after braces as often\n\nCheck to make sure the blank lines aren\u0027t comment lines like:\n\n bool foo(bool bar)\n {\n\t/* Don\u0027t warn on a leading comment */\n\treturn !bar;\n\t/* Don\u0027t warn on a trailing comment either */\n }\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c4a62ef9102bfa39f3bb89be2ae1ae11a23ebe28", "tree": "f3d0d23c8664d6f8ebcda37f3617b8ecbe5660dc", "parents": [ "3cc4b1c3f0d283f4bb8d49059bd6df8e7af7558b" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:28 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: add a placeholder to check blank lines before declarations\n\nFigure out first how to determine if this is in a struct declaration or in\na function body before enabling this.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3cc4b1c3f0d283f4bb8d49059bd6df8e7af7558b", "tree": "7ac539f3e668317e1fa2f9f2e283d80eecc7333f", "parents": [ "9d7a34a5135d29b840d074ba8fbb9c2fac63e508" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:27 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: reduce false positive rate of \"complex macros\"\n\nAllow \"#define foo struct.member\" without bleating a warning.\n\nThis also allows \"#define foo bar.baz-\u003equx\" and so on.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9d7a34a5135d29b840d074ba8fbb9c2fac63e508", "tree": "3e6869ca31ecf4a1cef0d310427cf937cc1df1cb", "parents": [ "36ec19390effc9131132901e8a66a071a7b74a88" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:26 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: warn on comparisons to get_jiffies_64()\n\nComparing get_jiffies_64() is almost always wrong and time_before64 and\ntime_after64 should be used instead.\n\nWarn on any comparison to get_jiffies_64().\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "36ec19390effc9131132901e8a66a071a7b74a88", "tree": "a0b823311ee76f1ffc4c2b84f9d35446fc449272", "parents": [ "a605e32ebde25dc31f943fecb30e3e28079ccd06" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:25 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: warn on comparisons to jiffies\n\nComparing jiffies is almost always wrong and time_before and time_after\nshould be used instead.\n\nWarn on any comparison to jiffies.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a605e32ebde25dc31f943fecb30e3e28079ccd06", "tree": "42e3079ac358a456aa74a723d4f9c7ffe40b9b4d", "parents": [ "fdb4bcd6108602097b9a1ebd11f6e61f331c8dce" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:24 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: warn when networking block comment lines don\u0027t start with *\n\nSome block comments in network are written as:\n\n\t/* block comment line 1\n\t block comment line 2\n\t */\n\nEmit a warning on the \"block comment line 2\" because it should be\n\n\t/* block comment line 1\n\t * block comment line 2\n\t */\n\nThis warning is only emitted on the second line of a block comment.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fdb4bcd6108602097b9a1ebd11f6e61f331c8dce", "tree": "ecc8b5a175e5cf6c00f6351a803e967a719d484e", "parents": [ "807bd26c4c3e94aced4630ba8369c8941728636b" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:23 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: improve network block comment test and message\n\nShow the first line of the comment after a line with just /* to better\nshow where the defective comment style is in the file.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "807bd26c4c3e94aced4630ba8369c8941728636b", "tree": "6583d6b4fa1714d3b10def6256ea5b18dc59ded1", "parents": [ "a640d25cead66457ac14a878234f8b323ba8aade" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:22 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: remove quote from CamelCase test\n\nCommit be987d9f80 (\"checkpatch: improve CamelCase test for Page\") added\nit but it shouldn\u0027t be there. Must have been my fault.\n\nMake sure that the tested variable doesn\u0027t contain a constant.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a640d25cead66457ac14a878234f8b323ba8aade", "tree": "68226ed2019c2e999efdbf6ccd8d0c53a271e833", "parents": [ "95e2c6023b0e4c8499fb521697f79215f69135fe" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:21 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: add --strict preference for p \u003d kmalloc(sizeof(*p)...\n\nAdd another test for memory allocation style to follow\nDocumentation/CodingStyle:\n\n\t\tChapter 14: Allocating memory\n\nThe preferred form for passing a size of a struct is the following:\n\n\tp \u003d kmalloc(sizeof(*p), ...);\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "95e2c6023b0e4c8499fb521697f79215f69135fe", "tree": "25eb9f42cf21e5476bbdcd4375fa71a546e0b503", "parents": [ "be79794bc116fc0c264be1a599433c92ec9e34f5" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:20 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: warn when using gcc\u0027s binary constant (\"0b\") extension\n\nThe gcc extension for binary constants that start with 0b is only\nsupported with gcc version 4.3 or higher.\n\nThe kernel can still be compiled with earlier versions of gcc, so have\ncheckpatch emit a warning for these constants.\n\nRestructure checkpatch\u0027s constant finding code a bit to support finding\nthese binary constants.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "be79794bc116fc0c264be1a599433c92ec9e34f5", "tree": "55d91938fbfec0094630021274bc97c8a095b1c5", "parents": [ "64df3071a97f20767f63b88c573791691a855b5c" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:20 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:43 2013 -0700" }, "message": "checkpatch: change CamelCase test and make it --strict\n\nDo not bleat a message on nominally acceptable CamelCase uses that are\nseparated by an _ like drm_core_has_MTRR.\n\nCamelCase tests are also a bit noisy against certain types of code\nacceptable to some kernel developers.\n\nMake the test applicable only with --strict.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8543ae1296f6ec1490c7afab6ae0fe97bf87ebf8", "tree": "aa9a2ce97f33051bbcb99079d5fda7311e31f3b3", "parents": [ "74c8f4336da4319f886151a4246024e08b1a0eb3" ], "author": { "name": "Mugunthan V N", "email": "mugunthanvnm@ti.com", "time": "Mon Apr 29 16:18:17 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:20 2013 -0700" }, "message": "checkpatch: add Suggested-by as a standard signature\n\nAs people started using Suggested-by as standard signature, adding\n\"Suggested-by\" to the standard signature so that checkpatch won\u0027t\ngenerate warning when Suggested-by is used in patch signature\n\nSigned-off-by: Mugunthan V N \u003cmugunthanvnm@ti.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "74c8f4336da4319f886151a4246024e08b1a0eb3", "tree": "1953ac3cff35854e438b6bfa5cb001b27615c849", "parents": [ "5646bc71b3ef9634f307f91d9c4bdf38eba4018a" ], "author": { "name": "Matthijs Kooijman", "email": "matthijs@stdin.nl", "time": "Mon Apr 29 16:18:16 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:20 2013 -0700" }, "message": "checkpatch: only warn for empty lines before closing braces by themselves\n\nThis check was intended to catch extra newlines at the end of a function\ndefinition, but it would trigger on any closing brace, including those\nof inline functions and macro definitions, triggering false positives.\nNow, only closing braces on a line by themselves trigger this check.\n\nTested with:\n\n$ cat test.h\n/* test.h - Test file */\n\nstatic inline int foo(void) { return 0; }\n\nstatic inline int bar(void)\n{\n return 1;\n\n}\n\n$ ./scripts/checkpatch.pl --strict -f test.h # Before this commit\nCHECK: Blank lines aren\u0027t necessary before a close brace \u0027}\u0027\n+\n+static inline int foo(void) { return 0; }\n\nCHECK: Blank lines aren\u0027t necessary before a close brace \u0027}\u0027\n+\n+}\n\ntotal: 0 errors, 0 warnings, 2 checks, 9 lines checked\n\n$ ./scripts/checkpatch.pl --strict -f test.h # After this commit\nCHECK: Blank lines aren\u0027t necessary before a close brace \u0027}\u0027\n+\n+}\n\ntotal: 0 errors, 0 warnings, 1 checks, 9 lines checked\n\nSigned-off-by: Matthijs Kooijman \u003cmatthijs@stdin.nl\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nAcked-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5646bc71b3ef9634f307f91d9c4bdf38eba4018a", "tree": "e92492bfcd853e506aaabe2f8a16dcd72861a4d1", "parents": [ "04db4d25d9eaa58140520f976994d1a601129c00" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Apr 29 16:18:15 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:20 2013 -0700" }, "message": "checkpatch: warn on space before semicolon\n\nMake space before semicolon a warning instead of a --strict CHK test.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "04db4d25d9eaa58140520f976994d1a601129c00", "tree": "ef0f2c8c04f8deba8fd9ea9b81d00edbda3f575e", "parents": [ "a6962d7273d8f89c136fe9ea3d61d7f47adcd823" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Apr 29 16:18:14 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:20 2013 -0700" }, "message": "checkpatch: complain about executable files\n\nComplain about files with an executable bit set that are not in a scripts/\ndirectory and are not type .pl, .py, .awk, or .sh\n\nBased on an initial patch from Stephen.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: Stephen Boyd \u003csboyd@codeaurora.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a6962d7273d8f89c136fe9ea3d61d7f47adcd823", "tree": "67d260393e057398039f81acf41c4d35d7c6a01f", "parents": [ "972fdea2e6ece7578915d386a5447bc78d3fb8b8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Apr 29 16:18:13 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:19 2013 -0700" }, "message": "checkpatch: Prefer seq_puts to seq_printf\n\nAdd a check for seq_printf use with a constant format without additional\narguments. Suggest seq_puts instead.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Bjorn Helgaas \u003cbhelgaas@google.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "972fdea2e6ece7578915d386a5447bc78d3fb8b8", "tree": "22c3cf9b8c078efc8d272df333416faca460914a", "parents": [ "2e0fb404c86d6c86dc33e284310eb5d28d192dcf" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Apr 29 16:18:12 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:19 2013 -0700" }, "message": "checkpatch: add check for reuse of krealloc arg\n\nOn Thu, 2013-03-14 at 13:30 +0000, David Woodhouse wrote:\n\u003e If krealloc() returns NULL, it *doesn\u0027t* free the original. So any code\n\u003e of the form \u0027foo \u003d krealloc(foo, …);\u0027 is almost certainly a bug.\n\nSo add a check for it to checkpatch.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nTested-by: Guenter Roeck \u003clinux@roeck-us.net\u003e\nAcked-by: Guenter Roeck \u003clinux@roeck-us.net\u003e\nCc: David Woodhouse \u003cdwmw2@infradead.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Jean Delvare \u003ckhali@linux-fr.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e942e2c3f7e093fc8756dd8b47c93a821c09429f", "tree": "78e410a09d5b9d0f7e7129bfe998658863cfaf16", "parents": [ "d875cf08391a811703f8adf39db598cac9ece6a1" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Apr 17 15:58:26 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Apr 17 16:10:44 2013 -0700" }, "message": "checkpatch: fix stringification macro defect\n\nFix checkpatch misreporting defect with stringification macros\n\nERROR: Macros with complex values should be enclosed in parenthesis\n #27: FILE: arch/arm/include/asm/kgdb.h:41:\n +#define ___to_string(X) #X\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReported-by: Vincent Stehlé \u003cv-stehle@ti.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "be987d9f80354e2e919926349282facd74992f90", "tree": "218d560f3eb8f04701729f6f0dd9cd538df146e8", "parents": [ "adf96e6f514a9e87aa3d26c8c9c03eca5be53df0" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Feb 27 17:02:38 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Feb 27 19:10:08 2013 -0800" }, "message": "checkpatch: improve CamelCase test for Page\n\nAdd the ClearPage/SetPage/TestClearPage/TestSetPage variants to the not\nreported Page CamelCase variables.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "37581c28e9e77f44a3124ebab99b98643bda1aa2", "tree": "3430f2a52b74f201cb20789cf9387d2cd3295a8c", "parents": [ "5ce59ae0bcc0f0ad249d21560c9bb5f6061e62a8" ], "author": { "name": "Bruce Allan", "email": "bruce.w.allan@intel.com", "time": "Thu Feb 21 16:44:19 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Feb 21 17:22:26 2013 -0800" }, "message": "checkpatch: fix USLEEP_RANGE test\n\nDo not test udelay() for a value less than 10usec when passed a variable\ninstead of a hard-coded number; there is no way for checkpatch to know the\nvalue of the variable. As it is today, it will complain about variables\nwith alphanumeric characters plus \u0027_\u0027, e.g. foo_bar, but not variables\nwith other characters, eg. foo-\u003ebar.\n\nSigned-off-by: Bruce Allan \u003cbruce.w.allan@intel.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5ce59ae0bcc0f0ad249d21560c9bb5f6061e62a8", "tree": "1fa6ddc462a2425d6d8d50136330c2db0b6becee", "parents": [ "e8eb3997ce2f5887472a674b32f295b0196ecf46" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Feb 21 16:44:18 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Feb 21 17:22:26 2013 -0800" }, "message": "checkpatch: Add check for kcalloc argument order\n\nkcalloc is sometimes misused with the first and second arguments switched.\n\nSame issue with kmalloc_array too.\n\nBleat if sizeof is the first argument\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e8eb3997ce2f5887472a674b32f295b0196ecf46", "tree": "85cec0f6a05582bf6e255b4492026d863cc59fc3", "parents": [ "10d83f07103f3af0d7e8d73d8d5ffa76e900fd04" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Feb 21 16:44:17 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Feb 21 17:22:26 2013 -0800" }, "message": "checkpatch: don\u0027t emit the CamelCase warning for PageFoo\n\nI\u0027m getting a ton of these:\n\n WARNING: Avoid CamelCase: \u003cPageTransHuge\u003e\n #140: FILE: mm/migrate.c:1576:\n + if (PageTransHuge(page) \u0026\u0026 page_count(page) !\u003d 3) {\n\nSo exclude anything which starts with \"Page\".\n\nTested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "56e77d709df72eefe50ce97a701bd2d5614d0009", "tree": "6aaed6701b4dc7db919dd345afb9181466fbd277", "parents": [ "dc1393130b026908c54d4538abbb5c2badbfabbe" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Feb 21 16:44:14 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Feb 21 17:22:26 2013 -0800" }, "message": "checkpatch: warn on unnecessary __dev\u003cfoo\u003e section markings\n\nGet people to stop adding __devinit and __devexit section markings.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Greg KH \u003cgreg@kroah.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "dc1393130b026908c54d4538abbb5c2badbfabbe", "tree": "4185d47c7dcf7d2a5c4922fe759e0a203ffb484a", "parents": [ "5dc49c75a26b99e86a18441e0b64c1f7c7c6a500" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Feb 21 16:44:13 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Feb 21 17:22:26 2013 -0800" }, "message": "checkpatch: prefer dev_\u003clevel\u003e( to dev_printk(KERN_\u003cLEVEL\u003e\n\nAdd YA check to printk style.\n\ndev_\u003clevel\u003e uses are functions and generate smaller\nobject code than dev_printk(KERN_\u003cLEVEL\u003e.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "326b1ffc136d944d403a2b44dc3abace2a4e10fd", "tree": "8cc25f335929cce2fc6ba48257e52784eea63fb6", "parents": [ "91c777d86752b00bb3a1d8efa3d8f7e1264f38a9" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Feb 04 14:28:51 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Feb 05 20:38:48 2013 +1100" }, "message": "checkpatch: fix $Float creation of match variables\n\nCommit 74349bccedb3 (\"checkpatch: add support for floating point\nconstants\") added an unnecessary match variable that caused tests that\nused a $Constant or $LvalOrFunc to have one too many matches.\n\nThis causes problems with usleep_range, min/max and other extended\ntests.\n\nAvoid using match variables in $Float.\nAvoid using match variables in $Assignment too.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "495e9d84607cda966ba6d223d5eb9df0070cd21a", "tree": "208667895c3646fe4fa1bb7322d0ed1f51880ca5", "parents": [ "5abe257af8b95857b95fa0ba694530b446ae32d8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Dec 20 15:05:37 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Dec 20 17:40:20 2012 -0800" }, "message": "checkpatch: warn on uapi #includes that #include \u003cuapi/...\n\nAvoid specifying internal uapi #include paths with uapi/... as\nuserspace should not use and never see that.\n\nNeaten message line wrapping above.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: David Howells \u003cdhowells@redhat.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "323c1260ba2c4b5c4b2a1e9ab6657cde54ccf554", "tree": "fcc114327e37918e20e42a2f4ed00e3b7f158cec", "parents": [ "74349bccedb3e34b4f1fd9c7efd2dda7905e3335" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:07 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: warn on CamelCase variable names\n\nStore the camelcase variables in a hash and only emit a warning on the\nfirst use of each new variable.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "74349bccedb3e34b4f1fd9c7efd2dda7905e3335", "tree": "7dec12471c55dbaa90c78ab67ea3e23788565cba", "parents": [ "6b7eaf6e1428be33f731287de963862e3846cd42" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:05 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: add support for floating point constants\n\nEven though the kernel doesn\u0027t support using floating point constants,\nadd a regex for them.\n\nSupport forms like: 0x123p1, 123e-1, 1.23, 1.5e23f\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6b7eaf6e1428be33f731287de963862e3846cd42", "tree": "19628f1233f2e758cbd138d1c7a2d41701244b32", "parents": [ "d1e2ad07e78c4bbac9fce4d2e3c0fe60bce091d8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:02 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: find hex constants as a single IDENT\n\nHexadecimal values are current found in 2 parts. A hex constant like\n0x123456abcdef is found as 0 and then x123456abcdef and later coalesced.\n\nInstead, reverse the order of the 2 searches in $Constant to find 0x\nfirst, then 0 so that the entire hex constant is found all at once.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d1e2ad07e78c4bbac9fce4d2e3c0fe60bce091d8", "tree": "41193684d79788aef5d00c817ba570c27c7de02f", "parents": [ "88982fea52d0115d44b77619afef576f24cdb844" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:01 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: add --strict test for switch/default missing break\n\nswitch default case is sometimes written as \"default:;\". This can cause\nnew cases added below the default to be defective.\n\nSuggest adding a break; after empty default cases to avoid fallthrough\ndefects.\n\nFixed indentation in the other semicolon test above it.\n\nSuggested-by: Peter Senna Tschudin \u003cpeter.senna@gmail.com\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "88982fea52d0115d44b77619afef576f24cdb844", "tree": "a31942d9f3ec40c520b6c963e726c705e47b7db3", "parents": [ "0979ae66464bd9793c6701861bccb21f9f118a52" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:00 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: warn when declaring \"struct spinlock foo;\"\n\nspinlock_t should always be used.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: \"Luis R. Rodriguez\" \u003cmcgrof@do-not-panic.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0979ae66464bd9793c6701861bccb21f9f118a52", "tree": "e2e7a6f513aba1c433dbad1ccbb24adb834ca406", "parents": [ "481eb486a88c9b068f0168ac4c21291802720933" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:59 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: Add --strict messages for blank lines around braces\n\nBlank lines around braces are not unnecessary. Emit a message on the use\nof these blank lines only when using --strict.\n\nint foo(int bar)\n{\n\n\tsomething or other....\n\n}\n\nis generally written in the kernel as:\n\nint foo(int bar)\n{\n\tsomething or other...\n}\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "481eb486a88c9b068f0168ac4c21291802720933", "tree": "ded9373e9ace9887f28c8bf3ea1810c600a6b059", "parents": [ "6cd7f3869c925622bbf420e1107a026d91dbd7f2" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:56 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: extend line continuation test\n\nPreprocessor directives and asm statements should be allowed to have a\nline continuation.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nTested-by: Jingoo Han \u003cjg1.han@samsung.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6cd7f3869c925622bbf420e1107a026d91dbd7f2", "tree": "23c356d279579726f68ddfdebe54d4e469e25572", "parents": [ "03df4b51f33e1fdd35fe7bc19f1f450726395207" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:54 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: allow control over line length warning, default remains 80\n\nSome projects might want a longer line length so allow a command line\n--max-line-length\u003dn control over the long line warnings. The default line\nlength is 80.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Constantine Shulyupin \u003cconst@makelinux.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "03df4b51f33e1fdd35fe7bc19f1f450726395207", "tree": "13994b0b62313a4e0f93c1f6c349b01c53ea958e", "parents": [ "78e3f1f01d23c1a0d5828669d35afa2e7951987d" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Dec 17 16:01:52 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: consolidate if (foo) bar(foo) checks and add debugfs_remove\n\nConsolidate the if (foo) bar(foo) detectors into a single check. Add\ndebugfs_remove and family.\n\nBased on a patch by Constantine Shulyupin.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Constantine Shulyupin \u003cconst@MakeLinux.com\u003e.\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "78e3f1f01d23c1a0d5828669d35afa2e7951987d", "tree": "60221a5006aaec5e0a810facb8a223b910f92175", "parents": [ "1ba8dfd17ead04de18bfca7b68c2a144c8be736a" ], "author": { "name": "Tao Ma", "email": "boyu.mt@taobao.com", "time": "Mon Dec 17 16:01:49 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: remove reference to feature-removal-schedule.txt\n\nIn commit 9c0ece069b32 (\"Get rid of Documentation/feature-removal.txt\"),\nLinus removes feature-removal-schedule.txt from Documentation, but there\nis still some reference to this file. So remove them.\n\nSigned-off-by: Tao Ma \u003cboyu.mt@taobao.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1ba8dfd17ead04de18bfca7b68c2a144c8be736a", "tree": "d9f42871b6809cd40e03557bc243a11d6039dd20", "parents": [ "5023d3472d444747bfa12e9798d7993e7efb8287" ], "author": { "name": "Kees Cook", "email": "keescook@chromium.org", "time": "Mon Dec 17 16:01:48 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:18 2012 -0800" }, "message": "checkpatch: warn about using CONFIG_EXPERIMENTAL\n\nThis config item has not carried much meaning for a while now and is\nalmost always enabled by default. As agreed during the Linux kernel\nsummit, it is being removed. This will discourage future addition of\nCONFIG_EXPERIMENTAL while it is being phased out.\n\nSigned-off-by: Kees Cook \u003ckeescook@chromium.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5023d3472d444747bfa12e9798d7993e7efb8287", "tree": "384454623fc76da468021e0d58846debec536014", "parents": [ "0ad50c3896afbb3c103409a18260e601b87a744c" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:47 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:18 2012 -0800" }, "message": "checkpatch: warn on unnecessary line continuations\n\nWhen the previous line is not a line continuation and the current line has\na line continuation but is not a #define, emit a warning.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Peter Hurley \u003cpeter@hurleysoftware.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c24f9f195edf8c7f78eff1081cdadd26bd272ee3", "tree": "27063fcac4f5fd20054b3ca45fe15d6c39762876", "parents": [ "3d70f8c617a436c7146ecb81df2265b4626dfe89" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Nov 08 15:53:29 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Nov 09 06:41:46 2012 +0100" }, "message": "checkpatch: improve network block comment style checking\n\nSome comment styles in net and drivers/net are flagged inappropriately.\n\nAvoid proclaiming inline comments like:\n\tint a \u003d b;\t/* some comment */\nand block comments like:\n\t/*********************\n\t * some comment\n\t ********************/\nare defective.\n\nTested with\n$ cat drivers/net/t.c\n/* foo */\n\n/*\n * foo\n */\n\n/* foo\n */\n\n/* foo\n * bar */\n\n/****************************\n * some long block comment\n ***************************/\n\nstruct foo {\n\tint bar;\t/* another test */\n};\n$\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReported-by: Larry Finger \u003cLarry.Finger@lwfinger.net\u003e\nCc: David Miller \u003cdavem@davemloft.net\u003e\nCc: Stephen Hemminger \u003cshemminger@vyatta.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a0a0a7a94c765f7219b57fa3b79389901bb0bc99", "tree": "8830687bde899b15cf1764aee396a15c8dee8fb9", "parents": [ "c4ff1b5f8bf09d77d7329cbff224f0237646c90e" ], "author": { "name": "Kees Cook", "email": "keescook@chromium.org", "time": "Thu Oct 04 17:13:38 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:05:00 2012 +0900" }, "message": "checkpatch: fix name of \"MODULE_PARM_DESC\"\n\nFix macro name in checkpatch: s/PARAM/PARM/.\n\nSigned-off-by: Kees Cook \u003ckeescook@chromium.org\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "058806007450489bb8f457b275e5cb5c946320c1", "tree": "7c99dc9728618bec0eccd7578ad493ff312e7dc1", "parents": [ "8f26b8376faad26372a579606ecbd77b20e99dd8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Oct 04 17:13:35 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:04:59 2012 +0900" }, "message": "checkpatch: check networking specific block comment style\n\nIn an effort to get fewer checkpatch reviewer corrections, add a\nnetworking specific style test for the preferred networking comment style.\n\n\t/* The preferred style for block comments in\n\t * drivers/net/... and net/... is like this\n\t */\n\nThese tests are only used in net/ and drivers/net/\n\nTested with:\n\n$ cat drivers/net/t.c\n\n/* foo */\n\n/*\n * foo\n */\n\n/* foo\n */\n\n/* foo\n * bar */\n$ ./scripts/checkpatch.pl -f drivers/net/t.c\nWARNING: networking block comments don\u0027t use an empty /* line, use /* Comment...\n#4: FILE: net/t.c:4:\n+\n+/*\n\nWARNING: networking block comments put the trailing */ on a separate line\n#12: FILE: net/t.c:12:\n+ * bar */\n\ntotal: 0 errors, 2 warnings, 12 lines checked\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: \"Allan, Bruce W\" \u003cbruce.w.allan@intel.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: David Miller \u003cdavem@davemloft.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8f26b8376faad26372a579606ecbd77b20e99dd8", "tree": "50fc1463508ac9fd91a0b437284d84a81918f903", "parents": [ "fa64205df9dfd7b7662cc64a7e82115c00e428e5" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Oct 04 17:13:32 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:04:59 2012 +0900" }, "message": "checkpatch: update suggested printk conversions\n\nDirect conversion of printk(KERN_\u003cLEVEL\u003e... to pr_\u003clevel\u003e isn\u0027t the\npreferred conversion when a struct net_device or struct device is\navailable.\n\nHint that using netdev_\u003clevel\u003e or dev_\u003clevel\u003e is preferred to using\npr_\u003clevel\u003e. Add netdev_dbg and dev_dbg variants too.\n\nMiscellaneous whitespace neatening of a misplaced close brace.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Greg KH \u003cgregkh@linuxfoundation.org\u003e\nCc: Dan Carpenter \u003cdan.carpenter@oracle.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fa64205df9dfd7b7662cc64a7e82115c00e428e5", "tree": "4df37058666c34ed88a3d7c0ffae2330b8b7eddf", "parents": [ "8290e2d2dcbf0d379d4b1379e17916515ee20a39" ], "author": { "name": "Pasi Savanainen", "email": "pasi.savanainen@nixu.com", "time": "Thu Oct 04 17:13:29 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:04:59 2012 +0900" }, "message": "checkpatch: check utf-8 content from a commit log when it\u0027s missing from charset\n\nCheck that a commit log doesn\u0027t contain UTF-8 when a mail header\nexplicitly defines a different charset, like\n\n\u0027Content-Type: text/plain; charset\u003d\"us-ascii\"\u0027\n\nSigned-off-by: Pasi Savanainen \u003cpasi.savanainen@nixu.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ac8e97f8a742828daa1d9de37f6e635888f8d71e", "tree": "d2eae9170d79c302d99c0d7a27da134060fde69e", "parents": [ "eb48c071464757414538c68a6033c8f8c15196f8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Aug 21 16:15:53 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Aug 21 16:45:02 2012 -0700" }, "message": "checkpatch: add control statement test to SINGLE_STATEMENT_DO_WHILE_MACRO\n\nCommit b13edf7ff2dd (\"checkpatch: add checks for do {} while (0) macro\nmisuses\") added a test that is overly simplistic for single statement\nmacros.\n\nMacros that start with control tests should be enclosed in a do {} while\n(0) loop.\n\nAdd the necessary control tests to the check.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nTested-by: Franz Schrober \u003cfranzschrober@yahoo.de\u003e\nCc: Stephen Rothwell \u003csfr@canb.auug.org.au\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b13edf7ff2dd0fef95e981170fa71fa6b60421b0", "tree": "cdfbfb5429b089d1e41f9551bf112a8236fae078", "parents": [ "66c80b6077256898df948ac6acf547b47ddb1fcf" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:24 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: add checks for do {} while (0) macro misuses\n\nThese types of macros should not be used for either a single statement\nnor should the macro end with a semi-colon.\n\nAdd tests for these conditions.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "66c80b6077256898df948ac6acf547b47ddb1fcf", "tree": "20982260f1fd1e875188b24ddd598e77544e5354", "parents": [ "4a273195a551a27a9a3ebed072c8df16c853da7f" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:22 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: Add acheck for use of sizeof without parenthesis\n\nKernel style uses parenthesis around sizeof.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4a273195a551a27a9a3ebed072c8df16c853da7f", "tree": "f6dd0354f66679adea5cab8aab0a620a6832e181", "parents": [ "ce0338df3c9a43e709b8a478265b32b9edcc7ccc" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:20 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: check usleep_range() arguments\n\nusleep_range() shouldn\u0027t use the same args for min and max.\n\nReport it when it happens and when both args are decimal and min \u003e max.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Yuval Mintz \u003cyuvalmin@broadcom.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ce0338df3c9a43e709b8a478265b32b9edcc7ccc", "tree": "7f6c7047b4e1215f11ce2f774091237c7b5fdeb8", "parents": [ "b34a26f3158cca932b6f1427b97fe12c7838ee68" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:18 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: test for non-standard signatures\n\nWarn on non-standard signature styles.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b34a26f3158cca932b6f1427b97fe12c7838ee68", "tree": "e1c5e08259b56d444f6797c8e3e7b88cd4df64d5", "parents": [ "4ed940d4c34c21a1a356969a923f2815d608e0bf" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:16 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: Update alignment check\n\nParenthesis alignment doesn\u0027t correctly check an existing line after an\ninserted or modified line with an open parenthesis.\n\nFix it.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "243f3803cf2a3665092c5fd6f924f453694681a6", "tree": "a05005eb618c2770a2e56c644ae04d8e36c58c89", "parents": [ "9a4cad4e25b91f48494f13fce3d25ea44bec7472" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu May 31 16:26:09 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu May 31 17:49:27 2012 -0700" }, "message": "checkpatch: suggest pr_\u003clevel\u003e over printk(KERN_\u003cLEVEL\u003e\n\nSuggest the shorter pr_\u003clevel\u003e instead of printk(KERN_\u003cLEVEL\u003e.\n\nPrefer to use pr_\u003clevel\u003e over bare printks.\nPrefer to use pr_warn over pr_warning.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nCc: Theodore Ts\u0027o \u003ctytso@mit.edu\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9a4cad4e25b91f48494f13fce3d25ea44bec7472", "tree": "6b7cbfdf1517792f826f23408b8ca023ee2b3229", "parents": [ "133fd9f5cda2d86904126f4b9fa4e8f4330c9569" ], "author": { "name": "Eric Nelson", "email": "eric.nelson@boundarydevices.com", "time": "Thu May 31 16:26:09 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu May 31 17:49:27 2012 -0700" }, "message": "checkpatch: check for whitespace before semicolon at EOL\n\nRequires --strict option during invocation:\n\t~/linux$ scripts/checkpatch --strict foo.patch\n\nThis tests for a bad habits of mine like this:\n\n\treturn 0 ;\n\nNote that it does allow a special case of a bare semicolon\nfor empty loops:\n\n\twhile (foo())\n\t\t;\n\nSigned-off-by: Eric Nelson \u003ceric.nelson@boundarydevices.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c06a9ebdb7a4f4823d4225fe789d8c20a1d534eb", "tree": "9909d3aac2349fd6636fd1fdd0d4480869978b5b", "parents": [ "e816b57a337ea3b755de72bec38c10c864f23015" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Apr 16 13:35:11 2012 -0600" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 16 12:44:38 2012 -0700" }, "message": "checkpatch: revert --strict test for net/ and drivers/net block comment style\n\nRevert the --strict test for the old preferred block\ncomment style in drivers/net and net/\n\nReported-by: Ingo Molnar \u003cmingo@kernel.org\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ca56dc098caf93b5437cd6c4ee49f02aa18f84d6", "tree": "0bc689836c48cf91fcc5ca37db7753b5fa7d9fa3", "parents": [ "6712d85852b348d07301c7480f7eb3312d329143" ], "author": { "name": "Josh Triplett", "email": "josh@joshtriplett.org", "time": "Fri Mar 23 15:02:21 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:37 2012 -0700" }, "message": "checkpatch: check for quoted strings broken across lines\n\ncheckpatch already makes an exception to the 80-column rule for quoted\nstrings, and Documentation/CodingStyle recommends not splitting quoted\nstrings across lines, because it breaks the ability to grep for the\nstring. Rather than just permitting this, actively warn about quoted\nstrings split across lines.\n\nTest case:\n\nvoid context(void)\n{\n\tstruct { unsigned magic; const char *strdata; } foo[] \u003d {\n\t\t{ 42, \"these strings\"\n\t\t \"do not produce warnings\" },\n\t\t{ 256, \"though perhaps\"\n\t\t \"they should\" },\n\t};\n\tpr_err(\"this string\"\n\t \" should produce a warning\\n\");\n\tpr_err(\"this multi-line string\\n\"\n\t \"should not produce a warning\\n\");\n\tasm (\"this asm\\n\\t\"\n\t \"should not produce a warning\");\n}\n\nResults of checkpatch on that test case:\n\nWARNING: quoted string split across lines\n+\t \" should produce a warning\\n\");\n\ntotal: 0 errors, 1 warnings, 15 lines checked\n\nSigned-off-by: Josh Triplett \u003cjosh@joshtriplett.org\u003e\nAcked-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6712d85852b348d07301c7480f7eb3312d329143", "tree": "dbb4fdfc2dcafb9e22a2a5daed673fb172721605", "parents": [ "2c92488ab29886d08766c054afc8dd0f19c724f1" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 23 15:02:20 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:37 2012 -0700" }, "message": "checkpatch: whitespace - add/remove blank lines\n\nAdd blank lines between a few tests, remove an extraneous one.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2c92488ab29886d08766c054afc8dd0f19c724f1", "tree": "c1a42d6c825de9b0f3bf239d9a1a086a4b4422ce", "parents": [ "aad4f61498314d41d047ea2161b7bd7237b72d33" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 23 15:02:20 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:37 2012 -0700" }, "message": "checkpatch: warn on use of yield()\n\nUsing yield() is generally wrong. Warn on its use.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Peter Zijlstra \u003ca.p.zijlstra@chello.nl\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "aad4f61498314d41d047ea2161b7bd7237b72d33", "tree": "503836c82abeaed36ad119538fa3cbb7b8d94b24", "parents": [ "b337d8b82f235d0212f7adcaeb431fd4e688bb98" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 23 15:02:19 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:37 2012 -0700" }, "message": "checkpatch: add --strict tests for braces, comments and casts\n\nAdd some more subjective --strict tests.\n\nAdd a test for block comments that start with a blank line followed only\nby a line with just the comment block initiator. Prefer a blank line\nfollowed by /* comment...\n\nAdd a test for unnecessary spaces after a cast.\n\nAdd a test for symmetric uses of braces in if/else blocks.\nIf one branch needs braces, then all branches should use braces.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b337d8b82f235d0212f7adcaeb431fd4e688bb98", "tree": "1caccc45dbd1edfec3ff4d02e268f76444330ccf", "parents": [ "fd1b57ac73f169a5ba7a9569989aad40184f6340" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Mar 23 15:02:18 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: add [] to type extensions\n\nAdd [] to a type extensions. Fixes false positives on:\n\n .attrs \u003d (struct attribute *[]) {\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fd1b57ac73f169a5ba7a9569989aad40184f6340", "tree": "7a188a1f50c00a86e790acc406fb96db45294850", "parents": [ "e45bab8ebfee65ba89b228c1e7c64a6cb0812124" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Mar 23 15:02:18 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: high precedence operators do not require additional parentheses in #defines\n\nWith any very high precedence operator it is not necessary to enforce\nadditional parentheses around simple negated expressions. This prevents\nus requesting further perentheses around the following:\n\n #define PMEM_IS_FREE(id, index) !(pmem[id].bitmap[index].allocated)\n\nFor now add logical and bitwise not and unary minus.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e45bab8ebfee65ba89b228c1e7c64a6cb0812124", "tree": "fe61be22fa4438d5bd132712e730daca9cbf341b", "parents": [ "b9df76ac76da351cd4f6ba52369e9a64e9ab686d" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Mar 23 15:02:18 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: handle string concatenation in simple #defines\n\nAdjacent strings indicate concatentation, therefore look at identifiers\ndirectly adjacent to literal strings as strings too. This allows us to\nbetter detect the form below and accept it as a simple constant:\n\n #define pr_fmt(fmt) KBUILD_MODNAME \": \" fmt\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b9df76ac76da351cd4f6ba52369e9a64e9ab686d", "tree": "b02d82a012dbf249d8b8f89b530681eaa26e52bd", "parents": [ "daebc534ac15f991961a5bb433e515988220e9bf" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Mar 23 15:02:17 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: allow simple character constants in #defines\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "daebc534ac15f991961a5bb433e515988220e9bf", "tree": "add72230235f44a56111cad80913985ad24aaf6d", "parents": [ "11232688ec41a507cdb476fc4e88aff8a3a34c3c" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Mar 23 15:02:17 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: catch [ ... ] usage when not at the beginning of definition\n\nHandle the [ A ... B ] form deeper into a definition, for example:\n\n static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] \u003d {\n\t {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] \u003d 0 },\n\t {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] \u003d 0 },\n };\n\nReported-by: Marek Vasut \u003cmarek.vasut@gmail.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "11232688ec41a507cdb476fc4e88aff8a3a34c3c", "tree": "4b8aa11d480277531d3c96cf7acf5180540269d8", "parents": [ "d1fe9c099cecc6e49324355f1b15573e9dbbe0f9" ], "author": { "name": "Artem Bityutskiy", "email": "dedekind1@gmail.com", "time": "Fri Mar 23 15:02:17 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch.pl: be silent when -q and --ignore is given\n\nFix checkpatch.pl when both -q and --ignore are given and prevents it from\nprinting a\n\nNOTE: Ignored message types: blah\n\nmessages.\n\nE.g., if I use -q --ignore PREFER_PACKED,PREFER_ALIGNED, i see:\n\nNOTE: Ignored message types: PREFER_ALIGNED PREFER_PACKED\n\nIt makes no sense to print this when -q is given.\n\nSigned-off-by: Artem Bityutskiy \u003cartem.bityutskiy@linux.intel.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d1fe9c099cecc6e49324355f1b15573e9dbbe0f9", "tree": "3b9fc1b4ac53907623b73e4967fed8b1ead12a58", "parents": [ "6061d949dd984c762ee272a88e77699fa675d1c8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 23 15:02:16 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: add some --strict coding style checks\n\nArgument alignment across multiple lines should match the open\nparenthesis.\n\nLogical continuations should be at the end of the previous line, not the\nstart of a new line.\n\nThese are not required by CodingStyle so make the tests active only when\nusing --strict.\n\nImproved by some examples from Bruce Allen.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: \"Bruce W. Allen\" \u003cbruce.w.allan@intel.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6061d949dd984c762ee272a88e77699fa675d1c8", "tree": "2e19eecd34a716fc5ed9fa3f18a7db0a3edf6f5b", "parents": [ "97e834c5040b85e133d8d922111a62b2b853a406" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 23 15:02:16 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "include/ and checkpatch: prefer __scanf to __attribute__((format(scanf,...)\n\nIt\u0027s equivalent to __printf, so prefer __scanf.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8eef05dd3e70233f3e391774d612dab44c3f023b", "tree": "dda65b15abaa42564d2e46424bfe6a7a73cc5681", "parents": [ "6bd113f1f4a8c0d05c4dbadb300319e0e3526db4" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Feb 03 15:20:39 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Feb 07 15:53:08 2012 -0800" }, "message": "checkpatch: Warn on code with 6+ tab indentation\n\nOverly indented code should be refactored.\n\nSuggest refactoring excessive indentation of of\nif/else/for/do/while/switch statements.\n\nFor example:\n\n$ cat t.c\n#include \u003cstdio.h\u003e\n#include \u003cstdlib.h\u003e\n\nint main(int argc, char **argv)\n{\n\n\tif (1)\n\t\tif (2)\n\t\t\tif (3)\n\t\t\t\tif (4)\n\t\t\t\t\tif (5)\n\t\t\t\t\t\tif (6)\n\t\t\t\t\t\t\tif (7)\n\t\t\t\t\t\t\t\tif (8)\n\t\t\t\t\t\t\t\t\t;\n\treturn 0;\n}\n\n$ ./scripts/checkpatch.pl -f t.c\nWARNING: Too many leading tabs - consider code refactoring\n#12: FILE: t.c:12:\n+\t\t\t\t\t\tif (6)\n\nWARNING: Too many leading tabs - consider code refactoring\n#13: FILE: t.c:13:\n+\t\t\t\t\t\t\tif (7)\n\nWARNING: Too many leading tabs - consider code refactoring\n#14: FILE: t.c:14:\n+\t\t\t\t\t\t\t\tif (8)\n\ntotal: 0 errors, 3 warnings, 17 lines checked\n\nt.c has style problems, please review.\n\nIf any of these errors are false positives, please report\nthem to the maintainer, see CHECKPATCH in MAINTAINERS.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "bfcb2cc798a14230d22b6dd999e2e680623de622", "tree": "dfa486a04620bd02e58b3cdcb8b06ee5da3014ac", "parents": [ "6b48db24e30d371bc54566667b82ca3d64aab80a" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:15 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: catch all occurences of type and cast spacing errors per line\n\nFix up type and cast spacing checks such that all occurences on a line are\nexamined and reported. For example the line below has a valid cast and a\nbad type, but currently we check the cast first which is good and stop:\n\n u16* bar \u003d (u16 *)baz;\n\nWe will also only report one of the errors in this example:\n\n u16* bar \u003d (u16*)bad;\n\nMove to iterating across all casts and all types, reporting any failure.\n\n[akpm@linux-foundation.org: coding-style fixes]\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6b48db24e30d371bc54566667b82ca3d64aab80a", "tree": "4532e530d3e97917dc8a82bfc1f23f91e9627150", "parents": [ "addcdcea99514bee64b5bf091ac9fd2fc5da65cf" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:13 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: typeof may have more complex arguments\n\ntypeof may have various more complex forms as its arguement, not just an\nidentifier. For now allow us to leak to the first close perenthesis \u0027)\u0027.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "addcdcea99514bee64b5bf091ac9fd2fc5da65cf", "tree": "effbf409bfc451203c0051f130ff263c52aa356e", "parents": [ "c81769fdc84ed7c6eb3cc5cecb194324a5e4c8ad" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:11 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: ensure cast type is unique in the context parser\n\nEnsure the cast type is unique in the context parser, we do not want them\nto detect as a comma \u0027,\u0027.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c81769fdc84ed7c6eb3cc5cecb194324a5e4c8ad", "tree": "bfa7973e16263c7993a54bd53e7a00f350f7d5cc", "parents": [ "e01886ada28741d7cb2cfb3224e9caccfbc1a2d5" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:10 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: fix complex macros handling of square brackets\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e01886ada28741d7cb2cfb3224e9caccfbc1a2d5", "tree": "ba401dddad6fffc2dc079e1449f20c2091195a41", "parents": [ "72f115f94d500fc72f78c5df8104a98f8b9cc273" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:08 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: fix \u0027return is not a function\u0027 square bracket handling\n\nWe are incorrectly matching square brackets \u0027[\u0027 and \u0027]\u0027 leading to false\npositives on more complex functions as below:\n\n return (dt3155_fbuffer[m]-\u003eready_head -\n\tdt3155_fbuffer[m]-\u003eready_len +\n\tdt3155_fbuffer[m]-\u003enbuffers)%\n\t(dt3155_fbuffer[m]-\u003enbuffers);\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "72f115f94d500fc72f78c5df8104a98f8b9cc273", "tree": "3c6b37bebd9b1f1671df4f8d0dcbe0f625b4a6a0", "parents": [ "87a53877185627b49a903023255425bda78f890c" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:06 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: complex macro should allow the empty do while loop\n\nIt is common to stub out a function as below, this is triggering a complex\nmacro format incorrectly. Sort this out:\n\n #define cma_early_regions_reserve(reserve) do { } while (0)\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "87a53877185627b49a903023255425bda78f890c", "tree": "47809b22567658e1e17be1603358d06f79a8e99f", "parents": [ "a13858033a3a993147d190317cc9d709f0a1b819" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:04 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: fix EXPORT_SYMBOL handling following a function\n\nThe following fragment defeats the DEVICE_ATTR style handing, check for\nand ignore the close brace \u0027}\u0027 in this context:\n\n int foo()\n {\n }\n DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR,\n ata_scsi_lpm_show, ata_scsi_lpm_put);\n EXPORT_SYMBOL_GPL(dev_attr_link_power_management_policy);\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a13858033a3a993147d190317cc9d709f0a1b819", "tree": "2d82b609eeafc484a046faa4616f4ed67a31c27f", "parents": [ "3e469cdc08ac5d84b220f8fb76a090d158d5114f" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:03 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: only apply kconfig help checks for options which prompt\n\nThe intent of this check is to catch the options which the user will see\nand ensure they are properly described. It is also common for internal\nonly options to have a brief description. Allow this form.\n\nReported-by: Steven Rostedt \u003crostedt@goodmis.org\u003e\nTested-by: Steven Rostedt \u003crostedt@goodmis.org\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3e469cdc08ac5d84b220f8fb76a090d158d5114f", "tree": "fc35a9ca8593ddd2bf0e07ceb2f39e83ff06ff4c", "parents": [ "89a883530fe79939384a6c6ed893c719762c7c9c" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:01 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: optimise statement scanner when mid-statement\n\nIn the middle of a long definition or similar, there is no possibility of\nfinding a smaller sub-statement. Optimise this case by skipping statement\naquirey where there are no starts of statement (open brace \u0027{\u0027 or\nsemi-colon \u0027;\u0027). We are likely to scan slightly more than needed still\nbut this is safest.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "89a883530fe79939384a6c6ed893c719762c7c9c", "tree": "49d1dd395c3029ab6261c8d217f53642d77bdc0f", "parents": [ "d7c76ba7e58bc3ca674f20759c686535db484749" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:00 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: ## is not a valid modifier\n\nInserting a # into the modifiers list will incorrectly add the null string\nto the modifiers list, leading to an infinite loop. As neither of these\nis a valid modifier form simply ignore them.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nReported-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d7c76ba7e58bc3ca674f20759c686535db484749", "tree": "26066daabbfd375eb984da2d8d773ef230f62ddb", "parents": [ "554e165cf32610ec9596a183fa1b54a5707fc3cb" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Jan 10 15:09:58 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: improve memset and min/max with cast checking\n\nImprove the checking of arguments to memset and min/max tests.\n\nMove the checking of min/max to statement blocks instead of single line.\nChange $Constant to allow any case type 0x initiator and trailing ul\nspecifier. Add $FuncArg type as any function argument with or without a\ncast. Print the whole statement when showing memset or min/max messages.\nImprove the memset with 0 as 3rd argument error message.\n\nThere are still weaknesses in the $FuncArg and $Constant code as arbitrary\nparentheses and negative signs are not generically supported.\n\n[akpm@linux-foundation.org: fix per Andy]\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "554e165cf32610ec9596a183fa1b54a5707fc3cb", "tree": "027354f186b71c033929a5ecf8df80f131c9ce7b", "parents": [ "f74bd1942e04a0cedd1e9c8b331141e75add49c0" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:09:57 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: check for common memset parameter issues against statments\n\nMove the memset checks over to work against the statement. Also add\nchecks for 0 and 1 used as lengths. Generally these indicate badly\nordered parameters.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f74bd1942e04a0cedd1e9c8b331141e75add49c0", "tree": "76e1f8b1fdf0c1be748304d14f9aed353932fc26", "parents": [ "5f14d3bd87ef5f979ea64c1f0862534d71786db7" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:09:54 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: correctly track the end of preprocessor commands in context\n\nWhen looking for a statement we currently run on through preprocessor\ncommands. This means that a header file with just definitions is parsed\nover and over again combining all of the lines from the current line to\nthe end of file leading to severe performance issues.\n\nFix up context accumulation to track preprocessor commands and stop when\nreaching the end of them. At the same time vastly simplify the #define\nhandling.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5f14d3bd87ef5f979ea64c1f0862534d71786db7", "tree": "88982b950031e877156bf17c3755d9a128b336f8", "parents": [ "270c49a088ae58d4b817861bb04bfec63b0966db" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Jan 10 15:09:52 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: prefer __printf over __attribute__((format(printf,...)))\n\nAdd a warn for not using __printf.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "270c49a088ae58d4b817861bb04bfec63b0966db", "tree": "4c08b86b0be13a7d256e1f7a83f87ebca9d20b9d", "parents": [ "96b62067f970ff529c98913311d33f4b57b453dc" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Jan 10 15:09:50 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: update signature \"might be better as\" warning\n\nemail header lines can look like signature tags. It\u0027s valid to have\nmultiple email recipients on a single line but not valid to have multiple\nsignatures on a single line.\n\nValidate signatures only when not in the email headers.\n\nClear the $in_commit_log flag when the patch filename appears.\n\nAdd \u0027-\u0027 to the valid chars in a message header for headers\nlike \"Message-Id:\" and \"In-Reply-To:\".\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReported-by: Julia Lawall \u003cjulia.lawall@lip6.fr\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "addd8c92cf55bba578b8a56e0f717a0a74b31008", "tree": "2329201d816460d4baa71c8463c761034f99b1eb", "parents": [ "a84f6aa68e35a911c28e5871c87356dce3607b40", "c68e58783f20d3eb32b99e1962b26462f2e3195a" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Nov 06 18:53:33 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Nov 06 18:53:33 2011 -0800" }, "message": "Merge branch \u0027misc\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild\n\n* \u0027misc\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:\n script/checkpatch.pl: warn about deprecated use of EXTRA_{A,C,CPP,LD}FLAGS\n tags, powerpc: Update tags.sh to support _GLOBAL symbols\n scripts: add extract-vmlinux\n" }, { "commit": "15662b3e8644905032c2e26808401a487d4e90c1", "tree": "0eae1a68779bd314459a2bff55c43e266329015d", "parents": [ "67d0a0754455f89ef3946946159d8ec9e45ce33a" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Oct 31 17:13:12 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Oct 31 17:30:57 2011 -0700" }, "message": "checkpatch: add a --strict check for utf-8 in commit logs\n\nSome find using utf-8 in commit logs inappropriate.\n\nSome patch commit logs contain unintended utf-8 characters when doing\nthings like copy/pasting compilation output.\n\nLook for the start of any commit log by skipping initial lines that look\nlike email headers and \"From: \" lines.\n\nStop looking for utf-8 at the first signature line.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "67d0a0754455f89ef3946946159d8ec9e45ce33a", "tree": "297c25551f6523bc8284c40642491113e72b350e", "parents": [ "fc23af34b00ef444eec088f744983b9ca6c7f5d1" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Oct 31 17:13:10 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Oct 31 17:30:57 2011 -0700" }, "message": "kernel.h/checkpatch: mark strict_strto\u003cfoo\u003e and simple_strto\u003cfoo\u003e as obsolete\n\nMark obsolete/deprecated strict_strto\u003cfoo\u003e and simple_strto\u003cfoo\u003e functions\nand macros as obsolete.\n\nUpdate checkpatch to warn about their use.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e060c38434b2caa78efe7cedaff4191040b65a15", "tree": "407361230bf6733f63d8e788e4b5e6566ee04818", "parents": [ "10e4ac572eeffe5317019bd7330b6058a400dfc2", "cc39c6a9bbdebfcf1a7dee64d83bf302bc38d941" ], "author": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Thu Sep 15 15:08:05 2011 +0200" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Thu Sep 15 15:08:18 2011 +0200" }, "message": "Merge branch \u0027master\u0027 into for-next\n\nFast-forward merge with Linus to be able to merge patches\nbased on more recent version of the tree.\n" }, { "commit": "699324871fcc3650f2023c5e36cb119a92d7894b", "tree": "7115a8183a4fd00b6f0ea1ae3b8f3dfbcf1c454b", "parents": [ "ca4a04cf3dd0cecb5e7188ed7796cc55fc13aeb1" ], "author": { "name": "Justin P. Mattock", "email": "justinmattock@gmail.com", "time": "Tue Jul 26 23:06:29 2011 -0700" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Thu Sep 15 14:50:49 2011 +0200" }, "message": "treewide: remove extra semicolons from various parts of the kernel\n\nThis is a resend from the original, changing the title from PATCH to\nRFC(since this is a review for commit, and I should have put that the first go around).\nand also removing some of the commit\u0027s with ia64 and bash since it is significant.\nlet me know if I might have missed anything etc..\n\nSigned-off-by: Justin P. Mattock \u003cjustinmattock@gmail.com\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "c68e58783f20d3eb32b99e1962b26462f2e3195a", "tree": "b77e91da189e7df141cea7f775328f3968cc27a6", "parents": [ "9c65426ad2cce12a2d72cdb42aa08f7ce946065d" ], "author": { "name": "Arnaud Lacombe", "email": "lacombar@gmail.com", "time": "Mon Aug 15 01:07:14 2011 -0400" }, "committer": { "name": "Michal Marek", "email": "mmarek@suse.cz", "time": "Wed Aug 31 16:43:44 2011 +0200" }, "message": "script/checkpatch.pl: warn about deprecated use of EXTRA_{A,C,CPP,LD}FLAGS\n\nUsage of these flags has been deprecated for nearly 4 years by:\n\n commit f77bf01425b11947eeb3b5b54685212c302741b8\n Author: Sam Ravnborg \u003csam@neptun.(none)\u003e\n Date: Mon Oct 15 22:25:06 2007 +0200\n\n kbuild: introduce ccflags-y, asflags-y and ldflags-y\n\nMoreover, these flags (at least EXTRA_CFLAGS) have been documented for command\nline use. By default, gmake(1) do not override command line setting, so this is\nlikely to result in build failure or unexpected behavior.\n\nWarn about their introduction in Makefile or Kbuild files.\n\nCc: Sam Ravnborg \u003csam@ravnborg.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Arnaud Lacombe \u003clacombar@gmail.com\u003e\nSigned-off-by: Michal Marek \u003cmmarek@suse.cz\u003e\n" }, { "commit": "30ecad51849ae132dc6ef6ddb62d499c7257515b", "tree": "cf6781cde6f1929c93c2d3c393188257aa7031e9", "parents": [ "3d1c2f72a9464c9880054194af0c041d7beb9124" ], "author": { "name": "Hui Zhu", "email": "teawater@gmail.com", "time": "Thu Aug 25 15:59:08 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Aug 25 16:25:33 2011 -0700" }, "message": "checkpatch: add missing WARN argument for min_t and max_t tests\n\nThe test for bad usage of min_t() and max_t() is missing the --ignore\ntype. Add it.\n\nSigned-off-by: Hui Zhu \u003cteawater@gmail.com\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6e60c02e9d9427f59842192bdb123cbeaf8bc9a0", "tree": "6cd57dfec304a5cb049173dac6050bb0f13e6876", "parents": [ "34d99219726ff4d3425b360d1e8d081627a73a00" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 25 17:13:27 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 25 20:57:16 2011 -0700" }, "message": "checkpatch.pl: update $logFunctions\n\nPrevious behavior allowed only alphabetic prefixes like pr_info to exceed\nthe 80 column line length limit.\n\nath6kl wants to add a digit into the prefix, so allow numbers as well as\ndigits in the \u003cprefix\u003e_\u003clevel\u003e printks.\n\n\u003cprefix\u003e_\u003clevel\u003e_ratelimited and \u003cprefix\u003e_\u003clevel\u003e_once and WARN_RATELIMIT\nand WARN_ONCE may now exceed 80 cols.\n\nAdd missing \u003cprefix\u003e_printk type for completeness.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Kalle Valo \u003ckvalo@qca.qualcomm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "34d99219726ff4d3425b360d1e8d081627a73a00", "tree": "30d9d2c477c984d7be0aa13dc93c19189649e7f1", "parents": [ "000d1cc1829f938c87402fc2fd4bb5e8daed6b52" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 25 17:13:26 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 25 20:57:16 2011 -0700" }, "message": "checkpatch: make utf-8 test --strict\n\nSome patches are sent in using ISO-8859 or even Windows codepage 1252.\n\nMake checkpatch accept these by default and only emit the \"Invalid UTF-8\"\nmessage when using --strict.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "000d1cc1829f938c87402fc2fd4bb5e8daed6b52", "tree": "b893c94009680dc51556ba0838815b7c9f9b6236", "parents": [ "39b7e2878e783af027ddd3530f7a0abec330905d" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 25 17:13:25 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 25 20:57:16 2011 -0700" }, "message": "checkpatch.pl: add ability to ignore various messages\n\nSome users would like the ability to not emit some of the messages that\ncheckpatch produces. This can make it easier to use checkpatch in other\nprojects and integrate into scm hook scripts.\n\nAdd command line option to \"--ignore\" various message types. Add option\n--show-types to emit the \"type\" of each message. Categorize all ERROR,\nWARN and CHK messages with types.\n\nAdd optional .checkpatch.conf file to store default options.\n3 paths are searched for .checkpatch.conf\n . customized per-tree configurations\n $HOME user global configuration when per-tree configs don\u0027t exist\n ./scripts lk defaults to override script\nThe .conf file can contain any valid command-line argument and\nthe contents are prepended to any additional command line arguments.\nMultiple lines may be used, blank lines are ignored, # is a comment.\n\nUpdate \"false positive\" output for readability.\n\nUpdate version to 0.32\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: Mike Frysinger \u003cvapier@gentoo.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "39b7e2878e783af027ddd3530f7a0abec330905d", "tree": "f8b5adf97fc9806310c560e12463d1cb56c20b2f", "parents": [ "2011247550c1b903a9ecd68f6eb3e9e7b7b07f52" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 25 17:13:24 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 25 20:57:16 2011 -0700" }, "message": "checkpatch: add a \"prefer __aligned\" check\n\nPrefer the use of __aligned(size) over __attribute__((__aligned___(size)))\n\nLink: http://lkml.kernel.org/r/20110609094526.1571774c.akpm@linux-foundation.org\n\nSuggested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" } ], "next": "2011247550c1b903a9ecd68f6eb3e9e7b7b07f52" }