)]}' { "log": [ { "commit": "495e9d84607cda966ba6d223d5eb9df0070cd21a", "tree": "208667895c3646fe4fa1bb7322d0ed1f51880ca5", "parents": [ "5abe257af8b95857b95fa0ba694530b446ae32d8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Dec 20 15:05:37 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Dec 20 17:40:20 2012 -0800" }, "message": "checkpatch: warn on uapi #includes that #include \u003cuapi/...\n\nAvoid specifying internal uapi #include paths with uapi/... as\nuserspace should not use and never see that.\n\nNeaten message line wrapping above.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: David Howells \u003cdhowells@redhat.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "323c1260ba2c4b5c4b2a1e9ab6657cde54ccf554", "tree": "fcc114327e37918e20e42a2f4ed00e3b7f158cec", "parents": [ "74349bccedb3e34b4f1fd9c7efd2dda7905e3335" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:07 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: warn on CamelCase variable names\n\nStore the camelcase variables in a hash and only emit a warning on the\nfirst use of each new variable.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "74349bccedb3e34b4f1fd9c7efd2dda7905e3335", "tree": "7dec12471c55dbaa90c78ab67ea3e23788565cba", "parents": [ "6b7eaf6e1428be33f731287de963862e3846cd42" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:05 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: add support for floating point constants\n\nEven though the kernel doesn\u0027t support using floating point constants,\nadd a regex for them.\n\nSupport forms like: 0x123p1, 123e-1, 1.23, 1.5e23f\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6b7eaf6e1428be33f731287de963862e3846cd42", "tree": "19628f1233f2e758cbd138d1c7a2d41701244b32", "parents": [ "d1e2ad07e78c4bbac9fce4d2e3c0fe60bce091d8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:02 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: find hex constants as a single IDENT\n\nHexadecimal values are current found in 2 parts. A hex constant like\n0x123456abcdef is found as 0 and then x123456abcdef and later coalesced.\n\nInstead, reverse the order of the 2 searches in $Constant to find 0x\nfirst, then 0 so that the entire hex constant is found all at once.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d1e2ad07e78c4bbac9fce4d2e3c0fe60bce091d8", "tree": "41193684d79788aef5d00c817ba570c27c7de02f", "parents": [ "88982fea52d0115d44b77619afef576f24cdb844" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:01 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: add --strict test for switch/default missing break\n\nswitch default case is sometimes written as \"default:;\". This can cause\nnew cases added below the default to be defective.\n\nSuggest adding a break; after empty default cases to avoid fallthrough\ndefects.\n\nFixed indentation in the other semicolon test above it.\n\nSuggested-by: Peter Senna Tschudin \u003cpeter.senna@gmail.com\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "88982fea52d0115d44b77619afef576f24cdb844", "tree": "a31942d9f3ec40c520b6c963e726c705e47b7db3", "parents": [ "0979ae66464bd9793c6701861bccb21f9f118a52" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:00 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: warn when declaring \"struct spinlock foo;\"\n\nspinlock_t should always be used.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: \"Luis R. Rodriguez\" \u003cmcgrof@do-not-panic.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0979ae66464bd9793c6701861bccb21f9f118a52", "tree": "e2e7a6f513aba1c433dbad1ccbb24adb834ca406", "parents": [ "481eb486a88c9b068f0168ac4c21291802720933" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:59 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: Add --strict messages for blank lines around braces\n\nBlank lines around braces are not unnecessary. Emit a message on the use\nof these blank lines only when using --strict.\n\nint foo(int bar)\n{\n\n\tsomething or other....\n\n}\n\nis generally written in the kernel as:\n\nint foo(int bar)\n{\n\tsomething or other...\n}\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "481eb486a88c9b068f0168ac4c21291802720933", "tree": "ded9373e9ace9887f28c8bf3ea1810c600a6b059", "parents": [ "6cd7f3869c925622bbf420e1107a026d91dbd7f2" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:56 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: extend line continuation test\n\nPreprocessor directives and asm statements should be allowed to have a\nline continuation.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nTested-by: Jingoo Han \u003cjg1.han@samsung.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6cd7f3869c925622bbf420e1107a026d91dbd7f2", "tree": "23c356d279579726f68ddfdebe54d4e469e25572", "parents": [ "03df4b51f33e1fdd35fe7bc19f1f450726395207" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:54 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: allow control over line length warning, default remains 80\n\nSome projects might want a longer line length so allow a command line\n--max-line-length\u003dn control over the long line warnings. The default line\nlength is 80.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Constantine Shulyupin \u003cconst@makelinux.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "03df4b51f33e1fdd35fe7bc19f1f450726395207", "tree": "13994b0b62313a4e0f93c1f6c349b01c53ea958e", "parents": [ "78e3f1f01d23c1a0d5828669d35afa2e7951987d" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Dec 17 16:01:52 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: consolidate if (foo) bar(foo) checks and add debugfs_remove\n\nConsolidate the if (foo) bar(foo) detectors into a single check. Add\ndebugfs_remove and family.\n\nBased on a patch by Constantine Shulyupin.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Constantine Shulyupin \u003cconst@MakeLinux.com\u003e.\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "78e3f1f01d23c1a0d5828669d35afa2e7951987d", "tree": "60221a5006aaec5e0a810facb8a223b910f92175", "parents": [ "1ba8dfd17ead04de18bfca7b68c2a144c8be736a" ], "author": { "name": "Tao Ma", "email": "boyu.mt@taobao.com", "time": "Mon Dec 17 16:01:49 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: remove reference to feature-removal-schedule.txt\n\nIn commit 9c0ece069b32 (\"Get rid of Documentation/feature-removal.txt\"),\nLinus removes feature-removal-schedule.txt from Documentation, but there\nis still some reference to this file. So remove them.\n\nSigned-off-by: Tao Ma \u003cboyu.mt@taobao.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1ba8dfd17ead04de18bfca7b68c2a144c8be736a", "tree": "d9f42871b6809cd40e03557bc243a11d6039dd20", "parents": [ "5023d3472d444747bfa12e9798d7993e7efb8287" ], "author": { "name": "Kees Cook", "email": "keescook@chromium.org", "time": "Mon Dec 17 16:01:48 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:18 2012 -0800" }, "message": "checkpatch: warn about using CONFIG_EXPERIMENTAL\n\nThis config item has not carried much meaning for a while now and is\nalmost always enabled by default. As agreed during the Linux kernel\nsummit, it is being removed. This will discourage future addition of\nCONFIG_EXPERIMENTAL while it is being phased out.\n\nSigned-off-by: Kees Cook \u003ckeescook@chromium.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5023d3472d444747bfa12e9798d7993e7efb8287", "tree": "384454623fc76da468021e0d58846debec536014", "parents": [ "0ad50c3896afbb3c103409a18260e601b87a744c" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:47 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:18 2012 -0800" }, "message": "checkpatch: warn on unnecessary line continuations\n\nWhen the previous line is not a line continuation and the current line has\na line continuation but is not a #define, emit a warning.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Peter Hurley \u003cpeter@hurleysoftware.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c24f9f195edf8c7f78eff1081cdadd26bd272ee3", "tree": "27063fcac4f5fd20054b3ca45fe15d6c39762876", "parents": [ "3d70f8c617a436c7146ecb81df2265b4626dfe89" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Nov 08 15:53:29 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Nov 09 06:41:46 2012 +0100" }, "message": "checkpatch: improve network block comment style checking\n\nSome comment styles in net and drivers/net are flagged inappropriately.\n\nAvoid proclaiming inline comments like:\n\tint a \u003d b;\t/* some comment */\nand block comments like:\n\t/*********************\n\t * some comment\n\t ********************/\nare defective.\n\nTested with\n$ cat drivers/net/t.c\n/* foo */\n\n/*\n * foo\n */\n\n/* foo\n */\n\n/* foo\n * bar */\n\n/****************************\n * some long block comment\n ***************************/\n\nstruct foo {\n\tint bar;\t/* another test */\n};\n$\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReported-by: Larry Finger \u003cLarry.Finger@lwfinger.net\u003e\nCc: David Miller \u003cdavem@davemloft.net\u003e\nCc: Stephen Hemminger \u003cshemminger@vyatta.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a0a0a7a94c765f7219b57fa3b79389901bb0bc99", "tree": "8830687bde899b15cf1764aee396a15c8dee8fb9", "parents": [ "c4ff1b5f8bf09d77d7329cbff224f0237646c90e" ], "author": { "name": "Kees Cook", "email": "keescook@chromium.org", "time": "Thu Oct 04 17:13:38 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:05:00 2012 +0900" }, "message": "checkpatch: fix name of \"MODULE_PARM_DESC\"\n\nFix macro name in checkpatch: s/PARAM/PARM/.\n\nSigned-off-by: Kees Cook \u003ckeescook@chromium.org\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "058806007450489bb8f457b275e5cb5c946320c1", "tree": "7c99dc9728618bec0eccd7578ad493ff312e7dc1", "parents": [ "8f26b8376faad26372a579606ecbd77b20e99dd8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Oct 04 17:13:35 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:04:59 2012 +0900" }, "message": "checkpatch: check networking specific block comment style\n\nIn an effort to get fewer checkpatch reviewer corrections, add a\nnetworking specific style test for the preferred networking comment style.\n\n\t/* The preferred style for block comments in\n\t * drivers/net/... and net/... is like this\n\t */\n\nThese tests are only used in net/ and drivers/net/\n\nTested with:\n\n$ cat drivers/net/t.c\n\n/* foo */\n\n/*\n * foo\n */\n\n/* foo\n */\n\n/* foo\n * bar */\n$ ./scripts/checkpatch.pl -f drivers/net/t.c\nWARNING: networking block comments don\u0027t use an empty /* line, use /* Comment...\n#4: FILE: net/t.c:4:\n+\n+/*\n\nWARNING: networking block comments put the trailing */ on a separate line\n#12: FILE: net/t.c:12:\n+ * bar */\n\ntotal: 0 errors, 2 warnings, 12 lines checked\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: \"Allan, Bruce W\" \u003cbruce.w.allan@intel.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: David Miller \u003cdavem@davemloft.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8f26b8376faad26372a579606ecbd77b20e99dd8", "tree": "50fc1463508ac9fd91a0b437284d84a81918f903", "parents": [ "fa64205df9dfd7b7662cc64a7e82115c00e428e5" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Oct 04 17:13:32 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:04:59 2012 +0900" }, "message": "checkpatch: update suggested printk conversions\n\nDirect conversion of printk(KERN_\u003cLEVEL\u003e... to pr_\u003clevel\u003e isn\u0027t the\npreferred conversion when a struct net_device or struct device is\navailable.\n\nHint that using netdev_\u003clevel\u003e or dev_\u003clevel\u003e is preferred to using\npr_\u003clevel\u003e. Add netdev_dbg and dev_dbg variants too.\n\nMiscellaneous whitespace neatening of a misplaced close brace.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Greg KH \u003cgregkh@linuxfoundation.org\u003e\nCc: Dan Carpenter \u003cdan.carpenter@oracle.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fa64205df9dfd7b7662cc64a7e82115c00e428e5", "tree": "4df37058666c34ed88a3d7c0ffae2330b8b7eddf", "parents": [ "8290e2d2dcbf0d379d4b1379e17916515ee20a39" ], "author": { "name": "Pasi Savanainen", "email": "pasi.savanainen@nixu.com", "time": "Thu Oct 04 17:13:29 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:04:59 2012 +0900" }, "message": "checkpatch: check utf-8 content from a commit log when it\u0027s missing from charset\n\nCheck that a commit log doesn\u0027t contain UTF-8 when a mail header\nexplicitly defines a different charset, like\n\n\u0027Content-Type: text/plain; charset\u003d\"us-ascii\"\u0027\n\nSigned-off-by: Pasi Savanainen \u003cpasi.savanainen@nixu.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ac8e97f8a742828daa1d9de37f6e635888f8d71e", "tree": "d2eae9170d79c302d99c0d7a27da134060fde69e", "parents": [ "eb48c071464757414538c68a6033c8f8c15196f8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Aug 21 16:15:53 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Aug 21 16:45:02 2012 -0700" }, "message": "checkpatch: add control statement test to SINGLE_STATEMENT_DO_WHILE_MACRO\n\nCommit b13edf7ff2dd (\"checkpatch: add checks for do {} while (0) macro\nmisuses\") added a test that is overly simplistic for single statement\nmacros.\n\nMacros that start with control tests should be enclosed in a do {} while\n(0) loop.\n\nAdd the necessary control tests to the check.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nTested-by: Franz Schrober \u003cfranzschrober@yahoo.de\u003e\nCc: Stephen Rothwell \u003csfr@canb.auug.org.au\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b13edf7ff2dd0fef95e981170fa71fa6b60421b0", "tree": "cdfbfb5429b089d1e41f9551bf112a8236fae078", "parents": [ "66c80b6077256898df948ac6acf547b47ddb1fcf" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:24 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: add checks for do {} while (0) macro misuses\n\nThese types of macros should not be used for either a single statement\nnor should the macro end with a semi-colon.\n\nAdd tests for these conditions.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "66c80b6077256898df948ac6acf547b47ddb1fcf", "tree": "20982260f1fd1e875188b24ddd598e77544e5354", "parents": [ "4a273195a551a27a9a3ebed072c8df16c853da7f" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:22 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: Add acheck for use of sizeof without parenthesis\n\nKernel style uses parenthesis around sizeof.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4a273195a551a27a9a3ebed072c8df16c853da7f", "tree": "f6dd0354f66679adea5cab8aab0a620a6832e181", "parents": [ "ce0338df3c9a43e709b8a478265b32b9edcc7ccc" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:20 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: check usleep_range() arguments\n\nusleep_range() shouldn\u0027t use the same args for min and max.\n\nReport it when it happens and when both args are decimal and min \u003e max.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Yuval Mintz \u003cyuvalmin@broadcom.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ce0338df3c9a43e709b8a478265b32b9edcc7ccc", "tree": "7f6c7047b4e1215f11ce2f774091237c7b5fdeb8", "parents": [ "b34a26f3158cca932b6f1427b97fe12c7838ee68" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:18 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: test for non-standard signatures\n\nWarn on non-standard signature styles.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b34a26f3158cca932b6f1427b97fe12c7838ee68", "tree": "e1c5e08259b56d444f6797c8e3e7b88cd4df64d5", "parents": [ "4ed940d4c34c21a1a356969a923f2815d608e0bf" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:16 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: Update alignment check\n\nParenthesis alignment doesn\u0027t correctly check an existing line after an\ninserted or modified line with an open parenthesis.\n\nFix it.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "243f3803cf2a3665092c5fd6f924f453694681a6", "tree": "a05005eb618c2770a2e56c644ae04d8e36c58c89", "parents": [ "9a4cad4e25b91f48494f13fce3d25ea44bec7472" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu May 31 16:26:09 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu May 31 17:49:27 2012 -0700" }, "message": "checkpatch: suggest pr_\u003clevel\u003e over printk(KERN_\u003cLEVEL\u003e\n\nSuggest the shorter pr_\u003clevel\u003e instead of printk(KERN_\u003cLEVEL\u003e.\n\nPrefer to use pr_\u003clevel\u003e over bare printks.\nPrefer to use pr_warn over pr_warning.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nCc: Theodore Ts\u0027o \u003ctytso@mit.edu\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9a4cad4e25b91f48494f13fce3d25ea44bec7472", "tree": "6b7cbfdf1517792f826f23408b8ca023ee2b3229", "parents": [ "133fd9f5cda2d86904126f4b9fa4e8f4330c9569" ], "author": { "name": "Eric Nelson", "email": "eric.nelson@boundarydevices.com", "time": "Thu May 31 16:26:09 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu May 31 17:49:27 2012 -0700" }, "message": "checkpatch: check for whitespace before semicolon at EOL\n\nRequires --strict option during invocation:\n\t~/linux$ scripts/checkpatch --strict foo.patch\n\nThis tests for a bad habits of mine like this:\n\n\treturn 0 ;\n\nNote that it does allow a special case of a bare semicolon\nfor empty loops:\n\n\twhile (foo())\n\t\t;\n\nSigned-off-by: Eric Nelson \u003ceric.nelson@boundarydevices.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c06a9ebdb7a4f4823d4225fe789d8c20a1d534eb", "tree": "9909d3aac2349fd6636fd1fdd0d4480869978b5b", "parents": [ "e816b57a337ea3b755de72bec38c10c864f23015" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Apr 16 13:35:11 2012 -0600" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 16 12:44:38 2012 -0700" }, "message": "checkpatch: revert --strict test for net/ and drivers/net block comment style\n\nRevert the --strict test for the old preferred block\ncomment style in drivers/net and net/\n\nReported-by: Ingo Molnar \u003cmingo@kernel.org\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ca56dc098caf93b5437cd6c4ee49f02aa18f84d6", "tree": "0bc689836c48cf91fcc5ca37db7753b5fa7d9fa3", "parents": [ "6712d85852b348d07301c7480f7eb3312d329143" ], "author": { "name": "Josh Triplett", "email": "josh@joshtriplett.org", "time": "Fri Mar 23 15:02:21 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:37 2012 -0700" }, "message": "checkpatch: check for quoted strings broken across lines\n\ncheckpatch already makes an exception to the 80-column rule for quoted\nstrings, and Documentation/CodingStyle recommends not splitting quoted\nstrings across lines, because it breaks the ability to grep for the\nstring. Rather than just permitting this, actively warn about quoted\nstrings split across lines.\n\nTest case:\n\nvoid context(void)\n{\n\tstruct { unsigned magic; const char *strdata; } foo[] \u003d {\n\t\t{ 42, \"these strings\"\n\t\t \"do not produce warnings\" },\n\t\t{ 256, \"though perhaps\"\n\t\t \"they should\" },\n\t};\n\tpr_err(\"this string\"\n\t \" should produce a warning\\n\");\n\tpr_err(\"this multi-line string\\n\"\n\t \"should not produce a warning\\n\");\n\tasm (\"this asm\\n\\t\"\n\t \"should not produce a warning\");\n}\n\nResults of checkpatch on that test case:\n\nWARNING: quoted string split across lines\n+\t \" should produce a warning\\n\");\n\ntotal: 0 errors, 1 warnings, 15 lines checked\n\nSigned-off-by: Josh Triplett \u003cjosh@joshtriplett.org\u003e\nAcked-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6712d85852b348d07301c7480f7eb3312d329143", "tree": "dbb4fdfc2dcafb9e22a2a5daed673fb172721605", "parents": [ "2c92488ab29886d08766c054afc8dd0f19c724f1" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 23 15:02:20 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:37 2012 -0700" }, "message": "checkpatch: whitespace - add/remove blank lines\n\nAdd blank lines between a few tests, remove an extraneous one.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2c92488ab29886d08766c054afc8dd0f19c724f1", "tree": "c1a42d6c825de9b0f3bf239d9a1a086a4b4422ce", "parents": [ "aad4f61498314d41d047ea2161b7bd7237b72d33" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 23 15:02:20 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:37 2012 -0700" }, "message": "checkpatch: warn on use of yield()\n\nUsing yield() is generally wrong. Warn on its use.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Peter Zijlstra \u003ca.p.zijlstra@chello.nl\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "aad4f61498314d41d047ea2161b7bd7237b72d33", "tree": "503836c82abeaed36ad119538fa3cbb7b8d94b24", "parents": [ "b337d8b82f235d0212f7adcaeb431fd4e688bb98" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 23 15:02:19 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:37 2012 -0700" }, "message": "checkpatch: add --strict tests for braces, comments and casts\n\nAdd some more subjective --strict tests.\n\nAdd a test for block comments that start with a blank line followed only\nby a line with just the comment block initiator. Prefer a blank line\nfollowed by /* comment...\n\nAdd a test for unnecessary spaces after a cast.\n\nAdd a test for symmetric uses of braces in if/else blocks.\nIf one branch needs braces, then all branches should use braces.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b337d8b82f235d0212f7adcaeb431fd4e688bb98", "tree": "1caccc45dbd1edfec3ff4d02e268f76444330ccf", "parents": [ "fd1b57ac73f169a5ba7a9569989aad40184f6340" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Mar 23 15:02:18 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: add [] to type extensions\n\nAdd [] to a type extensions. Fixes false positives on:\n\n .attrs \u003d (struct attribute *[]) {\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fd1b57ac73f169a5ba7a9569989aad40184f6340", "tree": "7a188a1f50c00a86e790acc406fb96db45294850", "parents": [ "e45bab8ebfee65ba89b228c1e7c64a6cb0812124" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Mar 23 15:02:18 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: high precedence operators do not require additional parentheses in #defines\n\nWith any very high precedence operator it is not necessary to enforce\nadditional parentheses around simple negated expressions. This prevents\nus requesting further perentheses around the following:\n\n #define PMEM_IS_FREE(id, index) !(pmem[id].bitmap[index].allocated)\n\nFor now add logical and bitwise not and unary minus.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e45bab8ebfee65ba89b228c1e7c64a6cb0812124", "tree": "fe61be22fa4438d5bd132712e730daca9cbf341b", "parents": [ "b9df76ac76da351cd4f6ba52369e9a64e9ab686d" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Mar 23 15:02:18 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: handle string concatenation in simple #defines\n\nAdjacent strings indicate concatentation, therefore look at identifiers\ndirectly adjacent to literal strings as strings too. This allows us to\nbetter detect the form below and accept it as a simple constant:\n\n #define pr_fmt(fmt) KBUILD_MODNAME \": \" fmt\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b9df76ac76da351cd4f6ba52369e9a64e9ab686d", "tree": "b02d82a012dbf249d8b8f89b530681eaa26e52bd", "parents": [ "daebc534ac15f991961a5bb433e515988220e9bf" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Mar 23 15:02:17 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: allow simple character constants in #defines\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "daebc534ac15f991961a5bb433e515988220e9bf", "tree": "add72230235f44a56111cad80913985ad24aaf6d", "parents": [ "11232688ec41a507cdb476fc4e88aff8a3a34c3c" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Fri Mar 23 15:02:17 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: catch [ ... ] usage when not at the beginning of definition\n\nHandle the [ A ... B ] form deeper into a definition, for example:\n\n static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] \u003d {\n\t {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] \u003d 0 },\n\t {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] \u003d 0 },\n };\n\nReported-by: Marek Vasut \u003cmarek.vasut@gmail.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "11232688ec41a507cdb476fc4e88aff8a3a34c3c", "tree": "4b8aa11d480277531d3c96cf7acf5180540269d8", "parents": [ "d1fe9c099cecc6e49324355f1b15573e9dbbe0f9" ], "author": { "name": "Artem Bityutskiy", "email": "dedekind1@gmail.com", "time": "Fri Mar 23 15:02:17 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch.pl: be silent when -q and --ignore is given\n\nFix checkpatch.pl when both -q and --ignore are given and prevents it from\nprinting a\n\nNOTE: Ignored message types: blah\n\nmessages.\n\nE.g., if I use -q --ignore PREFER_PACKED,PREFER_ALIGNED, i see:\n\nNOTE: Ignored message types: PREFER_ALIGNED PREFER_PACKED\n\nIt makes no sense to print this when -q is given.\n\nSigned-off-by: Artem Bityutskiy \u003cartem.bityutskiy@linux.intel.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d1fe9c099cecc6e49324355f1b15573e9dbbe0f9", "tree": "3b9fc1b4ac53907623b73e4967fed8b1ead12a58", "parents": [ "6061d949dd984c762ee272a88e77699fa675d1c8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 23 15:02:16 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "checkpatch: add some --strict coding style checks\n\nArgument alignment across multiple lines should match the open\nparenthesis.\n\nLogical continuations should be at the end of the previous line, not the\nstart of a new line.\n\nThese are not required by CodingStyle so make the tests active only when\nusing --strict.\n\nImproved by some examples from Bruce Allen.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: \"Bruce W. Allen\" \u003cbruce.w.allan@intel.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6061d949dd984c762ee272a88e77699fa675d1c8", "tree": "2e19eecd34a716fc5ed9fa3f18a7db0a3edf6f5b", "parents": [ "97e834c5040b85e133d8d922111a62b2b853a406" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Mar 23 15:02:16 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Mar 23 16:58:36 2012 -0700" }, "message": "include/ and checkpatch: prefer __scanf to __attribute__((format(scanf,...)\n\nIt\u0027s equivalent to __printf, so prefer __scanf.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8eef05dd3e70233f3e391774d612dab44c3f023b", "tree": "dda65b15abaa42564d2e46424bfe6a7a73cc5681", "parents": [ "6bd113f1f4a8c0d05c4dbadb300319e0e3526db4" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Feb 03 15:20:39 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Feb 07 15:53:08 2012 -0800" }, "message": "checkpatch: Warn on code with 6+ tab indentation\n\nOverly indented code should be refactored.\n\nSuggest refactoring excessive indentation of of\nif/else/for/do/while/switch statements.\n\nFor example:\n\n$ cat t.c\n#include \u003cstdio.h\u003e\n#include \u003cstdlib.h\u003e\n\nint main(int argc, char **argv)\n{\n\n\tif (1)\n\t\tif (2)\n\t\t\tif (3)\n\t\t\t\tif (4)\n\t\t\t\t\tif (5)\n\t\t\t\t\t\tif (6)\n\t\t\t\t\t\t\tif (7)\n\t\t\t\t\t\t\t\tif (8)\n\t\t\t\t\t\t\t\t\t;\n\treturn 0;\n}\n\n$ ./scripts/checkpatch.pl -f t.c\nWARNING: Too many leading tabs - consider code refactoring\n#12: FILE: t.c:12:\n+\t\t\t\t\t\tif (6)\n\nWARNING: Too many leading tabs - consider code refactoring\n#13: FILE: t.c:13:\n+\t\t\t\t\t\t\tif (7)\n\nWARNING: Too many leading tabs - consider code refactoring\n#14: FILE: t.c:14:\n+\t\t\t\t\t\t\t\tif (8)\n\ntotal: 0 errors, 3 warnings, 17 lines checked\n\nt.c has style problems, please review.\n\nIf any of these errors are false positives, please report\nthem to the maintainer, see CHECKPATCH in MAINTAINERS.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "bfcb2cc798a14230d22b6dd999e2e680623de622", "tree": "dfa486a04620bd02e58b3cdcb8b06ee5da3014ac", "parents": [ "6b48db24e30d371bc54566667b82ca3d64aab80a" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:15 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: catch all occurences of type and cast spacing errors per line\n\nFix up type and cast spacing checks such that all occurences on a line are\nexamined and reported. For example the line below has a valid cast and a\nbad type, but currently we check the cast first which is good and stop:\n\n u16* bar \u003d (u16 *)baz;\n\nWe will also only report one of the errors in this example:\n\n u16* bar \u003d (u16*)bad;\n\nMove to iterating across all casts and all types, reporting any failure.\n\n[akpm@linux-foundation.org: coding-style fixes]\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6b48db24e30d371bc54566667b82ca3d64aab80a", "tree": "4532e530d3e97917dc8a82bfc1f23f91e9627150", "parents": [ "addcdcea99514bee64b5bf091ac9fd2fc5da65cf" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:13 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: typeof may have more complex arguments\n\ntypeof may have various more complex forms as its arguement, not just an\nidentifier. For now allow us to leak to the first close perenthesis \u0027)\u0027.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "addcdcea99514bee64b5bf091ac9fd2fc5da65cf", "tree": "effbf409bfc451203c0051f130ff263c52aa356e", "parents": [ "c81769fdc84ed7c6eb3cc5cecb194324a5e4c8ad" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:11 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: ensure cast type is unique in the context parser\n\nEnsure the cast type is unique in the context parser, we do not want them\nto detect as a comma \u0027,\u0027.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c81769fdc84ed7c6eb3cc5cecb194324a5e4c8ad", "tree": "bfa7973e16263c7993a54bd53e7a00f350f7d5cc", "parents": [ "e01886ada28741d7cb2cfb3224e9caccfbc1a2d5" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:10 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: fix complex macros handling of square brackets\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e01886ada28741d7cb2cfb3224e9caccfbc1a2d5", "tree": "ba401dddad6fffc2dc079e1449f20c2091195a41", "parents": [ "72f115f94d500fc72f78c5df8104a98f8b9cc273" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:08 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: fix \u0027return is not a function\u0027 square bracket handling\n\nWe are incorrectly matching square brackets \u0027[\u0027 and \u0027]\u0027 leading to false\npositives on more complex functions as below:\n\n return (dt3155_fbuffer[m]-\u003eready_head -\n\tdt3155_fbuffer[m]-\u003eready_len +\n\tdt3155_fbuffer[m]-\u003enbuffers)%\n\t(dt3155_fbuffer[m]-\u003enbuffers);\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "72f115f94d500fc72f78c5df8104a98f8b9cc273", "tree": "3c6b37bebd9b1f1671df4f8d0dcbe0f625b4a6a0", "parents": [ "87a53877185627b49a903023255425bda78f890c" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:06 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:51 2012 -0800" }, "message": "checkpatch: complex macro should allow the empty do while loop\n\nIt is common to stub out a function as below, this is triggering a complex\nmacro format incorrectly. Sort this out:\n\n #define cma_early_regions_reserve(reserve) do { } while (0)\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "87a53877185627b49a903023255425bda78f890c", "tree": "47809b22567658e1e17be1603358d06f79a8e99f", "parents": [ "a13858033a3a993147d190317cc9d709f0a1b819" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:04 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: fix EXPORT_SYMBOL handling following a function\n\nThe following fragment defeats the DEVICE_ATTR style handing, check for\nand ignore the close brace \u0027}\u0027 in this context:\n\n int foo()\n {\n }\n DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR,\n ata_scsi_lpm_show, ata_scsi_lpm_put);\n EXPORT_SYMBOL_GPL(dev_attr_link_power_management_policy);\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a13858033a3a993147d190317cc9d709f0a1b819", "tree": "2d82b609eeafc484a046faa4616f4ed67a31c27f", "parents": [ "3e469cdc08ac5d84b220f8fb76a090d158d5114f" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:03 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: only apply kconfig help checks for options which prompt\n\nThe intent of this check is to catch the options which the user will see\nand ensure they are properly described. It is also common for internal\nonly options to have a brief description. Allow this form.\n\nReported-by: Steven Rostedt \u003crostedt@goodmis.org\u003e\nTested-by: Steven Rostedt \u003crostedt@goodmis.org\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3e469cdc08ac5d84b220f8fb76a090d158d5114f", "tree": "fc35a9ca8593ddd2bf0e07ceb2f39e83ff06ff4c", "parents": [ "89a883530fe79939384a6c6ed893c719762c7c9c" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:01 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: optimise statement scanner when mid-statement\n\nIn the middle of a long definition or similar, there is no possibility of\nfinding a smaller sub-statement. Optimise this case by skipping statement\naquirey where there are no starts of statement (open brace \u0027{\u0027 or\nsemi-colon \u0027;\u0027). We are likely to scan slightly more than needed still\nbut this is safest.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "89a883530fe79939384a6c6ed893c719762c7c9c", "tree": "49d1dd395c3029ab6261c8d217f53642d77bdc0f", "parents": [ "d7c76ba7e58bc3ca674f20759c686535db484749" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:10:00 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: ## is not a valid modifier\n\nInserting a # into the modifiers list will incorrectly add the null string\nto the modifiers list, leading to an infinite loop. As neither of these\nis a valid modifier form simply ignore them.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nReported-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d7c76ba7e58bc3ca674f20759c686535db484749", "tree": "26066daabbfd375eb984da2d8d773ef230f62ddb", "parents": [ "554e165cf32610ec9596a183fa1b54a5707fc3cb" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Jan 10 15:09:58 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: improve memset and min/max with cast checking\n\nImprove the checking of arguments to memset and min/max tests.\n\nMove the checking of min/max to statement blocks instead of single line.\nChange $Constant to allow any case type 0x initiator and trailing ul\nspecifier. Add $FuncArg type as any function argument with or without a\ncast. Print the whole statement when showing memset or min/max messages.\nImprove the memset with 0 as 3rd argument error message.\n\nThere are still weaknesses in the $FuncArg and $Constant code as arbitrary\nparentheses and negative signs are not generically supported.\n\n[akpm@linux-foundation.org: fix per Andy]\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "554e165cf32610ec9596a183fa1b54a5707fc3cb", "tree": "027354f186b71c033929a5ecf8df80f131c9ce7b", "parents": [ "f74bd1942e04a0cedd1e9c8b331141e75add49c0" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:09:57 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: check for common memset parameter issues against statments\n\nMove the memset checks over to work against the statement. Also add\nchecks for 0 and 1 used as lengths. Generally these indicate badly\nordered parameters.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f74bd1942e04a0cedd1e9c8b331141e75add49c0", "tree": "76e1f8b1fdf0c1be748304d14f9aed353932fc26", "parents": [ "5f14d3bd87ef5f979ea64c1f0862534d71786db7" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Jan 10 15:09:54 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: correctly track the end of preprocessor commands in context\n\nWhen looking for a statement we currently run on through preprocessor\ncommands. This means that a header file with just definitions is parsed\nover and over again combining all of the lines from the current line to\nthe end of file leading to severe performance issues.\n\nFix up context accumulation to track preprocessor commands and stop when\nreaching the end of them. At the same time vastly simplify the #define\nhandling.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5f14d3bd87ef5f979ea64c1f0862534d71786db7", "tree": "88982b950031e877156bf17c3755d9a128b336f8", "parents": [ "270c49a088ae58d4b817861bb04bfec63b0966db" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Jan 10 15:09:52 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: prefer __printf over __attribute__((format(printf,...)))\n\nAdd a warn for not using __printf.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "270c49a088ae58d4b817861bb04bfec63b0966db", "tree": "4c08b86b0be13a7d256e1f7a83f87ebca9d20b9d", "parents": [ "96b62067f970ff529c98913311d33f4b57b453dc" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Jan 10 15:09:50 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jan 10 16:30:50 2012 -0800" }, "message": "checkpatch: update signature \"might be better as\" warning\n\nemail header lines can look like signature tags. It\u0027s valid to have\nmultiple email recipients on a single line but not valid to have multiple\nsignatures on a single line.\n\nValidate signatures only when not in the email headers.\n\nClear the $in_commit_log flag when the patch filename appears.\n\nAdd \u0027-\u0027 to the valid chars in a message header for headers\nlike \"Message-Id:\" and \"In-Reply-To:\".\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReported-by: Julia Lawall \u003cjulia.lawall@lip6.fr\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "addd8c92cf55bba578b8a56e0f717a0a74b31008", "tree": "2329201d816460d4baa71c8463c761034f99b1eb", "parents": [ "a84f6aa68e35a911c28e5871c87356dce3607b40", "c68e58783f20d3eb32b99e1962b26462f2e3195a" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Nov 06 18:53:33 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Nov 06 18:53:33 2011 -0800" }, "message": "Merge branch \u0027misc\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild\n\n* \u0027misc\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild:\n script/checkpatch.pl: warn about deprecated use of EXTRA_{A,C,CPP,LD}FLAGS\n tags, powerpc: Update tags.sh to support _GLOBAL symbols\n scripts: add extract-vmlinux\n" }, { "commit": "15662b3e8644905032c2e26808401a487d4e90c1", "tree": "0eae1a68779bd314459a2bff55c43e266329015d", "parents": [ "67d0a0754455f89ef3946946159d8ec9e45ce33a" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Oct 31 17:13:12 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Oct 31 17:30:57 2011 -0700" }, "message": "checkpatch: add a --strict check for utf-8 in commit logs\n\nSome find using utf-8 in commit logs inappropriate.\n\nSome patch commit logs contain unintended utf-8 characters when doing\nthings like copy/pasting compilation output.\n\nLook for the start of any commit log by skipping initial lines that look\nlike email headers and \"From: \" lines.\n\nStop looking for utf-8 at the first signature line.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "67d0a0754455f89ef3946946159d8ec9e45ce33a", "tree": "297c25551f6523bc8284c40642491113e72b350e", "parents": [ "fc23af34b00ef444eec088f744983b9ca6c7f5d1" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Oct 31 17:13:10 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Oct 31 17:30:57 2011 -0700" }, "message": "kernel.h/checkpatch: mark strict_strto\u003cfoo\u003e and simple_strto\u003cfoo\u003e as obsolete\n\nMark obsolete/deprecated strict_strto\u003cfoo\u003e and simple_strto\u003cfoo\u003e functions\nand macros as obsolete.\n\nUpdate checkpatch to warn about their use.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e060c38434b2caa78efe7cedaff4191040b65a15", "tree": "407361230bf6733f63d8e788e4b5e6566ee04818", "parents": [ "10e4ac572eeffe5317019bd7330b6058a400dfc2", "cc39c6a9bbdebfcf1a7dee64d83bf302bc38d941" ], "author": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Thu Sep 15 15:08:05 2011 +0200" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Thu Sep 15 15:08:18 2011 +0200" }, "message": "Merge branch \u0027master\u0027 into for-next\n\nFast-forward merge with Linus to be able to merge patches\nbased on more recent version of the tree.\n" }, { "commit": "699324871fcc3650f2023c5e36cb119a92d7894b", "tree": "7115a8183a4fd00b6f0ea1ae3b8f3dfbcf1c454b", "parents": [ "ca4a04cf3dd0cecb5e7188ed7796cc55fc13aeb1" ], "author": { "name": "Justin P. Mattock", "email": "justinmattock@gmail.com", "time": "Tue Jul 26 23:06:29 2011 -0700" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Thu Sep 15 14:50:49 2011 +0200" }, "message": "treewide: remove extra semicolons from various parts of the kernel\n\nThis is a resend from the original, changing the title from PATCH to\nRFC(since this is a review for commit, and I should have put that the first go around).\nand also removing some of the commit\u0027s with ia64 and bash since it is significant.\nlet me know if I might have missed anything etc..\n\nSigned-off-by: Justin P. Mattock \u003cjustinmattock@gmail.com\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "c68e58783f20d3eb32b99e1962b26462f2e3195a", "tree": "b77e91da189e7df141cea7f775328f3968cc27a6", "parents": [ "9c65426ad2cce12a2d72cdb42aa08f7ce946065d" ], "author": { "name": "Arnaud Lacombe", "email": "lacombar@gmail.com", "time": "Mon Aug 15 01:07:14 2011 -0400" }, "committer": { "name": "Michal Marek", "email": "mmarek@suse.cz", "time": "Wed Aug 31 16:43:44 2011 +0200" }, "message": "script/checkpatch.pl: warn about deprecated use of EXTRA_{A,C,CPP,LD}FLAGS\n\nUsage of these flags has been deprecated for nearly 4 years by:\n\n commit f77bf01425b11947eeb3b5b54685212c302741b8\n Author: Sam Ravnborg \u003csam@neptun.(none)\u003e\n Date: Mon Oct 15 22:25:06 2007 +0200\n\n kbuild: introduce ccflags-y, asflags-y and ldflags-y\n\nMoreover, these flags (at least EXTRA_CFLAGS) have been documented for command\nline use. By default, gmake(1) do not override command line setting, so this is\nlikely to result in build failure or unexpected behavior.\n\nWarn about their introduction in Makefile or Kbuild files.\n\nCc: Sam Ravnborg \u003csam@ravnborg.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Arnaud Lacombe \u003clacombar@gmail.com\u003e\nSigned-off-by: Michal Marek \u003cmmarek@suse.cz\u003e\n" }, { "commit": "30ecad51849ae132dc6ef6ddb62d499c7257515b", "tree": "cf6781cde6f1929c93c2d3c393188257aa7031e9", "parents": [ "3d1c2f72a9464c9880054194af0c041d7beb9124" ], "author": { "name": "Hui Zhu", "email": "teawater@gmail.com", "time": "Thu Aug 25 15:59:08 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Aug 25 16:25:33 2011 -0700" }, "message": "checkpatch: add missing WARN argument for min_t and max_t tests\n\nThe test for bad usage of min_t() and max_t() is missing the --ignore\ntype. Add it.\n\nSigned-off-by: Hui Zhu \u003cteawater@gmail.com\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6e60c02e9d9427f59842192bdb123cbeaf8bc9a0", "tree": "6cd57dfec304a5cb049173dac6050bb0f13e6876", "parents": [ "34d99219726ff4d3425b360d1e8d081627a73a00" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 25 17:13:27 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 25 20:57:16 2011 -0700" }, "message": "checkpatch.pl: update $logFunctions\n\nPrevious behavior allowed only alphabetic prefixes like pr_info to exceed\nthe 80 column line length limit.\n\nath6kl wants to add a digit into the prefix, so allow numbers as well as\ndigits in the \u003cprefix\u003e_\u003clevel\u003e printks.\n\n\u003cprefix\u003e_\u003clevel\u003e_ratelimited and \u003cprefix\u003e_\u003clevel\u003e_once and WARN_RATELIMIT\nand WARN_ONCE may now exceed 80 cols.\n\nAdd missing \u003cprefix\u003e_printk type for completeness.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Kalle Valo \u003ckvalo@qca.qualcomm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "34d99219726ff4d3425b360d1e8d081627a73a00", "tree": "30d9d2c477c984d7be0aa13dc93c19189649e7f1", "parents": [ "000d1cc1829f938c87402fc2fd4bb5e8daed6b52" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 25 17:13:26 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 25 20:57:16 2011 -0700" }, "message": "checkpatch: make utf-8 test --strict\n\nSome patches are sent in using ISO-8859 or even Windows codepage 1252.\n\nMake checkpatch accept these by default and only emit the \"Invalid UTF-8\"\nmessage when using --strict.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "000d1cc1829f938c87402fc2fd4bb5e8daed6b52", "tree": "b893c94009680dc51556ba0838815b7c9f9b6236", "parents": [ "39b7e2878e783af027ddd3530f7a0abec330905d" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 25 17:13:25 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 25 20:57:16 2011 -0700" }, "message": "checkpatch.pl: add ability to ignore various messages\n\nSome users would like the ability to not emit some of the messages that\ncheckpatch produces. This can make it easier to use checkpatch in other\nprojects and integrate into scm hook scripts.\n\nAdd command line option to \"--ignore\" various message types. Add option\n--show-types to emit the \"type\" of each message. Categorize all ERROR,\nWARN and CHK messages with types.\n\nAdd optional .checkpatch.conf file to store default options.\n3 paths are searched for .checkpatch.conf\n . customized per-tree configurations\n $HOME user global configuration when per-tree configs don\u0027t exist\n ./scripts lk defaults to override script\nThe .conf file can contain any valid command-line argument and\nthe contents are prepended to any additional command line arguments.\nMultiple lines may be used, blank lines are ignored, # is a comment.\n\nUpdate \"false positive\" output for readability.\n\nUpdate version to 0.32\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: Mike Frysinger \u003cvapier@gentoo.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "39b7e2878e783af027ddd3530f7a0abec330905d", "tree": "f8b5adf97fc9806310c560e12463d1cb56c20b2f", "parents": [ "2011247550c1b903a9ecd68f6eb3e9e7b7b07f52" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 25 17:13:24 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 25 20:57:16 2011 -0700" }, "message": "checkpatch: add a \"prefer __aligned\" check\n\nPrefer the use of __aligned(size) over __attribute__((__aligned___(size)))\n\nLink: http://lkml.kernel.org/r/20110609094526.1571774c.akpm@linux-foundation.org\n\nSuggested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2011247550c1b903a9ecd68f6eb3e9e7b7b07f52", "tree": "afd2ca6683f7225d29df77fb4c19b81211c05a57", "parents": [ "165e72a6c374ed03c57d03c88406d32745e1add2" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 25 17:13:23 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 25 20:57:16 2011 -0700" }, "message": "checkpatch: validate signature styles and To: and Cc: lines\n\nSignatures have many forms and can sometimes cause problems if not in the\ncorrect format when using git send-email or quilt.\n\nTry to verify the signature tags and email addresses to use the generally\naccepted \"Signed-off-by: Full Name \u003cemail@domain.tld\u003e\" form.\n\nOriginal idea by Anish Kumar \u003canish198519851985@gmail.com\u003e\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Anish Kumar \u003canish198519851985@gmail.com\u003e\nCc: Nick Bowler \u003cnbowler@elliptictech.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "165e72a6c374ed03c57d03c88406d32745e1add2", "tree": "6ca776305899b6187c8ecb7560e2e07a524cd163", "parents": [ "7d2367af0b09f8028dc5c1b1919bb82d141c2afb" ], "author": { "name": "Sven Eckelmann", "email": "sven@narfation.org", "time": "Mon Jul 25 17:13:23 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 25 20:57:16 2011 -0700" }, "message": "checkpatch: add __rcu as a sparse modifier\n\nFix \"need consistent spacing around \u0027*\u0027\" error after a __rcu sparse\nannotation which was caused by the missing __rcu entry in the\ncheckpatch.pl internal list of sparse keywords.\n\nSigned-off-by: Sven Eckelmann \u003csven@narfation.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7d2367af0b09f8028dc5c1b1919bb82d141c2afb", "tree": "e2645027cae1b716443e2659bda5364cb101d4e0", "parents": [ "27c46a2546c75c6814562e85b751e3d64c188ad5" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 25 17:13:22 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 25 20:57:16 2011 -0700" }, "message": "checkpatch: suggest using min_t or max_t\n\nA common issue with min() or max() is using a cast on one or both of the\narguments when using min_t/max_t could be better.\n\nAdd cast detection to uses of min/max and suggest an appropriate use of\nmin_t or max_t instead.\n\nCaveat: This only works for min() or max() on a single line.\n It does not find min() or max() split across multiple lines.\n\nThis does find:\n\tmin((u32)foo, bar);\nBut it does not find:\n\tmax((unsigned long)foo,\n\t bar);\n\nSuggested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "17441227f6258fc379c6ebfe21c3eec43b6f0de3", "tree": "d38f88d97472ae33827fd8cd247e0cd5161c61ba", "parents": [ "ac5622418bbff9cd3dc607aa57dfb4f62a7f2043" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jun 15 15:08:17 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jun 15 20:03:59 2011 -0700" }, "message": "checkpatch: add warning for uses of printk_ratelimit\n\nWarn about uses of printk_ratelimit() because it uses a global state and\ncan hide subsequent useful messages.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Richard Weinberger \u003crichard@nod.at\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0fccc6221821e07366aa44bca112c4edb6d04dd7", "tree": "b99a4d1b7df909b4eb3a876cc6ec75d3641ea943", "parents": [ "b05317221b7607ba61ee921c31867ed08912aa46" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue May 24 17:13:41 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed May 25 08:39:56 2011 -0700" }, "message": "checkpatch: fix defect in printk(KERN_\u003cLEVEL\u003e 80 column exceptions\n\nCurrently, printk lines with a only KERN_PREFIX and a quoted string\nwithout a comma or close paren that exceed 80 columns are flagged with a\nwarning.\n\nie:\n\tprintk(KERN_WARNING \"some long string that extends beond 80 cols...\"\n\t \"and is continued on another line\\n\");\n\nAllow this form instead of emitting a warning.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b05317221b7607ba61ee921c31867ed08912aa46", "tree": "64f6d81875c75e438df461618b8441e0116a6eb9", "parents": [ "428e2fdc4ecee2312829e97549f99c12312f4faf" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue May 24 17:13:40 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed May 25 08:39:55 2011 -0700" }, "message": "checkpatch: add \u003cfoo\u003e_\u003clevel\u003e and MODULE_\u003cBAR\u003e to 80 column exceptions\n\nMany module or file local logging functions use specific prefixes other\nthan pr|dev|netdev. Allow all forms like foo_printk and foo_err to be\nlonger than 80 columns.\n\nAlso allow MODULE_\u003cBAR\u003e declarations to be longer than 80 columns.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "428e2fdc4ecee2312829e97549f99c12312f4faf", "tree": "5f5debb951822770cd6e325c6552e701a2874642", "parents": [ "5ca43f6c3b365024d889bc77064bb331f5a72a45" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue May 24 17:13:39 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed May 25 08:39:55 2011 -0700" }, "message": "checkpatch: add check for line continuations in quoted strings\n\nAdd a warning for unterminated quoted strings with line continuations as\nthese frequently add unwanted whitespace.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "25985edcedea6396277003854657b5f3cb31a628", "tree": "f026e810210a2ee7290caeb737c23cb6472b7c38", "parents": [ "6aba74f2791287ec407e0f92487a725a25908067" ], "author": { "name": "Lucas De Marchi", "email": "lucas.demarchi@profusion.mobi", "time": "Wed Mar 30 22:57:33 2011 -0300" }, "committer": { "name": "Lucas De Marchi", "email": "lucas.demarchi@profusion.mobi", "time": "Thu Mar 31 11:26:23 2011 -0300" }, "message": "Fix common misspellings\n\nFixes generated by \u0027codespell\u0027 and manually reviewed.\n\nSigned-off-by: Lucas De Marchi \u003clucas.demarchi@profusion.mobi\u003e\n" }, { "commit": "309c00c73f053a905d144b430d4fb55d811085e2", "tree": "2226c4b1c86395078abfccdb54b17be93ea6e8ad", "parents": [ "b0781216e7bff68aca2fbcd275b4db7531d1e22f" ], "author": { "name": "Dave Jones", "email": "davej@redhat.com", "time": "Tue Mar 22 16:34:44 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Mar 22 17:44:15 2011 -0700" }, "message": "checkpatch: warn about memset with swapped arguments\n\nBecause the second and third arguments of memset have the same type, it\nturns out to be really easy to mix them up.\n\nThis bug comes up time after time, so checkpatch should really be checking\nfor it at patch submission time.\n\nSigned-off-by: Dave Jones \u003cdavej@redhat.com\u003e\nCc: Steven Rostedt \u003crostedt@goodmis.org\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b0781216e7bff68aca2fbcd275b4db7531d1e22f", "tree": "04767f9d01945aab963bbc3b4ca90589ff9a854e", "parents": [ "984b203a7237d8d32090b48113c18eb8f824a2be" ], "author": { "name": "Mike Frysinger", "email": "vapier@gentoo.org", "time": "Tue Mar 22 16:34:43 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Mar 22 17:44:15 2011 -0700" }, "message": "scripts/checkpatch.pl: reset rpt_cleaners warnings\n\nIf you run checkpatch against multiple patches, and one of them has a\nwhitespace issue which can be helped via a script (rpt_cleaners), you will\nsee the same NOTE over and over for all subsequent patches. It makes it\nseem like those patches also have whitespace problems when in reality,\nthere\u0027s only one or two bad apples.\n\nSo reset rpt_cleaners back to 0 after we\u0027ve issued the note so that it\nonly shows up near the patch with the actual problems.\n\nSigned-off-by: Mike Frysinger \u003cvapier@gentoo.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "33ee3b2e2eb9b4b6c64dcf9ed66e2ac3124e748c", "tree": "25d70c021189efa0bcbdf4e84b3ca97a6c147246", "parents": [ "8a5700cd6754a3c88d2ea2f1d7a56f671987fc25" ], "author": { "name": "Alexey Dobriyan", "email": "adobriyan@gmail.com", "time": "Tue Mar 22 16:34:40 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Mar 22 17:44:14 2011 -0700" }, "message": "kstrto*: converting strings to integers done (hopefully) right\n\n1. simple_strto*() do not contain overflow checks and crufty,\n libc way to indicate failure.\n2. strict_strto*() also do not have overflow checks but the name and\n comments pretend they do.\n3. Both families have only \"long long\" and \"long\" variants,\n but users want strtou8()\n4. Both \"simple\" and \"strict\" prefixes are wrong:\n Simple doesn\u0027t exactly say what\u0027s so simple, strict should not exist\n because conversion should be strict by default.\n\nThe solution is to use \"k\" prefix and add convertors for more types.\nEnter\n\tkstrtoull()\n\tkstrtoll()\n\tkstrtoul()\n\tkstrtol()\n\tkstrtouint()\n\tkstrtoint()\n\n\tkstrtou64()\n\tkstrtos64()\n\tkstrtou32()\n\tkstrtos32()\n\tkstrtou16()\n\tkstrtos16()\n\tkstrtou8()\n\tkstrtos8()\n\nInclude runtime testsuite (somewhat incomplete) as well.\n\nstrict_strto*() become deprecated, stubbed to kstrto*() and\neventually will be removed altogether.\n\nUse kstrto*() in code today!\n\nNote: on some archs _kstrtoul() and _kstrtol() are left in tree, even if\n they\u0027ll be unused at runtime. This is temporarily solution,\n because I don\u0027t want to hardcode list of archs where these\n functions aren\u0027t needed. Current solution with sizeof() and\n __alignof__ at least always works.\n\nSigned-off-by: Alexey Dobriyan \u003cadobriyan@gmail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d04fa5a3ba06c3b7a1c4a6860d0fa4825507a755", "tree": "e17ac53c5bb9b60839d4722533fb0b6ba1c87027", "parents": [ "10389a15e25fd4784d42de7e0e3fc8c242f2011d" ], "author": { "name": "Thomas Gleixner", "email": "tglx@linutronix.de", "time": "Sun Jan 23 15:30:09 2011 +0100" }, "committer": { "name": "Thomas Gleixner", "email": "tglx@linutronix.de", "time": "Thu Jan 27 12:30:38 2011 +0100" }, "message": "locking: Remove deprecated lock initializers\n\nLast users are gone. Remove the left overs.\n\nSigned-off-by: Thomas Gleixner \u003ctglx@linutronix.de\u003e\n" }, { "commit": "3d130fd03e06672f7700e2cb694b29f9a98227ca", "tree": "65608fc8841362c586cdfd06b69389165753ae93", "parents": [ "88f8831c055858179a7844d9dd4ddd7d3621322e" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jan 12 17:00:00 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 08:03:11 2011 -0800" }, "message": "checkpatch.pl: add \"prefer __packed\" check\n\nThere\u0027s a __packed #define for __attribute__((packed)). Add a checkpatch\nto tell people about it.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "88f8831c055858179a7844d9dd4ddd7d3621322e", "tree": "b8f5c4cdb714ec2fbb7ecf4ca34fff6dbbeb304d", "parents": [ "c023e4734c3e8801e0ecb5e81b831d42a374d861" ], "author": { "name": "Dave Jones", "email": "davej@redhat.com", "time": "Wed Jan 12 16:59:59 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 08:03:11 2011 -0800" }, "message": "checkpatch: check for world-writeable sysfs/debugfs files\n\nExporting world writable sysfs/debugfs files is usually a bad thing. Warn\nabout it.\n\nSigned-off-by: Dave Jones \u003cdavej@redhat.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c023e4734c3e8801e0ecb5e81b831d42a374d861", "tree": "a497964957d6dd30baa52ffe7a175737599ebca0", "parents": [ "caf2a54f101a55ec318c2a20253a1977802f7de4" ], "author": { "name": "Florian Mickler", "email": "florian@mickler.org", "time": "Wed Jan 12 16:59:58 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 08:03:11 2011 -0800" }, "message": "checkpatch.pl: fix CAST detection\n\nWe should only claim that something is a cast if we did not encouter a\ntoken before, that did set av_pending.\n\nThis fixes the operator * in the line below to be detected as binary (vs\nunary).\n\nkmalloc(sizeof(struct alphatrack_ocmd) * true_size, GFP_KERNEL);\n\nReported-by: Audun Hoem \u003caudun.hoem@gmail.com\u003e\nSigned-off-by: Florian Mickler \u003cflorian@mickler.org\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "caf2a54f101a55ec318c2a20253a1977802f7de4", "tree": "0eaa61afa0af0754a42b8a1f5c642500c4a54026", "parents": [ "78c377d1b5e7ef15c8c307c2aa2511602a0829c3" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jan 12 16:59:56 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 13 08:03:11 2011 -0800" }, "message": "scripts/checkpatch.pl: add check for multiple terminating semicolons and casts of vmalloc\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4882720b267b7b1d1b0ce08334b205f0329d4615", "tree": "dd54880f84b7b7fb2bbdb529ffada434aca1e4d9", "parents": [ "45f4d0243525b6bc747c946937ced437b135a84d" ], "author": { "name": "Thomas Gleixner", "email": "tglx@linutronix.de", "time": "Tue Sep 07 14:34:01 2010 +0000" }, "committer": { "name": "Thomas Gleixner", "email": "tglx@linutronix.de", "time": "Sat Oct 30 12:12:50 2010 +0200" }, "message": "semaphore: Remove mutex emulation\n\nSemaphores used as mutexes have been deprecated for years. Now that\nall users are either converted to real semaphores or to mutexes remove\nthe cruft.\n\nSigned-off-by: Thomas Gleixner \u003ctglx@linutronix.de\u003e\nCc: Peter Zijlstra \u003cpeterz@infradead.org\u003e\nCc: Christoph Hellwig \u003chch@infradead.org\u003e\nLKML-Reference: \u003c20100907125057.562399240@linutronix.de\u003e\n\n" }, { "commit": "93ed0e2d07b25aff4db1d61bfbcd1e82074c0ad5", "tree": "7b0c7f31bbf7ca0f083c1372e2cf6ebc3eaac20a", "parents": [ "cb710eca6820493add0ddd3d7e8e3ee53f2b6e57" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Oct 26 14:23:21 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:21 2010 -0700" }, "message": "scripts/checkpatch.pl: add check for declaration of pci_device_id\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "cb710eca6820493add0ddd3d7e8e3ee53f2b6e57", "tree": "752ca452a0d2fa3f9cb085c4f4e050a5e657f5f5", "parents": [ "267ad8f42644c2fa4ff6c2e7596d2b02c7397c85" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Oct 26 14:23:20 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:21 2010 -0700" }, "message": "scripts/checkpatch.pl: add warnings for static char that could be static const char\n\nAdd warnings for possible missing const uses of\n\tstatic char foo[] \u003d \"bar\"\n that could be\n\tstatic const char foo[] \u003d \"bar\"\nand\n\tstatic const char *foo[] \u003d {\"bar\", \"baz\"}\n that could be\n\tstatic const char * const foo[] \u003d {\"bar\", \"baz\"}\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Mike Frysinger \u003cvapier.adi@gmail.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "267ad8f42644c2fa4ff6c2e7596d2b02c7397c85", "tree": "3ee37f7c98f3f0f54ddc3d165bf48c576205eb17", "parents": [ "01464f30a97c5c30bf9633309b27cce055cef8fd" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:19 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:21 2010 -0700" }, "message": "checkpatch: version 0.31\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "01464f30a97c5c30bf9633309b27cce055cef8fd", "tree": "5ba4eb55ff1b520cbbc82f5f32a7bc81c666d8da", "parents": [ "3cbf62df3a8ce61cb1aa20b7dae964058988bfdd" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:19 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:21 2010 -0700" }, "message": "checkpatch: statement/block context analyser should look at sanitised lines\n\nWhen tracking context to find a block or statement we need to use the\nsanitised lines, else perentheses \u0027(\u0027 \u0026 \u0027)\u0027 and braces \u0027{\u0027 \u0026 \u0027}\u0027 can throw\nthe scanner out. Also fix up a couple of error outputs which include\nthose sanitised lines incorrectly.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3cbf62df3a8ce61cb1aa20b7dae964058988bfdd", "tree": "46a2d31b34c07ae6547d743a27e60b682b84c3e8", "parents": [ "5eaa20b984eb316533b4a098d8de3912e434df6a" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:18 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:21 2010 -0700" }, "message": "checkpatch: handle EXPORT_SYMBOL for DEVICE_ATTR and similar\n\nHandly definitions similar to below. The definition macro spits out a\nsymbol with a prefix. Add matching of any identifier prefix:\n\n DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR,\n ata_scsi_lpm_show, ata_scsi_lpm_put);\n EXPORT_SYMBOL_GPL(dev_attr_link_power_management_policy);\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5eaa20b984eb316533b4a098d8de3912e434df6a", "tree": "91df836f5b4fdd7745fde745adec27c4edeccb1a", "parents": [ "015830be9779aeae7de7060b07a3157a8e41bcb4" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:18 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: clean up structure definition macro handline\n\nHandle definitions such as the following correctly, it is not\na complex statement:\n\n #define PREALLOC(NAME, START, END, FLAGS) { \\\n\t\t .name \u003d (NAME), \\\n\t\t .start \u003d (START), \\\n\t\t .end \u003d (END), \\\n\t\t .flags \u003d (FLAGS) \\\n\t },\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "015830be9779aeae7de7060b07a3157a8e41bcb4", "tree": "6a6044c2e3129b42f1b5d7dfd3763fc54f76ea76", "parents": [ "03f1df7da5696ddfa6e167b37e0c0ce5aad3de79" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:17 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: update copyright dates\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "03f1df7da5696ddfa6e167b37e0c0ce5aad3de79", "tree": "46e1ac76d5a6a31f96f1ca040fb2620eb93f4a36", "parents": [ "3bf9a009fccea422bc355414a3bdf5f35fff9f36" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Oct 26 14:23:16 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: Add additional attribute #defines\n\nOn Wed, 2010-08-11 at 12:35 -0400, Dave Jones wrote:\n\u003e I just got this from a patch I merged..\n\u003e\n\u003e ERROR: need consistent spacing around \u0027*\u0027 (ctx:WxV)\n\u003e #121: FILE: arch/x86/kernel/cpu/cpufreq/pcc-cpufreq.c:113:\n\u003e +static struct pcc_cpu __percpu *pcc_cpu_info;\n\u003e ^\n\u003e which doesn\u0027t seem right.\n\nPerhaps these need to be added to checkpatch.\n\n[apw@canonical.com: added tests]\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Dave Jones \u003cdavej@codemonkey.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3bf9a009fccea422bc355414a3bdf5f35fff9f36", "tree": "18a47ff24bae81950fae0e8b550835723da17cd1", "parents": [ "9fe287d79b0af983050d24e7916cf3d1f019f553" ], "author": { "name": "Rabin Vincent", "email": "rabin.vincent@stericsson.com", "time": "Tue Oct 26 14:23:16 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: check for incorrect permissions\n\nThrow an error when a source file has been given execute permissions using\nthe mode change line present in git diffs. Also alow the filename\nmatching to use the \"diff\" line in addition to the \"+++\" line, since the\nmode change lines appear before any \"+++\" lines.\n\n[apw@canonical.com: simplified filename logic slightly, added tests]\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nAcked-by: Linus Walleij \u003clinus.walleij@stericsson.com\u003e\nSigned-off-by: Rabin Vincent \u003crabin.vincent@stericsson.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9fe287d79b0af983050d24e7916cf3d1f019f553", "tree": "46683d872be3d6976ad895f6ad94996acc06344c", "parents": [ "0c73b4eb7a825a5aff16d8a9701f6c28056de058" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:15 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: ensure kconfig help checks only apply when we are adding help\n\nWhen checking the length of the help we need to be sure we are seeing the\nwhole story before erroring. Firstly we only want to check when adding\nthe help in the first place. Second we need to be sure that we are seeing\nthe end of the entry, nominally when there is no context below or that\ncontext shows the start of the next entry.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0c73b4eb7a825a5aff16d8a9701f6c28056de058", "tree": "bbc5cec929a9406ad53c6d5df36c980259e60546", "parents": [ "8cf6de7145943caa38c56c61cd83b17687afd900" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:15 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: simplify and consolidate \"missing space after\" checks\n\nCommonise the code for missing spaces after struct, union, and enum such\nthat they share the same code. Ensure we cover all the common cases in\neach case. Check against the sanitised line to ensure we do not report on\ncomments and strings.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8cf6de7145943caa38c56c61cd83b17687afd900", "tree": "f32e86109cce060816afdcbd9e55cd7c991a495b", "parents": [ "53a3c4487a05b8f26ef72fe434a750a3402c998f" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:14 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: add check for space after struct, union, and enum\n\nAdd spacing checks for struct, union, and enum definitions. Check the\nspacing after type and before the equals (\u003d) and open brace ({).\n\nBased on a patch by Joe Perches.\n\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "53a3c4487a05b8f26ef72fe434a750a3402c998f", "tree": "dfe0b1f85cbf1082ceb52b71bb157cc715e22293", "parents": [ "9446ef569c288e683225fec8337a0b2b81e75cc5" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:14 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: returning errno typically should be negative\n\nAdd a (strict mode only) test to check for non-negative returns of what\nappear to be errno values as the majority case these should indeed be\nnegative.\n\nSuggested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9446ef569c288e683225fec8337a0b2b81e75cc5", "tree": "a46d6265a77f637f882c9136c914483b5d4598d8", "parents": [ "fb2d2c1b5825503d30fb6f2dc328dbe4a47d9794" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:13 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:20 2010 -0700" }, "message": "checkpatch: handle casts better fixing false categorisation of : as binary\n\nThe following incantation is triggering categorisation of its colon (:) as\na binary form, which it is not:\n\n\treturn foo ? (s8)bar : baz;\n\nHandle casts differently from types in the categoriser, allowing us to\nbetter track (s8)bar as a value and not a declaration.\n\nReported-by: Jean Delvare \u003ckhali@linux-fr.org\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fb2d2c1b5825503d30fb6f2dc328dbe4a47d9794", "tree": "6fba2ec80498dcb83615ea27907c89e979902c85", "parents": [ "d2c0a23514d8ac4ed10a8e742467cfb72ca3bed8" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:12 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:19 2010 -0700" }, "message": "checkpatch: ensure we do not collapse bracketed sections into constants\n\nWhen determining if a return () sequence is a function style bracketing we\nsimplify the expression one bracket at a time replacing each with a\nconstant. However this can trigger a false merge with expressions as\nbelow:\n\n\treturn (foo)0;\n\nPrevent this false merging.\n\nReported-by: Hitoshi Mitake \u003cmitake@dcl.info.waseda.ac.jp\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d2c0a23514d8ac4ed10a8e742467cfb72ca3bed8", "tree": "a3c0283ee6cdcaa92ecf9ae2ec7a4f1e627c359c", "parents": [ "e91b6e263ed6735c766cb14bbe63b9c7bd774526" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:12 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:19 2010 -0700" }, "message": "checkpatch: suggest cleanpatch and cleanfile when appropriate\n\nWhen we hit types of whitespace which may be fixed by scripts/cleanpatch\nand scripts/cleanfile suggest their use in our report.\n\nSuggested-by: Bartlomiej Zolnierkiewicz \u003cbzolnier@gmail.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e91b6e263ed6735c766cb14bbe63b9c7bd774526", "tree": "aeb8283e01f9ec0fe3250f60ec83da4fe2399e2e", "parents": [ "6b4c5bebcebb0a48d29947e9aa749650751a7696" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Tue Oct 26 14:23:11 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 26 16:52:19 2010 -0700" }, "message": "checkpatch: types may sit on a line on their own\n\nWhen the following form is used we have a type which fully fills a line.\nThis means that a type may end at the end of line as well as at the\nfollowing identifier.\n\n\tint **\n\tfoo;\n\nReported-by: Daniel Walker \u003cdwalker@fifo99.com\u003e\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" } ], "next": "6b4c5bebcebb0a48d29947e9aa749650751a7696" }