)]}' { "log": [ { "commit": "8fc2751beb0941966d3a97b26544e8585e428c08", "tree": "30a03f2e173f31d76fb436054ed2356542099999", "parents": [ "c92371566ea505cf455c208cdfb89046b3db87de" ], "author": { "name": "Mark Bellon", "email": "mbellon@mvista.com", "time": "Tue Sep 06 15:16:54 2005 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@g5.osdl.org", "time": "Wed Sep 07 16:57:23 2005 -0700" }, "message": "[PATCH] disk quotas fail when /etc/mtab is symlinked to /proc/mounts\n\nIf /etc/mtab is a regular file all of the mount options (of a file system)\nare written to /etc/mtab by the mount command. The quota tools look there\nfor the quota strings for their operation. If, however, /etc/mtab is a\nsymlink to /proc/mounts (a \"good thing\" in some environments) the tools\ndon\u0027t write anything - they assume the kernel will take care of things.\n\nWhile the quota options are sent down to the kernel via the mount system\ncall and the file system codes handle them properly unfortunately there is\nno code to echo the quota strings into /proc/mounts and the quota tools\nfail in the symlink case.\n\nThe attached patchs modify the EXT[2|3] and JFS codes to add the necessary\nhooks. The show_options function of each file system in these patches\ncurrently deal with only those things that seemed related to quotas;\nespecially in the EXT3 case more can be done (later?).\n\nJan Kara also noted the difficulty in moving these changes above the FS\ncodes responding similarly to myself to Andrew\u0027s comment about possible\nVFS migration. Issue summary:\n\n - FS codes have to process the entire string of options anyway.\n\n - Only FS codes that use quotas must have a show_options function (for\n quotas to work properly) however quotas are only used in a small number\n of FS.\n\n - Since most of the quota using FS support other options these FS codes\n should have the a show_options function to show those options - and the\n quota echoing becomes virtually negligible.\n\nBased on feedback I have modified my patches from the original:\n\n JFS a missing patch has been restored to the posting\n EXT[2|3] and JFS always use the show_options function\n - Each FS has at least one FS specific option displayed\n - QUOTA output is under a CONFIG_QUOTA ifdef\n - a follow-on patch will add a multitude of options for each FS\n EXT[2|3] and JFS \"quota\" is treated as \"usrquota\"\n EXT3 journalled data check for journalled quota removed\n EXT[2|3] mount when quota specified but not compiled in\n\n - no changes from my original patch. I tested the patch and the codes\n warn but\n\n - still mount. With all due respection I believe the comments\n otherwise were a\n\n - misread of the patch. Please reread/test and comment. XFS patch\n removed - the XFS team already made the necessary changes EXT3 mixing\n old and new quotas are handled differently (not purely exclusive)\n\n - if old and new quotas for the same type are used together the old\n type is silently depricated for compatability (e.g. usrquota and\n usrjquota)\n\n - mixing of old and new quotas is an error (e.g. usrjquota and\n grpquota)\n\nSigned-off-by: Mark Bellon \u003cmbellon@mvista.com\u003e\nAcked-by: Dave Kleikamp \u003cshaggy@austin.ibm.com\u003e\nCc: Jan Kara \u003cjack@ucw.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@osdl.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@osdl.org\u003e\n" }, { "commit": "08c6a96fd77836856c090ebb39beadc81cb8484d", "tree": "36e643a41179078abcb8a866894586cba9bbf7e0", "parents": [ "5323125031799a7fd8602ce150c3902aedfdcba6" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue Jul 12 13:58:28 2005 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@g5.osdl.org", "time": "Tue Jul 12 16:01:01 2005 -0700" }, "message": "[PATCH] ext3: fix options parsing\n\nFix a problem with ext3 mount option parsing. When remount of a filesystem\nfails, old options are now restored.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@osdl.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@osdl.org\u003e\n" }, { "commit": "c7f1721ef284c6e8257c7471a02148db76105036", "tree": "6c16fdc37f5bdd46f38e5dd8054b0b1c7363833c", "parents": [ "ec471dc484b8ca5352903ee28796b8b248313547" ], "author": { "name": "KAMBAROV, ZAUR", "email": "kambarov@berkeley.edu", "time": "Tue Jun 28 20:45:11 2005 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@ppc970.osdl.org", "time": "Tue Jun 28 21:20:34 2005 -0700" }, "message": "[PATCH] coverity: fs/ext3/super.c: match_int return check\n\nThe return value of \"match_int\" is checked 27 out of 28 times\n\nIn lib/parser.c\n142 \t/**\n143 \t * match_int: - scan a decimal representation of an integer from a substring_t\n144 \t * @s: substring_t to be scanned\n145 \t * @result: resulting integer on success\n146 \t *\n147 \t * Description: Attempts to parse the \u0026substring_t @s as a decimal integer. On\n148 \t * success, sets @result to the integer represented by the string and returns 0.\n149 \t * Returns either -ENOMEM or -EINVAL on failure.\n150 \t */\n151 \tint match_int(substring_t *s, int *result)\n152 \t{\n153 \t\treturn match_number(s, result, 0);\n154 \t}\n\nSigned-off-by: Zaur Kambarov \u003czkambarov@coverity.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@osdl.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@osdl.org\u003e\n" }, { "commit": "1f54587bea84a35125c95e19b98c2f464c50871b", "tree": "42f2467d6892be821271a2257e1259922bdafd45", "parents": [ "4e5117ba0af4582b6ec9164874f719d7f3f1eb2b" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Jun 23 22:01:04 2005 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@ppc970.osdl.org", "time": "Fri Jun 24 00:05:20 2005 -0700" }, "message": "[PATCH] quota: ext3: Improve quota credit estimates\n\nUse improved credits estimates for quota operations. Also reserve a space\nfor a quota operation in a transaction only if filesystem was mounted with\nsome quota options.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@osdl.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@osdl.org\u003e\n" }, { "commit": "84de856ed30c568c2bb7b9ac0679772bd2737d9b", "tree": "532e4f6bcc0db2d1baf0455484ec7f64a2a51e71", "parents": [ "df164db5fd16888ddbe2a63a47b2f6dda9a428b5" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Thu Jun 23 00:09:16 2005 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@ppc970.osdl.org", "time": "Thu Jun 23 09:45:20 2005 -0700" }, "message": "[PATCH] quota: consolidate code surrounding vfs_quota_on_mount\n\nMove some code duplicated in both callers into vfs_quota_on_mount\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nAcked-by: Jan Kara \u003cjack@ucw.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@osdl.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@osdl.org\u003e\n" }, { "commit": "301216244b1e39c4346e56d38b079ca53d528580", "tree": "4a16a1f4cf249d713e565c1b2113ca3b38d3ba45", "parents": [ "e72022e13d659bece2fc9cb2dd97afa67047dbca" ], "author": { "name": "Stephen Tweedie", "email": "sct@redhat.com", "time": "Wed May 18 11:47:17 2005 -0400" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@ppc970.osdl.org", "time": "Wed May 18 09:10:02 2005 -0700" }, "message": "[PATCH] Avoid console spam with ext3 aborted journal.\n\nAvoid console spam with ext3 aborted journal.\n\next3 usually reports error conditions that it detects in its environment.\nBut when its journal gets aborted due to such errors, it can sometimes\ncontinue to report that condition forever, spamming the console to such\nan extent that the initial first cause of the journal abort can be lost.\n\nWhen the journal aborts, we put the filesystem into readonly mode. Most\nsubsequent filesystem operations will get rejected immediately by checks\nfor MS_RDONLY either in the filesystem or in the VFS. But some paths do\nnot have such checks --- for example, if we continue to write to a file\nhandle that was opened before the fs went readonly. (We only check for\nthe ROFS condition when the file is first opened.) In these cases, we\ncan continue to generate log errors similar to\n\nEXT3-fs error (device $DEV) in start_transaction: Journal has aborted\n\nfor each subsequent write.\n\nThere is really no point in generating these errors after the initial\nerror has been fully reported. Specifically, if we\u0027re starting a\ncompletely new filesystem operation, and the filesystem is *already*\nreadonly (ie. the ext3 layer has already detected and handled the\nunderlying jbd abort), and we see an EROFS error, then there is simply\nno point in reporting it again.\n\nSigned-off-by: Stephen Tweedie \u003csct@redhat.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@osdl.org\u003e\n" }, { "commit": "1da177e4c3f41524e886b7f1b8a0c1fc7321cac2", "tree": "0bba044c4ce775e45a88a51686b5d9f90697ea9d", "parents": [], "author": { "name": "Linus Torvalds", "email": "torvalds@ppc970.osdl.org", "time": "Sat Apr 16 15:20:36 2005 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@ppc970.osdl.org", "time": "Sat Apr 16 15:20:36 2005 -0700" }, "message": "Linux-2.6.12-rc2\n\nInitial git repository build. I\u0027m not bothering with the full history,\neven though we have it. We can create a separate \"historical\" git\narchive of that later if we want to, and in the meantime it\u0027s about\n3.2GB when imported into git - space that would just make the early\ngit days unnecessarily complicated, when we don\u0027t have a lot of good\ninfrastructure for it.\n\nLet it rip!\n" } ] }