)]}' { "log": [ { "commit": "8fc2c767b06067b417c565c4e75731e68ed41fd8", "tree": "7ae425a9fb09bacec67c55f1a412e4585e1836a9", "parents": [ "5ad31a575157147b43fa84ef1e21471661653878" ], "author": { "name": "Kim B. Heino", "email": "Kim.Heino@bluegiga.com", "time": "Wed Jul 23 21:30:34 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:33 2008 -0700" }, "message": "rtc: add support for ST M41T94 SPI RTC\n\nThis patch adds kernel driver for M41T94 RTC chip connected via SPI.\nI\u0027ve tested it on two different AT91-based hardwares.\n\nThis is third revision of the patch: some comments made by\nAlessandro Zummo fixed.\n\nRevision two added support for century bit and fixes.\n\nSigned-off-by: Kim B. Heino \u003cKim.Heino@bluegiga.com\u003e\nSigned-off-by: Alessandro Zummo \u003ca.zummo@towertech.it\u003e\nCc: David Brownell \u003cdavid-b@pacbell.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5ad31a575157147b43fa84ef1e21471661653878", "tree": "c4a42d45957362aa8391938ae3e11496321c19d8", "parents": [ "53f1b1433da7eac2607a4a0898a221a4485fd732" ], "author": { "name": "David Brownell", "email": "david-b@pacbell.net", "time": "Wed Jul 23 21:30:33 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:33 2008 -0700" }, "message": "rtc: remove BKL for ioctl()\n\nRemove implicit use of BKL in ioctl() from the RTC framework.\n\nInstead, the rtc-\u003eops_lock is used. That\u0027s the same lock that already\nprotects the RTC operations when they\u0027re issued through the exported\nrtc_*() calls in drivers/rtc/interface.c ... making this a bugfix, not\njust a cleanup, since both ioctl calls and set_alarm() need to update IRQ\nenable flags and that implies a common lock (which RTC drivers as a rule\ndo not provide on their own).\n\nA new comment at the declaration of \"struct rtc_class_ops\" summarizes\ncurrent locking rules. It\u0027s not clear to me that the exceptions listed\nthere should exist ... if not, those are pre-existing problems which can\nbe fixed in a patch that doesn\u0027t relate to BKL removal.\n\nSigned-off-by: David Brownell \u003cdbrownell@users.sourceforge.net\u003e\nCc: Alan Cox \u003calan@lxorguk.ukuu.org.uk\u003e\nCc: Jonathan Corbet \u003ccorbet@lwn.net\u003e\nAcked-by: Alessandro Zummo \u003ca.zummo@towertech.it\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "53f1b1433da7eac2607a4a0898a221a4485fd732", "tree": "b6c663482bc7e94cead5d8e9135993a0af149b18", "parents": [ "4c228db0b30fa12d65ae7461ce29ed1f4da12c5b" ], "author": { "name": "Alan Cox", "email": "alan@lxorguk.ukuu.org.uk", "time": "Wed Jul 23 21:30:32 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:33 2008 -0700" }, "message": "rtc: push the BKL down into the driver ioctl method\n\nFor now just wrap the main logic, but this driver is a prime candidate for\nsomeone wanting to eliminate the lock entirely\n\n[lizf@cn.fujitsu.com: fix build failure]\nSigned-off-by: Alan Cox \u003calan@redhat.com\u003e\nSigned-off-by: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4c228db0b30fa12d65ae7461ce29ed1f4da12c5b", "tree": "71642638de47ba369a620699687cc34575a8233a", "parents": [ "35aa64f3a117a16c466f688f52ac3847b3b572e8" ], "author": { "name": "Maciej W. Rozycki", "email": "macro@linux-mips.org", "time": "Wed Jul 23 21:30:32 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:33 2008 -0700" }, "message": "rtc: m41t80: use pr_info() as appropriate\n\nReplace printk(KERN_INFO ...) calls with appropriate pr_info(...)\nequivalents.\n\nSigned-off-by: Maciej W. Rozycki \u003cmacro@linux-mips.org\u003e\nCc: Alessandro Zummo \u003ca.zummo@towertech.it\u003e\nCc: Alexander Bigga \u003cab@mycable.de\u003e\nCc: David Brownell \u003cdavid-b@pacbell.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "35aa64f3a117a16c466f688f52ac3847b3b572e8", "tree": "a98673fd5c40fbbadffef0fe597badb0399d764a", "parents": [ "aa55ddf340c9fa3f303ee16bbf35887e42c50304" ], "author": { "name": "Maciej W. Rozycki", "email": "macro@linux-mips.org", "time": "Wed Jul 23 21:30:29 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:33 2008 -0700" }, "message": "rtc: m41t80: sort header inclusions for readability\n\nSort the header inclusions for readability. No functional changes.\n\nSigned-off-by: Maciej W. Rozycki \u003cmacro@linux-mips.org\u003e\nCc: Alessandro Zummo \u003ca.zummo@towertech.it\u003e\nCc: Alexander Bigga \u003cab@mycable.de\u003e\nCc: David Brownell \u003cdavid-b@pacbell.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "aa55ddf340c9fa3f303ee16bbf35887e42c50304", "tree": "62194eef352ef852e6da1a9a3b685d2f56ac9c3b", "parents": [ "06a3598552dc3b2b30eb18bd53bbac2a901489d7" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:29 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:33 2008 -0700" }, "message": "autofs4: remove unused ioctls\n\nThe ioctls AUTOFS_IOC_TOGGLEREGHOST and AUTOFS_IOC_ASKREGHOST were added\nseveral years ago but what they were intended for has never been\nimplemented (as far as I\u0027m aware noone uses them) so remove them.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nReviewed-by: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "06a3598552dc3b2b30eb18bd53bbac2a901489d7", "tree": "bb209268deac3b12d63d07c67a76ba10561f6a11", "parents": [ "ec6e8c7d3f9073336ec7b2eed3fcda6f922087c3" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:28 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: reorganize expire pending wait function calls\n\nThis patch re-orgnirzes the checking for and waiting on active expires and\nelininates redundant checks.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nCc: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ec6e8c7d3f9073336ec7b2eed3fcda6f922087c3", "tree": "f88f8c2c972477e64f29ad619b9f42f6d5dcf961", "parents": [ "6e60a9ab5f5d314735467752f623072f5b75157a" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:28 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: fix direct mount pending expire race - correction\n\nAppologies, somehow I seem to have sent an out dated version of this\npatch. Here is an additional patch that brings the patch up to date.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nCc: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6e60a9ab5f5d314735467752f623072f5b75157a", "tree": "1a42df40e6fad52bd6be74970af8eb56870fe6ba", "parents": [ "97e7449a7ad883bf9f516fc970778d75999c7843" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:27 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: fix direct mount pending expire race\n\nFor direct and offset type mounts that are covered by another mount we\ncannot check the AUTOFS_INF_EXPIRING flag during a path walk which leads\nto lookups walking into an expiring mount while it is being expired.\n\nFor example, for the direct multi-mount map entry with a couple of\noffsets:\n\n/race/mm1 / \u003cserver1\u003e:/\u003cpath1\u003e\n /om1 \u003cserver2\u003e:/\u003cpath2\u003e\n /om2 \u003cserver1\u003e:/\u003cpath3\u003e\n\nan autofs trigger mount is mounted on /race/mm1 and when accessed it is\nover mounted and trigger mounts made for /race/mm1/om1 and /race/mm1/om2.\nSo it isn\u0027t possible for path walks to see the expiring flag at all and\nthey happily walk into the file system while it is expiring.\n\nWhen expiring these mounts follow_down() must stop at the autofs mount and\nall processes must block in the -\u003efollow_link() method (except the daemon)\nuntil the expire is complete. This is done by decrementing the d_mounted\nfield of the autofs trigger mount root dentry until the expire is\ncompleted. In -\u003efollow_link() all processes wait on the expire and the\nmount following is completed for the daemon until the expire is complete.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nCc: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "97e7449a7ad883bf9f516fc970778d75999c7843", "tree": "903f6de243847eb12d1a372b271b15046ecdc774", "parents": [ "26e81b3142f1ba497d4cd0365c13661684b784ce" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:26 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: fix indirect mount pending expire race\n\nThe selection of a dentry for expiration and the setting of the\nAUTOFS_INF_EXPIRING flag isn\u0027t done atomically which can lead to lookups\nwalking into an expiring mount.\n\nWhat happens is that an expire is initiated by the daemon and a dentry is\nselected for expire but, since there is no lock held between the selection\nand setting of the expiring flag, a process may find the flag clear and\ncontinue walking into the mount tree at the same time the daemon attempts\nthe expire it.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nReviewed-by: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "26e81b3142f1ba497d4cd0365c13661684b784ce", "tree": "b21545ceca70a0e93da1e4e6b19b5dcb99549d2d", "parents": [ "ff9cd499d6258952385cb2f12e9a3c0908fd5786" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:25 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: fix pending checks\n\nThere are two cases for which a dentry that has a pending mount request\ndoes not wait for completion. One is via autofs4_revalidate() and the\nother via autofs4_follow_link().\n\nIn revalidate, after the mount point directory is created, but before the\nmount is done, the check in try_to_fill_dentry() can can fail to send the\ndentry to the wait queue since the dentry is positive and the lookup flags\nmay contain only LOOKUP_FOLLOW. Although we don\u0027t trigger a mount for the\nLOOKUP_FOLLOW flag, if ther\u0027s one pending we might as well wait and use\nthe mounted dentry for the lookup.\n\nIn autofs4_follow_link() the dentry is not checked to see if it is pending\nso it may fail to call try_to_fill_dentry() and not wait for mount\ncompletion.\n\nA dentry that is pending must always be sent to the wait queue.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nReviewed-by: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ff9cd499d6258952385cb2f12e9a3c0908fd5786", "tree": "6614b95a82361c7a69fe52168db5836e313bd366", "parents": [ "c72305b5472522299bb6f45b736080128eb1c822" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:24 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: cleanup redundant readir code\n\nThe mount triggering functionality of readdir and related functions is no\nlonger used (and is quite broken as well). The unused portions have been\nremoved.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nReviewed-by: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c72305b5472522299bb6f45b736080128eb1c822", "tree": "0dc2c0c553d302358df0b54676ef4be82d47fb6c", "parents": [ "eb3b176796b0e53fd26fce86847231542eb0d198" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:23 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: indirect dentry must almost always be positive\n\nWe have been seeing mount requests comming to the automount daemon for\nkeys of the form \"\u003cmap key\u003e/\u003cnon key directory\u003e\" which are lookups for\ninvalid map keys. But we can check for this in the kernel module and\nreturn a fail immediately, without having to send a request to the daemon.\n\nIt is possible to recognise these requests are invalid based on whether\nthe request dentry is negative and its relation to the autofs file system\nroot.\n\nFor example, given the indirect multi-mount map entry:\n\nidm1 \\\n /mm1 \u003cserver\u003e:/\u003cpath1\u003e\n /mm2 \u003cserver\u003e:/\u003cpath2\u003e\n\nFor a request to mount idm1, IS_ROOT((idm1)-\u003ed_parent) will be always be\ntrue and the dentry may be negative. But directories idm1/mm1 and\nidm1/mm2 will always be created as part of the mount request for idm1. So\nany mount request within idm1 itself must have a positive dentry otherwise\nthe map key is invalid.\n\nIn version 4 these multi-mount entries are all mounted and umounted as a\nsingle request and in version 5 the directories idm1/mm1 and idm1/mm2 are\ncreated and an autofs fs mounted on them to act as a mount trigger so the\nabove is also true.\n\nThis also holds true for the autofs version 4 pseudo direct mount feature.\n When this feature is used without the \"--ghost\" option automount(8) will\ncreate internal submounts as we go down the map key paths which are\nessentially normal indirect mounts for which the above holds. If the\n\"--ghost\" option is given the directories for map keys are created at\ndaemon startup so valid map entries correspond to postive dentries in the\nautofs fs.\n\nautofs version 5 direct mount maps are similar except that the IS_ROOT\ncheck is not needed. This has been addressed in a previous patch tittled\n\"autofs4 - detect invalid direct mount requests\".\n\nFor example, given the direct multi-mount map entry:\n\n/test/dm1 \\\n /mm1 \u003cserver\u003e:/\u003cpath1\u003e\n /mm2 \u003cserver\u003e:/\u003cpath2\u003e\n\nAn autofs fs is mounted on /test/dm1 as a trigger mount and when a mount\nis triggered for /test/dm1, the multi-mount offset directories\n/test/dm1/mm1 and /test/dm1/mm2 are created and an autofs fs is mounted on\nthem to act as mount triggers. So valid direct mount requests must always\nhave a positive dentry if they correspond to a valid map entry.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nAcked-by: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "eb3b176796b0e53fd26fce86847231542eb0d198", "tree": "85bd1a2e79e92d1ff52714aa19888ef7e4f80638", "parents": [ "296f7bf78bc5c7a4d772aea580ce800d14040d1a" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:22 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: detect invalid direct mount requests\n\nautofs v5 direct and offset mounts within an autofs filesystem are\ntriggered by existing autofs triger mounts so the mount point dentry must\nbe positive. If the mount point dentry is negative then the trigger\ndoesn\u0027t exist so we can return fail immediately.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nCc: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "296f7bf78bc5c7a4d772aea580ce800d14040d1a", "tree": "794e3ae197d75b1a03511fefb4f87ca89caa54ac", "parents": [ "e64be33ccaceaca67c84237dff8805b861398eab" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:21 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: fix waitq memory leak\n\nIf an autofs mount becomes catatonic before autofs4_wait_release() is\ncalled the wait queue counter will not be decremented down to zero and the\nentry will never be freed. There are also races decrementing the wait\ncounter in the wait release function. To deal with this the counter needs\nto be updated while holding the wait queue mutex and waiters need to be\nwoken up unconditionally when the wait is removed from the queue to ensure\nwe eventually free the wait.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e64be33ccaceaca67c84237dff8805b861398eab", "tree": "574c0eed196ac6115e0f042c1e4564d1b85474d2", "parents": [ "f4c7da02615bebcaf89f15a8d055922f515160b8" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:20 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: check kernel communication pipe is valid for write\n\nIt is possible for an autofs mount to become catatonic (and for the daemon\ncommunication pipe to become NULL) after a wait has been initiallized but\nbefore the request has been sent to the daemon. We need to check for this\nbefore sending the request packet.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f4c7da02615bebcaf89f15a8d055922f515160b8", "tree": "1da0aa09fd27b35628562648b5da5bf3af9d2d8b", "parents": [ "a1362fe92f1bde687b3a9e93d6b8d105d0a84f74" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:19 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: add missing kfree\n\nIt see that the patch tittled \"autofs4 - fix pending mount race\" is\nmissing a change that I had recently made.\n\nIt\u0027s missing a kfree for the case mutex_lock_interruptible() fails\nto aquire the wait queue mutex.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nCc: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a1362fe92f1bde687b3a9e93d6b8d105d0a84f74", "tree": "b176c2494ea23b1842a8b408247f02058533dda5", "parents": [ "5a11d4d0ee1ff284271f7265929d07ea4a1168a6" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:19 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: fix pending mount race\n\nClose a race between a pending mount that is about to finish and a new\nlookup for the same directory.\n\nProcess P1 triggers a mount of directory foo. It sets\nDCACHE_AUTOFS_PENDING in the -\u003elookup routine, creates a waitq entry for\n\u0027foo\u0027, and calls out to the daemon to perform the mount. The autofs\ndaemon will then create the directory \u0027foo\u0027, using a new dentry that will\nbe hashed in the dcache.\n\nBefore the mount completes, another process, P2, tries to walk into the\n\u0027foo\u0027 directory. The vfs path walking code finds an entry for \u0027foo\u0027 and\ncalls the revalidate method. Revalidate finds that the entry is not\nPENDING (because PENDING was never set on the dentry created by the\nmkdir), but it does find the directory is empty. Revalidate calls\ntry_to_fill_dentry, which sets the PENDING flag and then calls into the\nautofs4 wait code to trigger or wait for a mount of \u0027foo\u0027. The wait code\nfinds the entry for \u0027foo\u0027 and goes to sleep waiting for the completion of\nthe mount.\n\nYet another process, P3, tries to walk into the \u0027foo\u0027 directory. This\nprocess again finds a dentry in the dcache for \u0027foo\u0027, and calls into the\nautofs revalidate code.\n\nThe revalidate code finds that the PENDING flag is set, and so calls\ntry_to_fill_dentry.\n\na) try_to_fill_dentry sets the PENDING flag redundantly for this\n dentry, then calls into the autofs4 wait code.\n\nb) the autofs4 wait code takes the waitq mutex and searches for an\n entry for \u0027foo\u0027\n\nBetween a and b, P1 is woken up because the mount completed. P1 takes the\nwait queue mutex, clears the PENDING flag from the dentry, and removes the\nwaitqueue entry for \u0027foo\u0027 from the list.\n\nWhen it releases the waitq mutex, P3 (eventually) acquires it. At this\ntime, it looks for an existing waitq for \u0027foo\u0027, finds none, and so creates\na new one and calls out to the daemon to mount the \u0027foo\u0027 directory.\n\nNow, the reason that three processes are required to trigger this race is\nthat, because the PENDING flag is not set on the dentry created by mkdir,\nthe window for the race would be way to slim for it to ever occur.\nBasically, between the testing of d_mountpoint(dentry) and the taking of\nthe waitq mutex, the mount would have to complete and the daemon would\nhave to be woken up, and that in turn would have to wake up P1. This is\nsimply impossible. Add the third process, though, and it becomes slightly\nmore likely.\n\nSigned-off-by: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5a11d4d0ee1ff284271f7265929d07ea4a1168a6", "tree": "4b9b76486afa5d9fc29216df069c5a557e09011a", "parents": [ "70b52a0a5005ce6a0ceec56e97222437a0ba7506" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:17 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: fix waitq locking\n\nThe autofs4_catatonic_mode() function accesses the wait queue without any\nlocking but can be called at any time. This could lead to a possible\ndouble free of the name field of the wait and a double fput of the daemon\ncommunication pipe or an fput of a NULL file pointer.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "70b52a0a5005ce6a0ceec56e97222437a0ba7506", "tree": "e2b45dff98eae948dd34d4cc36f54796bd01104f", "parents": [ "6d5cb926fa0162b1e62f37c117cc7ce763cfcbb9" ], "author": { "name": "Jeff Moyer", "email": "jmoyer@redhat.com", "time": "Wed Jul 23 21:30:16 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:32 2008 -0700" }, "message": "autofs4: use struct qstr in waitq.c\n\nThe autofs_wait_queue already contains all of the fields of the\nstruct qstr, so change it into a qstr.\n\nThis patch, from Jeff Moyer, has been modified a liitle by myself.\n\nSigned-off-by: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6d5cb926fa0162b1e62f37c117cc7ce763cfcbb9", "tree": "275f1154f7724c6b86c3ec9e2c36ff8f96c3e55d", "parents": [ "c432c2586a0811c7d0030d78f0993568bc889a6f" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:15 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "autofs4: use lookup intent flags to trigger mounts\n\nWhen an open(2) call is made on an autofs mount point directory that\nalready exists and the O_DIRECTORY flag is not used the needed mount\ncallback to the daemon is not done. This leads to the path walk\ncontinuing resulting in a callback to the daemon with an incorrect\nkey. open(2) is called without O_DIRECTORY by the \"find\" utility but\nthis should be handled properly anyway.\n\nThis happens because autofs needs to use the lookup flags to decide\nwhen to callback to the daemon to perform a mount to prevent mount\nstorms. For example, an autofs indirect mount map that has the \"browse\"\noption will have the mount point directories are pre-created and the\nstat(2) call made by a color ls against each directory will cause all\nthese directories to be mounted. It is unfortunate we need to resort\nto this but mount maps can be quite large. Additionally, if a user\nmanually umounts an autofs indirect mount the directory isn\u0027t removed\nwhich also leads to this situation.\n\nTo resolve this autofs needs to use the lookup intent flags to enable\nit to make this decision. This patch adds this check and triggers a\ncall back if any of the lookup intent flags are set as all these calls\nwarrant a mount attempt be requested.\n\nI know that external VFS code which uses the lookup flags is something\nthat the VFS would like to eliminate but I have no choice as I can\u0027t\nsee any other way to do this. A VFS dentry or inode operation callback\nwhich returns the lookup \"type\" (requires a definition) would be\nsufficient. But this change is needed now and I\u0027m not aware of the form\nthat coming VFS changes will take so I\u0027m not willing to propose anything\nalong these lines.\n\nIf anyone can provide an alternate method I would be happy to use it.\n\n[akpm@linux-foundation.org: fix build for concurrent VFS changes]\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nCc: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nCc: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c432c2586a0811c7d0030d78f0993568bc889a6f", "tree": "b5d711345120af6cc6ae67836d0773a5857e3e8c", "parents": [ "ef581a742874ebc4c28d24b374c78b762144ebdc" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:14 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "autofs4: don\u0027t release directory mutex if called in oz_mode\n\nSince we now delay hashing of dentrys until the -\u003emkdir() call, droping\nand re-taking the directory mutex within the -\u003elookup() function when we\nare being called by user space is not needed. This can lead to a race\nwhen other processes are attempting to access the same directory during\nmount point directory creation.\n\nIn this case we need to hang onto the mutex to ensure we don\u0027t get user\nprocesses trying to create a mount request for a newly created dentry\nafter the mount point entry has already been created. This ensures that\nwhen we need to check a dentry passed to autofs4_wait(), if it is hashed,\nit is always the mount point dentry and not a new dentry created by\nanother lookup during directory creation.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ef581a742874ebc4c28d24b374c78b762144ebdc", "tree": "8dfced9c0fc8e18a3b81aac9fae2b843d251b8a6", "parents": [ "2576737873dc1d9ea461a5955a5f6779b569a350" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:13 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "autofs4: fix symlink name allocation\n\nThe length of the symlink name has been moved but it needs to be set\nbefore allocating space for it in the dentry info struct. This corrects a\nmistake in a recent patch.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2576737873dc1d9ea461a5955a5f6779b569a350", "tree": "aad8f5cf52c872f307275328022a3bcb94a6c342", "parents": [ "caf7da3d5d4d9dd873eb52d025d8cc63b89f1fdb" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:12 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "autofs4: use look aside list for lookups\n\nA while ago a patch to resolve a deadlock during directory creation was\nmerged. This delayed the hashing of lookup dentrys until the -\u003emkdir()\n(or -\u003esymlink()) operation completed to ensure we always went through\n-\u003elookup() instead of also having processes go through -\u003erevalidate() so\nour VFS locking remained consistent.\n\nNow we are seeing a couple of side affects of that change in situations\nwith heavy mount activity.\n\nTwo cases have been identified:\n\n1) When a mount request is triggered, due to the delayed hashing, the\n directory created by user space for the mount point doesn\u0027t have the\n DCACHE_AUTOFS_PENDING flag set. In the case of an autofs multi-mount\n where a tree of mount point directories are created this can lead to\n the path walk continuing rather than the dentry being sent to the wait\n queue to wait for request completion. This is because, if the pending\n flag isn\u0027t set, the criteria for deciding this is a mount in progress\n fails to hold, namely that the dentry is not a mount point and has no\n subdirectories.\n\n2) A mount request dentry is initially created negative and unhashed.\n It remains this way until the -\u003emkdir() callback completes. Since it\n is unhashed a fresh dentry is used when the user space mount request\n creates the mount point directory. This leaves the original dentry\n negative and unhashed. But revalidate has no way to tell the VFS that\n the dentry has changed, other than to force another -\u003elookup() by\n returning false, which is at best wastefull and at worst not possible.\n This results in an -ENOENT return from the original path walk when in\n fact the mount succeeded.\n\nTo resolve this we need to ensure that the same dentry is used in all\ncalls to -\u003elookup() during the course of a mount request. This patch\nachieves that by adding the initial dentry to a look aside list and\nremoves it at -\u003emkdir() or -\u003esymlink() completion (or when the dentry is\nreleased), since these are the only create operations autofs4 supports.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "caf7da3d5d4d9dd873eb52d025d8cc63b89f1fdb", "tree": "9e53359c28c4247eae9685a5f9c63a5c0a54a7b1", "parents": [ "5f6f4f28b6ba543beef8bad91aa6f69c7ffeee51" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:11 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "autofs4: revert - redo lookup in ttfd\n\nThis patch series enables the use of a single dentry for lookups prior to\nthe dentry being hashed and so we no longer need to redo the lookup. This\npatch reverts the patch of commit\n033790449ba9c4dcf8478a87693d33df625c23b5.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5f6f4f28b6ba543beef8bad91aa6f69c7ffeee51", "tree": "72f3aac56d49c7bea7940f8d8b6e8ca559e3ae1c", "parents": [ "391b52f98cf2e9bff227dad8bf9ea206fec43fa4" ], "author": { "name": "Ian Kent", "email": "raven@themaw.net", "time": "Wed Jul 23 21:30:09 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "autofs4: don\u0027t make expiring dentry negative\n\nCorrect the error of making a positive dentry negative after it has been\ninstantiated.\n\nThe code that makes this error attempts to re-use the dentry from a\nconcurrent expire and mount to resolve a race and the dentry used for the\nlookup must be negative for mounts to trigger in the required cases. The\nfact is that the dentry doesn\u0027t need to be re-used because all that is\nneeded is to preserve the flag that indicates an expire is still\nincomplete at the time of the mount request.\n\nThis change uses the the dentry to check the flag and wait for the expire\nto complete then discards it instead of attempting to re-use it.\n\nSigned-off-by: Ian Kent \u003craven@themaw.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "391b52f98cf2e9bff227dad8bf9ea206fec43fa4", "tree": "40eb4e0d6d399d9b98b791db497097a1ff44894e", "parents": [ "72b55fffd631a89e5be6fe1b4f2565bc4cd90deb" ], "author": { "name": "Michael Halcrow", "email": "mhalcrow@us.ibm.com", "time": "Wed Jul 23 21:30:08 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "eCryptfs: Make all persistent file opens delayed\n\nThere is no good reason to immediately open the lower file, and that can\ncause problems with files that the user does not intend to immediately\nopen, such as device nodes.\n\nThis patch removes the persistent file open from the interpose step and\npushes that to the locations where eCryptfs really does need the lower\npersistent file, such as just before reading or writing the metadata\nstored in the lower file header.\n\nTwo functions are jumping to out_dput when they should just be jumping to\nout on error paths. This patch also fixes these.\n\nSigned-off-by: Michael Halcrow \u003cmhalcrow@us.ibm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "72b55fffd631a89e5be6fe1b4f2565bc4cd90deb", "tree": "ece810c24655a6eeed96a6f2fbe14dea6478f031", "parents": [ "0a688ad713949643e201431d3f4a4ceddfeb70ca" ], "author": { "name": "Michael Halcrow", "email": "mhalcrow@us.ibm.com", "time": "Wed Jul 23 21:30:07 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "eCryptfs: do not try to open device files on mknod\n\nWhen creating device nodes, eCryptfs needs to delay actually opening the lower\npersistent file until an application tries to open. Device handles may not be\nbacked by anything when they first come into existence.\n\n[Valdis.Kletnieks@vt.edu: build fix]\nSigned-off-by: Michael Halcrow \u003cmhalcrow@us.ibm.com\u003e\nCc: \u003cValdis.Kletnieks@vt.edu}\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0a688ad713949643e201431d3f4a4ceddfeb70ca", "tree": "d56c3258db6eb2ea0df39c5e5d86302caa72042c", "parents": [ "29335c6a41568d4708d4ec3b9187f9b6d302e5ea" ], "author": { "name": "Harvey Harrison", "email": "harvey.harrison@gmail.com", "time": "Wed Jul 23 21:30:07 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "ecryptfs: inode.c mmap.c use unaligned byteorder helpers\n\nFixe sparse warnings:\nfs/ecryptfs/inode.c:368:15: warning: cast to restricted __be64\nfs/ecryptfs/mmap.c:385:12: warning: incorrect type in assignment (different base types)\nfs/ecryptfs/mmap.c:385:12: expected unsigned long long [unsigned] [assigned] [usertype] file_size\nfs/ecryptfs/mmap.c:385:12: got restricted __be64 [usertype] \u003cnoident\u003e\nfs/ecryptfs/mmap.c:428:12: warning: incorrect type in assignment (different base types)\nfs/ecryptfs/mmap.c:428:12: expected unsigned long long [unsigned] [assigned] [usertype] file_size\nfs/ecryptfs/mmap.c:428:12: got restricted __be64 [usertype] \u003cnoident\u003e\n\nSigned-off-by: Harvey Harrison \u003charvey.harrison@gmail.com\u003e\nCc: Michael Halcrow \u003cmhalcrow@us.ibm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "29335c6a41568d4708d4ec3b9187f9b6d302e5ea", "tree": "83be9a98e4b657b46377c32624d5d0cd9120ee5f", "parents": [ "8f2368095e25018838e1bf145041f58270ccd32e" ], "author": { "name": "Harvey Harrison", "email": "harvey.harrison@gmail.com", "time": "Wed Jul 23 21:30:06 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "ecryptfs: crypto.c use unaligned byteorder helpers\n\nFixes the following sparse warnings:\nfs/ecryptfs/crypto.c:1036:8: warning: cast to restricted __be32\nfs/ecryptfs/crypto.c:1038:8: warning: cast to restricted __be32\nfs/ecryptfs/crypto.c:1077:10: warning: cast to restricted __be32\nfs/ecryptfs/crypto.c:1103:6: warning: incorrect type in assignment (different base types)\nfs/ecryptfs/crypto.c:1105:6: warning: incorrect type in assignment (different base types)\nfs/ecryptfs/crypto.c:1124:8: warning: incorrect type in assignment (different base types)\nfs/ecryptfs/crypto.c:1241:21: warning: incorrect type in assignment (different base types)\nfs/ecryptfs/crypto.c:1244:30: warning: incorrect type in assignment (different base types)\nfs/ecryptfs/crypto.c:1414:23: warning: cast to restricted __be32\nfs/ecryptfs/crypto.c:1417:32: warning: cast to restricted __be16\n\nSigned-off-by: Harvey Harrison \u003charvey.harrison@gmail.com\u003e\nCc: Michael Halcrow \u003cmhalcrow@us.ibm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8f2368095e25018838e1bf145041f58270ccd32e", "tree": "c8ac94c024d0874f1955c1aa8880d3649dc7d4fc", "parents": [ "982363c97f8cad7aea4c3d2cfebffc1cc2d2f166" ], "author": { "name": "Miklos Szeredi", "email": "mszeredi@suse.cz", "time": "Wed Jul 23 21:30:05 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "ecryptfs: string copy cleanup\n\nClean up overcomplicated string copy, which also gets rid of this\nbogus warning:\n\nfs/ecryptfs/main.c: In function \u0027ecryptfs_parse_options\u0027:\ninclude/asm/arch/string_32.h:75: warning: array subscript is above array bounds\n\nSigned-off-by: Miklos Szeredi \u003cmszeredi@suse.cz\u003e\nCc: Michael Halcrow \u003cmhalcrow@us.ibm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "982363c97f8cad7aea4c3d2cfebffc1cc2d2f166", "tree": "63459c8ea40c1f45f7a4e14b0630829ab2a43afc", "parents": [ "6c4c17b073cd4a5a61bc04329561632870bb21fc" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Wed Jul 23 21:30:04 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "ecryptfs: propagate key errors up at mount time\n\nMounting with invalid key signatures should probably fail, if they were\nspecifically requested but not available.\n\nAlso fix case checks in process_request_key_err() for the right sign of\nthe errnos, as spotted by Jan Tluka.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nReviewed-by: Jan Tluka \u003cjtluka@redhat.com\u003e\nAcked-by: Michael Halcrow \u003cmhalcrow@us.ibm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6c4c17b073cd4a5a61bc04329561632870bb21fc", "tree": "22fea1e80df5665061f1cf2953c69a00dc097e9b", "parents": [ "746f1e558bc52b9693c1a1ecdab60f8392e5ff18" ], "author": { "name": "Tyler Hicks", "email": "tyhicks@linux.vnet.ibm.com", "time": "Wed Jul 23 21:30:04 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:31 2008 -0700" }, "message": "ecryptfs: discard ecryptfsd registration messages in miscdev\n\nThe userspace eCryptfs daemon sends HELO and QUIT messages to the kernel\nfor per-user daemon (un)registration. These messages are required when\nnetlink is used as the transport, but (un)registration is handled by\nopening and closing the device file when miscdev is the transport. These\nmessages should be discarded in the miscdev transport so that a daemon\nisn\u0027t registered twice.\n\nSigned-off-by: Tyler Hicks \u003ctyhicks@linux.vnet.ibm.com\u003e\nCc: Michael Halcrow \u003cmhalcrow@us.ibm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "746f1e558bc52b9693c1a1ecdab60f8392e5ff18", "tree": "a3253428affed93967c3ec67ba27ce8fe7d333c2", "parents": [ "0293902a4d66fab27d0ddcc0766e05dae68f004e" ], "author": { "name": "Michael Halcrow", "email": "mhalcrow@us.ibm.com", "time": "Wed Jul 23 21:30:02 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "eCryptfs: Privileged kthread for lower file opens\n\neCryptfs would really like to have read-write access to all files in the\nlower filesystem. Right now, the persistent lower file may be opened\nread-only if the attempt to open it read-write fails. One way to keep\nfrom having to do that is to have a privileged kthread that can open the\nlower persistent file on behalf of the user opening the eCryptfs file;\nthis patch implements this functionality.\n\nThis patch will properly allow a less-privileged user to open the eCryptfs\nfile, followed by a more-privileged user opening the eCryptfs file, with\nthe first user only being able to read and the second user being able to\nboth read and write. eCryptfs currently does this wrong; it will wind up\ncalling vfs_write() on a file that was opened read-only. This is fixed in\nthis patch.\n\nSigned-off-by: Michael Halcrow \u003cmhalcrow@us.ibm.com\u003e\nCc: Dave Kleikamp \u003cshaggy@austin.ibm.com\u003e\nCc: Serge Hallyn \u003cserue@us.ibm.com\u003e\nCc: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0293902a4d66fab27d0ddcc0766e05dae68f004e", "tree": "3a02e64ec212aa568eeaeae38065877e36a0c833", "parents": [ "f700d6e5e5549cb9349d22043f4bd153792c621f" ], "author": { "name": "Wang Chen", "email": "wangchen@cn.fujitsu.com", "time": "Wed Jul 23 21:30:01 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "I2O: handle sysfs_create_link() failures\n\nCompile warning:\nignoring return value of `sysfs_create_link\u0027, declared with attribute warn_unused_result.\n\nIf sysfs_create_link failed, take care of the return value and do some\nerror handle after the failure.\n\nSince sysfs_remove_link() will check whether a link exists, when removing the\nlink in error path, we don\u0027t need to care whether a link was created.\n\nSigned-off-by: Wang Chen \u003cwangchen@cn.fujitsu.com\u003e\nCc: Markus Lidel \u003cMarkus.Lidel@shadowconnect.com\u003e\nCc: Jens Axboe \u003cjens.axboe@oracle.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f700d6e5e5549cb9349d22043f4bd153792c621f", "tree": "ea15f9d3f3a800d5ff938e645cc046a67ebc4ad3", "parents": [ "e0426e6a09954d205da2d674a3d368d2715e3afd" ], "author": { "name": "Stefano Stabellini", "email": "stefano.stabellini@eu.citrix.com", "time": "Wed Jul 23 21:29:59 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "vt: do not update when the console is blanked\n\nvt.c DO_UPDATE macro checks if the console is visible but doesn\u0027t check if\nthe console is blanked.\n\nIn fact updating fbcon while the console is blanked is not only\nunnecessary but can even cause screen corruption.\n\nTherefore I am adding a simple check on console_blanked in DO_UPDATE.\n\nSigned-off-by: Stefano Stabellini \u003cstefano.stabellini@eu.citrix.com\u003e\nCc: Krzysztof Helt \u003ckrzysztof.h1@poczta.fm\u003e\nCc: \"Antonino A. Daplas\" \u003cadaplas@pol.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e0426e6a09954d205da2d674a3d368d2715e3afd", "tree": "fcdc9863df9b7458f51730aaf8ab022dd87fcc84", "parents": [ "bbe48ecc7f6559318cfc6c023da225a0b0e14ab3" ], "author": { "name": "Jiri Slaby", "email": "jirislaby@gmail.com", "time": "Wed Jul 23 21:29:58 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "vt: hold console_sem across sysfs operations\n\nHold console sem while creating/destroying sysfs files. Serialisation is\nso far done by BKL held in tty release_dev and chrdev_open, but no other\nlocks are held in open path.\n\nSigned-off-by: Jiri Slaby \u003cjirislaby@gmail.com\u003e\nCc: Alan Cox \u003calan@lxorguk.ukuu.org.uk\u003e\nCc: Aristeu Rozanski \u003caris@ruivo.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "bbe48ecc7f6559318cfc6c023da225a0b0e14ab3", "tree": "bc31e1fbea4180a6822abe4247c9cfdb59e6b206", "parents": [ "3a93a159c61e38a12f7ecbb3a25cf3f012abcf7a" ], "author": { "name": "Jan Nikitenko", "email": "jan.nikitenko@gmail.com", "time": "Wed Jul 23 21:29:57 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "spi: au1550_spi: improve pio transfer mode\n\nImprove PIO transfer mode of au1550 spi controller by continuing of spi\ntransfer, instead of aborting transfer when transmit underflow interrupt\noccurrs.\n\nVerified by oscilloscope that the spi clock pauses on trasmit underflow,\nso transfer continuation is perfectly valid even though au1550 datasheet\nsays that on tx underflow zeroes will be transfered.\n\nAlso make some error messages more specific.\n\n[akpm@linux-foundation.org: coding-style fixes]\nSigned-off-by: Jan Nikitenko \u003cjan.nikitenko@gmail.com\u003e\nSigned-off-by: David Brownell \u003cdbrownell@users.sourceforge.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3a93a159c61e38a12f7ecbb3a25cf3f012abcf7a", "tree": "e0511aab3bdf590633987f9f8e0de1f9d0f72342", "parents": [ "4ef754b7d7971a704d5b1b4608839da1bae37e5e" ], "author": { "name": "Manuel Lauss", "email": "mano@roarinelk.homelinux.net", "time": "Wed Jul 23 21:29:56 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "spi: au1550_spi: proper platform device\n\nRemove the Au1550 resource table and instead extract MMIO/IRQ/DMA\nresources from platform resource information like any well-behaved\nplatform driver.\n\nSigned-off-by: Manuel Lauss \u003cmano@roarinelk.homelinux.net\u003e\nSigned-off-by: Jan Nikitenko \u003cjan.nikitenko@gmail.com\u003e\nSigned-off-by: David Brownell \u003cdbrownell@users.sourceforge.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4ef754b7d7971a704d5b1b4608839da1bae37e5e", "tree": "a9db20a2b6ca332653e5d1503fc8d3398b145aa6", "parents": [ "102eb97564c73ea73645b38599c5cbe6f54b030c" ], "author": { "name": "Alan Cox", "email": "alan@lxorguk.ukuu.org.uk", "time": "Wed Jul 23 21:29:55 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "spidev: BKL removal\n\nAnother step to removing -\u003eioctl and to removing the BKL\n\n[dbrownell@users.sourceforge.net: take final step; BKL not needed]\nSigned-off-by: Alan Cox \u003calan@redhat.com\u003e\nSigned-off-by: David Brownell \u003cdbrownell@users.sourceforge.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "102eb97564c73ea73645b38599c5cbe6f54b030c", "tree": "c054ffd980f35d14c569204fc4dcd995544817d3", "parents": [ "6291fe2abce4689d6ee7cbaea16692c79bf0d01b" ], "author": { "name": "Grant Likely", "email": "grant.likely@secretlab.ca", "time": "Wed Jul 23 21:29:55 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "spi: make spi_board_info.modalias a char array\n\nCurrently, \u0027modalias\u0027 in the spi_device structure is a \u0027const char *\u0027.\nThe spi_new_device() function fills in the modalias value from a passed in\nspi_board_info data block. Since it is a pointer copy, the new spi_device\nremains dependent on the spi_board_info structure after the new spi_device\nis registered (no other fields in spi_device directly depend on the\nspi_board_info structure; all of the other data is copied).\n\nThis causes a problem when dynamically propulating the list of attached\nSPI devices. For example, in arch/powerpc, the list of SPI devices can be\npopulated from data in the device tree. With the current code, the device\ntree adapter must kmalloc() a new spi_board_info structure for each new\nSPI device it finds in the device tree, and there is no simple mechanism\nin place for keeping track of these allocations.\n\nThis patch changes modalias from a \u0027const char *\u0027 to a fixed char array.\nBy copying the modalias string instead of referencing it, the dependency\non the spi_board_info structure is eliminated and an outside caller does\nnot need to maintain a separate spi_board_info allocation for each device.\n\nIf searched through the code to the best of my ability for any references\nto modalias which may be affected by this change and haven\u0027t found\nanything. It has been tested with the lite5200b platform in arch/powerpc.\n\n[dbrownell@users.sourceforge.net: cope with linux-next changes: KOBJ_NAME_LEN obliterated, etc]\nSigned-off-by: Grant Likely \u003cgrant.likely@secretlab.ca\u003e\nSigned-off-by: David Brownell \u003cdbrownell@users.sourceforge.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6291fe2abce4689d6ee7cbaea16692c79bf0d01b", "tree": "088f71d0f8c730ba8667484940027aaf76c0c95e", "parents": [ "166a375b657b7af494f4ce3f72c4d2002180da44" ], "author": { "name": "Robert P. J. Day", "email": "rpjday@crashcourse.ca", "time": "Wed Jul 23 21:29:53 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "SPI Kconfig simplifications\n\nUse \"if SPI_MASTER\" to remove numerous dependencies.\n\n[dbrownell@users.sourceforge.net: remove a couple now-needless EXPERIMENTAL dependencies too]\nSigned-off-by: Robert P. J. Day \u003crpjday@crashcourse.ca\u003e\nSigned-off-by: David Brownell \u003cdbrownell@users.sourceforge.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "166a375b657b7af494f4ce3f72c4d2002180da44", "tree": "02a3c51a478535b582b4d38833755fc3cfa82d3e", "parents": [ "a61f5345eba34772a71523227de890a28410f320" ], "author": { "name": "Roel Kluin", "email": "12o3l@tiscali.nl", "time": "Wed Jul 23 21:29:53 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "xilinx_spi: test below 0 on unsigned irq in xilinx_spi_probe()\n\nxilinx_spi-\u003eirq is unsigned, so the test fails\n\nSigned-off-by: Roel Kluin \u003c12o3l@tiscali.nl\u003e\nCc: David Brownell \u003cdbrownell@users.sourceforge.net\u003e\nCc: Andrei Konovalov \u003cakonovalov@ru.mvista.com\u003e\nCc: Yuri Frolov \u003cyfrolov@ru.mvista.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a61f5345eba34772a71523227de890a28410f320", "tree": "28c038919fa2d526dbf6992d88956409d0beffc2", "parents": [ "708d8cefd0f6d8dc13027f899e865ccfa5f63871" ], "author": { "name": "Chen Gong", "email": "g.chen@freescale.com", "time": "Wed Jul 23 21:29:52 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "spi: spi_mpc83xx clockrate fixes\n\nThis updates the SPI clock rate calculations for the spi_mpc83xx driver.\nSome boundary conditions were wrong, and in several cases divide-by-16\nwasn\u0027t always needed\n\nSigned-off-by: Chen Gong \u003cg.chen@freescale.com\u003e\nSigned-off-by: David Brownell \u003cdbrownell@users.sourceforge.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "708d8cefd0f6d8dc13027f899e865ccfa5f63871", "tree": "e6d6efb7b82615d76b46fcc24c25188958cf8507", "parents": [ "ae2d4c396e19f45918ed6e0900b031538d009823" ], "author": { "name": "Andre Haupt", "email": "andre@bitwigglers.org", "time": "Wed Jul 23 21:29:51 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "stallion: removed unused variable\n\nSigned-off-by: Andre Haupt \u003candre@bitwigglers.org\u003e\nAcked-by: Alan Cox \u003calan@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ae2d4c396e19f45918ed6e0900b031538d009823", "tree": "809061b816c0ef3a724df8c7369632fb2dda58cd", "parents": [ "e9a8f4d1de12633bfb71b5fee47745b32877b7b5" ], "author": { "name": "Nye Liu", "email": "nyet@mrv.com", "time": "Wed Jul 23 21:29:50 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:30 2008 -0700" }, "message": "cpm1: don\u0027t send break on TX_STOP, don\u0027t interrupt RX/TX when adjusting termios parameters\n\nBefore setting STOP_TX, set _brkcr to 0 so the SMC does not send a break\ncharacter. The driver appears to properly re-initialize _brkcr when the\nSMC is restarted.\n\nDo not interrupt RX/TX when the termios is being adjusted; it results in\ncorrupted characters appearing on the line.\n\nCc: Vitaly Bordug \u003cvbordug@ru.mvista.com\u003e\nCc: Scott Wood \u003cscottwood@freescale.com\u003e\nCc: Paul Mackerras \u003cpaulus@samba.org\u003e\nCc: Kumar Gala \u003cgalak@kernel.crashing.org\u003e\nCc: Alan Cox \u003calan@lxorguk.ukuu.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e9a8f4d1de12633bfb71b5fee47745b32877b7b5", "tree": "3bf0f747b32314491b9b6cf4f44a2c6d3288390e", "parents": [ "377135912806ddc87d56d64fafa685f4063c45f1" ], "author": { "name": "Maciej W. Rozycki", "email": "macro@linux-mips.org", "time": "Wed Jul 23 21:29:49 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "serial: DZ11: avoid a hang at console switch-over\n\nChanges to the generic console support code that happened a while ago\nintroduced a scenario where the initial console is used in parallel with\nthe final console during a brief period when switching between the two is\nin progress. During that time a message about the switch-over is printed.\n\nWith some combinations of chips, firmware and drivers, such as the DEC\nDZ11 clone used with the DECstation, a hang may happen because the\nfirmware used for the initial console may not expect the state of the chip\nafter it has been initialised by the driver.\n\nThis is a workaround for the DZ11 which reuses the power-management\ncallback to keep the transmitter of the line associated with the console\nenabled. It reflects the consensus reached in a discussion a while ago.\n\nSigned-off-by: Maciej W. Rozycki \u003cmacro@linux-mips.org\u003e\nCc: Jiri Slaby \u003cjirislaby@gmail.com\u003e\nCc: Alan Cox \u003calan@lxorguk.ukuu.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "377135912806ddc87d56d64fafa685f4063c45f1", "tree": "77165d6a19281278d54c0b054ffacf7472bd093e", "parents": [ "b76c5a0717094f0a900d9afd8e36f7ad8dbba587" ], "author": { "name": "Maciej W. Rozycki", "email": "macro@linux-mips.org", "time": "Wed Jul 23 21:29:48 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "serial: Z85C30: avoid a hang at console switch-over\n\nChanges to the generic console support code that happened a while ago\nintroduced a scenario where the initial console is used in parallel with\nthe final console during a brief period when switching between the two is\nin progress. During that time a message about the switch-over is printed.\n\nWith some combinations of chips, firmware and drivers, such as the Zilog\nZ85C30 SCC used with the DECstation, a hang may happen because the\nfirmware used for the initial console may not expect the state of the chip\nafter it has been initialised by the driver. This is not a bug in the\nfirmware, as some registers it would have to examine are write-only.\n\nThis is a workaround for the Z85C30 which reuses the power-management\ncallback to keep the transmitter of the line associated with the console\nenabled. It reflects the consensus reached in a discussion a while ago.\n\nSigned-off-by: Maciej W. Rozycki \u003cmacro@linux-mips.org\u003e\nCc: Jiri Slaby \u003cjirislaby@gmail.com\u003e\nCc: Alan Cox \u003calan@lxorguk.ukuu.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b76c5a0717094f0a900d9afd8e36f7ad8dbba587", "tree": "455097900805ea7566d0a2f6b978df47e8a4ee4b", "parents": [ "7500b1f602aad75901774a67a687ee985d85893f" ], "author": { "name": "Catalin(ux) M BOIE", "email": "catab@embedromix.ro", "time": "Wed Jul 23 21:29:46 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "serial: add support for a no-name 4 ports multiserial card\n\nIt is a no-name PCI card. I found no reference to a producer so I used\n\"UNKNOWN_0x1584\" as the name.\n\nFull lspci:\n01:07.0 0780: 10b5:9050 (rev 01)\n Subsystem: 10b5:1584\n Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- \\\n ParErr- Stepping- SERR+ FastB2B-\n Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- \\\n DEVSEL\u003dmedium \u003eTAbort- \u003cTAbort- \u003cMAbort- \u003eSERR- \u003cPERR-\n Interrupt: pin A routed to IRQ 10\n Region 1: I/O ports at ec00 [size\u003d128]\n Region 2: I/O ports at e480 [size\u003d32]\n Region 3: I/O ports at e400 [size\u003d8]\n Capabilities: [40] Power Management version 1\n Flags: PMEClk- DSI- D1- D2- AuxCurrent\u003d0mA \\\n PME(D0+,D1-,D2-,D3hot+,D3cold-)\n Status: D0 PME-Enable- DSel\u003d0 DScale\u003d0 PME-\n Capabilities: [48] #06 [0080]\n Capabilities: [4c] Vital Product Data\n\nAfter:\n0000:01:07.0: ttyS4 at I/O 0xe480 (irq \u003d 10) is a 16550A\n0000:01:07.0: ttyS5 at I/O 0xe488 (irq \u003d 10) is a 16550A\n0000:01:07.0: ttyS6 at I/O 0xe490 (irq \u003d 10) is a 16550A\n0000:01:07.0: ttyS7 at I/O 0xe498 (irq \u003d 10) is a 16550A\n\nSigned-off-by: Catalin(ux) M BOIE \u003ccatab@embedromix.ro\u003e\nAcked-by: Alan Cox \u003calan@redhat.com\u003e\nAcked-by: Russell King \u003crmk+kernel@arm.linux.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7500b1f602aad75901774a67a687ee985d85893f", "tree": "52afbdf19a5186e307fa9da68a1070431ad46b3a", "parents": [ "920519c1c31ca46ef6caab1a4be102ed0dfb5fbc" ], "author": { "name": "Aristeu Rozanski", "email": "arozansk@redhat.com", "time": "Wed Jul 23 21:29:45 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "8250: fix break handling for Intel 82571\n\nIntel 82571 has a \"Serial Over LAN\" feature that doesn\u0027t properly\nimplements the receiving of break characters. When a break is received,\nit doesn\u0027t set UART_LSR_DR and unless another character is received, the\nbreak won\u0027t be received by the application.\n\nSigned-off-by: Aristeu Rozanski \u003carozansk@redhat.com\u003e\nAcked-by: Alan Cox \u003calan@lxorguk.ukuu.org.uk\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "920519c1c31ca46ef6caab1a4be102ed0dfb5fbc", "tree": "bf6e785099a62194bb219070a9cda33f5b166980", "parents": [ "9fe5ad9c8cef9ad5873d8ee55d1cf00d9b607df0" ], "author": { "name": "Adrian Bunk", "email": "bunk@kernel.org", "time": "Wed Jul 23 21:29:44 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "serial/8250_gsc.c: add MODULE_LICENSE\n\nThis patch adds the missing MODULE_LICENSE(\"GPL\").\n\nSigned-off-by: Adrian Bunk \u003cbunk@kernel.org\u003e\nAcked-by: Alan Cox \u003calan@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9fe5ad9c8cef9ad5873d8ee55d1cf00d9b607df0", "tree": "49fb04cf552192e566d2aa6e18f40585230cba5a", "parents": [ "e38b36f325153eaadd1c2a7abc5762079233e540" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:43 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "flag parameters add-on: remove epoll_create size param\n\nRemove the size parameter from the new epoll_create syscall and renames the\nsyscall itself. The updated test program follows.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003ctime.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_epoll_create2\n# ifdef __x86_64__\n# define __NR_epoll_create2 291\n# elif defined __i386__\n# define __NR_epoll_create2 329\n# else\n# error \"need __NR_epoll_create2\"\n# endif\n#endif\n\n#define EPOLL_CLOEXEC O_CLOEXEC\n\nint\nmain (void)\n{\n int fd \u003d syscall (__NR_epoll_create2, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"epoll_create2(0) failed\");\n return 1;\n }\n int coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (coe \u0026 FD_CLOEXEC)\n {\n puts (\"epoll_create2(0) set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n fd \u003d syscall (__NR_epoll_create2, EPOLL_CLOEXEC);\n if (fd \u003d\u003d -1)\n {\n puts (\"epoll_create2(EPOLL_CLOEXEC) failed\");\n return 1;\n }\n coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((coe \u0026 FD_CLOEXEC) \u003d\u003d 0)\n {\n puts (\"epoll_create2(EPOLL_CLOEXEC) set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nCc: \u003clinux-arch@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e38b36f325153eaadd1c2a7abc5762079233e540", "tree": "92cfc9855e41c5328d91456f5e373c00ecb8d383", "parents": [ "510df2dd482496083e1c3b1a8c9b6afd5fa4c7d7" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:42 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "flag parameters: check magic constants\n\nThis patch adds test that ensure the boundary conditions for the various\nconstants introduced in the previous patches is met. No code is generated.\n\n[akpm@linux-foundation.org: fix alpha]\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "510df2dd482496083e1c3b1a8c9b6afd5fa4c7d7", "tree": "cb6fe277b361e13c100d20db5e3689d0e3abca45", "parents": [ "be61a86d7237dd80510615f38ae21d6e1e98660c" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:41 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "flag parameters: NONBLOCK in inotify_init\n\nThis patch adds non-blocking support for inotify_init1. The\nadditional changes needed are minimal.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_inotify_init1\n# ifdef __x86_64__\n# define __NR_inotify_init1 294\n# elif defined __i386__\n# define __NR_inotify_init1 332\n# else\n# error \"need __NR_inotify_init1\"\n# endif\n#endif\n\n#define IN_NONBLOCK O_NONBLOCK\n\nint\nmain (void)\n{\n int fd \u003d syscall (__NR_inotify_init1, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"inotify_init1(0) failed\");\n return 1;\n }\n int fl \u003d fcntl (fd, F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (fl \u0026 O_NONBLOCK)\n {\n puts (\"inotify_init1(0) set non-blocking mode\");\n return 1;\n }\n close (fd);\n\n fd \u003d syscall (__NR_inotify_init1, IN_NONBLOCK);\n if (fd \u003d\u003d -1)\n {\n puts (\"inotify_init1(IN_NONBLOCK) failed\");\n return 1;\n }\n fl \u003d fcntl (fd, F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((fl \u0026 O_NONBLOCK) \u003d\u003d 0)\n {\n puts (\"inotify_init1(IN_NONBLOCK) set non-blocking mode\");\n return 1;\n }\n close (fd);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "be61a86d7237dd80510615f38ae21d6e1e98660c", "tree": "3dfe6c8275c724533f88525970a4065ae795f6e3", "parents": [ "6b1ef0e60d42f2fdaec26baee8327eb156347b4f" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:40 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "flag parameters: NONBLOCK in pipe\n\nThis patch adds O_NONBLOCK support to pipe2. It is minimally more involved\nthan the patches for eventfd et.al but still trivial. The interfaces of the\ncreate_write_pipe and create_read_pipe helper functions were changed and the\none other caller as well.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_pipe2\n# ifdef __x86_64__\n# define __NR_pipe2 293\n# elif defined __i386__\n# define __NR_pipe2 331\n# else\n# error \"need __NR_pipe2\"\n# endif\n#endif\n\nint\nmain (void)\n{\n int fds[2];\n if (syscall (__NR_pipe2, fds, 0) \u003d\u003d -1)\n {\n puts (\"pipe2(0) failed\");\n return 1;\n }\n for (int i \u003d 0; i \u003c 2; ++i)\n {\n int fl \u003d fcntl (fds[i], F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (fl \u0026 O_NONBLOCK)\n {\n printf (\"pipe2(0) set non-blocking mode for fds[%d]\\n\", i);\n return 1;\n }\n close (fds[i]);\n }\n\n if (syscall (__NR_pipe2, fds, O_NONBLOCK) \u003d\u003d -1)\n {\n puts (\"pipe2(O_NONBLOCK) failed\");\n return 1;\n }\n for (int i \u003d 0; i \u003c 2; ++i)\n {\n int fl \u003d fcntl (fds[i], F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((fl \u0026 O_NONBLOCK) \u003d\u003d 0)\n {\n printf (\"pipe2(O_NONBLOCK) does not set non-blocking mode for fds[%d]\\n\", i);\n return 1;\n }\n close (fds[i]);\n }\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6b1ef0e60d42f2fdaec26baee8327eb156347b4f", "tree": "84f7e417f0c1f637ed10d42406276cff83849d69", "parents": [ "e7d476dfdf0bcfed478a207aecfdc84f81efecaf" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:39 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "flag parameters: NONBLOCK in timerfd_create\n\nThis patch adds support for the TFD_NONBLOCK flag to timerfd_create. The\nadditional changes needed are minimal.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003ctime.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_timerfd_create\n# ifdef __x86_64__\n# define __NR_timerfd_create 283\n# elif defined __i386__\n# define __NR_timerfd_create 322\n# else\n# error \"need __NR_timerfd_create\"\n# endif\n#endif\n\n#define TFD_NONBLOCK O_NONBLOCK\n\nint\nmain (void)\n{\n int fd \u003d syscall (__NR_timerfd_create, CLOCK_REALTIME, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"timerfd_create(0) failed\");\n return 1;\n }\n int fl \u003d fcntl (fd, F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (fl \u0026 O_NONBLOCK)\n {\n puts (\"timerfd_create(0) set non-blocking mode\");\n return 1;\n }\n close (fd);\n\n fd \u003d syscall (__NR_timerfd_create, CLOCK_REALTIME, TFD_NONBLOCK);\n if (fd \u003d\u003d -1)\n {\n puts (\"timerfd_create(TFD_NONBLOCK) failed\");\n return 1;\n }\n fl \u003d fcntl (fd, F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((fl \u0026 O_NONBLOCK) \u003d\u003d 0)\n {\n puts (\"timerfd_create(TFD_NONBLOCK) set non-blocking mode\");\n return 1;\n }\n close (fd);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e7d476dfdf0bcfed478a207aecfdc84f81efecaf", "tree": "8adc7f4cf562cd0e283d4abdaa0633686a59d8b2", "parents": [ "5fb5e04926a54bc1c22bba7ca166840f4476196f" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:38 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "flag parameters: NONBLOCK in eventfd\n\nThis patch adds support for the EFD_NONBLOCK flag to eventfd2. The\nadditional changes needed are minimal.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_eventfd2\n# ifdef __x86_64__\n# define __NR_eventfd2 290\n# elif defined __i386__\n# define __NR_eventfd2 328\n# else\n# error \"need __NR_eventfd2\"\n# endif\n#endif\n\n#define EFD_NONBLOCK O_NONBLOCK\n\nint\nmain (void)\n{\n int fd \u003d syscall (__NR_eventfd2, 1, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"eventfd2(0) failed\");\n return 1;\n }\n int fl \u003d fcntl (fd, F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (fl \u0026 O_NONBLOCK)\n {\n puts (\"eventfd2(0) sets non-blocking mode\");\n return 1;\n }\n close (fd);\n\n fd \u003d syscall (__NR_eventfd2, 1, EFD_NONBLOCK);\n if (fd \u003d\u003d -1)\n {\n puts (\"eventfd2(EFD_NONBLOCK) failed\");\n return 1;\n }\n fl \u003d fcntl (fd, F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((fl \u0026 O_NONBLOCK) \u003d\u003d 0)\n {\n puts (\"eventfd2(EFD_NONBLOCK) does not set non-blocking mode\");\n return 1;\n }\n close (fd);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5fb5e04926a54bc1c22bba7ca166840f4476196f", "tree": "999cf1d58e85ca801a03baeba114b9e8d2734249", "parents": [ "77d2720059618b9b6e827a8b73831eb6c6fad63c" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:37 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "flag parameters: NONBLOCK in signalfd\n\nThis patch adds support for the SFD_NONBLOCK flag to signalfd4. The\nadditional changes needed are minimal.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003csignal.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_signalfd4\n# ifdef __x86_64__\n# define __NR_signalfd4 289\n# elif defined __i386__\n# define __NR_signalfd4 327\n# else\n# error \"need __NR_signalfd4\"\n# endif\n#endif\n\n#define SFD_NONBLOCK O_NONBLOCK\n\nint\nmain (void)\n{\n sigset_t ss;\n sigemptyset (\u0026ss);\n sigaddset (\u0026ss, SIGUSR1);\n int fd \u003d syscall (__NR_signalfd4, -1, \u0026ss, 8, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"signalfd4(0) failed\");\n return 1;\n }\n int fl \u003d fcntl (fd, F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (fl \u0026 O_NONBLOCK)\n {\n puts (\"signalfd4(0) set non-blocking mode\");\n return 1;\n }\n close (fd);\n\n fd \u003d syscall (__NR_signalfd4, -1, \u0026ss, 8, SFD_NONBLOCK);\n if (fd \u003d\u003d -1)\n {\n puts (\"signalfd4(SFD_NONBLOCK) failed\");\n return 1;\n }\n fl \u003d fcntl (fd, F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((fl \u0026 O_NONBLOCK) \u003d\u003d 0)\n {\n puts (\"signalfd4(SFD_NONBLOCK) does not set non-blocking mode\");\n return 1;\n }\n close (fd);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "77d2720059618b9b6e827a8b73831eb6c6fad63c", "tree": "c8a08caa9a864c546fda2e043d5232c377d210c6", "parents": [ "99829b832997d907c30669bfd17da32151e18f04" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:35 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:29 2008 -0700" }, "message": "flag parameters: NONBLOCK in socket and socketpair\n\nThis patch introduces support for the SOCK_NONBLOCK flag in socket,\nsocketpair, and paccept. To do this the internal function sock_attach_fd\ngets an additional parameter which it uses to set the appropriate flag for\nthe file descriptor.\n\nGiven that in modern, scalable programs almost all socket connections are\nnon-blocking and the minimal additional cost for the new functionality\nI see no reason not to add this code.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cpthread.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003cnetinet/in.h\u003e\n#include \u003csys/socket.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_paccept\n# ifdef __x86_64__\n# define __NR_paccept 288\n# elif defined __i386__\n# define SYS_PACCEPT 18\n# define USE_SOCKETCALL 1\n# else\n# error \"need __NR_paccept\"\n# endif\n#endif\n\n#ifdef USE_SOCKETCALL\n# define paccept(fd, addr, addrlen, mask, flags) \\\n ({ long args[6] \u003d { \\\n (long) fd, (long) addr, (long) addrlen, (long) mask, 8, (long) flags }; \\\n syscall (__NR_socketcall, SYS_PACCEPT, args); })\n#else\n# define paccept(fd, addr, addrlen, mask, flags) \\\n syscall (__NR_paccept, fd, addr, addrlen, mask, 8, flags)\n#endif\n\n#define PORT 57392\n\n#define SOCK_NONBLOCK O_NONBLOCK\n\nstatic pthread_barrier_t b;\n\nstatic void *\ntf (void *arg)\n{\n pthread_barrier_wait (\u0026b);\n int s \u003d socket (AF_INET, SOCK_STREAM, 0);\n struct sockaddr_in sin;\n sin.sin_family \u003d AF_INET;\n sin.sin_addr.s_addr \u003d htonl (INADDR_LOOPBACK);\n sin.sin_port \u003d htons (PORT);\n connect (s, (const struct sockaddr *) \u0026sin, sizeof (sin));\n close (s);\n pthread_barrier_wait (\u0026b);\n\n pthread_barrier_wait (\u0026b);\n s \u003d socket (AF_INET, SOCK_STREAM, 0);\n sin.sin_port \u003d htons (PORT);\n connect (s, (const struct sockaddr *) \u0026sin, sizeof (sin));\n close (s);\n pthread_barrier_wait (\u0026b);\n\n return NULL;\n}\n\nint\nmain (void)\n{\n int fd;\n fd \u003d socket (PF_INET, SOCK_STREAM, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"socket(0) failed\");\n return 1;\n }\n int fl \u003d fcntl (fd, F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (fl \u0026 O_NONBLOCK)\n {\n puts (\"socket(0) set non-blocking mode\");\n return 1;\n }\n close (fd);\n\n fd \u003d socket (PF_INET, SOCK_STREAM|SOCK_NONBLOCK, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"socket(SOCK_NONBLOCK) failed\");\n return 1;\n }\n fl \u003d fcntl (fd, F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((fl \u0026 O_NONBLOCK) \u003d\u003d 0)\n {\n puts (\"socket(SOCK_NONBLOCK) does not set non-blocking mode\");\n return 1;\n }\n close (fd);\n\n int fds[2];\n if (socketpair (PF_UNIX, SOCK_STREAM, 0, fds) \u003d\u003d -1)\n {\n puts (\"socketpair(0) failed\");\n return 1;\n }\n for (int i \u003d 0; i \u003c 2; ++i)\n {\n fl \u003d fcntl (fds[i], F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (fl \u0026 O_NONBLOCK)\n {\n printf (\"socketpair(0) set non-blocking mode for fds[%d]\\n\", i);\n return 1;\n }\n close (fds[i]);\n }\n\n if (socketpair (PF_UNIX, SOCK_STREAM|SOCK_NONBLOCK, 0, fds) \u003d\u003d -1)\n {\n puts (\"socketpair(SOCK_NONBLOCK) failed\");\n return 1;\n }\n for (int i \u003d 0; i \u003c 2; ++i)\n {\n fl \u003d fcntl (fds[i], F_GETFL);\n if (fl \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((fl \u0026 O_NONBLOCK) \u003d\u003d 0)\n {\n printf (\"socketpair(SOCK_NONBLOCK) does not set non-blocking mode for fds[%d]\\n\", i);\n return 1;\n }\n close (fds[i]);\n }\n\n pthread_barrier_init (\u0026b, NULL, 2);\n\n struct sockaddr_in sin;\n pthread_t th;\n if (pthread_create (\u0026th, NULL, tf, NULL) !\u003d 0)\n {\n puts (\"pthread_create failed\");\n return 1;\n }\n\n int s \u003d socket (AF_INET, SOCK_STREAM, 0);\n int reuse \u003d 1;\n setsockopt (s, SOL_SOCKET, SO_REUSEADDR, \u0026reuse, sizeof (reuse));\n sin.sin_family \u003d AF_INET;\n sin.sin_addr.s_addr \u003d htonl (INADDR_LOOPBACK);\n sin.sin_port \u003d htons (PORT);\n bind (s, (struct sockaddr *) \u0026sin, sizeof (sin));\n listen (s, SOMAXCONN);\n\n pthread_barrier_wait (\u0026b);\n\n int s2 \u003d paccept (s, NULL, 0, NULL, 0);\n if (s2 \u003c 0)\n {\n puts (\"paccept(0) failed\");\n return 1;\n }\n\n fl \u003d fcntl (s2, F_GETFL);\n if (fl \u0026 O_NONBLOCK)\n {\n puts (\"paccept(0) set non-blocking mode\");\n return 1;\n }\n close (s2);\n close (s);\n\n pthread_barrier_wait (\u0026b);\n\n s \u003d socket (AF_INET, SOCK_STREAM, 0);\n sin.sin_port \u003d htons (PORT);\n setsockopt (s, SOL_SOCKET, SO_REUSEADDR, \u0026reuse, sizeof (reuse));\n bind (s, (struct sockaddr *) \u0026sin, sizeof (sin));\n listen (s, SOMAXCONN);\n\n pthread_barrier_wait (\u0026b);\n\n s2 \u003d paccept (s, NULL, 0, NULL, SOCK_NONBLOCK);\n if (s2 \u003c 0)\n {\n puts (\"paccept(SOCK_NONBLOCK) failed\");\n return 1;\n }\n\n fl \u003d fcntl (s2, F_GETFL);\n if ((fl \u0026 O_NONBLOCK) \u003d\u003d 0)\n {\n puts (\"paccept(SOCK_NONBLOCK) does not set non-blocking mode\");\n return 1;\n }\n close (s2);\n close (s);\n\n pthread_barrier_wait (\u0026b);\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nCc: \"David S. Miller\" \u003cdavem@davemloft.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "99829b832997d907c30669bfd17da32151e18f04", "tree": "a9d4b9a3e475891198de0f37d376bda053399bde", "parents": [ "4006553b06306b34054529477b06b68a1c66249b" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:33 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:28 2008 -0700" }, "message": "flag parameters: NONBLOCK in anon_inode_getfd\n\nBuilding on the previous change to anon_inode_getfd, this patch introduces\nsupport for handling of O_NONBLOCK in addition to the already supported\nO_CLOEXEC. Following patches will take advantage of this support. As can be\nseen, the additional support for supporting this functionality is minimal.\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4006553b06306b34054529477b06b68a1c66249b", "tree": "d4ebbe4a5294b0cec69fe4908b7b7c569f4ece03", "parents": [ "ed8cae8ba01348bfd83333f4648dd807b04d7f08" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:32 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:28 2008 -0700" }, "message": "flag parameters: inotify_init\n\nThis patch introduces the new syscall inotify_init1 (note: the 1 stands for\nthe one parameter the syscall takes, as opposed to no parameter before). The\nvalues accepted for this parameter are function-specific and defined in the\ninotify.h header. Here the values must match the O_* flags, though. In this\npatch CLOEXEC support is introduced.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_inotify_init1\n# ifdef __x86_64__\n# define __NR_inotify_init1 294\n# elif defined __i386__\n# define __NR_inotify_init1 332\n# else\n# error \"need __NR_inotify_init1\"\n# endif\n#endif\n\n#define IN_CLOEXEC O_CLOEXEC\n\nint\nmain (void)\n{\n int fd;\n fd \u003d syscall (__NR_inotify_init1, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"inotify_init1(0) failed\");\n return 1;\n }\n int coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (coe \u0026 FD_CLOEXEC)\n {\n puts (\"inotify_init1(0) set close-on-exit\");\n return 1;\n }\n close (fd);\n\n fd \u003d syscall (__NR_inotify_init1, IN_CLOEXEC);\n if (fd \u003d\u003d -1)\n {\n puts (\"inotify_init1(IN_CLOEXEC) failed\");\n return 1;\n }\n coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((coe \u0026 FD_CLOEXEC) \u003d\u003d 0)\n {\n puts (\"inotify_init1(O_CLOEXEC) does not set close-on-exit\");\n return 1;\n }\n close (fd);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n[akpm@linux-foundation.org: add sys_ni stub]\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nCc: \u003clinux-arch@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ed8cae8ba01348bfd83333f4648dd807b04d7f08", "tree": "c71a1c8e771c1c55728bb7c40612fbdcefbc858a", "parents": [ "336dd1f70ff62d7dd8655228caed4c5bfc818c56" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:30 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:28 2008 -0700" }, "message": "flag parameters: pipe\n\nThis patch introduces the new syscall pipe2 which is like pipe but it also\ntakes an additional parameter which takes a flag value. This patch implements\nthe handling of O_CLOEXEC for the flag. I did not add support for the new\nsyscall for the architectures which have a special sys_pipe implementation. I\nthink the maintainers of those archs have the chance to go with the unified\nimplementation but that\u0027s up to them.\n\nThe implementation introduces do_pipe_flags. I did that instead of changing\nall callers of do_pipe because some of the callers are written in assembler.\nI would probably screw up changing the assembly code. To avoid breaking code\ndo_pipe is now a small wrapper around do_pipe_flags. Once all callers are\nchanged over to do_pipe_flags the old do_pipe function can be removed.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_pipe2\n# ifdef __x86_64__\n# define __NR_pipe2 293\n# elif defined __i386__\n# define __NR_pipe2 331\n# else\n# error \"need __NR_pipe2\"\n# endif\n#endif\n\nint\nmain (void)\n{\n int fd[2];\n if (syscall (__NR_pipe2, fd, 0) !\u003d 0)\n {\n puts (\"pipe2(0) failed\");\n return 1;\n }\n for (int i \u003d 0; i \u003c 2; ++i)\n {\n int coe \u003d fcntl (fd[i], F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (coe \u0026 FD_CLOEXEC)\n {\n printf (\"pipe2(0) set close-on-exit for fd[%d]\\n\", i);\n return 1;\n }\n }\n close (fd[0]);\n close (fd[1]);\n\n if (syscall (__NR_pipe2, fd, O_CLOEXEC) !\u003d 0)\n {\n puts (\"pipe2(O_CLOEXEC) failed\");\n return 1;\n }\n for (int i \u003d 0; i \u003c 2; ++i)\n {\n int coe \u003d fcntl (fd[i], F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((coe \u0026 FD_CLOEXEC) \u003d\u003d 0)\n {\n printf (\"pipe2(O_CLOEXEC) does not set close-on-exit for fd[%d]\\n\", i);\n return 1;\n }\n }\n close (fd[0]);\n close (fd[1]);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nCc: \u003clinux-arch@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "336dd1f70ff62d7dd8655228caed4c5bfc818c56", "tree": "1441b76ea5f08f44167f41867f3555ac53712ebb", "parents": [ "a0998b50c3f0b8fdd265c63e0032f86ebe377dbf" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:29 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:28 2008 -0700" }, "message": "flag parameters: dup2\n\nThis patch adds the new dup3 syscall. It extends the old dup2 syscall by one\nparameter which is meant to hold a flag value. Support for the O_CLOEXEC flag\nis added in this patch.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003ctime.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_dup3\n# ifdef __x86_64__\n# define __NR_dup3 292\n# elif defined __i386__\n# define __NR_dup3 330\n# else\n# error \"need __NR_dup3\"\n# endif\n#endif\n\nint\nmain (void)\n{\n int fd \u003d syscall (__NR_dup3, 1, 4, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"dup3(0) failed\");\n return 1;\n }\n int coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (coe \u0026 FD_CLOEXEC)\n {\n puts (\"dup3(0) set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n fd \u003d syscall (__NR_dup3, 1, 4, O_CLOEXEC);\n if (fd \u003d\u003d -1)\n {\n puts (\"dup3(O_CLOEXEC) failed\");\n return 1;\n }\n coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((coe \u0026 FD_CLOEXEC) \u003d\u003d 0)\n {\n puts (\"dup3(O_CLOEXEC) set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nCc: \u003clinux-arch@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a0998b50c3f0b8fdd265c63e0032f86ebe377dbf", "tree": "9132ecb7ef925374edabcaeea44e0287eb5043f4", "parents": [ "11fcb6c14676023d0bd437841f5dcd670e7990a0" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:27 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:28 2008 -0700" }, "message": "flag parameters: epoll_create\n\nThis patch adds the new epoll_create2 syscall. It extends the old epoll_create\nsyscall by one parameter which is meant to hold a flag value. In this\npatch the only flag support is EPOLL_CLOEXEC which causes the close-on-exec\nflag for the returned file descriptor to be set.\n\nA new name EPOLL_CLOEXEC is introduced which in this implementation must\nhave the same value as O_CLOEXEC.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003ctime.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_epoll_create2\n# ifdef __x86_64__\n# define __NR_epoll_create2 291\n# elif defined __i386__\n# define __NR_epoll_create2 329\n# else\n# error \"need __NR_epoll_create2\"\n# endif\n#endif\n\n#define EPOLL_CLOEXEC O_CLOEXEC\n\nint\nmain (void)\n{\n int fd \u003d syscall (__NR_epoll_create2, 1, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"epoll_create2(0) failed\");\n return 1;\n }\n int coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (coe \u0026 FD_CLOEXEC)\n {\n puts (\"epoll_create2(0) set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n fd \u003d syscall (__NR_epoll_create2, 1, EPOLL_CLOEXEC);\n if (fd \u003d\u003d -1)\n {\n puts (\"epoll_create2(EPOLL_CLOEXEC) failed\");\n return 1;\n }\n coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((coe \u0026 FD_CLOEXEC) \u003d\u003d 0)\n {\n puts (\"epoll_create2(EPOLL_CLOEXEC) set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nCc: \u003clinux-arch@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "11fcb6c14676023d0bd437841f5dcd670e7990a0", "tree": "7b98614739715734d9cdd74f94982e110c953fc0", "parents": [ "b087498eb5605673b0f260a7620d91818cd72304" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:26 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "flag parameters: timerfd_create\n\nThe timerfd_create syscall already has a flags parameter. It just is\nunused so far. This patch changes this by introducing the TFD_CLOEXEC\nflag to set the close-on-exec flag for the returned file descriptor.\n\nA new name TFD_CLOEXEC is introduced which in this implementation must\nhave the same value as O_CLOEXEC.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003ctime.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_timerfd_create\n# ifdef __x86_64__\n# define __NR_timerfd_create 283\n# elif defined __i386__\n# define __NR_timerfd_create 322\n# else\n# error \"need __NR_timerfd_create\"\n# endif\n#endif\n\n#define TFD_CLOEXEC O_CLOEXEC\n\nint\nmain (void)\n{\n int fd \u003d syscall (__NR_timerfd_create, CLOCK_REALTIME, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"timerfd_create(0) failed\");\n return 1;\n }\n int coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (coe \u0026 FD_CLOEXEC)\n {\n puts (\"timerfd_create(0) set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n fd \u003d syscall (__NR_timerfd_create, CLOCK_REALTIME, TFD_CLOEXEC);\n if (fd \u003d\u003d -1)\n {\n puts (\"timerfd_create(TFD_CLOEXEC) failed\");\n return 1;\n }\n coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((coe \u0026 FD_CLOEXEC) \u003d\u003d 0)\n {\n puts (\"timerfd_create(TFD_CLOEXEC) set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b087498eb5605673b0f260a7620d91818cd72304", "tree": "977d9dbcd326a9582dfc5ad000995d26886c872e", "parents": [ "9deb27baedb79759c3ab9435a7d8b841842d56e9" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:25 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "flag parameters: eventfd\n\nThis patch adds the new eventfd2 syscall. It extends the old eventfd\nsyscall by one parameter which is meant to hold a flag value. In this\npatch the only flag support is EFD_CLOEXEC which causes the close-on-exec\nflag for the returned file descriptor to be set.\n\nA new name EFD_CLOEXEC is introduced which in this implementation must\nhave the same value as O_CLOEXEC.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_eventfd2\n# ifdef __x86_64__\n# define __NR_eventfd2 290\n# elif defined __i386__\n# define __NR_eventfd2 328\n# else\n# error \"need __NR_eventfd2\"\n# endif\n#endif\n\n#define EFD_CLOEXEC O_CLOEXEC\n\nint\nmain (void)\n{\n int fd \u003d syscall (__NR_eventfd2, 1, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"eventfd2(0) failed\");\n return 1;\n }\n int coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (coe \u0026 FD_CLOEXEC)\n {\n puts (\"eventfd2(0) sets close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n fd \u003d syscall (__NR_eventfd2, 1, EFD_CLOEXEC);\n if (fd \u003d\u003d -1)\n {\n puts (\"eventfd2(EFD_CLOEXEC) failed\");\n return 1;\n }\n coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((coe \u0026 FD_CLOEXEC) \u003d\u003d 0)\n {\n puts (\"eventfd2(EFD_CLOEXEC) does not set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n[akpm@linux-foundation.org: add sys_ni stub]\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nCc: \u003clinux-arch@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9deb27baedb79759c3ab9435a7d8b841842d56e9", "tree": "1c88393ba30db851ca0bb93c4e656d4e5dbb22b9", "parents": [ "7d9dbca34240ebb6ff88d8a29c6c7bffd098f0c1" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:24 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "flag parameters: signalfd\n\nThis patch adds the new signalfd4 syscall. It extends the old signalfd\nsyscall by one parameter which is meant to hold a flag value. In this\npatch the only flag support is SFD_CLOEXEC which causes the close-on-exec\nflag for the returned file descriptor to be set.\n\nA new name SFD_CLOEXEC is introduced which in this implementation must\nhave the same value as O_CLOEXEC.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003csignal.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_signalfd4\n# ifdef __x86_64__\n# define __NR_signalfd4 289\n# elif defined __i386__\n# define __NR_signalfd4 327\n# else\n# error \"need __NR_signalfd4\"\n# endif\n#endif\n\n#define SFD_CLOEXEC O_CLOEXEC\n\nint\nmain (void)\n{\n sigset_t ss;\n sigemptyset (\u0026ss);\n sigaddset (\u0026ss, SIGUSR1);\n int fd \u003d syscall (__NR_signalfd4, -1, \u0026ss, 8, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"signalfd4(0) failed\");\n return 1;\n }\n int coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (coe \u0026 FD_CLOEXEC)\n {\n puts (\"signalfd4(0) set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n fd \u003d syscall (__NR_signalfd4, -1, \u0026ss, 8, SFD_CLOEXEC);\n if (fd \u003d\u003d -1)\n {\n puts (\"signalfd4(SFD_CLOEXEC) failed\");\n return 1;\n }\n coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((coe \u0026 FD_CLOEXEC) \u003d\u003d 0)\n {\n puts (\"signalfd4(SFD_CLOEXEC) does not set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n[akpm@linux-foundation.org: add sys_ni stub]\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nCc: \u003clinux-arch@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7d9dbca34240ebb6ff88d8a29c6c7bffd098f0c1", "tree": "7e3226a4d885f5e4444fbe01a08c51b0b33b2cc7", "parents": [ "c019bbc612f6633ede7ed67725cbf68de45ae8a4" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:22 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "flag parameters: anon_inode_getfd extension\n\nThis patch just extends the anon_inode_getfd interface to take an additional\nparameter with a flag value. The flag value is passed on to\nget_unused_fd_flags in anticipation for a use with the O_CLOEXEC flag.\n\nNo actual semantic changes here, the changed callers all pass 0 for now.\n\n[akpm@linux-foundation.org: KVM fix]\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c019bbc612f6633ede7ed67725cbf68de45ae8a4", "tree": "99b23660c2915e699f35f3fc5820b5cc30f890b3", "parents": [ "aaca0bdca573f3f51ea03139f9c7289541e7bca3" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:21 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "flag parameters: paccept w/out set_restore_sigmask\n\nSome platforms do not have support to restore the signal mask in the\nreturn path from a syscall. For those platforms syscalls like pselect are\nnot defined at all. This is, I think, not a good choice for paccept()\nsince paccept() adds more value on top of accept() than just the signal\nmask handling.\n\nTherefore this patch defines a scaled down version of the sys_paccept\nfunction for those platforms. It returns -EINVAL in case the signal mask\nis non-NULL but behaves the same otherwise.\n\nNote that I explicitly included \u003clinux/thread_info.h\u003e. I saw that it is\ncurrently included but indirectly two levels down. There is too much risk\nin relying on this. The header might change and then suddenly the\nfunction definition would change without anyone immediately noticing.\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nCc: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "aaca0bdca573f3f51ea03139f9c7289541e7bca3", "tree": "d25b0baa73b5301d91a5c848a896bad0fb719acc", "parents": [ "a677a039be7243357d93502bff2b40850c942e2d" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:20 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "flag parameters: paccept\n\nThis patch is by far the most complex in the series. It adds a new syscall\npaccept. This syscall differs from accept in that it adds (at the userlevel)\ntwo additional parameters:\n\n- a signal mask\n- a flags value\n\nThe flags parameter can be used to set flag like SOCK_CLOEXEC. This is\nimlpemented here as well. Some people argued that this is a property which\nshould be inherited from the file desriptor for the server but this is against\nPOSIX. Additionally, we really want the signal mask parameter as well\n(similar to pselect, ppoll, etc). So an interface change in inevitable.\n\nThe flag value is the same as for socket and socketpair. I think diverging\nhere will only create confusion. Similar to the filesystem interfaces where\nthe use of the O_* constants differs, it is acceptable here.\n\nThe signal mask is handled as for pselect etc. The mask is temporarily\ninstalled for the thread and removed before the call returns. I modeled the\ncode after pselect. If there is a problem it\u0027s likely also in pselect.\n\nFor architectures which use socketcall I maintained this interface instead of\nadding a system call. The symmetry shouldn\u0027t be broken.\n\nThe following test must be adjusted for architectures other than x86 and\nx86-64 and in case the syscall numbers changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cerrno.h\u003e\n#include \u003cfcntl.h\u003e\n#include \u003cpthread.h\u003e\n#include \u003csignal.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003cnetinet/in.h\u003e\n#include \u003csys/socket.h\u003e\n#include \u003csys/syscall.h\u003e\n\n#ifndef __NR_paccept\n# ifdef __x86_64__\n# define __NR_paccept 288\n# elif defined __i386__\n# define SYS_PACCEPT 18\n# define USE_SOCKETCALL 1\n# else\n# error \"need __NR_paccept\"\n# endif\n#endif\n\n#ifdef USE_SOCKETCALL\n# define paccept(fd, addr, addrlen, mask, flags) \\\n ({ long args[6] \u003d { \\\n (long) fd, (long) addr, (long) addrlen, (long) mask, 8, (long) flags }; \\\n syscall (__NR_socketcall, SYS_PACCEPT, args); })\n#else\n# define paccept(fd, addr, addrlen, mask, flags) \\\n syscall (__NR_paccept, fd, addr, addrlen, mask, 8, flags)\n#endif\n\n#define PORT 57392\n\n#define SOCK_CLOEXEC O_CLOEXEC\n\nstatic pthread_barrier_t b;\n\nstatic void *\ntf (void *arg)\n{\n pthread_barrier_wait (\u0026b);\n int s \u003d socket (AF_INET, SOCK_STREAM, 0);\n struct sockaddr_in sin;\n sin.sin_family \u003d AF_INET;\n sin.sin_addr.s_addr \u003d htonl (INADDR_LOOPBACK);\n sin.sin_port \u003d htons (PORT);\n connect (s, (const struct sockaddr *) \u0026sin, sizeof (sin));\n close (s);\n\n pthread_barrier_wait (\u0026b);\n s \u003d socket (AF_INET, SOCK_STREAM, 0);\n sin.sin_port \u003d htons (PORT);\n connect (s, (const struct sockaddr *) \u0026sin, sizeof (sin));\n close (s);\n pthread_barrier_wait (\u0026b);\n\n pthread_barrier_wait (\u0026b);\n sleep (2);\n pthread_kill ((pthread_t) arg, SIGUSR1);\n\n return NULL;\n}\n\nstatic void\nhandler (int s)\n{\n}\n\nint\nmain (void)\n{\n pthread_barrier_init (\u0026b, NULL, 2);\n\n struct sockaddr_in sin;\n pthread_t th;\n if (pthread_create (\u0026th, NULL, tf, (void *) pthread_self ()) !\u003d 0)\n {\n puts (\"pthread_create failed\");\n return 1;\n }\n\n int s \u003d socket (AF_INET, SOCK_STREAM, 0);\n int reuse \u003d 1;\n setsockopt (s, SOL_SOCKET, SO_REUSEADDR, \u0026reuse, sizeof (reuse));\n sin.sin_family \u003d AF_INET;\n sin.sin_addr.s_addr \u003d htonl (INADDR_LOOPBACK);\n sin.sin_port \u003d htons (PORT);\n bind (s, (struct sockaddr *) \u0026sin, sizeof (sin));\n listen (s, SOMAXCONN);\n\n pthread_barrier_wait (\u0026b);\n\n int s2 \u003d paccept (s, NULL, 0, NULL, 0);\n if (s2 \u003c 0)\n {\n puts (\"paccept(0) failed\");\n return 1;\n }\n\n int coe \u003d fcntl (s2, F_GETFD);\n if (coe \u0026 FD_CLOEXEC)\n {\n puts (\"paccept(0) set close-on-exec-flag\");\n return 1;\n }\n close (s2);\n\n pthread_barrier_wait (\u0026b);\n\n s2 \u003d paccept (s, NULL, 0, NULL, SOCK_CLOEXEC);\n if (s2 \u003c 0)\n {\n puts (\"paccept(SOCK_CLOEXEC) failed\");\n return 1;\n }\n\n coe \u003d fcntl (s2, F_GETFD);\n if ((coe \u0026 FD_CLOEXEC) \u003d\u003d 0)\n {\n puts (\"paccept(SOCK_CLOEXEC) does not set close-on-exec flag\");\n return 1;\n }\n close (s2);\n\n pthread_barrier_wait (\u0026b);\n\n struct sigaction sa;\n sa.sa_handler \u003d handler;\n sa.sa_flags \u003d 0;\n sigemptyset (\u0026sa.sa_mask);\n sigaction (SIGUSR1, \u0026sa, NULL);\n\n sigset_t ss;\n pthread_sigmask (SIG_SETMASK, NULL, \u0026ss);\n sigaddset (\u0026ss, SIGUSR1);\n pthread_sigmask (SIG_SETMASK, \u0026ss, NULL);\n\n sigdelset (\u0026ss, SIGUSR1);\n alarm (4);\n pthread_barrier_wait (\u0026b);\n\n errno \u003d 0 ;\n s2 \u003d paccept (s, NULL, 0, \u0026ss, 0);\n if (s2 !\u003d -1 || errno !\u003d EINTR)\n {\n puts (\"paccept did not fail with EINTR\");\n return 1;\n }\n\n close (s);\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n[akpm@linux-foundation.org: make it compile]\n[akpm@linux-foundation.org: add sys_ni stub]\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nCc: \u003clinux-arch@vger.kernel.org\u003e\nCc: \"David S. Miller\" \u003cdavem@davemloft.net\u003e\nCc: Roland McGrath \u003croland@redhat.com\u003e\nCc: Kyle McMartin \u003ckyle@mcmartin.ca\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a677a039be7243357d93502bff2b40850c942e2d", "tree": "6cf1669c4752e2527e02f33baa920cd2dfd59117", "parents": [ "6e2c10a12a2170856f5582d62d583cbcd1cb5eaf" ], "author": { "name": "Ulrich Drepper", "email": "drepper@redhat.com", "time": "Wed Jul 23 21:29:17 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "flag parameters: socket and socketpair\n\nThis patch adds support for flag values which are ORed to the type passwd\nto socket and socketpair. The additional code is minimal. The flag\nvalues in this implementation can and must match the O_* flags. This\navoids overhead in the conversion.\n\nThe internal functions sock_alloc_fd and sock_map_fd get a new parameters\nand all callers are changed.\n\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n#include \u003cfcntl.h\u003e\n#include \u003cstdio.h\u003e\n#include \u003cunistd.h\u003e\n#include \u003cnetinet/in.h\u003e\n#include \u003csys/socket.h\u003e\n\n#define PORT 57392\n\n/* For Linux these must be the same. */\n#define SOCK_CLOEXEC O_CLOEXEC\n\nint\nmain (void)\n{\n int fd;\n fd \u003d socket (PF_INET, SOCK_STREAM, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"socket(0) failed\");\n return 1;\n }\n int coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (coe \u0026 FD_CLOEXEC)\n {\n puts (\"socket(0) set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n fd \u003d socket (PF_INET, SOCK_STREAM|SOCK_CLOEXEC, 0);\n if (fd \u003d\u003d -1)\n {\n puts (\"socket(SOCK_CLOEXEC) failed\");\n return 1;\n }\n coe \u003d fcntl (fd, F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((coe \u0026 FD_CLOEXEC) \u003d\u003d 0)\n {\n puts (\"socket(SOCK_CLOEXEC) does not set close-on-exec flag\");\n return 1;\n }\n close (fd);\n\n int fds[2];\n if (socketpair (PF_UNIX, SOCK_STREAM, 0, fds) \u003d\u003d -1)\n {\n puts (\"socketpair(0) failed\");\n return 1;\n }\n for (int i \u003d 0; i \u003c 2; ++i)\n {\n coe \u003d fcntl (fds[i], F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if (coe \u0026 FD_CLOEXEC)\n {\n printf (\"socketpair(0) set close-on-exec flag for fds[%d]\\n\", i);\n return 1;\n }\n close (fds[i]);\n }\n\n if (socketpair (PF_UNIX, SOCK_STREAM|SOCK_CLOEXEC, 0, fds) \u003d\u003d -1)\n {\n puts (\"socketpair(SOCK_CLOEXEC) failed\");\n return 1;\n }\n for (int i \u003d 0; i \u003c 2; ++i)\n {\n coe \u003d fcntl (fds[i], F_GETFD);\n if (coe \u003d\u003d -1)\n {\n puts (\"fcntl failed\");\n return 1;\n }\n if ((coe \u0026 FD_CLOEXEC) \u003d\u003d 0)\n {\n printf (\"socketpair(SOCK_CLOEXEC) does not set close-on-exec flag for fds[%d]\\n\", i);\n return 1;\n }\n close (fds[i]);\n }\n\n puts (\"OK\");\n\n return 0;\n}\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Ulrich Drepper \u003cdrepper@redhat.com\u003e\nAcked-by: Davide Libenzi \u003cdavidel@xmailserver.org\u003e\nCc: Michael Kerrisk \u003cmtk.manpages@googlemail.com\u003e\nCc: \"David S. Miller\" \u003cdavem@davemloft.net\u003e\nCc: Ralf Baechle \u003cralf@linux-mips.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6e2c10a12a2170856f5582d62d583cbcd1cb5eaf", "tree": "139bbb09655994b60eaa7c0e4bfccf775f4ab8e8", "parents": [ "76a6f3dc9a7108785c145a298f82c72f9208fe17" ], "author": { "name": "Akinobu Mita", "email": "akinobu.mita@gmail.com", "time": "Wed Jul 23 21:29:15 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "binfmt_misc: use simple_read_from_buffer()\n\nSigned-off-by: Akinobu Mita \u003cakinobu.mita@gmail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "76a6f3dc9a7108785c145a298f82c72f9208fe17", "tree": "3066b1f95336ea152a77b01317f27bd2cb861446", "parents": [ "7102ed519a08b70eadc8fea9d8765d2d990241d1" ], "author": { "name": "Adrian Bunk", "email": "bunk@kernel.org", "time": "Wed Jul 23 21:29:15 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "CONFIG_SOUND_WM97XX: remove stale makefile line\n\nThe driver is gone for a long time.\n\nReported-by: Robert P. J. Day \u003crpjday@crashcourse.ca\u003e\nSigned-off-by: Adrian Bunk \u003cbunk@kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7102ed519a08b70eadc8fea9d8765d2d990241d1", "tree": "f98b5992d340e66a72ae9e0807d732962de37cf8", "parents": [ "33cba0657393a75e18e1781e3e13613303f18124" ], "author": { "name": "Adrian Bunk", "email": "bunk@kernel.org", "time": "Wed Jul 23 21:29:13 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "remove the OSS trident driver\n\nSOUND_TRIDENT was the last PCI OSS driver, and since there\u0027s already an\nALSA driver for the same hardware we can remove it.\n\n[muli@il.ibm.com: update CREDITS]\nSigned-off-by: Adrian Bunk \u003cbunk@kernel.org\u003e\nSigned-off-by: Muli Ben-Yehuda \u003cmuli@il.ibm.com\u003e\nSigned-off-by: Muli Ben-Yehuda \u003cmuli@il.ibm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "33cba0657393a75e18e1781e3e13613303f18124", "tree": "81e492d8d9611cddd70165bd3def46a53773a482", "parents": [ "234fff6515a11cf3e67c793146689da426787fea" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:12 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:27 2008 -0700" }, "message": "checkpatch: version 0.21\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "234fff6515a11cf3e67c793146689da426787fea", "tree": "a16d881c498f1db608ed4c571186a2c42e3f12e8", "parents": [ "292f1a9b342d763f94ea3915726a48905be4acd1" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:12 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: types cannot start mid word for pointer tests\n\nWhen checking spacing for pointer checks the type cannot start in the\nmiddle of a word, ie. this is not \u0027int * bar\u0027:\n\n\tx \u003d fooint * bar;\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "292f1a9b342d763f94ea3915726a48905be4acd1", "tree": "599e54b48cddb386cd373520ad85a4dc13b7087d", "parents": [ "74048ed811152a995a88945ba9e0dded34adfff4" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:11 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: complex macros need to ignore comments\n\nEnsure we ignore comments in complex macro detection else we incorrectly\nreport this:\n\n\t#define PFM_GROUP_PERM_ANY -1 /* any user/group */\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "74048ed811152a995a88945ba9e0dded34adfff4", "tree": "6a129872a995f6fe24d02f3754ec50b69a6bd3f6", "parents": [ "1f65f947a6a875e1fe7867dc08e981c4101d435d" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:10 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: variants -- move the main unary/binary operators to use variants\n\nNow that we have a variants system, move to using that to carry the\nunary/binary designation for +, -, \u0026, and *.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1f65f947a6a875e1fe7867dc08e981c4101d435d", "tree": "2dec76eed9d3dd6a48bc226fbe3a6d2fa813af9c", "parents": [ "d2506586586c59f5db0e2ce00d5d31ccec6260b8" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:10 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: add checks for question mark and colon spacing\n\nAdd checks for the question mark colon operator spacing, and also check\nthe other uses of colon. Colon means a number of things:\n\n - it introduces the else part of the ?: operator,\n - it terminates a goto label,\n - it terminates the case value,\n - it separates the identifier from the bit size on bit fields, and\n - it is used to introduce option types in asm().\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d2506586586c59f5db0e2ce00d5d31ccec6260b8", "tree": "f55f7723e9a1ad6bcb5826bbb9a73b2579f7b846", "parents": [ "0221f55c142b0ac8baf6f0b6c4e1ec89f0c98e96" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:09 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: possible modifiers -- handle multiple modifiers and trailing\n\nAdd support for multiple modifiers such as:\n\n\tint __one __two foo;\n\nAlso handle trailing known modifiers when defecting modifiers:\n\n\tint __one foo __read_mostly;\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0221f55c142b0ac8baf6f0b6c4e1ec89f0c98e96", "tree": "49e16ea22f6247213e7fe7bba664ceba026ea783", "parents": [ "8ea3eb9a20f39d5afa52900a34092b4b5f6b55cb" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:08 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: possible types -- known modifiers cannot be types\n\nEnsure we do not inadvertantly load known modifiers up as possible types.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8ea3eb9a20f39d5afa52900a34092b4b5f6b55cb", "tree": "ad79fe0bade637209967aadf23a34447c717fe1a", "parents": [ "b8f96a31f38c8e9fc75f0a89c6815e7cbc402858" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:08 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: handle return types of pointers to functions\n\nMake sure we correctly mark the return type of the pointer to a function\ndeclaration.\n\n const void *(*sb_tag)(struct sysfs_tag_info *info);\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b8f96a31f38c8e9fc75f0a89c6815e7cbc402858", "tree": "d68058c4329c6cb32255f905a2aac02a3bfac273", "parents": [ "d2172eb5bd4b7d06577113ec40635083619ca54a" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:07 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: macro complexity checks are meaningless in linker scripts\n\nExclude vmlinux.lds.h from the macro complexity checks. They will never\napply sanely here.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d2172eb5bd4b7d06577113ec40635083619ca54a", "tree": "1a60f2c34a4b5da1d256e1b2f281a994ebe91c15", "parents": [ "7429c6903e3628fc2cfea65ec7e13bac030c7bfe" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:07 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: possible modifiers are not being correctly matched\n\nAlthough we are finding the added modifier in the declaration below\nwe are not correctly matching it as a type. Fix the declaration.\n\n static void __ref *vmem_alloc_pages(unsigned int order)\n {\n }\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7429c6903e3628fc2cfea65ec7e13bac030c7bfe", "tree": "47f51d123e1e6d8b75a8e8337592638953252fe6", "parents": [ "389a2fe57ffc59a649bea39db4d7e6d2eff2b562" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:06 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: improve type matcher debug\n\nImprove type matcher debug so we can see what it does match. As part\nof this move us to to using the common debug framework.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "389a2fe57ffc59a649bea39db4d7e6d2eff2b562", "tree": "f5f0492710f0331a5057281272e89797f38d1b80", "parents": [ "3c232147a7d5b0418b0a0bae0e5b9a62fb81f4f2" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:05 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: allow for type modifiers on multiple declarations\n\nAllow for type modifiers mid declaration on multiple declarations:\n\n\tstruct mxser_mstatus ms, __user *msu \u003d argp;\n\nReported by Jiri Slaby.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3c232147a7d5b0418b0a0bae0e5b9a62fb81f4f2", "tree": "a6f909e41a2c9cc777822f96c984884cd6a07614", "parents": [ "4c432a8f0134504814aa8dcce6cc57c89d175604" ], "author": { "name": "Wolfram Sang", "email": "w.sang@pengutronix.de", "time": "Wed Jul 23 21:29:05 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: correct spelling in kfree checks\n\nCorrect spelling in the kfree reports.\n\nSigned-off-by: Wolfram Sang \u003cw.sang@pengutronix.de\u003e\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4c432a8f0134504814aa8dcce6cc57c89d175604", "tree": "ebc15ff444ec24098c18ec6c0210ea33333f40d3", "parents": [ "f5fe35dd95549b1b419cdeb2ec3fe61fda94fa93" ], "author": { "name": "Greg Kroah-Hartman", "email": "gregkh@suse.de", "time": "Wed Jul 23 21:29:04 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: usb_free_urb() can take NULL\n\nusb_free_urb() can take a NULL, so let\u0027s check and warn about that.\n\nSigned-off-by: Greg Kroah-Hartman \u003cgregkh@suse.de\u003e\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f5fe35dd95549b1b419cdeb2ec3fe61fda94fa93", "tree": "dbb0d8a8951f5b376900e0c26a392d9ccaafef27", "parents": [ "53210168feeff9a3c780bd42f69936d4c12381d5" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:03 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:26 2008 -0700" }, "message": "checkpatch: condition/loop indent checks\n\nCheck to see if the block/statement which a condition or loop introduces\nis indented correctly.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "53210168feeff9a3c780bd42f69936d4c12381d5", "tree": "7f637f7e8a1c01b0a5fd4456d31da4868472a95d", "parents": [ "8d31cfcecf67563d70cd68616cb8fb4384f24b51" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:03 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:25 2008 -0700" }, "message": "checkpatch: toughen trailing if statement checks and extend them to while and for\n\nExtend the trailing statement checks to report a trailing semi-colon \u0027;\u0027\nas we really want it on the next line and indented so it is really really\nobvious. Also extend the tests to include while and for.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8d31cfcecf67563d70cd68616cb8fb4384f24b51", "tree": "edfe965d3efa84305a9c6fe83ecfe24b97bdc7fb", "parents": [ "e2a763c20b89890d2153551b1af6962b135de4c0" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:02 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:25 2008 -0700" }, "message": "checkpatch: check spacing for square brackets\n\nCheck on the spacing before square brackets. We should only allow spaces\nthere if this is part of a type definition or an initialialiser.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e2a763c20b89890d2153551b1af6962b135de4c0", "tree": "0b25d4eae1929576ce3807f3208b7bb2c37bf7aa", "parents": [ "f4c014c0dede10cc0a8463e748892e738e190699" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:02 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:25 2008 -0700" }, "message": "checkpatch: switch -- report trailing statements on case and default\n\nReport trailing statements on case and default lines.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f4c014c0dede10cc0a8463e748892e738e190699", "tree": "e4eb11df93e1d716db70c5bd20fa3cb8c6106210", "parents": [ "548596d523d83dff5a670beb84be0daf4c3bcd16" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:01 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:25 2008 -0700" }, "message": "checkpatch: allow printk strings to exceed 80 characters to maintain their searchability\n\nAllow printk strings to break the 80 character width limits, thus keeping\nthem complete and searchable.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "548596d523d83dff5a670beb84be0daf4c3bcd16", "tree": "ad5e7bad318a2d986f7cd3d8e540e1c240610dfe", "parents": [ "a3bb97a7aba36055d476896ed6393ab35a119d5b" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:01 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:25 2008 -0700" }, "message": "checkpatch: trailing statement indent: fix end of statement location\n\nFix end of statement location. Where the last line of the statement is\nreplaced we are miss reporting the newly added replacement an incorrectly\nindented trailing statement for the negative context. We are also\nincorrectly reporting negative statements generally.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a3bb97a7aba36055d476896ed6393ab35a119d5b", "tree": "9d09ae6cfc89e72078ccf7f436fdfa7cd33a7519", "parents": [ "6ef9b297f6e8850da3be9c9ff5f00385c0977004" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:29:00 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:25 2008 -0700" }, "message": "checkpatch: macros: fix statement counting block end detection\n\nWe are incorrectly counting the lines in a block while accumulating\nthe trailing lines in a macro statement, leading to false positives.\nFix end of block handling and general counting for negative context lines.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6ef9b297f6e8850da3be9c9ff5f00385c0977004", "tree": "427f87ff219ee166bbb031359c6f97fcaf386273", "parents": [ "beae6332493a40116dba24928154621f2e88b9a9" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:28:59 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:25 2008 -0700" }, "message": "checkpatch: types: unary -- goto introduces unary context\n\nWhen we see a goto we enter unary context. For example:\n\n\tgoto *h;\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "beae6332493a40116dba24928154621f2e88b9a9", "tree": "08b0c7e339c00be0fc0f4e841a92a00871c9bcba", "parents": [ "d3ddcf471ea90d7ff711dbaa371ef379ed625ec0" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:28:59 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:25 2008 -0700" }, "message": "checkpatch: comment detection: ignore macro continuation when detecting associated comments\n\nWhen looking for an associated comment they may be suffixed by a macro\ncontinuation. Ignore this.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d3ddcf471ea90d7ff711dbaa371ef379ed625ec0", "tree": "d2eee93fbc6af05508e86e8c8bca548e57902d3a", "parents": [ "f3db6639fee577f6ed92c0a1fc881e748c47ec48" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:28:58 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:25 2008 -0700" }, "message": "checkpatch: possible types: __asm__ is never a type\n\nWe are false matching __asm__ as a type, and then tripping the external\nfunction checks. Squash.\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f3db6639fee577f6ed92c0a1fc881e748c47ec48", "tree": "dc6a84609a8838ebbf9d094f4ef67adb32eb10a9", "parents": [ "c8cb2ca37ed51aa1f3b20e3eff1e72df1c400f70" ], "author": { "name": "Michael Ellerman", "email": "michael@ellerman.id.au", "time": "Wed Jul 23 21:28:57 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:25 2008 -0700" }, "message": "checkpatch: add a checkpatch warning for new uses of __initcall().\n\n[apw@shadowen.org: generalise pattern and add tests]\nSigned-off-by: Michael Ellerman \u003cmichael@ellerman.id.au\u003e\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c8cb2ca37ed51aa1f3b20e3eff1e72df1c400f70", "tree": "1855161684a9b0db3254698509b2a0dd33ed8c1c", "parents": [ "fee61c47d15270bdea699a8a3dd867f0825c3541" ], "author": { "name": "Andy Whitcroft", "email": "apw@shadowen.org", "time": "Wed Jul 23 21:28:57 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jul 24 10:47:25 2008 -0700" }, "message": "checkpatch: types: some types may also be identifiers\n\nSome types such as typedefs may overlap real identifiers. Be more\ntargetted about when a type can really exist. Where it cannot let it be\nan identifier. This prevents false reporting of the minus \u0027-\u0027 in unary\ncontext in the following:\n\n\tfoo[bar-\u003ebool - 1];\n\nSigned-off-by: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" } ], "next": "fee61c47d15270bdea699a8a3dd867f0825c3541" }