)]}' { "log": [ { "commit": "1ab142d499294b844ecc81e8004db4ce029b0b61", "tree": "9db85a456d0cba3de8b9bd6671b1b52fa939770c", "parents": [ "267d7b23dd62f6ec55e0fba777e456495c308fc7", "187e70a554e0f0717a65998bc9199945cbbd4692" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Mar 22 12:38:04 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Mar 22 12:38:04 2012 -0700" }, "message": "Merge branch \u0027for-next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending\n\nPull SCSI target updates from Nicholas Bellinger:\n \"This contains the usual set of updates and bugfixes to target-core +\n existing fabric module code, along with a handful of the patches\n destined for v3.3 stable.\n\n It also contains the necessary target-core infrastructure pieces\n required to run using tcm_qla2xxx.ko WWPNs with the new Qlogic Fibre\n Channel fabric module currently queued in target-pending/for-next-merge,\n and coming for round 2.\n\n The highlights for this series include:\n\n - Add target_submit_tmr() helper function for fabric task management\n (andy)\n - Convert tcm_fc to use target_submit_tmr() (andy)\n - Replace target core various cmd flags with a transport state (hch)\n - Convert loopback to use workqueue submission (hch)\n - Convert target core to use array_zalloc for tpg_lun_list (joern)\n - Convert target core to use array_zalloc for device_list (joern)\n - Add target core support for TMR_ABORT_TASK (nab)\n - Add target core se_sess-\u003esess_kref + get/put helpers (nab)\n - Add target core se_node_acl-\u003eacl_kref for -\u003eacl_free_comp usage\n (nab)\n - Convert iscsi-target to use target_put_session + sess_kref (nab)\n - Fix tcm_fc fc_exch memory leak in ft_send_resp_status (nab)\n - Fix ib_srpt srpt_handle_cmd send_ioctx-\u003eioctx_kref leak on\n exception (nab)\n - Fix target core up handling of short INQUIRY buffers (roland)\n - Untangle target-core front-end and back-end meanings of max_sectors\n attribute (roland)\n - Set loopback residual field for SCSI commands (roland)\n - Fix target-core 16-bit target ports for SET TARGET PORT GROUPS\n emulation (roland)\n\n Thanks again to Andy, Christoph, Joern, Roland, and everyone who has\n contributed this round!\"\n\n* \u0027for-next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending: (64 commits)\n ib_srpt: Fix srpt_handle_cmd send_ioctx-\u003eioctx_kref leak on exception\n loopback: Fix transport_generic_allocate_tasks error handling\n iscsi-target: remove improper externs\n iscsi-target: Remove unused variables in iscsi_target_parameters.c\n target: remove obvious warnings\n target: Use array_zalloc for device_list\n target: Use array_zalloc for tpg_lun_list\n target: Fix sense code for unsupported SERVICE ACTION IN\n target: Remove hack to make READ CAPACITY(10) lie if thin provisioning is enabled\n target: Bump core version to v4.1.0-rc2-ml + fabric versions\n tcm_fc: Fix fc_exch memory leak in ft_send_resp_status\n target: Drop unused legacy target_core_fabric_ops API callers\n iscsi-target: Convert to use target_put_session + sess_kref\n target: Convert se_node_acl-\u003eacl_group removal to use -\u003eacl_kref\n target: Add se_node_acl-\u003eacl_kref for -\u003eacl_free_comp usage\n target: Add se_node_acl-\u003eacl_free_comp for NodeACL release path\n target: Add se_sess-\u003esess_kref + get/put helpers\n target: Convert session_lock to irqsave\n target: Fix typo in drivers/target\n iscsi-target: Fix dynamic -\u003e explict NodeACL pointer reference\n ...\n" }, { "commit": "3556485f1595e3964ba539e39ea682acbb835cee", "tree": "7f5ee254f425b1427ac0059b5f347a307f8538a1", "parents": [ "b8716614a7cc2fc15ea2a518edd04755fb08d922", "09f61cdbb32a9d812c618d3922db533542736bb0" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Mar 21 13:25:04 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Mar 21 13:25:04 2012 -0700" }, "message": "Merge branch \u0027next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security\n\nPull security subsystem updates for 3.4 from James Morris:\n \"The main addition here is the new Yama security module from Kees Cook,\n which was discussed at the Linux Security Summit last year. Its\n purpose is to collect miscellaneous DAC security enhancements in one\n place. This also marks a departure in policy for LSM modules, which\n were previously limited to being standalone access control systems.\n Chromium OS is using Yama, and I believe there are plans for Ubuntu,\n at least.\n\n This patchset also includes maintenance updates for AppArmor, TOMOYO\n and others.\"\n\nFix trivial conflict in \u003cnet/sock.h\u003e due to the jumo_label-\u003estatic_key\nrename.\n\n* \u0027next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security: (38 commits)\n AppArmor: Fix location of const qualifier on generated string tables\n TOMOYO: Return error if fails to delete a domain\n AppArmor: add const qualifiers to string arrays\n AppArmor: Add ability to load extended policy\n TOMOYO: Return appropriate value to poll().\n AppArmor: Move path failure information into aa_get_name and rename\n AppArmor: Update dfa matching routines.\n AppArmor: Minor cleanup of d_namespace_path to consolidate error handling\n AppArmor: Retrieve the dentry_path for error reporting when path lookup fails\n AppArmor: Add const qualifiers to generated string tables\n AppArmor: Fix oops in policy unpack auditing\n AppArmor: Fix error returned when a path lookup is disconnected\n KEYS: testing wrong bit for KEY_FLAG_REVOKED\n TOMOYO: Fix mount flags checking order.\n security: fix ima kconfig warning\n AppArmor: Fix the error case for chroot relative path name lookup\n AppArmor: fix mapping of META_READ to audit and quiet flags\n AppArmor: Fix underflow in xindex calculation\n AppArmor: Fix dropping of allowed operations that are force audited\n AppArmor: Add mising end of structure test to caps unpacking\n ...\n" }, { "commit": "f760903ae512c7851b619be1742ae1581145a878", "tree": "0e2c40deda9e60804cd9a4804e2f3d9cae18820f", "parents": [ "a227fb3a5a61e70ae4e4957818a23e9239bf5a43" ], "author": { "name": "Dan Carpenter", "email": "dan.carpenter@oracle.com", "time": "Sat Mar 17 16:11:52 2012 +0300" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Mar 17 18:07:04 2012 -0700" }, "message": "iscsi-target: remove improper externs\n\nThese externs aren\u0027t needed and Sparse complains about them.\n\ndrivers/target/iscsi/iscsi_target_nodeattrib.c:52:12: warning:\n\tfunction \u0027iscsit_na_dataout_timeout\u0027 with external linkage has\n\tdefinition\n\nSigned-off-by: Dan Carpenter \u003cdan.carpenter@oracle.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "a227fb3a5a61e70ae4e4957818a23e9239bf5a43", "tree": "861197e821a8cc347e8ea5788ee4a944c872fcd0", "parents": [ "281689051a628e5341ce1efcfafde9d60f2f6fbb" ], "author": { "name": "Jörn Engel", "email": "joern@logfs.org", "time": "Thu Mar 15 15:08:03 2012 -0400" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Thu Mar 15 19:16:25 2012 -0700" }, "message": "iscsi-target: Remove unused variables in iscsi_target_parameters.c\n\nlocal_right_val was an obvious case, tmp_ptr is also write-only, but\nevades the compiler by being passed to simple_strtoul as char **endp.\n\nSigned-off-by: Joern Engel \u003cjoern@logfs.org\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "281689051a628e5341ce1efcfafde9d60f2f6fbb", "tree": "15809410fe5d1c8540622f5bd7c726517b22ddd3", "parents": [ "f2083241f23722207676025abbb45a301d412e69" ], "author": { "name": "Jörn Engel", "email": "joern@logfs.org", "time": "Thu Mar 15 15:06:58 2012 -0400" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Thu Mar 15 19:16:09 2012 -0700" }, "message": "target: remove obvious warnings\n\nGet rid of a bunch of write-only variables. In a number of cases I\nsuspect actual bugs to be present, so I left all of those for a second\nlook.\n\n(nab: fix lio-core patch fuzz)\n\nSigned-off-by: Joern Engel \u003cjoern@logfs.org\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "00fdc6bbef77844ce397a7de7acfaf25e8e2e4eb", "tree": "df8d71a6b9c9239b68d43fc04d57580caf3e4992", "parents": [ "087a03b3ea1c8d6e2d5743a8d1c6d571058caa04" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Mar 13 18:20:11 2012 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Mar 13 21:43:58 2012 -0700" }, "message": "iscsi-target: Fix reservation conflict -EBUSY response handling bug\n\nThis patch addresses a iscsi-target specific bug related to reservation conflict\nhandling in iscsit_handle_scsi_cmd() that has been causing reservation conflicts\nto complete and not fail as expected due to incorrect errno checking. The problem\noccured with the change to return -EBUSY from transport_generic_cmd_sequencer() -\u003e\ntransport_generic_allocate_tasks() failures, that broke iscsit_handle_scsi_cmd()\nchecking for -EINVAL in order to invoke a non GOOD status response.\n\nThis was manifesting itself as data corruption with legacy SPC-2 reservations,\nbut also effects iscsi-target LUNs with SPC-3 persistent reservations.\n\nThis bug was originally introduced in lio-core commit:\n\ncommit 03e98c9eb916f3f0868c1dc344dde2a60287ff72\nAuthor: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\nDate: Fri Nov 4 02:36:16 2011 -0700\n\n target: Address legacy PYX_TRANSPORT_* return code breakage\n\nReported-by: Martin Svec \u003cmartin.svec@zoner.cz\u003e\nCc: Martin Svec \u003cmartin.svec@zoner.cz\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\nCc: stable@vger.kernel.org\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "9765b1f327951e643a97f43924d1fbeb4e90ffba", "tree": "d1e9691a7b366874ca37bf229f84443384fd5366", "parents": [ "031ed4d565b31880a4136bb7366bc89f5b1dba7d" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Mar 10 14:50:19 2012 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Mar 10 14:55:17 2012 -0800" }, "message": "target: Bump core version to v4.1.0-rc2-ml + fabric versions\n\nBump core version to v4.1.0-rc2-ml, and for versions from the\nfollowing mainline fabric modules:\n\nloopback: v2.1-rc2\ntcm_fc: v0.4\niscsi-target: v4.1.0-rc2\n\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "c7ec05c82bfd6acf1fd800d628591500805f3179", "tree": "c64d5d330120d038f5ee9fe90b7a7eba0a0b3459", "parents": [ "99367f01b8df2018ff3328ddf4111e701d34188d" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Feb 28 00:22:12 2012 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Mar 10 14:42:55 2012 -0800" }, "message": "target: Drop unused legacy target_core_fabric_ops API callers\n\nThis patch drops the following unused legacy API callers from target_core_fabric.h:\n\n*) TFO-\u003efall_back_to_erl0()\n*) TFO-\u003estop_session()\n*) TFO-\u003esess_logged_in()\n*) TFO-\u003eis_state_remove()\n\nThis patch also removes the stub usage in loopback, tcm_fc, iscsi_target,\nand ib_srpt fabric modules.\n\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "99367f01b8df2018ff3328ddf4111e701d34188d", "tree": "5ef6e2ffe8b1d3ee8bfd995b80efcb4e6d02095d", "parents": [ "337c060701fb3d27d9945bf7af7ba194ae2153a8" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Feb 27 01:43:32 2012 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Mar 10 14:42:25 2012 -0800" }, "message": "iscsi-target: Convert to use target_put_session + sess_kref\n\nThis patch converts iscsi-target session code to use se_sess-\u003esess_kref\ncounting for iscsi session shutdown. The following cases include:\n\n*) last iscsit_close_connection() shutdown path to invoke close session\n*) iscsit_logout_post_handler_closesession() for explict logout\n*) iscsit_free_session() caller for explict shutdown\n\nIt also moves iscsit_stop_session() call from lio_tpg_close_session()\ninto lio_tpg_shutdown_session() TFO callbacks to invoke an explict\nshutdown, and also changes iscsi_check_for_session_reinstatement()\nlogin code to use se_sess-\u003esess_kref.\n\n(v2: Make iscsit_handle_time2retain_timeout() use target_put_session)\n\nCc: Andy Grover \u003cagrover@redhat.com\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "5e58b0299794fc4acf6e19995a2159e0535a008c", "tree": "14d46ddd8b001aea2b75f89598e131360dbb9a7c", "parents": [ "d06283341aee9e48eff1b068779d340785c635ce" ], "author": { "name": "Masanari Iida", "email": "standby24x7@gmail.com", "time": "Mon Feb 27 23:18:15 2012 +0900" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Mar 10 13:55:05 2012 -0800" }, "message": "target: Fix typo in drivers/target\n\nCorrect spelling \"exeeds\" to \"exceeds\" in iscsi/iscsi_target_nego.c\nCorrect spelling \"diabled\" to \"disabled\" in target_core_configfs.c\n\nSigned-off-by: Masanari Iida \u003cstandby24x7@gmail.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "d06283341aee9e48eff1b068779d340785c635ce", "tree": "4b6085fababdbb6784db9945968cbf6ed292e0e8", "parents": [ "c0974f89385970455a60a999ae4fc0a783cf458d" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sun Feb 26 22:16:07 2012 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Thu Mar 08 12:10:56 2012 -0800" }, "message": "iscsi-target: Fix dynamic -\u003e explict NodeACL pointer reference\n\nThis patch fixes a free after use in lio_target_make_nodeacl() where\niscsi_node_acl was referenced from the original se_nacl_new allocation,\ninstead of from core_tpg_add_initiator_node_acl() in the case of dynamic\n-\u003e explict NodeACL conversion.\n\nCc: stable@vger.kernel.org\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "d335e6054db616bce3f040e659fa38440518ad1d", "tree": "f426c61320c4b323536a2b46203e17e5c6c3ea59", "parents": [ "33395fb8a13731c7ef7b175dbf5a4d8a6738fe6c" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Thu Feb 23 17:28:43 2012 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Feb 25 14:37:50 2012 -0800" }, "message": "iscsi-target: Fix iscsit_alloc_buffs() failure cases\n\nMake iscsit_alloc_buffs() failure case for page_alloc_failed use correct\n__free_page() SGL pointer, and return -ENOMEM for iscsit_allocate_iovecs\nfailure to push se_cmd-\u003et_mem_sg release into iscsit_release_cmd()\ncallback during iscsit_add_reject_from_cmd() connection reset.\n\nAlso drop cmd-\u003et_mem_sg \u003d NULL assignment from page_alloc_failed\nfailure case.\n\nReported-by: Roland Dreier \u003croland@purestorage.com\u003e\nCc: Andy Grover \u003cagrover@redhat.com\u003e\nCc: stable@vger.kernel.org\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "c8e31f26feeb03dc6f51bff68135cc58431e099b", "tree": "8d584fcb7cb7a58988cd2463a9a26f577410e6ac", "parents": [ "35b2cdc4fea1f0d13e1602c07e62c797c9fe5ed4" ], "author": { "name": "Andy Grover", "email": "agrover@redhat.com", "time": "Thu Jan 19 13:39:17 2012 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Feb 25 14:37:47 2012 -0800" }, "message": "target: Add SCF_SCSI_TMR_CDB usage and drop se_tmr_req_cache\n\nChange the test for if a cmd is a tmr request to checking if\nSCF_SCSI_TMR_CDB (a new flag) is set in cmd-\u003ese_cmd_flags.\n\nAlso remove se_tmr_req_cache usage in favor of kzalloc usage,\nand make core_tmr_alloc_req() return int + setup se_cmd-\u003ese_tmr_req\ndirectly and fix up various fabric module usages\n\nCc: Andy Grover \u003cagrover@redhat.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "4f26998a79b30a5c912cfa1a759fa0c3e6f6414e", "tree": "b69fd7ed5d387edb81364e29cf484eaae99d2f05", "parents": [ "ef28640497f5935bf614e1e29b16972d8b97cdb2" ], "author": { "name": "Andy Grover", "email": "agrover@redhat.com", "time": "Thu Jan 19 13:39:14 2012 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Feb 25 14:37:47 2012 -0800" }, "message": "target/iscsi: Remove unneeded wrapper functions\n\niscsit_get_lun_for_{cmd,tmr} are unnecessary.\n\nSigned-off-by: Andy Grover \u003cagrover@redhat.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "d0f474e501929acdbd116cca39ef083012f70f25", "tree": "ce4db92ff234d82c3b61ff05404ed4ae41551770", "parents": [ "d5b4a21b3dc116b477c1b1b493233a73aacbb440" ], "author": { "name": "Roland Dreier", "email": "roland@purestorage.com", "time": "Thu Jan 12 10:41:18 2012 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Feb 25 14:37:46 2012 -0800" }, "message": "target: Use LIST_HEAD()/DEFINE_MUTEX() for static objects\n\nInstead of\n\n static struct list_head foo;\n static struct mutex bar;\n\n ...\n\n INIT_LIST_HEAD(\u0026foo);\n mutex_init(\u0026bar);\n\njust do\n\n static LIST_HEAD(foo);\n static DEFINE_MUTEX(bar);\n\nAlso remove some superfluous struct list_head and spinlock_t\ninitialization calls where the variables are already defined using\nmacros that initialize them.\n\nThis saves a decent amount of compiled code too:\n\n add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-178 (-178)\n function old new delta\n target_core_init_configfs 898 850 -48\n core_scsi3_emulate_pro_preempt 1742 1683 -59\n iscsi_thread_set_init 159 88 -71\n\nSigned-off-by: Roland Dreier \u003croland@purestorage.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "7d680f3b74dd6f0f57569eeeee8c257790ceaa96", "tree": "e0797ab722c222213b7cbe4fa9ba4a61db2d8b0c", "parents": [ "b01543dfe67bb1d191998e90d20534dc354de059" ], "author": { "name": "Christoph Hellwig", "email": "hch@infradead.org", "time": "Wed Dec 21 14:13:47 2011 -0500" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Feb 25 14:37:45 2012 -0800" }, "message": "target: replace various cmd flags with a transport state\n\nReplace various atomic_ts used as flags in struct se_cmd with a single\ntransport_state bitmap that requires t_state_lock to be held for modifications.\n\nIn the target core that assumption generally is true, but some recently added\ncode in the SRP target had to grow new lock calls. I can\u0027t say I like the way\nhow it messes with the command state directly, but let\u0027s leave that for later.\n\n(Re-add missing ib_srpt.c changes that nab dropped..)\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "4040153087478993cbf0809f444400a3c808074c", "tree": "2dc7af85b0cf930f1656553bd38410b8c16601a6", "parents": [ "191c542442fdf53cc3c496c00be13367fd9cd42d" ], "author": { "name": "Al Viro", "email": "viro@ftp.linux.org.uk", "time": "Mon Feb 13 03:58:52 2012 +0000" }, "committer": { "name": "James Morris", "email": "jmorris@namei.org", "time": "Tue Feb 14 10:45:42 2012 +1100" }, "message": "security: trim security.h\n\nTrim security.h\n\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\nSigned-off-by: James Morris \u003cjmorris@namei.org\u003e\n" }, { "commit": "9f9ef6d3c08319defc29e4cf6ef2868d15ed0cc3", "tree": "dab36bf875ce037be9fc59b7fab101dce192d188", "parents": [ "5c55125f4794f4e77574fc09839cb47b0eb45b06" ], "author": { "name": "Dax Kelson", "email": "dkelson@gurulabs.com", "time": "Fri Feb 03 23:40:25 2012 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Feb 07 06:48:53 2012 +0000" }, "message": "iscsi: use IP_FREEBIND socket option\n\nUse IP_FREEBIND socket option so that iscsi portal configuration with\nexplicit IP addresses can happen during boot, before network interfaces\nhave been assigned IPs.\n\nThis is especially important on systemd based Linux boxes where system\nboot happens asynchronously and non-trivial configuration must be done\nto get targetcli.service to start synchronously after the network is\nconfigured.\n\nReference:\nhttp://lists.fedoraproject.org/pipermail/devel/2011-October/158025.html\n\nSigned-off-by: Dax Kelson \u003cdkelson@gurulabs.com\u003e\nCc: \"Nicholas A. Bellinger\" \u003cnab@linux-iscsi.org\u003e\nCc: \"Andy Grover\" \u003cagrover@redhat.com\u003e\nCc: \"Lennart Poettering\" \u003clennart@poettering.net\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "c3bc93da24c8f315d9ece741f6e6414a38879ec6", "tree": "4b7fe46a3fec2e222d0e77f721cb09f69e81899a", "parents": [ "7347b5ff7090b2b399b7921a266255cd55bbd78f" ], "author": { "name": "Stephen Rothwell", "email": "sfr@canb.auug.org.au", "time": "Mon Jan 23 11:39:49 2012 +1100" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Feb 07 06:48:30 2012 +0000" }, "message": "iscsi_target: in_aton needs linux/inet.h\n\nFixes this error after a recent nfs cleanup:\n\ndrivers/target/iscsi/iscsi_target_configfs.c: In function \u0027lio_target_call_addnptotpg\u0027:\ndrivers/target/iscsi/iscsi_target_configfs.c:214:3: error: implicit declaration of function \u0027in6_pton\u0027 [-Werror\u003dimplicit-function-declaration]\ndrivers/target/iscsi/iscsi_target_configfs.c:239:3: error: implicit declaration of function \u0027in_aton\u0027 [-Werror\u003dimplicit-function-declaration]\n\nSigned-off-by: Stephen Rothwell \u003csfr@canb.auug.org.au\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "2f9bc894c67dbacae5a6a9875818d2a18a918d18", "tree": "2891680fbe0b57299776d44123969452a9cb1a25", "parents": [ "4949314c7283ea4f9ade182ca599583b89f7edd6" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Jan 16 23:33:48 2012 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jan 18 08:35:58 2012 +0000" }, "message": "iscsi-target: Fix discovery with INADDR_ANY and IN6ADDR_ANY_INIT\n\nThis patch addresses a bug with sendtargets discovery where INADDR_ANY (0.0.0.0)\n+ IN6ADDR_ANY_INIT ([0:0:0:0:0:0:0:0]) network portals where incorrectly being\nreported back to initiators instead of the address of the connecting interface.\nTo address this, save local socket -\u003egetname() output during iscsi login setup,\nand makes iscsit_build_sendtargets_response() return these TargetAddress keys\nwhen INADDR_ANY or IN6ADDR_ANY_INIT portals are in use.\n\nReported-by: Dax Kelson \u003cdkelson@gurulabs.com\u003e\nReported-by: Andy Grover \u003cagrover@redhat.com\u003e\nCc: David S. Miller \u003cdavem@davemloft.net\u003e\nCc: \u003cstable@vger.kernel.org\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "e8904dc5008ef92f0f62391d6557f03f921eeb32", "tree": "da3cdfc1e0be8166b58649840dac0d1ba0842081", "parents": [ "f8d48ae52eeec906d7fb42485eb26a5d305bab0a" ], "author": { "name": "Jesper Juhl", "email": "jj@chaosbits.net", "time": "Sun Jan 15 19:33:30 2012 +0100" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jan 18 08:35:57 2012 +0000" }, "message": "iscsi-target: Fix up a few assignments\n\nA statement such as\n struct iscsi_node_attrib *na \u003d na \u003d iscsit_tpg_get_node_attrib(sess);\nhas undefined behaviour since there are two assignments to \u0027na\u0027, strictly\nspeaking (the order in which side-effects from the assignments take place\nis undefined since there\u0027s no intervening sequence point), and it looks\nunintentional in any case.\n\nSigned-off-by: Jesper Juhl \u003cjj@chaosbits.net\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "f8d48ae52eeec906d7fb42485eb26a5d305bab0a", "tree": "4de9fc43d78b02bb6569860c887f81af763f9308", "parents": [ "cd931ee62fd0258fc85c76a7c5499fe85e0f3436" ], "author": { "name": "Dan Carpenter", "email": "dan.carpenter@oracle.com", "time": "Sun Jan 15 14:30:24 2012 +0300" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jan 18 08:35:57 2012 +0000" }, "message": "iscsi-target: make one-bit bitfields unsigned\n\nSigned bitfields are a problem because instead of being 1 or 0 like\nyou\u0027d expect they are 0 and -1. It doesn\u0027t cause a problem in this case\nbut sparse complains:\n\ndrivers/target/iscsi/iscsi_target_core.h:564:56: error: dubious one-bit\nsigned bitfield\n\nSigned-off-by: Dan Carpenter \u003cdan.carpenter@oracle.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "cd931ee62fd0258fc85c76a7c5499fe85e0f3436", "tree": "3e98ce1d1fc20b0782dee6eea01e6db295d12503", "parents": [ "c1ce4bd56f2846de55043374598fd929ad3b711b" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Jan 16 17:11:54 2012 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jan 18 08:35:57 2012 +0000" }, "message": "iscsi-target: Fix double list_add with iscsit_alloc_buffs reject\n\nThis patch fixes a bug where the iscsit_add_reject_from_cmd() call\nfrom a failure to iscsit_alloc_buffs() was incorrectly passing\nadd_to_conn\u003d1 and causing a double list_add after iscsi_cmd-\u003ei_list\nhad already been added in iscsit_handle_scsi_cmd().\n\nCc: \u003cstable@vger.kernel.org\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "c1ce4bd56f2846de55043374598fd929ad3b711b", "tree": "86a088a99e1c51c78aa2198d015936edccdfeb12", "parents": [ "8d9efe539cf78f6a90947d47100e4a86d907750f" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Jan 16 16:04:15 2012 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jan 18 08:35:56 2012 +0000" }, "message": "iscsi-target: Fix reject release handling in iscsit_free_cmd()\n\nThis patch addresses a bug where iscsit_free_cmd() was incorrectly calling\niscsit_release_cmd() for ISCSI_OP_REJECT because iscsi_add_reject*() will\noverwrite the original iscsi_cmd-\u003eiscsi_opcode assignment. This bug was\nintroduced with the following commit:\n\ncommit 0be67f2ed8f577d2c72d917928394c5885fa9134\nAuthor: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\nDate: Sun Oct 9 01:48:14 2011 -0700\n\n iscsi-target: Remove SCF_SE_LUN_CMD flag abuses\n\nand was manifesting itself as list corruption with the following:\n\n[ 131.191092] ------------[ cut here ]------------\n[ 131.191092] WARNING: at lib/list_debug.c:53 __list_del_entry+0x8d/0x98()\n[ 131.191092] Hardware name: VMware Virtual Platform\n[ 131.191092] list_del corruption. prev-\u003enext should be ffff880022d3c100, but was 6b6b6b6b6b6b6b6b\n[ 131.191092] Modules linked in: tcm_vhost ib_srpt ib_cm ib_sa ib_mad ib_core tcm_qla2xxx qla2xxx tcm_loop tcm_fc libfc scsi_transport_fc crc32c iscsi_target_mod target_core_stgt scsi_tgt target_core_pscsi target_core_file target_core_iblock target_core_mod configfs ipv6 iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi sr_mod cdrom sd_mod e1000 ata_piix libata mptspi mptscsih mptbase [last unloaded: scsi_wait_scan]\n[ 131.191092] Pid: 2250, comm: iscsi_ttx Tainted: G W 3.2.0-rc4+ #42\n[ 131.191092] Call Trace:\n[ 131.191092] [\u003cffffffff8103b553\u003e] warn_slowpath_common+0x80/0x98\n[ 131.191092] [\u003cffffffff8103b5ff\u003e] warn_slowpath_fmt+0x41/0x43\n[ 131.191092] [\u003cffffffff811d0279\u003e] __list_del_entry+0x8d/0x98\n[ 131.191092] [\u003cffffffffa01395c9\u003e] transport_lun_remove_cmd+0x9b/0xb7 [target_core_mod]\n[ 131.191092] [\u003cffffffffa013a55c\u003e] transport_generic_free_cmd+0x5d/0x71 [target_core_mod]\n[ 131.191092] [\u003cffffffffa01a012b\u003e] iscsit_free_cmd+0x1e/0x27 [iscsi_target_mod]\n[ 131.191092] [\u003cffffffffa01a13be\u003e] iscsit_close_connection+0x14d/0x5b2 [iscsi_target_mod]\n[ 131.191092] [\u003cffffffffa0196a0c\u003e] iscsit_take_action_for_connection_exit+0xdb/0xe0 [iscsi_target_mod]\n[ 131.191092] [\u003cffffffffa01a55d4\u003e] iscsi_target_tx_thread+0x15cb/0x1608 [iscsi_target_mod]\n[ 131.191092] [\u003cffffffff8103609a\u003e] ? check_preempt_wakeup+0x121/0x185\n[ 131.191092] [\u003cffffffff81030801\u003e] ? __dequeue_entity+0x2e/0x33\n[ 131.191092] [\u003cffffffffa01a4009\u003e] ? iscsit_send_text_rsp+0x25f/0x25f [iscsi_target_mod]\n[ 131.191092] [\u003cffffffffa01a4009\u003e] ? iscsit_send_text_rsp+0x25f/0x25f [iscsi_target_mod]\n[ 131.191092] [\u003cffffffff8138f706\u003e] ? schedule+0x55/0x57\n[ 131.191092] [\u003cffffffff81056c7d\u003e] kthread+0x7d/0x85\n[ 131.191092] [\u003cffffffff81399534\u003e] kernel_thread_helper+0x4/0x10\n[ 131.191092] [\u003cffffffff81056c00\u003e] ? kthread_worker_fn+0x16d/0x16d\n[ 131.191092] [\u003cffffffff81399530\u003e] ? gs_change+0x13/0x13\n\nReported-by: \u003cjrepac@yahoo.com\u003e\nCc: \u003cstable@vger.kernel.org\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "bc704fb58f507deea84a4c047a3a71351f0c55aa", "tree": "64372a6e7fbf1a54214fda904a81637d8bba1402", "parents": [ "8359cf43b9dccddeebb0d247146719a14ce6371a" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Nov 28 01:02:07 2011 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Dec 14 11:28:09 2011 +0000" }, "message": "iscsi-target: fix chap identifier simple_strtoul usage\n\nThis patch makes chap_server_compute_md5() use proper unsigned long\nusage for the CHAP_I (identifier) and check for values beyond 255 as\nper RFC-1994.\n\nReported-by: Joern Engel \u003cjoern@logfs.org\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "8359cf43b9dccddeebb0d247146719a14ce6371a", "tree": "25421cb0e06d878709a826edf8d724ca102ab441", "parents": [ "feae85644f1460b3373ef5141183ee43e6191b58" ], "author": { "name": "Jörn Engel", "email": "joern@logfs.org", "time": "Thu Nov 24 02:05:51 2011 +0100" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Dec 14 11:28:07 2011 +0000" }, "message": "target: remove useless casts\n\nA reader should spend an extra moment whenever noticing a cast,\nbecause either something special is going on that deserves extra\nattention or, as is all too often the case, the code is wrong.\n\nThese casts, afaics, have all been useless. They cast a foo* to a\nfoo*, cast a void* to the assigned type, cast a foo* to void*, before\nassigning it to a void* variable, etc.\n\nIn a few cases I also removed an additional \u0026...[0], which is equally\nuseless.\n\nLastly I added three FIXMEs where, to the best of my judgement, the\ncode appears to have a bug. It would be good if someone could check\nthese.\n\nSigned-off-by: Joern Engel \u003cjoern@logfs.org\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "c4795fb20edf2fe2c862c8fe9f8b681edeb79ac1", "tree": "506a8cb0a12ea2b56c5ebed5e6bc2a0d842c069d", "parents": [ "e26d99aed42ec6cdc9540d19c77ac5d4dd2c5b00" ], "author": { "name": "Christoph Hellwig", "email": "hch@infradead.org", "time": "Wed Nov 16 09:46:48 2011 -0500" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Dec 14 11:26:05 2011 +0000" }, "message": "target: header reshuffle, part2\n\nThis reorganized the headers under include/target into:\n\n - target_core_base.h stays as is with all target-wide data stuctures and defines\n - target_core_backend.h contains the whole interface to I/O backends\n - target_core_fabric.h contains the whole interface to fabric modules\n\nExcept for those only the various configfs macro headers stay around.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "ddca8f3ed36c5d25363dab6762829868af09cb02", "tree": "a954dea7351e0f36fa2872ad39b9c4ea5f2cc5d8", "parents": [ "c638830d040696ff2bae07785fd4277e7e3fe7c4" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Dec 06 05:24:19 2011 +0000" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Dec 06 06:00:59 2011 +0000" }, "message": "iscsi-target: Fix hex2bin warn_unused compile message\n\nFix the following compile warning with hex2bin() usage:\n\ndrivers/target/iscsi/iscsi_target_auth.c: In function ‘chap_string_to_hex’:\ndrivers/target/iscsi/iscsi_target_auth.c:35: warning: ignoring return value of ‘hex2bin’, declared with attribute warn_unused_result\n\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "5c73b678f729ea087ef57b59a5d7b5dd3a97042b", "tree": "1dfbf0564bba408d6728cb2cf1054b3f0f2eddbc", "parents": [ "1289a0571c037b4757f60597d646aedb70361ec3" ], "author": { "name": "Jörn Engel", "email": "joern@logfs.org", "time": "Thu Nov 24 02:04:16 2011 +0100" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Dec 06 06:00:56 2011 +0000" }, "message": "target: remove unused struct fields\n\nSome are never used, some are set but never read, dev_hoq_count is\nincremented and decremented, but never read.\n\nSigned-off-by: Joern Engel \u003cjoern@logfs.org\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "1c3d5794fc4a2afd2258b3aa6406377934a36663", "tree": "9a071b1260bfc5b957f168e5a3622667c0ed2ccc", "parents": [ "7ae0b1038f9f7d4c91e9afd4dbbc98210bf1a241" ], "author": { "name": "Thomas Meyer", "email": "thomas@m3y3r.de", "time": "Thu Nov 17 23:43:40 2011 +0100" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Dec 06 06:00:55 2011 +0000" }, "message": "iscsi-target: Use kmemdup rather than duplicating its implementation\n\nThe semantic patch that makes this change is available\nin scripts/coccinelle/api/memdup.cocci.\n\nSigned-off-by: Thomas Meyer \u003cthomas@m3y3r.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "7ae0b1038f9f7d4c91e9afd4dbbc98210bf1a241", "tree": "f022457108c11b5a90d10634f2abbbf1147b2271", "parents": [ "7e46cf02687e40197ae07c623e660be2a2720064" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sun Nov 27 22:25:14 2011 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Dec 06 06:00:54 2011 +0000" }, "message": "iscsi-target: Add missing F_BIT for iscsi_tm_rsp\n\nThis patch sets the missing ISCSI_FLAG_CMD_FINAL bit in\niscsit_send_task_mgt_rsp() for a struct iscsi_tm_rsp PDU.\n\nThis usage is hardcoded for all TM response PDUs in RFC-3720\nsection 10.6.\n\nReported-by: whucecil \u003cwhucecil1999@gmail.com\u003e\nCc: stable@kernel.org\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "7e46cf02687e40197ae07c623e660be2a2720064", "tree": "47e6b57863e2716dfa5a6347b12a23c063e446cd", "parents": [ "fef58a6096770ed6ab49103a430cc755254a74d9" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Nov 15 23:59:00 2011 -0800" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Dec 06 06:00:54 2011 +0000" }, "message": "iscsi-target: Fix residual count hanlding + remove iscsi_cmd-\u003eresidual_count\n\nThis patch fixes iscsi-target handling of underflow where residual data is\ncausing an OOPs by using the incorrect iscsi_cmd_t-\u003edata_length initially\nassigned in iscsit_allocate_se_cmd(). It resets iscsi_cmd_t-\u003edata_length\nfrom se_cmd_t-\u003edata_length after transport_generic_allocate_tasks()\nhas been invoked in iscsit_handle_scsi_cmd() RX context, and converts\niscsi_cmd-\u003eresidual_count usage to access iscsi_cmd-\u003ese_cmd.residual_count\nto get the proper residual count set by target-core.\n\nReported-by: \u003clists@internyc.net\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\nCc: Andy Grover \u003cagrover@redhat.com\u003e\nCc: stable@kernel.org\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "0957627a99604f379d35831897a2aa15272528fc", "tree": "250335ec7dcc6816a7b8135076058a494745f689", "parents": [ "03e98c9eb916f3f0868c1dc344dde2a60287ff72" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Fri Nov 04 11:36:38 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Dec 06 06:00:49 2011 +0000" }, "message": "iscsi-target: Fix sess allocation leak in iscsi_login_zero_tsih_s1\n\nThis patch adds missing kfree() for an allocation in iscsi_login_zero_tsih_s1()\ncode, and make transport_init_session() check for IS_ERR() returns.\n\nReported-by: Dan Carpenter \u003cdan.carpenter@oracle.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "03e98c9eb916f3f0868c1dc344dde2a60287ff72", "tree": "cfa47c1cec5b0a589b868c34310ee25f6a6a1939", "parents": [ "5611cc4572e889b62a7b4c72a413536bf6a9c416" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Fri Nov 04 02:36:16 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Dec 06 06:00:49 2011 +0000" }, "message": "target: Address legacy PYX_TRANSPORT_* return code breakage\n\nThis patch removes legacy usage of PYX_TRANSPORT_* return codes in a number\nof locations and addresses cases where transport_generic_request_failure()\nwas returning the incorrect sense upon CHECK_CONDITION status after the\nv3.1 converson to use errno return codes.\n\nThis includes the conversion of transport_generic_request_failure() to\nprocess cmd-\u003escsi_sense_reason and handle extra TCM_RESERVATION_CONFLICT\nbefore calling transport_send_check_condition_and_sense() to queue up\nresponse status. It also drops PYX_TRANSPORT_OUT_OF_MEMORY_RESOURCES legacy\nusgae, and returns TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE w/ a response\nfor these cases.\n\ntransport_generic_allocate_tasks(), transport_generic_new_cmd(), backend\nSCF_SCSI_DATA_SG_IO_CDB -\u003edo_task(), and emulated -\u003eexecute_task() have\nall been updated to set se_cmd-\u003escsi_sense_reason and return errno codes\nuniversally upon failure. This includes cmd-\u003escsi_sense_reason assignment\nin target_core_alua.c, target_core_pr.c and target_core_cdb.c emulation code.\n\nFinally it updates fabric modules to remove the legacy usage, and for\nTFO-\u003enew_cmd_map() callers forwards return values outside of fabric code.\niscsi-target has also been updated to remove a handful of special cases\nrelated to the cleanup and signaling QUEUE_FULL handling w/ ft_write_pending()\n\n(v2: Drop extra SCF_SCSI_CDB_EXCEPTION check during failure from\n transport_generic_new_cmd, and re-add missing task-\u003etask_error_status\n assignment in transport_complete_task)\n\nCc: Christoph Hellwig \u003chch@lst.de\u003e\nCc: stable@kernel.org\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "32aaeffbd4a7457bf2f7448b33b5946ff2a960eb", "tree": "faf7ad871d87176423ff9ed1d1ba4d9c688fc23f", "parents": [ "208bca0860406d16398145ddd950036a737c3c9d", "67b84999b1a8b1af5625b1eabe92146c5eb42932" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Nov 06 19:44:47 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Nov 06 19:44:47 2011 -0800" }, "message": "Merge branch \u0027modsplit-Oct31_2011\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux\n\n* \u0027modsplit-Oct31_2011\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux: (230 commits)\n Revert \"tracing: Include module.h in define_trace.h\"\n irq: don\u0027t put module.h into irq.h for tracking irqgen modules.\n bluetooth: macroize two small inlines to avoid module.h\n ip_vs.h: fix implicit use of module_get/module_put from module.h\n nf_conntrack.h: fix up fallout from implicit moduleparam.h presence\n include: replace linux/module.h with \"struct module\" wherever possible\n include: convert various register fcns to macros to avoid include chaining\n crypto.h: remove unused crypto_tfm_alg_modname() inline\n uwb.h: fix implicit use of asm/page.h for PAGE_SIZE\n pm_runtime.h: explicitly requires notifier.h\n linux/dmaengine.h: fix implicit use of bitmap.h and asm/page.h\n miscdevice.h: fix up implicit use of lists and types\n stop_machine.h: fix implicit use of smp.h for smp_processor_id\n of: fix implicit use of errno.h in include/linux/of.h\n of_platform.h: delete needless include \u003clinux/module.h\u003e\n acpi: remove module.h include from platform/aclinux.h\n miscdevice.h: delete unnecessary inclusion of module.h\n device_cgroup.h: delete needless include \u003clinux/module.h\u003e\n net: sch_generic remove redundant use of \u003clinux/module.h\u003e\n net: inet_timewait_sock doesnt need \u003clinux/module.h\u003e\n ...\n\nFix up trivial conflicts (other header files, and removal of the ab3550 mfd driver) in\n - drivers/media/dvb/frontends/dibx000_common.c\n - drivers/media/video/{mt9m111.c,ov6650.c}\n - drivers/mfd/ab3550-core.c\n - include/linux/dmaengine.h\n" }, { "commit": "6aad3738f6a79fd0ca480eaceefe064cc471f6eb", "tree": "08fb9ec4824bf3320af01f29fe84b75f814c0fa0", "parents": [ "02ebbbd481635fd3ce7018e5bb19c18c0f1e4561", "5bda90c8f20f0af93375721533f4081a40fa6f41" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Nov 06 19:00:42 2011 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Nov 06 19:00:42 2011 -0800" }, "message": "Merge branch \u0027for-next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending\n\n* \u0027for-next\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending:\n target: use -\u003eexectute_task for all CDB emulation\n target: remove SCF_EMULATE_CDB_ASYNC\n target: refactor transport_emulate_control_cdb\n target: pass the se_task to the CDB emulation callback\n target: split core_scsi3_emulate_pr\n target: split core_scsi2_emulate_crh\n target: Add generic active I/O shutdown logic\n target: add back error handling in transport_complete_task\n target/pscsi: blk_make_request() returns an ERR_PTR()\n target: Remove core TRANSPORT_FREE_CMD_INTR usage\n target: Make TFO-\u003echeck_stop_free return free status\n iscsi-target: Fix non-immediate TMR handling\n iscsi-target: Add missing CMDSN_LOWER_THAN_EXP check in iscsit_handle_scsi_cmd\n target: Avoid double list_del for aborted se_tmr_req\n target: Minor cleanups to core_tmr_drain_tmr_list\n target: Fix wrong se_tmr being added to drain_tmr_list\n target: Fix incorrect se_cmd assignment in core_tmr_drain_tmr_list\n target: Check -ENOMEM to signal QUEUE_FULL from fabric callbacks\n tcm_loop: Add explict read buffer memset for SCF_SCSI_CONTROL_SG_IO_CDB\n target: Fix compile warning w/ missing module.h include\n" }, { "commit": "5a4c8666c6d576f076a7c6824589cdbb984c0f84", "tree": "cd4eb1d2c67ff7cf99b4de4e9420c6c1df5b1085", "parents": [ "7e32da55e26b80d57961681e53aa67938268db3f" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Fri Oct 28 13:37:19 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Nov 02 15:57:13 2011 +0000" }, "message": "iscsi-target: Fix non-immediate TMR handling\n\nThis patch addresses two issues with non immediate TMR handling in\niscsit_handle_task_mgt_cmd(). The first involves breakage due to\nv3.1-rc conversion of iscsit_sequence_cmd(), which upon good status\nwould hit the iscsit_add_reject_from_cmd() block of code. This patch\nadds an explict check for CMDSN_ERROR_CANNOT_RECOVER.\n\nThe second adds a check to return when non immediate TMR operation is\ndetected after iscsit_ack_from_expstatsn(), as iscsit_sequence_cmd()\n-\u003e iscsit_execute_cmd() will have called transport_generic_handle_tmr()\nfor the non immediate TMR case already.\n\nCc: Andy Grover \u003cagrover@redhat.com\u003e\nCc: stable@kernel.org\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "7e32da55e26b80d57961681e53aa67938268db3f", "tree": "c56edb6b8267a1bfeaebdfe5ae6f8bcff3e7f592", "parents": [ "b8a11d7399173dcf23b6d0ca4f416bdf1eba982e" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Fri Oct 28 13:32:35 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Nov 02 15:57:12 2011 +0000" }, "message": "iscsi-target: Add missing CMDSN_LOWER_THAN_EXP check in iscsit_handle_scsi_cmd\n\nThis patch adds a missing CMDSN_LOWER_THAN_EXP return check for\niscsit_sequence_cmd() in iscsit_handle_scsi_cmd() that was incorrectly\ndropped during the v3.1-rc cleanups to use iscsit_sequence_cmd().\n\nCc: Andy Grover \u003cagrover@redhat.com\u003e\nCc: stable@kernel.org\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "827509e38e5a4a5ba65a745ec7b4b0278656d1ca", "tree": "9b7c3cb15548495f87aa4996b2bc44fb5786fc4e", "parents": [ "c53181af838fb9d82eebbb62b7175b0466d5a7a0" ], "author": { "name": "Paul Gortmaker", "email": "paul.gortmaker@windriver.com", "time": "Tue Aug 30 14:20:44 2011 -0400" }, "committer": { "name": "Paul Gortmaker", "email": "paul.gortmaker@windriver.com", "time": "Mon Oct 31 19:31:59 2011 -0400" }, "message": "drivers/target: Add module.h to drivers/target files as required.\n\nSigned-off-by: Paul Gortmaker \u003cpaul.gortmaker@windriver.com\u003e\n" }, { "commit": "c53181af838fb9d82eebbb62b7175b0466d5a7a0", "tree": "afb4fb9a78349b9ef21b0f1c17778a14b1a44a64", "parents": [ "07c92739455520541c22f6529683467aa3058b7c" ], "author": { "name": "Paul Gortmaker", "email": "paul.gortmaker@windriver.com", "time": "Tue Aug 30 18:16:43 2011 -0400" }, "committer": { "name": "Paul Gortmaker", "email": "paul.gortmaker@windriver.com", "time": "Mon Oct 31 19:31:58 2011 -0400" }, "message": "drivers/target: Add export.h to files as required.\n\nSo that they have access to EXPORT_SYMBOL variants and THIS_MODULE.\n\nSigned-off-by: Paul Gortmaker \u003cpaul.gortmaker@windriver.com\u003e\n" }, { "commit": "59e52534172d845ebffb0d7e85fc56fb7b857051", "tree": "49552e03f1bdb413cd8b5f7542e91770688d7047", "parents": [ "73692d9bb58ecc2fa73f4b2bfcf6eadaa6d49a26", "0d89e54c8249645404283436d952afc261a04e1e" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 25 12:11:02 2011 +0200" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Oct 25 12:11:02 2011 +0200" }, "message": "Merge branch \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial\n\n* \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (59 commits)\n MAINTAINERS: linux-m32r is moderated for non-subscribers\n linux@lists.openrisc.net is moderated for non-subscribers\n Drop default from \"DM365 codec select\" choice\n parisc: Kconfig: cleanup Kernel page size default\n Kconfig: remove redundant CONFIG_ prefix on two symbols\n cris: remove arch/cris/arch-v32/lib/nand_init.S\n microblaze: add missing CONFIG_ prefixes\n h8300: drop puzzling Kconfig dependencies\n MAINTAINERS: microblaze-uclinux@itee.uq.edu.au is moderated for non-subscribers\n tty: drop superfluous dependency in Kconfig\n ARM: mxc: fix Kconfig typo \u0027i.MX51\u0027\n Fix file references in Kconfig files\n aic7xxx: fix Kconfig references to READMEs\n Fix file references in drivers/ide/\n thinkpad_acpi: Fix printk typo \u0027bluestooth\u0027\n bcmring: drop commented out line in Kconfig\n btmrvl_sdio: fix typo \u0027btmrvl_sdio_sd6888\u0027\n doc: raw1394: Trivial typo fix\n CIFS: Don\u0027t free volume_info-\u003eUNC until we are entirely done with it.\n treewide: Correct spelling of successfully in comments\n ...\n" }, { "commit": "415a090ade7e674018e3fa4255938e4c312339b3", "tree": "075991035ca3410cdd2a9110d2cde1c1ca485e4d", "parents": [ "af3f00c75949369d937f499f49118e879939724d" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sun Oct 23 18:16:13 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Oct 24 03:22:06 2011 +0000" }, "message": "target: Fix incorrect transport_sent usage\n\nThis patch converts target-core to use se_cmd-\u003et_transport_sent instead of\na duplicated se_cmd-\u003etransport_sent member in a handful of locations.\nIt also updates iscsi_target to properly use -\u003et_transport_sent instead of\nit\u0027s own iscsi_cmd_t-\u003etransport_sent value that was not being assigned.\n\nReported-by: Christoph Hellwig \u003chch@lst.de\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "c0427f155614908ca1147cd5b6a0d5cdcaef8327", "tree": "a4c4d59078679302ccea165080213d0752b1369d", "parents": [ "0a020436d8baf412bcf5997aee7796276ea773ae" ], "author": { "name": "Christoph Hellwig", "email": "hch@infradead.org", "time": "Wed Oct 12 11:06:56 2011 -0400" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Oct 24 03:21:03 2011 +0000" }, "message": "target: Cleanup unused target_core_base.h bits\n\nThis is a squashed version of the following target_core_base.h\ncleanup patches:\n\n target: remove the unused SHUTDOWN_SIGS defintion\n target: remove unused se_mem leftovers\n target: remove the unused map_func_t typedef\n target: move TRANSPORT_IOV_DATA_BUFFER to the iscsi-specific code\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "d270190a75e5b859c6d8eed8d4095fbb45f78264", "tree": "61f3a7a031433a7a31d5d38f7662f445d3441fa3", "parents": [ "d14921d6ad192868184686b3af5bb99cf3380510" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sun Oct 09 01:48:14 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Oct 24 03:20:56 2011 +0000" }, "message": "iscsi-target: Remove SCF_SE_LUN_CMD flag abuses\n\nThis patch removes a number of SCF_SE_LUN_CMD flag abuses within iscsi-target\ncode to determine when iscsit_release_cmd() or transport_generic_free_cmd()\nshould be called while releasing an individual iscsi_cmd descriptor.\n\nIn the place of SCF_SE_LUN_CMD checks, this patch converts existing code to\nuse a new iscsit_free_cmd() that inspects iscsi_cmd-\u003eiscsi_opcode types to\ndetermine which of the above functions should be invoked. It also removes the\nnow unnecessary special case checking in iscsit_release_commands_from_conn().\n\n(hch: Use iscsit_free_cmd instead of open-coded alternative)\n\nReported-by: Christoph Hellwig \u003chch@lst.de\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "d14921d6ad192868184686b3af5bb99cf3380510", "tree": "a6ffc3a5a695d6dc50ca1885cf41f2c372607fca", "parents": [ "dd503a5fcc0dfb8b5fd887bd967b6f431176864b" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sun Oct 09 01:00:58 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Oct 24 03:20:54 2011 +0000" }, "message": "target: Convert -\u003etransport_wait_for_tasks usage to transport_generic_free_cmd\n\nThis patch converts se_cmd-\u003etransport_wait_for_tasks(se_cmd, 1) usage to use\ntransport_generic_free_cmd() directly in target-core and iscsi-target fabric\nusage. The includes:\n\n*) Removal of the optional transport_generic_free_cmd() call from within\n transport_generic_wait_for_tasks()\n*) Usage of existing SCF_SUPPORTED_SAM_OPCODE to determine when\n transport_generic_wait_for_tasks() processing may occur instead of\n checking se_cmd-\u003etransport_wait_for_tasks()\n*) Move transport_generic_wait_for_tasks() call ahead of core_dec_lacl_count()\n and transport_lun_remove_cmd() in transport_generic_free_cmd() to follow\n existing logic for iscsi-target w/ se_cmd-\u003etransport_wait_for_tasks(se_cmd, 1)\n*) Removal of se_cmd-\u003etransport_wait_for_tasks() function pointer\n*) Rename transport_generic_wait_for_tasks() -\u003e transport_wait_for_tasks(), and\n add docbook comment.\n*) Add EXPORT_SYMBOL for transport_wait_for_tasks()\n\nFor the case in iscsi_target_erl2.c:iscsit_prepare_cmds_for_realligance()\nwhere se_cmd-\u003etransport_wait_for_tasks(se_cmd, 0) is called, this patch\nadds a direct call to transport_wait_for_tasks().\n\n(hch: Fix transport_generic_free_cmd() usage in iscsit_release_commands_from_conn)\n(nab: Add patch: Ensure that TMRs hit wait_for_tasks logic during release)\n\nReported-by: Christoph Hellwig \u003chch@lst.de\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "dd503a5fcc0dfb8b5fd887bd967b6f431176864b", "tree": "59d5bd7db7d4040ea91def8676cca5334f9926a6", "parents": [ "942d82646e16725ac366d44087b8c992f2cb2190" ], "author": { "name": "Roland Dreier", "email": "roland@purestorage.com", "time": "Thu Oct 06 09:56:16 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Oct 24 03:20:53 2011 +0000" }, "message": "target: Have core_tmr_alloc_req() take an explicit GFP_xxx flag\n\nTesting in_interrupt() to know when sleeping is allowed is not really\nreliable (since eg it won\u0027t be true if the caller is holding a spinlock).\nInstead have the caller tell core_tmr_alloc_req() what GFP_xxx to use;\nevery caller except tcm_qla2xxx can use GFP_KERNEL.\n\nSigned-off-by: Roland Dreier \u003croland@purestorage.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "f2b56afd406b455fba339a35f43bfc4ada198073", "tree": "f11190e11015c65d75b24ffbd8dee08db2e409e5", "parents": [ "a3eedc227bfa7c9e21ef3cebe164d06a4c507a71" ], "author": { "name": "Andy Shevchenko", "email": "andriy.shevchenko@linux.intel.com", "time": "Fri Sep 30 14:39:54 2011 +0300" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Oct 24 03:20:48 2011 +0000" }, "message": "iscsi-target: use native hex2bin for chap_string_to_hex\n\nThis patch converts chap_string_to_hex() to use hex2bin() instead of\nthe internal chap_asciihex_to_binaryhex().\n\n(nab: Fix up minor compile breakage + typo)\n\nSigned-off-by: Andy Shevchenko \u003candriy.shevchenko@linux.intel.com\u003e\nCc: \"Nicholas A. Bellinger\" \u003cnab@linux-iscsi.org\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "39c05f321a4b27f3036392eed68bd94ce2267155", "tree": "28f5db67b1ac89444428cc03d043481b51fbac71", "parents": [ "82f1c8a4e7739eae9f1c32c2c419efdc19b8af41" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Oct 08 13:59:52 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Oct 24 03:20:39 2011 +0000" }, "message": "target: Remove session_reinstatement parameter from -\u003etransport_wait_for_tasks\n\nThis patch removes the unnecessary session_reinstatement parameter from\nse_cmd-\u003etransport_wait_for_tasks(), logic in transport_generic_wait_for_tasks,\nand usage within iscsi-target code.\n\nThis also includes the removal of the \u0027bool\u0027 return from transport_put_cmd() +\ntransport_generic_free_cmd() that is no longer necessary.\n\nCc: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "82f1c8a4e7739eae9f1c32c2c419efdc19b8af41", "tree": "e4b9141c59cbc1402b96fb34003205fe90d362df", "parents": [ "e6a2573f1f5d66f0456c433afdfc63f33fdf9008" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Tue Sep 13 23:09:01 2011 +0200" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Oct 24 03:20:38 2011 +0000" }, "message": "target: push session reinstatement out of transport_generic_free_cmd\n\nPush session reinstatement out of transport_generic_free_cmd into the only\ncaller that actually needs it. Clean up transport_generic_free_cmd a bit,\nand remove the useless comment. I\u0027d love to add a more useful kerneldoc\ncomment for it, but as this point I\u0027m still a bit confused in where it\nstands in the command release stack.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "acf3ecc4a1c7460662757c07ee1ec625760d3ae6", "tree": "02f67afb285d5b42e12b723d2d3fc6bb190598fa", "parents": [ "4ca495e0630b6fd960f94f89a9f13ad32b91bc96" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Mon Sep 12 21:50:56 2011 +0200" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Oct 24 03:20:26 2011 +0000" }, "message": "iscsi-target: always call transport_handle_cdb_direct\n\niscsit_task_reassign_complete is always called from the TX thread, so\nhandle the CDB directly instead of offloading it.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "bfb9035c98906aafcd3cf22694fba2550997bf53", "tree": "82256f42b5be76c49c0009b96b0641b34a8f16d3", "parents": [ "395cf9691d72173d8cdaa613c5f0255f993af94b" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Aug 17 06:58:04 2011 -0700" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Tue Sep 27 18:08:04 2011 +0200" }, "message": "treewide: Correct spelling of successfully in comments\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "40b054970afcf067896d62cd6f7e617c62665304", "tree": "5596f2b4fa1c1f41f599caf21bd5d10681ab152b", "parents": [ "2ff017f5b4299e24a7f22d9a336dd162bf52bb54" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Fri Sep 16 16:55:47 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Fri Sep 16 23:47:07 2011 +0000" }, "message": "iscsi-target: Fix sendpage breakage with proper padding+DataDigest iovec offsets\n\nThis patch fixes a bug in the iscsit_fe_sendpage_sg() transmit codepath that\nwas originally introduced with the v3.1 iscsi-target merge that incorrectly\nuses hardcoded cmd-\u003eiov_data_count values to determine cmd-\u003eiov_data[] offsets\nfor extra outgoing padding and DataDigest payload vectors.\n\nThis code is obviously incorrect for the DataDigest enabled case with sendpage\noffload, and this fix ensures correct operation for padding + DataDigest,\npadding only, and DataDigest only cases. The bug was introduced during a\npre-merge change in iscsit_fe_sendpage_sg() to natively use struct scatterlist\ninstead of the legacy v3.0 struct se_mem logic.\n\nCc: Andy Grover \u003cagrover@redhat.com\u003e\nCc: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "2ff017f5b4299e24a7f22d9a336dd162bf52bb54", "tree": "71b896a42d7576dd751abf65adbf85f4a7726641", "parents": [ "784eb99ebad91db4c8c231c4b17f203147ab827b" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Fri Sep 16 01:44:54 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Fri Sep 16 19:37:18 2011 +0000" }, "message": "iscsi-target: Disable markers + remove dangerous local scope array usage\n\nThis patch makes iscsi-target explictly disable OFMarker\u003dYes and IFMarker\u003dyes\nparameter key usage during iscsi login by setting IFMarkInt_Reject and\nOFMarkInt_Reject values in iscsi_enforce_integrity_rules() to effectively\ndisable iscsi marker usage. With this patch, an initiator proposer asking\nto enable either marker parameter keys will be issued a \u0027No\u0027 response, and\nthe target sets OFMarkInt + IFMarkInt parameter key response to \u0027Irrelevant\u0027.\n\nWith markers disabled during iscsi login, this patch removes the problematic\non-stack local-scope array for marker intervals in iscsit_do_rx_data() +\niscsit_do_tx_data(), and other related marker code in iscsi_target_util.c.\nThis fixes a potentional stack smashing scenario with small range markers\nenabled and a large MRDSL as reported by DanC here:\n\n[bug report] target: stack can be smashed\nhttp://www.spinics.net/lists/target-devel/msg00453.html\n\nReported-by: Dan Carpenter \u003cerror27@gmail.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "ba7736696341ad4253125055c0c85aa9f42959a0", "tree": "7433fc8fa41e8dd54c56d4eea4a031c0f7d9f780", "parents": [ "6626a0572657a0945a7b9ccf4a6d6ad1750f9adc" ], "author": { "name": "Dan Carpenter", "email": "error27@gmail.com", "time": "Sat Aug 13 22:35:00 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Aug 22 19:26:30 2011 +0000" }, "message": "iscsi-target: Fix iscsit_allocate_se_cmd_for_tmr failure path bugs\n\nThis patch fixes two bugs in allocation failure handling in\niscsit_allocate_se_cmd_for_tmr():\n\nThis first reported by DanC is a free-after call to transport_free_se_cmd(), this\npatch drops the transport_free_se_cmd() call all together, as iscsit_release_cmd()\nwill release existing allocations as expected.\n\nThe second is a bug where iscsi_cmd_t was being leaked on a cmd-\u003etmr_req allocation\nfailure, so make this jump to iscsit_release_cmd() as well.\n\nSigned-off-by: Dan Carpenter \u003cerror27@gmail.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "6626a0572657a0945a7b9ccf4a6d6ad1750f9adc", "tree": "65db4e143b121c6dbb101f1a076b943bb91a4a8f", "parents": [ "c3c74c7a33d837be391ab61aaae39bb21f16736a" ], "author": { "name": "Chris Boot", "email": "bootc@bootc.net", "time": "Sat Aug 13 22:10:46 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Aug 22 19:26:29 2011 +0000" }, "message": "iscsi-target: Implement iSCSI target IPv6 address printing.\n\nThe iSCSI target configfs code to print out an initiator\u0027s IPv6 address\nis not fully implemented. This patch uses snprintf() with the \"%pI6c\"\nformat string to format the IPv6 address for display purposes.\n\nSigned-off-by: Chris Boot \u003cbootc@bootc.net\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "387e96c05299ca7a0ade874f343f91f0b01086a0", "tree": "308be01da85fb7bf9466d8a2968db173905485ec", "parents": [ "c2337c709102b343bd917ae00c79b266fb15b871" ], "author": { "name": "Dan Carpenter", "email": "error27@gmail.com", "time": "Mon Aug 08 14:06:44 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Aug 22 19:26:19 2011 +0000" }, "message": "iscsi-target: forever loop bug in iscsit_attach_ooo_cmdsn()\n\nThis patch fixes a forever loop bug in iscsit_attach_ooo_cmdsn()\nwhile walking sess-\u003esess_ooo_cmdsn_list when the received\nCmdSN is less than the tail of the list.\n\nSigned-off-by: Dan Carpenter \u003cerror27@gmail.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "c2337c709102b343bd917ae00c79b266fb15b871", "tree": "542f9e6f5d14e714e9dc8f0ae73292b8a8e643f0", "parents": [ "6fc6148865c9a17cee33f251723f6a056f022ecd" ], "author": { "name": "Dan Carpenter", "email": "error27@gmail.com", "time": "Mon Aug 08 14:02:27 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Aug 22 19:26:18 2011 +0000" }, "message": "iscsi-target: remove duplicate return\n\nWe returned on the line before already.\n\nSigned-off-by: Dan Carpenter \u003cerror27@gmail.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "9be08c5804ae4ad96ec22d0b1e71e630803a85ea", "tree": "c49610a94f3441db14a384ee2c8d533707781e9c", "parents": [ "e1750ba20f0d850c38820190ccbf0f647723091a" ], "author": { "name": "Jesper Juhl", "email": "jj@chaosbits.net", "time": "Tue Aug 02 10:26:36 2011 +0200" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Aug 22 19:26:16 2011 +0000" }, "message": "iscsi-target: Fix leak on failure in iscsi_copy_param_list()\n\nWe leak memory if the allocations for \u0027new_param-\u003ename\u0027 or\n\u0027new_param-\u003evalue\u0027 fail in iscsi_target_parameters.c::iscsi_copy_param_list()\n\nWe also do a lot of variable assignments that are completely pointless\nif the allocations fail.\n\nSo, let\u0027s move the allocations before the assignments and also make\nsure that we free whatever was allocated to one if the allocation fail.\n\nThere\u0027s also some small CodingStyle fixups in there (curly braces on\nboth branches of if statement, only one variable per line) since I was\nin the area anyway. And finally, error messages in the function are\nput on a single line for easy grep\u0027abillity.\n\nSigned-off-by: Jesper Juhl \u003cjj@chaosbits.net\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "e1750ba20f0d850c38820190ccbf0f647723091a", "tree": "5026dff79f550661ed0dfb4a6e4bc0b649a29e7b", "parents": [ "052605c6caa3e1edf8eee8fe5fe6d53f5721f39a" ], "author": { "name": "Thomas Meyer", "email": "thomas@m3y3r.de", "time": "Mon Aug 01 23:58:18 2011 +0200" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Mon Aug 22 19:26:15 2011 +0000" }, "message": "target: Use ERR_CAST inlined function\n\nUse ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))\n\nThe semantic patch that makes this output is available\nin scripts/coccinelle/api/err_cast.cocci.\n\nMore information about semantic patching is available at\nhttp://coccinelle.lip6.fr/\n\nSigned-off-by: Thomas Meyer \u003cthomas@m3y3r.de\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "d52a10d003694e48d28cf0218db16372ed61f1bd", "tree": "b7b66ae33a6c961a6d63ad94be48c2c7b16fa08d", "parents": [ "5db0753ba5aabcd9fa298029f03b32b3c96b5a39" ], "author": { "name": "Randy Dunlap", "email": "rdunlap@xenotime.net", "time": "Thu Jul 28 09:48:19 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Thu Jul 28 20:16:18 2011 +0000" }, "message": "target: iscsi_target depends on NET\n\niscsi target code uses lots on network interface functions, so it\nshould depend on NET. Fixes many build errors when NET is not enabled:\n\nERROR: \"kernel_sendmsg\" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!\nERROR: \"in_aton\" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!\nERROR: \"sock_release\" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!\nERROR: \"kernel_listen\" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!\nERROR: \"kernel_setsockopt\" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!\nERROR: \"kernel_recvmsg\" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!\nERROR: \"kernel_accept\" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!\nERROR: \"sock_create\" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!\nERROR: \"kernel_bind\" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!\nERROR: \"in6_pton\" [drivers/target/iscsi/iscsi_target_mod.ko] undefined!\n\nSigned-off-by: Randy Dunlap \u003crdunlap@xenotime.net\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "aadcec010127a20599500c7007fbe9998744be41", "tree": "3ac7a379936e62e675081c0abb649e954ca39afc", "parents": [ "7bbb654e9c77a8692425dbd2c704ad245b86ec8a" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jul 27 20:13:22 2011 +0000" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jul 27 20:28:49 2011 +0000" }, "message": "iscsi-target: Fix CONFIG_SMP\u003dn and CONFIG_MODULES\u003dn build failure\n\nThis patch fixes the following CONFIG_SMP\u003dn and CONFIG_MODULES\u003dn build\nfailure, because iscsit_thread_get_cpumask() is defined as a macro in\niscsi_target.c, but needed by iscsi_target_login.c\n\ndrivers/built-in.o: In function `iscsi_post_login_handler\u0027:\niscsi_target_login.c:(.text+0x13a315): undefined reference to `iscsit_thread_get_cpumask\u0027\niscsi_target_login.c:(.text+0x13a4b4): undefined reference to `iscsit_thread_get_cpumask\u0027\nmake: *** [.tmp_vmlinux1] Error 1\n\nReported-by: Randy Dunlap \u003crdunlap@xenotime.net\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "7bbb654e9c77a8692425dbd2c704ad245b86ec8a", "tree": "86c251ae2311c899de00f1c5054aff1e6a167e32", "parents": [ "76f1928e8831961a692459924cfac0ca1b0d303a" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jul 27 12:37:03 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jul 27 20:28:38 2011 +0000" }, "message": "iscsi-target: Fix snprintf usage with MAX_PORTAL_LEN\n\nThis patch makes lio_target_call_addnptotpg() use sprintf() with\nMAX_PORTAL_LEN + 1 to address the following smatch warning:\n\ndrivers/target/iscsi/iscsi_target_configfs.c +184 lio_target_call_addnptotpg(21)\n error: snprintf() chops off the last chars of \u0027name\u0027: 257 vs 256\n\nReported-by: Dan Carpenter \u003cerror27@gmail.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "76f1928e8831961a692459924cfac0ca1b0d303a", "tree": "99c2ff11bc6e863e82bd285b7db1a392526f1df9", "parents": [ "8f50c7f5d63b0e4a29f6f96e8cfaca782e0c458d" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jul 27 12:16:22 2011 -0700" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jul 27 20:28:31 2011 +0000" }, "message": "iscsi-target: Fix uninitialized usage of cmd-\u003epad_bytes\n\nThis patch fixes an uninitialized usage of cmd-\u003epad_bytes inside of\niscsit_handle_text_cmd() introduced during a v4.1 change to use cmd\nmembers instead of local pad_bytes variables.\n\nReported-by: Dan Carpenter \u003cerror27@gmail.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "8f50c7f5d63b0e4a29f6f96e8cfaca782e0c458d", "tree": "bc2f8064a1170be3755b4443f813ee50bf85e3fd", "parents": [ "4a28a3fa8c37193b105807193b3695048f0050a4" ], "author": { "name": "Dan Carpenter", "email": "error27@gmail.com", "time": "Wed Jul 27 14:11:43 2011 +0300" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jul 27 20:28:16 2011 +0000" }, "message": "iscsi-target: strlen() doesn\u0027t count the terminator\n\nThis patch fixes an off by one check in iscsit_add_tiqn() because the\nNULL terminator isn\u0027t taken into consideration.\n\nSigned-off-by: Dan Carpenter \u003cerror27@gmail.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "4a28a3fa8c37193b105807193b3695048f0050a4", "tree": "60c42c12dd1f09a75af0f0a35f98acef4ac7ae0f", "parents": [ "277c5f27a2c86a9a733c0ec0f6a9b1032dfa3e15" ], "author": { "name": "Dan Carpenter", "email": "error27@gmail.com", "time": "Wed Jul 27 12:58:17 2011 +0300" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Wed Jul 27 20:28:04 2011 +0000" }, "message": "iscsi-target: Fix NULL dereference on allocation failure\n\nThis patch fixes a bug in iscsi_target_init_negotiation() where\nthe \"goto out\" path dereferences \"login\" which is NULL upon a\nmemory allocation failure.\n\nSigned-off-by: Dan Carpenter \u003cerror27@gmail.com\u003e\nSigned-off-by: Nicholas Bellinger \u003cnab@linux-iscsi.org\u003e\n" }, { "commit": "e48354ce078c079996f89d715dfa44814b4eba01", "tree": "7a593b6dd4864073944160fe227aae5d54e587ab", "parents": [ "8304bbceee505742925b487fd8ea56e1f8b4b805" ], "author": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Sat Jul 23 06:43:04 2011 +0000" }, "committer": { "name": "Nicholas Bellinger", "email": "nab@linux-iscsi.org", "time": "Tue Jul 26 09:16:43 2011 +0000" }, "message": "iscsi-target: Add iSCSI fabric support for target v4.1\n\nThe Linux-iSCSI.org target module is a full featured in-kernel\nsoftware implementation of iSCSI target mode (RFC-3720) for the\ncurrent WIP mainline target v4.1 infrastructure code for the v3.1\nkernel. More information can be found here:\n\nhttp://linux-iscsi.org/wiki/ISCSI\n\nThis includes support for:\n\n * RFC-3720 defined request / response state machines and support for\n all defined iSCSI operation codes from Section 10.2.1.2 using libiscsi\n include/scsi/iscsi_proto.h PDU definitions\n * Target v4.1 compatible control plane using the generic layout in\n target_core_fabric_configfs.c and fabric dependent attributes\n within /sys/kernel/config/target/iscsi/ subdirectories.\n * Target v4.1 compatible iSCSI statistics based on RFC-4544 (iSCSI MIBS)\n * Support for IPv6 and IPv4 network portals in M:N mapping to TPGs\n * iSCSI Error Recovery Hierarchy support\n * Per iSCSI connection RX/TX thread pair scheduling affinity\n * crc32c + crc32c_intel SSEv4 instruction offload support using libcrypto\n * CHAP Authentication support using libcrypto\n * Conversion to use internal SGl allocation with iscsit_alloc_buffs() -\u003e\n transport_generic_map_mem_to_cmd()\n\n(nab: Fix iscsi_proto.h struct scsi_lun usage from linux-next in commit:\n iscsi: Use struct scsi_lun in iscsi structs instead of u8[8])\n(nab: Fix 32-bit compile warnings)\n\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Andy Grover \u003cagrover@redhat.com\u003e\nAcked-by: Roland Dreier \u003croland@kernel.org\u003e\nSigned-off-by: Nicholas A. Bellinger \u003cnab@linux-iscsi.org\u003e\n" } ] }