)]}'
{
  "commit": "558e10a57db10de355ee97712d2b6df49e9b7849",
  "tree": "96c2289644358c43e5154c33d5a511ad3f06c324",
  "parents": [
    "d254bcdbf2199d9e2a52dbe4592e79ef3a456096"
  ],
  "author": {
    "name": "Diego Calleja",
    "email": "diegocg@gmail.com",
    "time": "Sat Aug 05 21:15:58 2006 -0700"
  },
  "committer": {
    "name": "David S. Miller",
    "email": "davem@davemloft.net",
    "time": "Sat Aug 05 21:15:58 2006 -0700"
  },
  "message": "[LAPB]: Fix windowsize check\n\nIn bug #6954, Norbert Reinartz reported the following issue:\n\n\"Function lapb_setparms() in file net/lapb/lapb_iface.c checks if the given\nparameters are valid. If the given window size is in the range of 8 .. 127,\nlapb_setparms() fails and returns an error value of LAPB_INVALUE, even if bit\nLAPB_EXTENDED in parms-\u003emode is set.\nIf bit LAPB_EXTENDED in parms-\u003emode is set and the window size is in the range\nof 8 .. 127, the first check \"(parms-\u003emode \u0026 LAPB_EXTENDED)\" results true  and\nthe second check \"(parms-\u003ewindow \u003c 1 || parms-\u003ewindow \u003e 127)\" results false.\nBoth checks in conjunction result to false, thus the third check \"(parms-\u003ewindow\n\u003c 1 || parms-\u003ewindow \u003e 7)\" is done by fault.\nThis third check results true, so that we leave lapb_setparms() by \u0027goto out_put\u0027.\nSeems that this bug doesn\u0027t cause any problems, because lapb_setparms() isn\u0027t\nused to change the default values of LAPB. We are using kernel lapb in our\nsoftware project and also change the default parameters of lapb, so we found\nthis bug\"\n\nHe also pasted a fix, that I\u0027ve transformated into a patch:\n\nSigned-off-by: Diego Calleja \u003cdiegocg@gmail.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d504eed416f6a468fb95c7d8da9aa2cebdf3813a",
      "old_mode": 33188,
      "old_path": "net/lapb/lapb_iface.c",
      "new_id": "7e6bc41eeb216df942fcaf4b0575a1d4e26a6d05",
      "new_mode": 33188,
      "new_path": "net/lapb/lapb_iface.c"
    }
  ]
}