)]}' { "log": [ { "commit": "b36190c5f85724da1871bfb8eddbeb77a45c4952", "tree": "d424160e8bed505f1073709e0d5504068784f8d2", "parents": [ "a3978a519461b095b776f44a86079f5448c96963" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jan 27 17:07:18 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jan 27 21:02:40 2014 -0800" }, "message": "checkpatch.pl: check for function declarations without arguments\n\nFunctions like this one are evil:\n\nvoid foo()\n{\n\t...\n}\n\nBecause these functions allow variadic arguments without\nchecking the arguments at all.\n\nOriginal patch by Richard Weinberger.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Richard Weinberger \u003crichard@nod.at\u003e\nCc: Borislav Petkov \u003cbp@alien8.de\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "98a9bba51c6e47f69c4fa22cc39a600d2e39536c", "tree": "b390dcdd936226bca71243d0cac5b27f8a34d4f4", "parents": [ "bff5da4335256513497cc8c79f9a9d1665e09864" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Jan 23 15:54:52 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:58 2014 -0800" }, "message": "checkpatch: prefer ether_addr_copy to memcpy(foo, bar, ETH_ALEN)\n\nether_addr_copy was added for kernel version 3.14. It\u0027s slightly\nsmaller/faster for some arches. Encourage its use.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: David Miller \u003cdavem@davemloft.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "bff5da4335256513497cc8c79f9a9d1665e09864", "tree": "4cd51486058e7cdd0ec77073f729da849a150da7", "parents": [ "109d8cb2002dcb0fff04ff1afe8f1cec66bbdad9" ], "author": { "name": "Rob Herring", "email": "robh@kernel.org", "time": "Thu Jan 23 15:54:51 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:58 2014 -0800" }, "message": "checkpatch: add DT compatible string documentation checks\n\nThis adds a simple check that any compatible strings in DeviceTree dts\nfiles are present in Documentation/devicetree/bindings. Vendor prefixes\nare also checked for existing in vendor-prefixes.txt These should be\ntemporary checks until we have more sophisticated binding schema\nchecking.\n\nSigned-off-by: Rob Herring \u003crobh@kernel.org\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Grant Likely \u003cgrant.likely@linaro.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "109d8cb2002dcb0fff04ff1afe8f1cec66bbdad9", "tree": "aec7141b4b8a9f24d8f9cf74ed1eb9f6150325fd", "parents": [ "31070b5d4490c6c876e0d3b093e5d5b05e4027fa" ], "author": { "name": "Alexander Duyck", "email": "alexander.h.duyck@intel.com", "time": "Thu Jan 23 15:54:50 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:58 2014 -0800" }, "message": "checkpatch: only flag FSF address, not gnu.org URL\n\nThis change restricts the check for the for the FSF address in the GPL\ncopyright statement so that it only flags the address, not the\nreferences to the gnu.org/licenses URL which appears to be used in\nnumerous drivers. The idea is to still allow some reference to an\nexternal copy of the GPL in the event that files are copied out of the\nkernel tree without the COPYING file.\n\nSo for example this statement will still return an error:\n You should have received a copy of the GNU General Public License\n along with this program; if not, write to the Free Software\n Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.\n\nHowever, this statement will not return an error after this patch:\n You should have received a copy of the GNU General Public License\n along with this program. If not, see \u003chttp://www.gnu.org/licenses/\u003e.\n\nSigned-off-by: Alexander Duyck \u003calexander.h.duyck@intel.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "31070b5d4490c6c876e0d3b093e5d5b05e4027fa", "tree": "7d6a71fcb471bdc4f82e6fc101d8043e966f1d15", "parents": [ "3e2232f2d03ffa531e31662c447496ec2552d85b" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Jan 23 15:54:49 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:58 2014 -0800" }, "message": "checkpatch: add tests for function pointer style misuses\n\nKernel style uses function pointers in this form:\n\t\"type (*funcptr)(args...)\"\n\nEmit warnings when this function pointer form isn\u0027t used.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nCc: Derek Perrin \u003cd.roc16@gmail.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3e2232f2d03ffa531e31662c447496ec2552d85b", "tree": "57a97643ee91135730ebc4cd84fa7697b6bd4511", "parents": [ "189248d8f4f3ac2fba30da9b40133b5891df95fc" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Jan 23 15:54:48 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:58 2014 -0800" }, "message": "checkpatch: update the FSF/GPL address check\n\nThe FSF address check is a bit too verbose looking for the GPL text.\nQuiet it a bit by requiring --strict for the GPL bit.\n\nAlso make the address tests match a few uses of abbreviations for street\nnames and make it case insensitive.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReviewed-by: Josh Triplett \u003cjosh@joshtriplett.org\u003e\nCc: Manfred Spraul \u003cmanfred@colorfullife.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "189248d8f4f3ac2fba30da9b40133b5891df95fc", "tree": "8c1f512c32463c29de4792b17a30822555cdbc76", "parents": [ "c76f4cb3d25e5dc84017d7e845072e9aef6037f4" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Jan 23 15:54:47 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:58 2014 -0800" }, "message": "checkpatch: check for if\u0027s with unnecessary parentheses\n\nIf statements don\u0027t need multiple parentheses around tested comparisons\nlike \"if ((foo \u003d\u003d bar))\".\n\nAn \u003d\u003d comparison maybe a sign of an intended assignment, so emit a\nslightly different message if so.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReviewed-by: Josh Triplett \u003cjosh@joshtriplett.org\u003e\nCc: Manfred Spraul \u003cmanfred@colorfullife.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c76f4cb3d25e5dc84017d7e845072e9aef6037f4", "tree": "68e8dc16563af714984bb236d904d1f4ca735f95", "parents": [ "9624b8d65cd1e9a6415a81a6588e423b1d8c2282" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Jan 23 15:54:46 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:58 2014 -0800" }, "message": "checkpatch: improve space before tab --fix option\n\nThis test should remove all the spaces before a tab not just one space.\n\nSubstitute a tab for each 8 space block before a tab and remove less than\n8 spaces before a tab.\n\nThis SPACE_BEFORE_TAB test is done after CODE_INDENT.\n\nIf there are spaces used at the beginning of a line that should be\nconverted to tabs, please make sure that the CODE_INDENT test and\nconversion is done before this SPACE_BEFORE_TAB test and conversion.\n\nReported-by: Manfred Spraul \u003cmanfred@colorfullife.com\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Josh Triplett \u003cjosh@joshtriplett.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9624b8d65cd1e9a6415a81a6588e423b1d8c2282", "tree": "3efead36061f8934d6d2d0bdc2c571ee8ffc1539", "parents": [ "c34c09a8451fac8555cbf0e8df1f6cf31cf1360b" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Jan 23 15:54:44 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:58 2014 -0800" }, "message": "checkpatch: add a --fix-inplace option\n\nAdd the ability to fix and overwrite existing files/patches instead of\ncreating a new file \"\u003cfilename\u003e.EXPERIMENTAL-checkpatch-fixes\".\n\nSuggested-by: Manfred Spraul \u003cmanfred@colorfullife.com\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReviewed-by: Josh Triplett \u003cjosh@joshtriplett.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c34c09a8451fac8555cbf0e8df1f6cf31cf1360b", "tree": "c02d5fc86654daa828f610a3d212f899ae6dee7d", "parents": [ "7e4915e78992ebd3cc031051dc23063bbf29e749" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Jan 23 15:54:43 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:57 2014 -0800" }, "message": "checkpatch: attempt to find missing switch/case break;\n\nswitch case statements missing a break statement are an unfortunately\ncommon error.\n\ne.g.:\n commit 4a2c94c9b6c0 (\"HID: kye: Add report fixup for Genius Manticore Keyboard\")\n\ncase blocks should end in a break/return/goto/continue.\n\nIf a fall-through is used, it should have a comment showing that it is\nintentional. Ideally that comment should be something like:\n\"/* fall-through */\"\n\nAdd a test to look for missing break statements.\n\nThis looks only at the context lines before an inserted case so it\u0027s\npossible to have false positives when the context contains a close brace\nand the break is before the brace and not part of the patch context.\n\nLooking at recent patches, this is a pretty rare occurrence. The normal\nkernel style uses a break as the last line of the previous block.\n\nSigned-off-by: Joe Perches \u003cjoe@perche.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nCc: Jiri Kosina \u003cjkosina@suse.cz\u003e\nCc: Benjamin Tissoires \u003cbenjamin.tissoires@redhat.com\u003e\nCc: Dave Jones \u003cdavej@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7e4915e78992ebd3cc031051dc23063bbf29e749", "tree": "4c57102fdf47e26e466aa923f176552944791313", "parents": [ "d2e248e7b0068b940f3ca1fc26da603536a533db" ], "author": { "name": "David Rientjes", "email": "rientjes@google.com", "time": "Thu Jan 23 15:54:42 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:57 2014 -0800" }, "message": "checkpatch: add warning of future __GFP_NOFAIL use\n\ngfp.h and page_alloc.c already specify that __GFP_NOFAIL is deprecated and\nno new users should be added.\n\nAdd a warning to checkpatch to catch this.\n\nSigned-off-by: David Rientjes \u003crientjes@google.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d2e248e7b0068b940f3ca1fc26da603536a533db", "tree": "f40f33a4dfbb04615575be0b1600db48b5894a79", "parents": [ "8c5fcd24a9ea608286816a1508c067c8a512af78" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Jan 23 15:54:41 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:57 2014 -0800" }, "message": "checkpatch: warn only on \"space before semicolon\" at end of line\n\nThe \"space before a non-naked semicolon\" test has unwanted output when\nused in \"for ( ;; )\" loops.\n\nMake the test work only on end-of-line statement termination semicolons.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Dan Carpenter \u003cdan.carpenter@oracle.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8c5fcd24a9ea608286816a1508c067c8a512af78", "tree": "6d6e2e1af8034d0ccd22b7eb1370a06bf1783458", "parents": [ "cf0744021c5d5de54d2c66e2020c6de2fe800264" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Jan 23 15:54:40 2014 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 23 16:36:57 2014 -0800" }, "message": "checkpatch: more comprehensive split strings warning\n\nThe current checkpatch test for split strings does not find several\ncases that should be found.\n\nFor instance:\n\n \t\t/* Else poor success; go back to mode in \"active\" table */\n \t\t} else {\n \t\t\tIWL_DEBUG_RATE(mvm,\n-\t\t\t\t \"LQ: GOING BACK TO THE OLD TABLE suc\u003d%d cur-tpt\u003d%d old-tpt\u003d%d\\n\",\n+\t\t\t\t \"GOING BACK TO THE OLD TABLE: SR %d \"\n+\t\t\t\t \"cur-tpt %d old-tpt %d\\n\",\n \t\t\t\t window-\u003esuccess_ratio,\n \t\t\t\t window-\u003eaverage_tpt,\n \t\t\t\t lq_sta-\u003elast_tpt);\n\ndoes not currently emit a warning.\n\nImprove the test to find these cases.\n\nAdd more exceptions to reduce false positives for assembly and octal/hex\nstring constants.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReviewed-by: Josh Triplett \u003cjosh@joshtriplett.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "92e112fdbb3cb55b43390426501a7efacd893b96", "tree": "4f77ae248e2e7fc8a5633e2feb6e83e5c0f0de5f", "parents": [ "5b764b834ea925b7fc87df4a87a0fde95acbecb9" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Fri Dec 13 11:36:22 2013 -0700" }, "committer": { "name": "Bjorn Helgaas", "email": "bhelgaas@google.com", "time": "Fri Dec 13 11:36:22 2013 -0700" }, "message": "PCI/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE\n\nPrefer use of the direct definition of struct pci_device_id instead of\nindirection via macro DEFINE_PCI_DEVICE_TABLE.\n\nUpdate the PCI documentation to deprecate DEFINE_PCI_DEVICE_TABLE. Update\ncheckpatch adding --fix option.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Bjorn Helgaas \u003cbhelgaas@google.com\u003e\nReviewed-by: Jingoo Han \u003cjg1.han@samsung.com\u003e" }, { "commit": "c11230f44b3c3e055e4e7cd572fc1c4a22c6f4a9", "tree": "c6181aa0d144506cc0e08147b3ed6a60d8ff06f5", "parents": [ "76ae281f6307331aa063288edb6422ae99f435f0" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Nov 21 14:31:57 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Nov 21 16:42:27 2013 -0800" }, "message": "checkpatch: fix \"Use of uninitialized value\" warnings\n\ncheckpatch is currently confused about some complex macros and references\nundefined variables $stat and $cond.\n\nMake sure these are defined before using them.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReported-by: Gerhard Sittig \u003cgsi@denx.de\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "823b794ce176bcf135a062075737be71a78629dd", "tree": "27ee885ad9d07e3421f04e846a3507b74ffe1fa7", "parents": [ "2b7ab45395dc4d91ef30985f76d90a8f28f58c27" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Nov 12 15:10:15 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Nov 13 12:09:25 2013 +0900" }, "message": "checkpatch: add check for sscanf without return use\n\nNaked use sscanf can be troublesome because the pointed to variables may\nnot have been set.\n\nAdd a warning when the sscanf return value is not used.\n\nFor now, do not add __must_check to the sscanf prototype because that will\ncause a couple of hundred new warnings when compiling a kernel.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "2b7ab45395dc4d91ef30985f76d90a8f28f58c27", "tree": "e15c7ed2dd28389a1155daad6d3f178d9d69ff2e", "parents": [ "507e51418ca0c98640310aa02450720825b2b6b1" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Nov 12 15:10:14 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Nov 13 12:09:25 2013 +0900" }, "message": "checkpatch: don\u0027t require kernel style __attribute__ shortcuts in uapi paths\n\nAvoid prescribing kernel styled shortcuts for gcc extensions of\n__attribute__((foo)) in the uapi include paths.\n\nFix $realfile filename when using -f/--file to not remove first level\ndirectory as if the filename was used in a -P1 patch. Only strip the\nfirst level directory (typically a or b) for P1 patches.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: \"Dixit, Ashutosh\" \u003cashutosh.dixit@intel.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "507e51418ca0c98640310aa02450720825b2b6b1", "tree": "c31ed1d6e0fa1686ac3738aea997a82fc524bade", "parents": [ "4783f894d0f3bfb107cf3b1d9aed1f1a0672ee1d" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Nov 12 15:10:13 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Nov 13 12:09:25 2013 +0900" }, "message": "checkpatch: improve \"return is not a function\" test\n\nFind a few more cases where parentheses are used around the value of a\nreturn statement.\n\nThis now uses the \"$balanced_parens\" test and also makes the test depend\non perl v5.10 and higher.\n\nThis now finds return with parenthesis uses the old code did not find\nlike:\n\nERROR: return is not a function, parentheses are not required\n#211: FILE: arch/m68k/include/asm/sun3xflop.h:211:\n+\t\treturn ((error \u003d\u003d 0) ? 0 : -1);\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nTested-by: David Cohen \u003cdavid.a.cohen@linux.intel.com\u003e\nAcked-by: David Cohen \u003cdavid.a.cohen@linux.intel.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4783f894d0f3bfb107cf3b1d9aed1f1a0672ee1d", "tree": "587e0caa33d507b767ec2a6d2691ec91f18c50b5", "parents": [ "c1fd7bb99637e69994d26df5f6e33192319d3866" ], "author": { "name": "Josh Triplett", "email": "josh@joshtriplett.org", "time": "Tue Nov 12 15:10:12 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Nov 13 12:09:25 2013 +0900" }, "message": "checkpatch.pl: check for the FSF mailing address\n\nKernel maintainers reject new instances of the GPL boilerplate paragraph\ndirecting people to write to the FSF for a copy of the GPL, since the FSF\nhas moved in the past and may do so again.\n\nMake this an error for new code, but just a --strict CHK in --file mode;\nanyone interested in doing tree-wide cleanups of this form can enable this\ntest explicitly.\n\nSigned-off-by: Josh Triplett \u003cjosh@joshtriplett.org\u003e\nAcked-by: Greg Kroah-Hartman \u003cgregkh@linuxfoundation.org\u003e\nAcked-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c1fd7bb99637e69994d26df5f6e33192319d3866", "tree": "875cadcd10bc9375fefe44ebe665e4666cc4bb53", "parents": [ "e970b8846ae4763e64be3c93dc06b4eaebf9ad63" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Nov 12 15:10:11 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Nov 13 12:09:25 2013 +0900" }, "message": "checkpatch: make the memory barrier test noisier\n\nPeter Zijlstra prefers that comments be required near uses of memory\nbarriers.\n\nChange the message level for memory barrier uses from a --strict test only\nto a normal WARN so it\u0027s always emitted.\n\nThis might produce false positives around insertions of memory barriers\nwhen a comment is outside the patch context block.\n\nAnd checkpatch is still stupid, it only looks for existence of any\ncomment, not at the comment content.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Peter Zijlstra \u003cpeterz@infradead.org\u003e\nAcked-by: Peter Zijlstra \u003cpeterz@infradead.org\u003e\nAcked-by: Paul E. McKenney \u003cpaulmck@linux.vnet.ibm.com\u003e\nCc: Oliver Neukum \u003coliver@neukum.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e970b8846ae4763e64be3c93dc06b4eaebf9ad63", "tree": "2543f6bd1d9aa24249c3d8418c0dc369434aad81", "parents": [ "52ea85061d188031c827ecef9bce47ae93f1e52e" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Nov 12 15:10:10 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Nov 13 12:09:25 2013 +0900" }, "message": "checkpatch: add rules to check init attribute and const defects\n\nPeople get this regularly wrong and it breaks the LTO builds, as it causes\na section attribute conflict.\n\nAdd --fix capability too.\n\nBased on a patch from Andi Kleen.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andi Kleen \u003cak@linux.intel.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "52ea85061d188031c827ecef9bce47ae93f1e52e", "tree": "613a13b5542918ea5a0b08c992bddcbd81453b76", "parents": [ "11ea516a6c578564a65a352abb08ef558d365946" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Nov 12 15:10:09 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Nov 13 12:09:24 2013 +0900" }, "message": "checkpatch: add test for #defines of ARCH_HAS_\u003cfoo\u003e\n\nAdd a test for these #defines\n\nAdditionally, moved string_find_replace sub as it screws up subsequent\nformatting when placed inside another sub.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "11ea516a6c578564a65a352abb08ef558d365946", "tree": "b9373f23d089a5c762ee72c52cd9c3e1d4e11222", "parents": [ "066687279ccf5e9e935f7780c4b311d18ebaf977" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Nov 12 15:10:08 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Nov 13 12:09:24 2013 +0900" }, "message": "checkpatch: find CamelCase definitions of struct/union/enum\n\nCheckpatch doesn\u0027t currently find CamelCase definitions of structs, unions\nor enums.\n\nAdd that ability.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "066687279ccf5e9e935f7780c4b311d18ebaf977", "tree": "389261e12f14f4ac8af609f55cb4c728133ccc7e", "parents": [ "d8b077101bcfbd36701c18bfda04fd74648d5d35" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Nov 12 15:10:07 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Nov 13 12:09:24 2013 +0900" }, "message": "checkpatch: update seq_\u003cfoo\u003e tests\n\nseq_vprintf, seq_printf and seq_puts are logging functions and should be\nallowed to exceed the maximium line length.\n\nAdd maximum line length exceptions for these functions.\n\nAlso, suggesting seq_printf conversions to seq_puts should be tested for\narguments after the format.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d8b077101bcfbd36701c18bfda04fd74648d5d35", "tree": "d7ed8875a42cfb1fa7c90ab98f18314c90fb111a", "parents": [ "847316231c2f89918a2872e3d5fa3f5de11c39b6" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Nov 12 15:10:06 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Nov 13 12:09:24 2013 +0900" }, "message": "checkpatch: extend CamelCase types and ignore existing CamelCase uses in a patch\n\nExtend the CamelCase words found to include structure members.\n\nIn https://lkml.org/lkml/2013/9/3/318 Sarah Sharp (mostly) wrote:\n\n\"In general, if checkpatch.pl complains about a variable a patch\nintroduces that\u0027s CamelCase, you should pay attention to it. Otherwise,\n[] ignore it.\"\n\nSo, if checking a patch, scan the original patched file if it\u0027s available\nand add any preexisting CamelCase types so reuses do not generate\nCamelCase messages.\n\nThat also means Andrew\u0027s not so cruelly spurned anymore.\nhttps://lkml.org/lkml/2013/2/22/426\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Sarah Sharp \u003csarah.a.sharp@linux.intel.com\u003e\nSuggested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "847316231c2f89918a2872e3d5fa3f5de11c39b6", "tree": "b164674e5fd816e0f8bd54279604d4c1d3347a9d", "parents": [ "6bc080d8fdae33f4463203a400cfaa01e91701e2" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Nov 12 15:10:05 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Nov 13 12:09:24 2013 +0900" }, "message": "checkpatch: report missing spaces around trigraphs with --strict\n\nSpaces around trigraphs are specified by CodingStyle but checkpatch is\ncurrently silent about them because there are many current instances\nwithout them.\n\nMake missing spaces around trigraphs a --strict message.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReviewed-by: Josh Triplett \u003cjosh@joshtriplett.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d1d85780dd30e137d8ff505c1c2e79eaf729853d", "tree": "5688d52d88f6a97b7b8ae26afa1f58ac10dd9347", "parents": [ "58f09e00ae095e46ef9edfcf3a5fd9ccdfad065e" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Sep 24 15:27:46 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Sep 24 17:00:26 2013 -0700" }, "message": "checkpatch: make extern in .h prototypes quieter\n\nThe use of extern in .h files is a bit contentious.\n\nMake the warning be emitted only when --strict is used on the command\nline.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: David Howells \u003cdhowells@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8716de383b82f16d920513138f1691e40ef5a9e3", "tree": "2709bb597a4d722eb1777aea752aad62c843ba04", "parents": [ "58cb3cf66cc6330910316abb1dc7a7aa78917a27" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Sep 11 14:24:05 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:49 2013 -0700" }, "message": "checkpatch: add test for positional misuse of section specifiers like __initdata\n\nAs discussed recently on the arm [1] and lm-sensors [2] lists, it is\npossible to use section markers on variables in a way which gcc doesn\u0027t\nunderstand (or at least not the way the developer intended):\n\nstatic struct __initdata samsung_pll_clock exynos4_plls[nr_plls] \u003d {\n\ndoes NOT put exynos4_plls in the .initdata section. The __initdata marker\ncan be virtually anywhere on the line, EXCEPT right after \"struct\". The\npreferred location is before the \"\u003d\" sign if there is one, or before the\ntrailing \";\" otherwise.\n\n[1] http://permalink.gmane.org/gmane.linux.ports.arm.kernel/258149\n[2] http://lists.lm-sensors.org/pipermail/lm-sensors/2013-August/039836.html\n\nSo, update checkpatch to find these misuses and report an error when it\u0027s\nimmediately after struct or union, and a warning when it\u0027s otherwise not\nimmediately before the ; or \u003d.\n\nA similar patch was suggested by Andi Kleen\nhttps://lkml.org/lkml/2013/8/5/648\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Jean Delvare \u003ckhali@linux-fr.org\u003e\nTested-by: Guenter Roeck \u003clinux@roeck-us.net\u003e\nCc: Andi Kleen \u003candi@firstfloor.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "58cb3cf66cc6330910316abb1dc7a7aa78917a27", "tree": "2be791e7173ebf0b2a629acaaee8009d6c5f7c23", "parents": [ "1b5539b1ffbdcf7113eebea7f37141d4468d9070" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Sep 11 14:24:04 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:49 2013 -0700" }, "message": "checkpatch: fix perl version 5.12 and earlier incompatibility\n\nA previous patch (\"checkpatch: add --types option to report only\nspecific message types\") uses a perl syntax introduced in perl version\n5.14.\n\nUse the backward compatible perl syntax instead.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReported-by: Julia Lawall \u003cjulia.lawall@lip6.fr\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1b5539b1ffbdcf7113eebea7f37141d4468d9070", "tree": "3c58c77b71cf7da626d966e018856b1e64932890", "parents": [ "b34c648bb33ca143b98851fd7fe7250f1875c463" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Sep 11 14:24:03 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:48 2013 -0700" }, "message": "checkpatch: reduce runtime/cpu time used\n\nThere are some cases where checkpatch can take a long time to complete.\nReduce the likelihood of this long run-time by adding a new test for lines\nwith and without comments and eliminating checks on lines with only\ncomments.\n\nThis reduces the number of \"ctx_statement_block\" calls, and also the\nnumber of tests of $stat, which is now undefined for these blank lines.\n\nOne test in particular, the \"check for switch/default statements without a\nbreak\", could take an extremely long time to parse as it tries to skip\ninterleaving comments within the ctx_statement_block/$stat and that could\nbe done multiple times unnecessarily.\n\nA small test case taken from cfg80211.h before this patch would take\n1000\u0027s of seconds to run, now it\u0027s just a couple seconds.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b34c648bb33ca143b98851fd7fe7250f1875c463", "tree": "f3e531f96906eb951677147daf8b15cdbde3a309", "parents": [ "f95a7e6a462ed1338bd576ccb557ff86772a0776" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Sep 11 14:24:01 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:48 2013 -0700" }, "message": "checkpatch: better --fix of SPACING errors.\n\nPrevious attempt at fixing SPACING errors could make a hash of several\ndefects.\n\nThis patch should make --fix be a lot better at correcting these defects.\n\nTrim left and right sides of these defects appropriately instead of a\nsomewhat random attempt at it.\n\nTrim left spaces from any following bit of the modified line when only a\nsingle space is required around an operator.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Phil Carmody \u003cphil.carmody@partner.samsung.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f95a7e6a462ed1338bd576ccb557ff86772a0776", "tree": "ad85c177e88e05a43b66bc519825ff291656410f", "parents": [ "91bfe4843dff4426ca3a0dd1dab8454c1534022d" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Sep 11 14:24:00 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:46 2013 -0700" }, "message": "checkpatch: ignore #define TRACE_\u003cfoo\u003e macros\n\nThe tracing subsystem uses slightly odd #defines to set path/directory\nlocations for include files.\n\nThese #defines can cause false positives for the complex macro tests so\nadd exclusions for these specific #defines (TRACE_SYSTEM,\nTRACE_INCLUDE_FILE, TRACE_INCLUDE_PATH).\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Sarah Sharp \u003csarah.a.sharp@linux.intel.com\u003e\nCc: Li Zefan \u003clizefan@huawei.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "91bfe4843dff4426ca3a0dd1dab8454c1534022d", "tree": "45bd3d4f0ce6d7b8f59a956ce5728b6ff9ed871d", "parents": [ "61135e966367eda5056504ffd2f7518eaf77e25b" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Sep 11 14:23:59 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:45 2013 -0700" }, "message": "checkpatch: add --types option to report only specific message types\n\nAdd a --types convenience option to show only specific message types.\nCombined with the --fix option, this can produce specific suggested\nformatting patches to files.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "61135e966367eda5056504ffd2f7518eaf77e25b", "tree": "147fa33fb15f77eb5af50ad845ea19ba00f3cae9", "parents": [ "70dc8a48357ce630d8a76887a9a36f0d34c8caf2" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Sep 11 14:23:59 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:44 2013 -0700" }, "message": "checkpatch: fix networking kernel-doc block comment defect\n\ncheckpatch can generate a false positive when inserting a new kernel-doc\nblock and function above an existing kernel-doc block.\n\nFix it by checking that the context line is also a newly inserted line.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReported-by: Darren Hart \u003cdvhart@linux.intel.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "70dc8a48357ce630d8a76887a9a36f0d34c8caf2", "tree": "aba8963ae8efcc2c6ecaa5cb495e53254fa9d7fc", "parents": [ "7e51f1979237e01bcd4e04e434c5da79151f08f8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Sep 11 14:23:58 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:43 2013 -0700" }, "message": "checkpatch: warn when using extern with function prototypes in .h files\n\nUsing the extern keyword on function prototypes is superfluous visual\nnoise so suggest removing it.\n\nUsing extern can cause unnecessary line wrapping at 80 columns and\nunnecessarily long multi-line function prototypes.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Hannes Frederic Sowa \u003channes@stressinduktion.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7e51f1979237e01bcd4e04e434c5da79151f08f8", "tree": "17cfd69cb04e0ed9e66d5f436199f9dc8bbe3fea", "parents": [ "d62a201f24cba74e2fbf9f6f7af86ff5f5e276fc" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Sep 11 14:23:57 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:42 2013 -0700" }, "message": "checkpatch: check for duplicate signatures\n\nEmit a warning when a signature is used more than once.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d62a201f24cba74e2fbf9f6f7af86ff5f5e276fc", "tree": "8744109e08545cc175c0c1aaf86bc82b93dd662e", "parents": [ "7e781f67df436b67753a65436c0fef0a0ebf5043" ], "author": { "name": "Dave Hansen", "email": "dave.hansen@linux.intel.com", "time": "Wed Sep 11 14:23:56 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:41 2013 -0700" }, "message": "checkpatch: enforce sane perl version\n\nI got a bug report from a couple of users who said checkpatch.pl was\nbroken for them. It was erroring out on fairly random lines most commonly\nwith messages like:\n\n\tNested quantifiers in regex; marked by \u003c--HERE in m/(\\((?:[^\\(\\)]++ \u003c-- HERE |(?-1))*\\))/ at ./checkpatch.pl line 340.\n\nThe bug reporter was running a version of perl 5.8 which was end-of-lifed\nin 2008: http://www.cpan.org/src/. Versions of perl this old are at\n_best_ quite untested. At worst, they are crusty and known to be\ncompletely broken.\n\nIf folks have a system _that_ old, then we should have mercy on them and\ngive them a half-decent error message rather than fail with nutty error\nmessages.\n\nThis patch enforces that checkpatch.pl is run with perl 5.10, which was\nend-of-lifed in 2009. The new --ignore-perl-version command-line switch\nwill let folks override this if they want.\n\nSigned-off-by: Dave Hansen \u003cdave.hansen@linux.intel.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7e781f67df436b67753a65436c0fef0a0ebf5043", "tree": "3fd10d6d6bb55e684adb77f9958d9db269aa9272", "parents": [ "d5e616fc1c1dd673c53b682877e2d35a2862263c" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Sep 11 14:23:55 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:40 2013 -0700" }, "message": "checkpatch: check CamelCase by word, not by $Lval\n\n$Lval is a test for complete name (ie: foo-\u003ebar.Baz[1])\n\nIf any of this is CamelCase, then the current test uses the entire $Lval.\nThis isn\u0027t optimal because it can emit messages with foo-\u003ebar.Baz and\nbar.Baz when Baz is a variable specified in an include file.\n\nSo instead, break the $Lval into words and check each word for CamelCase\nuses.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d5e616fc1c1dd673c53b682877e2d35a2862263c", "tree": "c1eec612d62f6c6d6ade9a843f89ff34ad94fab4", "parents": [ "1431574a1c4c669a0c198e4763627837416e4443" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Sep 11 14:23:54 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Sep 11 15:58:39 2013 -0700" }, "message": "checkpatch: add a few more --fix corrections\n\nSuggest a few more single-line corrections.\n\nRemove DOS line endings\nSimplify removing trailing whitespace\nRemove global/static initializations to 0/NULL\nConvert pr_warning to pr_warn\nAdd space after brace\nConvert binary constants to hex\nRemove whitespace after line continuation\nUse inline not __inline or __inline__\nUse __printf and __scanf\nUse a single ; for statement terminations\nConvert __FUNCTION__ to __func__\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c707a81de71a27a499fde60fbb963f60602c1a94", "tree": "38f6a128f256ba3d2e95b470e83d8ac88c60b2cb", "parents": [ "dcb6b45254e2281b6f99ea7f2d51343954aa3ba8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 08 16:00:43 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jul 09 10:33:25 2013 -0700" }, "message": "checkpatch: make the CamelCase cache work for non-git trees too\n\nMight as well check include timestamps and cache the include file\nCamelCase uses for the non-git case too.\n\nThe camelcase cache file is now named:\n\n for git: .checkpatch-camelcase.git.\u003ccommit_id\u003e\n for non-git: .checkpatch-camelcase.date.\u003cYYYYMMDDhhmm\u003e\n\nAll .checkpatch-camelcase* files are deleted if not current.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "351b2a1fe2d06f44b4c06d377744b2ac408b7407", "tree": "94566bc117b757bfab5c282d56c251121a7f33f9", "parents": [ "7d0b6594e1055e3d4efcc28af11a8e42dd85ded4" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:36 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: cache last camelcase hash as .checkpatch-camelcase.\u003ccommit\u003e\n\nAdd a file to cache the CamelCase variables found by \u003ccommit\u003e to reduce\nthe time it takes to scan the include/ directory.\n\nFilename is \u0027.checkpatch-camelcase.\u003ccommit\u003e\u0027 and it is created only only\nif a .git directory exists.\n\n\u003ccommit\u003e is determined by the last non-merge commit id in the\ninclude/ path.\n\nReduces checkpatch run time by ~12 cpu seconds on my little netbook.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "7d0b6594e1055e3d4efcc28af11a8e42dd85ded4", "tree": "bedce15993d5f37ff1b7af79a5e1b4c1a58b9392", "parents": [ "3445686af721534ac1086a9c6d48b3470dfb6946" ], "author": { "name": "Jacob Keller", "email": "jacob.e.keller@intel.com", "time": "Wed Jul 03 15:05:35 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: allow longer logging function names\n\nThe current $logFunction regular expression allows names like dev_warn,\ne_dbg, netdev_info, etc, but some log functions are now written like\ne_dev_warn, so allow 1 or 2 word blocks with an underscore before the\nlogging level.\n\nSigned-off-by: Jacob Keller \u003cjacob.e.keller@intel.com\u003e\nTested-by: Aaron Brown \u003caaron.f.brown@intel.com\u003e\nSigned-off-by: Jeff Kirsher \u003cjeffrey.t.kirsher@intel.com\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3445686af721534ac1086a9c6d48b3470dfb6946", "tree": "d3b3ece795d3a83e19c8f9e788d3433d275b0bda", "parents": [ "22735ce857a2d9f4e6eec37c36be3fcf9d21d154" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:34 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: ignore existing CamelCase uses from include/...\n\nWhen using --strict, CamelCase uses are described with CHECK: messages.\nThese CamelCase uses may be acceptable and should not generate these\nmessages when the variable is already defined in a file from the\ninclude/... path.\n\nSo, change checkpatch to read all the .h files in include/... and look\nfor preexisting CamelCase #defines, typedefs and function prototypes.\n\nAdd these to the existing camelcase hash so that any uses in the patch or\nfile can be ignored.\n\nThere are currently ~3500 files in include/. It takes about 10 cpu\nseconds on my little netbook to grep for and preseed these existing uses.\n\nThat\u0027s about 4x the time for a similar git grep.\n\nThis preseeding is only done once when using --strict and only when there\nis a CamelCase use found.\n\nIf a .git directory is found, it uses \u0027git ls-files include\u0027 If not, it\nuses \u0027find $root/include -name \"*.h\"\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "22735ce857a2d9f4e6eec37c36be3fcf9d21d154", "tree": "ef64119a99ffce6a804a7ff2d9a0e316934b2654", "parents": [ "786b632622800d73d9b0355c9a79b3f3b5792c6c" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:33 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: ignore SI unit CamelCase variants like \"_uV\"\n\nMany existing variable names use SI like variants that should be otherwise\nobvious and acceptable.\n\nWhitelist them from the CamelCase message.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Phil Carmody \u003cphil.carmody@partner.samsung.com\u003e\nAcked-by: Phil Carmody \u003cphil.carmody@partner.samsung.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "786b632622800d73d9b0355c9a79b3f3b5792c6c", "tree": "e78b97a8730cbbe1c713a6ae4f1811ad78aab871", "parents": [ "3705ce5bcc1037b68e9d20f90ab50bc7f64edd00" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:32 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: move test for space before semicolon after operator spacing\n\nMoving this test allows the --fix option to work better.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3705ce5bcc1037b68e9d20f90ab50bc7f64edd00", "tree": "3f5f6e5a5a749c88418e114a34ee85b9c99fad28", "parents": [ "23f780c90496eb1cc158e862e7035c8468dfa052" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:31 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: create an EXPERIMENTAL --fix option to correct patches\n\nSome patches have simple defects in whitespace and formatting that\ncheckpatch could correct automatically. Attempt to do so.\n\nAdd a --fix option to create a \"\u003cinputfile\u003e.EXPERIMENTAL-checkpatch-fixes\"\nfile that tries to use normal kernel style for some of these formatting\nerrors.\n\nAdd warnings against using this file without verifying the changes.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "23f780c90496eb1cc158e862e7035c8468dfa052", "tree": "568616787bf5f25ad3bc5da9520ed321e5b02383", "parents": [ "179f8f40fc3ae7cd49e96b3a7d5182166c36bdab" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:31 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: improve \"no space after cast\" test\n\nSome false positives exist on this test.\n\nFor instance:\n\t*va_arg(args, signed char *) \u003d val.s;\nor\n\tmemset(foo, 0, sizeof(struct bar *) * baz));\n\nIgnore lines that have an arithmetic operator or assignment\nafter what appears to be a cast to a pointer \"(foo *)\".\n\nAdd $Arithmetic convenience variable.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "179f8f40fc3ae7cd49e96b3a7d5182166c36bdab", "tree": "b2660986886bf926f82efd7960b40db57c0f350c", "parents": [ "77b9a53a627491df83a75361440485629c35aa91" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:30 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:45 2013 -0700" }, "message": "checkpatch: add a --strict test for comparison to true/false\n\nComparing to true or false is error prone.\n\nAdd tests for the various forms of (foo \u003d\u003d true) \u0026\u0026 (false !\u003d bar)\nthat are only reported with --strict.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "77b9a53a627491df83a75361440485629c35aa91", "tree": "8a3176a5cc00a3e8173e03b73b8459f21c8cdf3b", "parents": [ "c4a62ef9102bfa39f3bb89be2ae1ae11a23ebe28" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:29 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: don\u0027t warn on blank lines before/after braces as often\n\nCheck to make sure the blank lines aren\u0027t comment lines like:\n\n bool foo(bool bar)\n {\n\t/* Don\u0027t warn on a leading comment */\n\treturn !bar;\n\t/* Don\u0027t warn on a trailing comment either */\n }\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c4a62ef9102bfa39f3bb89be2ae1ae11a23ebe28", "tree": "f3d0d23c8664d6f8ebcda37f3617b8ecbe5660dc", "parents": [ "3cc4b1c3f0d283f4bb8d49059bd6df8e7af7558b" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:28 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: add a placeholder to check blank lines before declarations\n\nFigure out first how to determine if this is in a struct declaration or in\na function body before enabling this.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3cc4b1c3f0d283f4bb8d49059bd6df8e7af7558b", "tree": "7ac539f3e668317e1fa2f9f2e283d80eecc7333f", "parents": [ "9d7a34a5135d29b840d074ba8fbb9c2fac63e508" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:27 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: reduce false positive rate of \"complex macros\"\n\nAllow \"#define foo struct.member\" without bleating a warning.\n\nThis also allows \"#define foo bar.baz-\u003equx\" and so on.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9d7a34a5135d29b840d074ba8fbb9c2fac63e508", "tree": "3e6869ca31ecf4a1cef0d310427cf937cc1df1cb", "parents": [ "36ec19390effc9131132901e8a66a071a7b74a88" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:26 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: warn on comparisons to get_jiffies_64()\n\nComparing get_jiffies_64() is almost always wrong and time_before64 and\ntime_after64 should be used instead.\n\nWarn on any comparison to get_jiffies_64().\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "36ec19390effc9131132901e8a66a071a7b74a88", "tree": "a0b823311ee76f1ffc4c2b84f9d35446fc449272", "parents": [ "a605e32ebde25dc31f943fecb30e3e28079ccd06" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:25 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: warn on comparisons to jiffies\n\nComparing jiffies is almost always wrong and time_before and time_after\nshould be used instead.\n\nWarn on any comparison to jiffies.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a605e32ebde25dc31f943fecb30e3e28079ccd06", "tree": "42e3079ac358a456aa74a723d4f9c7ffe40b9b4d", "parents": [ "fdb4bcd6108602097b9a1ebd11f6e61f331c8dce" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:24 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: warn when networking block comment lines don\u0027t start with *\n\nSome block comments in network are written as:\n\n\t/* block comment line 1\n\t block comment line 2\n\t */\n\nEmit a warning on the \"block comment line 2\" because it should be\n\n\t/* block comment line 1\n\t * block comment line 2\n\t */\n\nThis warning is only emitted on the second line of a block comment.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fdb4bcd6108602097b9a1ebd11f6e61f331c8dce", "tree": "ecc8b5a175e5cf6c00f6351a803e967a719d484e", "parents": [ "807bd26c4c3e94aced4630ba8369c8941728636b" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:23 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: improve network block comment test and message\n\nShow the first line of the comment after a line with just /* to better\nshow where the defective comment style is in the file.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "807bd26c4c3e94aced4630ba8369c8941728636b", "tree": "6583d6b4fa1714d3b10def6256ea5b18dc59ded1", "parents": [ "a640d25cead66457ac14a878234f8b323ba8aade" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:22 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: remove quote from CamelCase test\n\nCommit be987d9f80 (\"checkpatch: improve CamelCase test for Page\") added\nit but it shouldn\u0027t be there. Must have been my fault.\n\nMake sure that the tested variable doesn\u0027t contain a constant.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a640d25cead66457ac14a878234f8b323ba8aade", "tree": "68226ed2019c2e999efdbf6ccd8d0c53a271e833", "parents": [ "95e2c6023b0e4c8499fb521697f79215f69135fe" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:21 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: add --strict preference for p \u003d kmalloc(sizeof(*p)...\n\nAdd another test for memory allocation style to follow\nDocumentation/CodingStyle:\n\n\t\tChapter 14: Allocating memory\n\nThe preferred form for passing a size of a struct is the following:\n\n\tp \u003d kmalloc(sizeof(*p), ...);\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "95e2c6023b0e4c8499fb521697f79215f69135fe", "tree": "25eb9f42cf21e5476bbdcd4375fa71a546e0b503", "parents": [ "be79794bc116fc0c264be1a599433c92ec9e34f5" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:20 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:44 2013 -0700" }, "message": "checkpatch: warn when using gcc\u0027s binary constant (\"0b\") extension\n\nThe gcc extension for binary constants that start with 0b is only\nsupported with gcc version 4.3 or higher.\n\nThe kernel can still be compiled with earlier versions of gcc, so have\ncheckpatch emit a warning for these constants.\n\nRestructure checkpatch\u0027s constant finding code a bit to support finding\nthese binary constants.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "be79794bc116fc0c264be1a599433c92ec9e34f5", "tree": "55d91938fbfec0094630021274bc97c8a095b1c5", "parents": [ "64df3071a97f20767f63b88c573791691a855b5c" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Jul 03 15:05:20 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Jul 03 16:07:43 2013 -0700" }, "message": "checkpatch: change CamelCase test and make it --strict\n\nDo not bleat a message on nominally acceptable CamelCase uses that are\nseparated by an _ like drm_core_has_MTRR.\n\nCamelCase tests are also a bit noisy against certain types of code\nacceptable to some kernel developers.\n\nMake the test applicable only with --strict.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8543ae1296f6ec1490c7afab6ae0fe97bf87ebf8", "tree": "aa9a2ce97f33051bbcb99079d5fda7311e31f3b3", "parents": [ "74c8f4336da4319f886151a4246024e08b1a0eb3" ], "author": { "name": "Mugunthan V N", "email": "mugunthanvnm@ti.com", "time": "Mon Apr 29 16:18:17 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:20 2013 -0700" }, "message": "checkpatch: add Suggested-by as a standard signature\n\nAs people started using Suggested-by as standard signature, adding\n\"Suggested-by\" to the standard signature so that checkpatch won\u0027t\ngenerate warning when Suggested-by is used in patch signature\n\nSigned-off-by: Mugunthan V N \u003cmugunthanvnm@ti.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "74c8f4336da4319f886151a4246024e08b1a0eb3", "tree": "1953ac3cff35854e438b6bfa5cb001b27615c849", "parents": [ "5646bc71b3ef9634f307f91d9c4bdf38eba4018a" ], "author": { "name": "Matthijs Kooijman", "email": "matthijs@stdin.nl", "time": "Mon Apr 29 16:18:16 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:20 2013 -0700" }, "message": "checkpatch: only warn for empty lines before closing braces by themselves\n\nThis check was intended to catch extra newlines at the end of a function\ndefinition, but it would trigger on any closing brace, including those\nof inline functions and macro definitions, triggering false positives.\nNow, only closing braces on a line by themselves trigger this check.\n\nTested with:\n\n$ cat test.h\n/* test.h - Test file */\n\nstatic inline int foo(void) { return 0; }\n\nstatic inline int bar(void)\n{\n return 1;\n\n}\n\n$ ./scripts/checkpatch.pl --strict -f test.h # Before this commit\nCHECK: Blank lines aren\u0027t necessary before a close brace \u0027}\u0027\n+\n+static inline int foo(void) { return 0; }\n\nCHECK: Blank lines aren\u0027t necessary before a close brace \u0027}\u0027\n+\n+}\n\ntotal: 0 errors, 0 warnings, 2 checks, 9 lines checked\n\n$ ./scripts/checkpatch.pl --strict -f test.h # After this commit\nCHECK: Blank lines aren\u0027t necessary before a close brace \u0027}\u0027\n+\n+}\n\ntotal: 0 errors, 0 warnings, 1 checks, 9 lines checked\n\nSigned-off-by: Matthijs Kooijman \u003cmatthijs@stdin.nl\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nAcked-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5646bc71b3ef9634f307f91d9c4bdf38eba4018a", "tree": "e92492bfcd853e506aaabe2f8a16dcd72861a4d1", "parents": [ "04db4d25d9eaa58140520f976994d1a601129c00" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Apr 29 16:18:15 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:20 2013 -0700" }, "message": "checkpatch: warn on space before semicolon\n\nMake space before semicolon a warning instead of a --strict CHK test.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "04db4d25d9eaa58140520f976994d1a601129c00", "tree": "ef0f2c8c04f8deba8fd9ea9b81d00edbda3f575e", "parents": [ "a6962d7273d8f89c136fe9ea3d61d7f47adcd823" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Apr 29 16:18:14 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:20 2013 -0700" }, "message": "checkpatch: complain about executable files\n\nComplain about files with an executable bit set that are not in a scripts/\ndirectory and are not type .pl, .py, .awk, or .sh\n\nBased on an initial patch from Stephen.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: Stephen Boyd \u003csboyd@codeaurora.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a6962d7273d8f89c136fe9ea3d61d7f47adcd823", "tree": "67d260393e057398039f81acf41c4d35d7c6a01f", "parents": [ "972fdea2e6ece7578915d386a5447bc78d3fb8b8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Apr 29 16:18:13 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:19 2013 -0700" }, "message": "checkpatch: Prefer seq_puts to seq_printf\n\nAdd a check for seq_printf use with a constant format without additional\narguments. Suggest seq_puts instead.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSuggested-by: Bjorn Helgaas \u003cbhelgaas@google.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "972fdea2e6ece7578915d386a5447bc78d3fb8b8", "tree": "22c3cf9b8c078efc8d272df333416faca460914a", "parents": [ "2e0fb404c86d6c86dc33e284310eb5d28d192dcf" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Apr 29 16:18:12 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 29 18:28:19 2013 -0700" }, "message": "checkpatch: add check for reuse of krealloc arg\n\nOn Thu, 2013-03-14 at 13:30 +0000, David Woodhouse wrote:\n\u003e If krealloc() returns NULL, it *doesn\u0027t* free the original. So any code\n\u003e of the form \u0027foo \u003d krealloc(foo, …);\u0027 is almost certainly a bug.\n\nSo add a check for it to checkpatch.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nTested-by: Guenter Roeck \u003clinux@roeck-us.net\u003e\nAcked-by: Guenter Roeck \u003clinux@roeck-us.net\u003e\nCc: David Woodhouse \u003cdwmw2@infradead.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Jean Delvare \u003ckhali@linux-fr.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e942e2c3f7e093fc8756dd8b47c93a821c09429f", "tree": "78e410a09d5b9d0f7e7129bfe998658863cfaf16", "parents": [ "d875cf08391a811703f8adf39db598cac9ece6a1" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Apr 17 15:58:26 2013 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Apr 17 16:10:44 2013 -0700" }, "message": "checkpatch: fix stringification macro defect\n\nFix checkpatch misreporting defect with stringification macros\n\nERROR: Macros with complex values should be enclosed in parenthesis\n #27: FILE: arch/arm/include/asm/kgdb.h:41:\n +#define ___to_string(X) #X\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReported-by: Vincent Stehlé \u003cv-stehle@ti.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "be987d9f80354e2e919926349282facd74992f90", "tree": "218d560f3eb8f04701729f6f0dd9cd538df146e8", "parents": [ "adf96e6f514a9e87aa3d26c8c9c03eca5be53df0" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Wed Feb 27 17:02:38 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Feb 27 19:10:08 2013 -0800" }, "message": "checkpatch: improve CamelCase test for Page\n\nAdd the ClearPage/SetPage/TestClearPage/TestSetPage variants to the not\nreported Page CamelCase variables.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "37581c28e9e77f44a3124ebab99b98643bda1aa2", "tree": "3430f2a52b74f201cb20789cf9387d2cd3295a8c", "parents": [ "5ce59ae0bcc0f0ad249d21560c9bb5f6061e62a8" ], "author": { "name": "Bruce Allan", "email": "bruce.w.allan@intel.com", "time": "Thu Feb 21 16:44:19 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Feb 21 17:22:26 2013 -0800" }, "message": "checkpatch: fix USLEEP_RANGE test\n\nDo not test udelay() for a value less than 10usec when passed a variable\ninstead of a hard-coded number; there is no way for checkpatch to know the\nvalue of the variable. As it is today, it will complain about variables\nwith alphanumeric characters plus \u0027_\u0027, e.g. foo_bar, but not variables\nwith other characters, eg. foo-\u003ebar.\n\nSigned-off-by: Bruce Allan \u003cbruce.w.allan@intel.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5ce59ae0bcc0f0ad249d21560c9bb5f6061e62a8", "tree": "1fa6ddc462a2425d6d8d50136330c2db0b6becee", "parents": [ "e8eb3997ce2f5887472a674b32f295b0196ecf46" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Feb 21 16:44:18 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Feb 21 17:22:26 2013 -0800" }, "message": "checkpatch: Add check for kcalloc argument order\n\nkcalloc is sometimes misused with the first and second arguments switched.\n\nSame issue with kmalloc_array too.\n\nBleat if sizeof is the first argument\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e8eb3997ce2f5887472a674b32f295b0196ecf46", "tree": "85cec0f6a05582bf6e255b4492026d863cc59fc3", "parents": [ "10d83f07103f3af0d7e8d73d8d5ffa76e900fd04" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Feb 21 16:44:17 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Feb 21 17:22:26 2013 -0800" }, "message": "checkpatch: don\u0027t emit the CamelCase warning for PageFoo\n\nI\u0027m getting a ton of these:\n\n WARNING: Avoid CamelCase: \u003cPageTransHuge\u003e\n #140: FILE: mm/migrate.c:1576:\n + if (PageTransHuge(page) \u0026\u0026 page_count(page) !\u003d 3) {\n\nSo exclude anything which starts with \"Page\".\n\nTested-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "56e77d709df72eefe50ce97a701bd2d5614d0009", "tree": "6aaed6701b4dc7db919dd345afb9181466fbd277", "parents": [ "dc1393130b026908c54d4538abbb5c2badbfabbe" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Feb 21 16:44:14 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Feb 21 17:22:26 2013 -0800" }, "message": "checkpatch: warn on unnecessary __dev\u003cfoo\u003e section markings\n\nGet people to stop adding __devinit and __devexit section markings.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Greg KH \u003cgreg@kroah.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "dc1393130b026908c54d4538abbb5c2badbfabbe", "tree": "4185d47c7dcf7d2a5c4922fe759e0a203ffb484a", "parents": [ "5dc49c75a26b99e86a18441e0b64c1f7c7c6a500" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Feb 21 16:44:13 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Feb 21 17:22:26 2013 -0800" }, "message": "checkpatch: prefer dev_\u003clevel\u003e( to dev_printk(KERN_\u003cLEVEL\u003e\n\nAdd YA check to printk style.\n\ndev_\u003clevel\u003e uses are functions and generate smaller\nobject code than dev_printk(KERN_\u003cLEVEL\u003e.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "326b1ffc136d944d403a2b44dc3abace2a4e10fd", "tree": "8cc25f335929cce2fc6ba48257e52784eea63fb6", "parents": [ "91c777d86752b00bb3a1d8efa3d8f7e1264f38a9" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Feb 04 14:28:51 2013 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Feb 05 20:38:48 2013 +1100" }, "message": "checkpatch: fix $Float creation of match variables\n\nCommit 74349bccedb3 (\"checkpatch: add support for floating point\nconstants\") added an unnecessary match variable that caused tests that\nused a $Constant or $LvalOrFunc to have one too many matches.\n\nThis causes problems with usleep_range, min/max and other extended\ntests.\n\nAvoid using match variables in $Float.\nAvoid using match variables in $Assignment too.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "495e9d84607cda966ba6d223d5eb9df0070cd21a", "tree": "208667895c3646fe4fa1bb7322d0ed1f51880ca5", "parents": [ "5abe257af8b95857b95fa0ba694530b446ae32d8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Dec 20 15:05:37 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Dec 20 17:40:20 2012 -0800" }, "message": "checkpatch: warn on uapi #includes that #include \u003cuapi/...\n\nAvoid specifying internal uapi #include paths with uapi/... as\nuserspace should not use and never see that.\n\nNeaten message line wrapping above.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: David Howells \u003cdhowells@redhat.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "323c1260ba2c4b5c4b2a1e9ab6657cde54ccf554", "tree": "fcc114327e37918e20e42a2f4ed00e3b7f158cec", "parents": [ "74349bccedb3e34b4f1fd9c7efd2dda7905e3335" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:07 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: warn on CamelCase variable names\n\nStore the camelcase variables in a hash and only emit a warning on the\nfirst use of each new variable.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "74349bccedb3e34b4f1fd9c7efd2dda7905e3335", "tree": "7dec12471c55dbaa90c78ab67ea3e23788565cba", "parents": [ "6b7eaf6e1428be33f731287de963862e3846cd42" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:05 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: add support for floating point constants\n\nEven though the kernel doesn\u0027t support using floating point constants,\nadd a regex for them.\n\nSupport forms like: 0x123p1, 123e-1, 1.23, 1.5e23f\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6b7eaf6e1428be33f731287de963862e3846cd42", "tree": "19628f1233f2e758cbd138d1c7a2d41701244b32", "parents": [ "d1e2ad07e78c4bbac9fce4d2e3c0fe60bce091d8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:02 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: find hex constants as a single IDENT\n\nHexadecimal values are current found in 2 parts. A hex constant like\n0x123456abcdef is found as 0 and then x123456abcdef and later coalesced.\n\nInstead, reverse the order of the 2 searches in $Constant to find 0x\nfirst, then 0 so that the entire hex constant is found all at once.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d1e2ad07e78c4bbac9fce4d2e3c0fe60bce091d8", "tree": "41193684d79788aef5d00c817ba570c27c7de02f", "parents": [ "88982fea52d0115d44b77619afef576f24cdb844" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:01 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: add --strict test for switch/default missing break\n\nswitch default case is sometimes written as \"default:;\". This can cause\nnew cases added below the default to be defective.\n\nSuggest adding a break; after empty default cases to avoid fallthrough\ndefects.\n\nFixed indentation in the other semicolon test above it.\n\nSuggested-by: Peter Senna Tschudin \u003cpeter.senna@gmail.com\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "88982fea52d0115d44b77619afef576f24cdb844", "tree": "a31942d9f3ec40c520b6c963e726c705e47b7db3", "parents": [ "0979ae66464bd9793c6701861bccb21f9f118a52" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:02:00 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: warn when declaring \"struct spinlock foo;\"\n\nspinlock_t should always be used.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: \"Luis R. Rodriguez\" \u003cmcgrof@do-not-panic.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0979ae66464bd9793c6701861bccb21f9f118a52", "tree": "e2e7a6f513aba1c433dbad1ccbb24adb834ca406", "parents": [ "481eb486a88c9b068f0168ac4c21291802720933" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:59 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: Add --strict messages for blank lines around braces\n\nBlank lines around braces are not unnecessary. Emit a message on the use\nof these blank lines only when using --strict.\n\nint foo(int bar)\n{\n\n\tsomething or other....\n\n}\n\nis generally written in the kernel as:\n\nint foo(int bar)\n{\n\tsomething or other...\n}\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "481eb486a88c9b068f0168ac4c21291802720933", "tree": "ded9373e9ace9887f28c8bf3ea1810c600a6b059", "parents": [ "6cd7f3869c925622bbf420e1107a026d91dbd7f2" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:56 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: extend line continuation test\n\nPreprocessor directives and asm statements should be allowed to have a\nline continuation.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nTested-by: Jingoo Han \u003cjg1.han@samsung.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6cd7f3869c925622bbf420e1107a026d91dbd7f2", "tree": "23c356d279579726f68ddfdebe54d4e469e25572", "parents": [ "03df4b51f33e1fdd35fe7bc19f1f450726395207" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:54 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: allow control over line length warning, default remains 80\n\nSome projects might want a longer line length so allow a command line\n--max-line-length\u003dn control over the long line warnings. The default line\nlength is 80.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Constantine Shulyupin \u003cconst@makelinux.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "03df4b51f33e1fdd35fe7bc19f1f450726395207", "tree": "13994b0b62313a4e0f93c1f6c349b01c53ea958e", "parents": [ "78e3f1f01d23c1a0d5828669d35afa2e7951987d" ], "author": { "name": "Andy Whitcroft", "email": "apw@canonical.com", "time": "Mon Dec 17 16:01:52 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: consolidate if (foo) bar(foo) checks and add debugfs_remove\n\nConsolidate the if (foo) bar(foo) detectors into a single check. Add\ndebugfs_remove and family.\n\nBased on a patch by Constantine Shulyupin.\n\nSigned-off-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Constantine Shulyupin \u003cconst@MakeLinux.com\u003e.\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "78e3f1f01d23c1a0d5828669d35afa2e7951987d", "tree": "60221a5006aaec5e0a810facb8a223b910f92175", "parents": [ "1ba8dfd17ead04de18bfca7b68c2a144c8be736a" ], "author": { "name": "Tao Ma", "email": "boyu.mt@taobao.com", "time": "Mon Dec 17 16:01:49 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:19 2012 -0800" }, "message": "checkpatch: remove reference to feature-removal-schedule.txt\n\nIn commit 9c0ece069b32 (\"Get rid of Documentation/feature-removal.txt\"),\nLinus removes feature-removal-schedule.txt from Documentation, but there\nis still some reference to this file. So remove them.\n\nSigned-off-by: Tao Ma \u003cboyu.mt@taobao.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1ba8dfd17ead04de18bfca7b68c2a144c8be736a", "tree": "d9f42871b6809cd40e03557bc243a11d6039dd20", "parents": [ "5023d3472d444747bfa12e9798d7993e7efb8287" ], "author": { "name": "Kees Cook", "email": "keescook@chromium.org", "time": "Mon Dec 17 16:01:48 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:18 2012 -0800" }, "message": "checkpatch: warn about using CONFIG_EXPERIMENTAL\n\nThis config item has not carried much meaning for a while now and is\nalmost always enabled by default. As agreed during the Linux kernel\nsummit, it is being removed. This will discourage future addition of\nCONFIG_EXPERIMENTAL while it is being phased out.\n\nSigned-off-by: Kees Cook \u003ckeescook@chromium.org\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "5023d3472d444747bfa12e9798d7993e7efb8287", "tree": "384454623fc76da468021e0d58846debec536014", "parents": [ "0ad50c3896afbb3c103409a18260e601b87a744c" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Dec 17 16:01:47 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Dec 17 17:15:18 2012 -0800" }, "message": "checkpatch: warn on unnecessary line continuations\n\nWhen the previous line is not a line continuation and the current line has\na line continuation but is not a #define, emit a warning.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Peter Hurley \u003cpeter@hurleysoftware.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c24f9f195edf8c7f78eff1081cdadd26bd272ee3", "tree": "27063fcac4f5fd20054b3ca45fe15d6c39762876", "parents": [ "3d70f8c617a436c7146ecb81df2265b4626dfe89" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Nov 08 15:53:29 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Nov 09 06:41:46 2012 +0100" }, "message": "checkpatch: improve network block comment style checking\n\nSome comment styles in net and drivers/net are flagged inappropriately.\n\nAvoid proclaiming inline comments like:\n\tint a \u003d b;\t/* some comment */\nand block comments like:\n\t/*********************\n\t * some comment\n\t ********************/\nare defective.\n\nTested with\n$ cat drivers/net/t.c\n/* foo */\n\n/*\n * foo\n */\n\n/* foo\n */\n\n/* foo\n * bar */\n\n/****************************\n * some long block comment\n ***************************/\n\nstruct foo {\n\tint bar;\t/* another test */\n};\n$\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nReported-by: Larry Finger \u003cLarry.Finger@lwfinger.net\u003e\nCc: David Miller \u003cdavem@davemloft.net\u003e\nCc: Stephen Hemminger \u003cshemminger@vyatta.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a0a0a7a94c765f7219b57fa3b79389901bb0bc99", "tree": "8830687bde899b15cf1764aee396a15c8dee8fb9", "parents": [ "c4ff1b5f8bf09d77d7329cbff224f0237646c90e" ], "author": { "name": "Kees Cook", "email": "keescook@chromium.org", "time": "Thu Oct 04 17:13:38 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:05:00 2012 +0900" }, "message": "checkpatch: fix name of \"MODULE_PARM_DESC\"\n\nFix macro name in checkpatch: s/PARAM/PARM/.\n\nSigned-off-by: Kees Cook \u003ckeescook@chromium.org\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "058806007450489bb8f457b275e5cb5c946320c1", "tree": "7c99dc9728618bec0eccd7578ad493ff312e7dc1", "parents": [ "8f26b8376faad26372a579606ecbd77b20e99dd8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Oct 04 17:13:35 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:04:59 2012 +0900" }, "message": "checkpatch: check networking specific block comment style\n\nIn an effort to get fewer checkpatch reviewer corrections, add a\nnetworking specific style test for the preferred networking comment style.\n\n\t/* The preferred style for block comments in\n\t * drivers/net/... and net/... is like this\n\t */\n\nThese tests are only used in net/ and drivers/net/\n\nTested with:\n\n$ cat drivers/net/t.c\n\n/* foo */\n\n/*\n * foo\n */\n\n/* foo\n */\n\n/* foo\n * bar */\n$ ./scripts/checkpatch.pl -f drivers/net/t.c\nWARNING: networking block comments don\u0027t use an empty /* line, use /* Comment...\n#4: FILE: net/t.c:4:\n+\n+/*\n\nWARNING: networking block comments put the trailing */ on a separate line\n#12: FILE: net/t.c:12:\n+ * bar */\n\ntotal: 0 errors, 2 warnings, 12 lines checked\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: \"Allan, Bruce W\" \u003cbruce.w.allan@intel.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: David Miller \u003cdavem@davemloft.net\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "8f26b8376faad26372a579606ecbd77b20e99dd8", "tree": "50fc1463508ac9fd91a0b437284d84a81918f903", "parents": [ "fa64205df9dfd7b7662cc64a7e82115c00e428e5" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu Oct 04 17:13:32 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:04:59 2012 +0900" }, "message": "checkpatch: update suggested printk conversions\n\nDirect conversion of printk(KERN_\u003cLEVEL\u003e... to pr_\u003clevel\u003e isn\u0027t the\npreferred conversion when a struct net_device or struct device is\navailable.\n\nHint that using netdev_\u003clevel\u003e or dev_\u003clevel\u003e is preferred to using\npr_\u003clevel\u003e. Add netdev_dbg and dev_dbg variants too.\n\nMiscellaneous whitespace neatening of a misplaced close brace.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Greg KH \u003cgregkh@linuxfoundation.org\u003e\nCc: Dan Carpenter \u003cdan.carpenter@oracle.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fa64205df9dfd7b7662cc64a7e82115c00e428e5", "tree": "4df37058666c34ed88a3d7c0ffae2330b8b7eddf", "parents": [ "8290e2d2dcbf0d379d4b1379e17916515ee20a39" ], "author": { "name": "Pasi Savanainen", "email": "pasi.savanainen@nixu.com", "time": "Thu Oct 04 17:13:29 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sat Oct 06 03:04:59 2012 +0900" }, "message": "checkpatch: check utf-8 content from a commit log when it\u0027s missing from charset\n\nCheck that a commit log doesn\u0027t contain UTF-8 when a mail header\nexplicitly defines a different charset, like\n\n\u0027Content-Type: text/plain; charset\u003d\"us-ascii\"\u0027\n\nSigned-off-by: Pasi Savanainen \u003cpasi.savanainen@nixu.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ac8e97f8a742828daa1d9de37f6e635888f8d71e", "tree": "d2eae9170d79c302d99c0d7a27da134060fde69e", "parents": [ "eb48c071464757414538c68a6033c8f8c15196f8" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Tue Aug 21 16:15:53 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Aug 21 16:45:02 2012 -0700" }, "message": "checkpatch: add control statement test to SINGLE_STATEMENT_DO_WHILE_MACRO\n\nCommit b13edf7ff2dd (\"checkpatch: add checks for do {} while (0) macro\nmisuses\") added a test that is overly simplistic for single statement\nmacros.\n\nMacros that start with control tests should be enclosed in a do {} while\n(0) loop.\n\nAdd the necessary control tests to the check.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nAcked-by: Andy Whitcroft \u003capw@canonical.com\u003e\nTested-by: Franz Schrober \u003cfranzschrober@yahoo.de\u003e\nCc: Stephen Rothwell \u003csfr@canb.auug.org.au\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b13edf7ff2dd0fef95e981170fa71fa6b60421b0", "tree": "cdfbfb5429b089d1e41f9551bf112a8236fae078", "parents": [ "66c80b6077256898df948ac6acf547b47ddb1fcf" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:24 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: add checks for do {} while (0) macro misuses\n\nThese types of macros should not be used for either a single statement\nnor should the macro end with a semi-colon.\n\nAdd tests for these conditions.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "66c80b6077256898df948ac6acf547b47ddb1fcf", "tree": "20982260f1fd1e875188b24ddd598e77544e5354", "parents": [ "4a273195a551a27a9a3ebed072c8df16c853da7f" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:22 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: Add acheck for use of sizeof without parenthesis\n\nKernel style uses parenthesis around sizeof.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4a273195a551a27a9a3ebed072c8df16c853da7f", "tree": "f6dd0354f66679adea5cab8aab0a620a6832e181", "parents": [ "ce0338df3c9a43e709b8a478265b32b9edcc7ccc" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:20 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: check usleep_range() arguments\n\nusleep_range() shouldn\u0027t use the same args for min and max.\n\nReport it when it happens and when both args are decimal and min \u003e max.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Yuval Mintz \u003cyuvalmin@broadcom.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ce0338df3c9a43e709b8a478265b32b9edcc7ccc", "tree": "7f6c7047b4e1215f11ce2f774091237c7b5fdeb8", "parents": [ "b34a26f3158cca932b6f1427b97fe12c7838ee68" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:18 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: test for non-standard signatures\n\nWarn on non-standard signature styles.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "b34a26f3158cca932b6f1427b97fe12c7838ee68", "tree": "e1c5e08259b56d444f6797c8e3e7b88cd4df64d5", "parents": [ "4ed940d4c34c21a1a356969a923f2815d608e0bf" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Jul 30 14:41:16 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jul 30 17:25:17 2012 -0700" }, "message": "checkpatch: Update alignment check\n\nParenthesis alignment doesn\u0027t correctly check an existing line after an\ninserted or modified line with an open parenthesis.\n\nFix it.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "243f3803cf2a3665092c5fd6f924f453694681a6", "tree": "a05005eb618c2770a2e56c644ae04d8e36c58c89", "parents": [ "9a4cad4e25b91f48494f13fce3d25ea44bec7472" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Thu May 31 16:26:09 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu May 31 17:49:27 2012 -0700" }, "message": "checkpatch: suggest pr_\u003clevel\u003e over printk(KERN_\u003cLEVEL\u003e\n\nSuggest the shorter pr_\u003clevel\u003e instead of printk(KERN_\u003cLEVEL\u003e.\n\nPrefer to use pr_\u003clevel\u003e over bare printks.\nPrefer to use pr_warn over pr_warning.\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nCc: Andy Whitcroft \u003capw@shadowen.org\u003e\nCc: Theodore Ts\u0027o \u003ctytso@mit.edu\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9a4cad4e25b91f48494f13fce3d25ea44bec7472", "tree": "6b7cbfdf1517792f826f23408b8ca023ee2b3229", "parents": [ "133fd9f5cda2d86904126f4b9fa4e8f4330c9569" ], "author": { "name": "Eric Nelson", "email": "eric.nelson@boundarydevices.com", "time": "Thu May 31 16:26:09 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu May 31 17:49:27 2012 -0700" }, "message": "checkpatch: check for whitespace before semicolon at EOL\n\nRequires --strict option during invocation:\n\t~/linux$ scripts/checkpatch --strict foo.patch\n\nThis tests for a bad habits of mine like this:\n\n\treturn 0 ;\n\nNote that it does allow a special case of a bare semicolon\nfor empty loops:\n\n\twhile (foo())\n\t\t;\n\nSigned-off-by: Eric Nelson \u003ceric.nelson@boundarydevices.com\u003e\nCc: Andy Whitcroft \u003capw@canonical.com\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "c06a9ebdb7a4f4823d4225fe789d8c20a1d534eb", "tree": "9909d3aac2349fd6636fd1fdd0d4480869978b5b", "parents": [ "e816b57a337ea3b755de72bec38c10c864f23015" ], "author": { "name": "Joe Perches", "email": "joe@perches.com", "time": "Mon Apr 16 13:35:11 2012 -0600" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 16 12:44:38 2012 -0700" }, "message": "checkpatch: revert --strict test for net/ and drivers/net block comment style\n\nRevert the --strict test for the old preferred block\ncomment style in drivers/net and net/\n\nReported-by: Ingo Molnar \u003cmingo@kernel.org\u003e\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" } ], "next": "ca56dc098caf93b5437cd6c4ee49f02aa18f84d6" }