)]}' { "log": [ { "commit": "a637120e49021d197e9578cba545bbaa459cbb51", "tree": "0d502a8fcc55c89eb4d79a7578e46a9273d1f2c8", "parents": [ "496fb7806d616185a46865a4f3a20ef19dc6c7e3" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Apr 19 16:29:24 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:40 2012 +0200" }, "message": "blkcg: use radix tree to index blkgs from blkcg\n\nblkg lookup is currently performed by traversing linked list anchored\nat blkcg-\u003eblkg_list. This is very unscalable and with blk-throttle\nenabled and enough request queues on the system, this can get very\nugly quickly (blk-throttle performs look up on every bio submission).\n\nThis patch makes blkcg use radix tree to index blkgs combined with\nsimple last-looked-up hint. This is mostly identical to how icqs are\nindexed from ioc.\n\nNote that because __blkg_lookup() may be invoked without holding queue\nlock, hint is only updated from __blkg_lookup_create(). Due to cfq\u0027s\ncfqq caching, this makes hint updates overly lazy. This will be\nimproved with scheduled blkcg aware request allocation.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "496fb7806d616185a46865a4f3a20ef19dc6c7e3", "tree": "a200e6825be55f6d0ed411ec32dc16244f488fd9", "parents": [ "aaf7c680682f1999ef2e574f743c45d1674a8b8a" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Apr 19 16:29:23 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:40 2012 +0200" }, "message": "blkcg: fix blkcg-\u003ecss ref leak in __blkg_lookup_create()\n\n__blkg_lookup_create() leaked blkcg-\u003ecss ref if blkg allocation\nfailed. Fix it.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "f9fcc2d3919b8eb575b3cee9274feefafb641bca", "tree": "bb3eaeb993b21ba352c0967488a6955a40314d97", "parents": [ "f95a04afa80c0f4ddd645ef6a84ed118b5d1ad46" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Apr 16 13:57:27 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:17 2012 +0200" }, "message": "blkcg: collapse blkcg_policy_ops into blkcg_policy\n\nThere\u0027s no reason to keep blkcg_policy_ops separate. Collapse it into\nblkcg_policy.\n\nThis patch doesn\u0027t introduce any functional change.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "f95a04afa80c0f4ddd645ef6a84ed118b5d1ad46", "tree": "2428dacf9bab1eb643628c872aed3092704f7fb2", "parents": [ "3c798398e393e5f9502dbab2b51e6c25e2e8f2ac" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Apr 16 13:57:26 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:17 2012 +0200" }, "message": "blkcg: embed struct blkg_policy_data in policy specific data\n\nCurrently blkg_policy_data carries policy specific data as char flex\narray instead of being embedded in policy specific data. This was\nforced by oddities around blkg allocation which are all gone now.\n\nThis patch makes blkg_policy_data embedded in policy specific data -\nthrotl_grp and cfq_group so that it\u0027s more conventional and consistent\nwith how io_cq is handled.\n\n* blkcg_policy-\u003epdata_size is renamed to -\u003epd_size.\n\n* Functions which used to take void *pdata now takes struct\n blkg_policy_data *pd.\n\n* blkg_to_pdata/pdata_to_blkg() updated to blkg_to_pd/pd_to_blkg().\n\n* Dummy struct blkg_policy_data definition added. Dummy\n pdata_to_blkg() definition was unused and inconsistent with the\n non-dummy version - correct dummy pd_to_blkg() added.\n\n* throtl and cfq updated accordingly.\n\n* As dummy blkg_to_pd/pd_to_blkg() are provided,\n blkg_to_cfqg/cfqg_to_blkg() don\u0027t need to be ifdef\u0027d. Moved outside\n ifdef block.\n\nThis patch doesn\u0027t introduce any functional change.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "3c798398e393e5f9502dbab2b51e6c25e2e8f2ac", "tree": "d6f638e6a25dec4887e64bcc35b98bc394cb974f", "parents": [ "36558c8a30e121f97b5852ae33e28081af21bdbf" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Apr 16 13:57:25 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:17 2012 +0200" }, "message": "blkcg: mass rename of blkcg API\n\nDuring the recent blkcg cleanup, most of blkcg API has changed to such\nextent that mass renaming wouldn\u0027t cause any noticeable pain. Take\nthe chance and cleanup the naming.\n\n* Rename blkio_cgroup to blkcg.\n\n* Drop blkio / blkiocg prefixes and consistently use blkcg.\n\n* Rename blkio_group to blkcg_gq, which is consistent with io_cq but\n keep the blkg prefix / variable name.\n\n* Rename policy method type and field names to signify they\u0027re dealing\n with policy data.\n\n* Rename blkio_policy_type to blkcg_policy.\n\nThis patch doesn\u0027t cause any functional change.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "54e7ed12bad1e3aa2a28558fab6850240465f973", "tree": "907eb0451782f4eb1ad3f9236e51ec4acb7fb941", "parents": [ "c94bed89995e638e43a6663177358b9d20617361" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Apr 16 13:57:23 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:16 2012 +0200" }, "message": "blkcg: remove blkio_group-\u003epath[]\n\nblkio_group-\u003epath[] stores the path of the associated cgroup and is\nused only for debug messages. Just format the path from blkg-\u003ecgroup\nwhen printing debug messages.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "6d18b008daf46bcd82b8ae250aae0785f9714096", "tree": "e70e66ce74220d5a0c7382acd20efbd4835c8f77", "parents": [ "3c96cb32d318f323c1bf972a4c66821f8499e34d" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Apr 13 13:11:35 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:06 2012 +0200" }, "message": "blkcg: shoot down blkgs if all policies are deactivated\n\nThere\u0027s no reason to keep blkgs around if no policy is activated for\nthe queue. This patch moves queue locking out of blkg_destroy_all()\nand call it from blkg_deactivate_policy() on deactivation of the last\npolicy on the queue.\n\nThis change was suggested by Vivek.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "3c96cb32d318f323c1bf972a4c66821f8499e34d", "tree": "e76d0437f487405d8a22a727b8085696b949179d", "parents": [ "a2b1693bac45ea3fe3ba612fd22c45f17449f610" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Apr 13 13:11:34 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:06 2012 +0200" }, "message": "blkcg: drop stuff unused after per-queue policy activation update\n\n* All_q_list is unused. Drop all_q_{mutex|list}.\n\n* @for_root of blkg_lookup_create() is always %false when called from\n outside blk-cgroup.c proper. Factor out __blkg_lookup_create() so\n that it doesn\u0027t check whether @q is bypassing and use the\n underscored version for the @for_root callsite.\n\n* blkg_destroy_all() is used only from blkcg proper and @destroy_root\n is always %true. Make it static and drop @destroy_root.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "a2b1693bac45ea3fe3ba612fd22c45f17449f610", "tree": "2e05859caab6453efbc85d584dd72dca7ef03cd0", "parents": [ "03d8e11142a893ad322285d3c8a08e88b570cda1" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Apr 13 13:11:33 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:06 2012 +0200" }, "message": "blkcg: implement per-queue policy activation\n\nAll blkcg policies were assumed to be enabled on all request_queues.\nDue to various implementation obstacles, during the recent blkcg core\nupdates, this was temporarily implemented as shooting down all !root\nblkgs on elevator switch and policy [de]registration combined with\nhalf-broken in-place root blkg updates. In addition to being buggy\nand racy, this meant losing all blkcg configurations across those\nevents.\n\nNow that blkcg is cleaned up enough, this patch replaces the temporary\nimplementation with proper per-queue policy activation. Each blkcg\npolicy should call the new blkcg_[de]activate_policy() to enable and\ndisable the policy on a specific queue. blkcg_activate_policy()\nallocates and installs policy data for the policy for all existing\nblkgs. blkcg_deactivate_policy() does the reverse. If a policy is\nnot enabled for a given queue, blkg printing / config functions skip\nthe respective blkg for the queue.\n\nblkcg_activate_policy() also takes care of root blkg creation, and\ncfq_init_queue() and blk_throtl_init() are updated accordingly.\n\nThis replaces blkcg_bypass_{start|end}() and update_root_blkg_pd()\nunnecessary. Dropped.\n\nv2: cfq_init_queue() was returning uninitialized @ret on root_group\n alloc failure if !CONFIG_CFQ_GROUP_IOSCHED. Fixed.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "80fd99792b0b9f162abdf3da12fb10eb9eb5f321", "tree": "3273581c76d9bcad18f0668f6707be9323e650fb", "parents": [ "da8b066262e12d1d0a3b1e6d3486e500169bf730" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Apr 13 14:50:53 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:06 2012 +0200" }, "message": "blkcg: make sure blkg_lookup() returns %NULL if @q is bypassing\n\nCurrently, blkg_lookup() doesn\u0027t check @q bypass state. This patch\nupdates blk_queue_bypass_start() to do synchronize_rcu() before\nreturning and updates blkg_lookup() to check blk_queue_bypass() and\nreturn %NULL if bypassing. This ensures blkg_lookup() returns %NULL\nif @q is bypassing.\n\nThis is to guarantee that nobody is accessing policy data while @q is\nbypassing, which is necessary to allow replacing blkio_cgroup-\u003epd[] in\nplace on policy [de]activation.\n\nv2: Added more comments explaining bypass guarantees as suggested by\n Vivek.\n\nv3: Added more comments explaining why there\u0027s no synchronize_rcu() in\n blk_cleanup_queue() as suggested by Vivek.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "da8b066262e12d1d0a3b1e6d3486e500169bf730", "tree": "048eee7101b526017bbd295366bf2e95dd65e5a7", "parents": [ "8bd435b30ecacb69bbb8b2d3e251f770b807c5b2" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Apr 13 13:11:29 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:06 2012 +0200" }, "message": "blkcg: make blkg_conf_prep() take @pol and return with queue lock held\n\nAdd @pol to blkg_conf_prep() and let it return with queue lock held\n(to be released by blkg_conf_finish()). Note that @pol isn\u0027t used\nyet.\n\nThis is to prepare for per-queue policy activation and doesn\u0027t cause\nany visible difference.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "8bd435b30ecacb69bbb8b2d3e251f770b807c5b2", "tree": "a1a50e95517a54a578af3967fb4016a5a1a42a68", "parents": [ "ec399347d39fb2337ebace928cf4a2855bd0ec37" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Apr 13 13:11:28 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:06 2012 +0200" }, "message": "blkcg: remove static policy ID enums\n\nRemove BLKIO_POLICY_* enums and let blkio_policy_register() allocate\n@pol-\u003eplid dynamically on registration. The maximum number of blkcg\npolicies which can be registered at the same time is defined by\nBLKCG_MAX_POLS constant added to include/linux/blkdev.h.\n\nNote that blkio_policy_register() now may fail. Policy init functions\nupdated accordingly and unnecessary ifdefs removed from cfq_init().\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "ec399347d39fb2337ebace928cf4a2855bd0ec37", "tree": "d95efeb004e8da914f7d3c726cd059b422443694", "parents": [ "bc0d6501a844392ab6ad419d7ca5af4693b6afac" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Apr 13 13:11:27 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:06 2012 +0200" }, "message": "blkcg: use @pol instead of @plid in update_root_blkg_pd() and blkcg_print_blkgs()\n\nThe two functions were taking \"enum blkio_policy_id plid\". Make them\ntake \"const struct blkio_policy_type *pol\" instead.\n\nThis is to prepare for per-queue policy activation and doesn\u0027t cause\nany functional difference.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "bc0d6501a844392ab6ad419d7ca5af4693b6afac", "tree": "08375aff242a2efd35d830c7636ab61a3ec6a109", "parents": [ "f48ec1d7885281a9c6cd7779d61f321d1b1fd741" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Fri Apr 13 13:11:26 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Fri Apr 20 10:06:06 2012 +0200" }, "message": "blkcg: kill blkio_list and replace blkio_list_lock with a mutex\n\nWith blkio_policy[], blkio_list is redundant and hinders with\nper-queue policy activation. Remove it. Also, replace\nblkio_list_lock with a mutex blkcg_pol_mutex and let it protect the\nwhole [un]registration.\n\nThis is to prepare for per-queue policy activation and doesn\u0027t cause\nany functional difference.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "5bc4afb1ec6aa562fac4d9aba34d957ee42f5813", "tree": "dfef1de2dcb71beab3150ffecf6ae564d326ffba", "parents": [ "d366e7ec41882791c970dfb7c67b737be8c3a174" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:45 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:45 2012 -0700" }, "message": "blkcg: drop BLKCG_STAT_{PRIV|POL|OFF} macros\n\nNow that all stat handling code lives in policy implementations,\nthere\u0027s no need to encode policy ID in cft-\u003eprivate.\n\n* Export blkcg_prfill_[rw]stat() from blkcg, remove\n blkcg_print_[rw]stat(), and implement cfqg_print_[rw]stat() which\n use hard-code BLKIO_POLICY_PROP.\n\n* Use cft-\u003eprivate for offset of the target field directly and drop\n BLKCG_STAT_{PRIV|POL|OFF}().\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "d366e7ec41882791c970dfb7c67b737be8c3a174", "tree": "78d3c73d90276b797e1553c004272af869a30075", "parents": [ "af133ceb261033eb43c03d161a991c3b772e8c56" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "message": "blkcg: pass around pd-\u003epdata instead of pd itself in prfill functions\n\nNow that all conf and stat fields are moved into policy specific\nblkio_policy_data-\u003epdata areas, there\u0027s no reason to use\nblkio_policy_data itself in prfill functions. Pass around @pd-\u003epdata\ninstead of @pd.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "3381cb8d2ef1523dbaeec99161d766c25f1e52d6", "tree": "b5592ee2a0f84e694282c947611971eb7735622d", "parents": [ "8a3d26151f24e2a2ffa550890144c3d54d2edb15" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "message": "blkcg: move blkio_group_conf-\u003eweight to cfq\n\nblkio_group_conf-\u003eweight is owned by cfq and has no reason to be\ndefined in blkcg core. Replace it with cfq_group-\u003edev_weight and let\nconf setting functions directly set it. If dev_weight is zero, the\ncfqg doesn\u0027t have device specific weight configured.\n\nAlso, rename BLKIO_WEIGHT_* constants to CFQ_WEIGHT_* and rename\nblkio_cgroup-\u003eweight to blkio_cgroup-\u003ecfq_weight. We eventually want\nper-policy storage in blkio_cgroup but just mark the ownership of the\nfield for now.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "8a3d26151f24e2a2ffa550890144c3d54d2edb15", "tree": "b99f5cf8db0abc02e39e5c5107f8d4342f81effa", "parents": [ "155fead9b6347ead90e0b0396cb108a6ba6126c6" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "message": "blkcg: move blkio_group_stats_cpu and friends to blk-throttle.c\n\nblkio_group_stats_cpu is used only by blk-throtl and has no reason to\nbe defined in blkcg core.\n\n* Move blkio_group_stats_cpu to blk-throttle.c and rename it to\n tg_stats_cpu.\n\n* blkg_policy_data-\u003estats_cpu is replaced with throtl_grp-\u003estats_cpu.\n prfill functions updated accordingly.\n\n* All related macros / functions are renamed so that they have tg_\n prefix and the unnecessary @pol arguments are dropped.\n\n* Per-cpu stats allocation code is also moved from blk-cgroup.c to\n blk-throttle.c and gets simplified to only deal with\n BLKIO_POLICY_THROTL. percpu stat free is performed by the exit\n method throtl_exit_blkio_group().\n\n* throtl_reset_group_stats() implemented for\n blkio_reset_group_stats_fn method so that tg-\u003estats_cpu can be\n reset.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "155fead9b6347ead90e0b0396cb108a6ba6126c6", "tree": "7e14bb87d942561aa5f44ac8a2d09d6e546c6ccb", "parents": [ "9ade5ea4ce57d3596eaee6a57cd212a483674058" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "message": "blkcg: move blkio_group_stats to cfq-iosched.c\n\nblkio_group_stats contains only fields used by cfq and has no reason\nto be defined in blkcg core.\n\n* Move blkio_group_stats to cfq-iosched.c and rename it to cfqg_stats.\n\n* blkg_policy_data-\u003estats is replaced with cfq_group-\u003estats.\n blkg_prfill_[rw]stat() are updated to use offset against pd-\u003epdata\n instead.\n\n* All related macros / functions are renamed so that they have cfqg_\n prefix and the unnecessary @pol arguments are dropped.\n\n* All stat functions now take cfq_group * instead of blkio_group *.\n\n* lockdep assertion on queue lock dropped. Elevator runs under queue\n lock by default. There isn\u0027t much to be gained by adding lockdep\n assertions at stat function level.\n\n* cfqg_stats_reset() implemented for blkio_reset_group_stats_fn method\n so that cfqg-\u003estats can be reset.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "9ade5ea4ce57d3596eaee6a57cd212a483674058", "tree": "cad2cc4ecb116f114cc73098b1704a47d82edd18", "parents": [ "41b38b6d540f951c49315d8573e6f6195a6e736d" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "message": "blkcg: add blkio_policy_ops operations for exit and stat reset\n\nAdd blkio_policy_ops-\u003eblkio_exit_group_fn() and\n-\u003eblkio_reset_group_stats_fn(). These will be used to further\nmodularize blkcg policy implementation.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "41b38b6d540f951c49315d8573e6f6195a6e736d", "tree": "e667cec0bba6e7678810ff0087c96547a21a45c7", "parents": [ "629ed0b10209ffc4e1d439e5508d52d5e3a090b8" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "message": "blkcg: cfq doesn\u0027t need per-cpu dispatch stats\n\nblkio_group_stats_cpu is used to count dispatch stats using per-cpu\ncounters. This is used by both blk-throtl and cfq-iosched but the\nsharing is rather silly.\n\n* cfq-iosched doesn\u0027t need per-cpu dispatch stats. cfq always updates\n those stats while holding queue_lock.\n\n* blk-throtl needs per-cpu dispatch stats but only service_bytes and\n serviced. It doesn\u0027t make use of sectors.\n\nThis patch makes cfq add and use global stats for service_bytes,\nserviced and sectors, removes per-cpu sectors counter and moves\nper-cpu stat printing code to blk-throttle.c.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "629ed0b10209ffc4e1d439e5508d52d5e3a090b8", "tree": "69caa493e4ea0714aff247c8415c4fef7ebfe996", "parents": [ "2ce4d50f9cfab40831eee5e51e950d5c4724994b" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:44 2012 -0700" }, "message": "blkcg: move statistics update code to policies\n\nAs with conf/stats file handling code, there\u0027s no reason for stat\nupdate code to live in blkcg core with policies calling into update\nthem. The current organization is both inflexible and complex.\n\nThis patch moves stat update code to specific policies. All\nblkiocg_update_*_stats() functions which deal with BLKIO_POLICY_PROP\nstats are collapsed into their cfq_blkiocg_update_*_stats()\ncounterparts. blkiocg_update_dispatch_stats() is used by both\npolicies and duplicated as throtl_update_dispatch_stats() and\ncfq_blkiocg_update_dispatch_stats(). This will be cleaned up later.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "60c2bc2d5a12369deef395cda41638d7e6b6bf19", "tree": "67fb6ace87a930215f800f0a96bb33f9773231c7", "parents": [ "44ea53de46a8b01a65ae6217f47e00b516725190" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "message": "blkcg: move conf/stat file handling code to policies\n\nblkcg conf/stat handling is convoluted in that details which belong to\nspecific policy implementations are all out in blkcg core and then\npolicies hook into core layer to access and manipulate confs and\nstats. This sadly achieves both inflexibility (confs/stats can\u0027t be\nmodified without messing with blkcg core) and complexity (all the\ncall-ins and call-backs).\n\nThe previous patches restructured conf and stat handling code such\nthat they can be separated out. This patch relocates the file\nhandling part. All conf/stat file handling code which belongs to\nBLKIO_POLICY_PROP is moved to cfq-iosched.c and all\nBKLIO_POLICY_THROTL code to blk-throtl.c.\n\nThe move is verbatim except for blkio_update_group_{weight|bps|iops}()\ncallbacks which relays conf changes to policies. The configuration\nsettings are handled in policies themselves so the relaying isn\u0027t\nnecessary. Conf setting functions are modified to directly call\nper-policy update functions and the relaying mechanism is dropped.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "44ea53de46a8b01a65ae6217f47e00b516725190", "tree": "45ccff782042704818d0b3f96221c381209e4a2d", "parents": [ "829fdb50004de78f1bd187e428d72edcd9721cb8" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "message": "blkcg: implement blkio_policy_type-\u003ecftypes\n\nAdd blkiop-\u003ecftypes which is added and removed together with the\npolicy. This will be used to move conf/stat handling to the policies.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "829fdb50004de78f1bd187e428d72edcd9721cb8", "tree": "96dbdb62c97e0b7a9a31a7af6d18a6c34e820528", "parents": [ "726fa6945e6e5f0389bf47a790e1df734a67de54" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "message": "blkcg: export conf/stat helpers to prepare for reorganization\n\nconf/stat handling is about to be moved to policy implementation from\nblkcg core. Export conf/stat helpers from blkcg core so that\nblk-throttle and cfq-iosched can use them.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "726fa6945e6e5f0389bf47a790e1df734a67de54", "tree": "7119107ef544ccde91bdd6a116b4bdabc15e4bbd", "parents": [ "3a8b31d396b296df4b8594429d86d415d3409432" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "message": "blkcg: simplify blkg_conf_prep()\n\nblkg_conf_prep() implements \"MAJ:MIN VAL\" parsing manually, which is\nunnecessary. Just use sscanf(\"%u:%u %llu\"). This might not reject\nsome malformed input (extra input at the end) but we don\u0027t care.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "3a8b31d396b296df4b8594429d86d415d3409432", "tree": "fe75761c55f91e558b5899cc284fa9b4134d8167", "parents": [ "c4682aec9caaca1fcfd1dd4b59cef47af22cbdc6" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "message": "blkcg: restructure blkio_group configruation setting\n\nAs part of userland interface restructuring, this patch updates\nper-blkio_group configuration setting. Instead of funneling\neverything through a master function which has hard-coded cases for\neach config file it may handle, the common part is factored into\nblkg_conf_prep() and blkg_conf_finish() and different configuration\nsetters are implemented using the helpers.\n\nWhile this doesn\u0027t result in immediate LOC reduction, this enables\nfurther cleanups and more modular implementation.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "c4682aec9caaca1fcfd1dd4b59cef47af22cbdc6", "tree": "6e20981d877cf3dab29eb265f36edbd309f23761", "parents": [ "627f29f48158c3088cc55a25d8650cae455ff63b" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "message": "blkcg: restructure configuration printing\n\nSimilarly to the previous stat restructuring, this patch restructures\nconf printing code such that,\n\n* Conf printing uses the same helpers as stat.\n\n* Printing function doesn\u0027t require hardcoded switching on the config\n being printed. Note that this isn\u0027t complete yet for throttle\n confs. The next patch will convert setting for these confs and will\n complete the transition.\n\n* Printing uses read_seq_string callback (other methods will be phased\n out).\n\nNote that blkio_group_conf.iops[2] is changed to u64 so that they can\nbe manipulated with the same functions. This is transitional and will\ngo away later.\n\nAfter this patch, per-device configurations - weight, bps and iops -\nuse __blkg_prfill_u64() for printing which uses white space as\ndelimiter instead of tab.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "627f29f48158c3088cc55a25d8650cae455ff63b", "tree": "c8b2eb5250fbf15e5f932d15714b37f2ff6227a7", "parents": [ "d3d32e69fa368e131b25ee68806aa3fd3916cec1" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:43 2012 -0700" }, "message": "blkcg: drop blkiocg_file_write_u64()\n\nblkiocg_file_write_u64() has single switch case. Drop\nblkiocg_file_write_u64(), rename blkio_weight_write() to\nblkcg_set_weight() and use it directly for .write_u64 callback.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "d3d32e69fa368e131b25ee68806aa3fd3916cec1", "tree": "f6413e70f38cffb3b363fa831b5f868d90bb6c80", "parents": [ "edcb0722c654947908388df660791abd41e6617c" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:42 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:42 2012 -0700" }, "message": "blkcg: restructure statistics printing\n\nblkcg stats handling is a mess. None of the stats has much to do with\nblkcg core but they are all implemented in blkcg core. Code sharing\nis achieved by mixing common code with hard-coded cases for each stat\ncounter.\n\nThis patch restructures statistics printing such that\n\n* Common logic exists as helper functions and specific print functions\n use the helpers to implement specific cases.\n\n* Printing functions serving multiple counters don\u0027t require hardcoded\n switching on specific counters.\n\n* Printing uses read_seq_string callback (other methods will be phased\n out).\n\nThis change enables further cleanups and relocating stats code to the\npolicy implementation it belongs to.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "edcb0722c654947908388df660791abd41e6617c", "tree": "8c44dd4517bd562b58216dd01fb5abc42cb74a95", "parents": [ "2aa4a1523b40a065bc3a31e20097ea7a618ec3de" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:42 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:42 2012 -0700" }, "message": "blkcg: introduce blkg_stat and blkg_rwstat\n\nblkcg uses u64_stats_sync to avoid reading wrong u64 statistic values\non 32bit archs and some stat counters have subtypes to distinguish\nread/writes and sync/async IOs. The stat code paths are confusing and\ninvolve a lot of going back and forth between blkcg core and specific\npolicy implementations, and synchronization and subtype handling are\nopen coded in blkcg core.\n\nThis patch introduces struct blkg_stat and blkg_rwstat which, with\naccompanying operations, encapsulate stat updating and accessing with\nproper synchronization.\n\nblkg_stat is simple u64 counter with 64bit read-access protection.\nblkg_rwstat is the one with rw and [a]sync subcounters and takes @rw\nflags to distinguish IO subtypes (%REQ_WRITE and %REQ_SYNC) and\nreplaces stat_sub_type indexed arrays.\n\nAll counters in blkio_group_stats and blkio_group_stats_cpu are\nreplaced with either blkg_stat or blkg_rwstat along with all users.\n\nThis does add one u64_stats_sync per counter and increase stats_sync\noperations but they\u0027re empty/noops on 64bit archs and blkcg doesn\u0027t\nhave too many counters, especially with DEBUG_BLK_CGROUP off.\n\nWhile the currently resulting code isn\u0027t necessarily simpler at the\nmoment, this will enable further clean up of blkcg stats code.\n\n- BLKIO_STAT_{READ|WRITE|SYNC|ASYNC|TOTAL} renamed to\n BLKG_RWSTAT_{READ|WRITE|SYNC|ASYNC|TOTAL}.\n\n- blkg_stat_add() replaces blkio_add_stat() and\n blkio_check_and_dec_stat(). Note that BUG_ON() on underflow in the\n latter function no longer exists. It\u0027s *way* better to have\n underflowed stat counters than oopsing.\n\n- blkio_group_stats-\u003edequeue is now a proper u64 stat counter instead\n of ulong.\n\n- reset_stats() updated to clear each stat counters individually and\n BLKG_STATS_DEBUG_CLEAR_{START|SIZE} are removed.\n\n- Some functions reconstruct rw flags from direction and sync\n booleans. This will be removed by future patches.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "aaec55a002a29bf940588dc03253099a4cd543bf", "tree": "2fb146599db30c25abca72e52516d1c5f2c4e21e", "parents": [ "959d851caa48829eb85cb85aa949fd6b4c5d5bc6" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:42 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 14:38:42 2012 -0700" }, "message": "blkcg: remove unused @pol and @plid parameters\n\n@pol to blkg_to_pdata() and @plid to blkg_lookup_create() are no\nlonger necessary. Drop them.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "959d851caa48829eb85cb85aa949fd6b4c5d5bc6", "tree": "3ba9c94ec346275fb44c4f0d1cd2537cdff8d811", "parents": [ "a5567932fc926739e29e98487128080f40c61710", "48ddbe194623ae089cc0576e60363f2d2e85662a" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 12:30:01 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 12:55:00 2012 -0700" }, "message": "Merge branch \u0027for-3.5\u0027 of ../cgroup into block/for-3.5/core-merged\n\ncgroup/for-3.5 contains the following changes which blk-cgroup needs\nto proceed with the on-going cleanup.\n\n* Dynamic addition and removal of cftypes to make config/stat file\n handling modular for policies.\n\n* cgroup removal update to not wait for css references to drain to fix\n blkcg removal hang caused by cfq caching cfqgs.\n\nPull in cgroup/for-3.5 into block/for-3.5/core. This causes the\nfollowing conflicts in block/blk-cgroup.c.\n\n* 761b3ef50e \"cgroup: remove cgroup_subsys argument from callbacks\"\n conflicts with blkiocg_pre_destroy() addition and blkiocg_attach()\n removal. Resolved by removing @subsys from all subsys methods.\n\n* 676f7c8f84 \"cgroup: relocate cftype and cgroup_subsys definitions in\n controllers\" conflicts with -\u003epre_destroy() and -\u003eattach() updates\n and removal of modular config. Resolved by dropping forward\n declarations of the methods and applying updates to the relocated\n blkio_subsys.\n\n* 4baf6e3325 \"cgroup: convert all non-memcg controllers to the new\n cftype interface\" builds upon the previous item. Resolved by adding\n -\u003ebase_cftypes to the relocated blkio_subsys.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "4baf6e33251b37f111e21289f8ee71fe4cce236e", "tree": "7decc386a60679fd2696041810cf331c0daf1f41", "parents": [ "676f7c8f84d15e94065841529016da5ab92e901b" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 12:09:55 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 12:09:55 2012 -0700" }, "message": "cgroup: convert all non-memcg controllers to the new cftype interface\n\nConvert debug, freezer, cpuset, cpu_cgroup, cpuacct, net_prio, blkio,\nnet_cls and device controllers to use the new cftype based interface.\nTermination entry is added to cftype arrays and populate callbacks are\nreplaced with cgroup_subsys-\u003ebase_cftypes initializations.\n\nThis is functionally identical transformation. There shouldn\u0027t be any\nvisible behavior change.\n\nmemcg is rather special and will be converted separately.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nAcked-by: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nCc: Paul Menage \u003cpaul@paulmenage.org\u003e\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nCc: Peter Zijlstra \u003cpeterz@infradead.org\u003e\nCc: \"David S. Miller\" \u003cdavem@davemloft.net\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\n" }, { "commit": "676f7c8f84d15e94065841529016da5ab92e901b", "tree": "29c267a4c5711f9eaca7fa88fd7a78d39c8c4eac", "parents": [ "6e6ff25bd548a0c5bf5163e4f63e2793dcefbdcb" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 12:09:55 2012 -0700" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Sun Apr 01 12:09:55 2012 -0700" }, "message": "cgroup: relocate cftype and cgroup_subsys definitions in controllers\n\nblk-cgroup, netprio_cgroup, cls_cgroup and tcp_memcontrol\nunnecessarily define cftype array and cgroup_subsys structures at the\ntop of the file, which is unconventional and necessiates forward\ndeclaration of methods.\n\nThis patch relocates those below the definitions of the methods and\nremoves the forward declarations. Note that forward declaration of\ntcp_files[] is added in tcp_memcontrol.c for tcp_init_cgroup(). This\nwill be removed soon by another patch.\n\nThis patch doesn\u0027t introduce any functional change.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nAcked-by: Li Zefan \u003clizf@cn.fujitsu.com\u003e\n" }, { "commit": "a5567932fc926739e29e98487128080f40c61710", "tree": "8bd1995697c0c86f605a6ddb213312454ac7f467", "parents": [ "eb7d8c07f9c5fca6190b0d328179551122d1b8a3" ], "author": { "name": "Dan Carpenter", "email": "dan.carpenter@oracle.com", "time": "Thu Mar 29 20:57:08 2012 +0200" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Thu Mar 29 20:57:08 2012 +0200" }, "message": "blkcg: change a spin_lock() to spin_lock_irq()\n\nSmatch complains that we re-enable IRQs twice. It looks like we forgot\nto disable them here on the spin_trylock() failure path. This was added\nin 9f13ef678e \"blkcg: use double locking instead of RCU for blkg\nsynchronization\".\n\nSigned-off-by: Dan Carpenter \u003cdan.carpenter@oracle.com\u003e`\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "0d9cabdccedb79ee5f27b77ff51f29a9e7d23275", "tree": "8bfb64c3672d058eb90aec3c3a9c4f61cef9097c", "parents": [ "701085b219016d38f105b031381b9cee6200253a", "3ce3230a0cff484e5130153f244d4fb8a56b3a8b" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Mar 20 18:11:21 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Mar 20 18:11:21 2012 -0700" }, "message": "Merge branch \u0027for-3.4\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup\n\nPull cgroup changes from Tejun Heo:\n \"Out of the 8 commits, one fixes a long-standing locking issue around\n tasklist walking and others are cleanups.\"\n\n* \u0027for-3.4\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup:\n cgroup: Walk task list under tasklist_lock in cgroup_enable_task_cg_list\n cgroup: Remove wrong comment on cgroup_enable_task_cg_list()\n cgroup: remove cgroup_subsys argument from callbacks\n cgroup: remove extra calls to find_existing_css_set\n cgroup: replace tasklist_lock with rcu_read_lock\n cgroup: simplify double-check locking in cgroup_attach_proc\n cgroup: move struct cgroup_pidlist out from the header file\n cgroup: remove cgroup_attach_task_current_cg()\n" }, { "commit": "2b566fa55b9a94b53217c2818e6c5e5756eeb1a1", "tree": "d2186ebd18062172a7b0c83e31ca834f44ecdcc0", "parents": [ "598971bfbdfdc8701337dc1636c7919c44699914" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 19 15:10:59 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 20 12:47:48 2012 +0100" }, "message": "block: remove ioc_*_changed()\n\nAfter the previous patch to cfq, there\u0027s no ioc_get_changed() user\nleft. This patch yanks out ioc_{ioprio|cgroup|get}_changed() and all\nrelated stuff.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "9a9e8a26da4c2c5ddc60999bdea957935fb22b6b", "tree": "5a42ef29c2c34174390e4ccf9a2924c0ade6f340", "parents": [ "edf1b879e308d37b5b7c414476ab39f79650a253" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 19 15:10:56 2012 -0700" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 20 12:47:47 2012 +0100" }, "message": "blkcg: add blkcg-\u003eid\n\nAdd 64bit unique id to blkcg. This will be used by policies which\nwant blkcg identity test to tell whether the associated blkcg has\nchanged.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "edf1b879e308d37b5b7c414476ab39f79650a253", "tree": "fec2895e806eb357ba9e9ed960f8c247042d5383", "parents": [ "c4c76a05382c7d05e0b911daa58a827399e9ba1a" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Mar 08 10:54:00 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 20 12:45:37 2012 +0100" }, "message": "blkcg: remove blkio_group-\u003estats_lock\n\nWith recent plug merge updates, all non-percpu stat updates happen\nunder queue_lock making stats_lock unnecessary to synchronize stat\nupdates. The only synchronization necessary is stat reading, which\ncan be done using u64_stats_sync instead.\n\nThis patch removes blkio_group-\u003estats_lock and adds\nblkio_group_stats-\u003esyncp for reader synchronization.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "c4c76a05382c7d05e0b911daa58a827399e9ba1a", "tree": "e89f1edb9890a4b857f75dbdb4a0fb77d9aafa59", "parents": [ "997a026c80c3cc05f82e589aced1f0011c17d376" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Mar 08 10:53:59 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 20 12:45:37 2012 +0100" }, "message": "blkcg: restructure blkio_get_stat()\n\nRestructure blkio_get_stat() to prepare for removal of stats_lock.\n\n* Define BLKIO_STAT_ARR_NR explicitly to denote which stats have\n subtypes instead of using BLKIO_STAT_QUEUED.\n\n* Separate out stat acquisition and printing. After this, there are\n only two users of blkio_fill_stat(). Just open code it.\n\n* The code was mixing MAX_KEY_LEN and MAX_KEY_LEN - 1. There\u0027s no\n need to subtract one. Use MAX_KEY_LEN consistently.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "997a026c80c3cc05f82e589aced1f0011c17d376", "tree": "905fe49970f8549663e1e70e77dd04811fd14c9c", "parents": [ "5fe224d2d5fbf8f020b30d0ba69fed7856923752" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Mar 08 10:53:58 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 20 12:45:37 2012 +0100" }, "message": "blkcg: simplify stat reset\n\nblkiocg_reset_stats() implements stat reset for blkio.reset_stats\ncgroupfs file. This feature is very unconventional and something\nwhich shouldn\u0027t have been merged. It\u0027s only useful when there\u0027s only\none user or tool looking at the stats. As soon as multiple users\nand/or tools are involved, it becomes useless as resetting disrupts\nother usages. There are very good reasons why all other stats expect\nreaders to read values at the start and end of a period and subtract\nto determine delta over the period.\n\nThe implementation is rather complex - some fields shouldn\u0027t be\ncleared and it saves some fields, resets whole and restores for some\nreason. Reset of percpu stats is also racy. The comment points to\n64bit store atomicity for the reason but even without that stores for\nzero can simply race with other CPUs doing RMW and get clobbered.\n\nSimplify reset by\n\n* Clear selectively instead of resetting and restoring.\n\n* Grouping debug stat fields to be reset and using memset() over them.\n\n* Not caring about stats_lock.\n\n* Using memset() to reset percpu stats.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "5fe224d2d5fbf8f020b30d0ba69fed7856923752", "tree": "26941c40cd28c4f7070e8edab338d340afd2bc99", "parents": [ "1cd9e039fc258f91fe38b97b3c622b13a3b8a795" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Mar 08 10:53:57 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 20 12:45:37 2012 +0100" }, "message": "blkcg: don\u0027t use percpu for merged stats\n\nWith recent plug merge updates, merged stats are no longer called for\nplug merges and now only updated while holding queue_lock. As\nstats_lock is scheduled to be removed, there\u0027s no reason to use percpu\nfor merged stats. Don\u0027t use percpu for merged stats.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "1cd9e039fc258f91fe38b97b3c622b13a3b8a795", "tree": "908f9747124b24ea4413025ab9294bd7d026b4f8", "parents": [ "671058fb2a2aac4e70f01b316b06bc59b98bd138" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Thu Mar 08 10:53:56 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 20 12:45:37 2012 +0100" }, "message": "blkcg: alloc per cpu stats from worker thread in a delayed manner\n\nCurrent per cpu stat allocation assumes GFP_KERNEL allocation flag. But in\nIO path there are times when we want GFP_NOIO semantics. As there is no\nway to pass the allocation flags to alloc_percpu(), this patch delays the\nallocation of stats using a worker thread.\n\nv2-\u003e tejun suggested following changes. Changed the patch accordingly.\n\t- move alloc_node location in structure\n\t- reduce the size of names of some of the fields\n\t- Reduce the scope of locking of alloc_list_lock\n\t- Simplified stat_alloc_fn() by allocating stats for all\n\t policies in one go and then assigning these to a group.\n\nv3 -\u003e Andrew suggested to put some comments in the code. Also raised\n concerns about trying to allocate infinitely in case of allocation\n failure. I have changed the logic to sleep for 10ms before retrying.\n That should take care of non-preemptible UP kernels.\n\nv4 -\u003e Tejun had more suggestions.\n\t- drop list_for_each_entry_all()\n\t- instead of msleep() use queue_delayed_work()\n\t- Some cleanups realted to more compact coding.\n\nv5-\u003e tejun suggested more cleanups leading to more compact code.\n\ntj: - Relocated pcpu_stats into blkio_stat_alloc_fn().\n - Minor comment update.\n - This also fixes suspicious RCU usage warning caused by invoking\n cgroup_path() from blkg_alloc() without holding RCU read lock.\n Now that blkg_alloc() doesn\u0027t require sleepable context, RCU\n read lock from blkg_lookup_create() is maintained throughout\n blkg_alloc().\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "4f85cb96d9d2fbbb7160db855a6beee1baced5e5", "tree": "5472bba04490da05fa6ca8f780431b37bd7375cb", "parents": [ "852c788f8365062c8a383c5a93f7f7289977cb50" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:28 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:24 2012 +0100" }, "message": "block: make block cgroup policies follow bio task association\n\nImplement bio_blkio_cgroup() which returns the blkcg associated with\nthe bio if exists or %current\u0027s blkcg, and use it in blk-throttle and\ncfq-iosched propio. This makes both cgroup policies honor task\nassociation for the bio instead of always assuming %current.\n\nAs nobody is using bio_set_task() yet, this doesn\u0027t introduce any\nbehavior change.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "c875f4d0250a1f070fa26087a73bdd8f54c48100", "tree": "4ed2bae2fc48e54ac712d28eaaae8217c8064c1d", "parents": [ "9f13ef678efd977487fc0c2e489f17c9a8c67a3e" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:22 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:24 2012 +0100" }, "message": "blkcg: drop unnecessary RCU locking\n\nNow that blkg additions / removals are always done under both q and\nblkcg locks, the only places RCU locking is necessary are\nblkg_lookup[_create]() for lookup w/o blkcg lock. This patch drops\nunncessary RCU locking replacing it with plain blkcg locking as\nnecessary.\n\n* blkiocg_pre_destroy() already perform proper locking and don\u0027t need\n RCU. Dropped.\n\n* blkio_read_blkg_stats() now uses blkcg-\u003elock instead of RCU read\n lock. This isn\u0027t a hot path.\n\n* Now unnecessary synchronize_rcu() from queue exit paths removed.\n This makes q-\u003enr_blkgs unnecessary. Dropped.\n\n* RCU annotation on blkg-\u003eq removed.\n\n-v2: Vivek pointed out that blkg_lookup_create() still needs to be\n called under rcu_read_lock(). Updated.\n\n-v3: After the update, stats_lock locking in blkio_read_blkg_stats()\n shouldn\u0027t be using _irq variant as it otherwise ends up enabling\n irq while blkcg-\u003elock is locked. Fixed.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "9f13ef678efd977487fc0c2e489f17c9a8c67a3e", "tree": "e58a2dd153ad24b2ea173d5dfb575c507e1f7589", "parents": [ "e8989fae38d9831c72b20375a206a919ca468c52" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:21 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:24 2012 +0100" }, "message": "blkcg: use double locking instead of RCU for blkg synchronization\n\nblkgs are chained from both blkcgs and request_queues and thus\nsubjected to two locks - blkcg-\u003elock and q-\u003equeue_lock. As both blkcg\nand q can go away anytime, locking during removal is tricky. It\u0027s\ncurrently solved by wrapping removal inside RCU, which makes the\nsynchronization complex. There are three locks to worry about - the\nouter RCU, q lock and blkcg lock, and it leads to nasty subtle\ncomplications like conditional synchronize_rcu() on queue exit paths.\n\nFor all other paths, blkcg lock is naturally nested inside q lock and\nthe only exception is blkcg removal path, which is a very cold path\nand can be implemented as clumsy but conceptually-simple reverse\ndouble lock dancing.\n\nThis patch updates blkg removal path such that blkgs are removed while\nholding both q and blkcg locks, which is trivial for request queue\nexit path - blkg_destroy_all(). The blkcg removal path,\nblkiocg_pre_destroy(), implements reverse double lock dancing\nessentially identical to ioc_release_fn().\n\nThis simplifies blkg locking - no half-dead blkgs to worry about. Now\nunnecessary RCU annotations will be removed by the next patch.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "e8989fae38d9831c72b20375a206a919ca468c52", "tree": "2eeb1320e526cd0ba187465c0e6e19799dc1b956", "parents": [ "03aa264ac15637b6f98374270bcdf31400965505" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:20 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:23 2012 +0100" }, "message": "blkcg: unify blkg\u0027s for blkcg policies\n\nCurrently, blkg is per cgroup-queue-policy combination. This is\nunnatural and leads to various convolutions in partially used\nduplicate fields in blkg, config / stat access, and general management\nof blkgs.\n\nThis patch make blkg\u0027s per cgroup-queue and let them serve all\npolicies. blkgs are now created and destroyed by blkcg core proper.\nThis will allow further consolidation of common management logic into\nblkcg core and API with better defined semantics and layering.\n\nAs a transitional step to untangle blkg management, elvswitch and\npolicy [de]registration, all blkgs except the root blkg are being shot\ndown during elvswitch and bypass. This patch adds blkg_root_update()\nto update root blkg in place on policy change. This is hacky and racy\nbut should be good enough as interim step until we get locking\nsimplified and switch over to proper in-place update for all blkgs.\n\n-v2: Root blkgs need to be updated on elvswitch too and blkg_alloc()\n comment wasn\u0027t updated according to the function change. Fixed.\n Both pointed out by Vivek.\n\n-v3: v2 updated blkg_destroy_all() to invoke update_root_blkg_pd() for\n all policies. This freed root pd during elvswitch before the\n last queue finished exiting and led to oops. Directly invoke\n update_root_blkg_pd() only on BLKIO_POLICY_PROP from\n cfq_exit_queue(). This also is closer to what will be done with\n proper in-place blkg update. Reported by Vivek.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "03aa264ac15637b6f98374270bcdf31400965505", "tree": "6fa9ca54d3f775fba19123790f6655158034a1d8", "parents": [ "4eef3049986e8397d5003916aed8cad6567a5e02" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:19 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:23 2012 +0100" }, "message": "blkcg: let blkcg core manage per-queue blkg list and counter\n\nWith the previous patch to move blkg list heads and counters to\nrequest_queue and blkg, logic to manage them in both policies are\nalmost identical and can be moved to blkcg core.\n\nThis patch moves blkg link logic into blkg_lookup_create(), implements\ncommon blkg unlink code in blkg_destroy(), and updates\nblkg_destory_all() so that it\u0027s policy specific and can skip root\ngroup. The updated blkg_destroy_all() is now used to both clear queue\nfor bypassing and elv switching, and release all blkgs on q exit.\n\nThis patch introduces a race window where policy [de]registration may\nrace against queue blkg clearing. This can only be a problem on cfq\nunload and shouldn\u0027t be a real problem in practice (and we have many\nother places where this race already exists). Future patches will\nremove these unlikely races.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "4eef3049986e8397d5003916aed8cad6567a5e02", "tree": "5e36431986907b9fa728a6fbeb819a2738a64c82", "parents": [ "c1768268f9424410761da57ea71107acae7b03cc" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:18 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:23 2012 +0100" }, "message": "blkcg: move per-queue blkg list heads and counters to queue and blkg\n\nCurrently, specific policy implementations are responsible for\nmaintaining list and number of blkgs. This duplicates code\nunnecessarily, and hinders factoring common code and providing blkcg\nAPI with better defined semantics.\n\nAfter this patch, request_queue hosts list heads and counters and blkg\nhas list nodes for both policies. This patch only relocates the\nnecessary fields and the next patch will actually move management code\ninto blkcg core.\n\nNote that request_queue-\u003eblkg_list[] and -\u003enr_blkgs[] are hardcoded to\nhave 2 elements. This is to avoid include dependency and will be\nremoved by the next patch.\n\nThis patch doesn\u0027t introduce any behavior change.\n\n-v2: Now unnecessary conditional on CONFIG_BLK_CGROUP_MODULE removed\n as pointed out by Vivek.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "c1768268f9424410761da57ea71107acae7b03cc", "tree": "be6a534b1a15ab9df9f23e585b039776c5a5e498", "parents": [ "549d3aa872cd1aec1ee540fd93afd9611faa0def" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:17 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:23 2012 +0100" }, "message": "blkcg: don\u0027t use blkg-\u003eplid in stat related functions\n\nblkg is scheduled to be unified for all policies and thus there won\u0027t\nbe one-to-one mapping from blkg to policy. Update stat related\nfunctions to take explicit @pol or @plid arguments and not use\nblkg-\u003eplid.\n\nThis is painful for now but most of specific stat interface functions\nwill be replaced with a handful of generic helpers.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "549d3aa872cd1aec1ee540fd93afd9611faa0def", "tree": "27c3703d3448dc0be9f58b5f01224ae901422a32", "parents": [ "1adaf3dde37a8b9b59ea59c5f58fed7761178383" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:16 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:23 2012 +0100" }, "message": "blkcg: make blkg-\u003epd an array and move configuration and stats into it\n\nTo prepare for unifying blkgs for different policies, make blkg-\u003epd an\narray with BLKIO_NR_POLICIES elements and move blkg-\u003econf, -\u003estats,\nand -\u003estats_cpu into blkg_policy_data.\n\nThis patch doesn\u0027t introduce any functional difference.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "1adaf3dde37a8b9b59ea59c5f58fed7761178383", "tree": "e4a46485b1bf0370aa41a5b9a8f138fba34c9d23", "parents": [ "0381411e4b1a52cee134eb73750e5e3cc1155d09" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:15 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:23 2012 +0100" }, "message": "blkcg: move refcnt to blkcg core\n\nCurrently, blkcg policy implementations manage blkg refcnt duplicating\nmostly identical code in both policies. This patch moves refcnt to\nblkg and let blkcg core handle refcnt and freeing of blkgs.\n\n* cfq blkgs now also get freed via RCU.\n\n* cfq blkgs lose RB_EMPTY_ROOT() sanity check on blkg free. If\n necessary, we can add blkio_exit_group_fn() to resurrect this.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "0381411e4b1a52cee134eb73750e5e3cc1155d09", "tree": "32aa1d0b8a2ca8277e60e8b78dd731d193440924", "parents": [ "923adde1be1df57cebd80c563058e503376645e8" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:14 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:23 2012 +0100" }, "message": "blkcg: let blkcg core handle policy private data allocation\n\nCurrently, blkg\u0027s are embedded in private data blkcg policy private\ndata structure and thus allocated and freed by policies. This leads\nto duplicate codes in policies, hinders implementing common part in\nblkcg core with strong semantics, and forces duplicate blkg\u0027s for the\nsame cgroup-q association.\n\nThis patch introduces struct blkg_policy_data which is a separate data\nstructure chained from blkg. Policies specifies the amount of private\ndata it needs in its blkio_policy_type-\u003epdata_size and blkcg core\ntakes care of allocating them along with blkg which can be accessed\nusing blkg_to_pdata(). blkg can be determined from pdata using\npdata_to_blkg(). blkio_alloc_group_fn() method is accordingly updated\nto blkio_init_group_fn().\n\nFor consistency, tg_of_blkg() and cfqg_of_blkg() are replaced with\nblkg_to_tg() and blkg_to_cfqg() respectively, and functions to map in\nthe reverse direction are added.\n\nExcept that policy specific data now lives in a separate data\nstructure from blkg, this patch doesn\u0027t introduce any functional\ndifference.\n\nThis will be used to unify blkg\u0027s for different policies.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "923adde1be1df57cebd80c563058e503376645e8", "tree": "7009edf644abdf6b91daaab3967ffa6a8b30633a", "parents": [ "5efd611351d1a847c72d74fb12ff4bd187c0cb2c" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:13 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:23 2012 +0100" }, "message": "blkcg: clear all request_queues on blkcg policy [un]registrations\n\nKeep track of all request_queues which have blkcg initialized and turn\non bypass and invoke blkcg_clear_queue() on all before making changes\nto blkcg policies.\n\nThis is to prepare for moving blkg management into blkcg core. Note\nthat this uses more brute force than necessary. Finer grained shoot\ndown will be implemented later and given that policy [un]registration\nalmost never happens on running systems (blk-throtl can\u0027t be built as\na module and cfq usually is the builtin default iosched), this\nshouldn\u0027t be a problem for the time being.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "5efd611351d1a847c72d74fb12ff4bd187c0cb2c", "tree": "bac28206d088426ab872eea98155cc100bd8d9b1", "parents": [ "7ee9c5620504906e98451dc9a1945b2b9e892cb8" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:12 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:23 2012 +0100" }, "message": "blkcg: add blkcg_{init|drain|exit}_queue()\n\nCurrently block core calls directly into blk-throttle for init, drain\nand exit. This patch adds blkcg_{init|drain|exit}_queue() which wraps\nthe blk-throttle functions. This is to give more control and\nvisiblity to blkcg core layer for proper layering. Further patches\nwill add logic common to blkcg policies to the functions.\n\nWhile at it, collapse blk_throtl_release() into blk_throtl_exit().\nThere\u0027s no reason to keep them separate.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "7ee9c5620504906e98451dc9a1945b2b9e892cb8", "tree": "1daf4d9fc8d03ebbc88ceedb7abeec46d8c71df3", "parents": [ "92616b5b3a7c7fa8148df82e7ff6183056f2bfc8" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:11 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:23 2012 +0100" }, "message": "blkcg: let blkio_group point to blkio_cgroup directly\n\nCurrently, blkg points to the associated blkcg via its css_id. This\nunnecessarily complicates dereferencing blkcg. Let blkg hold a\nreference to the associated blkcg and point directly to it and disable\ncss_id on blkio_subsys.\n\nThis change requires splitting blkiocg_destroy() into\nblkiocg_pre_destroy() and blkiocg_destroy() so that all blkg\u0027s can be\ndestroyed and all the blkcg references held by them dropped during\ncgroup removal.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "92616b5b3a7c7fa8148df82e7ff6183056f2bfc8", "tree": "b204b7df4753e9508cf15d278688dc9c307761fa", "parents": [ "7a4dd281ec66224f802093962d1d903d86b09560" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Mon Mar 05 13:15:10 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:22 2012 +0100" }, "message": "blkcg: skip blkg printing if q isn\u0027t associated with disk\n\nblk-cgroup printing code currently assumes that there is a device/disk\nassociated with every queue in the system, but modules like floppy,\ncan instantiate request queues without registering disk which can lead\nto oops.\n\nSkip the queue/blkg which don\u0027t have dev/disk associated with them.\n\n-tj: Factored out backing_dev_info check into blkg_dev_name().\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "7a4dd281ec66224f802093962d1d903d86b09560", "tree": "c38c5c40464d4d7eb429cc14348a435176832ef2", "parents": [ "4bfd482e73b30284cb21e10834ce729fa81aa256" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:09 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:22 2012 +0100" }, "message": "blkcg: kill the mind-bending blkg-\u003edev\n\nblkg-\u003edev is dev_t recording the device number of the block device for\nthe associated request_queue. It is used to identify the associated\nblock device when printing out configuration or stats.\n\nThis is redundant to begin with. A blkg is an association between a\ncgroup and a request_queue and it of course is possible to reach\nrequest_queue from blkg and synchronization conventions are in place\nfor safe q dereferencing, so this shouldn\u0027t be necessary from the\nbeginning. Furthermore, it\u0027s initialized by sscanf()ing the device\nname of backing_dev_info. The mind boggles.\n\nAnyways, if blkg is visible under rcu lock, we *know* that the\nassociated request_queue hasn\u0027t gone away yet and its bdi is\nregistered and alive - blkg can\u0027t be created for request_queue which\nhasn\u0027t been fully initialized and it can\u0027t go away before blkg is\nremoved.\n\nLet stat and conf read functions get device name from\nblkg-\u003eq-\u003ebacking_dev_info.dev and pass it down to printing functions\nand remove blkg-\u003edev.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "4bfd482e73b30284cb21e10834ce729fa81aa256", "tree": "2c39e09592113946e3545013199b0e00a21f60f2", "parents": [ "e56da7e287967667474a58c4f60c286279e3f487" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:08 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:22 2012 +0100" }, "message": "blkcg: kill blkio_policy_node\n\nNow that blkcg configuration lives in blkg\u0027s, blkio_policy_node is no\nlonger necessary. Kill it.\n\nblkio_policy_parse_and_set() now fails if invoked for missing device\nand functions to print out configurations are updated to print from\nblkg\u0027s.\n\ncftype_blkg_same_policy() is dropped along with other policy functions\nfor consistency. Its one line is open coded in the only user -\nblkio_read_blkg_stats().\n\n-v2: Update to reflect the retry-on-bypass logic change of the\n previous patch.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "e56da7e287967667474a58c4f60c286279e3f487", "tree": "4ce64581888f287a25b4abdc21fc641210351612", "parents": [ "cd1604fab4f95f7cfc227d3955fd7ae14da61f38" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:07 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:22 2012 +0100" }, "message": "blkcg: don\u0027t allow or retain configuration of missing devices\n\nblkcg is very peculiar in that it allows setting and remembering\nconfigurations for non-existent devices by maintaining separate data\nstructures for configuration.\n\nThis behavior is completely out of the usual norms and outright\nconfusing; furthermore, it uses dev_t number to match the\nconfiguration to devices, which is unpredictable to begin with and\nbecomes completely unuseable if EXT_DEVT is fully used.\n\nIt is wholely unnecessary - we already have fully functional userland\nmechanism to program devices being hotplugged which has full access to\ndevice identification, connection topology and filesystem information.\n\nAdd a new struct blkio_group_conf which contains all blkcg\nconfigurations to blkio_group and let blkio_group, which can be\ncreated iff the associated device exists and is removed when the\nassociated device goes away, carry all configurations.\n\nNote that, after this patch, all newly created blkg\u0027s will always have\nthe default configuration (unlimited for throttling and blkcg\u0027s weight\nfor propio).\n\nThis patch makes blkio_policy_node meaningless but doesn\u0027t remove it.\nThe next patch will.\n\n-v2: Updated to retry after short sleep if blkg lookup/creation failed\n due to the queue being temporarily bypassed as indicated by\n -EBUSY return. Pointed out by Vivek.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nCc: Kay Sievers \u003ckay.sievers@vrfy.org\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "cd1604fab4f95f7cfc227d3955fd7ae14da61f38", "tree": "021881faedc1c2468730f9f54d364083e70dce76", "parents": [ "f51b802c17e2a21926b29911493f5e7ddf6eee87" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:06 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:22 2012 +0100" }, "message": "blkcg: factor out blkio_group creation\n\nCurrently both blk-throttle and cfq-iosched implement their own\nblkio_group creation code in throtl_get_tg() and cfq_get_cfqg(). This\npatch factors out the common code into blkg_lookup_create(), which\nreturns ERR_PTR value so that transitional failures due to queue\nbypass can be distinguished from other failures.\n\n* New plkio_policy_ops methods blkio_alloc_group_fn() and\n blkio_link_group_fn added. Both are transitional and will be\n removed once the blkg management code is fully moved into\n blk-cgroup.c.\n\n* blkio_alloc_group_fn() allocates policy-specific blkg which is\n usually a larger data structure with blkg as the first entry and\n intiailizes it. Note that initialization of blkg proper, including\n percpu stats, is responsibility of blk-cgroup proper.\n\n Note that default config (weight, bps...) initialization is done\n from this method; otherwise, we end up violating locking order\n between blkcg and q locks via blkcg_get_CONF() functions.\n\n* blkio_link_group_fn() is called under queue_lock and responsible for\n linking the blkg to the queue. blkcg side is handled by blk-cgroup\n proper.\n\n* The common blkg creation function is named blkg_lookup_create() and\n blkiocg_lookup_group() is renamed to blkg_lookup() for consistency.\n Also, throtl / cfq related functions are similarly [re]named for\n consistency.\n\nThis simplifies blkcg policy implementations and enables further\ncleanup.\n\n-v2: Vivek noticed that blkg_lookup_create() incorrectly tested\n blk_queue_dead() instead of blk_queue_bypass() leading a user of\n the function ending up creating a new blkg on bypassing queue.\n This is a bug introduced while relocating bypass patches before\n this one. Fixed.\n\n-v3: ERR_PTR patch folded into this one. @for_root added to\n blkg_lookup_create() to allow creating root group on a bypassed\n queue during elevator switch.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "035d10b2fa7e5f7e9bf9465dbc39c35affd5ac32", "tree": "6a712eb1b505e8163d28f8709980e581a08b572c", "parents": [ "ca32aefc7f2539ed88d42763330d54ee3e61769a" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:04 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:22 2012 +0100" }, "message": "blkcg: add blkio_policy[] array and allow one policy per policy ID\n\nBlock cgroup policies are maintained in a linked list and,\ntheoretically, multiple policies sharing the same policy ID are\nallowed.\n\nThis patch temporarily restricts one policy per plid and adds\nblkio_policy[] array which indexes registered policy types by plid.\nBoth the restriction and blkio_policy[] array are transitional and\nwill be removed once API cleanup is complete.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "ca32aefc7f2539ed88d42763330d54ee3e61769a", "tree": "791d2ac1c11b738ce34629653090b6e971fc11b5", "parents": [ "0a5a7d0e32be6643b881f0e7cd9d0d06fadde27a" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:03 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:22 2012 +0100" }, "message": "blkcg: use q and plid instead of opaque void * for blkio_group association\n\nblkgio_group is association between a block cgroup and a queue for a\ngiven policy. Using opaque void * for association makes things\nconfusing and hinders factoring of common code. Use request_queue *\nand, if necessary, policy id instead.\n\nThis will help block cgroup API cleanup.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "72e06c255181537d0b3e1f657a9ed81655d745b1", "tree": "eb656df2ad23a7709b4e9fe58f1dabdc32be9ae9", "parents": [ "6ecf23afab13c39d3bb0e2d826d0984b0dd53733" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:15:00 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:22 2012 +0100" }, "message": "blkcg: shoot down blkio_groups on elevator switch\n\nElevator switch may involve changes to blkcg policies. Implement\nshoot down of blkio_groups.\n\nCombined with the previous bypass updates, the end goal is updating\nblkcg core such that it can ensure that blkcg\u0027s being affected become\nquiescent and don\u0027t have any per-blkg data hanging around before\ncommencing any policy updates. Until queues are made aware of the\npolicies that applies to them, as an interim step, all per-policy blkg\ndata will be shot down.\n\n* blk-throtl doesn\u0027t need this change as it can\u0027t be disabled for a\n live queue; however, update it anyway as the scheduled blkg\n unification requires this behavior change. This means that\n blk-throtl configuration will be unnecessarily lost over elevator\n switch. This oddity will be removed after blkcg learns to associate\n individual policies with request_queues.\n\n* blk-throtl dosen\u0027t shoot down root_tg. This is to ease transition.\n Unified blkg will always have persistent root group and not shooting\n down root_tg for now eases transition to that point by avoiding\n having to update td-\u003eroot_tg and is safe as blk-throtl can never be\n disabled\n\n-v2: Vivek pointed out that group list is not guaranteed to be empty\n on return from clear function if it raced cgroup removal and\n lost. Fix it by waiting a bit and retrying. This kludge will\n soon be removed once locking is updated such that blkg is never\n in limbo state between blkcg and request_queue locks.\n\n blk-throtl no longer shoots down root_tg to avoid breaking\n td-\u003eroot_tg.\n\n Also, Nest queue_lock inside blkio_list_lock not the other way\n around to avoid introduce possible deadlock via blkcg lock.\n\n-v3: blkcg_clear_queue() repositioned and renamed to\n blkg_destroy_all() to increase consistency with later changes.\n cfq_clear_queue() updated to check q-\u003eelevator before\n dereferencing it to avoid NULL dereference on not fully\n initialized queues (used by later change).\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "32e380aedc3de454c06ce1c254fe3bea35a676e1", "tree": "ae48ced36af22f020451cb05ecca835ff561dc9d", "parents": [ "b855b04a0b2213dbc1b59cf936056726e7ed97ad" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Mar 05 13:14:54 2012 -0800" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Mar 06 21:27:21 2012 +0100" }, "message": "blkcg: make CONFIG_BLK_CGROUP bool\n\nBlock cgroup core can be built as module; however, it isn\u0027t too useful\nas blk-throttle can only be built-in and cfq-iosched is usually the\ndefault built-in scheduler. Scheduled blkcg cleanup requires calling\ninto blkcg from block core. To simplify that, disallow building blkcg\nas module by making CONFIG_BLK_CGROUP bool.\n\nIf building blkcg core as module really matters, which I doubt, we can\nrevisit it after blkcg API cleanup.\n\n-v2: Vivek pointed out that IOSCHED_CFQ was incorrectly updated to\n depend on BLK_CGROUP. Fixed.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "11a3122f6cf2d988a77eb8883d0fc49cd013a6d5", "tree": "ded8ea8a2982754ff0c58448a7ed2e59487104cb", "parents": [ "822bfa51ce44f2c63c300fdb76dc99c4d5a5ca9f" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Feb 07 07:51:30 2012 +0100" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Feb 07 07:51:30 2012 +0100" }, "message": "block: strip out locking optimization in put_io_context()\n\nput_io_context() performed a complex trylock dancing to avoid\ndeferring ioc release to workqueue. It was also broken on UP because\ntrylock was always assumed to succeed which resulted in unbalanced\npreemption count.\n\nWhile there are ways to fix the UP breakage, even the most\npathological microbench (forced ioc allocation and tight fork/exit\nloop) fails to show any appreciable performance benefit of the\noptimization. Strip it out. If there turns out to be workloads which\nare affected by this change, simpler optimization from the discussion\nthread can be applied later.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nLKML-Reference: \u003c1328514611.21268.66.camel@sli10-conroe\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "761b3ef50e1c2649cffbfa67a4dcb2dcdb7982ed", "tree": "67ab6a9a2520811c9c0b4d70d1c19b4bfca16237", "parents": [ "61d1d219c4c0761059236a46867bc49943c4d29d" ], "author": { "name": "Li Zefan", "email": "lizf@cn.fujitsu.com", "time": "Tue Jan 31 13:47:36 2012 +0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Thu Feb 02 09:20:22 2012 -0800" }, "message": "cgroup: remove cgroup_subsys argument from callbacks\n\nThe argument is not used at all, and it\u0027s not necessary, because\na specific callback handler of course knows which subsys it\nbelongs to.\n\nNow only -\u003epupulate() takes this argument, because the handlers of\nthis callback always call cgroup_add_file()/cgroup_add_files().\n\nSo we reduce a few lines of code, though the shrinking of object size\nis minimal.\n\n 16 files changed, 113 insertions(+), 162 deletions(-)\n\n text data bss dec hex filename\n5486240 656987 7039960 13183187 c928d3 vmlinux.o.orig\n5486170 656987 7039960 13183117 c9288d vmlinux.o\n\nSigned-off-by: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\n" }, { "commit": "b3c9dd182ed3bdcdaf0e42625a35924b0497afdc", "tree": "ad48ad4d923fee147c736318d0fad35b3755f4f5", "parents": [ "83c2f912b43c3a7babbb6cb7ae2a5276c1ed2a3e", "5d381efb3d1f1ef10535a31ca0dd9b22fe1e1922" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Jan 15 12:24:45 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Jan 15 12:24:45 2012 -0800" }, "message": "Merge branch \u0027for-3.3/core\u0027 of git://git.kernel.dk/linux-block\n\n* \u0027for-3.3/core\u0027 of git://git.kernel.dk/linux-block: (37 commits)\n Revert \"block: recursive merge requests\"\n block: Stop using macro stubs for the bio data integrity calls\n blockdev: convert some macros to static inlines\n fs: remove unneeded plug in mpage_readpages()\n block: Add BLKROTATIONAL ioctl\n block: Introduce blk_set_stacking_limits function\n block: remove WARN_ON_ONCE() in exit_io_context()\n block: an exiting task should be allowed to create io_context\n block: ioc_cgroup_changed() needs to be exported\n block: recursive merge requests\n block, cfq: fix empty queue crash caused by request merge\n block, cfq: move icq creation and rq-\u003eelv.icq association to block core\n block, cfq: restructure io_cq creation path for io_context interface cleanup\n block, cfq: move io_cq exit/release to blk-ioc.c\n block, cfq: move icq cache management to block core\n block, cfq: move io_cq lookup to blk-ioc.c\n block, cfq: move cfqd-\u003eicq_list to request_queue and add request-\u003eelv.icq\n block, cfq: reorganize cfq_io_context into generic and cfq specific parts\n block: remove elevator_queue-\u003eops\n block: reorder elevator switch sequence\n ...\n\nFix up conflicts in:\n - block/blk-cgroup.c\n\tSwitch from can_attach_task to can_attach\n - block/cfq-iosched.c\n\tconflict with now removed cic index changes (we now use q-\u003eid instead)\n" }, { "commit": "b2efa05265d62bc29f3a64400fad4b44340eedb8", "tree": "4555f0b5f0025c099997b81f7b3f8bc48b44220d", "parents": [ "f1a4f4d35ff30a328d5ea28f6cc826b2083111d2" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Dec 14 00:33:39 2011 +0100" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Wed Dec 14 00:33:39 2011 +0100" }, "message": "block, cfq: unlink cfq_io_context\u0027s immediately\n\ncic is association between io_context and request_queue. A cic is\nlinked from both ioc and q and should be destroyed when either one\ngoes away. As ioc and q both have their own locks, locking becomes a\nbit complex - both orders work for removal from one but not from the\nother.\n\nCurrently, cfq tries to circumvent this locking order issue with RCU.\nioc-\u003elock nests inside queue_lock but the radix tree and cic\u0027s are\nalso protected by RCU allowing either side to walk their lists without\ngrabbing lock.\n\nThis rather unconventional use of RCU quickly devolves into extremely\nfragile convolution. e.g. The following is from cfqd going away too\nsoon after ioc and q exits raced.\n\n general protection fault: 0000 [#1] PREEMPT SMP\n CPU 2\n Modules linked in:\n [ 88.503444]\n Pid: 599, comm: hexdump Not tainted 3.1.0-rc10-work+ #158 Bochs Bochs\n RIP: 0010:[\u003cffffffff81397628\u003e] [\u003cffffffff81397628\u003e] cfq_exit_single_io_context+0x58/0xf0\n ...\n Call Trace:\n [\u003cffffffff81395a4a\u003e] call_for_each_cic+0x5a/0x90\n [\u003cffffffff81395ab5\u003e] cfq_exit_io_context+0x15/0x20\n [\u003cffffffff81389130\u003e] exit_io_context+0x100/0x140\n [\u003cffffffff81098a29\u003e] do_exit+0x579/0x850\n [\u003cffffffff81098d5b\u003e] do_group_exit+0x5b/0xd0\n [\u003cffffffff81098de7\u003e] sys_exit_group+0x17/0x20\n [\u003cffffffff81b02f2b\u003e] system_call_fastpath+0x16/0x1b\n\nThe only real hot path here is cic lookup during request\ninitialization and avoiding extra locking requires very confined use\nof RCU. This patch makes cic removal from both ioc and request_queue\nperform double-locking and unlink immediately.\n\n* From q side, the change is almost trivial as ioc-\u003elock nests inside\n queue_lock. It just needs to grab each ioc-\u003elock as it walks\n cic_list and unlink it.\n\n* From ioc side, it\u0027s a bit more difficult because of inversed lock\n order. ioc needs its lock to walk its cic_list but can\u0027t grab the\n matching queue_lock and needs to perform unlock-relock dancing.\n\n Unlinking is now wholly done from put_io_context() and fast path is\n optimized by using the queue_lock the caller already holds, which is\n by far the most common case. If the ioc accessed multiple devices,\n it tries with trylock. In unlikely cases of fast path failure, it\n falls back to full double-locking dance from workqueue.\n\nDouble-locking isn\u0027t the prettiest thing in the world but it\u0027s *far*\nsimpler and more understandable than RCU trick without adding any\nmeaningful overhead.\n\nThis still leaves a lot of now unnecessary RCU logics. Future patches\nwill trim them.\n\n-v2: Vivek pointed out that cic-\u003eq was being dereferenced after\n cic-\u003erelease() was called. Updated to use local variable @this_q\n instead.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "dc86900e0a8f665122de6faadd27fb4c6d2b3e4d", "tree": "ec24aa4b076f54fcfb0558d5113f5c5e0f4bc173", "parents": [ "283287a52e3c3f7f8f9da747f4b8c5202740d776" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Dec 14 00:33:38 2011 +0100" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Wed Dec 14 00:33:38 2011 +0100" }, "message": "block, cfq: move ioc ioprio/cgroup changed handling to cic\n\nioprio/cgroup change was handled by marking the changed state in ioc\nand, on the following access to the ioc, performing RCU-protected\niteration through all cic\u0027s grabbing the matching queue_lock.\n\nThis patch moves the changed state to each cic. When ioprio or cgroup\nchanges, the respective bit is set on all cic\u0027s of the ioc and when\neach of those cic (not ioc) is accessed, change is applied for that\nspecific ioc-queue pair.\n\nThis also fixes the following two race conditions between setting and\nclearing of changed states.\n\n* Missing barrier between assign/load of ioprio and ioprio_changed\n allowed applying old ioprio.\n\n* Change requests could happen between application of change and\n clearing of changed variables.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "6e736be7f282fff705db7c34a15313281b372a76", "tree": "1683e00e073ee4bd3027798f92ae2d368404d44b", "parents": [ "42ec57a8f68311bbbf4ff96a5d33c8a2e90b9d05" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Dec 14 00:33:38 2011 +0100" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Wed Dec 14 00:33:38 2011 +0100" }, "message": "block: make ioc get/put interface more conventional and fix race on alloction\n\nIgnoring copy_io() during fork, io_context can be allocated from two\nplaces - current_io_context() and set_task_ioprio(). The former is\nalways called from local task while the latter can be called from\ndifferent task. The synchornization between them are peculiar and\ndubious.\n\n* current_io_context() doesn\u0027t grab task_lock() and assumes that if it\n saw %NULL -\u003eio_context, it would stay that way until allocation and\n assignment is complete. It has smp_wmb() between alloc/init and\n assignment.\n\n* set_task_ioprio() grabs task_lock() for assignment and does\n smp_read_barrier_depends() between \"ioc \u003d task-\u003eio_context\" and \"if\n (ioc)\". Unfortunately, this doesn\u0027t achieve anything - the latter\n is not a dependent load of the former. ie, if ioc itself were being\n dereferenced \"ioc-\u003exxx\", it would mean something (not sure what tho)\n but as the code currently stands, the dependent read barrier is\n noop.\n\nAs only one of the the two test-assignment sequences is task_lock()\nprotected, the task_lock() can\u0027t do much about race between the two.\nNothing prevents current_io_context() and set_task_ioprio() allocating\nits own ioc for the same task and overwriting the other\u0027s.\n\nAlso, set_task_ioprio() can race with exiting task and create a new\nioc after exit_io_context() is finished.\n\nioc get/put doesn\u0027t have any reason to be complex. The only hot path\nis accessing the existing ioc of %current, which is simple to achieve\ngiven that -\u003eio_context is never destroyed as long as the task is\nalive. All other paths can happily go through task_lock() like all\nother task sub structures without impacting anything.\n\nThis patch updates ioc get/put so that it becomes more conventional.\n\n* alloc_io_context() is replaced with get_task_io_context(). This is\n the only interface which can acquire access to ioc of another task.\n On return, the caller has an explicit reference to the object which\n should be put using put_io_context() afterwards.\n\n* The functionality of current_io_context() remains the same but when\n creating a new ioc, it shares the code path with\n get_task_io_context() and always goes through task_lock().\n\n* get_io_context() now means incrementing ref on an ioc which the\n caller already has access to (be that an explicit refcnt or implicit\n %current one).\n\n* PF_EXITING inhibits creation of new io_context and once\n exit_io_context() is finished, it\u0027s guaranteed that both ioc\n acquisition functions return %NULL.\n\n* All users are updated. Most are trivial but\n smp_read_barrier_depends() removal from cfq_get_io_context() needs a\n bit of explanation. I suppose the original intention was to ensure\n ioc-\u003eioprio is visible when set_task_ioprio() allocates new\n io_context and installs it; however, this wouldn\u0027t have worked\n because set_task_ioprio() doesn\u0027t have wmb between init and install.\n There are other problems with this which will be fixed in another\n patch.\n\n* While at it, use NUMA_NO_NODE instead of -1 for wildcard node\n specification.\n\n-v2: Vivek spotted contamination from debug patch. Removed.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "bb9d97b6dffa10cec5e1ce9adbce60f3c2b5eabc", "tree": "fb8351518fcfb91927e9e138f48284c44553f011", "parents": [ "2f7ee5691eecb67c8108b92001a85563ea336ac5" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Dec 12 18:12:21 2011 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Dec 12 18:12:21 2011 -0800" }, "message": "cgroup: don\u0027t use subsys-\u003ecan_attach_task() or -\u003eattach_task()\n\nNow that subsys-\u003ecan_attach() and attach() take @tset instead of\n@task, they can handle per-task operations. Convert\n-\u003ecan_attach_task() and -\u003eattach_task() users to use -\u003ecan_attach()\nand attach() instead. Most converions are straight-forward.\nNoteworthy changes are,\n\n* In cgroup_freezer, remove unnecessary NULL assignments to unused\n methods. It\u0027s useless and very prone to get out of sync, which\n already happened.\n\n* In cpuset, PF_THREAD_BOUND test is checked for each task. This\n doesn\u0027t make any practical difference but is conceptually cleaner.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nReviewed-by: KAMEZAWA Hiroyuki \u003ckamezawa.hiroyu@jp.fujitsu.com\u003e\nReviewed-by: Frederic Weisbecker \u003cfweisbec@gmail.com\u003e\nAcked-by: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nCc: Paul Menage \u003cpaul@paulmenage.org\u003e\nCc: Balbir Singh \u003cbsingharora@gmail.com\u003e\nCc: Daisuke Nishimura \u003cnishimura@mxp.nes.nec.co.jp\u003e\nCc: James Morris \u003cjmorris@namei.org\u003e\nCc: Ingo Molnar \u003cmingo@elte.hu\u003e\nCc: Peter Zijlstra \u003cpeterz@infradead.org\u003e\n" }, { "commit": "a38eb630fa224d6fba8c14a4063174bc5e0f63bb", "tree": "b86cb5b0aaa4b6d45d798b5155ed2089177f8206", "parents": [ "e060f00beee23568fe2c4faf1e88ff22edefd7b2" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Tue Oct 25 15:48:12 2011 +0200" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Oct 25 15:48:12 2011 +0200" }, "message": "blk-throttle: Take blkcg-\u003elock while traversing blkcg-\u003epolicy_list\n\nblkcg-\u003epolicy_list is protected by blkcg-\u003elock. Its not rcu protected\nlist. So even for readers, they need to take blkcg-\u003elock. There are\nfew functions which were reading the list without taking lock. Fix it.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nAcked-by: Tejun Heo \u003ctj@kernel.org\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "e060f00beee23568fe2c4faf1e88ff22edefd7b2", "tree": "a953ca37996c2010c4e8dda7fbdd76b270a9b4df", "parents": [ "5e08159197b5b98a6648a172008de23f420e6c11" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Tue Oct 25 15:48:12 2011 +0200" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Tue Oct 25 15:48:12 2011 +0200" }, "message": "blk-throttle: Free up policy node associated with deleted rule\n\nIf a rule is being deleted, free up associated policy node. Otherwise\nthat memory is leaked.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nAcked-by: Tejun Heo \u003ctj@kernel.org\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "ece84241b93c4693bfe0a8ec9a043a16d216d0cd", "tree": "4bddd724aaecaf391488d3194d59cef80ef0c9eb", "parents": [ "523e1d399ce0e23bec562abe2b2f8d297af81161" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Oct 19 14:31:15 2011 +0200" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Wed Oct 19 14:31:15 2011 +0200" }, "message": "block: fix genhd refcounting in blkio_policy_parse_and_set()\n\nblkio_policy_parse_and_set() calls blkio_check_dev_num() to check\nwhether the given dev_t is valid. blkio_check_dev_num() uses\nget_gendisk() for verification but never puts the returned genhd\nleaking the reference.\n\nThis patch collapses blkio_check_dev_num() into its caller and updates\nit such that the genhd is put before returning.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "d11bb4462c4cc6ddd45c6927c617ad79fa6fb8fc", "tree": "248949fdd3c8894db0e161e9338a3a984c1ce0f7", "parents": [ "8ad6a56f5679a987bfeacad1bd818a2a381aa98e" ], "author": { "name": "Wanlong Gao", "email": "gaowanlong@cn.fujitsu.com", "time": "Wed Sep 21 10:22:10 2011 +0200" }, "committer": { "name": "Jens Axboe", "email": "axboe@kernel.dk", "time": "Wed Sep 21 10:22:10 2011 +0200" }, "message": "blk-cgroup: be able to remove the record of unplugged device\n\nThe bug is we\u0027re not able to remove the device from blkio cgroup\u0027s\nper-device control files if it gets unplugged.\n\nTo reproduce the bug:\n\n # mount -t cgroup -o blkio xxx /cgroup\n # cd /cgroup\n # echo \"8:0 1000\" \u003e blkio.throttle.read_bps_device\n # unplug the device\n # cat blkio.throttle.read_bps_device\n 8:0\t1000\n # echo \"8:0 0\" \u003e blkio.throttle.read_bps_device\n -bash: echo: write error: No such device\n\nAfter patching, the device removal will succeed.\n\nThanks for the comments of Paul, Zefan, and Vivek.\n\nSigned-off-by: Wanlong Gao \u003cgaowanlong@cn.fujitsu.com\u003e\nCc: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nCc: Paul Menage \u003cpaul@paulmenage.org\u003e\nAcked-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nCc: Jens Axboe \u003caxboe@kernel.dk\u003e\nCc: \u003cstable@kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Jens Axboe \u003caxboe@kernel.dk\u003e\n" }, { "commit": "f780bdb7c1c73009cb57adcf99ef50027d80bf3c", "tree": "d15668ffcc40a2aaa31723b87cfda0b166f84d57", "parents": [ "4714d1d32d97239fb5ae3e10521d3f133a899b66" ], "author": { "name": "Ben Blum", "email": "bblum@andrew.cmu.edu", "time": "Thu May 26 16:25:19 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu May 26 17:12:34 2011 -0700" }, "message": "cgroups: add per-thread subsystem callbacks\n\nAdd cgroup subsystem callbacks for per-thread attachment in atomic contexts\n\nAdd can_attach_task(), pre_attach(), and attach_task() as new callbacks\nfor cgroups\u0027s subsystem interface. Unlike can_attach and attach, these\nare for per-thread operations, to be called potentially many times when\nattaching an entire threadgroup.\n\nAlso, the old \"bool threadgroup\" interface is removed, as replaced by\nthis. All subsystems are modified for the new interface - of note is\ncpuset, which requires from/to nodemasks for attach to be globally scoped\n(though per-cpuset would work too) to persist from its pre_attach to\nattach_task and attach.\n\nThis is a pre-patch for cgroup-procs-writable.patch.\n\nSigned-off-by: Ben Blum \u003cbblum@andrew.cmu.edu\u003e\nCc: \"Eric W. Biederman\" \u003cebiederm@xmission.com\u003e\nCc: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nCc: Matt Helsley \u003cmatthltc@us.ibm.com\u003e\nReviewed-by: Paul Menage \u003cmenage@google.com\u003e\nCc: Oleg Nesterov \u003coleg@redhat.com\u003e\nCc: David Rientjes \u003crientjes@google.com\u003e\nCc: Miao Xie \u003cmiaox@cn.fujitsu.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "317389a7739675aa990b7e0d750a7c435f1d25d7", "tree": "c24b7bb45d03233d76405dab4f9406c05c44eafa", "parents": [ "2abae55f5a41d29f21b5b259c33d218c950d5c90" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Mon May 23 10:02:19 2011 +0200" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Mon May 23 10:02:19 2011 +0200" }, "message": "cfq-iosched: Make IO merge related stats per cpu\n\nMake BLKIO_STAT_MERGED per cpu hence gettring rid of need of taking\nblkg-\u003estats_lock.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "f0bdc8cdd9a2bcc2c84ae2a1fdbff4188b354d8d", "tree": "6d34ecec4cfc29c6032a7b6ce1acbb61088d1787", "parents": [ "575969a0dd3fe65c6556bcb8f87c42303326ea55" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Thu May 19 15:38:30 2011 -0400" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Fri May 20 20:34:53 2011 +0200" }, "message": "blk-cgroup: Make cgroup stat reset path blkg-\u003elock free for dispatch stats\n\nNow dispatch stats update is lock free. But reset of these stats still\ntakes blkg-\u003estats_lock and is dependent on that. As stats are per cpu,\nwe should be able to just reset the stats on each cpu without any locks.\n(Atleast for 64bit arch).\n\nOn 32bit arch there is a small race where 64bit updates are not atomic.\nThe result of this race can be that in the presence of other writers,\none might not get 0 value after reset of a stat and might see something\nintermediate\n\nOne can write more complicated code to cover this race like sending IPI\nto other cpus to reset stats and for offline cpus, reset these directly.\n\nRight not I am not taking that path because reset_update is more of a\ndebug feature and it can happen only on 32bit arch and possibility of\nit happening is small. Will fix it if it becomes a real problem. For\nthe time being going for code simplicity.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "575969a0dd3fe65c6556bcb8f87c42303326ea55", "tree": "0db18fa173b20076e03b5b9c4be4c31c56baa438", "parents": [ "5624a4e445e2ec27582984b068d7bf7f127cee10" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Thu May 19 15:38:29 2011 -0400" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Fri May 20 20:34:53 2011 +0200" }, "message": "blk-cgroup: Make 64bit per cpu stats safe on 32bit arch\n\nSome of the stats are 64bit and updation will be non atomic on 32bit\narchitecture. Use sequence counters on 32bit arch to make reading\nof stats safe.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "5624a4e445e2ec27582984b068d7bf7f127cee10", "tree": "0827c83c6e5f5fa83bd0dadc1bc395c0f0657dae", "parents": [ "4843c69d496a8d2e4caab6182fe016b9a79136e0" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Thu May 19 15:38:28 2011 -0400" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Fri May 20 20:34:52 2011 +0200" }, "message": "blk-throttle: Make dispatch stats per cpu\n\nCurrently we take blkg_stat lock for even updating the stats. So even if\na group has no throttling rules (common case for root group), we end\nup taking blkg_lock, for updating the stats.\n\nMake dispatch stats per cpu so that these can be updated without taking\nblkg lock.\n\nIf cpu goes offline, these stats simply disappear. No protection has\nbeen provided for that yet. Do we really need anything for that?\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "a23e68695593d00b35a6cddf8e9c9ec03505ecb9", "tree": "954a92fb07408e4b7483881f09d2afc91002bc00", "parents": [ "a29a171e7c46c60842b85729280e2f5690372683" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Thu May 19 15:38:20 2011 -0400" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Fri May 20 20:34:52 2011 +0200" }, "message": "blk-cgroup: move some fields of unaccounted_time file under right config option\n\ncgroup unaccounted_time file is created only if CONFIG_DEBUG_BLK_CGROUP\u003dy.\nthere are some fields which are out side this config option. Fix that.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "70087dc38cc77ca8f46059564c00338777734762", "tree": "2ffd5885a12acb44d90d3c3c1a578387bad94a32", "parents": [ "02e352287a40bd456eb78df705bf888bc3161d3f" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Mon May 16 15:24:08 2011 +0200" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Mon May 16 15:24:08 2011 +0200" }, "message": "blk-throttle: Use task_subsys_state() to determine a task\u0027s blkio_cgroup\n\nCurrentlly we first map the task to cgroup and then cgroup to\nblkio_cgroup. There is a more direct way to get to blkio_cgroup\nfrom task using task_subsys_state(). Use that.\n\nThe real reason for the fix is that it also avoids a race in generic\ncgroup code. During remount/umount rebind_subsystems() is called and\nit can do following with and rcu protection.\n\ncgrp-\u003esubsys[i] \u003d NULL;\n\nThat means if somebody got hold of cgroup under rcu and then it tried\nto do cgroup-\u003esubsys[] to get to blkio_cgroup, it would get NULL which\nis wrong. I was running into this race condition with ltp running on a\nupstream derived kernel and that lead to crash.\n\nSo ideally we should also fix cgroup generic code to wait for rcu\ngrace period before setting pointer to NULL. Li Zefan is not very keen\non introducing synchronize_wait() as he thinks it will slow\ndown moun/remount/umount operations.\n\nSo for the time being atleast fix the kernel crash by taking a more\ndirect route to blkio_cgroup.\n\nOne tester had reported a crash while running LTP on a derived kernel\nand with this fix crash is no more seen while the test has been\nrunning for over 6 days.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nReviewed-by: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "25985edcedea6396277003854657b5f3cb31a628", "tree": "f026e810210a2ee7290caeb737c23cb6472b7c38", "parents": [ "6aba74f2791287ec407e0f92487a725a25908067" ], "author": { "name": "Lucas De Marchi", "email": "lucas.demarchi@profusion.mobi", "time": "Wed Mar 30 22:57:33 2011 -0300" }, "committer": { "name": "Lucas De Marchi", "email": "lucas.demarchi@profusion.mobi", "time": "Thu Mar 31 11:26:23 2011 -0300" }, "message": "Fix common misspellings\n\nFixes generated by \u0027codespell\u0027 and manually reviewed.\n\nSigned-off-by: Lucas De Marchi \u003clucas.demarchi@profusion.mobi\u003e\n" }, { "commit": "9026e521c0da0731eb31f9f9022dd00cc3cd8885", "tree": "b2e9f44d22d009efcac6bf4a25a620017ac903a0", "parents": [ "eda5e0c91fed2d2a38a341b0957263406d330274" ], "author": { "name": "Justin TerAvest", "email": "teravest@google.com", "time": "Tue Mar 22 21:26:54 2011 +0100" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Tue Mar 22 21:26:54 2011 +0100" }, "message": "blk-cgroup: Only give unaccounted_time under debug\n\nThis change moves unaccounted_time to only be reported when\nCONFIG_DEBUG_BLK_CGROUP is true.\n\nSigned-off-by: Justin TerAvest \u003cteravest@google.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "167400d34070ebbc408dc0f447c4ddb4bf837360", "tree": "19100b0511a7e3e18f6f61d90a5fe5f1c40f59c4", "parents": [ "1f940bdfc0d03265d178d9dfd840d854819f797d" ], "author": { "name": "Justin TerAvest", "email": "teravest@google.com", "time": "Sat Mar 12 16:54:00 2011 +0100" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Sat Mar 12 16:54:00 2011 +0100" }, "message": "blk-cgroup: Add unaccounted time to timeslice_used.\n\nThere are two kind of times that tasks are not charged for: the first\nseek and the extra time slice used over the allocated timeslice. Both\nof these exported as a new unaccounted_time stat.\n\nI think it would be good to have this reported in \u0027time\u0027 as well, but\nthat is probably a separate discussion.\n\nSigned-off-by: Justin TerAvest \u003cteravest@google.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "bdc85df7a8417b9893443ff5520804699416b6f3", "tree": "7d1158ff87d327934c0c3b0d5ec9b02ed4811de6", "parents": [ "0143832cc96d0bf78486297aad5c8fb2c2ead02a" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Mon Nov 15 19:37:36 2010 +0100" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Mon Nov 15 19:37:36 2010 +0100" }, "message": "blk-cgroup: Allow creation of hierarchical cgroups\n\no Allow hierarchical cgroup creation for blkio controller\n\no Currently we disallow it as both the io controller policies (throttling\n as well as proportion bandwidth) do not support hierarhical accounting\n and control. But the flip side is that blkio controller can not be used with\n libvirt as libvirt creates a cgroup hierarchy deeper than 1 level.\n\n \u003ctop-level-cgroup-dir\u003e/\u003ccontroller\u003e/libvirt/qemu/\u003cvirtual-machine-groups\u003e\n\no So this patch will allow creation of cgroup hierarhcy but at the backend\n everything will be treated as flat. So if somebody created a an hierarchy\n like as follows.\n\n\t\t\troot\n\t\t\t/ \\\n\t\t test1 test2\n\t\t\t|\n\t\t test3\n\n CFQ and throttling will practically treat all groups at same level.\n\n\t\t\t\tpivot\n\t\t\t / | \\ \\\n\t\t\troot test1 test2 test3\n\no Once we have actual support for hierarchical accounting and control\n then we can introduce another cgroup tunable file \"blkio.use_hierarchy\"\n which will be 0 by default but if user wants to enforce hierarhical\n control then it can be set to 1. This way there should not be any\n ABI problems down the line.\n\no The only not so pretty part is introduction of extra file \"use_hierarchy\"\n down the line. Kame-san had mentioned that hierarhical accounting is\n expensive in memory controller hence they keep it off by default. I\n suspect same will be the case for IO controller also as for each IO\n completion we shall have to account IO through hierarchy up to the root.\n if yes, then it probably is not a very bad idea to introduce this extra\n file so that it will be used only when somebody needs it and some people\n might enable hierarchy only in part of the hierarchy.\n\no This is how basically memory controller also uses \"use_hierarhcy\" and\n they also allowed creation of hierarchies when actual backend support\n was not available.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nAcked-by: Balbir Singh \u003cbalbir@linux.vnet.ibm.com\u003e\nReviewed-by: Gui Jianfeng \u003cguijianfeng@cn.fujitsu.com\u003e\nReviewed-by: Ciju Rajan K \u003cciju@linux.vnet.ibm.com\u003e\nTested-by: Ciju Rajan K \u003cciju@linux.vnet.ibm.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "e9dd2b6837e26fe202708cce5ea4bb4ee3e3482e", "tree": "f42fd892495bfc4cbb740d06b016d267c9c42d00", "parents": [ "4f3a29dadaf999a273f1e7fe2476595d0283eef3", "b4627321e18582dcbdeb45d77df29d3177107c65" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Oct 22 17:00:32 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Oct 22 17:00:32 2010 -0700" }, "message": "Merge branch \u0027for-2.6.37/core\u0027 of git://git.kernel.dk/linux-2.6-block\n\n* \u0027for-2.6.37/core\u0027 of git://git.kernel.dk/linux-2.6-block: (39 commits)\n cfq-iosched: Fix a gcc 4.5 warning and put some comments\n block: Turn bvec_k{un,}map_irq() into static inline functions\n block: fix accounting bug on cross partition merges\n block: Make the integrity mapped property a bio flag\n block: Fix double free in blk_integrity_unregister\n block: Ensure physical block size is unsigned int\n blkio-throttle: Fix possible multiplication overflow in iops calculations\n blkio-throttle: limit max iops value to UINT_MAX\n blkio-throttle: There is no need to convert jiffies to milli seconds\n blkio-throttle: Fix link failure failure on i386\n blkio: Recalculate the throttled bio dispatch time upon throttle limit change\n blkio: Add root group to td-\u003etg_list\n blkio: deletion of a cgroup was causes oops\n blkio: Do not export throttle files if CONFIG_BLK_DEV_THROTTLING\u003dn\n block: set the bounce_pfn to the actual DMA limit rather than to max memory\n block: revert bad fix for memory hotplug causing bounces\n Fix compile error in blk-exec.c for !CONFIG_DETECT_HUNG_TASK\n block: set the bounce_pfn to the actual DMA limit rather than to max memory\n block: Prevent hang_check firing during long I/O\n cfq: improve fsync performance for small files\n ...\n\nFix up trivial conflicts due to __rcu sparse annotation in include/linux/genhd.h\n" }, { "commit": "9355aede5a3c4975e0ba8bbfe2b9d1fd73308916", "tree": "73db212009de0e60d71d343b737d6a90449b06b8", "parents": [ "5e901a2b95db709c5e40599ff4df6029be1e2a12" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Fri Oct 01 21:16:41 2010 +0200" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Fri Oct 01 21:16:41 2010 +0200" }, "message": "blkio-throttle: limit max iops value to UINT_MAX\n\n- Limit max iops value to UINT_MAX and return error to user if value is more\n than that instead of accepting bigger values and truncating implicitly.\n\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "fe0714377ee2ca161bf2afb7773e22f15f1786d4", "tree": "09f5e8686d741d012333c92251b8cc66793ef916", "parents": [ "02977e4af7ed3b478c505e50491ffdf3e1314cf4" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Fri Oct 01 14:49:49 2010 +0200" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Fri Oct 01 14:49:49 2010 +0200" }, "message": "blkio: Recalculate the throttled bio dispatch time upon throttle limit change\n\no Currently any cgroup throttle limit changes are processed asynchronousy and\n the change does not take affect till a new bio is dispatched from same group.\n\no It might happen that a user sets a redicuously low limit on throttling.\n Say 1 bytes per second on reads. In such cases simple operations like mount\n a disk can wait for a very long time.\n\no Once bio is throttled, there is no easy way to come out of that wait even if\n user increases the read limit later.\n\no This patch fixes it. Now if a user changes the cgroup limits, we recalculate\n the bio dispatch time according to new limits.\n\no Can\u0027t take queueu lock under blkcg_lock, hence after the change I wake\n up the dispatch thread again which recalculates the time. So there are some\n variables being synchronized across two threads without lock and I had to\n make use of barriers. Hoping I have used barriers correctly. Any review of\n memory barrier code especially will help.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "61014e96e6ed55b8db0af31574eec2a75d4e8755", "tree": "69201251c3c5c51a0ed31dbe595743e60fbdaf52", "parents": [ "13f98250f587b7defa39ed738dfa74b600e46e7b" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Fri Oct 01 14:49:44 2010 +0200" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Fri Oct 01 14:49:44 2010 +0200" }, "message": "blkio: deletion of a cgroup was causes oops\n\no Now a cgroup list of blkg elements can contain blkg from multiple policies.\n Before sending an unlink event, make sure blkg belongs to they policy. If\n policy does not own the blkg, do not send update for this blkg.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "13f98250f587b7defa39ed738dfa74b600e46e7b", "tree": "9d06cb3cd0c8737d1c9289ad6d19e4f4c8ec601f", "parents": [ "efb012b361cf9319cd86ff169afa7550b7aa9336" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Fri Oct 01 14:49:41 2010 +0200" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Fri Oct 01 14:49:41 2010 +0200" }, "message": "blkio: Do not export throttle files if CONFIG_BLK_DEV_THROTTLING\u003dn\n\nCurrently throttling related files were visible even if user had disabled\nthrottling using config options. It was switching off background throttling\nof bio but not the cgroup files. This patch fixes it.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "7702e8f45b0a3bb262b9366c60beb5445758d94c", "tree": "bd61754827def804fe5a1f790f3eb303154df63d", "parents": [ "e43473b7f223ec866f7db273697e76c337c390f9" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Wed Sep 15 17:06:36 2010 -0400" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Thu Sep 16 08:42:58 2010 +0200" }, "message": "blk-cgroup: cgroup changes for IOPS limit support\n\no cgroup changes for IOPS throttling rules.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "4c9eefa16c6f124ffcc736cb719b24ea27f85017", "tree": "0fc333553f66b72c3eb1bd532e45040d90e68f1f", "parents": [ "062a644d6121d5e2f51c0b2ca0cbc5155ebf845b" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Wed Sep 15 17:06:34 2010 -0400" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Thu Sep 16 08:42:12 2010 +0200" }, "message": "blk-cgroup: Introduce cgroup changes for throttling policy\n\no cgroup chagnes for throttle policy.\n\no Introduces READ and WRITE bytes per second throttling rules.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "062a644d6121d5e2f51c0b2ca0cbc5155ebf845b", "tree": "250626a8ee11efa8e598692904e12ac26c29cab5", "parents": [ "af41d7bd9b685ab4e8f930627874ba4f4728e128" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Wed Sep 15 17:06:33 2010 -0400" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Thu Sep 16 08:42:04 2010 +0200" }, "message": "blk-cgroup: Prepare the base for supporting more than one IO control policies\n\no This patch prepares the base for introducing new IO control policies.\n Currently all the code is written knowing there is only one policy\n and that is proportional bandwidth. Creating infrastructure for newer\n policies to come in.\n\no Also there were many functions which were generated using macro. It was\n very confusing. Got rid of those.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "af41d7bd9b685ab4e8f930627874ba4f4728e128", "tree": "f91be30499efd1c39a3417cb19186ecca261ebe2", "parents": [ "38b6f45a97bbb8536cc7d095b577f580bd4d643e" ], "author": { "name": "Vivek Goyal", "email": "vgoyal@redhat.com", "time": "Wed Sep 15 17:06:32 2010 -0400" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Thu Sep 16 08:40:42 2010 +0200" }, "message": "blk-cgroup: Kill the header printed at the start of blkio.weight_device file\n\no Kill extra \"dev weight\" header which is printed when somebody reads\n blkio.weight_device file. This really seems to be out of convention. No other\n blkio files are printing any header at the start of file. I think it is ok\n to just print values and how to interpret values should be part of\n documentation.\n\nSigned-off-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "96aa1b419d47286db446f292cf898bb1a8b27f24", "tree": "1b7a7c5c8131374396df69fd52d02de5de06e978", "parents": [ "9ee47476d6734c9deb9ae9ab05d963302f6b6150" ], "author": { "name": "Ciju Rajan K", "email": "ciju@linux.vnet.ibm.com", "time": "Mon Aug 23 10:56:30 2010 +0200" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Mon Aug 23 10:56:30 2010 +0200" }, "message": "blkio: Fix return code for mkdir calls\n\nIf the cgroup hierarchy for blkio control groups is deeper than two\nlevels, kernel should not allow the creation of further levels. mkdir\nsystem call does not except EINVAL as a return value. This patch\nreplaces EINVAL with more appropriate EPERM\n\nSigned-off-by: Ciju Rajan K \u003cciju@linux.vnet.ibm.com\u003e\nReviewed-by: KAMEZAWA Hiroyuki \u003ckamezawa.hiroyu@jp.fujitsu.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "ee9a3607fb03e804ddf624544105f4e34260c380", "tree": "ce41b6e0fa10982a306f6c142a92dbf3c9961284", "parents": [ "b492e95be0ae672922f4734acf3f5d35c30be948", "d515e86e639890b33a09390d062b0831664f04a2" ], "author": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Fri May 21 21:27:26 2010 +0200" }, "committer": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Fri May 21 21:27:26 2010 +0200" }, "message": "Merge branch \u0027master\u0027 into for-2.6.35\n\nConflicts:\n\tfs/ext3/fsync.c\n\nSigned-off-by: Jens Axboe \u003cjens.axboe@oracle.com\u003e\n" }, { "commit": "0341509fdfc9519f7de6aabc5dd23217cef72b73", "tree": "84415f35129013b9d8fb3f5f0ef266437a02f09c", "parents": [ "dcf097b247affd8b88ad410a92298590c5600f44" ], "author": { "name": "Li Zefan", "email": "lizf@cn.fujitsu.com", "time": "Fri May 07 08:57:00 2010 +0200" }, "committer": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Fri May 07 08:57:00 2010 +0200" }, "message": "blk-cgroup: Fix an RCU warning in blkiocg_create()\n\nwith CONFIG_PROVE_RCU\u003dy, a warning can be triggered:\n\n # mount -t cgroup -o blkio xxx /mnt\n # mkdir /mnt/subgroup\n\n...\nkernel/cgroup.c:4442 invoked rcu_dereference_check() without protection!\n...\n\nTo fix this, we avoid caling css_depth() here, which is a bit simpler\nthan the original code.\n\nSigned-off-by: Li Zefan \u003clizf@cn.fujitsu.com\u003e\nAcked-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nSigned-off-by: Jens Axboe \u003cjens.axboe@oracle.com\u003e\n" } ], "next": "0f3942a39ed768c967cb71ea0e9be7fc94112713" }