)]}' { "log": [ { "commit": "acbbb76a26648dfae6fed0989879e40d75692bfc", "tree": "509620f02e6d86444ea426bc188ba943381e5815", "parents": [ "c56001879bc091eee0c7a8e6e94ea0bea63c3012" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Wed Jan 18 22:32:33 2012 -0600" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Wed Jan 18 22:32:33 2012 -0600" }, "message": "CIFS: Rename *UCS* functions to *UTF16*\n\nto reflect the unicode encoding used by CIFS protocol.\n\nSigned-off-by: Pavel Shilovsky \u003cpiastry@etersoft.ru\u003e\nAcked-by: Jeff Layton \u003cjlayton@samba.org\u003e\nReviewed-by: Shirish Pargaonkar \u003cshirishpargaonkar@gmail.com\u003e\n" }, { "commit": "9c32c63bb70b2fafc3b18bee29959c3bf245ceba", "tree": "06397ec435eaad4e3ba9045bf15ad7ef1f810ae0", "parents": [ "ed6c038c2167bee886291b62a6865f0da825e8a6" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu Nov 10 12:48:20 2011 -0600" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu Nov 10 12:48:20 2011 -0600" }, "message": "cifs: Fix sparse warning when calling cifs_strtoUCS\n\nFix sparse endian check warning while calling cifs_strtoUCS\n\nCHECK fs/cifs/smbencrypt.c\nfs/cifs/smbencrypt.c:216:37: warning: incorrect type in argument 1\n(different base types)\nfs/cifs/smbencrypt.c:216:37: expected restricted __le16 [usertype] *\u003cnoident\u003e\nfs/cifs/smbencrypt.c:216:37: got unsigned short *\u003cnoident\u003e\n\nSigned-off-by: Steve French \u003csmfrench@gmail.com\u003e\nAcked-by: Shirish Pargaonkar \u003cshirishpargaonkar@gmail.com\n" }, { "commit": "9ef5992e442b2b0bf6364bfcc5574e983a983159", "tree": "ffd83c890d6d82c525b6030e49b483fee194a8a9", "parents": [ "5079276066cc421b48a6a63a54a34775979e8506" ], "author": { "name": "Shirish Pargaonkar", "email": "shirishpargaonkar@gmail.com", "time": "Thu Oct 20 13:21:59 2011 -0500" }, "committer": { "name": "Steve French", "email": "smfrench@gmail.com", "time": "Sat Oct 29 22:06:54 2011 -0500" }, "message": "cifs: Assume passwords are encoded according to iocharset (try #2)\n\nRe-posting a patch originally posted by Oskar Liljeblad after\nrebasing on 3.2.\n\nModify cifs to assume that the supplied password is encoded according\nto iocharset. Before this patch passwords would be treated as\nraw 8-bit data, which made authentication with Unicode passwords impossible\n(at least passwords with characters \u003e 0xFF).\n\nThe previous code would as a side effect accept passwords encoded with\nISO 8859-1, since Unicode \u003c 0x100 basically is ISO 8859-1. Software which\nrelies on that will no longer support password chars \u003e 0x7F unless it also\nuses iocharset\u003diso8859-1. (mount.cifs does not care about the encoding so\nit will work as expected.)\n\nSigned-off-by: Oskar Liljeblad \u003coskar@osk.mine.nu\u003e\nSigned-off-by: Shirish Pargaonkar \u003cshirishpargaonkar@gmail.com\u003e\nReviewed-by: Pavel Shilovsky \u003cpiastry@etersoft.ru\u003e\nTested-by: A \u003cnimbus1_03087@yahoo.com\u003e\nSigned-off-by: Steve French \u003csmfrench@gmail.com\u003e\n" }, { "commit": "d02616869221517582dea7972c9b5063ac9a2ae7", "tree": "63768325153cbb945b453492c6176d0da5beb5a0", "parents": [ "3d3ea8e64efbeb3e4289675dbbfab82333395642" ], "author": { "name": "Shirish Pargaonkar", "email": "shirishpargaonkar@gmail.com", "time": "Wed Sep 21 14:33:31 2011 -0500" }, "committer": { "name": "Steve French", "email": "smfrench@gmail.com", "time": "Wed Oct 12 23:42:21 2011 -0500" }, "message": "cifs: clean up unused encryption code\n\nRemove unsed #if 0 encryption code.\n\nSigned-off-by: Shirish Pargaonkar \u003cshirishpargaonkar@gmail.com\u003e\nReviewed-by: Jeff Layton \u003cjlayton@redhat.com\u003e\nSigned-off-by: Steve French \u003csmfrench@gmail.com\u003e\n" }, { "commit": "14cae3243b555afda69a57778069ddca65532c06", "tree": "7aad42f8f9812c9fcbfb2b81709152431eddc6b4", "parents": [ "f5bc1e755d23d022bf948904386337fc3e5e29a8" ], "author": { "name": "Shirish Pargaonkar", "email": "shirishpargaonkar@gmail.com", "time": "Mon Jun 20 16:14:03 2011 -0500" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Mon Jul 25 22:12:10 2011 +0000" }, "message": "cifs: Cleanup: check return codes of crypto api calls\n\nCheck return codes of crypto api calls and either log an error or log\nan error and return from the calling function with error.\n\nSigned-off-by: Shirish Pargaonkar \u003cshirishpargaonkar@gmail.com\u003e\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "e4fb0edb7c03e5ec19b6f732f1dfbe911212dbde", "tree": "1ac0749688ab9e90bdf486db591a24536f9eba86", "parents": [ "5220cc9382e11ca955ce946ee6a5bac577bb14ff" ], "author": { "name": "Jeff Layton", "email": "jlayton@redhat.com", "time": "Mon Jun 20 14:33:16 2011 -0400" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Fri Jun 24 17:03:55 2011 +0000" }, "message": "cifs: free blkcipher in smbhash\n\nThis is currently leaked in the rc \u003d\u003d 0 case.\n\nReported-by: J. Bruce Fields \u003cbfields@fieldses.org\u003e\nSigned-off-by: Jeff Layton \u003cjlayton@redhat.com\u003e\nReviewed-by: Shirish Pargaonkar \u003cshirishpargaonkar@gmail.com\u003e\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "43988d76851077d2945080665e3c4e2e636d700a", "tree": "8fe4d82c49687c47f496803197f2a8736a8e2dfc", "parents": [ "257208736acc694def83627fa0de2892490a5d42" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Tue Apr 19 18:23:31 2011 +0000" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu May 19 14:10:49 2011 +0000" }, "message": "[CIFS] Use ecb des kernel crypto APIs instead of\n local cifs functions (repost)\n\nUsing kernel crypto APIs for DES encryption during LM and NT hash generation\ninstead of local functions within cifs.\nSource file smbdes.c is deleted sans four functions, one of which\nuses ecb des functionality provided by kernel crypto APIs.\n\nRemove function SMBOWFencrypt.\n\nAdd return codes to various functions such as calc_lanman_hash,\nSMBencrypt, and SMBNTencrypt. Includes fix noticed by Dan Carpenter.\n\nSigned-off-by: Shirish Pargaonkar \u003cshirishpargaonkar@gmail.com\u003e\nCC: Dan Carpenter \u003cerror27@gmail.com\u003e\nAcked-by: Jeff Layton \u003cjlayton@redhat.com\u003e\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "ffeb414a59291d5891f09727beb793c109f19f08", "tree": "1880441bc56981be5978d3f86cecb8dbd526af4c", "parents": [ "ee2c9258501f83d3ed0fd09ce5df1cec53312cf0" ], "author": { "name": "Jeff Layton", "email": "jlayton@redhat.com", "time": "Sat Jan 29 07:03:02 2011 -0500" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Mon Jan 31 03:15:57 2011 +0000" }, "message": "cifs: fix two compiler warning about uninitialized vars\n\nfs/cifs/link.c: In function ‘symlink_hash’:\nfs/cifs/link.c:58:3: warning: ‘rc’ may be used uninitialized in this\nfunction [-Wuninitialized]\n\nfs/cifs/smbencrypt.c: In function ‘mdfour’:\nfs/cifs/smbencrypt.c:61:3: warning: ‘rc’ may be used uninitialized in this\nfunction [-Wuninitialized]\n\nReviewed-by: Shirish Pargaonkar \u003cshirishpargaonkar@gmail.com\u003e\nSigned-off-by: Jeff Layton \u003cjlayton@redhat.com\u003e\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "ee2c9258501f83d3ed0fd09ce5df1cec53312cf0", "tree": "2690ab3e75343be23a4969846a0c71f0df842dc7", "parents": [ "d39454ffe4a3c85428483b8a8a8e5e797b6363d5" ], "author": { "name": "Shirish Pargaonkar", "email": "shirishpargaonkar@gmail.com", "time": "Thu Jan 27 09:58:04 2011 -0600" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu Jan 27 19:58:13 2011 +0000" }, "message": "cifs: More crypto cleanup (try #2)\n\nReplaced md4 hashing function local to cifs module with kernel crypto APIs.\nAs a result, md4 hashing function and its supporting functions in\nfile md4.c are not needed anymore.\n\nCleaned up function declarations, removed forward function declarations,\nand removed a header file that is being deleted from being included.\n\nVerified that sec\u003dntlm/i, sec\u003dntlmv2/i, and sec\u003dntlmssp/i work correctly.\n\nSigned-off-by: Shirish Pargaonkar \u003cshirishpargaonkar@gmail.com\u003e\nReviewed-by: Jeff Layton \u003cjlayton@redhat.com\u003e\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "93c100c0b423266c0ee28497e90fdf27c05e6b8e", "tree": "d62879296fdcb482ba4f3995e8e9177f6ec17599", "parents": [ "c723fdab8aa728dc2bf0da6a0de8bb9c3f588d84" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Tue Jan 25 19:28:43 2011 +0000" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Tue Jan 25 19:28:43 2011 +0000" }, "message": "[CIFS] Replace cifs md5 hashing functions with kernel crypto APIs\n\nReplace remaining use of md5 hash functions local to cifs module\nwith kernel crypto APIs.\nRemove header and source file containing those local functions.\n\nSigned-off-by: Shirish Pargaonkar \u003cshirishpargaonkar@gmail.com\u003e\nReviewed-by: Jeff Layton \u003cjlayton@redhat.com\u003e\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "5a0e3ad6af8660be21ca98a971cd00f331318c05", "tree": "5bfb7be11a03176a87296a43ac6647975c00a1d1", "parents": [ "ed391f4ebf8f701d3566423ce8f17e614cde9806" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 24 17:04:11 2010 +0900" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 30 22:02:32 2010 +0900" }, "message": "include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h\n\npercpu.h is included by sched.h and module.h and thus ends up being\nincluded when building most .c files. percpu.h includes slab.h which\nin turn includes gfp.h making everything defined by the two files\nuniversally available and complicating inclusion dependencies.\n\npercpu.h -\u003e slab.h dependency is about to be removed. Prepare for\nthis change by updating users of gfp and slab facilities include those\nheaders directly instead of assuming availability. As this conversion\nneeds to touch large number of source files, the following script is\nused as the basis of conversion.\n\n http://userweb.kernel.org/~tj/misc/slabh-sweep.py\n\nThe script does the followings.\n\n* Scan files for gfp and slab usages and update includes such that\n only the necessary includes are there. ie. if only gfp is used,\n gfp.h, if slab is used, slab.h.\n\n* When the script inserts a new include, it looks at the include\n blocks and try to put the new include such that its order conforms\n to its surrounding. It\u0027s put in the include block which contains\n core kernel includes, in the same order that the rest are ordered -\n alphabetical, Christmas tree, rev-Xmas-tree or at the end if there\n doesn\u0027t seem to be any matching order.\n\n* If the script can\u0027t find a place to put a new include (mostly\n because the file doesn\u0027t have fitting include block), it prints out\n an error message indicating which .h file needs to be added to the\n file.\n\nThe conversion was done in the following steps.\n\n1. The initial automatic conversion of all .c files updated slightly\n over 4000 files, deleting around 700 includes and adding ~480 gfp.h\n and ~3000 slab.h inclusions. The script emitted errors for ~400\n files.\n\n2. Each error was manually checked. Some didn\u0027t need the inclusion,\n some needed manual addition while adding it to implementation .h or\n embedding .c file was more appropriate for others. This step added\n inclusions to around 150 files.\n\n3. The script was run again and the output was compared to the edits\n from #2 to make sure no file was left behind.\n\n4. Several build tests were done and a couple of problems were fixed.\n e.g. lib/decompress_*.c used malloc/free() wrappers around slab\n APIs requiring slab.h to be added manually.\n\n5. The script was run on all .h files but without automatically\n editing them as sprinkling gfp.h and slab.h inclusions around .h\n files could easily lead to inclusion dependency hell. Most gfp.h\n inclusion directives were ignored as stuff from gfp.h was usually\n wildly available and often used in preprocessor macros. Each\n slab.h inclusion directive was examined and added manually as\n necessary.\n\n6. percpu.h was updated not to include slab.h.\n\n7. Build test were done on the following configurations and failures\n were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my\n distributed build env didn\u0027t work with gcov compiles) and a few\n more options had to be turned off depending on archs to make things\n build (like ipr on powerpc/64 which failed due to missing writeq).\n\n * x86 and x86_64 UP and SMP allmodconfig and a custom test config.\n * powerpc and powerpc64 SMP allmodconfig\n * sparc and sparc64 SMP allmodconfig\n * ia64 SMP allmodconfig\n * s390 SMP allmodconfig\n * alpha SMP allmodconfig\n * um on x86_64 SMP allmodconfig\n\n8. percpu.h modifications were reverted so that it could be applied as\n a separate patch and serve as bisection point.\n\nGiven the fact that I had only a couple of failures from tests on step\n6, I\u0027m fairly confident about the coverage of this conversion patch.\nIf there is a breakage, it\u0027s likely to be something in one of the arch\nheaders which should be easily discoverable easily on most builds of\nthe specific arch.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nGuess-its-ok-by: Christoph Lameter \u003ccl@linux-foundation.org\u003e\nCc: Ingo Molnar \u003cmingo@redhat.com\u003e\nCc: Lee Schermerhorn \u003cLee.Schermerhorn@hp.com\u003e\n" }, { "commit": "4e53a3fb98d3d5c2941d2e7199dab317a9d4ead3", "tree": "c3485a826f33e4b6f18b603a475a1bfef7bb7986", "parents": [ "55162dec9371a6f6ac63ff546c182cc6144a649e" ], "author": { "name": "Jeff Layton", "email": "jlayton@redhat.com", "time": "Fri Dec 05 20:41:21 2008 -0500" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Fri Dec 26 02:29:11 2008 +0000" }, "message": "cifs: have calc_lanman_hash take more granular args\n\ncifs: have calc_lanman_hash take more granular args\n\nWe need to use this routine to encrypt passwords associated with the\ntcon too. Don\u0027t assume that the password will be attached to the\nsmb_session.\n\nAlso, make some of the values in the lower encryption functions\nconst since they aren\u0027t changed.\n\nSigned-off-by: Jeff Layton \u003cjlayton@redhat.com\u003e\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "4b18f2a9c3964f7612b7403dddc1d1ba5443ae24", "tree": "6deaca1844706e70e235be6fe502269e4f15355f", "parents": [ "e9f20d6f03e8df393b001dab6dc5226c2a5daf57" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Tue Apr 29 00:06:05 2008 +0000" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Tue Apr 29 00:06:05 2008 +0000" }, "message": "[CIFS] convert usage of implicit booleans to bool\n\nSigned-off-by: Joe Perches \u003cjoe@perches.com\u003e\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "63d2583f5a1a0b72fea3f2171f23f0ca8fa556ec", "tree": "b9dab1514976c462f2d3528f86dd6c3e46fca745", "parents": [ "f1d662a7d5e5322e583aad6b3cfec03d8f27b435" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Mon Nov 05 21:46:10 2007 +0000" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Mon Nov 05 21:46:10 2007 +0000" }, "message": "[CIFS] Fix walking out end of cifs dacl\n\nAcked-by: Shirish Pargaonkar \u003cshirishp@us.ibm.com\u003e\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "630f3f0c45a80ab907d216191ef4a205c249fa1b", "tree": "be1fe069ded6df343f978469160b002c5ae67169", "parents": [ "44093ca2fef3c52dc7d186116862d74f9a676e0f" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu Oct 25 21:17:17 2007 +0000" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu Oct 25 21:17:17 2007 +0000" }, "message": "[CIFS] acl support part 6\n\nAcked-by: Shirish Pargaonkar \u003cshirishp@us.ibm.com\u003e\nCC: Cyrill Gorcunov \u003cgorcunov@gmail.com\u003e\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "50c2f75388727018c3c357454a247072915a9e3f", "tree": "e7c7cd30f1adee51be7af8bda5e937df5c899bc6", "parents": [ "7521a3c566dda7bb09576975324fc0a08a79ad14" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Fri Jul 13 00:33:32 2007 +0000" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Fri Jul 13 00:33:32 2007 +0000" }, "message": "[CIFS] whitespace/formatting fixes\n\nThis should be the last big batch of whitespace/formatting fixes.\ncheckpatch warnings for the cifs directory are down about 90% and\nmany of the remaining ones are harder to remove or make the code\nharder to read.\n\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "790fe579f5006b72dfd2814f9263a73b0b455e81", "tree": "8d0749bb66bcd8993ae66101c6706e0ba432e155", "parents": [ "6dc0f87e351142e224b396f29b59527c4b2d834c" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Sat Jul 07 19:25:05 2007 +0000" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Sat Jul 07 19:25:05 2007 +0000" }, "message": "[CIFS] more whitespace cleanup\n\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "e10847ed499cb86bf8ce12f3a686be8a98f8e140", "tree": "f3767345a5c83b8362736798a350d7bdd3b86c35", "parents": [ "2eaf55862e8eb03999169d84f21eadffc88a36ce" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu Sep 28 20:49:01 2006 +0000" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu Sep 28 20:49:01 2006 +0000" }, "message": "[CIFS] More removing of unused functions\n\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "2eaf55862e8eb03999169d84f21eadffc88a36ce", "tree": "3e30ebdb766ba061f755a7ac6611d77a9c3497e0", "parents": [ "e33c74d06e2b46a5f187ec7f60248da774c84e72" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu Sep 28 20:41:48 2006 +0000" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu Sep 28 20:41:48 2006 +0000" }, "message": "[CIFS] Remove unused prototypes\n\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "2cd646a2d1d5e0e46aa4bb55b1847b0cb35bd855", "tree": "06be4e598e93e5426f32837386187395e592bb0a", "parents": [ "1bd5bbcb6531776a8f73e2cc6287fc4dd542e1c7" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu Sep 28 19:43:08 2006 +0000" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Thu Sep 28 19:43:08 2006 +0000" }, "message": "[CIFS] Remove static and unused symbols\n\nMost cases of the ones found by Shaggy by\n\t\"make namespacecheck\"\ncould be removed or made static\n\nAck: Dave Kleikamp \u003cshaggy@austin.ibm.com\u003e\nSigned-off-by: Steve French \u003csfrench@us.ibm.com\u003e\n" }, { "commit": "3979877e5606ecc58c5a31bd0078c6d80ba9cbe7", "tree": "d221455b5176ea8b26e750d6498c3ed822998ba3", "parents": [ "26a21b980b1897b11fd7f9ba4bf6060c9e15df10" ], "author": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Wed May 31 22:40:51 2006 +0000" }, "committer": { "name": "Steve French", "email": "sfrench@us.ibm.com", "time": "Wed May 31 22:40:51 2006 +0000" }, "message": "[CIFS] Support for setting up SMB sessions to legacy lanman servers\n" }, { "commit": "1da177e4c3f41524e886b7f1b8a0c1fc7321cac2", "tree": "0bba044c4ce775e45a88a51686b5d9f90697ea9d", "parents": [], "author": { "name": "Linus Torvalds", "email": "torvalds@ppc970.osdl.org", "time": "Sat Apr 16 15:20:36 2005 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@ppc970.osdl.org", "time": "Sat Apr 16 15:20:36 2005 -0700" }, "message": "Linux-2.6.12-rc2\n\nInitial git repository build. I\u0027m not bothering with the full history,\neven though we have it. We can create a separate \"historical\" git\narchive of that later if we want to, and in the meantime it\u0027s about\n3.2GB when imported into git - space that would just make the early\ngit days unnecessarily complicated, when we don\u0027t have a lot of good\ninfrastructure for it.\n\nLet it rip!\n" } ] }