)]}' { "log": [ { "commit": "fd2cbd4dfa3db477dd6226d387d3f1911d36a6a9", "tree": "b0ada946d14cdcf5db6da2d177be9590a3449e9a", "parents": [ "1ce8486dcc00c1e095af8d155fa4451936b89013" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Sat Apr 07 11:05:19 2012 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue May 15 23:34:37 2012 +0200" }, "message": "jbd: Write journal superblock with WRITE_FUA after checkpointing\n\nIf journal superblock is written only in disk\u0027s caches and other transaction\nstarts reusing space of the transaction cleaned from the log, it can happen\nblocks of a new transaction reach the disk before journal superblock. When\npower failure happens in such case, subsequent journal replay would still try\nto replay the old transaction but some of it\u0027s blocks may be already\noverwritten by the new transaction. For this reason we must use WRITE_FUA when\nupdating log tail and we must first write new log tail to disk and update\nin-memory information only after that.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "1ce8486dcc00c1e095af8d155fa4451936b89013", "tree": "416fc385dc25993f0a968d1a78fb07dd0b79be34", "parents": [ "9754e39c7bc51328f145e933bfb0df47cd67b6e9" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Sat Apr 07 12:50:13 2012 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue May 15 23:34:36 2012 +0200" }, "message": "jbd: protect all log tail updates with j_checkpoint_mutex\n\nThere are some log tail updates that are not protected by j_checkpoint_mutex.\nSome of these are harmless because they happen during startup or shutdown but\nupdates in journal_commit_transaction() and journal_flush() can really race\nwith other log tail updates (e.g. someone doing journal_flush() with someone\nrunning cleanup_journal_tail()). So protect all log tail updates with\nj_checkpoint_mutex.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "9754e39c7bc51328f145e933bfb0df47cd67b6e9", "tree": "d2fa043f74939d049d6934aea6ab7b1c272be8a5", "parents": [ "f72cf5e223a28d3b3ea7dc9e40464fd534e359e8" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Sat Apr 07 12:33:03 2012 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue May 15 23:34:36 2012 +0200" }, "message": "jbd: Split updating of journal superblock and marking journal empty\n\nThere are three case of updating journal superblock. In the first case, we want\nto mark journal as empty (setting s_sequence to 0), in the second case we want\nto update log tail, in the third case we want to update s_errno. Split these\ncases into separate functions. It makes the code slightly more straightforward\nand later patches will make the distinction even more important.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "2db938bee32e7469ca8ed9bfb3a05535f28c680d", "tree": "7d175a486c2e02270839ba18da61455603c2205e", "parents": [ "923e9a1399b620d063cd88537c64561bc3d5f905" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Feb 21 17:25:37 2011 +0100" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Apr 11 11:12:44 2012 +0200" }, "message": "jbd: Refine commit writeout logic\n\nCurrently we write out all journal buffers in WRITE_SYNC mode. This improves\nperformance for fsync heavy workloads but hinders performance when writes\nare mostly asynchronous, most noticably it slows down readers and users\ncomplain about slow desktop response etc.\n\nSo submit writes as asynchronous in the normal case and only submit writes as\nWRITE_SYNC if we detect someone is waiting for current transaction commit.\n\nI\u0027ve gathered some numbers to back this change. The first is the read latency\ntest. It measures time to read 1 MB after several seconds of sleeping in\npresence of streaming writes.\n\nTop 10 times (out of 90) in us:\nBefore\t\tAfter\n2131586\t\t697473\n1709932\t\t557487\n1564598\t\t535642\n1480462\t\t347573\n1478579\t\t323153\n1408496\t\t222181\n1388960\t\t181273\n1329565\t\t181070\n1252486\t\t172832\n1223265\t\t172278\n\nAverage:\n619377\t\t82180\n\nSo the improvement in both maximum and average latency is massive.\n\nI\u0027ve measured fsync throughput by:\nfs_mark -n 100 -t 1 -s 16384 -d /mnt/fsync/ -S 1 -L 4\n\nin presence of streaming reader. The numbers (fsyncs/s) are:\nBefore\t\tAfter\n9.9\t\t6.3\n6.8\t\t6.0\n6.3\t\t6.2\n5.8\t\t6.1\n\nSo fsync performance seems unharmed by this change.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "c7c66c0cb0c77b1a8edf09bca57d922312d58030", "tree": "77277103c5f16aa4dee64978a060933d92e14776", "parents": [ "9f3938346a5c1fa504647670edb5fea5756cfb00", "98e8bdafeb4728a6af7bbcbcc3984967d1cf2bc1" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Mar 21 10:15:51 2012 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Mar 21 10:15:51 2012 -0700" }, "message": "Merge tag \u0027pm-for-3.4\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm\n\nPull power management updates for 3.4 from Rafael Wysocki:\n \"Assorted extensions and fixes including:\n\n * Introduction of early/late suspend/hibernation device callbacks.\n * Generic PM domains extensions and fixes.\n * devfreq updates from Axel Lin and MyungJoo Ham.\n * Device PM QoS updates.\n * Fixes of concurrency problems with wakeup sources.\n * System suspend and hibernation fixes.\"\n\n* tag \u0027pm-for-3.4\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm: (43 commits)\n PM / Domains: Check domain status during hibernation restore of devices\n PM / devfreq: add relation of recommended frequency.\n PM / shmobile: Make MTU2 driver use pm_genpd_dev_always_on()\n PM / shmobile: Make CMT driver use pm_genpd_dev_always_on()\n PM / shmobile: Make TMU driver use pm_genpd_dev_always_on()\n PM / Domains: Introduce \"always on\" device flag\n PM / Domains: Fix hibernation restore of devices, v2\n PM / Domains: Fix handling of wakeup devices during system resume\n sh_mmcif / PM: Use PM QoS latency constraint\n tmio_mmc / PM: Use PM QoS latency constraint\n PM / QoS: Make it possible to expose PM QoS latency constraints\n PM / Sleep: JBD and JBD2 missing set_freezable()\n PM / Domains: Fix include for PM_GENERIC_DOMAINS\u003dn case\n PM / Freezer: Remove references to TIF_FREEZE in comments\n PM / Sleep: Add more wakeup source initialization routines\n PM / Hibernate: Enable usermodehelpers in hibernate() error path\n PM / Sleep: Make __pm_stay_awake() delete wakeup source timers\n PM / Sleep: Fix race conditions related to wakeup source timer function\n PM / Sleep: Fix possible infinite loop during wakeup source destruction\n PM / Hibernate: print physical addresses consistently with other parts of kernel\n ...\n" }, { "commit": "8fb53c46d9c9322fc5a8e53038ceb0d243059c25", "tree": "7fc80c0f840fd90dd3347de226935a7d0d7c950a", "parents": [ "d93492855ff307ce9d699e36d966af3420b80bb3" ], "author": { "name": "Cong Wang", "email": "amwang@redhat.com", "time": "Fri Nov 25 23:14:31 2011 +0800" }, "committer": { "name": "Cong Wang", "email": "xiyou.wangcong@gmail.com", "time": "Tue Mar 20 21:48:23 2012 +0800" }, "message": "jbd: remove the second argument of k[un]map_atomic()\n\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Cong Wang \u003camwang@redhat.com\u003e\n" }, { "commit": "35c80422afc8394d1ecbab3c0b17fcd539e4e5c2", "tree": "ff01c1ed95ea4ca6656f43e87f29a1a54a633106", "parents": [ "37f08be11be9a7d9351fb1b9b408259519a126f3" ], "author": { "name": "Nigel Cunningham", "email": "nigel@tuxonice.net", "time": "Fri Feb 03 19:59:41 2012 +1100" }, "committer": { "name": "Rafael J. Wysocki", "email": "rjw@sisk.pl", "time": "Tue Mar 13 22:36:44 2012 +0100" }, "message": "PM / Sleep: JBD and JBD2 missing set_freezable()\n\nWith the latest and greatest changes to the freezer, I started seeing\npanics that were caused by jbd2 running post-process freezing and\nhitting the canary BUG_ON for non-TuxOnIce I/O submission. I\u0027ve traced\nthis back to a lack of set_freezable calls in both jbd and jbd2. Since\nthey\u0027re clearly meant to be frozen (there are tests for freezing()), I\nsubmit the following patch to add the missing calls.\n\nSigned-off-by: Nigel Cunningham \u003cnigel@tuxonice.net\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Rafael J. Wysocki \u003crjw@sisk.pl\u003e\n" }, { "commit": "353b67d8ced4dc53281c88150ad295e24bc4b4c5", "tree": "a339a47a9899d01108c6167ffbbefcea07f63912", "parents": [ "e4e11180dfa545233e5145919b75b7fac88638df" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Sat Nov 26 00:35:39 2011 +0100" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Jan 11 13:36:57 2012 +0100" }, "message": "jbd: Issue cache flush after checkpointing\n\nWhen we reach cleanup_journal_tail(), there is no guarantee that\ncheckpointed buffers are on a stable storage - especially if buffers were\nwritten out by log_do_checkpoint(), they are likely to be only in disk\u0027s\ncaches. Thus when we update journal superblock, effectively removing old\ntransaction from journal, this write of superblock can get to stable storage\nbefore those checkpointed buffers which can result in filesystem corruption\nafter a crash.\n\nA similar problem can happen if we replay the journal and wipe it before\nflushing disk\u0027s caches.\n\nThus we must unconditionally issue a cache flush before we update journal\nsuperblock in these cases. The fix is slightly complicated by the fact that we\nhave to get log tail before we issue cache flush but we can store it in the\njournal superblock only after the cache flush. Otherwise we risk races where\nnew tail is written before appropriate cache flush is finished.\n\nI managed to reproduce the corruption using somewhat tweaked Chris Mason\u0027s\nbarrier-test scheduler. Also this should fix occasional reports of \u0027Bit already\nfreed\u0027 filesystem errors which are totally unreproducible but inspection of\nseveral fs images I\u0027ve gathered over time points to a problem like this.\n\nCC: stable@kernel.org\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "ac69e0928054ff29a5049902fb477f9c7605c773", "tree": "05be6b9285186823452e0adeffe40e1dfee6e354", "parents": [ "9e203936eac786f9268d6a13e6442d2accef1829", "302bf2f3259948c93361d501b04a5ed69c3bd4f8" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jan 09 12:51:21 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Jan 09 12:51:21 2012 -0800" }, "message": "Merge branch \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs\n\n* \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs:\n ext2/3/4: delete unneeded includes of module.h\n ext{3,4}: Fix potential race when setversion ioctl updates inode\n udf: Mark LVID buffer as uptodate before marking it dirty\n ext3: Don\u0027t warn from writepage when readonly inode is spotted after error\n jbd: Remove j_barrier mutex\n reiserfs: Force inode evictions before umount to avoid crash\n reiserfs: Fix quota mount option parsing\n udf: Treat symlink component of type 2 as /\n udf: Fix deadlock when converting file from in-ICB one to normal one\n udf: Cleanup calling convention of inode_getblk()\n ext2: Fix error handling on inode bitmap corruption\n ext3: Fix error handling on inode bitmap corruption\n ext3: replace ll_rw_block with other functions\n ext3: NULL dereference in ext3_evict_inode()\n jbd: clear revoked flag on buffers before a new transaction started\n ext3: call ext3_mark_recovery_complete() when recovery is really needed\n" }, { "commit": "0048278552e9752fd578c3d8deee756987c10873", "tree": "0931a7ff6aa5c388eb40e2a97fdcebe59bbae337", "parents": [ "a9e36da655e54545c3289b2a0700b5c443de0edd" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Dec 22 14:52:21 2011 +0100" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Jan 09 13:52:09 2012 +0100" }, "message": "jbd: Remove j_barrier mutex\n\nj_barrier mutex is used for serializing different journal lock operations. The\nproblem with it is that e.g. FIFREEZE ioctl results in process leaving kernel\nwith j_barrier mutex held which makes lockdep freak out. Also hibernation code\nwants to freeze filesystem but it cannot do so because it then cannot hibernate\nthe system because of mutex being locked.\n\nSo we remove j_barrier mutex and use direct wait on j_barrier_count instead.\nSince locking journal is a rare operation we don\u0027t have to care about fairness\nor such things.\n\nCC: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nAcked-by: Joel Becker \u003cjlbec@evilplan.org\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "98793265b429a3f0b3f1750e74d67cd4d740d162", "tree": "b0bd717673f0c21845cf053f3fb6b75d42530af5", "parents": [ "b4a133da2eaccb844a7beaef16ffd9c76a0d21d3", "bd1b2a555952d959f47169056fca05acf7eff81f" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Jan 08 13:21:22 2012 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Sun Jan 08 13:21:22 2012 -0800" }, "message": "Merge branch \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial\n\n* \u0027for-linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (53 commits)\n Kconfig: acpi: Fix typo in comment.\n misc latin1 to utf8 conversions\n devres: Fix a typo in devm_kfree comment\n btrfs: free-space-cache.c: remove extra semicolon.\n fat: Spelling s/obsolate/obsolete/g\n SCSI, pmcraid: Fix spelling error in a pmcraid_err() call\n tools/power turbostat: update fields in manpage\n mac80211: drop spelling fix\n types.h: fix comment spelling for \u0027architectures\u0027\n typo fixes: aera -\u003e area, exntension -\u003e extension\n devices.txt: Fix typo of \u0027VMware\u0027.\n sis900: Fix enum typo \u0027sis900_rx_bufer_status\u0027\n decompress_bunzip2: remove invalid vi modeline\n treewide: Fix comment and string typo \u0027bufer\u0027\n hyper-v: Update MAINTAINERS\n treewide: Fix typos in various parts of the kernel, and fix some comments.\n clockevents: drop unknown Kconfig symbol GENERIC_CLOCKEVENTS_MIGR\n gpio: Kconfig: drop unknown symbol \u0027CS5535_GPIO\u0027\n leds: Kconfig: Fix typo \u0027D2NET_V2\u0027\n sound: Kconfig: drop unknown symbol ARCH_CLPS7500\n ...\n\nFix up trivial conflicts in arch/powerpc/platforms/40x/Kconfig (some new\nkconfig additions, close to removed commented-out old ones)\n" }, { "commit": "90802ed9c3dbab2e067bd9fc67a30e66e6774e8f", "tree": "ac379380a669ad3c2a7ab0c3d923f1e9644ae885", "parents": [ "05183189ee5df8799b22c56d93f0f69b8490e33f" ], "author": { "name": "Paul Bolle", "email": "pebolle@tiscali.nl", "time": "Mon Dec 05 13:00:34 2011 +0100" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Tue Dec 06 09:53:40 2011 +0100" }, "message": "treewide: Fix comment and string typo \u0027bufer\u0027\n\nSigned-off-by: Paul Bolle \u003cpebolle@tiscali.nl\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "8c111b3f56332a216b18cd57950bdf04ac8f2a98", "tree": "9295744be006082391c9bfeed2cabf43b29cc4ea", "parents": [ "63894ab9f63a688f6b0b8cdd01ac0a9f36d507b8" ], "author": { "name": "Yongqiang Yang", "email": "xiaoqiangnk@gmail.com", "time": "Sat Nov 19 17:34:29 2011 +0800" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue Nov 22 01:20:53 2011 +0100" }, "message": "jbd: clear revoked flag on buffers before a new transaction started\n\nCurrently, we clear revoked flag only when a block is reused. However,\nthis can tigger a false journal error. Consider a situation when a block\nis used as a meta block and is deleted(revoked) in ordered mode, then the\nblock is allocated as a data block to a file. At this moment, user changes\nthe file\u0027s journal mode from ordered to journaled and truncates the file.\nThe block will be considered re-revoked by journal because it has revoked\nflag still pending from the last transaction and an assertion triggers.\n\nWe fix the problem by keeping the revoked status more uptodate - we clear\nrevoked flag when switching revoke tables to reflect there is no revoked\nbuffers in current transaction any more.\n\nSigned-off-by: Yongqiang Yang \u003cxiaoqiangnk@gmail.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "a0acae0e886d44bd5ce6d2f173c1ace0fcf0d9f6", "tree": "0b763388360a5a9043986e1f2201e43df74ebc46", "parents": [ "3a7cbd50f74907580eb47a8d08e1f29741b81abf" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Nov 21 12:32:22 2011 -0800" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Mon Nov 21 12:32:22 2011 -0800" }, "message": "freezer: unexport refrigerator() and update try_to_freeze() slightly\n\nThere is no reason to export two functions for entering the\nrefrigerator. Calling refrigerator() instead of try_to_freeze()\ndoesn\u0027t save anything noticeable or removes any race condition.\n\n* Rename refrigerator() to __refrigerator() and make it return bool\n indicating whether it scheduled out for freezing.\n\n* Update try_to_freeze() to return bool and relay the return value of\n __refrigerator() if freezing().\n\n* Convert all refrigerator() users to try_to_freeze().\n\n* Update documentation accordingly.\n\n* While at it, add might_sleep() to try_to_freeze().\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nCc: Samuel Ortiz \u003csamuel@sortiz.org\u003e\nCc: Chris Mason \u003cchris.mason@oracle.com\u003e\nCc: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nCc: Steven Whitehouse \u003cswhiteho@redhat.com\u003e\nCc: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nCc: Jan Kara \u003cjack@suse.cz\u003e\nCc: KONISHI Ryusuke \u003ckonishi.ryusuke@lab.ntt.co.jp\u003e\nCc: Christoph Hellwig \u003chch@infradead.org\u003e\n" }, { "commit": "8762202dd0d6e46854f786bdb6fb3780a1625efe", "tree": "0fe3a7e102bfefa0bbb5810f934fbf93840459dd", "parents": [ "bf52c6f7af55c48ab0fd5f990460b884b428d906" ], "author": { "name": "Eryu Guan", "email": "guaneryu@gmail.com", "time": "Tue Nov 01 19:04:59 2011 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Nov 01 19:04:59 2011 -0400" }, "message": "jbd/jbd2: validate sb-\u003es_first in journal_get_superblock()\n\nI hit a J_ASSERT(blocknr !\u003d 0) failure in cleanup_journal_tail() when\nmounting a fsfuzzed ext3 image. It turns out that the corrupted ext3\nimage has s_first \u003d 0 in journal superblock, and the 0 is passed to\njournal-\u003ej_head in journal_reset(), then to blocknr in\ncleanup_journal_tail(), in the end the J_ASSERT failed.\n\nSo validate s_first after reading journal superblock from disk in\njournal_get_superblock() to ensure s_first is valid.\n\nThe following script could reproduce it:\n\nfstype\u003dext3\nblocksize\u003d1024\nimg\u003d$fstype.img\noffset\u003d0\nfound\u003d0\nmagic\u003d\"c0 3b 39 98\"\n\ndd if\u003d/dev/zero of\u003d$img bs\u003d1M count\u003d8\nmkfs -t $fstype -b $blocksize -F $img\nfilesize\u003d`stat -c %s $img`\nwhile [ $offset -lt $filesize ]\ndo\n if od -j $offset -N 4 -t x1 $img | grep -i \"$magic\";then\n echo \"Found journal: $offset\"\n found\u003d1\n break\n fi\n offset\u003d`echo \"$offset+$blocksize\" | bc`\ndone\n\nif [ $found -ne 1 ];then\n echo \"Magic \\\"$magic\\\" not found\"\n exit 1\nfi\n\ndd if\u003d/dev/zero of\u003d$img seek\u003d$(($offset+23)) conv\u003dnotrunc bs\u003d1 count\u003d1\n\nmkdir -p ./mnt\nmount -o loop $img ./mnt\n\nCc: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Eryu Guan \u003cguaneryu@gmail.com\u003e\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "a212d1a71deea10ba4f6de2aaac0221be34ddb29", "tree": "72e29079ed4ff990219b7b98fd8fa89230605962", "parents": [ "bb189247f35688a3353545902c56290fb7d7754a" ], "author": { "name": "Tao Ma", "email": "boyu.mt@taobao.com", "time": "Tue Jun 07 11:56:50 2011 +0800" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue Jun 28 00:06:41 2011 +0200" }, "message": "jbd: Use WRITE_SYNC in journal checkpoint.\n\nIn journal checkpoint, we write the buffer and wait for its finish.\nBut in cfq, the async queue has a very low priority, and in our test,\nif there are too many sync queues and every queue is filled up with\nrequests, and the process will hang waiting for the log space.\n\nSo this patch tries to use WRITE_SYNC in __flush_batch so that the request will\nbe moved into sync queue and handled by cfq timely. We also use the new plug,\nsot that all the WRITE_SYNC requests can be given as a whole when we unplug it.\n\nReported-by: Robin Dong \u003csanbai@taobao.com\u003e\nSigned-off-by: Tao Ma \u003cboyu.mt@taobao.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "bb189247f35688a3353545902c56290fb7d7754a", "tree": "02f93da7f642f3e59050d1c2837a7a8a8e61b3aa", "parents": [ "2c2ea9451fc2a12ee57c8346f0da26969d07ee7f" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Fri Jun 24 23:11:59 2011 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Jun 27 11:44:37 2011 +0200" }, "message": "jbd: Fix oops in journal_remove_journal_head()\n\njournal_remove_journal_head() can oops when trying to access journal_head\nreturned by bh2jh(). This is caused for example by the following race:\n\n\tTASK1\t\t\t\t\tTASK2\n journal_commit_transaction()\n ...\n processing t_forget list\n __journal_refile_buffer(jh);\n if (!jh-\u003eb_transaction) {\n jbd_unlock_bh_state(bh);\n\t\t\t\t\tjournal_try_to_free_buffers()\n\t\t\t\t\t journal_grab_journal_head(bh)\n\t\t\t\t\t jbd_lock_bh_state(bh)\n\t\t\t\t\t __journal_try_to_free_buffer()\n\t\t\t\t\t journal_put_journal_head(jh)\n journal_remove_journal_head(bh);\n\njournal_put_journal_head() in TASK2 sees that b_jcount \u003d\u003d 0 and buffer is not\npart of any transaction and thus frees journal_head before TASK1 gets to doing\nso. Note that even buffer_head can be released by try_to_free_buffers() after\njournal_put_journal_head() which adds even larger opportunity for oops (but I\ndidn\u0027t see this happen in reality).\n\nFix the problem by making transactions hold their own journal_head reference\n(in b_jcount). That way we don\u0027t have to remove journal_head explicitely via\njournal_remove_journal_head() and instead just remove journal_head when\nb_jcount drops to zero. The result of this is that [__]journal_refile_buffer(),\n[__]journal_unfile_buffer(), and __journal_remove_checkpoint() can free\njournal_head which needs modification of a few callers. Also we have to be\ncareful because once journal_head is removed, buffer_head might be freed as\nwell. So we have to get our own buffer_head reference where it matters.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "bd5c9e1854e13d0c62a3de29a5fbc15dd6a4d8c6", "tree": "7ae5b23da18582e469353f5dee35efa93fb36ff0", "parents": [ "05713082ab7690a2b22b044cfc867f346c39cd2d" ], "author": { "name": "Ding Dinghua", "email": "dingdinghua@nrchpc.ac.cn", "time": "Thu May 26 10:29:01 2011 +0800" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Sat Jun 25 17:29:51 2011 +0200" }, "message": "jbd: fix a bug of leaking jh-\u003eb_jcount\n\njournal_get_create_access should drop jh-\u003eb_jcount in error handling path\n\nSigned-off-by: Ding Dinghua \u003cdingdinghua@nrchpc.ac.cn\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "05713082ab7690a2b22b044cfc867f346c39cd2d", "tree": "d69117ce69b53c5c51011595def5664210513437", "parents": [ "40680f2fa4670ab35ee554822a69dda1a118f966" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu May 26 17:17:18 2011 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Sat Jun 25 17:29:51 2011 +0200" }, "message": "jbd: remove dependency on __GFP_NOFAIL\n\nThe callers of start_this_handle() (or better ext3_journal_start()) are not\nreally prepared to handle allocation failures. Such failures can for example\nresult in silent data loss when it happens in ext3_..._writepage(). OTOH\n__GFP_NOFAIL is going away so we just retry allocation in start_this_handle().\n\nThis loop is potentially dangerous because the oom killer cannot be invoked\nfor GFP_NOFS allocation, so there is a potential for infinitely looping.\nBut still this is better than silent data loss.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "99cb1a318c37bf462c53d43f4dacb7b4896ce0c9", "tree": "32a9046649777e8cc589bbc8e0afb382642ba450", "parents": [ "785c4bcc0d88ff006a0b2120815a71e86ecf21ce" ], "author": { "name": "Lukas Czerner", "email": "lczerner@redhat.com", "time": "Mon May 23 18:33:02 2011 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Sat Jun 25 17:29:51 2011 +0200" }, "message": "jbd: Add fixed tracepoints\n\nThis commit adds fixed tracepoint for jbd. It has been based on fixed\ntracepoints for jbd2, however there are missing those for collecting\nstatistics, since I think that it will require more intrusive patch so I\nshould have its own commit, if someone decide that it is needed. Also\nthere are new tracepoints in __journal_drop_transaction() and\njournal_update_superblock().\n\nThe list of jbd tracepoints:\n\njbd_checkpoint\njbd_start_commit\njbd_commit_locking\njbd_commit_flushing\njbd_commit_logging\njbd_drop_transaction\njbd_end_commit\njbd_do_submit_data\njbd_cleanup_journal_tail\njbd_update_superblock_end\n\nSigned-off-by: Lukas Czerner \u003clczerner@redhat.com\u003e\nCc: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "c2b67735e5d3a419e90047b3f4179e54a39637bc", "tree": "2b73b4e11f292f6651c5da06bc488de57592a5b2", "parents": [ "9199e66528f61a06abe09f0589bbe1eecaa301a7" ], "author": { "name": "Eryu Guan", "email": "guaneryu@gmail.com", "time": "Tue May 24 00:17:34 2011 +0800" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue May 24 00:27:53 2011 +0200" }, "message": "jbd: Fix comment to match the code in journal_start()\n\njournal_start returns an ERR_PTR() value rather than NULL on failure.\n\nCc: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Eryu Guan \u003cguaneryu@gmail.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "9199e66528f61a06abe09f0589bbe1eecaa301a7", "tree": "9638e08371e859fcf38d6bc407859f09a0164a30", "parents": [ "2842bb20eed2e25cde5114298edc62c8883a1d9a" ], "author": { "name": "Tao Ma", "email": "boyu.mt@taobao.com", "time": "Thu May 05 23:54:19 2011 +0800" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue May 17 13:47:42 2011 +0200" }, "message": "jbd/jbd2: remove obsolete summarise_journal_usage.\n\nsummarise_journal_usage seems to be obsolete for a long time,\nso remove it.\n\nCc: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Tao Ma \u003cboyu.mt@taobao.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "2842bb20eed2e25cde5114298edc62c8883a1d9a", "tree": "af4d60d1e5e922f836ec5de3bc6f433fbb947ef2", "parents": [ "4e299c1d9113b5c1c3845c0d4e78d09dd60a4fe8" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu May 05 13:59:35 2011 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue May 17 13:47:42 2011 +0200" }, "message": "jbd: Fix forever sleeping process in do_get_write_access()\n\nIn do_get_write_access() we wait on BH_Unshadow bit for buffer to get\nfrom shadow state. The waking code in journal_commit_transaction() has\na bug because it does not issue a memory barrier after the buffer is moved\nfrom the shadow state and before wake_up_bit() is called. Thus a waitqueue\ncheck can happen before the buffer is actually moved from the shadow state\nand waiting process may never be woken. Fix the problem by issuing proper\nbarrier.\n\nCC: stable@kernel.org\nReported-by: Tao Ma \u003cboyu.mt@taobao.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "d9b01934d56a96d9f4ae2d6204d4ea78a36f5f36", "tree": "56a34d3c459bfac781b8f71d866caa7dd092b7c2", "parents": [ "86c4f6d85595cd7da635dc6985d27bfa43b1ae10" ], "author": { "name": "Ted Ts\u0027o", "email": "tytso@mit.edu", "time": "Sat Apr 30 13:17:11 2011 -0400" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue May 17 13:47:41 2011 +0200" }, "message": "jbd: fix fsync() tid wraparound bug\n\nIf an application program does not make any changes to the indirect\nblocks or extent tree, i_datasync_tid will not get updated. If there\nare enough commits (i.e., 2**31) such that tid_geq()\u0027s calculations\nwrap, and there isn\u0027t a currently active transaction at the time of\nthe fdatasync() call, this can end up triggering a BUG_ON in\nfs/jbd/commit.c:\n\n\tJ_ASSERT(journal-\u003ej_running_transaction !\u003d NULL);\n\nIt\u0027s pretty rare that this can happen, since it requires the use of\nfdatasync() plus *very* frequent and excessive use of fsync(). But\nwith the right workload, it can.\n\nWe fix this by replacing the use of tid_geq() with an equality test,\nsince there\u0027s only one valid transaction id that is valid for us to\nstart: namely, the currently running transaction (if it exists).\n\nCC: stable@kernel.org\nReported-by: Martin_Zielinski@McAfee.com\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "25985edcedea6396277003854657b5f3cb31a628", "tree": "f026e810210a2ee7290caeb737c23cb6472b7c38", "parents": [ "6aba74f2791287ec407e0f92487a725a25908067" ], "author": { "name": "Lucas De Marchi", "email": "lucas.demarchi@profusion.mobi", "time": "Wed Mar 30 22:57:33 2011 -0300" }, "committer": { "name": "Lucas De Marchi", "email": "lucas.demarchi@profusion.mobi", "time": "Thu Mar 31 11:26:23 2011 -0300" }, "message": "Fix common misspellings\n\nFixes generated by \u0027codespell\u0027 and manually reviewed.\n\nSigned-off-by: Lucas De Marchi \u003clucas.demarchi@profusion.mobi\u003e\n" }, { "commit": "6c5103890057b1bb781b26b7aae38d33e4c517d8", "tree": "e6e57961dcddcb5841acb34956e70b9dc696a880", "parents": [ "3dab04e6978e358ad2307bca563fabd6c5d2c58b", "9d2e157d970a73b3f270b631828e03eb452d525e" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Mar 24 10:16:26 2011 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Mar 24 10:16:26 2011 -0700" }, "message": "Merge branch \u0027for-2.6.39/core\u0027 of git://git.kernel.dk/linux-2.6-block\n\n* \u0027for-2.6.39/core\u0027 of git://git.kernel.dk/linux-2.6-block: (65 commits)\n Documentation/iostats.txt: bit-size reference etc.\n cfq-iosched: removing unnecessary think time checking\n cfq-iosched: Don\u0027t clear queue stats when preempt.\n blk-throttle: Reset group slice when limits are changed\n blk-cgroup: Only give unaccounted_time under debug\n cfq-iosched: Don\u0027t set active queue in preempt\n block: fix non-atomic access to genhd inflight structures\n block: attempt to merge with existing requests on plug flush\n block: NULL dereference on error path in __blkdev_get()\n cfq-iosched: Don\u0027t update group weights when on service tree\n fs: assign sb-\u003es_bdi to default_backing_dev_info if the bdi is going away\n block: Require subsystems to explicitly allocate bio_set integrity mempool\n jbd2: finish conversion from WRITE_SYNC_PLUG to WRITE_SYNC and explicit plugging\n jbd: finish conversion from WRITE_SYNC_PLUG to WRITE_SYNC and explicit plugging\n fs: make fsync_buffers_list() plug\n mm: make generic_writepages() use plugging\n blk-cgroup: Add unaccounted time to timeslice_used.\n block: fixup plugging stubs for !CONFIG_BLOCK\n block: remove obsolete comments for blkdev_issue_zeroout.\n blktrace: Use rq-\u003ecmd_flags directly in blk_add_trace_rq.\n ...\n\nFix up conflicts in fs/{aio.c,super.c}\n" }, { "commit": "65ab80279d7c323ce151e858d951e2684df72a97", "tree": "b00d0400360e11dd337a701ffbb66d097894da2b", "parents": [ "4ee2491ed8569f370bf4c1a4c046a6efb8032bd2" ], "author": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Thu Mar 17 10:56:45 2011 +0100" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Thu Mar 17 10:56:45 2011 +0100" }, "message": "jbd: finish conversion from WRITE_SYNC_PLUG to WRITE_SYNC and explicit plugging\n\n\u0027write_op\u0027 was still used, even though it was always WRITE_SYNC now.\nAdd plugging around the cases where it submits IO, and flush them\nbefore we end up waiting for that IO.\n\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "721a9602e6607417c6bc15b18e97a2f35266c690", "tree": "4987991e43f35b8b3b685fea0040c5265b578996", "parents": [ "cf15900e1209d5b46ec2d24643adbf561830935f" ], "author": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Wed Mar 09 11:56:30 2011 +0100" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Thu Mar 10 08:52:27 2011 +0100" }, "message": "block: kill off REQ_UNPLUG\n\nWith the plugging now being explicitly controlled by the\nsubmitter, callers need not pass down unplugging hints\nto the block layer. If they want to unplug, it\u0027s because they\nmanually plugged on their own - in which case, they should just\nunplug at will.\n\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "3c26bdb42320f9f39d30c6f115476bbb66b74dc5", "tree": "464b9ce0d2eb1875ef7cb676d5ec4f25645934a9", "parents": [ "ce654b37f87980d95f339080e4c3bdb2370bdf22" ], "author": { "name": "Justin P. Mattock", "email": "justinmattock@gmail.com", "time": "Sat Feb 26 20:34:05 2011 -0800" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Feb 28 21:55:58 2011 +0100" }, "message": "jbd: Remove one to many n\u0027s in a word.\n\nThe Patch below removes one to many \"n\u0027s\" in a word..\n\nSigned-off-by: Justin P. Mattock \u003cjustinmattock@gmail.com\u003e\nCC: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nCC: linux-ext4@vger.kernel.org\nAcked-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "a34f0b31398020e2d3be653eb695bd17a9cf3b55", "tree": "a049085d3b21a55f3138ed2cc78552cad828748d", "parents": [ "dac36dd87de10d1fd81dc7b7a40256cb2e965abc" ], "author": { "name": "Uwe Kleine-König", "email": "u.kleine-koenig@pengutronix.de", "time": "Fri Dec 10 14:55:42 2010 +0100" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Fri Dec 10 16:04:28 2010 +0100" }, "message": "fix comment typos concerning \"consistent\"\n\nSigned-off-by: Uwe Kleine-König \u003cu.kleine-koenig@pengutronix.de\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "7d2f280e75f05919314e250cadf361a327ed555c", "tree": "47db5a9a0ceaf31adf49c18b663b1e08184f7cff", "parents": [ "e3e1288e86a07cdeb0aee5860a2dff111c6eff79", "4408ea41c0ab4b711d4da44dd954fb06dce6c3f8" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Oct 27 20:13:18 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Oct 27 20:13:18 2010 -0700" }, "message": "Merge branch \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs-2.6\n\n* \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs-2.6: (24 commits)\n quota: Fix possible oops in __dquot_initialize()\n ext3: Update kernel-doc comments\n jbd/2: fixed typos\n ext2: fixed typo.\n ext3: Fix debug messages in ext3_group_extend()\n jbd: Convert atomic_inc() to get_bh()\n ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate()\n jbd: Fix debug message in do_get_write_access()\n jbd: Check return value of __getblk()\n ext3: Use DIV_ROUND_UP() on group desc block counting\n ext3: Return proper error code on ext3_fill_super()\n ext3: Remove unnecessary casts on bh-\u003eb_data\n ext3: Cleanup ext3_setup_super()\n quota: Fix issuing of warnings from dquot_transfer\n quota: fix dquot_disable vs dquot_transfer race v2\n jbd: Convert bitops to buffer fns\n ext3/jbd: Avoid WARN() messages when failing to write the superblock\n jbd: Use offset_in_page() instead of manual calculation\n jbd: Remove unnecessary goto statement\n jbd: Use printk_ratelimited() in journal_alloc_journal_head()\n ...\n" }, { "commit": "bcf3d0bcff9c2ab5794d9a2c5f0ebc9ce63cc63f", "tree": "e52f9059e1d0aab064a7a40dd214bab0e64e09d0", "parents": [ "58c6ed38a16cd235588ed4a5ca3b213f055bc14c" ], "author": { "name": "Andrea Gelmini", "email": "andrea.gelmini@gelma.net", "time": "Sat Oct 16 15:19:14 2010 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Oct 28 01:30:05 2010 +0200" }, "message": "jbd/2: fixed typos\n\n\"wakup\"\n\nSigned-off-by: Andrea Gelmini \u003candrea.gelmini@gelma.net\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "e4d5e3a497e159be7c2dbe4c61cfb185d60cfde2", "tree": "fdc0fda2f6baf45fac8f572936dd5828b301308a", "parents": [ "bfa01dfbe0a02f5ba434221c351f0510c06af392" ], "author": { "name": "Namhyung Kim", "email": "namhyung@gmail.com", "time": "Sat Oct 16 17:11:02 2010 +0900" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Oct 28 01:30:05 2010 +0200" }, "message": "jbd: Convert atomic_inc() to get_bh()\n\nConvert atomic_inc(\u0026bh-\u003eb_count) to get_bh(bh) for consistency.\n\nSigned-off-by: Namhyung Kim \u003cnamhyung@gmail.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "b8ea49fa9baff99523aa51e680e76e8ccb5f25f3", "tree": "e613397c1e8372c2c7e0352b5b5041f0727bc022", "parents": [ "2a0e33889b3f5e3c270dd1b746f4c0a75efa4790" ], "author": { "name": "Namhyung Kim", "email": "namhyung@gmail.com", "time": "Wed Oct 13 23:14:07 2010 +0900" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Oct 28 01:30:04 2010 +0200" }, "message": "jbd: Fix debug message in do_get_write_access()\n\n\u0027buffer_head\u0027 should be \u0027journal_head\u0027.\n\nSigned-off-by: Namhyung Kim \u003cnamhyung@gmail.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "2a0e33889b3f5e3c270dd1b746f4c0a75efa4790", "tree": "322394e75daccaf692a4adb388efa596a231a59b", "parents": [ "81a4e320e6ee29bde3fe880ab87b2122bc1de88b" ], "author": { "name": "Namhyung Kim", "email": "namhyung@gmail.com", "time": "Wed Oct 13 17:17:18 2010 +0900" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Oct 28 01:30:04 2010 +0200" }, "message": "jbd: Check return value of __getblk()\n\nFail journal creation if __getblk() returns NULL. unlikely() is\nadded because it is called in a loop and we\u0027ve been OK without\nthe check until now.\n\nSigned-off-by: Namhyung Kim \u003cnamhyung@gmail.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "a910eefa511f9d1118effc13fba6773163502c4f", "tree": "c041e592875a0048ca0c39fa8ea3ec9c5f03ff19", "parents": [ "dff6825e9fde93891e60751e01480337a991235e" ], "author": { "name": "Namhyung Kim", "email": "namhyung@gmail.com", "time": "Fri Oct 08 20:05:06 2010 +0900" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Oct 28 01:30:02 2010 +0200" }, "message": "jbd: Convert bitops to buffer fns\n\nConvert set/clear_bit(BH_JWrite, ...) to set/clear_buffer_jwrite()\nfor consistency.\n\nSigned-off-by: Namhyung Kim \u003cnamhyung@gmail.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "dff6825e9fde93891e60751e01480337a991235e", "tree": "3b243584ee48752096b110c04ecd803e285325ae", "parents": [ "8117f98c058dbe463eaba2b51b84d19bd5d78804" ], "author": { "name": "Darrick J. Wong", "email": "djwong@us.ibm.com", "time": "Mon Oct 04 12:35:05 2010 -0700" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Oct 28 01:30:02 2010 +0200" }, "message": "ext3/jbd: Avoid WARN() messages when failing to write the superblock\n\nThis fixes a WARN backtrace in mark_buffer_dirty() that occurs during unmount\nwhen the underlying block device is removed. This bug has been seen on System\nZ when removing all paths from a multipath-backed ext3 mount; on System P when\ninjecting enough PCI EEH errors to make the SCSI controller go offline; and\nsimilar warnings have been seen (and patched) with ext2/ext4.\n\nThe super block update from a previous operation has marked the buffer as in\nerror, and the flag has to be cleared before doing the update. Similar changes\nhave been made to ext4 by commit 914258bf2cb22bf4336a1b1d90c551b4b11ca5aa.\n\nSigned-off-by: Darrick J. Wong \u003cdjwong@us.ibm.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "8117f98c058dbe463eaba2b51b84d19bd5d78804", "tree": "5388a8183faff48ac48105396d55fec255c93185", "parents": [ "2b23976908d9f8406f8b10b86c83b2cee302bc7d" ], "author": { "name": "Namhyung Kim", "email": "namhyung@gmail.com", "time": "Tue Oct 05 01:03:40 2010 +0900" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Oct 28 01:30:02 2010 +0200" }, "message": "jbd: Use offset_in_page() instead of manual calculation\n\nSigned-off-by: Namhyung Kim \u003cnamhyung@gmail.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "2b23976908d9f8406f8b10b86c83b2cee302bc7d", "tree": "dc1e2039bfb7a89bc981f7c2f9f350c57ad26412", "parents": [ "f81e3d4564a06c5a070337ba527d11865acecb67" ], "author": { "name": "Namhyung Kim", "email": "namhyung@gmail.com", "time": "Tue Oct 05 00:13:59 2010 +0900" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Oct 28 01:30:01 2010 +0200" }, "message": "jbd: Remove unnecessary goto statement\n\nRemove goto statement which jumps to very next line. Also remove\ntarget label because it is no longer used anywhere.\n\nSigned-off-by: Namhyung Kim \u003cnamhyung@gmail.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "f81e3d4564a06c5a070337ba527d11865acecb67", "tree": "43fb5d4872c64b10421e588ab909c7d9ffcdb7e5", "parents": [ "c5639bef63a241d8d5a00e5243d7f304d7563c46" ], "author": { "name": "Namhyung Kim", "email": "namhyung@gmail.com", "time": "Mon Oct 04 19:12:13 2010 +0900" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Oct 28 01:30:01 2010 +0200" }, "message": "jbd: Use printk_ratelimited() in journal_alloc_journal_head()\n\nUse printk_ratelimited() instead of doing it manually.\n\nSigned-off-by: Namhyung Kim \u003cnamhyung@gmail.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "c5639bef63a241d8d5a00e5243d7f304d7563c46", "tree": "f0db02b256104af545b5da0eb40627b9367f12b4", "parents": [ "26f78b7a423aea094c536e94cbe1f1fa4641dd7b" ], "author": { "name": "Namhyung Kim", "email": "namhyung@gmail.com", "time": "Mon Oct 04 17:26:53 2010 +0900" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Oct 28 01:30:01 2010 +0200" }, "message": "jbd: Move debug message into #ifdef area\n\nMove call to jbd_debug() into #ifdef CONFIG_JBD_DEBUG block because\n\u0027dropped\u0027 is declared there. The code could be compiled without this\nchange anyway, simply because jbd_debug() expands to nothing if\n!CONFIG_JBD_DEBUG but IMHO it doesn\u0027t look good in general.\n\nSigned-off-by: Namhyung Kim \u003cnamhyung@gmail.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "a2887097f25cd38cadfc11d10769e2b349fb5eca", "tree": "cd4adcb305365d6ba9acd2c02d4eb9d0125c6f8d", "parents": [ "8abfc6e7a45eb74e51904bbae676fae008b11366", "005a1d15f5a6b2bb4ada80349513effbf22b4588" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Oct 22 17:07:18 2010 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Oct 22 17:07:18 2010 -0700" }, "message": "Merge branch \u0027for-2.6.37/barrier\u0027 of git://git.kernel.dk/linux-2.6-block\n\n* \u0027for-2.6.37/barrier\u0027 of git://git.kernel.dk/linux-2.6-block: (46 commits)\n xen-blkfront: disable barrier/flush write support\n Added blk-lib.c and blk-barrier.c was renamed to blk-flush.c\n block: remove BLKDEV_IFL_WAIT\n aic7xxx_old: removed unused \u0027req\u0027 variable\n block: remove the BH_Eopnotsupp flag\n block: remove the BLKDEV_IFL_BARRIER flag\n block: remove the WRITE_BARRIER flag\n swap: do not send discards as barriers\n fat: do not send discards as barriers\n ext4: do not send discards as barriers\n jbd2: replace barriers with explicit flush / FUA usage\n jbd2: Modify ASYNC_COMMIT code to not rely on queue draining on barrier\n jbd: replace barriers with explicit flush / FUA usage\n nilfs2: replace barriers with explicit flush / FUA usage\n reiserfs: replace barriers with explicit flush / FUA usage\n gfs2: replace barriers with explicit flush / FUA usage\n btrfs: replace barriers with explicit flush / FUA usage\n xfs: replace barriers with explicit flush / FUA usage\n block: pass gfp_mask and flags to sb_issue_discard\n dm: convey that all flushes are processed as empty\n ...\n" }, { "commit": "749ef9f8423054e326f3a246327ed2db4b6d395f", "tree": "388df763e4e731f5d9b4d8dcaedca641521571e3", "parents": [ "6d0aed7a38d06284db2a0e46c0a072b0c1c3299b" ], "author": { "name": "Corrado Zoccolo", "email": "czoccolo@gmail.com", "time": "Mon Sep 20 15:24:50 2010 +0200" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Mon Sep 20 15:24:50 2010 +0200" }, "message": "cfq: improve fsync performance for small files\n\nFsync performance for small files achieved by cfq on high-end disks is\nlower than what deadline can achieve, due to idling introduced between\nthe sync write happening in process context and the journal commit.\n\nMoreover, when competing with a sequential reader, a process writing\nsmall files and fsync-ing them is starved.\n\nThis patch fixes the two problems by:\n- marking journal commits as WRITE_SYNC, so that they get the REQ_NOIDLE\n flag set,\n- force all queues that have REQ_NOIDLE requests to be put in the noidle\n tree.\n\nHaving the queue associated to the fsync-ing process and the one associated\n to journal commits in the noidle tree allows:\n- switching between them without idling,\n- fairness vs. competing idling queues, since they will be serviced only\n after the noidle tree expires its slice.\n\nAcked-by: Vivek Goyal \u003cvgoyal@redhat.com\u003e\nReviewed-by: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nTested-by: Jeff Moyer \u003cjmoyer@redhat.com\u003e\nSigned-off-by: Corrado Zoccolo \u003cczoccolo@gmail.com\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "4524451ef7e88c64a868a8f5a0b49bda73beb2a3", "tree": "e9bf7e18153216f0a0366d5ae99d0f2cf96d6554", "parents": [ "f8c131f5b6ffc899a70b30e541f367d47f89691c" ], "author": { "name": "Christoph Hellwig", "email": "hch@infradead.org", "time": "Wed Aug 18 05:29:16 2010 -0400" }, "committer": { "name": "Jens Axboe", "email": "jaxboe@fusionio.com", "time": "Fri Sep 10 12:35:39 2010 +0200" }, "message": "jbd: replace barriers with explicit flush / FUA usage\n\nSwitch to the WRITE_FLUSH_FUA flag for journal commits and remove the\nEOPNOTSUPP detection for barriers.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nSigned-off-by: Jens Axboe \u003cjaxboe@fusionio.com\u003e\n" }, { "commit": "9cb569d601e0b93e01c20a22872270ec663b75f6", "tree": "80b2568fae48018806e82f8884062dae8a5494ae", "parents": [ "87e99511ea54510ffb60b98001d108794d5037f8" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Wed Aug 11 17:06:24 2010 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Aug 18 01:09:01 2010 -0400" }, "message": "remove SWRITE* I/O types\n\nThese flags aren\u0027t real I/O types, but tell ll_rw_block to always\nlock the buffer instead of giving up on a failed trylock.\n\nInstead add a new write_dirty_buffer helper that implements this semantic\nand use it from the existing SWRITE* callers. Note that the ll_rw_block\ncode had a bug where it didn\u0027t promote WRITE_SYNC_PLUG properly, which\nthis patch fixes.\n\nIn the ufs code clean up the helper that used to call ll_rw_block\nto mirror sync_dirty_buffer, which is the function it implements for\ncompound buffers.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "87e99511ea54510ffb60b98001d108794d5037f8", "tree": "359228828515e02302d9b259a066a1f1118eba0a", "parents": [ "dad5eb6daa7eeb63d4fc9d982892c59faa07e797" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Wed Aug 11 17:05:45 2010 +0200" }, "committer": { "name": "Al Viro", "email": "viro@zeniv.linux.org.uk", "time": "Wed Aug 18 01:09:00 2010 -0400" }, "message": "kill BH_Ordered flag\n\nInstead of abusing a buffer_head flag just add a variant of\nsync_dirty_buffer which allows passing the exact type of write\nflag required.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Al Viro \u003cviro@zeniv.linux.org.uk\u003e\n" }, { "commit": "0411ba7902e09111d6f2041b4697a597d2cf7736", "tree": "65927286bf15ae9161c3ffd2a0f65bea1e8faa6a", "parents": [ "189eef59e70e3e56edf726864629f310d114eefb" ], "author": { "name": "Andi Kleen", "email": "andi@firstfloor.org", "time": "Thu Jun 10 13:10:53 2010 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Jul 21 16:01:47 2010 +0200" }, "message": "ext3: Fix set but unused variables\n\n[tytso@mit.edu: Fix compilation with CONFIG_JBD_DEBUG enabled]\n\nAcked-by: tytso@mit.edu\ncc: linux-ext4@vger.kernel.org\nSigned-off-by: Andi Kleen \u003cak@linux.intel.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "5277970878a32e437b27296e34c592e5d351f11d", "tree": "64f41152b95e670935192ee6061653d922b642f3", "parents": [ "03f4d804a1b4748885dc4613a4afe10089a731c8" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Apr 15 22:24:26 2010 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Fri May 21 19:30:41 2010 +0200" }, "message": "ext3: Fix waiting on transaction during fsync\n\nlog_start_commit() returns 1 only when it started a transaction\ncommit. Thus in case transaction commit is already running, we\nfail to wait for the commit to finish. Fix the issue by always\nwaiting for the commit regardless of the log_start_commit return\nvalue.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "03f4d804a1b4748885dc4613a4afe10089a731c8", "tree": "f2d7be9a0205496f14d61e6a8fe62277e653fab8", "parents": [ "311b9549ed2bb0f2c2257781c3e88cb00505e80e" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Apr 15 22:16:24 2010 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Fri May 21 19:30:40 2010 +0200" }, "message": "jbd: Provide function to check whether transaction will issue data barrier\n\nProvide a function which returns whether a transaction with given tid\nwill send a barrier to the filesystem device. The function will be used\nby ext3 to detect whether fsync needs to send a separate barrier or not.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "5a0e3ad6af8660be21ca98a971cd00f331318c05", "tree": "5bfb7be11a03176a87296a43ac6647975c00a1d1", "parents": [ "ed391f4ebf8f701d3566423ce8f17e614cde9806" ], "author": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Wed Mar 24 17:04:11 2010 +0900" }, "committer": { "name": "Tejun Heo", "email": "tj@kernel.org", "time": "Tue Mar 30 22:02:32 2010 +0900" }, "message": "include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h\n\npercpu.h is included by sched.h and module.h and thus ends up being\nincluded when building most .c files. percpu.h includes slab.h which\nin turn includes gfp.h making everything defined by the two files\nuniversally available and complicating inclusion dependencies.\n\npercpu.h -\u003e slab.h dependency is about to be removed. Prepare for\nthis change by updating users of gfp and slab facilities include those\nheaders directly instead of assuming availability. As this conversion\nneeds to touch large number of source files, the following script is\nused as the basis of conversion.\n\n http://userweb.kernel.org/~tj/misc/slabh-sweep.py\n\nThe script does the followings.\n\n* Scan files for gfp and slab usages and update includes such that\n only the necessary includes are there. ie. if only gfp is used,\n gfp.h, if slab is used, slab.h.\n\n* When the script inserts a new include, it looks at the include\n blocks and try to put the new include such that its order conforms\n to its surrounding. It\u0027s put in the include block which contains\n core kernel includes, in the same order that the rest are ordered -\n alphabetical, Christmas tree, rev-Xmas-tree or at the end if there\n doesn\u0027t seem to be any matching order.\n\n* If the script can\u0027t find a place to put a new include (mostly\n because the file doesn\u0027t have fitting include block), it prints out\n an error message indicating which .h file needs to be added to the\n file.\n\nThe conversion was done in the following steps.\n\n1. The initial automatic conversion of all .c files updated slightly\n over 4000 files, deleting around 700 includes and adding ~480 gfp.h\n and ~3000 slab.h inclusions. The script emitted errors for ~400\n files.\n\n2. Each error was manually checked. Some didn\u0027t need the inclusion,\n some needed manual addition while adding it to implementation .h or\n embedding .c file was more appropriate for others. This step added\n inclusions to around 150 files.\n\n3. The script was run again and the output was compared to the edits\n from #2 to make sure no file was left behind.\n\n4. Several build tests were done and a couple of problems were fixed.\n e.g. lib/decompress_*.c used malloc/free() wrappers around slab\n APIs requiring slab.h to be added manually.\n\n5. The script was run on all .h files but without automatically\n editing them as sprinkling gfp.h and slab.h inclusions around .h\n files could easily lead to inclusion dependency hell. Most gfp.h\n inclusion directives were ignored as stuff from gfp.h was usually\n wildly available and often used in preprocessor macros. Each\n slab.h inclusion directive was examined and added manually as\n necessary.\n\n6. percpu.h was updated not to include slab.h.\n\n7. Build test were done on the following configurations and failures\n were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my\n distributed build env didn\u0027t work with gcov compiles) and a few\n more options had to be turned off depending on archs to make things\n build (like ipr on powerpc/64 which failed due to missing writeq).\n\n * x86 and x86_64 UP and SMP allmodconfig and a custom test config.\n * powerpc and powerpc64 SMP allmodconfig\n * sparc and sparc64 SMP allmodconfig\n * ia64 SMP allmodconfig\n * s390 SMP allmodconfig\n * alpha SMP allmodconfig\n * um on x86_64 SMP allmodconfig\n\n8. percpu.h modifications were reverted so that it could be applied as\n a separate patch and serve as bisection point.\n\nGiven the fact that I had only a couple of failures from tests on step\n6, I\u0027m fairly confident about the coverage of this conversion patch.\nIf there is a breakage, it\u0027s likely to be something in one of the arch\nheaders which should be easily discoverable easily on most builds of\nthe specific arch.\n\nSigned-off-by: Tejun Heo \u003ctj@kernel.org\u003e\nGuess-its-ok-by: Christoph Lameter \u003ccl@linux-foundation.org\u003e\nCc: Ingo Molnar \u003cmingo@redhat.com\u003e\nCc: Lee Schermerhorn \u003cLee.Schermerhorn@hp.com\u003e\n" }, { "commit": "318ae2edc3b29216abd8a2510f3f80b764f06858", "tree": "ce595adde342f57f379d277b25e4dd206988a052", "parents": [ "25cf84cf377c0aae5dbcf937ea89bc7893db5176", "3e58974027b04e84f68b964ef368a6cd758e2f84" ], "author": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Mon Mar 08 16:55:37 2010 +0100" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Mon Mar 08 16:55:37 2010 +0100" }, "message": "Merge branch \u0027for-next\u0027 into for-linus\n\nConflicts:\n\tDocumentation/filesystems/proc.txt\n\tarch/arm/mach-u300/include/mach/debug-macro.S\n\tdrivers/net/qlge/qlge_ethtool.c\n\tdrivers/net/qlge/qlge_main.c\n\tdrivers/net/typhoon.c\n" }, { "commit": "86963918965eb8fe0c8ae009e7c1b4c630f533d5", "tree": "333371098928c834b0bda0c2fe5bfd591a3806ef", "parents": [ "e5472147e1c0712d95d973acfdbd862957c77add" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue Feb 16 20:37:12 2010 +0100" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Fri Mar 05 00:20:26 2010 +0100" }, "message": "jbd: Delay discarding buffers in journal_unmap_buffer\n\nDelay discarding buffers in journal_unmap_buffer until\nwe know that \"add to orphan\" operation has definitely been\ncommitted, otherwise the log space of committing transation\nmay be freed and reused before truncate get committed, updates\nmay get lost if crash happens.\n\nThis patch is a backport of JBD2 fix by dingdinghua \u003cdingdinghua@nrchpc.ac.cn\u003e.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "3ad2f3fbb961429d2aa627465ae4829758bc7e07", "tree": "f365c513e8f5b477a61336a600ff54f32b7ad6e1", "parents": [ "1537a3638cbf741d3826c1002026cce487a6bee0" ], "author": { "name": "Daniel Mack", "email": "daniel@caiaq.de", "time": "Wed Feb 03 08:01:28 2010 +0800" }, "committer": { "name": "Jiri Kosina", "email": "jkosina@suse.cz", "time": "Tue Feb 09 11:13:56 2010 +0100" }, "message": "tree-wide: Assorted spelling fixes\n\nIn particular, several occurances of funny versions of \u0027success\u0027,\n\u0027unknown\u0027, \u0027therefore\u0027, \u0027acknowledge\u0027, \u0027argument\u0027, \u0027achieve\u0027, \u0027address\u0027,\n\u0027beginning\u0027, \u0027desirable\u0027, \u0027separate\u0027 and \u0027necessary\u0027 are fixed.\n\nSigned-off-by: Daniel Mack \u003cdaniel@caiaq.de\u003e\nCc: Joe Perches \u003cjoe@perches.com\u003e\nCc: Junio C Hamano \u003cgitster@pobox.com\u003e\nSigned-off-by: Jiri Kosina \u003cjkosina@suse.cz\u003e\n" }, { "commit": "765f8361902d015c864d5e62019b2f139452d7ef", "tree": "f872385ae91fc926b036038e583a7f72ab5f3459", "parents": [ "39bc680a8160bb9d6743f7873b535d553ff61058" ], "author": { "name": "Yin Kangkai", "email": "kangkai.yin@intel.com", "time": "Tue Dec 15 14:48:25 2009 -0800" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Dec 23 13:44:13 2009 +0100" }, "message": "jbd: jbd-debug and jbd2-debug should be writable\n\njbd-debug and jbd2-debug is currently read-only (S_IRUGO), which is not\ncorrect. Make it writable so that we can start debuging.\n\nSigned-off-by: Yin Kangkai \u003ckangkai.yin@intel.com\u003e\nReviewed-by: Aneesh Kumar K.V \u003caneesh.kumar@linux.vnet.ibm.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "b6e3224fb20954f155e41ec5709b2ab70b50ae2d", "tree": "96302d1b564c879779b9cc5d7aae7c3c4471ed14", "parents": [ "a2770d86b33024f71df269fde2de096df89d6a48" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Dec 17 13:23:24 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Dec 17 13:23:24 2009 -0800" }, "message": "Revert \"task_struct: make journal_info conditional\"\n\nThis reverts commit e4c570c4cb7a95dbfafa3d016d2739bf3fdfe319, as\nrequested by Alexey:\n\n \"I think I gave a good enough arguments to not merge it.\n To iterate:\n * patch makes impossible to start using ext3 on EXT3_FS\u003dn kernels\n without reboot.\n * this is done only for one pointer on task_struct\"\n\n None of config options which define task_struct are tristate directly\n or effectively.\"\n\nRequested-by: Alexey Dobriyan \u003cadobriyan@gmail.com\u003e\nAcked-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e4c570c4cb7a95dbfafa3d016d2739bf3fdfe319", "tree": "ce2be0a79fa2e8d8271426f0fc27b25e83c050b4", "parents": [ "8420e7efa1cf155765c6d77c91d3e3547c7aa557" ], "author": { "name": "Hiroshi Shimamoto", "email": "h-shimamoto@ct.jp.nec.com", "time": "Mon Dec 14 18:00:26 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Dec 15 08:53:27 2009 -0800" }, "message": "task_struct: make journal_info conditional\n\njournal_info in task_struct is used in journaling file system only. So\nintroduce CONFIG_FS_JOURNAL_INFO and make it conditional.\n\nSigned-off-by: Hiroshi Shimamoto \u003ch-shimamoto@ct.jp.nec.com\u003e\nCc: Chris Mason \u003cchris.mason@oracle.com\u003e\nCc: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nCc: Steven Whitehouse \u003cswhiteho@redhat.com\u003e\nCc: KONISHI Ryusuke \u003ckonishi.ryusuke@lab.ntt.co.jp\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "ff5e4b51a397568c6a2901903c35a4bfaaf752a4", "tree": "ce0561bb54b4bd433cd8797e31817d25235a7c13", "parents": [ "aa021baa3295fa6e3f367d80f8955dd5176656eb" ], "author": { "name": "Stefan Schmidt", "email": "stefan@datenfreihafen.org", "time": "Thu Nov 12 09:53:50 2009 +0100" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Nov 12 10:24:12 2009 +0100" }, "message": "fs/jbd: Export log_start_commit to fix ext3 build.\n\nThis fixes:\nERROR: \"log_start_commit\" [fs/ext3/ext3.ko] undefined!\n\nSigned-off-by: Stefan Schmidt \u003cstefan@datenfreihafen.org\u003e\n" }, { "commit": "7b02bec07efe1d6c7d48c786e0c1a38d28fe7245", "tree": "cb93e26c107052be83ba52a74652c44c3ba199da", "parents": [ "fe8bc91c4c30122b357d197117705cfd4fabaf28" ], "author": { "name": "Tao Ma", "email": "tao.ma@oracle.com", "time": "Tue Nov 10 17:13:22 2009 +0800" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Nov 11 15:24:14 2009 +0100" }, "message": "JBD/JBD2: free j_wbuf if journal init fails.\n\nIf journal init fails, we need to free j_wbuf.\n\nCc: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nCc: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Tao Ma \u003ctao.ma@oracle.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "3adae9da0b35d2ca908039f42a1e90395c335181", "tree": "bc7d971ffb673dab926a4c3d02411a2b78b58f6a", "parents": [ "9c28cbccec66a5ca292c6659bf5a0fe0c8459fa7" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue Aug 11 17:27:21 2009 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Sep 16 17:44:10 2009 +0200" }, "message": "jbd: Annotate transaction start also for journal_restart()\n\nlockdep annotation for a transaction start has been at the end of\njournal_start(). But a transaction is also started from journal_restart(). Move\nthe lockdep annotation to start_this_handle() which covers both cases.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "9c28cbccec66a5ca292c6659bf5a0fe0c8459fa7", "tree": "d43540ca30413ac8b3717e29f15ccbbe789a76c5", "parents": [ "19003c18e9b41f5c3aeb81c92356f90958e1f22f" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Aug 03 19:21:00 2009 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Sep 16 17:44:10 2009 +0200" }, "message": "jbd: Journal block numbers can ever be only 32-bit use unsigned int for them\n\nIt does not make sense to store block number for journal as unsigned long\nsince they can be only 32-bit (because of on-disk format limitation). So\nchange in-memory structures and variables to use unsigned int instead.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "b449fc6fcc07a392c69f3c1db9a4ad4dda8cbcba", "tree": "cc748936233e62cb8ae3325505e84805fb08b5ad", "parents": [ "ab86e5765d41a5eb4239a1c04d613db87bea5ed8" ], "author": { "name": "Andreas Dilger", "email": "adilger@sun.com", "time": "Thu Jul 30 20:09:46 2009 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Sep 16 17:44:10 2009 +0200" }, "message": "JBD: round commit timer up to avoid uncommitted transaction\n\nFix jiffie rounding in jbd commit timer setup code. Rounding down could cause\nthe timer to be fired before the corresponding transaction has expired. That\ntransaction can stay not committed forever if no new transaction is created or\nexplicit sync/umount happens.\n\nSigned-off-by: Andreas Dilger \u003cadilger@sun.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "f1015c447781729060c415f5133164c638561f25", "tree": "3fb03db8dc97bf9037cbdf91b71e28a2bbb8eed3", "parents": [ "43237b5490e8f2f4679decd660064ff35ce490cc" ], "author": { "name": "dingdinghua", "email": "dingdinghua85@gmail.com", "time": "Wed Jul 15 21:42:05 2009 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue Jul 21 11:54:42 2009 +0200" }, "message": "jbd: fix race between write_metadata_buffer and get_write_access\n\nThe function journal_write_metadata_buffer() calls jbd_unlock_bh_state(bh_in)\ntoo early; this could potentially allow another thread to call get_write_access\non the buffer head, modify the data, and dirty it, and allowing the wrong data\nto be written into the journal. Fortunately, if we lose this race, the only\ntime this will actually cause filesystem corruption is if there is a system\ncrash or other unclean shutdown of the system before the next commit can take\nplace.\n\nSigned-off-by: dingdinghua \u003cdingdinghua85@gmail.com\u003e\nAcked-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "1e9fd53b783ea646de3ee09a4574afeb6778d504", "tree": "0b87e9ca83c612a1c3c5b91a359f8604cde48c45", "parents": [ "9eaaa2d5759837402ec5eee13b2a97921808c3eb" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Jun 24 17:31:40 2009 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Jul 15 21:30:07 2009 +0200" }, "message": "jbd: Fix a race between checkpointing code and journal_get_write_access()\n\nThe following race can happen:\n\n CPU1 CPU2\n checkpointing code checks the buffer, adds\n it to an array for writeback\ndo_get_write_access()\n ...\n lock_buffer()\n unlock_buffer()\n flush_batch() submits the buffer for IO\n __jbd_journal_file_buffer()\n\n So a buffer under writeout is returned from do_get_write_access(). Since\nthe filesystem code relies on the fact that journaled buffers cannot be\nwritten out, it does not take the buffer lock and so it can modify buffer\nwhile it is under writeout. That can lead to a filesystem corruption\nif we crash at the right moment. The similar problem can happen with\nthe journal_get_create_access() path.\n We fix the problem by clearing the buffer dirty bit under buffer_lock\neven if the buffer is on BJ_None list. Actually, we clear the dirty bit\nregardless the list the buffer is in and warn about the fact if\nthe buffer is already journalled.\n\nThanks for spotting the problem goes to dingdinghua \u003cdingdinghua85@gmail.com\u003e.\n\nReported-by: dingdinghua \u003cdingdinghua85@gmail.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "7447a668a3860b66b3c9db86fdea91e355ba59ac", "tree": "f27e2c1df19e6558bce053e8ffa12bd121a30947", "parents": [ "e9e961c9a818a2f24711af493b907a8e40a69efc" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Jul 15 20:36:08 2009 +0200" }, "committer": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Jul 15 21:26:23 2009 +0200" }, "message": "jbd: Fail to load a journal if it is too short\n\nDue to on disk corruption, it can happen that journal is too short. Fail\nto load it in such case so that we don\u0027t oops somewhere later.\n\nReported-by: Nageswara R Sastry \u003crnsastry@linux.vnet.ibm.com\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "6f3f1cb21f08fbf757bbbbb0709ee515a7a7c6ad", "tree": "c6874d850ab2347dfeb58ea95a05422880fc0892", "parents": [ "e8ef7aaea79a899be4d7f50e829900c0ce15e52f" ], "author": { "name": "Hisashi Hifumi", "email": "hifumi.hisashi@oss.ntt.co.jp", "time": "Wed Jun 17 16:26:23 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jun 18 13:03:45 2009 -0700" }, "message": "jbd: clean up journal_try_to_free_buffers()\n\nI delete the following patch\n\"commit 3f31fddfa26b7594b44ff2b34f9a04ba409e0f91\nAuthor: Mingming Cao \u003ccmm@us.ibm.com\u003e\nDate: Fri Jul 25 01:46:22 2008 -0700\n\n jbd: fix race between free buffer and commit transaction\n\nThis patch is no longer needed because if race between freeing buffer and\ncommitting transaction functionality occurs and dio gets error, currently\ndio falls back to buffered IO by the following patch.\n\n\tcommit 6ccfa806a9cfbbf1cd43d5b6aa47ef2c0eb518fd\n\tAuthor: Hisashi Hifumi \u003chifumi.hisashi@oss.ntt.co.jp\u003e\n\tDate: Tue Sep 2 14:35:40 2008 -0700\n\n \tVFS: fix dio write returning EIO when try_to_release_page fails\n\nSigned-off-by: Hisashi Hifumi \u003chifumi.hisashi@oss.ntt.co.jp\u003e\nCc: Theodore Tso \u003ctytso@mit.edu\u003e\nCc: Mingming Cao \u003ccmm@us.ibm.com\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a61d90d75d0f9e86432c45b496b4b0fbf0fd03dc", "tree": "85d557e9d67cbad0347c6f12f7a60c474e485f7c", "parents": [ "463aea1a1c49f1a7d4b50656dfd6c8bb33358b1b" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Tue Jun 09 16:26:26 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Tue Jun 09 16:59:03 2009 -0700" }, "message": "jbd: fix race in buffer processing in commit code\n\nIn commit code, we scan buffers attached to a transaction. During this\nscan, we sometimes have to drop j_list_lock and then we recheck whether\nthe journal buffer head didn\u0027t get freed by journal_try_to_free_buffers().\n But checking for buffer_jbd(bh) isn\u0027t enough because a new journal head\ncould get attached to our buffer head. So add a check whether the journal\nhead remained the same and whether it\u0027s still at the same transaction and\nlist.\n\nThis is a nasty bug and can cause problems like memory corruption (use after\nfree) or trigger various assertions in JBD code (observed).\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nCc: \u003cstable@kernel.org\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a4277bf122e907e4fec509fc0bd9bf5fde30b14e", "tree": "b359e8b0f7895acda1d6331332e69ea5b14d5f0d", "parents": [ "6ae85d6db4871d8dbcb5cc0e9056f97f1ca07061", "b5451f7b2694b04d9f912f6cf09db1729f291996" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Apr 24 08:37:40 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Apr 24 08:37:40 2009 -0700" }, "message": "Merge branch \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4\n\n* \u0027for_linus\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4:\n ext4: Fix potential inode allocation soft lockup in Orlov allocator\n ext4: Make the extent validity check more paranoid\n jbd: use SWRITE_SYNC_PLUG when writing synchronous revoke records\n jbd2: use SWRITE_SYNC_PLUG when writing synchronous revoke records\n ext4: really print the find_group_flex fallback warning only once\n" }, { "commit": "38d726d153cfe5efe5fe22d28d36ab382dda3a5c", "tree": "f5403a0abb0ac7e8bbdd12403a70d4151559e778", "parents": [ "67c457a8c378a006a34d92f9bd3078a80a92f250" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Apr 14 10:10:47 2009 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Tue Apr 14 10:10:47 2009 -0400" }, "message": "jbd: use SWRITE_SYNC_PLUG when writing synchronous revoke records\n\nThe revoke records must be written using the same way as the rest of\nthe blocks during the commit process; that is, either marked as\nsynchronous writes or as asynchornous writes.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\n" }, { "commit": "32433879480d13bc019d5a067ce884064a93dd63", "tree": "652230bb84c0d93d06b8ed17049e9a8229283907", "parents": [ "9de100d001564f58c3fb2ec1bd03e540ac0aa357" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Mon Apr 13 14:40:06 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 13 15:04:32 2009 -0700" }, "message": "jbd: update locking coments\n\nUpdate information about locking in JBD revoke code.\n\nReported-by: Lin Tan \u003ctammy000@gmail.com\u003e.\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6c4bac6b3351fd278dc3537dae42f88f733ff12e", "tree": "682fd65d652851a3a67a8994036dfb70be7b93c3", "parents": [ "9cf6b720f84d6999ff9a514d0a939dd183846aaf" ], "author": { "name": "Jens Axboe", "email": "jens.axboe@oracle.com", "time": "Mon Apr 06 14:48:04 2009 +0200" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 06 08:04:53 2009 -0700" }, "message": "jbd: use WRITE_SYNC_PLUG instead of WRITE_SYNC\n\nWhen you are going to be submitting several sync writes, we want to\ngive the IO scheduler a chance to merge some of them. Instead of\nusing the implicitly unplugging WRITE_SYNC variant, use WRITE_SYNC_PLUG\nand rely on sync_buffer() doing the unplug when someone does a\nwait_on_buffer()/lock_buffer().\n\nSigned-off-by: Jens Axboe \u003cjens.axboe@oracle.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "20bec8ab1458c24bed0d5492ee15d87807fc415a", "tree": "e5f910947dbe314b96a591e41e2cfb2d3322caad", "parents": [ "18b34b9546dc192d978dda940673f40928d2e36e", "e7c8f5079ed9ec9e6eb1abe3defc5fb4ebfdf1cb" ], "author": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Apr 03 11:10:33 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Apr 03 11:10:33 2009 -0700" }, "message": "Merge branch \u0027ext3-latency-fixes\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4\n\n* \u0027ext3-latency-fixes\u0027 of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4:\n ext3: Add replace-on-rename hueristics for data\u003dwriteback mode\n ext3: Add replace-on-truncate hueristics for data\u003dwriteback mode\n ext3: Use WRITE_SYNC for commits which are caused by fsync()\n block_write_full_page: Use synchronous writes for WBC_SYNC_ALL writebacks\n" }, { "commit": "ecca9af0a98fdacfcdc73979d08481d7b27ff986", "tree": "41aa40eedd27799b2fa021138173c1adcabe89a5", "parents": [ "039fd8ce6258e01ec29f1637f9bf1868dd877c55" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Thu Apr 02 16:57:13 2009 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Apr 02 19:04:52 2009 -0700" }, "message": "jbd: fix oops in jbd_journal_init_inode() on corrupted fs\n\nOn 32-bit system with CONFIG_LBD getblk can fail because provided block\nnumber is too big. Make JBD gracefully handle that.\n\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nCc: \u003cdmaciejak@fortinet.com\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "512a004382f2c60d5c4f855476ba965adc00250c", "tree": "e0ecfce01aab892a415b95d6d4c8c5a8bd033a49", "parents": [ "a64c8610bd3b753c6aff58f51c04cdf0ae478c18" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Fri Mar 27 22:14:27 2009 -0400" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Fri Mar 27 22:14:27 2009 -0400" }, "message": "ext3: Use WRITE_SYNC for commits which are caused by fsync()\n\nIf a commit is triggered by fsync(), set a flag indicating the journal\nblocks associated with the transaction should be flushed out using\nWRITE_SYNC.\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\n" }, { "commit": "8fe4cd0dc5ea43760c59eb256404188272cc95dd", "tree": "f02892b7393c60b98b51202d868fa12b0a2339e2", "parents": [ "fc3501d411d34823fb9be248a95a0c44f945866f" ], "author": { "name": "Jan Kara", "email": "jack@suse.cz", "time": "Wed Feb 11 13:04:25 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed Feb 11 14:25:35 2009 -0800" }, "message": "jbd: fix return value of journal_start_commit()\n\njournal_start_commit() returns 1 if either a transaction is committing or\nthe function has queued a transaction commit. But it returns 0 if we\nraced with somebody queueing the transaction commit as well. This\nresulted in ext3_sync_fs() not functioning correctly (description from\nArthur Jones): In the case of a data\u003dordered umount with pending long\nsymlinks which are delayed due to a long list of other I/O on the backing\nblock device, this causes the buffer associated with the long symlinks to\nnot be moved to the inode dirty list in the second phase of fsync_super.\nThen, before they can be dirtied again, kjournald exits, seeing the UMOUNT\nflag and the dirty pages are never written to the backing block device,\ncausing long symlink corruption and exposing new or previously freed block\ndata to userspace.\n\nThis can be reproduced with a script created by Eric Sandeen\n\u003csandeen@redhat.com\u003e:\n\n #!/bin/bash\n\n umount /mnt/test2\n mount /dev/sdb4 /mnt/test2\n rm -f /mnt/test2/*\n dd if\u003d/dev/zero of\u003d/mnt/test2/bigfile bs\u003d1M count\u003d512\n touch /mnt/test2/thisisveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryverylongfilename\n ln -s /mnt/test2/thisisveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryverylongfilename\n /mnt/test2/link\n umount /mnt/test2\n mount /dev/sdb4 /mnt/test2\n ls /mnt/test2/\n\nThis patch fixes journal_start_commit() to always return 1 when there\u0027s\na transaction committing or queued for commit.\n\nCc: Eric Sandeen \u003csandeen@redhat.com\u003e\nCc: Mike Snitzer \u003csnitzer@gmail.com\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1579c3a15c06055713b42b077b805f818638302c", "tree": "8898416461b4451f095ea0a426dd8a9d91dfd95d", "parents": [ "04143e2fb9d512c21e1dcfb561dbb0445dcfdc8c" ], "author": { "name": "Randy Dunlap", "email": "randy.dunlap@oracle.com", "time": "Wed Jan 07 18:07:27 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 08 08:31:01 2009 -0800" }, "message": "jbd: remove excess kernel-doc notation\n\nRemove excess kernel-doc from fs/jbd/transaction.c:\n\nWarning(linux-2.6.28-git5//fs/jbd/transaction.c:764): Excess function parameter \u0027credits\u0027 description in \u0027journal_get_write_access\u0027\n\nSigned-off-by: Randy Dunlap \u003crandy.dunlap@oracle.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f420d4dc4272fd223986762df2ad06056ddebada", "tree": "2ae50476e901dc5c2e5d189d44785e27234bcce9", "parents": [ "ef8b646183868b2d042fa6cde0eef2a31263ff85" ], "author": { "name": "Josef Bacik", "email": "jbacik@redhat.com", "time": "Wed Jan 07 18:07:24 2009 -0800" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Jan 08 08:31:00 2009 -0800" }, "message": "jbd: improve fsync batching\n\nThere is a flaw with the way jbd handles fsync batching. If we fsync() a\nfile and we were not the last person to run fsync() on this fs then we\nautomatically sleep for 1 jiffie in order to wait for new writers to join\ninto the transaction before forcing the commit. The problem with this is\nthat with really fast storage (ie a Clariion) the time it takes to commit\na transaction to disk is way faster than 1 jiffie in most cases, so\nsleeping means waiting longer with nothing to do than if we just committed\nthe transaction and kept going. Ric Wheeler noticed this when using\nfs_mark with more than 1 thread, the throughput would plummet as he added\nmore threads.\n\nThis patch attempts to fix this problem by recording the average time in\nnanoseconds that it takes to commit a transaction to disk, and what time\nwe started the transaction. If we run an fsync() and we have been running\nfor less time than it takes to commit the transaction to disk, we sleep\nfor the delta amount of time and then commit to disk. We acheive\nsub-jiffie sleeping using schedule_hrtimeout. This means that the wait\ntime is auto-tuned to the speed of the underlying disk, instead of having\nthis static timeout. I weighted the average according to somebody\u0027s\ncomments (Andreas Dilger I think) in order to help normalize random\noutliers where we take way longer or way less time to commit than the\naverage. I also have a min() check in there to make sure we don\u0027t sleep\nlonger than a jiffie in case our storage is super slow, this was requested\nby Andrew.\n\nI unfortunately do not have access to a Clariion, so I had to use a\nramdisk to represent a super fast array. I tested with a SATA drive with\nbarrier\u003d1 to make sure there was no regression with local disks, I tested\nwith a 4 way multipathed Apple Xserve RAID array and of course the\nramdisk. I ran the following command\n\nfs_mark -d /mnt/ext3-test -s 4096 -n 2000 -D 64 -t $i\n\nwhere $i was 2, 4, 8, 16 and 32. I mkfs\u0027ed the fs each time. Here are my\nresults\n\ntype\tthreads\t\twith patch\twithout patch\nsata\t2\t\t24.6\t\t26.3\nsata\t4\t\t49.2\t\t48.1\nsata\t8\t\t70.1\t\t67.0\nsata\t16\t\t104.0\t\t94.1\nsata\t32\t\t153.6\t\t142.7\n\nxserve\t2\t\t246.4\t\t222.0\nxserve\t4\t\t480.0\t\t440.8\nxserve\t8\t\t829.5\t\t730.8\nxserve\t16\t\t1172.7\t\t1026.9\nxserve\t32\t\t1816.3\t\t1650.5\n\nramdisk\t2\t\t2538.3\t\t1745.6\nramdisk\t4\t\t2942.3\t\t661.9\nramdisk\t8\t\t2882.5\t\t999.8\nramdisk\t16\t\t2738.7\t\t1801.9\nramdisk\t32\t\t2541.9\t\t2394.0\n\nSigned-off-by: Josef Bacik \u003cjbacik@redhat.com\u003e\nCc: Andreas Dilger \u003cadilger@sun.com\u003e\nCc: Arjan van de Ven \u003carjan@infradead.org\u003e\nCc: Ric Wheeler \u003crwheeler@redhat.com\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "e219cca082f52e7dfea41f3be264b7b5eb204227", "tree": "6d67c967064eed255b602626348e78119f84fb8b", "parents": [ "45beca08dd8b6d6a65c5ffd730af2eac7a2c7a03" ], "author": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Thu Nov 06 22:37:59 2008 -0500" }, "committer": { "name": "Theodore Ts\u0027o", "email": "tytso@mit.edu", "time": "Thu Nov 06 22:37:59 2008 -0500" }, "message": "jbd: don\u0027t give up looking for space so easily in __log_wait_for_space\n\nCommit be07c4ed introducd a regression because it assumed that if\nthere were no transactions ready to be checkpointed, that no progress\ncould be made on making space available in the journal, and so the\njournal should be aborted. This assumption is false; it could be the\ncase that simply calling cleanup_journal_tail() will recover the\nnecessary space, or, for small journals, the currently committing\ntransaction could be responsible for chewing up the required space in\nthe log, so we need to wait for the currently committing transaction\nto finish before trying to force a checkpoint operation.\n\nThis patch fixes the bug reported by Meelis Roos at:\nhttp://bugzilla.kernel.org/show_bug.cgi?id\u003d11937\n\nSigned-off-by: \"Theodore Ts\u0027o\" \u003ctytso@mit.edu\u003e\nCc: Duane Griffin \u003cduaneg@dghda.com\u003e\nCc: Toshiyuki Okajima \u003ctoshi.okajima@jp.fujitsu.com\u003e\n" }, { "commit": "e74481e23283fb080d4591c258de20785cc3b6c3", "tree": "bfc5076aa40d62beeba319fdb0fe55ed53f4b335", "parents": [ "e99c97ade53fb6f5e665f2960eb86c624a532d7b" ], "author": { "name": "Randy Dunlap", "email": "randy.dunlap@oracle.com", "time": "Wed Oct 29 14:01:10 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 30 11:38:46 2008 -0700" }, "message": "fs: remove excess kernel-doc\n\nDelete excess kernel-doc notation in fs/ subdirectory:\n\nWarning(linux-2.6.27-git10//fs/jbd/transaction.c:886): Excess function parameter or struct member \u0027credits\u0027 description in \u0027journal_get_undo_access\u0027\n\nSigned-off-by: Randy Dunlap \u003crandy.dunlap@oracle.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "be07c4ed4043ab8c26f222348136141335e47a2f", "tree": "6c9dc77098a4cfe4212091aaecd2350c7b301733", "parents": [ "9f818b4ac04f53458d0354950b4f229f54be4dbf" ], "author": { "name": "Duane Griffin", "email": "duaneg@dghda.com", "time": "Wed Oct 22 14:15:03 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 23 08:55:02 2008 -0700" }, "message": "jbd: abort instead of waiting for nonexistent transactions\n\nThe __log_wait_for_space function sits in a loop checkpointing\ntransactions until there is sufficient space free in the journal.\nHowever, if there are no transactions to be processed (e.g. because the\nfree space calculation is wrong due to a corrupted filesystem) it will\nnever progress.\n\nCheck for space being required when no transactions are outstanding and\nabort the journal instead of endlessly looping.\n\nThis patch fixes the bug reported by Sami Liedes at:\nhttp://bugzilla.kernel.org/show_bug.cgi?id\u003d10976\n\nSigned-off-by: Duane Griffin \u003cduaneg@dghda.com\u003e\nTested-by: Sami Liedes \u003csliedes@cc.hut.fi\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "9f818b4ac04f53458d0354950b4f229f54be4dbf", "tree": "2f70be32757ea6b494e4272b7779950b282ed03c", "parents": [ "2d7c820e56ce83b23daee9eb5343730fb309418e" ], "author": { "name": "Hidehiro Kawai", "email": "hidehiro.kawai.ez@hitachi.com", "time": "Wed Oct 22 14:15:02 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 23 08:55:02 2008 -0700" }, "message": "jbd: test BH_Write_EIO to detect errors on metadata buffers\n\n__try_to_free_cp_buf(), __process_buffer(), and __wait_cp_io() test\nBH_Uptodate flag to detect write I/O errors on metadata buffers. But by\ncommit 95450f5a7e53d5752ce1a0d0b8282e10fe745ae0 \"ext3: don\u0027t read inode\nblock if the buffer has a write error\"(*), BH_Uptodate flag can be set to\ninode buffers with BH_Write_EIO in order to avoid reading old inode data.\nSo now, we have to test BH_Write_EIO flag of checkpointing inode buffers\ninstead of BH_Uptodate. This patch does it.\n\nSigned-off-by: Hidehiro Kawai \u003chidehiro.kawai.ez@hitachi.com\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nAcked-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "4afe978530702c934dfdb11f54073136818b2119", "tree": "5f7fb9539b46c0b390157f55c84017e14b7f605c", "parents": [ "66f50ee3cee4c9d98eea0add6f439e6e5e0ca4a5" ], "author": { "name": "Hidehiro Kawai", "email": "hidehiro.kawai.ez@hitachi.com", "time": "Wed Oct 22 14:15:00 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Thu Oct 23 08:55:01 2008 -0700" }, "message": "jbd: fix error handling for checkpoint io\n\nWhen a checkpointing IO fails, current JBD code doesn\u0027t check the error\nand continue journaling. This means latest metadata can be lost from both\nthe journal and filesystem.\n\nThis patch leaves the failed metadata blocks in the journal space and\naborts journaling in the case of log_do_checkpoint(). To achieve this, we\nneed to do:\n\n1. don\u0027t remove the failed buffer from the checkpoint list where in\n the case of __try_to_free_cp_buf() because it may be released or\n overwritten by a later transaction\n2. log_do_checkpoint() is the last chance, remove the failed buffer\n from the checkpoint list and abort the journal\n3. when checkpointing fails, don\u0027t update the journal super block to\n prevent the journaled contents from being cleaned. For safety,\n don\u0027t update j_tail and j_tail_sequence either\n4. when checkpointing fails, notify this error to the ext3 layer so\n that ext3 don\u0027t clear the needs_recovery flag, otherwise the\n journaled contents are ignored and cleaned in the recovery phase\n5. if the recovery fails, keep the needs_recovery flag\n6. prevent cleanup_journal_tail() from being called between\n __journal_drop_transaction() and journal_abort() (a race issue\n between journal_flush() and __log_wait_for_space()\n\nSigned-off-by: Hidehiro Kawai \u003chidehiro.kawai.ez@hitachi.com\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "6da0b38f4433fb0f24615449d7966471b6e5eae0", "tree": "9f163fbbc7342406bb602de447293c0b11628c6f", "parents": [ "0d468300dc97d6aec084799ffe39253ac366f1e4" ], "author": { "name": "Alexey Dobriyan", "email": "adobriyan@gmail.com", "time": "Mon Oct 20 22:28:45 2008 +0400" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Oct 20 11:43:59 2008 -0700" }, "message": "fs/Kconfig: move ext2, ext3, ext4, JBD, JBD2 out\n\nUse fs/*/Kconfig more, which is good because everything related to one\nfilesystem is in one place and fs/Kconfig is quite fat.\n\nSigned-off-by: Alexey Dobriyan \u003cadobriyan@gmail.com\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "960a22ae60c8a723bd17da3b929fe0bcea6d007e", "tree": "844e3726fb6bdedd433854966e90116eb1d03c99", "parents": [ "0e4fb5e283870757024294bc4567a7c59d936f0b" ], "author": { "name": "Hidehiro Kawai", "email": "hidehiro.kawai.ez@hitachi.com", "time": "Sat Oct 18 20:27:58 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Oct 20 08:52:37 2008 -0700" }, "message": "jbd: ordered data integrity fix\n\nIn ordered mode, if a file data buffer being dirtied exists in the\ncommitting transaction, we write the buffer to the disk, move it from the\ncommitting transaction to the running transaction, then dirty it. But we\ndon\u0027t have to remove the buffer from the committing transaction when the\nbuffer couldn\u0027t be written out, otherwise it would miss the error and the\ncommitting transaction would not abort.\n\nThis patch adds an error check before removing the buffer from the\ncommitting transaction.\n\nSigned-off-by: Hidehiro Kawai \u003chidehiro.kawai.ez@hitachi.com\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "0e4fb5e283870757024294bc4567a7c59d936f0b", "tree": "162263fe9e712124d3df886ca57d8db752a3237d", "parents": [ "46d01a225e694f1a4343beea44f1e85105aedd7e" ], "author": { "name": "Hidehiro Kawai", "email": "hidehiro.kawai.ez@hitachi.com", "time": "Sat Oct 18 20:27:57 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Oct 20 08:52:37 2008 -0700" }, "message": "ext3: add an option to control error handling on file data\n\nIf the journal doesn\u0027t abort when it gets an IO error in file data blocks,\nthe file data corruption will spread silently. Because most of\napplications and commands do buffered writes without fsync(), they don\u0027t\nnotice the IO error. It\u0027s scary for mission critical systems. On the\nother hand, if the journal aborts whenever it gets an IO error in file\ndata blocks, the system will easily become inoperable. So this patch\nintroduces a filesystem option to determine whether it aborts the journal\nor just call printk() when it gets an IO error in file data.\n\nIf you mount a ext3 fs with data_err\u003dabort option, it aborts on file data\nwrite error. If you mount it with data_err\u003dignore, it doesn\u0027t abort, just\ncall printk(). data_err\u003dignore is the default.\n\nSigned-off-by: Hidehiro Kawai \u003chidehiro.kawai.ez@hitachi.com\u003e\nCc: Jan Kara \u003cjack@ucw.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "885e353c7427db7b60692789741b34e605b0b69b", "tree": "9b6787c07b02e7abd41a0db9575d799bcb5eaf3a", "parents": [ "d1645e526a1e5842c9ac433d73419ba886676cf3" ], "author": { "name": "Hidehiro Kawai", "email": "hidehiro.kawai.ez@hitachi.com", "time": "Sat Oct 18 20:27:54 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Oct 20 08:52:37 2008 -0700" }, "message": "jbd: don\u0027t dirty original metadata buffer on abort\n\nCurrently, original metadata buffers are dirtied when they are unfiled\nwhether the journal has aborted or not. Eventually these buffers will be\nwritten-back to the filesystem by pdflush. This means some metadata\nbuffers are written to the filesystem without journaling if the journal\naborts. So if both journal abort and system crash happen at the same\ntime, the filesystem would become inconsistent state. Additionally,\nreplaying journaled metadata can overwrite the latest metadata on the\nfilesystem partly. Because, if the journal aborts, journaled metadata are\npreserved and replayed during the next mount not to lose uncheckpointed\nmetadata. This would also break the consistency of the filesystem.\n\nThis patch prevents original metadata buffers from being dirtied on abort\nby clearing BH_JBDDirty flag from those buffers. Thus, no metadata\nbuffers are written to the filesystem without journaling.\n\nSigned-off-by: Hidehiro Kawai \u003chidehiro.kawai.ez@hitachi.com\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "d1645e526a1e5842c9ac433d73419ba886676cf3", "tree": "daa856759312e60b0fcde672e805ae35da327ece", "parents": [ "60c11d2abf4ef811d0ce3ea34279746729c4c6fc" ], "author": { "name": "Hidehiro Kawai", "email": "hidehiro.kawai.ez@hitachi.com", "time": "Sat Oct 18 20:27:53 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Oct 20 08:52:36 2008 -0700" }, "message": "jbd: abort when failed to log metadata buffers\n\nIf we failed to write metadata buffers to the journal space and succeeded\nto write the commit record, stale data can be written back to the\nfilesystem as metadata in the recovery phase.\n\nTo avoid this, when we failed to write out metadata buffers, abort the\njournal before writing the commit record.\n\nSigned-off-by: Hidehiro Kawai \u003chidehiro.kawai.ez@hitachi.com\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "23a0ee908cbfba3264d19729c67c22b20fa73886", "tree": "541103f6283cbac6b82cff88a7b91128acfce046", "parents": [ "cc7a486cac78f6fc1a24e8cd63036bae8d2ab431", "0f2bc27be27ca1dcc66b96131e44bf7648b959c6" ], "author": { "name": "Ingo Molnar", "email": "mingo@elte.hu", "time": "Tue Aug 12 00:11:49 2008 +0200" }, "committer": { "name": "Ingo Molnar", "email": "mingo@elte.hu", "time": "Tue Aug 12 00:11:49 2008 +0200" }, "message": "Merge branch \u0027core/locking\u0027 into core/urgent\n" }, { "commit": "3295f0ef9ff048a4619ede597ad9ec9cab725654", "tree": "f39a8ecf1958130a0b86c554399d23a65b1c3991", "parents": [ "8bfe0298f7a04952d19f4a2cf510d7a6311eeed0" ], "author": { "name": "Ingo Molnar", "email": "mingo@elte.hu", "time": "Mon Aug 11 10:30:30 2008 +0200" }, "committer": { "name": "Ingo Molnar", "email": "mingo@elte.hu", "time": "Mon Aug 11 10:30:30 2008 +0200" }, "message": "lockdep: rename map_[acquire|release]() \u003d\u003e lock_map_[acquire|release]()\n\nthe names were too generic:\n\n drivers/uio/uio.c:87: error: expected identifier or \u0027(\u0027 before \u0027do\u0027\n drivers/uio/uio.c:87: error: expected identifier or \u0027(\u0027 before \u0027while\u0027\n drivers/uio/uio.c:113: error: \u0027map_release\u0027 undeclared here (not in a function)\n\nSigned-off-by: Ingo Molnar \u003cmingo@elte.hu\u003e\n" }, { "commit": "4f3e7524b2e703d9f8b02ac338153a53dd7ede66", "tree": "0033ade94f230d6044ad318e3791c55ad611069e", "parents": [ "f82b217e3513fe3af342c0f3ee1494e86250c21c" ], "author": { "name": "Peter Zijlstra", "email": "a.p.zijlstra@chello.nl", "time": "Mon Aug 11 09:30:23 2008 +0200" }, "committer": { "name": "Ingo Molnar", "email": "mingo@elte.hu", "time": "Mon Aug 11 09:30:23 2008 +0200" }, "message": "lockdep: map_acquire\n\nMost the free-standing lock_acquire() usages look remarkably similar, sweep\nthem into a new helper.\n\nSigned-off-by: Peter Zijlstra \u003ca.p.zijlstra@chello.nl\u003e\nSigned-off-by: Ingo Molnar \u003cmingo@elte.hu\u003e\n" }, { "commit": "ca5de404ff036a29b25e9a83f6919c9f606c5841", "tree": "474da867c4d4086313cee90cdc3560bb17fade96", "parents": [ "529ae9aaa08378cfe2a4350bded76f32cc8ff0ce" ], "author": { "name": "Nick Piggin", "email": "npiggin@suse.de", "time": "Sat Aug 02 12:02:13 2008 +0200" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Aug 04 21:56:09 2008 -0700" }, "message": "fs: rename buffer trylock\n\nLike the page lock change, this also requires name change, so convert the\nraw test_and_set bitop to a trylock.\n\nSigned-off-by: Nick Piggin \u003cnpiggin@suse.de\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "529ae9aaa08378cfe2a4350bded76f32cc8ff0ce", "tree": "d3ae998f9876c72a83a022805103a92111852b21", "parents": [ "e9ba9698187ddbc0c5bfcf41de0349a662d23d02" ], "author": { "name": "Nick Piggin", "email": "npiggin@suse.de", "time": "Sat Aug 02 12:01:03 2008 +0200" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Aug 04 21:31:34 2008 -0700" }, "message": "mm: rename page trylock\n\nConverting page lock to new locking bitops requires a change of page flag\noperation naming, so we might as well convert it to something nicer\n(!TestSetPageLocked_Lock \u003d\u003e trylock_page, SetPageLocked \u003d\u003e set_page_locked).\n\nThis also facilitates lockdeping of page lock.\n\nSigned-off-by: Nick Piggin \u003cnpiggin@suse.de\u003e\nAcked-by: KOSAKI Motohiro \u003ckosaki.motohiro@jp.fujitsu.com\u003e\nAcked-by: Peter Zijlstra \u003cpeterz@infradead.org\u003e\nAcked-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nAcked-by: Benjamin Herrenschmidt \u003cbenh@kernel.crashing.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "cbe5f466f6995e10a10c7ae66d6dc8608f08a6b8", "tree": "237bbbda6ddd6e38dc7004cd870cbce7af0684c4", "parents": [ "8ef2720397bb813d4985405a5ae7b8ad6474188b" ], "author": { "name": "Hidehiro Kawai", "email": "hidehiro.kawai.ez@hitachi.com", "time": "Fri Jul 25 01:46:30 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Jul 25 10:53:32 2008 -0700" }, "message": "jbd: don\u0027t abort if flushing file data failed\n\nIn ordered mode, the current jbd aborts the journal if a file data buffer\nhas an error. But this behavior is unintended, and we found that it has\nbeen adopted accidentally.\n\nThis patch undoes it and just calls printk() instead of aborting the\njournal. Additionally, set AS_EIO into the address_space object of the\nfailed buffer which is submitted by journal_do_submit_data() so that\nfsync() can get -EIO.\n\nMissing error checkings are also added to inform errors on file data\nbuffers to the user. The following buffers are targeted.\n\n (a) the buffer which has already been written out by pdflush\n (b) the buffer which has been unlocked before scanned in the\n t_locked_list loop\n\n[akpm@linux-foundation.org: improve grammar in a printk]\nSigned-off-by: Hidehiro Kawai \u003chidehiro.kawai.ez@hitachi.com\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "fc80c44277b3c92d808b73e9d40e120229aa4b6a", "tree": "db0848f89305aa3c90b07ad773badc17f858405e", "parents": [ "a10320e8f7c4dcfa050aac566092f29b40458d5a" ], "author": { "name": "Toshiyuki Okajima", "email": "toshi.okajima@jp.fujitsu.com", "time": "Fri Jul 25 01:46:29 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Jul 25 10:53:32 2008 -0700" }, "message": "jbd: positively dispose the unmapped data buffers in journal_commit_transaction()\n\nAfter ext3-ordered files are truncated, there is a possibility that the\npages which cannot be estimated still remain. Remaining pages can be\nreleased when the system has really few memory. So, it is not memory\nleakage. But the resource management software etc. may not work\ncorrectly.\n\nIt is possible that journal_unmap_buffer() cannot release the buffers, and\nthe pages to which they belong because they are attached to a commiting\ntransaction and journal_unmap_buffer() cannot release them. To release\nsuch the buffers and the pages later, journal_unmap_buffer() leaves it to\njournal_commit_transaction(). (journal_unmap_buffer() puts the mark\n\u0027BH_Freed\u0027 to the buffers so that journal_commit_transaction() can\nidentify whether they can be released or not.)\n\nIn the journalled mode and the writeback mode, jbd does with only metadata\nbuffers. But in the ordered mode, jbd does with metadata buffers and also\ndata buffers.\n\nActually, journal_commit_transaction() releases only the metadata buffers\nof which release is demanded by journal_unmap_buffer(), and also releases\nthe pages to which they belong if possible.\n\nAs a result, the data buffers of which release is demanded by\njournal_unmap_buffer() remain after a transaction commits. And also the\npages to which they belong remain.\n\nSuch the remained pages don\u0027t have mapping any longer. Due to this fact,\nthere is a possibility that the pages which cannot be estimated remain.\n\nThe metadata buffers marked \u0027BH_Freed\u0027 and the pages to which\nthey belong can be released at \u0027JBD: commit phase 7\u0027.\n\nTherefore, by applying the same code into \u0027JBD: commit phase 2\u0027 (where the\ndata buffers are done with), journal_commit_transaction() can also release\nthe data buffers marked \u0027BH_Freed\u0027 and the pages to which they belong.\n\nAs a result, all the buffers marked \u0027BH_Freed\u0027 can be released, and also\nall the pages to which these buffers belong can be released at\njournal_commit_transaction(). So, the page which cannot be estimated is\nlost.\n\n\u003c\u003cExcerpt of code at \u0027JBD: commit phase 7\u0027\u003e\u003e\n \u003e spin_lock(\u0026journal-\u003ej_list_lock);\n \u003e while (commit_transaction-\u003et_forget) {\n \u003e transaction_t *cp_transaction;\n \u003e struct buffer_head *bh;\n \u003e\n \u003e jh \u003d commit_transaction-\u003et_forget;\n \u003e...\n \u003e if (buffer_freed(bh)) {\n \u003e ^^^^^^^^^^^^^^^^^^^^^^^^\n \u003e clear_buffer_freed(bh);\n \u003e ^^^^^^^^^^^^^^^^^^^^^^^^\n \u003e clear_buffer_jbddirty(bh);\n \u003e }\n \u003e\n \u003e if (buffer_jbddirty(bh)) {\n \u003e JBUFFER_TRACE(jh, \"add to new checkpointing trans\");\n \u003e __journal_insert_checkpoint(jh, commit_transaction);\n \u003e JBUFFER_TRACE(jh, \"refile for checkpoint writeback\");\n \u003e __journal_refile_buffer(jh);\n \u003e jbd_unlock_bh_state(bh);\n \u003e } else {\n \u003e J_ASSERT_BH(bh, !buffer_dirty(bh));\n \u003e ...\n \u003e JBUFFER_TRACE(jh, \"refile or unfile freed buffer\");\n \u003e __journal_refile_buffer(jh);\n \u003e if (!jh-\u003eb_transaction) {\n \u003e jbd_unlock_bh_state(bh);\n \u003e /* needs a brelse */\n \u003e journal_remove_journal_head(bh);\n \u003e release_buffer_page(bh);\n \u003e ^^^^^^^^^^^^^^^^^^^^^^^^\n \u003e } else\n \u003e }\n****************************************************************\n* Apply the code of \"^^^^^^\" lines into \u0027JBD: commit phase 2\u0027 *\n****************************************************************\n\nAt journal_commit_transaction() code, there is one extra message in the\nseries of jbd debug messages. (\"JBD: commit phase 2\") This patch fixes\nit, too.\n\nSigned-off-by: Toshiyuki Okajima \u003ctoshi.okajima@jp.fujitsu.com\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "a10320e8f7c4dcfa050aac566092f29b40458d5a", "tree": "5ec4dbd114fb5700ba8f0edeea80eea75227d2bc", "parents": [ "3ccc3167b0e5d46ab3bf03e22fbdb7616ce038cd" ], "author": { "name": "Adrian Bunk", "email": "bunk@kernel.org", "time": "Fri Jul 25 01:46:26 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Jul 25 10:53:32 2008 -0700" }, "message": "jbd: unexport journal_update_superblock\n\nRemove the unused EXPORT_SYMBOL(journal_update_superblock).\n\nSigned-off-by: Adrian Bunk \u003cbunk@kernel.org\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3f31fddfa26b7594b44ff2b34f9a04ba409e0f91", "tree": "88994baf22f65dc4da0bef17ce61eda09c59db2a", "parents": [ "9ebfbe9f926553eabc21b4400918d1216b27ed0c" ], "author": { "name": "Mingming Cao", "email": "cmm@us.ibm.com", "time": "Fri Jul 25 01:46:22 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Jul 25 10:53:32 2008 -0700" }, "message": "jbd: fix race between free buffer and commit transaction\n\njournal_try_to_free_buffers() could race with jbd commit transaction when\nthe later is holding the buffer reference while waiting for the data\nbuffer to flush to disk. If the caller of journal_try_to_free_buffers()\nrequest tries hard to release the buffers, it will treat the failure as\nerror and return back to the caller. We have seen the directo IO failed\ndue to this race. Some of the caller of releasepage() also expecting the\nbuffer to be dropped when passed with GFP_KERNEL mask to the\nreleasepage()-\u003ejournal_try_to_free_buffers().\n\nWith this patch, if the caller is passing the __GFP_WAIT and __GFP_FS to\nindicating this call could wait, in case of try_to_free_buffers() failed,\nlet\u0027s waiting for journal_commit_transaction() to finish commit the\ncurrent committing transaction, then try to free those buffers again.\n\n[akpm@linux-foundation.org: coding-style fixes]\nSigned-off-by: Mingming Cao \u003ccmm@us.ibm.com\u003e\nReviewed-by: Badari Pulavarty \u003cpbadari@us.ibm.com\u003e\nAcked-by: Jan Kara \u003cjack@suse.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "1984bb763c2e50d0ebfb0cf56d1b319bd7afe63a", "tree": "dde3d0c06ee054d2d4439e6ac16da831f83a72a7", "parents": [ "f4d79ca2fa211cffc07306eeed7013448e77d7ec" ], "author": { "name": "Duane Griffin", "email": "duaneg@dghda.com", "time": "Fri Jul 25 01:46:21 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Jul 25 10:53:32 2008 -0700" }, "message": "jbd: tidy up revoke cache initialisation and destruction\n\nMake revocation cache destruction safe to call if initialisation fails\npartially or entirely. This allows it to be used to cleanup in the case\nof initialisation failure, simplifying that code slightly.\n\nSigned-off-by: Duane Griffin \u003cduaneg@dghda.com\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "f4d79ca2fa211cffc07306eeed7013448e77d7ec", "tree": "dee0ba9ed8102f5d0bcadc1e93ca7affe2414e8f", "parents": [ "3850f7a521dc17659ef6758a219f083418788490" ], "author": { "name": "Duane Griffin", "email": "duaneg@dghda.com", "time": "Fri Jul 25 01:46:20 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Jul 25 10:53:32 2008 -0700" }, "message": "jbd: eliminate duplicated code in revocation table init/destroy functions\n\nThe revocation table initialisation/destruction code is repeated for each\nof the two revocation tables stored in the journal. Refactoring the\nduplicated code into functions is tidier, simplifies the logic in\ninitialisation in particular, and slightly reduces the code size.\n\nThere should not be any functional change.\n\nSigned-off-by: Duane Griffin \u003cduaneg@dghda.com\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "3850f7a521dc17659ef6758a219f083418788490", "tree": "d576d48a13f4c31aef846dd7f178f3159c38e138", "parents": [ "d06bf1d252fe16f5f0d13e04da7a9913420aa1cf" ], "author": { "name": "Duane Griffin", "email": "duaneg@dghda.com", "time": "Fri Jul 25 01:46:19 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Fri Jul 25 10:53:32 2008 -0700" }, "message": "jbd: replace potentially false assertion with if block\n\nIf an error occurs during jbd cache initialisation it is possible for the\njournal_head_cache to be NULL when journal_destroy_journal_head_cache is\ncalled. Replace the J_ASSERT with an if block to handle the situation\ncorrectly.\n\nNote that even with this fix things will break badly if jbd is statically\ncompiled in and cache initialisation fails.\n\nSigned-off-by: Duane Griffin \u003cduaneg@dghda.com\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "772279c5f1dceb58d451dca94b557fd89b1ce890", "tree": "fa547bae10644896db94514db052443c6d903533", "parents": [ "c3723ca3874a8fc2218c4726d57e3a7da9e83e47" ], "author": { "name": "Mingming Cao", "email": "cmm@us.ibm.com", "time": "Wed May 14 16:05:41 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Wed May 14 19:11:14 2008 -0700" }, "message": "jbd: need to hold j_state_lock to updates to transaction t_state to T_COMMIT\n\nUpdating the current transaction\u0027s t_state is protected by j_state_lock. We\nneed to do the same when updating the t_state to T_COMMIT.\n\nSigned-off-by: Mingming Cao \u003ccmm@us.ibm.com\u003e\nAcked-by: Jan Kara \u003cjack@ucw.cz\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" }, { "commit": "08fc99bfc39d5b394aa27498ac5f14df0ef8e52a", "tree": "3749ce01f8cb60e3cf08c95f3f4076e21ad62ee7", "parents": [ "e05b6b524bd5c5c2bae1b64a7cbe08d46d57a6fe" ], "author": { "name": "Harvey Harrison", "email": "harvey.harrison@gmail.com", "time": "Mon Apr 28 02:16:16 2008 -0700" }, "committer": { "name": "Linus Torvalds", "email": "torvalds@linux-foundation.org", "time": "Mon Apr 28 08:58:45 2008 -0700" }, "message": "jbd: replace remaining __FUNCTION__ occurrences\n\n__FUNCTION__ is gcc-specific, use __func__\n\nSigned-off-by: Harvey Harrison \u003charvey.harrison@gmail.com\u003e\nCc: \u003clinux-ext4@vger.kernel.org\u003e\nSigned-off-by: Andrew Morton \u003cakpm@linux-foundation.org\u003e\nSigned-off-by: Linus Torvalds \u003ctorvalds@linux-foundation.org\u003e\n" } ], "next": "5b9a499d77e9dd39c9e6611ea10c56a31604f274" }