)]}'
{
  "commit": "f6b085b69d1cbbd62f49f34e71a3d58cb6d34b7e",
  "tree": "13d067c1be55a7d87b66ce5920890fcf1f72bcf1",
  "parents": [
    "ee9c5cfad29c8a13199962614b9b16f1c4137ac9"
  ],
  "author": {
    "name": "Jarek Poplawski",
    "email": "jarkao2@gmail.com",
    "time": "Tue Sep 07 07:51:17 2010 +0000"
  },
  "committer": {
    "name": "David S. Miller",
    "email": "davem@davemloft.net",
    "time": "Wed Sep 08 14:14:20 2010 -0700"
  },
  "message": "ipv4: Suppress lockdep-RCU false positive in FIB trie (3)\n\nHi,\nHere is one more of these warnings and a patch below:\n\nSep  5 23:52:33 del kernel: [46044.244833] \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nSep  5 23:52:33 del kernel: [46044.269681] [ INFO: suspicious rcu_dereference_check() usage. ]\nSep  5 23:52:33 del kernel: [46044.277000] ---------------------------------------------------\nSep  5 23:52:33 del kernel: [46044.285185] net/ipv4/fib_trie.c:1756 invoked rcu_dereference_check() without protection!\nSep  5 23:52:33 del kernel: [46044.293627]\nSep  5 23:52:33 del kernel: [46044.293632] other info that might help us debug this:\nSep  5 23:52:33 del kernel: [46044.293634]\nSep  5 23:52:33 del kernel: [46044.325333]\nSep  5 23:52:33 del kernel: [46044.325335] rcu_scheduler_active \u003d 1, debug_locks \u003d 0\nSep  5 23:52:33 del kernel: [46044.348013] 1 lock held by pppd/1717:\nSep  5 23:52:33 del kernel: [46044.357548]  #0:  (rtnl_mutex){+.+.+.}, at: [\u003cc125dc1f\u003e] rtnl_lock+0xf/0x20\nSep  5 23:52:33 del kernel: [46044.367647]\nSep  5 23:52:33 del kernel: [46044.367652] stack backtrace:\nSep  5 23:52:33 del kernel: [46044.387429] Pid: 1717, comm: pppd Not tainted 2.6.35.4.4a #3\nSep  5 23:52:33 del kernel: [46044.398764] Call Trace:\nSep  5 23:52:33 del kernel: [46044.409596]  [\u003cc12f9aba\u003e] ? printk+0x18/0x1e\nSep  5 23:52:33 del kernel: [46044.420761]  [\u003cc1053969\u003e] lockdep_rcu_dereference+0xa9/0xb0\nSep  5 23:52:33 del kernel: [46044.432229]  [\u003cc12b7235\u003e] trie_firstleaf+0x65/0x70\nSep  5 23:52:33 del kernel: [46044.443941]  [\u003cc12b74d4\u003e] fib_table_flush+0x14/0x170\nSep  5 23:52:33 del kernel: [46044.455823]  [\u003cc1033e92\u003e] ? local_bh_enable_ip+0x62/0xd0\nSep  5 23:52:33 del kernel: [46044.467995]  [\u003cc12fc39f\u003e] ? _raw_spin_unlock_bh+0x2f/0x40\nSep  5 23:52:33 del kernel: [46044.480404]  [\u003cc12b24d0\u003e] ? fib_sync_down_dev+0x120/0x180\nSep  5 23:52:33 del kernel: [46044.493025]  [\u003cc12b069d\u003e] fib_flush+0x2d/0x60\nSep  5 23:52:33 del kernel: [46044.505796]  [\u003cc12b06f5\u003e] fib_disable_ip+0x25/0x50\nSep  5 23:52:33 del kernel: [46044.518772]  [\u003cc12b10d3\u003e] fib_netdev_event+0x73/0xd0\nSep  5 23:52:33 del kernel: [46044.531918]  [\u003cc1048dfd\u003e] notifier_call_chain+0x2d/0x70\nSep  5 23:52:33 del kernel: [46044.545358]  [\u003cc1048f0a\u003e] raw_notifier_call_chain+0x1a/0x20\nSep  5 23:52:33 del kernel: [46044.559092]  [\u003cc124f687\u003e] call_netdevice_notifiers+0x27/0x60\nSep  5 23:52:33 del kernel: [46044.573037]  [\u003cc124faec\u003e] __dev_notify_flags+0x5c/0x80\nSep  5 23:52:33 del kernel: [46044.586489]  [\u003cc124fb47\u003e] dev_change_flags+0x37/0x60\nSep  5 23:52:33 del kernel: [46044.599394]  [\u003cc12a8a8d\u003e] devinet_ioctl+0x54d/0x630\nSep  5 23:52:33 del kernel: [46044.612277]  [\u003cc12aabb7\u003e] inet_ioctl+0x97/0xc0\nSep  5 23:52:34 del kernel: [46044.625208]  [\u003cc123f6af\u003e] sock_ioctl+0x6f/0x270\nSep  5 23:52:34 del kernel: [46044.638046]  [\u003cc109d2b0\u003e] ? handle_mm_fault+0x420/0x6c0\nSep  5 23:52:34 del kernel: [46044.650968]  [\u003cc123f640\u003e] ? sock_ioctl+0x0/0x270\nSep  5 23:52:34 del kernel: [46044.663865]  [\u003cc10c3188\u003e] vfs_ioctl+0x28/0xa0\nSep  5 23:52:34 del kernel: [46044.676556]  [\u003cc10c38fa\u003e] do_vfs_ioctl+0x6a/0x5c0\nSep  5 23:52:34 del kernel: [46044.688989]  [\u003cc1048676\u003e] ? up_read+0x16/0x30\nSep  5 23:52:34 del kernel: [46044.701411]  [\u003cc1021376\u003e] ? do_page_fault+0x1d6/0x3a0\nSep  5 23:52:34 del kernel: [46044.714223]  [\u003cc10b6588\u003e] ? fget_light+0xf8/0x2f0\nSep  5 23:52:34 del kernel: [46044.726601]  [\u003cc1241f98\u003e] ? sys_socketcall+0x208/0x2c0\nSep  5 23:52:34 del kernel: [46044.739140]  [\u003cc10c3eb3\u003e] sys_ioctl+0x63/0x70\nSep  5 23:52:34 del kernel: [46044.751967]  [\u003cc12fca3d\u003e] syscall_call+0x7/0xb\nSep  5 23:52:34 del kernel: [46044.764734]  [\u003cc12f0000\u003e] ? cookie_v6_check+0x3d0/0x630\n\n--------------\u003e\n\nThis patch fixes the warning:\n \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n [ INFO: suspicious rcu_dereference_check() usage. ]\n ---------------------------------------------------\n net/ipv4/fib_trie.c:1756 invoked rcu_dereference_check() without protection!\n\n other info that might help us debug this:\n\n rcu_scheduler_active \u003d 1, debug_locks \u003d 0\n 1 lock held by pppd/1717:\n  #0:  (rtnl_mutex){+.+.+.}, at: [\u003cc125dc1f\u003e] rtnl_lock+0xf/0x20\n\n stack backtrace:\n Pid: 1717, comm: pppd Not tainted 2.6.35.4a #3\n Call Trace:\n  [\u003cc12f9aba\u003e] ? printk+0x18/0x1e\n  [\u003cc1053969\u003e] lockdep_rcu_dereference+0xa9/0xb0\n  [\u003cc12b7235\u003e] trie_firstleaf+0x65/0x70\n  [\u003cc12b74d4\u003e] fib_table_flush+0x14/0x170\n  ...\n\nAllow trie_firstleaf() to be called either under rcu_read_lock()\nprotection or with RTNL held. The same annotation is added to\nnode_parent_rcu() to prevent a similar warning a bit later.\n\nFollowup of commits 634a4b20 and 4eaa0e3c.\n\nSigned-off-by: Jarek Poplawski \u003cjarkao2@gmail.com\u003e\nSigned-off-by: David S. Miller \u003cdavem@davemloft.net\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "79d057a939ba6404d4e7553008a2613815a9b049",
      "old_mode": 33188,
      "old_path": "net/ipv4/fib_trie.c",
      "new_id": "4a8e370862bca453cd6e939162ded09de6bdf831",
      "new_mode": 33188,
      "new_path": "net/ipv4/fib_trie.c"
    }
  ]
}
